)]}'
{"doc/source/contributor/manila-review-policy.rst":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2a4951db5bd1ed08712e98f9900892749da337e0","unresolved":false,"context_lines":[{"line_number":83,"context_line":"direction."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"While there is no strict requirement that two core reviewers accepting"},{"line_number":86,"context_line":"a code change have different affiliations. Other things being equal, we will"},{"line_number":87,"context_line":"continue to informally encourage organizational diversity by having core"},{"line_number":88,"context_line":"reviewers from different organizations. Core reviewers have the professional"},{"line_number":89,"context_line":"responsibility of avoiding conflicts of interest."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_ed85d80a","line":86,"updated":"2018-11-30 00:13:11.000000000","message":"I think we should try to avoid the situation where two core reviewers and the patch submitter all have the same affiliation, especially for new features.","commit_id":"39fe5dc0bcbd710fcfc935f4e2c5055c13c17819"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1000916a5eab27208459510432125ec6ab7813d8","unresolved":false,"context_lines":[{"line_number":83,"context_line":"direction."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"While there is no strict requirement that two core reviewers accepting"},{"line_number":86,"context_line":"a code change have different affiliations. Other things being equal, we will"},{"line_number":87,"context_line":"continue to informally encourage organizational diversity by having core"},{"line_number":88,"context_line":"reviewers from different organizations. Core reviewers have the professional"},{"line_number":89,"context_line":"responsibility of avoiding conflicts of interest."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_78f5abc8","line":86,"in_reply_to":"3f79a3b5_ed85d80a","updated":"2018-12-04 21:55:13.000000000","message":"Absolutely agree, Xing - we\u0027ll actively encourage two reviewers from different affiliations reviewing features. While we are relaxing the rest of the conventions we used to follow to move quickly and retain contributors, we will avoid conflicts of interest like the situation you described - a single organization unilaterally merging code.","commit_id":"39fe5dc0bcbd710fcfc935f4e2c5055c13c17819"}],"doc/source/contributor/manila_review_policy.rst":[{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"fcb072564474afc32fb15c73b9fbebfa9d7bf535","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. _manila_review_policy:"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Manila team code review policy"},{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Peer Code Review and the OpenStack Way"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_4bb56618","line":3,"updated":"2018-10-11 22:06:21.000000000","message":"I think each first letter in the words in the title should be capitalized, no?\ni.e.: Manila Team Code Review Policy\n\nAlso, I think each appearance of the word \u0027Manila\u0027 should be with a capital \u0027M\u0027.","commit_id":"94cda5a448bdabeb89f1afe343d79532d17083ce"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"79291bc23bed1d508459a9cf0797077e907484af","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. _manila_review_policy:"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Manila team code review policy"},{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Peer Code Review and the OpenStack Way"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_4c2d6afb","line":3,"in_reply_to":"3f79a3b5_4bb56618","updated":"2018-10-11 23:00:53.000000000","message":"The doc team had general guidance around project names [1]. The sentence casing, I\u0027ve been wildly inconsistent, let me fix this with [2]\n\n[1] https://docs.openstack.org/doc-contrib-guide/writing-style/openstack-components.html\n[2] https://docs.openstack.org/doc-contrib-guide/writing-style/headings.html","commit_id":"94cda5a448bdabeb89f1afe343d79532d17083ce"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"fcb072564474afc32fb15c73b9fbebfa9d7bf535","unresolved":false,"context_lines":[{"line_number":26,"context_line":"upload their code on the `OpenStack Gerrit \u003chttps://review.openstack.org\u003e`_"},{"line_number":27,"context_line":"website. They can then seek reviews by adding individual members of the"},{"line_number":28,"context_line":"`manila core team \u003chttps://review.openstack.org/#/admin/groups/213,"},{"line_number":29,"context_line":"members\u003e`_ or alert the entire core team by inviting the Gerrit Group"},{"line_number":30,"context_line":"\"manila-core\" to the review. Anyone with a membership to the OpenStack"},{"line_number":31,"context_line":"Gerrit system may review the code change. However, only the core team can"},{"line_number":32,"context_line":"accept and merge the code change. Non-core reviews are always welcome."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_2b66eabd","line":29,"range":{"start_line":29,"start_character":64,"end_line":29,"end_character":65},"updated":"2018-10-11 22:06:21.000000000","message":"g","commit_id":"94cda5a448bdabeb89f1afe343d79532d17083ce"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"79291bc23bed1d508459a9cf0797077e907484af","unresolved":false,"context_lines":[{"line_number":26,"context_line":"upload their code on the `OpenStack Gerrit \u003chttps://review.openstack.org\u003e`_"},{"line_number":27,"context_line":"website. They can then seek reviews by adding individual members of the"},{"line_number":28,"context_line":"`manila core team \u003chttps://review.openstack.org/#/admin/groups/213,"},{"line_number":29,"context_line":"members\u003e`_ or alert the entire core team by inviting the Gerrit Group"},{"line_number":30,"context_line":"\"manila-core\" to the review. Anyone with a membership to the OpenStack"},{"line_number":31,"context_line":"Gerrit system may review the code change. However, only the core team can"},{"line_number":32,"context_line":"accept and merge the code change. Non-core reviews are always welcome."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_0ce8d278","line":29,"range":{"start_line":29,"start_character":64,"end_line":29,"end_character":65},"in_reply_to":"3f79a3b5_2b66eabd","updated":"2018-10-11 23:00:53.000000000","message":"Done","commit_id":"94cda5a448bdabeb89f1afe343d79532d17083ce"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"fcb072564474afc32fb15c73b9fbebfa9d7bf535","unresolved":false,"context_lines":[{"line_number":36,"context_line":"One or more core reviewers will take cognizance of the contribution and"},{"line_number":37,"context_line":"provide feedback, or accept the code. For the submission to be accepted, it"},{"line_number":38,"context_line":"will need a minimum of one Code-Review:+2 and one Workflow:+1 votes, along"},{"line_number":39,"context_line":"with passing a Verified:+1 vote from the CI system. If no-one pays attention"},{"line_number":40,"context_line":"to a code submission, feel free to remind the team on #openstack-manila"},{"line_number":41,"context_line":"on irc.freenode.com."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_4bf806c0","line":39,"range":{"start_line":39,"start_character":55,"end_line":39,"end_character":61},"updated":"2018-10-11 22:06:21.000000000","message":"no core member","commit_id":"94cda5a448bdabeb89f1afe343d79532d17083ce"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"79291bc23bed1d508459a9cf0797077e907484af","unresolved":false,"context_lines":[{"line_number":36,"context_line":"One or more core reviewers will take cognizance of the contribution and"},{"line_number":37,"context_line":"provide feedback, or accept the code. For the submission to be accepted, it"},{"line_number":38,"context_line":"will need a minimum of one Code-Review:+2 and one Workflow:+1 votes, along"},{"line_number":39,"context_line":"with passing a Verified:+1 vote from the CI system. If no-one pays attention"},{"line_number":40,"context_line":"to a code submission, feel free to remind the team on #openstack-manila"},{"line_number":41,"context_line":"on irc.freenode.com."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_ccfdfa3b","line":39,"range":{"start_line":39,"start_character":55,"end_line":39,"end_character":61},"in_reply_to":"3f79a3b5_4bf806c0","updated":"2018-10-11 23:00:53.000000000","message":"Done","commit_id":"94cda5a448bdabeb89f1afe343d79532d17083ce"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"fcb072564474afc32fb15c73b9fbebfa9d7bf535","unresolved":false,"context_lines":[{"line_number":37,"context_line":"provide feedback, or accept the code. For the submission to be accepted, it"},{"line_number":38,"context_line":"will need a minimum of one Code-Review:+2 and one Workflow:+1 votes, along"},{"line_number":39,"context_line":"with passing a Verified:+1 vote from the CI system. If no-one pays attention"},{"line_number":40,"context_line":"to a code submission, feel free to remind the team on #openstack-manila"},{"line_number":41,"context_line":"on irc.freenode.com."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Core Code Review guidelines"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_8b1b7e1a","line":40,"range":{"start_line":40,"start_character":54,"end_line":40,"end_character":71},"updated":"2018-10-11 22:06:21.000000000","message":"the #openstack-manila IRC channel","commit_id":"94cda5a448bdabeb89f1afe343d79532d17083ce"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"79291bc23bed1d508459a9cf0797077e907484af","unresolved":false,"context_lines":[{"line_number":37,"context_line":"provide feedback, or accept the code. For the submission to be accepted, it"},{"line_number":38,"context_line":"will need a minimum of one Code-Review:+2 and one Workflow:+1 votes, along"},{"line_number":39,"context_line":"with passing a Verified:+1 vote from the CI system. If no-one pays attention"},{"line_number":40,"context_line":"to a code submission, feel free to remind the team on #openstack-manila"},{"line_number":41,"context_line":"on irc.freenode.com."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Core Code Review guidelines"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_8c8862c3","line":40,"range":{"start_line":40,"start_character":54,"end_line":40,"end_character":71},"in_reply_to":"3f79a3b5_8b1b7e1a","updated":"2018-10-11 23:00:53.000000000","message":"Done","commit_id":"94cda5a448bdabeb89f1afe343d79532d17083ce"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"fcb072564474afc32fb15c73b9fbebfa9d7bf535","unresolved":false,"context_lines":[{"line_number":38,"context_line":"will need a minimum of one Code-Review:+2 and one Workflow:+1 votes, along"},{"line_number":39,"context_line":"with passing a Verified:+1 vote from the CI system. If no-one pays attention"},{"line_number":40,"context_line":"to a code submission, feel free to remind the team on #openstack-manila"},{"line_number":41,"context_line":"on irc.freenode.com."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Core Code Review guidelines"},{"line_number":44,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_4b11e6f7","line":41,"updated":"2018-10-11 22:06:21.000000000","message":"maybe link to https://docs.openstack.org/infra/manual/irc.html or https://docs.openstack.org/contributors/common/irc.html here on in a footnote?","commit_id":"94cda5a448bdabeb89f1afe343d79532d17083ce"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"79291bc23bed1d508459a9cf0797077e907484af","unresolved":false,"context_lines":[{"line_number":38,"context_line":"will need a minimum of one Code-Review:+2 and one Workflow:+1 votes, along"},{"line_number":39,"context_line":"with passing a Verified:+1 vote from the CI system. If no-one pays attention"},{"line_number":40,"context_line":"to a code submission, feel free to remind the team on #openstack-manila"},{"line_number":41,"context_line":"on irc.freenode.com."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Core Code Review guidelines"},{"line_number":44,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_6c8b86c0","line":41,"in_reply_to":"3f79a3b5_4b11e6f7","updated":"2018-10-11 23:00:53.000000000","message":"Sure","commit_id":"94cda5a448bdabeb89f1afe343d79532d17083ce"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"fcb072564474afc32fb15c73b9fbebfa9d7bf535","unresolved":false,"context_lines":[{"line_number":40,"context_line":"to a code submission, feel free to remind the team on #openstack-manila"},{"line_number":41,"context_line":"on irc.freenode.com."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Core Code Review guidelines"},{"line_number":44,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"By convention rather than rule, we require that a minimum of two code"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_ebcf9288","line":43,"range":{"start_line":43,"start_character":17,"end_line":43,"end_character":18},"updated":"2018-10-11 22:06:21.000000000","message":"G","commit_id":"94cda5a448bdabeb89f1afe343d79532d17083ce"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"79291bc23bed1d508459a9cf0797077e907484af","unresolved":false,"context_lines":[{"line_number":40,"context_line":"to a code submission, feel free to remind the team on #openstack-manila"},{"line_number":41,"context_line":"on irc.freenode.com."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Core Code Review guidelines"},{"line_number":44,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"By convention rather than rule, we require that a minimum of two code"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_ecb0f68f","line":43,"range":{"start_line":43,"start_character":17,"end_line":43,"end_character":18},"in_reply_to":"3f79a3b5_ebcf9288","updated":"2018-10-11 23:00:53.000000000","message":"Done","commit_id":"94cda5a448bdabeb89f1afe343d79532d17083ce"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"fcb072564474afc32fb15c73b9fbebfa9d7bf535","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Trivial Changes"},{"line_number":58,"context_line":"---------------"},{"line_number":59,"context_line":"We do not need two core reviewers to approve trivial changes. Trivial changes"},{"line_number":60,"context_line":"are:"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"- Continuous Integration (CI) system break-fixes that are seemingly simple,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_4be6c615","line":59,"updated":"2018-10-11 22:06:21.000000000","message":"IMHO, this paragraph should start with the definition of a trivial change, and finish with what is currently the first sentence (\"We do not need ... trivial changes.\").","commit_id":"94cda5a448bdabeb89f1afe343d79532d17083ce"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"79291bc23bed1d508459a9cf0797077e907484af","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Trivial Changes"},{"line_number":58,"context_line":"---------------"},{"line_number":59,"context_line":"We do not need two core reviewers to approve trivial changes. Trivial changes"},{"line_number":60,"context_line":"are:"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"- Continuous Integration (CI) system break-fixes that are seemingly simple,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_cc709add","line":59,"in_reply_to":"3f79a3b5_4be6c615","updated":"2018-10-11 23:00:53.000000000","message":"Done","commit_id":"94cda5a448bdabeb89f1afe343d79532d17083ce"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"fcb072564474afc32fb15c73b9fbebfa9d7bf535","unresolved":false,"context_lines":[{"line_number":80,"context_line":"affiliation of the core reviewer team as a metric for maturity of the"},{"line_number":81,"context_line":"project. However, since the `Rocky release cycle \u003chttps://anticdent"},{"line_number":82,"context_line":".org/tc-report-18-28.html\u003e`_, the TC has changed its view on the"},{"line_number":83,"context_line":"subject (also see `this change https://review.openstack"},{"line_number":84,"context_line":".org/#/c/579870/`_). We believe this is a step in the right"},{"line_number":85,"context_line":"direction. There is no requirement that two core reviewers"},{"line_number":86,"context_line":"accepting a change have to have different affiliations."},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_cbaf367a","line":84,"range":{"start_line":83,"start_character":9,"end_line":84,"end_character":18},"updated":"2018-10-11 22:06:21.000000000","message":"can this and similar notes be converted into footnotes?","commit_id":"94cda5a448bdabeb89f1afe343d79532d17083ce"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"79291bc23bed1d508459a9cf0797077e907484af","unresolved":false,"context_lines":[{"line_number":80,"context_line":"affiliation of the core reviewer team as a metric for maturity of the"},{"line_number":81,"context_line":"project. However, since the `Rocky release cycle \u003chttps://anticdent"},{"line_number":82,"context_line":".org/tc-report-18-28.html\u003e`_, the TC has changed its view on the"},{"line_number":83,"context_line":"subject (also see `this change https://review.openstack"},{"line_number":84,"context_line":".org/#/c/579870/`_). We believe this is a step in the right"},{"line_number":85,"context_line":"direction. There is no requirement that two core reviewers"},{"line_number":86,"context_line":"accepting a change have to have different affiliations."},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_2c8cae2c","line":84,"range":{"start_line":83,"start_character":9,"end_line":84,"end_character":18},"in_reply_to":"3f79a3b5_cbaf367a","updated":"2018-10-11 23:00:53.000000000","message":"Sure, only these though, easier to click on hyperlinks for the rest of them","commit_id":"94cda5a448bdabeb89f1afe343d79532d17083ce"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"fcb072564474afc32fb15c73b9fbebfa9d7bf535","unresolved":false,"context_lines":[{"line_number":82,"context_line":".org/tc-report-18-28.html\u003e`_, the TC has changed its view on the"},{"line_number":83,"context_line":"subject (also see `this change https://review.openstack"},{"line_number":84,"context_line":".org/#/c/579870/`_). We believe this is a step in the right"},{"line_number":85,"context_line":"direction. There is no requirement that two core reviewers"},{"line_number":86,"context_line":"accepting a change have to have different affiliations."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"We will continue to encourage organizational diversity by having core"},{"line_number":89,"context_line":"reviewers from different organizations."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_eb91d2f8","line":86,"range":{"start_line":85,"start_character":11,"end_line":86,"end_character":54},"updated":"2018-10-11 22:06:21.000000000","message":"While I agree with that statement, I think that the current core team is pretty balanced, so we can still require reviewers with different affiliations.","commit_id":"94cda5a448bdabeb89f1afe343d79532d17083ce"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"79291bc23bed1d508459a9cf0797077e907484af","unresolved":false,"context_lines":[{"line_number":82,"context_line":".org/tc-report-18-28.html\u003e`_, the TC has changed its view on the"},{"line_number":83,"context_line":"subject (also see `this change https://review.openstack"},{"line_number":84,"context_line":".org/#/c/579870/`_). We believe this is a step in the right"},{"line_number":85,"context_line":"direction. There is no requirement that two core reviewers"},{"line_number":86,"context_line":"accepting a change have to have different affiliations."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"We will continue to encourage organizational diversity by having core"},{"line_number":89,"context_line":"reviewers from different organizations."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_8c6dc268","line":86,"range":{"start_line":85,"start_character":11,"end_line":86,"end_character":54},"in_reply_to":"3f79a3b5_eb91d2f8","updated":"2018-10-11 23:00:53.000000000","message":"Hmm, we have as much or more diversity as ever; only for a brief period, we\u0027ve had four core reviewers from a popular storage vendor. We\u0027ve balanced out over time and fixed that anomaly. \n\nHowever, I strongly believe we need to change this since there are far too many times when we request reviewers to weigh-in only to add the \"organizational diversity\" aspect. \n\nI wish we respect individual diversity of opinion: I don\u0027t always agree with Ben Swartzlander or Tom Barron on reviews, but when they have reviewed something and I agree with them, my vote shouldn\u0027t be meaningless because we\u0027re trying to represent \"organizational diversity\". At the same time, if ganso and bswartz want to merge something, they really needn\u0027t wait on Tom Barron and/or Xing Yang (or you, toabctl, me) for an approval. It makes things simpler and move faster.","commit_id":"94cda5a448bdabeb89f1afe343d79532d17083ce"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"e6f9b02fd1c24ec950bd03d5d2af6133f3427e15","unresolved":false,"context_lines":[{"line_number":30,"context_line":"\"manila-core\" to the review. Anyone with a membership to the OpenStack"},{"line_number":31,"context_line":"Gerrit system may review the code change. However, only the core team can"},{"line_number":32,"context_line":"accept and merge the code change. Reviews from contributors outside the core"},{"line_number":33,"context_line":"team are always welcome. Reviewing code meticulously and often is a"},{"line_number":34,"context_line":"pre-requisite for contributors aspiring to join the core reviewer team."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"One or more core reviewers will take cognizance of the contribution and"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_c27c5773","line":33,"range":{"start_line":33,"start_character":5,"end_line":33,"end_character":22},"updated":"2018-10-18 15:17:33.000000000","message":"Suggest: are encouraged!","commit_id":"541a08f274c0f6081e38579e0e0155a224cc268c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9547cf68ce901eae1dbf79af32728a1f2d614259","unresolved":false,"context_lines":[{"line_number":30,"context_line":"\"manila-core\" to the review. Anyone with a membership to the OpenStack"},{"line_number":31,"context_line":"Gerrit system may review the code change. However, only the core team can"},{"line_number":32,"context_line":"accept and merge the code change. Reviews from contributors outside the core"},{"line_number":33,"context_line":"team are always welcome. Reviewing code meticulously and often is a"},{"line_number":34,"context_line":"pre-requisite for contributors aspiring to join the core reviewer team."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"One or more core reviewers will take cognizance of the contribution and"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_202ad196","line":33,"range":{"start_line":33,"start_character":5,"end_line":33,"end_character":22},"in_reply_to":"3f79a3b5_c27c5773","updated":"2018-11-06 00:58:07.000000000","message":"Done","commit_id":"541a08f274c0f6081e38579e0e0155a224cc268c"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"e6f9b02fd1c24ec950bd03d5d2af6133f3427e15","unresolved":false,"context_lines":[{"line_number":58,"context_line":"---------------"},{"line_number":59,"context_line":"Trivial changes are:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"- Continuous Integration (CI) system break-fixes that are seemingly simple,"},{"line_number":62,"context_line":"  i.e.:"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  - No job or test is being deleted"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_02e80f13","line":61,"range":{"start_line":61,"start_character":58,"end_line":61,"end_character":67},"updated":"2018-10-18 15:17:33.000000000","message":"drop \u0027seemingly\u0027.","commit_id":"541a08f274c0f6081e38579e0e0155a224cc268c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9547cf68ce901eae1dbf79af32728a1f2d614259","unresolved":false,"context_lines":[{"line_number":58,"context_line":"---------------"},{"line_number":59,"context_line":"Trivial changes are:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"- Continuous Integration (CI) system break-fixes that are seemingly simple,"},{"line_number":62,"context_line":"  i.e.:"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  - No job or test is being deleted"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_0039d5ef","line":61,"range":{"start_line":61,"start_character":58,"end_line":61,"end_character":67},"in_reply_to":"3f79a3b5_02e80f13","updated":"2018-11-06 00:58:07.000000000","message":"Done","commit_id":"541a08f274c0f6081e38579e0e0155a224cc268c"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"e6f9b02fd1c24ec950bd03d5d2af6133f3427e15","unresolved":false,"context_lines":[{"line_number":82,"context_line":"on the subject [#]_ [#]_. We believe this is a step in the right"},{"line_number":83,"context_line":"direction."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"There is no requirement that two core reviewers accepting a code change have to"},{"line_number":86,"context_line":"have different affiliations. We will continue to encourage organizational"},{"line_number":87,"context_line":"diversity by having core reviewers from different organizations."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Ninja merging"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_c2e537dd","line":87,"range":{"start_line":85,"start_character":0,"end_line":87,"end_character":64},"updated":"2018-10-18 15:17:33.000000000","message":"Suggest: While there is no strict requirement that two core reviewers accepting a code change have different affiliations, other things being equal we will continue to informally encourage organizational diversity by having core reviewers from different organizations.\n\nShould we require diversity when back ends are being reviewed or company business interests might be at stake?","commit_id":"541a08f274c0f6081e38579e0e0155a224cc268c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9547cf68ce901eae1dbf79af32728a1f2d614259","unresolved":false,"context_lines":[{"line_number":82,"context_line":"on the subject [#]_ [#]_. We believe this is a step in the right"},{"line_number":83,"context_line":"direction."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"There is no requirement that two core reviewers accepting a code change have to"},{"line_number":86,"context_line":"have different affiliations. We will continue to encourage organizational"},{"line_number":87,"context_line":"diversity by having core reviewers from different organizations."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Ninja merging"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_2013b16a","line":87,"range":{"start_line":85,"start_character":0,"end_line":87,"end_character":64},"in_reply_to":"3f79a3b5_4d463381","updated":"2018-11-06 00:58:07.000000000","message":"Done","commit_id":"541a08f274c0f6081e38579e0e0155a224cc268c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b157bd7619b9933c44bd60c31ae15f96414399d","unresolved":false,"context_lines":[{"line_number":82,"context_line":"on the subject [#]_ [#]_. We believe this is a step in the right"},{"line_number":83,"context_line":"direction."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"There is no requirement that two core reviewers accepting a code change have to"},{"line_number":86,"context_line":"have different affiliations. We will continue to encourage organizational"},{"line_number":87,"context_line":"diversity by having core reviewers from different organizations."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Ninja merging"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_4d463381","line":87,"range":{"start_line":85,"start_character":0,"end_line":87,"end_character":64},"in_reply_to":"3f79a3b5_c2e537dd","updated":"2018-10-18 21:42:40.000000000","message":"Thanks, I will incorporate as you suggested and add:\n\nCore reviewers have the professional responsibility of avoiding conflicts of interest.","commit_id":"541a08f274c0f6081e38579e0e0155a224cc268c"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"17ffa29a502dcfabf90a9a2d69cae93fda27d6c3","unresolved":false,"context_lines":[{"line_number":87,"context_line":"diversity by having core reviewers from different organizations."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Ninja merging"},{"line_number":91,"context_line":"~~~~~~~~~~~~~"},{"line_number":92,"context_line":"\"Ninja merging\" is a colloquial reference to a core reviewer drafting a"},{"line_number":93,"context_line":"code change, approving and merging the code change themselves,"},{"line_number":94,"context_line":"typically without seeking the review attention of any other reviewers. We do"},{"line_number":95,"context_line":"not encourage ninja merges. However, they are acceptable if a pressing issue"},{"line_number":96,"context_line":"is being resolved, and no other reviewer is available to review the code in"},{"line_number":97,"context_line":"a timely manner."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Vendor code and review"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_55a8ffd8","line":97,"range":{"start_line":90,"start_character":0,"end_line":97,"end_character":16},"updated":"2018-10-18 15:36:25.000000000","message":"The first rule of ninja merging is you don\u0027t talk about ninja merging.\n\nThe moment we enshrine this practice in a document it ceases to be a secret and forbidden thing. Then is just becomes a standard part of the process.","commit_id":"541a08f274c0f6081e38579e0e0155a224cc268c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"c038b157cdb8f0e125dc055e51004c0a89ec5232","unresolved":false,"context_lines":[{"line_number":87,"context_line":"diversity by having core reviewers from different organizations."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Ninja merging"},{"line_number":91,"context_line":"~~~~~~~~~~~~~"},{"line_number":92,"context_line":"\"Ninja merging\" is a colloquial reference to a core reviewer drafting a"},{"line_number":93,"context_line":"code change, approving and merging the code change themselves,"},{"line_number":94,"context_line":"typically without seeking the review attention of any other reviewers. We do"},{"line_number":95,"context_line":"not encourage ninja merges. However, they are acceptable if a pressing issue"},{"line_number":96,"context_line":"is being resolved, and no other reviewer is available to review the code in"},{"line_number":97,"context_line":"a timely manner."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Vendor code and review"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_ce6ec0c7","line":97,"range":{"start_line":90,"start_character":0,"end_line":97,"end_character":16},"in_reply_to":"3f79a3b5_55a8ffd8","updated":"2018-10-18 17:44:42.000000000","message":"-1. I don\u0027t think it is a secret. It is something that everybody knows about and avoids. We are just making it clear why we avoid it.","commit_id":"541a08f274c0f6081e38579e0e0155a224cc268c"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"a415c913768a33be33f71af7f841e2294750f765","unresolved":false,"context_lines":[{"line_number":87,"context_line":"diversity by having core reviewers from different organizations."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Ninja merging"},{"line_number":91,"context_line":"~~~~~~~~~~~~~"},{"line_number":92,"context_line":"\"Ninja merging\" is a colloquial reference to a core reviewer drafting a"},{"line_number":93,"context_line":"code change, approving and merging the code change themselves,"},{"line_number":94,"context_line":"typically without seeking the review attention of any other reviewers. We do"},{"line_number":95,"context_line":"not encourage ninja merges. However, they are acceptable if a pressing issue"},{"line_number":96,"context_line":"is being resolved, and no other reviewer is available to review the code in"},{"line_number":97,"context_line":"a timely manner."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Vendor code and review"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_c70c6c46","line":97,"range":{"start_line":90,"start_character":0,"end_line":97,"end_character":16},"in_reply_to":"3f79a3b5_ad50272e","updated":"2018-10-31 19:00:12.000000000","message":"I think the rules do forbid ninja merging. We require two +2 (from cores other than the author) to merge a change. Ninja merging always violates this rule.\n\nThe point is that rules always have exceptions, and ninja merging is one way we put the exception process into practice. You typically don\u0027t write down the exceptions to the rules in the rules, because then the exceptions become rules themselves.\n\nThe bar I set for myself is \"Is there a single person that would disagree with my merging this patch by myself? If not, then I do it.\" It requires good judgement to make the right call, and tt only works when there\u0027s mutual trust. If trust breaks down to the point where we need to write down the exceptions to the rules, then there is a deeper problem.","commit_id":"541a08f274c0f6081e38579e0e0155a224cc268c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5a7e67ca1b756995afa5e60826b8c95ca5b02487","unresolved":false,"context_lines":[{"line_number":87,"context_line":"diversity by having core reviewers from different organizations."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Ninja merging"},{"line_number":91,"context_line":"~~~~~~~~~~~~~"},{"line_number":92,"context_line":"\"Ninja merging\" is a colloquial reference to a core reviewer drafting a"},{"line_number":93,"context_line":"code change, approving and merging the code change themselves,"},{"line_number":94,"context_line":"typically without seeking the review attention of any other reviewers. We do"},{"line_number":95,"context_line":"not encourage ninja merges. However, they are acceptable if a pressing issue"},{"line_number":96,"context_line":"is being resolved, and no other reviewer is available to review the code in"},{"line_number":97,"context_line":"a timely manner."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Vendor code and review"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_60a4494d","line":97,"range":{"start_line":90,"start_character":0,"end_line":97,"end_character":16},"in_reply_to":"3f79a3b5_c70c6c46","updated":"2018-11-01 21:37:24.000000000","message":"Hmm, I see your point, I\u0027ll drop the \"ninja merging\" stanza altogether - glad we talked this one over, and there\u0027s history of our meeting chat [1] and this review to know what our stance is, we don\u0027t need to take this to the DevRef\n\n[1] http://eavesdrop.openstack.org/meetings/manila/2018/manila.2018-10-18-15.00.log.txt","commit_id":"541a08f274c0f6081e38579e0e0155a224cc268c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b157bd7619b9933c44bd60c31ae15f96414399d","unresolved":false,"context_lines":[{"line_number":87,"context_line":"diversity by having core reviewers from different organizations."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Ninja merging"},{"line_number":91,"context_line":"~~~~~~~~~~~~~"},{"line_number":92,"context_line":"\"Ninja merging\" is a colloquial reference to a core reviewer drafting a"},{"line_number":93,"context_line":"code change, approving and merging the code change themselves,"},{"line_number":94,"context_line":"typically without seeking the review attention of any other reviewers. We do"},{"line_number":95,"context_line":"not encourage ninja merges. However, they are acceptable if a pressing issue"},{"line_number":96,"context_line":"is being resolved, and no other reviewer is available to review the code in"},{"line_number":97,"context_line":"a timely manner."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Vendor code and review"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_ad50272e","line":97,"range":{"start_line":90,"start_character":0,"end_line":97,"end_character":16},"in_reply_to":"3f79a3b5_ce6ec0c7","updated":"2018-10-18 21:42:40.000000000","message":"If it remains unspoken, how else will we tell ourselves that it only ought to be forbidden? I\u0027m thinking of the transparency aspect of our review process to other contributors besides the core reviewers..","commit_id":"541a08f274c0f6081e38579e0e0155a224cc268c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3034fd9a8465e15b42054c02553761596c6b1506","unresolved":false,"context_lines":[{"line_number":102,"context_line":"All code in the manila repositories is open-source and anyone can submit"},{"line_number":103,"context_line":"changes to these repositories as long as they seek to improve the code base."},{"line_number":104,"context_line":"Manila supports over 30 vendor storage systems, and many of these vendors"},{"line_number":105,"context_line":"participate in the development and maintenance of their drivers. To the"},{"line_number":106,"context_line":"extent possible, core reviewers will seek out driver maintainer feedback on"},{"line_number":107,"context_line":"code changes pertaining to vendor integrations."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_266d8998","line":106,"range":{"start_line":105,"start_character":65,"end_line":106,"end_character":15},"updated":"2018-10-13 19:22:49.000000000","message":"this is a bit vague and could be different from person to person. Also, to avoid creating a rule that may not apply on all instances, how about:\n\n\"Core reviewers will always seek out driver maintainer feedback on code changes pertaining to vendor integrations. If  there is no successful contact with the given driver maintainer for one month, the core team will decide in a weekly meeting how to proceed.\"","commit_id":"541a08f274c0f6081e38579e0e0155a224cc268c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"44175390f7f8729e4dc94f45014db556b5bcaf3a","unresolved":false,"context_lines":[{"line_number":102,"context_line":"All code in the manila repositories is open-source and anyone can submit"},{"line_number":103,"context_line":"changes to these repositories as long as they seek to improve the code base."},{"line_number":104,"context_line":"Manila supports over 30 vendor storage systems, and many of these vendors"},{"line_number":105,"context_line":"participate in the development and maintenance of their drivers. To the"},{"line_number":106,"context_line":"extent possible, core reviewers will seek out driver maintainer feedback on"},{"line_number":107,"context_line":"code changes pertaining to vendor integrations."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_7e653748","line":106,"range":{"start_line":105,"start_character":65,"end_line":106,"end_character":15},"in_reply_to":"3f79a3b5_1b4a1f82","updated":"2018-10-15 13:18:15.000000000","message":"I had the understanding that we wanted to make changes to the current process, as we had that etherpad and weekly meeting discussion as well.\n\nI understand your point, and I would like to ask you about a certain scenario. The scenario I was depicting is where you actually have the reviewer caring less about third party drivers. In summary \"if the driver maintainer is not participating, or is nowhere to be found, we don\u0027t merge it\", so it is one less thing to worry about. What I would like to ask is about another scenario. When a distro has a customer that is using a device from vendor X. If there is a bug in X driver but the driver maintainer is nowhere to be found, I assume that the customer would still like the distro to fix the bug and deploy it, correct?\n\nAlso, regarding participation, I actually see the proposal as discouraging 3rd party participation. If the core reviewers can fix the bug and merge it for the 3rd parties without requiring them to be around, they will probably care less about being around to fix their own stuff. If it remains broken until they show up, at some point a customer will ping them about fixing the bug, so they will need to get involved and participate, and perhaps they will even stumble on a test gap to fix and help improving there as well.","commit_id":"541a08f274c0f6081e38579e0e0155a224cc268c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a076f39981981b2bd847d13bd65b0cbc7c0e0236","unresolved":false,"context_lines":[{"line_number":102,"context_line":"All code in the manila repositories is open-source and anyone can submit"},{"line_number":103,"context_line":"changes to these repositories as long as they seek to improve the code base."},{"line_number":104,"context_line":"Manila supports over 30 vendor storage systems, and many of these vendors"},{"line_number":105,"context_line":"participate in the development and maintenance of their drivers. To the"},{"line_number":106,"context_line":"extent possible, core reviewers will seek out driver maintainer feedback on"},{"line_number":107,"context_line":"code changes pertaining to vendor integrations."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_1b4a1f82","line":106,"range":{"start_line":105,"start_character":65,"end_line":106,"end_character":15},"in_reply_to":"3f79a3b5_266d8998","updated":"2018-10-14 18:48:52.000000000","message":"Hmm, I\u0027m seeking to document the process as is currently for this one, because it came up during the PTG. \n\n \n\nYour suggestion puts the onus on the reviewers, and that is wrong - reviewers can try to nudge vendor reps in the community by adding them to the review or pinging them on irc - but \"always seek out driver maintainers... wait for a month... bring it up in a weekly meeting\" seems backwards for open source code, it should not be the responsibility of any reviewer to chase vendors, it really ought to be the other way round if vendors are concerned their code needs to work like they envision, always. \n\n \n\nAlso, this is why third-party CI is important, if reviewers feel like they\u0027ve given vendors enough time to react to a code change, and their CI is working and passing the change, I don\u0027t see a problem with merging the code.","commit_id":"541a08f274c0f6081e38579e0e0155a224cc268c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d5be1ed68e78ac89d9a4601532f1c23bbf037b68","unresolved":false,"context_lines":[{"line_number":102,"context_line":"All code in the manila repositories is open-source and anyone can submit"},{"line_number":103,"context_line":"changes to these repositories as long as they seek to improve the code base."},{"line_number":104,"context_line":"Manila supports over 30 vendor storage systems, and many of these vendors"},{"line_number":105,"context_line":"participate in the development and maintenance of their drivers. To the"},{"line_number":106,"context_line":"extent possible, core reviewers will seek out driver maintainer feedback on"},{"line_number":107,"context_line":"code changes pertaining to vendor integrations."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_933fe4dd","line":106,"range":{"start_line":105,"start_character":65,"end_line":106,"end_character":15},"in_reply_to":"3f79a3b5_7e653748","updated":"2018-10-15 17:38:34.000000000","message":"\u003e I had the understanding that we wanted to make changes to the current process, as we had that etherpad and weekly meeting discussion as well.\n\nfor this specific point? I\u0027m only seeking to clarify based off on our conversation that overlapped two separate discussions at the PTG - regarding reviews from vendors and \"proactive back ports\" - the latter still needs to be addressed, but the same point was raised during that discussion - that vendor back ports must not be workflow-ed without the vendor approving them. So, I\u0027m just rehashing our existing policy in this matter. \n\n \n\n\u003e if the driver maintainer is not participating, or is nowhere to be found, we don\u0027t merge it\n\nNo, I would want to merge anything that improves our code base. We adopted a policy that we won\u0027t kick out vendor driver code unless we really need to, so on a needs-it basis, we can still merge code changes to vendor code even if the vendor has stepped away/is not paying attention, \n\n \n\n\u003e When a distro has a customer that is using a device from vendor X. If there is a bug in X driver but the driver maintainer is nowhere to be found, I assume that the customer would still like the distro to fix the bug and deploy it, correct?\n\nYes, likely.\n\n \n\n\u003e Also, regarding participation, I actually see the proposal as discouraging 3rd party participation. If the core reviewers can fix the bug and merge it for the 3rd parties without requiring them to be around, they will probably care less about being around to fix their own stuff. If it remains broken until they show up, at some point a customer will ping them about fixing the bug, so they will need to get involved and participate, and perhaps they will even stumble on a test gap to fix and help improving there as well.\n\nWe really can\u0027t lure/motivate vendors that are no longer interested by not merging code fixes IMHO. We\u0027ll do what\u0027s best for the project, that is, take the code fix and run with it if we can reasonably determine that it works. How do you want me to frame it to be less discouraging to third party/vendors? You know that isn\u0027t my intention - on the contrary, it is to encourage everyone - vendors, users, hobbyists, wayward contributors, newcomers to contribute and keep the project healthy.\n\nAssume in theory that we have someone new to the community (or an end user) fixing AwesomeStorageX\u0027s code, but AwesomeStorageX has no interest responding to a core reviewer requests, but we have a policy that we wait for a long time or never merge the code fix - it disappoints the contributor and discourages them from contributing to the project. We don\u0027t want that to happen...","commit_id":"541a08f274c0f6081e38579e0e0155a224cc268c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"57b0c610593867e4a410aedaea20029bccc108f4","unresolved":false,"context_lines":[{"line_number":102,"context_line":"All code in the manila repositories is open-source and anyone can submit"},{"line_number":103,"context_line":"changes to these repositories as long as they seek to improve the code base."},{"line_number":104,"context_line":"Manila supports over 30 vendor storage systems, and many of these vendors"},{"line_number":105,"context_line":"participate in the development and maintenance of their drivers. To the"},{"line_number":106,"context_line":"extent possible, core reviewers will seek out driver maintainer feedback on"},{"line_number":107,"context_line":"code changes pertaining to vendor integrations."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_c5ab536e","line":106,"range":{"start_line":105,"start_character":65,"end_line":106,"end_character":15},"in_reply_to":"3f79a3b5_933fe4dd","updated":"2018-10-15 18:07:13.000000000","message":"\u003e \u003e if the driver maintainer is not participating, or is nowhere to\n \u003e be found, we don\u0027t merge it\n \u003e \n \u003e No, I would want to merge anything that improves our code base. We\n \u003e adopted a policy that we won\u0027t kick out vendor driver code unless\n \u003e we really need to, so on a needs-it basis, we can still merge code\n \u003e changes to vendor code even if the vendor has stepped away/is not\n \u003e paying attention,\n \u003e \n\nThis was just an example, my original proposal includes a timeout.\n\n \u003e \n \u003e Assume in theory that we have someone new to the community (or an\n \u003e end user) fixing AwesomeStorageX\u0027s code, but AwesomeStorageX has no\n \u003e interest responding to a core reviewer requests, but we have a\n \u003e policy that we wait for a long time or never merge the code fix -\n \u003e it disappoints the contributor and discourages them from\n \u003e contributing to the project. We don\u0027t want that to happen...\n\n\nExactly. We can discuss how long is \"a long time\", but I believe we should decide and make it explicit in the rules to avoid subjectiveness on \"To the extent possible\" or \"wait some time before merging\". If 1 month is too long, we could do 1 week + email on ML, etc.","commit_id":"541a08f274c0f6081e38579e0e0155a224cc268c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"40f52598f449f93e9335cc1c55c35879c3f2df7a","unresolved":false,"context_lines":[{"line_number":102,"context_line":"All code in the manila repositories is open-source and anyone can submit"},{"line_number":103,"context_line":"changes to these repositories as long as they seek to improve the code base."},{"line_number":104,"context_line":"Manila supports over 30 vendor storage systems, and many of these vendors"},{"line_number":105,"context_line":"participate in the development and maintenance of their drivers. To the"},{"line_number":106,"context_line":"extent possible, core reviewers will seek out driver maintainer feedback on"},{"line_number":107,"context_line":"code changes pertaining to vendor integrations."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_28969ef0","line":106,"range":{"start_line":105,"start_character":65,"end_line":106,"end_character":15},"in_reply_to":"3f79a3b5_c5ab536e","updated":"2018-10-15 19:17:26.000000000","message":"Rodrigo: I strongly disagree about adding any further reviewer burden. Let each of the core reviewers decide how best to approach this situation. My own personal view: I\u0027ll add a vendor driver author/maintainer to review and actively reach out to them on IRC if I think the code\u0027s controversial - if the review stagnates for a while despite multiple nudges, I\u0027ll take a call and merge it. I personally hate seeing things un-acked for over a week, so that\u0027s my personal time-out. We already check third-party CI and re-invoke it a bunch of times if it doesn\u0027t pass right away. I don\u0027t think any further burden is warranted. Also remember, if the fix is controversial, it will require two reviewers take a look at it anyway. \n\nI\u0027d also remind you that this is the way other projects in OpenStack deal with vendor code: Nova, Cinder - I don\u0027t believe we need to be different in this regard. I learned this the hard way a couple of times in Cinder when I was a vendor driver maintainer but understood that the reviewers always had what\u0027s best for the project in their mind.","commit_id":"541a08f274c0f6081e38579e0e0155a224cc268c"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"238586cb5ee1dafd582fd5d3c65d36af7faaec3f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"repositories (openstack/manila-image-elements, openstack/manila-specs,"},{"line_number":23,"context_line":"openstack/manila-tempest-plugin, openstack/manila-test-image,"},{"line_number":24,"context_line":"openstack/manila-ui and openstack/python-manilaclient), contributors need to"},{"line_number":25,"context_line":"follow the `Code Submission Process \u003cgerrit\u003e`_ and"},{"line_number":26,"context_line":"upload their code on the `OpenStack Gerrit \u003chttps://review.openstack.org\u003e`_"},{"line_number":27,"context_line":"website. They can then seek reviews by adding individual members of the"},{"line_number":28,"context_line":"`manila core team \u003chttps://review.openstack.org/#/admin/groups/213,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_0fe6a84a","line":25,"range":{"start_line":25,"start_character":11,"end_line":25,"end_character":46},"updated":"2018-11-05 17:58:00.000000000","message":"Did you find the missing link?","commit_id":"8fde0241a95a5b5480ab40a8df2812e6a93a4a57"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9547cf68ce901eae1dbf79af32728a1f2d614259","unresolved":false,"context_lines":[{"line_number":22,"context_line":"repositories (openstack/manila-image-elements, openstack/manila-specs,"},{"line_number":23,"context_line":"openstack/manila-tempest-plugin, openstack/manila-test-image,"},{"line_number":24,"context_line":"openstack/manila-ui and openstack/python-manilaclient), contributors need to"},{"line_number":25,"context_line":"follow the `Code Submission Process \u003cgerrit\u003e`_ and"},{"line_number":26,"context_line":"upload their code on the `OpenStack Gerrit \u003chttps://review.openstack.org\u003e`_"},{"line_number":27,"context_line":"website. They can then seek reviews by adding individual members of the"},{"line_number":28,"context_line":"`manila core team \u003chttps://review.openstack.org/#/admin/groups/213,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_3e1630a3","line":25,"range":{"start_line":25,"start_character":11,"end_line":25,"end_character":46},"in_reply_to":"3f79a3b5_0fe6a84a","updated":"2018-11-06 00:58:07.000000000","message":"thanks, bad syntax - but I\u0027m unable to use the :doc: directive for some reason.","commit_id":"8fde0241a95a5b5480ab40a8df2812e6a93a4a57"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"238586cb5ee1dafd582fd5d3c65d36af7faaec3f","unresolved":false,"context_lines":[{"line_number":97,"context_line":"extent possible, core reviewers will seek out driver maintainer feedback on"},{"line_number":98,"context_line":"code changes pertaining to vendor integrations."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":".. [#] Getting started with IRC: https://docs.openstack.org/contributors/common/irc.html"},{"line_number":102,"context_line":".. [#] IRC guidelines: https://docs.openstack.org/infra/manual/irc.html"},{"line_number":103,"context_line":".. [#] TC Report 18-28: https://anticdent.org/tc-report-18-28.html"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_cfa750bb","line":100,"updated":"2018-11-05 17:58:00.000000000","message":"It would be good to have a References header here.","commit_id":"8fde0241a95a5b5480ab40a8df2812e6a93a4a57"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9547cf68ce901eae1dbf79af32728a1f2d614259","unresolved":false,"context_lines":[{"line_number":97,"context_line":"extent possible, core reviewers will seek out driver maintainer feedback on"},{"line_number":98,"context_line":"code changes pertaining to vendor integrations."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":".. [#] Getting started with IRC: https://docs.openstack.org/contributors/common/irc.html"},{"line_number":102,"context_line":".. [#] IRC guidelines: https://docs.openstack.org/infra/manual/irc.html"},{"line_number":103,"context_line":".. [#] TC Report 18-28: https://anticdent.org/tc-report-18-28.html"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_5e820ca8","line":100,"in_reply_to":"3f79a3b5_cfa750bb","updated":"2018-11-06 00:58:07.000000000","message":"Done","commit_id":"8fde0241a95a5b5480ab40a8df2812e6a93a4a57"}]}