)]}'
{"manila/network/linux/interface.py":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"557fa839e45ba750a2754f273736556fca966953","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                \u0027external-ids:attached-mac\u003d%s\u0027 % mac_address]"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        LOG.debug(\"_ovs_add_port - running command: %s\", cmd)"},{"line_number":133,"context_line":"        utils.execute(*cmd, run_as_root\u003dTrue)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    @device_name_synchronized"},{"line_number":136,"context_line":"    def plug(self, device_name, port_id, mac_address,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f769fc5_159a6c6d","line":133,"updated":"2019-01-02 15:02:39.000000000","message":"this is calling processutils.execute() from oslo.concurrency and it accepts a loglevel parameter which can be set to logging.DEBUG . Maybe we should set the loglevel directly in manila/utils.py:execute() ?","commit_id":"eb9d26a4c5860e60b60350a8d07f1665e8314bbf"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"8e77a59a6bc5729c93331f9f7e1cb50f08aee87b","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                \u0027external-ids:attached-mac\u003d%s\u0027 % mac_address]"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        LOG.debug(\"_ovs_add_port - running command: %s\", cmd)"},{"line_number":133,"context_line":"        utils.execute(*cmd, run_as_root\u003dTrue)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    @device_name_synchronized"},{"line_number":136,"context_line":"    def plug(self, device_name, port_id, mac_address,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f769fc5_ba9b60c7","line":133,"in_reply_to":"1f769fc5_159a6c6d","updated":"2019-01-02 18:20:18.000000000","message":"Good idea, will try it.","commit_id":"eb9d26a4c5860e60b60350a8d07f1665e8314bbf"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"61cd14386c154f7efda25cc22cda614c2a6395bf","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                \u0027--\u0027, \u0027set\u0027, \u0027Interface\u0027, device_name,"},{"line_number":130,"context_line":"                \u0027external-ids:attached-mac\u003d%s\u0027 % mac_address]"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        LOG.debug(\"_ovs_add_port - running command: %s\", cmd)"},{"line_number":133,"context_line":"        utils.execute(*cmd, run_as_root\u003dTrue)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    @device_name_synchronized"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_1a2a948f","line":132,"updated":"2019-01-02 19:10:36.000000000","message":"this is not needed because utils.execute() now adds a log entry with the command line parameters (via processutils.execute)","commit_id":"e5a2b3b3b8474b4b509fac032c46c6391e37006b"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"968b71621bed59b413e212ed66a4d4d4b3c2ff8a","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                \u0027--\u0027, \u0027set\u0027, \u0027Interface\u0027, device_name,"},{"line_number":130,"context_line":"                \u0027external-ids:attached-mac\u003d%s\u0027 % mac_address]"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        LOG.debug(\"_ovs_add_port - running command: %s\", cmd)"},{"line_number":133,"context_line":"        utils.execute(*cmd, run_as_root\u003dTrue)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    @device_name_synchronized"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_18937cfc","line":132,"in_reply_to":"1f769fc5_1a2a948f","updated":"2019-01-02 21:16:41.000000000","message":"Agree.","commit_id":"e5a2b3b3b8474b4b509fac032c46c6391e37006b"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"62323c7874f25dae7701e15de83f3ae7f8ee7e87","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                \u0027external-ids:iface-status\u003dactive\u0027,"},{"line_number":129,"context_line":"                \u0027--\u0027, \u0027set\u0027, \u0027Interface\u0027, device_name,"},{"line_number":130,"context_line":"                \u0027external-ids:attached-mac\u003d%s\u0027 % mac_address]"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        utils.execute(*cmd, run_as_root\u003dTrue)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @device_name_synchronized"}],"source_content_type":"text/x-python","patch_set":5,"id":"ffd0ebdf_cdc49a43","line":131,"updated":"2019-01-03 15:05:16.000000000","message":"nit: newline not needed","commit_id":"39251882744de0e661a767c568d5a4c0fc005c25"}],"manila/share/drivers/service_instance.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"63e8b01b653816b4fdabcfa6dc1ae63d146c8278","unresolved":false,"context_lines":[{"line_number":949,"context_line":"        and setting up required network devices."},{"line_number":950,"context_line":"        \"\"\""},{"line_number":951,"context_line":"        if self.use_service_network:"},{"line_number":952,"context_line":"            LOG.debug(\"Plugging service instance into service network.\")"},{"line_number":953,"context_line":"            port \u003d self._get_service_port("},{"line_number":954,"context_line":"                self.service_network_id, None, \u0027manila-share\u0027)"},{"line_number":955,"context_line":"            port \u003d self._add_fixed_ips_to_service_port(port)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f769fc5_92b53f34","line":952,"range":{"start_line":952,"start_character":11,"end_line":952,"end_character":72},"updated":"2018-12-31 13:43:39.000000000","message":"it would be better to use some IDs here","commit_id":"c234b5bd8484ba567731494aad1cea8f9ea415ec"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"e0e0f03992658f359cb8ada230b8eefa455455e0","unresolved":false,"context_lines":[{"line_number":949,"context_line":"        and setting up required network devices."},{"line_number":950,"context_line":"        \"\"\""},{"line_number":951,"context_line":"        if self.use_service_network:"},{"line_number":952,"context_line":"            LOG.debug(\"Plugging service instance into service network.\")"},{"line_number":953,"context_line":"            port \u003d self._get_service_port("},{"line_number":954,"context_line":"                self.service_network_id, None, \u0027manila-share\u0027)"},{"line_number":955,"context_line":"            port \u003d self._add_fixed_ips_to_service_port(port)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f769fc5_928e9f76","line":952,"range":{"start_line":952,"start_character":11,"end_line":952,"end_character":72},"in_reply_to":"1f769fc5_92b53f34","updated":"2018-12-31 13:55:44.000000000","message":"Sure, good idea.","commit_id":"c234b5bd8484ba567731494aad1cea8f9ea415ec"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"63e8b01b653816b4fdabcfa6dc1ae63d146c8278","unresolved":false,"context_lines":[{"line_number":958,"context_line":"            self._plug_interface_in_host(interface_name, device, port)"},{"line_number":959,"context_line":""},{"line_number":960,"context_line":"        if self.use_admin_port:"},{"line_number":961,"context_line":"            LOG.debug(\"Plugging service instance into admin network.\")"},{"line_number":962,"context_line":"            port \u003d self._get_service_port("},{"line_number":963,"context_line":"                self.admin_network_id, self.admin_subnet_id,"},{"line_number":964,"context_line":"                \u0027manila-admin-share\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f769fc5_32846b5e","line":961,"range":{"start_line":961,"start_character":11,"end_line":961,"end_character":70},"updated":"2018-12-31 13:43:39.000000000","message":"same as above","commit_id":"c234b5bd8484ba567731494aad1cea8f9ea415ec"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"e0e0f03992658f359cb8ada230b8eefa455455e0","unresolved":false,"context_lines":[{"line_number":958,"context_line":"            self._plug_interface_in_host(interface_name, device, port)"},{"line_number":959,"context_line":""},{"line_number":960,"context_line":"        if self.use_admin_port:"},{"line_number":961,"context_line":"            LOG.debug(\"Plugging service instance into admin network.\")"},{"line_number":962,"context_line":"            port \u003d self._get_service_port("},{"line_number":963,"context_line":"                self.admin_network_id, self.admin_subnet_id,"},{"line_number":964,"context_line":"                \u0027manila-admin-share\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f769fc5_32e9cb19","line":961,"range":{"start_line":961,"start_character":11,"end_line":961,"end_character":70},"in_reply_to":"1f769fc5_32846b5e","updated":"2018-12-31 13:55:44.000000000","message":"Yup.","commit_id":"c234b5bd8484ba567731494aad1cea8f9ea415ec"}]}