)]}'
{"doc/source/admin/shared-file-systems-share-replication.rst":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"fd34d97976f059bc3ee97b5b58c0551f308bb749","unresolved":false,"context_lines":[{"line_number":600,"context_line":"   use the :command:`manila delete` command to remove the share."},{"line_number":601,"context_line":""},{"line_number":602,"context_line":""},{"line_number":603,"context_line":".. [1] When running in a multi-backend configuration, until the Queens"},{"line_number":604,"context_line":"       release, deployers could only configure one Availability Zone per manila"},{"line_number":605,"context_line":"       configuration file. This is achieved with the option"},{"line_number":606,"context_line":"       ``storage_availability_zone`` defined under the ``[DEFAULT]`` section."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9fdfeff1_cbf21207","line":603,"updated":"2019-01-23 09:14:30.000000000","message":"Queens? Should be Stein I guess.","commit_id":"e6c72c116e2a37af27e6b0c97ef221d49d0ba8bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8543598ac71c7d463a418e3e36939cb9f25cc1ef","unresolved":false,"context_lines":[{"line_number":600,"context_line":"   use the :command:`manila delete` command to remove the share."},{"line_number":601,"context_line":""},{"line_number":602,"context_line":""},{"line_number":603,"context_line":".. [1] When running in a multi-backend configuration, until the Queens"},{"line_number":604,"context_line":"       release, deployers could only configure one Availability Zone per manila"},{"line_number":605,"context_line":"       configuration file. This is achieved with the option"},{"line_number":606,"context_line":"       ``storage_availability_zone`` defined under the ``[DEFAULT]`` section."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9fdfeff1_e4637bb0","line":603,"in_reply_to":"9fdfeff1_cbf21207","updated":"2019-01-23 17:11:10.000000000","message":"you\u0027re right :)","commit_id":"e6c72c116e2a37af27e6b0c97ef221d49d0ba8bb"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"fd34d97976f059bc3ee97b5b58c0551f308bb749","unresolved":false,"context_lines":[{"line_number":605,"context_line":"       configuration file. This is achieved with the option"},{"line_number":606,"context_line":"       ``storage_availability_zone`` defined under the ``[DEFAULT]`` section."},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"       Beyond the Queens release, the option ``backend_availability_zone``"},{"line_number":609,"context_line":"       can be specified in each back end stanza. The value of this"},{"line_number":610,"context_line":"       configuration option will override any configuration of the"},{"line_number":611,"context_line":"       ``storage_availability_zone`` from the ``[DEFAULT]`` section."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9fdfeff1_8bdc0a75","line":608,"updated":"2019-01-23 09:14:30.000000000","message":"Stein instead of Queens","commit_id":"e6c72c116e2a37af27e6b0c97ef221d49d0ba8bb"}],"manila/service.py":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"fd34d97976f059bc3ee97b5b58c0551f308bb749","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        self.manager \u003d manager_class(host\u003dself.host,"},{"line_number":93,"context_line":"                                     service_name\u003dservice_name,"},{"line_number":94,"context_line":"                                     *args, **kwargs)"},{"line_number":95,"context_line":"        self.availability_zone \u003d self.manager.availability_zone"},{"line_number":96,"context_line":"        self.report_interval \u003d report_interval"},{"line_number":97,"context_line":"        self.periodic_interval \u003d periodic_interval"},{"line_number":98,"context_line":"        self.periodic_fuzzy_delay \u003d periodic_fuzzy_delay"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_ebd03653","line":95,"updated":"2019-01-23 09:14:30.000000000","message":"Why do we need that? Later you use  once self.manager.availability_zone and twice self.availability_zone . I would just use self.manager.availability_zone everywhere","commit_id":"e6c72c116e2a37af27e6b0c97ef221d49d0ba8bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8543598ac71c7d463a418e3e36939cb9f25cc1ef","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        self.manager \u003d manager_class(host\u003dself.host,"},{"line_number":93,"context_line":"                                     service_name\u003dservice_name,"},{"line_number":94,"context_line":"                                     *args, **kwargs)"},{"line_number":95,"context_line":"        self.availability_zone \u003d self.manager.availability_zone"},{"line_number":96,"context_line":"        self.report_interval \u003d report_interval"},{"line_number":97,"context_line":"        self.periodic_interval \u003d periodic_interval"},{"line_number":98,"context_line":"        self.periodic_fuzzy_delay \u003d periodic_fuzzy_delay"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_c460b7a8","line":95,"in_reply_to":"9fdfeff1_ebd03653","updated":"2019-01-23 17:11:10.000000000","message":"Thanks, I will reuse this variable below...","commit_id":"e6c72c116e2a37af27e6b0c97ef221d49d0ba8bb"}],"manila/share/driver.py":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"fd34d97976f059bc3ee97b5b58c0551f308bb749","unresolved":false,"context_lines":[{"line_number":126,"context_line":"             \"replication between each other. If this option is not \""},{"line_number":127,"context_line":"             \"specified in the group, it means that replication is not \""},{"line_number":128,"context_line":"             \"enabled on the backend.\"),"},{"line_number":129,"context_line":"    cfg.StrOpt(\u0027backend_availability_zone\u0027,"},{"line_number":130,"context_line":"               default\u003dNone,"},{"line_number":131,"context_line":"               help\u003d\u0027Availability zone for this share backend. If not set, \u0027"},{"line_number":132,"context_line":"                    \u0027the ``storage_availability_zone`` option from the \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_cd5465cd","line":129,"updated":"2019-01-23 09:14:30.000000000","message":"Not sure if that would work (and also not sure if that would be in any way better - just thinking loud), but couldn\u0027t we use the name `storage_availability_zone` here and add a deprecated_group\u003d\"DEFAULT\" to have a fall back?","commit_id":"e6c72c116e2a37af27e6b0c97ef221d49d0ba8bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8543598ac71c7d463a418e3e36939cb9f25cc1ef","unresolved":false,"context_lines":[{"line_number":126,"context_line":"             \"replication between each other. If this option is not \""},{"line_number":127,"context_line":"             \"specified in the group, it means that replication is not \""},{"line_number":128,"context_line":"             \"enabled on the backend.\"),"},{"line_number":129,"context_line":"    cfg.StrOpt(\u0027backend_availability_zone\u0027,"},{"line_number":130,"context_line":"               default\u003dNone,"},{"line_number":131,"context_line":"               help\u003d\u0027Availability zone for this share backend. If not set, \u0027"},{"line_number":132,"context_line":"                    \u0027the ``storage_availability_zone`` option from the \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_e4d5bb44","line":129,"in_reply_to":"9fdfeff1_cd5465cd","updated":"2019-01-23 17:11:10.000000000","message":"I tried going down that path, we can use \"deprecated_group\" and retain the opt name \"storage_availability_zone\" here, but:\n\n- We don\u0027t intend on removing support for \"storage_availability_zone\" in the [DEFAULT] section, which will be used for services other than the share manager service as well (scheduler, data)\n- We\u0027ll confuse tooling: configuration documentation generator, puppet etc if we were to accept simultaneous configuration for the opt \"storage_availability_zone\" in [DEFAULT] and [ *backend* ] sections","commit_id":"e6c72c116e2a37af27e6b0c97ef221d49d0ba8bb"}]}