)]}'
{"manila/share/drivers/dell_emc/plugins/unity/client.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"16a752ed5cb5703be77796fe9802f115c7fb45d9","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        return None"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def restore_snapshot(self, snap_name):"},{"line_number":343,"context_line":"        snap \u003d self.get_snapshot(snap_name)"},{"line_number":344,"context_line":"        return snap.restore(delete_backup\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_67bd66b6","line":343,"range":{"start_line":343,"start_character":20,"end_line":343,"end_character":43},"updated":"2019-01-14 11:31:33.000000000","message":"Maybe get rid of the get_snapshot method at line 334, use the one at 226, and LOG.the not found warning inside restore_snapshot?","commit_id":"fc127de0f2b9966f123c89cc8d07725fa7746478"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"0e3694058a2099414b1cd5e8fe1aa925793b3b4f","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        return None"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def restore_snapshot(self, snap_name):"},{"line_number":343,"context_line":"        snap \u003d self.get_snapshot(snap_name)"},{"line_number":344,"context_line":"        return snap.restore(delete_backup\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_67c0d87c","line":343,"range":{"start_line":343,"start_character":20,"end_line":343,"end_character":43},"in_reply_to":"bfdaf3ff_67bd66b6","updated":"2019-01-16 07:19:12.000000000","message":"Fixed. Removed the duplicated get_snapshot method at line 334, and used the one at 226, no need to LOG the exception. Thanks for the reminder, Tom.","commit_id":"fc127de0f2b9966f123c89cc8d07725fa7746478"}],"manila/tests/share/drivers/dell_emc/plugins/unity/test_client.py":[{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"e14ad73cb793e1a2f34ff3e20f95012f33696f44","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        self.assertEqual(\u0027snapshot_1\u0027, snapshot.id)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    @res_mock.patch_client"},{"line_number":241,"context_line":"    def test_restore_snapshot(self, client):"},{"line_number":242,"context_line":"        snap_name \u003d \u0027Snapshot_1\u0027"},{"line_number":243,"context_line":"        rst \u003d client.restore_snapshot(snap_name)"},{"line_number":244,"context_line":"        self.assertIs(True, rst)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfdaf3ff_d3d622c4","line":241,"range":{"start_line":241,"start_character":8,"end_line":241,"end_character":29},"updated":"2019-01-16 12:11:56.000000000","message":"Can you mock the \"snap\" object within restore_snapshot and see that you\u0027re actually calling it\u0027s \"restore\" method?\n\nFor example:\nhttps://github.com/openstack/manila/blob/master/manila/tests/share/drivers/infinidat/test_infinidat.py#L599\n\n(In the referenced code, see how the mock object is created)","commit_id":"05930c19b3b61f68a12af7af6a46642592808e28"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"83b15f327fec7fb0871b0390f12d47fde1b996c4","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        self.assertEqual(\u0027snapshot_1\u0027, snapshot.id)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    @res_mock.patch_client"},{"line_number":241,"context_line":"    def test_restore_snapshot(self, client):"},{"line_number":242,"context_line":"        snap_name \u003d \u0027Snapshot_1\u0027"},{"line_number":243,"context_line":"        rst \u003d client.restore_snapshot(snap_name)"},{"line_number":244,"context_line":"        self.assertIs(True, rst)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfdaf3ff_e54cae9f","line":241,"range":{"start_line":241,"start_character":8,"end_line":241,"end_character":29},"in_reply_to":"bfdaf3ff_d3d622c4","updated":"2019-01-17 02:32:06.000000000","message":"Fixed, thanks for the comment.","commit_id":"05930c19b3b61f68a12af7af6a46642592808e28"}]}
