)]}'
{"manila/share/drivers/ganesha/manager.py":[{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"cb593aea7b346bddb1e451e85cb937bcb12da8be","unresolved":false,"context_lines":[{"line_number":481,"context_line":"            else:"},{"line_number":482,"context_line":"                _mkindex_called \u003d True"},{"line_number":483,"context_line":"                self._mkindex()"},{"line_number":484,"context_line":"        except exception.ProcessExecutionError as e:"},{"line_number":485,"context_line":"            for u in undos:"},{"line_number":486,"context_line":"                u()"},{"line_number":487,"context_line":"            if not self.ganesha_rados_store_enable and not _mkindex_called:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_5cf8b379","line":484,"range":{"start_line":484,"start_character":15,"end_line":484,"end_character":46},"updated":"2019-01-30 07:19:35.000000000","message":"Please see L#240 in this file. Unless I\u0027m missing something here, all exception.ProcessExecutionError exceptions in this object are translated into exception.GaneshaCommandFailure, so this except clause will always be skipped.","commit_id":"f6613f95533180c957ab98e6ba51ea5ac9e1a706"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"5768b7faa60b165bd808b443de3248b3a652c215","unresolved":false,"context_lines":[{"line_number":481,"context_line":"            else:"},{"line_number":482,"context_line":"                _mkindex_called \u003d True"},{"line_number":483,"context_line":"                self._mkindex()"},{"line_number":484,"context_line":"        except exception.ProcessExecutionError as e:"},{"line_number":485,"context_line":"            for u in undos:"},{"line_number":486,"context_line":"                u()"},{"line_number":487,"context_line":"            if not self.ganesha_rados_store_enable and not _mkindex_called:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_c21b5e7e","line":484,"range":{"start_line":484,"start_character":15,"end_line":484,"end_character":46},"in_reply_to":"9fdfeff1_5cf8b379","updated":"2019-01-30 10:06:57.000000000","message":"I think you are right that they will all be translated but GaneshaCommandFailure is a subclass of ProcessExecutionError so I think they\u0027ll still get caught.  Do you think it will be clearer to use GaneshaCommandFailure here?","commit_id":"f6613f95533180c957ab98e6ba51ea5ac9e1a706"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"7e69e82689bb4d14212457cd17ce6ff20f653682","unresolved":false,"context_lines":[{"line_number":481,"context_line":"            else:"},{"line_number":482,"context_line":"                _mkindex_called \u003d True"},{"line_number":483,"context_line":"                self._mkindex()"},{"line_number":484,"context_line":"        except exception.ProcessExecutionError as e:"},{"line_number":485,"context_line":"            for u in undos:"},{"line_number":486,"context_line":"                u()"},{"line_number":487,"context_line":"            if not self.ganesha_rados_store_enable and not _mkindex_called:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_ec19b479","line":484,"range":{"start_line":484,"start_character":15,"end_line":484,"end_character":46},"in_reply_to":"9fdfeff1_c21b5e7e","updated":"2019-01-30 12:25:35.000000000","message":"Oh OK, so I did miss the subclassing part. I guess it\u0027s OK then.","commit_id":"f6613f95533180c957ab98e6ba51ea5ac9e1a706"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"cb593aea7b346bddb1e451e85cb937bcb12da8be","unresolved":false,"context_lines":[{"line_number":499,"context_line":"        try:"},{"line_number":500,"context_line":"            self._dbus_send_ganesha(\"UpdateExport\", \"string:\" + path,"},{"line_number":501,"context_line":"                                    \"string:EXPORT(Export_Id\u003d%d)\" % xid)"},{"line_number":502,"context_line":"        except exception.ProcessExecutionError as e:"},{"line_number":503,"context_line":"            # Revert the export update."},{"line_number":504,"context_line":"            self._write_export(name, old_confdict)"},{"line_number":505,"context_line":"            raise exception.GaneshaCommandFailure("}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_bc2c3f02","line":502,"range":{"start_line":502,"start_character":15,"end_line":502,"end_character":46},"updated":"2019-01-30 07:19:35.000000000","message":"Same comment.","commit_id":"f6613f95533180c957ab98e6ba51ea5ac9e1a706"}]}