)]}'
{"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f261869e79dff51ad48f48b918b7d799521b035f","unresolved":false,"context_lines":[{"line_number":1759,"context_line":""},{"line_number":1760,"context_line":"    @na_utils.trace"},{"line_number":1761,"context_line":"    def rename_vserver(self, vserver_name, new_vserver_name):"},{"line_number":1762,"context_line":"        \"\"\"Renames a vserver.\"\"\""},{"line_number":1763,"context_line":"        api_args \u003d {"},{"line_number":1764,"context_line":"            \u0027vserver-name\u0027: vserver_name,"},{"line_number":1765,"context_line":"            \u0027new-name\u0027: new_vserver_name,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_c5bb300c","line":1762,"range":{"start_line":1762,"start_character":11,"end_line":1762,"end_character":18},"updated":"2019-03-01 07:56:00.000000000","message":"nit: Rename\n\nconsistency","commit_id":"d94a092c0076ea051b9d1b08faf256907d0d5a37"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e67535a7b44dbfddc71d7bba3fc5c72669f94dab","unresolved":false,"context_lines":[{"line_number":1759,"context_line":""},{"line_number":1760,"context_line":"    @na_utils.trace"},{"line_number":1761,"context_line":"    def rename_vserver(self, vserver_name, new_vserver_name):"},{"line_number":1762,"context_line":"        \"\"\"Renames a vserver.\"\"\""},{"line_number":1763,"context_line":"        api_args \u003d {"},{"line_number":1764,"context_line":"            \u0027vserver-name\u0027: vserver_name,"},{"line_number":1765,"context_line":"            \u0027new-name\u0027: new_vserver_name,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_7d1d2c71","line":1762,"range":{"start_line":1762,"start_character":11,"end_line":1762,"end_character":18},"in_reply_to":"9fdfeff1_c5bb300c","updated":"2019-03-01 17:59:50.000000000","message":"Done","commit_id":"d94a092c0076ea051b9d1b08faf256907d0d5a37"}],"manila/share/drivers/netapp/dataontap/cluster_mode/drv_multi_svm.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f261869e79dff51ad48f48b918b7d799521b035f","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    def manage_existing_with_server("},{"line_number":87,"context_line":"            self, share, driver_options, share_server\u003dNone):"},{"line_number":88,"context_line":"        return self.library.manage_existing("},{"line_number":89,"context_line":"            share, driver_options, share_server)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def unmanage_with_server(self, share, share_server\u003dNone):"},{"line_number":92,"context_line":"        self.library.unmanage(share, share_server)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_455660d0","line":89,"range":{"start_line":89,"start_character":35,"end_line":89,"end_character":47},"updated":"2019-03-01 07:56:00.000000000","message":"pass kwargs ask kwargs.. here and below","commit_id":"d94a092c0076ea051b9d1b08faf256907d0d5a37"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e67535a7b44dbfddc71d7bba3fc5c72669f94dab","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    def manage_existing_with_server("},{"line_number":87,"context_line":"            self, share, driver_options, share_server\u003dNone):"},{"line_number":88,"context_line":"        return self.library.manage_existing("},{"line_number":89,"context_line":"            share, driver_options, share_server)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def unmanage_with_server(self, share, share_server\u003dNone):"},{"line_number":92,"context_line":"        self.library.unmanage(share, share_server)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_5d31480a","line":89,"range":{"start_line":89,"start_character":35,"end_line":89,"end_character":47},"in_reply_to":"9fdfeff1_455660d0","updated":"2019-03-01 17:59:50.000000000","message":"Done","commit_id":"d94a092c0076ea051b9d1b08faf256907d0d5a37"}],"manila/share/drivers/netapp/dataontap/cluster_mode/drv_single_svm.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f261869e79dff51ad48f48b918b7d799521b035f","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    def unmanage_snapshot(self, snapshot):"},{"line_number":84,"context_line":"        self.library.unmanage_snapshot(snapshot)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def manage_existing_with_server("},{"line_number":87,"context_line":"            self, share, driver_options, share_server\u003dNone):"},{"line_number":88,"context_line":"        raise NotImplementedError"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def unmanage_with_server(self, share, share_server\u003dNone):"},{"line_number":91,"context_line":"        raise NotImplementedError"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def manage_existing_snapshot_with_server("},{"line_number":94,"context_line":"            self, snapshot, driver_options, share_server\u003dNone):"},{"line_number":95,"context_line":"        raise NotImplementedError"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def unmanage_snapshot_with_server(self, snapshot, share_server\u003dNone):"},{"line_number":98,"context_line":"        raise NotImplementedError"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def update_access(self, context, share, access_rules, add_rules,"},{"line_number":101,"context_line":"                      delete_rules, **kwargs):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_054b782a","line":98,"range":{"start_line":86,"start_character":0,"end_line":98,"end_character":33},"updated":"2019-03-01 07:56:00.000000000","message":"no need to add..","commit_id":"d94a092c0076ea051b9d1b08faf256907d0d5a37"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e67535a7b44dbfddc71d7bba3fc5c72669f94dab","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    def unmanage_snapshot(self, snapshot):"},{"line_number":84,"context_line":"        self.library.unmanage_snapshot(snapshot)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def manage_existing_with_server("},{"line_number":87,"context_line":"            self, share, driver_options, share_server\u003dNone):"},{"line_number":88,"context_line":"        raise NotImplementedError"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def unmanage_with_server(self, share, share_server\u003dNone):"},{"line_number":91,"context_line":"        raise NotImplementedError"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def manage_existing_snapshot_with_server("},{"line_number":94,"context_line":"            self, snapshot, driver_options, share_server\u003dNone):"},{"line_number":95,"context_line":"        raise NotImplementedError"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def unmanage_snapshot_with_server(self, snapshot, share_server\u003dNone):"},{"line_number":98,"context_line":"        raise NotImplementedError"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def update_access(self, context, share, access_rules, add_rules,"},{"line_number":101,"context_line":"                      delete_rules, **kwargs):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_1d42e068","line":98,"range":{"start_line":86,"start_character":0,"end_line":98,"end_character":33},"in_reply_to":"9fdfeff1_054b782a","updated":"2019-03-01 17:59:50.000000000","message":"There is a unit test that makes sure that both interfaces drv_single_svm and drv_multi_svm all have the same methods declared.","commit_id":"d94a092c0076ea051b9d1b08faf256907d0d5a37"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c1e476b87f4c18ad361d61c17bf5cd2cb120115a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    def unmanage_snapshot(self, snapshot):"},{"line_number":84,"context_line":"        self.library.unmanage_snapshot(snapshot)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def manage_existing_with_server("},{"line_number":87,"context_line":"            self, share, driver_options, share_server\u003dNone):"},{"line_number":88,"context_line":"        raise NotImplementedError"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def unmanage_with_server(self, share, share_server\u003dNone):"},{"line_number":91,"context_line":"        raise NotImplementedError"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def manage_existing_snapshot_with_server("},{"line_number":94,"context_line":"            self, snapshot, driver_options, share_server\u003dNone):"},{"line_number":95,"context_line":"        raise NotImplementedError"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def unmanage_snapshot_with_server(self, snapshot, share_server\u003dNone):"},{"line_number":98,"context_line":"        raise NotImplementedError"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def update_access(self, context, share, access_rules, add_rules,"},{"line_number":101,"context_line":"                      delete_rules, **kwargs):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_f21aa616","line":98,"range":{"start_line":86,"start_character":0,"end_line":98,"end_character":33},"in_reply_to":"9fdfeff1_1d42e068","updated":"2019-03-01 20:39:06.000000000","message":"Oooh yeah, that one was written to prevent a real bug","commit_id":"d94a092c0076ea051b9d1b08faf256907d0d5a37"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f261869e79dff51ad48f48b918b7d799521b035f","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    def ensure_shares(self, context, shares):"},{"line_number":272,"context_line":"        return self.library.ensure_shares(context, shares)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    def get_share_server_network_info("},{"line_number":275,"context_line":"            self, context, share_server, identifier, driver_options):"},{"line_number":276,"context_line":"        return self.library.get_share_server_network_info("},{"line_number":277,"context_line":"            context, share_server, identifier, driver_options)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def manage_server(self, context, share_server, identifier, driver_options):"},{"line_number":280,"context_line":"        return self.library.manage_server("},{"line_number":281,"context_line":"            context, share_server, identifier, driver_options)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_e54bd424","line":281,"range":{"start_line":274,"start_character":0,"end_line":281,"end_character":62},"updated":"2019-03-01 07:56:00.000000000","message":"Why need them?","commit_id":"d94a092c0076ea051b9d1b08faf256907d0d5a37"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"0c9d35fa9bf215689fc4380fb62221ebaebb4ea0","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    def ensure_shares(self, context, shares):"},{"line_number":272,"context_line":"        return self.library.ensure_shares(context, shares)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    def get_share_server_network_info("},{"line_number":275,"context_line":"            self, context, share_server, identifier, driver_options):"},{"line_number":276,"context_line":"        return self.library.get_share_server_network_info("},{"line_number":277,"context_line":"            context, share_server, identifier, driver_options)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def manage_server(self, context, share_server, identifier, driver_options):"},{"line_number":280,"context_line":"        return self.library.manage_server("},{"line_number":281,"context_line":"            context, share_server, identifier, driver_options)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_be43853f","line":281,"range":{"start_line":274,"start_character":0,"end_line":281,"end_character":62},"in_reply_to":"9fdfeff1_b2141eeb","updated":"2019-03-01 23:52:17.000000000","message":"I think this was a merge error","commit_id":"d94a092c0076ea051b9d1b08faf256907d0d5a37"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c1e476b87f4c18ad361d61c17bf5cd2cb120115a","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    def ensure_shares(self, context, shares):"},{"line_number":272,"context_line":"        return self.library.ensure_shares(context, shares)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    def get_share_server_network_info("},{"line_number":275,"context_line":"            self, context, share_server, identifier, driver_options):"},{"line_number":276,"context_line":"        return self.library.get_share_server_network_info("},{"line_number":277,"context_line":"            context, share_server, identifier, driver_options)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def manage_server(self, context, share_server, identifier, driver_options):"},{"line_number":280,"context_line":"        return self.library.manage_server("},{"line_number":281,"context_line":"            context, share_server, identifier, driver_options)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_b2141eeb","line":281,"range":{"start_line":274,"start_character":0,"end_line":281,"end_character":62},"in_reply_to":"9fdfeff1_e54bd424","updated":"2019-03-01 20:39:06.000000000","message":"These should be NotImplementedError? their implementations aren\u0027t in lib_base, so they\u0027ll fail to resolve..","commit_id":"d94a092c0076ea051b9d1b08faf256907d0d5a37"}],"manila/share/drivers/netapp/dataontap/protocols/nfs_cmode.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f261869e79dff51ad48f48b918b7d799521b035f","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        \"\"\"Returns IP address and export location of an NFS share.\"\"\""},{"line_number":148,"context_line":"        export_location \u003d share[\u0027export_location\u0027] or \u0027:\u0027"},{"line_number":149,"context_line":"        result \u003d export_location.rsplit(\u0027:\u0027, 1)"},{"line_number":150,"context_line":"        if len(result) !\u003d 2:"},{"line_number":151,"context_line":"            return [\u0027\u0027, \u0027\u0027]"},{"line_number":152,"context_line":"        return result"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    @staticmethod"},{"line_number":155,"context_line":"    def _get_temp_export_policy_name():"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_a5314ca4","line":152,"range":{"start_line":150,"start_character":0,"end_line":152,"end_character":21},"updated":"2019-03-01 07:56:00.000000000","message":"unrelated change?\n\nAlso, when do you expect a share\u0027s export_location not to have a \u0027:\u0027?","commit_id":"d94a092c0076ea051b9d1b08faf256907d0d5a37"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c1e476b87f4c18ad361d61c17bf5cd2cb120115a","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        \"\"\"Returns IP address and export location of an NFS share.\"\"\""},{"line_number":148,"context_line":"        export_location \u003d share[\u0027export_location\u0027] or \u0027:\u0027"},{"line_number":149,"context_line":"        result \u003d export_location.rsplit(\u0027:\u0027, 1)"},{"line_number":150,"context_line":"        if len(result) !\u003d 2:"},{"line_number":151,"context_line":"            return [\u0027\u0027, \u0027\u0027]"},{"line_number":152,"context_line":"        return result"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    @staticmethod"},{"line_number":155,"context_line":"    def _get_temp_export_policy_name():"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_32290e37","line":152,"range":{"start_line":150,"start_character":0,"end_line":152,"end_character":21},"in_reply_to":"9fdfeff1_7d668c2b","updated":"2019-03-01 20:39:06.000000000","message":"oh, makes sense","commit_id":"d94a092c0076ea051b9d1b08faf256907d0d5a37"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e67535a7b44dbfddc71d7bba3fc5c72669f94dab","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        \"\"\"Returns IP address and export location of an NFS share.\"\"\""},{"line_number":148,"context_line":"        export_location \u003d share[\u0027export_location\u0027] or \u0027:\u0027"},{"line_number":149,"context_line":"        result \u003d export_location.rsplit(\u0027:\u0027, 1)"},{"line_number":150,"context_line":"        if len(result) !\u003d 2:"},{"line_number":151,"context_line":"            return [\u0027\u0027, \u0027\u0027]"},{"line_number":152,"context_line":"        return result"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    @staticmethod"},{"line_number":155,"context_line":"    def _get_temp_export_policy_name():"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_7d668c2b","line":152,"range":{"start_line":150,"start_character":0,"end_line":152,"end_character":21},"in_reply_to":"9fdfeff1_a5314ca4","updated":"2019-03-01 17:59:50.000000000","message":"We captured this while running the automated tests. If we pass a string that does not \":\" such as \"foobar\" it crashes with a python error message. This way the error message is more friendly.","commit_id":"d94a092c0076ea051b9d1b08faf256907d0d5a37"}],"releasenotes/notes/netapp-manage-unmanage-share-servers-635496b46e306920.yaml":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"bdd4fd9cbfba2e0c0adb2cb3a8662aec3553cd25","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Added managing and unmanaging of share servers"},{"line_number":4,"context_line":"    functionality to the NetApp driver, allowing for"},{"line_number":5,"context_line":"    shares and snapshots to be managed and unmanaged in"},{"line_number":6,"context_line":"    ``driver_handles_share_servers`` driver mode. "}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fdfeff1_647350b6","line":6,"range":{"start_line":6,"start_character":48,"end_line":6,"end_character":50},"updated":"2019-02-18 20:46:19.000000000","message":"nit: trailing whitespace","commit_id":"62c280c90dbb9e7eecbb4ed66dc1e3589d2619b9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f261869e79dff51ad48f48b918b7d799521b035f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Added managing and unmanaging of share servers"},{"line_number":4,"context_line":"    functionality to the NetApp driver, allowing for"},{"line_number":5,"context_line":"    shares and snapshots to be managed and unmanaged in"},{"line_number":6,"context_line":"    ``driver_handles_share_servers`` driver mode."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9fdfeff1_a5d5cc44","line":6,"range":{"start_line":6,"start_character":34,"end_line":6,"end_character":36},"updated":"2019-03-01 07:56:00.000000000","message":"\u003dTrue","commit_id":"d94a092c0076ea051b9d1b08faf256907d0d5a37"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e67535a7b44dbfddc71d7bba3fc5c72669f94dab","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Added managing and unmanaging of share servers"},{"line_number":4,"context_line":"    functionality to the NetApp driver, allowing for"},{"line_number":5,"context_line":"    shares and snapshots to be managed and unmanaged in"},{"line_number":6,"context_line":"    ``driver_handles_share_servers`` driver mode."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9fdfeff1_fd835ca7","line":6,"range":{"start_line":6,"start_character":34,"end_line":6,"end_character":36},"in_reply_to":"9fdfeff1_a5d5cc44","updated":"2019-03-01 17:59:50.000000000","message":"Done","commit_id":"d94a092c0076ea051b9d1b08faf256907d0d5a37"}]}