)]}'
{"manila/api/http_codes.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"15afd32c477ceaf07c222f50a4bba051da5dd31f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5fc1f717_8118aad3","updated":"2019-03-05 20:50:23.000000000","message":"This shallow copy of the modules is a bit unsettling. Would python optimize this? Also, if we\u0027re going to the lengths to disable pylint checks on this, why not just put the base module: \u0027httplib\u0027 or \u0027http.Status\u0027 in the ignored modules and be done?","commit_id":"c32e613cb51316773d0b399dee60289c5e85c80f"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"7f125c96be208cc3767fe1c6542637b4be7f6289","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5fc1f717_e10c0e44","in_reply_to":"5fc1f717_8118aad3","updated":"2019-03-05 21:09:57.000000000","message":"I\u0027ll read a bit and see if any optimization is done and if I can maybe do it more straightforward and better.\n\n+1 for adding both modules to .pylintrc. Is there no chance at all that one of the modules is imported anywhere in the manila code? Is six.moves used everywhere instead? I guess that if \u0027http\u0027 is imported anywhere without conditioning for Python 3, the py27 test will fail. Same for \u0027httplib\u0027 and the Python 3 tests.","commit_id":"c32e613cb51316773d0b399dee60289c5e85c80f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0804b432322806920fa49e93bfb17f1a827b2bad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5fc1f717_62d1fc57","in_reply_to":"5fc1f717_e10c0e44","updated":"2019-03-05 23:02:45.000000000","message":"I don\u0027t see why this didn\u0027t get resolved with the six.moves catchall in our pylintrc...\nNo, I don\u0027t see either of the modules (httplib for py2 or http for py3 being imported directly.. \n\nThat said, We can get rid of the indirect imports we currently have once we get rid of py27 compatibility.. So just adding the two modules may alleviate our current issue...","commit_id":"c32e613cb51316773d0b399dee60289c5e85c80f"}]}
