)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aba1b5ba9b29b49b49d5b2160053c436aecf057c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yajushi Srivastava \u003cyajushi.sri@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-03-06 20:58:10 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds User Message in case of Shrinking Error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When shrinking of a share fails, there is no User Message generated."},{"line_number":10,"context_line":"This change uses the Message API module and updates the user message"},{"line_number":11,"context_line":"list suggesting an UNEXPECTED_NETWORK error, which corresponds to:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"UNEXPECTED_NETWORK \u003d (\u0027003\u0027, \u0027Driver does not expect share-network"},{"line_number":14,"context_line":"\tto be provided with current configuration.\u0027)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ifcc616a0e90e720e5ec5b02fb8c7dfa049e1c20b"},{"line_number":17,"context_line":"Closes-Bug: #1802424"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Deletes temporary files"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This change deletes the temp files that were added during the last"},{"line_number":22,"context_line":"commit."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I04e0224706852b1ae435b12a8861bb0683a4d3ca"},{"line_number":25,"context_line":"Closes-Bug: #1802424"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_744a0228","line":25,"range":{"start_line":7,"start_character":0,"end_line":25,"end_character":20},"updated":"2019-03-06 20:06:02.000000000","message":"Please refer to the Gerrit workflow, and pay attention to [1], [2] and [3] . You will need to continue to amend your existing commit with your new changes if you want to preserve the same Gerrit Change (Change-Id: I04e0224706852b1ae435b12a8861bb0683a4d3ca)\n\n\n[1] https://docs.openstack.org/infra/manual/developers.html#updating-a-change\n[2] https://docs.openstack.org/infra/manual/developers.html#squashing-changes\n[3] https://docs.openstack.org/infra/manual/developers.html#rebasing-a-commit","commit_id":"cf5542d75d1949f4dd4e0f095329241f4d92b96f"}],"manila/share/manager.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aba1b5ba9b29b49b49d5b2160053c436aecf057c","unresolved":false,"context_lines":[{"line_number":3844,"context_line":"            self.db.share_update(context, share[\u0027id\u0027], {\u0027status\u0027: status})"},{"line_number":3845,"context_line":"            self.message.api.create("},{"line_number":3846,"context_line":"                context,"},{"line_number":3847,"context_line":"                message_field.Action.CREATE,"},{"line_number":3848,"context_line":"                share[\u0027project_id\u0027],"},{"line_number":3849,"context_line":"                resource_type\u003dmessage_field.Resource.SHARE,"},{"line_number":3850,"context_line":"                resource_id\u003dshare_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_940f6e2d","line":3847,"range":{"start_line":3847,"start_character":37,"end_line":3847,"end_character":43},"updated":"2019-03-06 20:06:02.000000000","message":"This failed isn\u0027t on a \"create\" action, it is on shrinking the share, so, you must add a new action to manila.message.message_field.Action [1]\n\n\n[1] https://github.com/openstack/manila/blob/9bcbeee/manila/message/message_field.py#L25","commit_id":"cf5542d75d1949f4dd4e0f095329241f4d92b96f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aba1b5ba9b29b49b49d5b2160053c436aecf057c","unresolved":false,"context_lines":[{"line_number":3847,"context_line":"                message_field.Action.CREATE,"},{"line_number":3848,"context_line":"                share[\u0027project_id\u0027],"},{"line_number":3849,"context_line":"                resource_type\u003dmessage_field.Resource.SHARE,"},{"line_number":3850,"context_line":"                resource_id\u003dshare_id,"},{"line_number":3851,"context_line":"                detail\u003dmessage_field.Detail.UNEXPECTED_NETWORK)"},{"line_number":3852,"context_line":""},{"line_number":3853,"context_line":"            raise exception.ShareShrinkingError("}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_1404de14","line":3850,"range":{"start_line":3850,"start_character":28,"end_line":3850,"end_character":36},"updated":"2019-03-06 20:06:02.000000000","message":"this isn\u0027t valid, you mean share[\u0027id\u0027]","commit_id":"cf5542d75d1949f4dd4e0f095329241f4d92b96f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aba1b5ba9b29b49b49d5b2160053c436aecf057c","unresolved":false,"context_lines":[{"line_number":3848,"context_line":"                share[\u0027project_id\u0027],"},{"line_number":3849,"context_line":"                resource_type\u003dmessage_field.Resource.SHARE,"},{"line_number":3850,"context_line":"                resource_id\u003dshare_id,"},{"line_number":3851,"context_line":"                detail\u003dmessage_field.Detail.UNEXPECTED_NETWORK)"},{"line_number":3852,"context_line":""},{"line_number":3853,"context_line":"            raise exception.ShareShrinkingError("},{"line_number":3854,"context_line":"                reason\u003dsix.text_type(exc), share_id\u003dshare_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_7440c236","line":3851,"range":{"start_line":3851,"start_character":23,"end_line":3851,"end_character":62},"updated":"2019-03-06 20:06:02.000000000","message":"You can\u0027t reuse this message since it is inappropriate for the failure here... you need to create a new message in manila.message.message_field.Detail [1] to reflect what\u0027s going on here.. \n\n\nIf the status is STATUS_SHRINKING_ERROR, then the shrink operation failed for an unknown reason, and the user must rectify whatever\u0027s wrong with the share and reattempt shrinking.\n\nIf the status is STATUS_SHRINKING_POSSIBLE_DATA_LOSS_ERROR, the shrink operation failed because the user was trying to shrink below the actual used capacity on the share, the message must say that the share resource is unmodified. Shrinking again to a valid size may work, or they can check the backend resource and reset the status of the share to allow further operations on the share. \n\n[1] https://github.com/openstack/manila/blob/9bcbeee/manila/message/message_field.py#L43","commit_id":"cf5542d75d1949f4dd4e0f095329241f4d92b96f"}]}