)]}'
{"manila/api/v2/share_networks.py":[{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"319f89cf8c41a0bb88c9d050eed9d7d437d4609f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        return self._view_builder.build_share_network(req, share_network)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _all_share_servers_are_auto_deletable(self, share_network):"},{"line_number":65,"context_line":"        return all(([ss[\u0027is_auto_deletable\u0027] for ss"},{"line_number":66,"context_line":"                     in share_network[\u0027share_servers\u0027]]))"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def delete(self, req, id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_c272067d","line":65,"range":{"start_line":65,"start_character":18,"end_line":65,"end_character":20},"updated":"2019-03-20 18:07:41.000000000","message":"you may remove one of them","commit_id":"5ba5116d46808c2f0c418fa9f84a77bcca116146"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6d63e4dfe7dbf6302adf36188c2819019415db3d","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        return self._view_builder.build_share_network(req, share_network)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _all_share_servers_are_auto_deletable(self, share_network):"},{"line_number":65,"context_line":"        return all(([ss[\u0027is_auto_deletable\u0027] for ss"},{"line_number":66,"context_line":"                     in share_network[\u0027share_servers\u0027]]))"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def delete(self, req, id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_422db644","line":65,"range":{"start_line":65,"start_character":18,"end_line":65,"end_character":20},"in_reply_to":"5fc1f717_c272067d","updated":"2019-03-20 18:10:07.000000000","message":"Done","commit_id":"5ba5116d46808c2f0c418fa9f84a77bcca116146"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f71fe7956a994d3b935f16d2e1ef395f219da563","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        # NOTE(silvacarlose): Do not allow the deletion of any share server"},{"line_number":98,"context_line":"        # if one of them has the flag is_auto_deletable \u003d False"},{"line_number":99,"context_line":"        if not self._all_share_servers_are_auto_deletable(share_network):"},{"line_number":100,"context_line":"            msg \u003d _(\"There may be shares o the share network %(id)s, that we \""},{"line_number":101,"context_line":"                    \"don\u0027t know about. Please contact your administrator to \""},{"line_number":102,"context_line":"                    \"clarify.\") % {\u0027id\u0027: id}"},{"line_number":103,"context_line":"            LOG.error(msg)"},{"line_number":104,"context_line":"            raise exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_99b47137","line":102,"range":{"start_line":100,"start_character":21,"end_line":102,"end_character":29},"updated":"2019-03-20 21:53:55.000000000","message":"The service cannot determine if there are any non-managed shares on the share network %(id)s, so it cannot be deleted. Please contact the cloud administrator to rectify.","commit_id":"2d31124a49ce6f760750f0d2d6313f30426634d4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6df2b0158eb405abc2af49831f57b4c3051a75f7","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        # NOTE(silvacarlose): Do not allow the deletion of any share server"},{"line_number":98,"context_line":"        # if one of them has the flag is_auto_deletable \u003d False"},{"line_number":99,"context_line":"        if not self._all_share_servers_are_auto_deletable(share_network):"},{"line_number":100,"context_line":"            msg \u003d _(\"There may be shares o the share network %(id)s, that we \""},{"line_number":101,"context_line":"                    \"don\u0027t know about. Please contact your administrator to \""},{"line_number":102,"context_line":"                    \"clarify.\") % {\u0027id\u0027: id}"},{"line_number":103,"context_line":"            LOG.error(msg)"},{"line_number":104,"context_line":"            raise exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_b4ce1481","line":102,"range":{"start_line":100,"start_character":21,"end_line":102,"end_character":29},"in_reply_to":"5fc1f717_99b47137","updated":"2019-03-20 23:41:22.000000000","message":"Done","commit_id":"2d31124a49ce6f760750f0d2d6313f30426634d4"}],"manila/share/manager.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f71fe7956a994d3b935f16d2e1ef395f219da563","unresolved":false,"context_lines":[{"line_number":2606,"context_line":"            self.db.share_server_update(context, share_server[\u0027id\u0027],"},{"line_number":2607,"context_line":"                                        {\u0027is_auto_deletable\u0027: False})"},{"line_number":2608,"context_line":""},{"line_number":2609,"context_line":"        LOG.warning(\"The share network that this share pertain is not able to \""},{"line_number":2610,"context_line":"                    \"be deleted unless the associated share servers are \""},{"line_number":2611,"context_line":"                    \"unmanaged or deleted.\")"},{"line_number":2612,"context_line":"        LOG.info(\"Share %s: unmanaged successfully.\", share_id)"},{"line_number":2613,"context_line":""},{"line_number":2614,"context_line":"    @add_hooks"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_d993d9a2","line":2611,"range":{"start_line":2609,"start_character":8,"end_line":2611,"end_character":44},"updated":"2019-03-20 21:53:55.000000000","message":"this needs to be inside the if condition on line 2605... \n\n also the message can be a little more verbose:\n\n           msg \u003d (\"Since share %(share)s has been un-managed from share \"\n                   \"server %(server)s. This share server must be \"\n                   \"removed manually, either by un-managing or by \"\n                   \"deleting it. The share network %(network)s cannot be \"\n                   \"deleted unless this share server has been removed.\")\n            msg_args \u003d {\n                \u0027share\u0027: share_id,\n                \u0027server\u0027: share_server[\u0027id\u0027],\n                \u0027network\u0027: share_server[\u0027share_network_id\u0027],\n            }\n            LOG.warning(msg, msg_args)","commit_id":"2d31124a49ce6f760750f0d2d6313f30426634d4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6df2b0158eb405abc2af49831f57b4c3051a75f7","unresolved":false,"context_lines":[{"line_number":2606,"context_line":"            self.db.share_server_update(context, share_server[\u0027id\u0027],"},{"line_number":2607,"context_line":"                                        {\u0027is_auto_deletable\u0027: False})"},{"line_number":2608,"context_line":""},{"line_number":2609,"context_line":"        LOG.warning(\"The share network that this share pertain is not able to \""},{"line_number":2610,"context_line":"                    \"be deleted unless the associated share servers are \""},{"line_number":2611,"context_line":"                    \"unmanaged or deleted.\")"},{"line_number":2612,"context_line":"        LOG.info(\"Share %s: unmanaged successfully.\", share_id)"},{"line_number":2613,"context_line":""},{"line_number":2614,"context_line":"    @add_hooks"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_3489c425","line":2611,"range":{"start_line":2609,"start_character":8,"end_line":2611,"end_character":44},"in_reply_to":"5fc1f717_d993d9a2","updated":"2019-03-20 23:41:22.000000000","message":"Done","commit_id":"2d31124a49ce6f760750f0d2d6313f30426634d4"}]}