)]}'
{"manila/api/common.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a549ab3c32fcc2d2432965fddfa5d7f9396f3bd","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    return request.GET[\u0027marker\u0027]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"def _validate_query(request, max_limit\u003dCONF.osapi_max_limit):"},{"line_number":106,"context_line":"    \"\"\"Validate the given request query and return limit and offset.\"\"\""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_21c56a5c","line":105,"range":{"start_line":105,"start_character":4,"end_line":105,"end_character":19},"updated":"2019-09-04 23:39:09.000000000","message":"_validate_pagination_query\n\nis perhaps more appropriate","commit_id":"2329b96103a89294a688b3e9b0b09ad5ce2f2d34"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b709c693bef2475c4d674c93f541beedc80505b0","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    return request.GET[\u0027marker\u0027]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"def _validate_query(request, max_limit\u003dCONF.osapi_max_limit):"},{"line_number":106,"context_line":"    \"\"\"Validate the given request query and return limit and offset.\"\"\""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_5d145f44","line":105,"range":{"start_line":105,"start_character":4,"end_line":105,"end_character":19},"in_reply_to":"7faddb67_21c56a5c","updated":"2019-09-24 01:56:34.000000000","message":"Done","commit_id":"2329b96103a89294a688b3e9b0b09ad5ce2f2d34"}],"manila/api/v1/shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fd4a00b1b1d5baee5909037754986b2c2c11571e","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        search_opts.update(req.GET)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        # Remove keys that are not related to share attrs"},{"line_number":131,"context_line":"        search_opts.pop(\u0027offset\u0027, None)"},{"line_number":132,"context_line":"        sort_key \u003d search_opts.pop(\u0027sort_key\u0027, \u0027created_at\u0027)"},{"line_number":133,"context_line":"        sort_dir \u003d search_opts.pop(\u0027sort_dir\u0027, \u0027desc\u0027)"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_6b74c7cf","line":131,"range":{"start_line":131,"start_character":0,"end_line":131,"end_character":39},"updated":"2019-08-01 16:20:31.000000000","message":"You need this too - so don\u0027t pop?","commit_id":"6e850f9f1074f889992989cf6a8a0f81a04128dd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8081367d88d15368b9fef3bb97a5f4ceae556935","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        search_opts.update(req.GET)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        # Remove keys that are not related to share attrs"},{"line_number":131,"context_line":"        search_opts.pop(\u0027offset\u0027, None)"},{"line_number":132,"context_line":"        sort_key \u003d search_opts.pop(\u0027sort_key\u0027, \u0027created_at\u0027)"},{"line_number":133,"context_line":"        sort_dir \u003d search_opts.pop(\u0027sort_dir\u0027, \u0027desc\u0027)"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_da521569","line":131,"range":{"start_line":131,"start_character":0,"end_line":131,"end_character":39},"in_reply_to":"7faddb67_6b74c7cf","updated":"2019-08-07 21:05:42.000000000","message":"Yes, you\u0027re right. I\u0027ll need this in the future.","commit_id":"6e850f9f1074f889992989cf6a8a0f81a04128dd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fd4a00b1b1d5baee5909037754986b2c2c11571e","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        if show_count:"},{"line_number":174,"context_line":"            total_count \u003d len(shares)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        limited_list \u003d common.limited(shares, req)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        if is_detail:"},{"line_number":179,"context_line":"            shares \u003d self._view_builder.detail_list(req, limited_list,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_eb519737","line":176,"range":{"start_line":176,"start_character":0,"end_line":176,"end_character":50},"updated":"2019-08-01 16:20:31.000000000","message":"You no longer need this call because processing is happening with the DB query...\n\nHowever, I think you should perform the validation necessary right at the beginning - please factor out the query validation (https://github.com/openstack/manila/blob/6d970b7375689eb73fc6a26ceb1c4d6e5553fa70/manila/api/common.py#L117-L135) into a separate method and call it right at the beginning...","commit_id":"6e850f9f1074f889992989cf6a8a0f81a04128dd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8081367d88d15368b9fef3bb97a5f4ceae556935","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        if show_count:"},{"line_number":174,"context_line":"            total_count \u003d len(shares)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        limited_list \u003d common.limited(shares, req)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        if is_detail:"},{"line_number":179,"context_line":"            shares \u003d self._view_builder.detail_list(req, limited_list,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_bc9b8e71","line":176,"range":{"start_line":176,"start_character":0,"end_line":176,"end_character":50},"in_reply_to":"7faddb67_eb519737","updated":"2019-08-07 21:05:42.000000000","message":"Great. I\u0027ve refactored the method and added the call to the extracted validation method in the very beggining of the limited(). I\u0027ve named the method but dunno if it is the best name, since the method not only validates the query but also returns limit and offset after the validation. Name suggestions for this method are welcome :)","commit_id":"6e850f9f1074f889992989cf6a8a0f81a04128dd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a549ab3c32fcc2d2432965fddfa5d7f9396f3bd","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        if show_count:"},{"line_number":173,"context_line":"            total_count \u003d len(shares)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        common._validate_query(req)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        if is_detail:"},{"line_number":178,"context_line":"            shares \u003d self._view_builder.detail_list(req, shares, total_count)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_a1a63abf","line":175,"range":{"start_line":175,"start_character":8,"end_line":175,"end_character":35},"updated":"2019-09-04 23:39:09.000000000","message":"Great, thanks for the refactor - can you pull this right at the top so we can fail fast/early? This can be done at the beginning of this method.","commit_id":"2329b96103a89294a688b3e9b0b09ad5ce2f2d34"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6166714043c4b000806b106cb3216fb04eece609","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        if show_count:"},{"line_number":173,"context_line":"            total_count \u003d len(shares)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        common._validate_query(req)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        if is_detail:"},{"line_number":178,"context_line":"            shares \u003d self._view_builder.detail_list(req, shares, total_count)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_fcc92d24","line":175,"range":{"start_line":175,"start_character":8,"end_line":175,"end_character":35},"in_reply_to":"7faddb67_a1a63abf","updated":"2019-09-18 19:56:56.000000000","message":"Alright. Done.","commit_id":"2329b96103a89294a688b3e9b0b09ad5ce2f2d34"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"179843f87973f8b62c8beb5d8737a4146f5bd744","unresolved":false,"context_lines":[{"line_number":1815,"context_line":"def _share_get_all_with_filters(context, project_id\u003dNone, share_server_id\u003dNone,"},{"line_number":1816,"context_line":"                                share_group_id\u003dNone, filters\u003dNone,"},{"line_number":1817,"context_line":"                                is_public\u003dFalse, sort_key\u003dNone,"},{"line_number":1818,"context_line":"                                sort_dir\u003dNone, offset\u003d0):"},{"line_number":1819,"context_line":"    \"\"\"Returns sorted list of shares that satisfies filters."},{"line_number":1820,"context_line":""},{"line_number":1821,"context_line":"    :param context: context to query under"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_53de606d","line":1818,"range":{"start_line":1818,"start_character":46,"end_line":1818,"end_character":55},"updated":"2019-09-26 00:23:12.000000000","message":"offset is being passed through filters... \n\n[1] https://review.opendev.org/#/c/650986/9/manila/db/sqlalchemy/api.py@1912\n[2] https://review.opendev.org/#/c/650986/9/manila/db/sqlalchemy/api.py@1921\n[3] https://review.opendev.org/#/c/650986/9/manila/share/api.py@1611","commit_id":"bdb915a919b1b64c8bdfc4e25a1cf7e8b171c9c8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"210bb686413b48b9a35aa0ab492269e3e0427945","unresolved":false,"context_lines":[{"line_number":1815,"context_line":"def _share_get_all_with_filters(context, project_id\u003dNone, share_server_id\u003dNone,"},{"line_number":1816,"context_line":"                                share_group_id\u003dNone, filters\u003dNone,"},{"line_number":1817,"context_line":"                                is_public\u003dFalse, sort_key\u003dNone,"},{"line_number":1818,"context_line":"                                sort_dir\u003dNone, offset\u003d0):"},{"line_number":1819,"context_line":"    \"\"\"Returns sorted list of shares that satisfies filters."},{"line_number":1820,"context_line":""},{"line_number":1821,"context_line":"    :param context: context to query under"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_fe32b3f1","line":1818,"range":{"start_line":1818,"start_character":46,"end_line":1818,"end_character":55},"in_reply_to":"3fa7e38b_53de606d","updated":"2019-09-26 03:01:07.000000000","message":"Oops. Changed :)","commit_id":"bdb915a919b1b64c8bdfc4e25a1cf7e8b171c9c8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"179843f87973f8b62c8beb5d8737a4146f5bd744","unresolved":false,"context_lines":[{"line_number":1900,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":1901,"context_line":""},{"line_number":1902,"context_line":"    if \u0027limit\u0027 in filters:"},{"line_number":1903,"context_line":"        query \u003d query.limit(filters[\u0027limit\u0027]).offset(offset)"},{"line_number":1904,"context_line":""},{"line_number":1905,"context_line":"    # Returns list of shares that satisfy filters."},{"line_number":1906,"context_line":"    query \u003d query.all()"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_13e4683b","line":1903,"range":{"start_line":1903,"start_character":8,"end_line":1903,"end_character":60},"updated":"2019-09-26 00:23:12.000000000","message":".\n offset \u003d filters.get(\u0027offset\u0027, 0)\n query \u003d query.limit(filters[\u0027limit\u0027]).offset(offset)","commit_id":"bdb915a919b1b64c8bdfc4e25a1cf7e8b171c9c8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"210bb686413b48b9a35aa0ab492269e3e0427945","unresolved":false,"context_lines":[{"line_number":1900,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":1901,"context_line":""},{"line_number":1902,"context_line":"    if \u0027limit\u0027 in filters:"},{"line_number":1903,"context_line":"        query \u003d query.limit(filters[\u0027limit\u0027]).offset(offset)"},{"line_number":1904,"context_line":""},{"line_number":1905,"context_line":"    # Returns list of shares that satisfy filters."},{"line_number":1906,"context_line":"    query \u003d query.all()"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_be4e7b6c","line":1903,"range":{"start_line":1903,"start_character":8,"end_line":1903,"end_character":60},"in_reply_to":"3fa7e38b_13e4683b","updated":"2019-09-26 03:01:07.000000000","message":"Done. Also, I\u0027ve modified the test I changed in the previous PS. The related test - test_get_all_with_limit - started failing after I changed this. The failure was because the offset was not properly working, since it was not being received through filters. I realized that the sort_dir\u003d\u0027asc\u0027 I added is not needed if the offset behaves correctly. Now as I have the offset properly working, this behaves as expected and I don\u0027t need to change the elements order in the query.","commit_id":"bdb915a919b1b64c8bdfc4e25a1cf7e8b171c9c8"}],"manila/share/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fd4a00b1b1d5baee5909037754986b2c2c11571e","unresolved":false,"context_lines":[{"line_number":1581,"context_line":"        if search_opts is None:"},{"line_number":1582,"context_line":"            search_opts \u003d {}"},{"line_number":1583,"context_line":""},{"line_number":1584,"context_line":"        LOG.debug(\"Searching for shares by: %s\", search_opts)"},{"line_number":1585,"context_line":""},{"line_number":1586,"context_line":"        # Prepare filters"},{"line_number":1587,"context_line":"        filters \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_eb1f5769","side":"PARENT","line":1584,"range":{"start_line":1584,"start_character":0,"end_line":1584,"end_character":61},"updated":"2019-08-01 16:20:31.000000000","message":"Unrelated change?","commit_id":"0ed8c74dc49c87d3de9c27303602ec97357fa8ad"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8081367d88d15368b9fef3bb97a5f4ceae556935","unresolved":false,"context_lines":[{"line_number":1581,"context_line":"        if search_opts is None:"},{"line_number":1582,"context_line":"            search_opts \u003d {}"},{"line_number":1583,"context_line":""},{"line_number":1584,"context_line":"        LOG.debug(\"Searching for shares by: %s\", search_opts)"},{"line_number":1585,"context_line":""},{"line_number":1586,"context_line":"        # Prepare filters"},{"line_number":1587,"context_line":"        filters \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_baf7195a","side":"PARENT","line":1584,"range":{"start_line":1584,"start_character":0,"end_line":1584,"end_character":61},"in_reply_to":"7faddb67_eb1f5769","updated":"2019-08-07 21:05:42.000000000","message":"Yes. Added again.","commit_id":"0ed8c74dc49c87d3de9c27303602ec97357fa8ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fd4a00b1b1d5baee5909037754986b2c2c11571e","unresolved":false,"context_lines":[{"line_number":1603,"context_line":"                msg \u003d _(\"Wrong extra specs filter provided: \""},{"line_number":1604,"context_line":"                        \"%s.\") % six.text_type(filters[\u0027extra_specs\u0027])"},{"line_number":1605,"context_line":"                raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":1606,"context_line":"        if \u0027limit\u0027 in search_opts:"},{"line_number":1607,"context_line":"            filters[\u0027limit\u0027] \u003d search_opts.pop(\u0027limit\u0027)"},{"line_number":1608,"context_line":"        if not (isinstance(sort_key, six.string_types) and sort_key):"},{"line_number":1609,"context_line":"            msg \u003d _(\"Wrong sort_key filter provided: \""},{"line_number":1610,"context_line":"                    \"\u0027%s\u0027.\") % six.text_type(sort_key)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_2b280f95","line":1607,"range":{"start_line":1606,"start_character":0,"end_line":1607,"end_character":55},"updated":"2019-08-01 16:20:31.000000000","message":"need same treatment for offset.","commit_id":"6e850f9f1074f889992989cf6a8a0f81a04128dd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8081367d88d15368b9fef3bb97a5f4ceae556935","unresolved":false,"context_lines":[{"line_number":1603,"context_line":"                msg \u003d _(\"Wrong extra specs filter provided: \""},{"line_number":1604,"context_line":"                        \"%s.\") % six.text_type(filters[\u0027extra_specs\u0027])"},{"line_number":1605,"context_line":"                raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":1606,"context_line":"        if \u0027limit\u0027 in search_opts:"},{"line_number":1607,"context_line":"            filters[\u0027limit\u0027] \u003d search_opts.pop(\u0027limit\u0027)"},{"line_number":1608,"context_line":"        if not (isinstance(sort_key, six.string_types) and sort_key):"},{"line_number":1609,"context_line":"            msg \u003d _(\"Wrong sort_key filter provided: \""},{"line_number":1610,"context_line":"                    \"\u0027%s\u0027.\") % six.text_type(sort_key)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_1a6aedec","line":1607,"range":{"start_line":1606,"start_character":0,"end_line":1607,"end_character":55},"in_reply_to":"7faddb67_2b280f95","updated":"2019-08-07 21:05:42.000000000","message":"Done","commit_id":"6e850f9f1074f889992989cf6a8a0f81a04128dd"}],"manila/tests/api/v1/test_shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fd4a00b1b1d5baee5909037754986b2c2c11571e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7faddb67_6b0b6729","updated":"2019-08-01 16:20:31.000000000","message":"please add a new unit test for your code in sqlalchemy/api.py..","commit_id":"6e850f9f1074f889992989cf6a8a0f81a04128dd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8081367d88d15368b9fef3bb97a5f4ceae556935","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7faddb67_0d45d215","in_reply_to":"7faddb67_6b0b6729","updated":"2019-08-07 21:05:42.000000000","message":"Added :)","commit_id":"6e850f9f1074f889992989cf6a8a0f81a04128dd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8081367d88d15368b9fef3bb97a5f4ceae556935","unresolved":false,"context_lines":[{"line_number":684,"context_line":"            {\u0027id\u0027: \u0027id3\u0027, \u0027display_name\u0027: \u0027n3\u0027},"},{"line_number":685,"context_line":"        ]"},{"line_number":686,"context_line":"        self.mock_object(share_api.API, \u0027get_all\u0027,"},{"line_number":687,"context_line":"                         mock.Mock(return_value\u003d[shares[1]]))"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        result \u003d self.controller.detail(req)"},{"line_number":690,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_54f02efe","line":687,"range":{"start_line":687,"start_character":48,"end_line":687,"end_character":58},"updated":"2019-08-07 21:05:42.000000000","message":"this method mock was previously returning a list of shares due to the use of the common.limited() (just a little comment to give context to my below comment :p )","commit_id":"2329b96103a89294a688b3e9b0b09ad5ce2f2d34"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8081367d88d15368b9fef3bb97a5f4ceae556935","unresolved":false,"context_lines":[{"line_number":710,"context_line":"            sort_dir\u003dsearch_opts[\u0027sort_dir\u0027],"},{"line_number":711,"context_line":"            search_opts\u003dsearch_opts_expected,"},{"line_number":712,"context_line":"        )"},{"line_number":713,"context_line":"        self.assertEqual(shares[1][\u0027id\u0027], result[\u0027shares\u0027][0][\u0027id\u0027])"},{"line_number":714,"context_line":"        self.assertEqual("},{"line_number":715,"context_line":"            shares[1][\u0027display_name\u0027], result[\u0027shares\u0027][0][\u0027name\u0027])"},{"line_number":716,"context_line":"        self.assertEqual("},{"line_number":717,"context_line":"            shares[1][\u0027snapshot_id\u0027], result[\u0027shares\u0027][0][\u0027snapshot_id\u0027])"},{"line_number":718,"context_line":"        self.assertEqual("},{"line_number":719,"context_line":"            shares[1][\u0027status\u0027], result[\u0027shares\u0027][0][\u0027status\u0027])"},{"line_number":720,"context_line":"        self.assertEqual("},{"line_number":721,"context_line":"            shares[1][\u0027instance\u0027][\u0027share_type_id\u0027],"},{"line_number":722,"context_line":"            result[\u0027shares\u0027][0][\u0027share_type\u0027])"},{"line_number":723,"context_line":"        self.assertEqual("},{"line_number":724,"context_line":"            shares[1][\u0027snapshot_id\u0027], result[\u0027shares\u0027][0][\u0027snapshot_id\u0027])"},{"line_number":725,"context_line":"        if use_admin_context:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_f4159ae6","line":722,"range":{"start_line":713,"start_character":8,"end_line":722,"end_character":46},"updated":"2019-08-07 21:05:42.000000000","message":"Not only in this file (also in the v2), we have this test which applies some filters to test the method. Now, I\u0027ve done the changes to make the filtering and offset operation happen in the database and extracted the common.limited() method which was being used to filter the results of get_all(), now don\u0027t need to have a list anymore, the database will return only one share in this scenario. As I\u0027m forcing the return_value of the mock I\u0027ve commented above, IMO this asserts are not needed anymore and the validation of the filtered items must be tested in another (database) unit test, am I correct?\nIf so, I\u0027ll need to refactor the shares variable creation and maybe other things in this method.","commit_id":"2329b96103a89294a688b3e9b0b09ad5ce2f2d34"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a549ab3c32fcc2d2432965fddfa5d7f9396f3bd","unresolved":false,"context_lines":[{"line_number":605,"context_line":"            sort_dir\u003dsearch_opts[\u0027sort_dir\u0027],"},{"line_number":606,"context_line":"            search_opts\u003dsearch_opts_expected,"},{"line_number":607,"context_line":"        )"},{"line_number":608,"context_line":"        self.assertEqual(1, len(result[\u0027shares\u0027]))"},{"line_number":609,"context_line":"        self.assertEqual(shares[1][\u0027id\u0027], result[\u0027shares\u0027][0][\u0027id\u0027])"},{"line_number":610,"context_line":"        self.assertEqual("},{"line_number":611,"context_line":"            shares[1][\u0027display_name\u0027], result[\u0027shares\u0027][0][\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_8178de2a","side":"PARENT","line":608,"range":{"start_line":608,"start_character":0,"end_line":608,"end_character":50},"updated":"2019-09-04 23:39:09.000000000","message":"This assert still makes sense, doesn\u0027t it?","commit_id":"0ed8c74dc49c87d3de9c27303602ec97357fa8ad"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b709c693bef2475c4d674c93f541beedc80505b0","unresolved":false,"context_lines":[{"line_number":605,"context_line":"            sort_dir\u003dsearch_opts[\u0027sort_dir\u0027],"},{"line_number":606,"context_line":"            search_opts\u003dsearch_opts_expected,"},{"line_number":607,"context_line":"        )"},{"line_number":608,"context_line":"        self.assertEqual(1, len(result[\u0027shares\u0027]))"},{"line_number":609,"context_line":"        self.assertEqual(shares[1][\u0027id\u0027], result[\u0027shares\u0027][0][\u0027id\u0027])"},{"line_number":610,"context_line":"        self.assertEqual("},{"line_number":611,"context_line":"            shares[1][\u0027display_name\u0027], result[\u0027shares\u0027][0][\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_9a597d8f","side":"PARENT","line":608,"range":{"start_line":608,"start_character":0,"end_line":608,"end_character":50},"in_reply_to":"7faddb67_8178de2a","updated":"2019-09-24 01:56:34.000000000","message":"Yeah, for sure.","commit_id":"0ed8c74dc49c87d3de9c27303602ec97357fa8ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a549ab3c32fcc2d2432965fddfa5d7f9396f3bd","unresolved":false,"context_lines":[{"line_number":703,"context_line":"            sort_dir\u003dsearch_opts[\u0027sort_dir\u0027],"},{"line_number":704,"context_line":"            search_opts\u003dsearch_opts_expected,"},{"line_number":705,"context_line":"        )"},{"line_number":706,"context_line":"        self.assertEqual(1, len(result[\u0027shares\u0027]))"},{"line_number":707,"context_line":"        self.assertEqual(shares[1][\u0027id\u0027], result[\u0027shares\u0027][0][\u0027id\u0027])"},{"line_number":708,"context_line":"        self.assertEqual("},{"line_number":709,"context_line":"            shares[1][\u0027display_name\u0027], result[\u0027shares\u0027][0][\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_c1cfb625","side":"PARENT","line":706,"range":{"start_line":706,"start_character":0,"end_line":706,"end_character":50},"updated":"2019-09-04 23:39:09.000000000","message":"same concern as above","commit_id":"0ed8c74dc49c87d3de9c27303602ec97357fa8ad"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b709c693bef2475c4d674c93f541beedc80505b0","unresolved":false,"context_lines":[{"line_number":703,"context_line":"            sort_dir\u003dsearch_opts[\u0027sort_dir\u0027],"},{"line_number":704,"context_line":"            search_opts\u003dsearch_opts_expected,"},{"line_number":705,"context_line":"        )"},{"line_number":706,"context_line":"        self.assertEqual(1, len(result[\u0027shares\u0027]))"},{"line_number":707,"context_line":"        self.assertEqual(shares[1][\u0027id\u0027], result[\u0027shares\u0027][0][\u0027id\u0027])"},{"line_number":708,"context_line":"        self.assertEqual("},{"line_number":709,"context_line":"            shares[1][\u0027display_name\u0027], result[\u0027shares\u0027][0][\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_1a4d8dc3","side":"PARENT","line":706,"range":{"start_line":706,"start_character":0,"end_line":706,"end_character":50},"in_reply_to":"7faddb67_c1cfb625","updated":"2019-09-24 01:56:34.000000000","message":"Done","commit_id":"0ed8c74dc49c87d3de9c27303602ec97357fa8ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a549ab3c32fcc2d2432965fddfa5d7f9396f3bd","unresolved":false,"context_lines":[{"line_number":603,"context_line":"        if use_admin_context:"},{"line_number":604,"context_line":"            search_opts_expected.update({\u0027fake_key\u0027: \u0027fake_value\u0027})"},{"line_number":605,"context_line":"            search_opts_expected[\u0027host\u0027] \u003d search_opts[\u0027host\u0027]"},{"line_number":606,"context_line":"            search_opts_expected[\u0027limit\u0027] \u003d \u00271\u0027"},{"line_number":607,"context_line":"            search_opts_expected[\u0027offset\u0027] \u003d \u00271\u0027"},{"line_number":608,"context_line":"        share_api.API.get_all.assert_called_once_with("},{"line_number":609,"context_line":"            req.environ[\u0027manila.context\u0027],"},{"line_number":610,"context_line":"            sort_key\u003dsearch_opts[\u0027sort_key\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_416d062d","line":607,"range":{"start_line":606,"start_character":12,"end_line":607,"end_character":48},"updated":"2019-09-04 23:39:09.000000000","message":"These should apply, no matter what context is used.","commit_id":"2bf2bb5cf08b07c318f81515c453d57e97e95598"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b709c693bef2475c4d674c93f541beedc80505b0","unresolved":false,"context_lines":[{"line_number":603,"context_line":"        if use_admin_context:"},{"line_number":604,"context_line":"            search_opts_expected.update({\u0027fake_key\u0027: \u0027fake_value\u0027})"},{"line_number":605,"context_line":"            search_opts_expected[\u0027host\u0027] \u003d search_opts[\u0027host\u0027]"},{"line_number":606,"context_line":"            search_opts_expected[\u0027limit\u0027] \u003d \u00271\u0027"},{"line_number":607,"context_line":"            search_opts_expected[\u0027offset\u0027] \u003d \u00271\u0027"},{"line_number":608,"context_line":"        share_api.API.get_all.assert_called_once_with("},{"line_number":609,"context_line":"            req.environ[\u0027manila.context\u0027],"},{"line_number":610,"context_line":"            sort_key\u003dsearch_opts[\u0027sort_key\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_da637541","line":607,"range":{"start_line":606,"start_character":12,"end_line":607,"end_character":48},"in_reply_to":"7faddb67_416d062d","updated":"2019-09-24 01:56:34.000000000","message":"Done","commit_id":"2bf2bb5cf08b07c318f81515c453d57e97e95598"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a549ab3c32fcc2d2432965fddfa5d7f9396f3bd","unresolved":false,"context_lines":[{"line_number":702,"context_line":"        if use_admin_context:"},{"line_number":703,"context_line":"            search_opts_expected.update({\u0027fake_key\u0027: \u0027fake_value\u0027})"},{"line_number":704,"context_line":"            search_opts_expected[\u0027host\u0027] \u003d search_opts[\u0027host\u0027]"},{"line_number":705,"context_line":"            search_opts_expected[\u0027limit\u0027] \u003d \u00271\u0027"},{"line_number":706,"context_line":"            search_opts_expected[\u0027offset\u0027] \u003d \u00271\u0027"},{"line_number":707,"context_line":"        share_api.API.get_all.assert_called_once_with("},{"line_number":708,"context_line":"            req.environ[\u0027manila.context\u0027],"},{"line_number":709,"context_line":"            sort_key\u003dsearch_opts[\u0027sort_key\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_01caae18","line":706,"range":{"start_line":705,"start_character":0,"end_line":706,"end_character":48},"updated":"2019-09-04 23:39:09.000000000","message":"same concern as above","commit_id":"2bf2bb5cf08b07c318f81515c453d57e97e95598"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b709c693bef2475c4d674c93f541beedc80505b0","unresolved":false,"context_lines":[{"line_number":702,"context_line":"        if use_admin_context:"},{"line_number":703,"context_line":"            search_opts_expected.update({\u0027fake_key\u0027: \u0027fake_value\u0027})"},{"line_number":704,"context_line":"            search_opts_expected[\u0027host\u0027] \u003d search_opts[\u0027host\u0027]"},{"line_number":705,"context_line":"            search_opts_expected[\u0027limit\u0027] \u003d \u00271\u0027"},{"line_number":706,"context_line":"            search_opts_expected[\u0027offset\u0027] \u003d \u00271\u0027"},{"line_number":707,"context_line":"        share_api.API.get_all.assert_called_once_with("},{"line_number":708,"context_line":"            req.environ[\u0027manila.context\u0027],"},{"line_number":709,"context_line":"            sort_key\u003dsearch_opts[\u0027sort_key\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_7a54c153","line":706,"range":{"start_line":705,"start_character":0,"end_line":706,"end_character":48},"in_reply_to":"7faddb67_01caae18","updated":"2019-09-24 01:56:34.000000000","message":"Done","commit_id":"2bf2bb5cf08b07c318f81515c453d57e97e95598"}],"manila/tests/api/v2/test_shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a549ab3c32fcc2d2432965fddfa5d7f9396f3bd","unresolved":false,"context_lines":[{"line_number":1626,"context_line":"            sort_dir\u003dsearch_opts[\u0027sort_dir\u0027],"},{"line_number":1627,"context_line":"            search_opts\u003dsearch_opts_expected,"},{"line_number":1628,"context_line":"        )"},{"line_number":1629,"context_line":"        self.assertEqual(1, len(result[\u0027shares\u0027]))"},{"line_number":1630,"context_line":"        self.assertEqual(shares[1][\u0027id\u0027], result[\u0027shares\u0027][0][\u0027id\u0027])"},{"line_number":1631,"context_line":"        self.assertEqual("},{"line_number":1632,"context_line":"            shares[1][\u0027display_name\u0027], result[\u0027shares\u0027][0][\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_c1e8167c","side":"PARENT","line":1629,"range":{"start_line":1629,"start_character":0,"end_line":1629,"end_character":50},"updated":"2019-09-04 23:39:09.000000000","message":"This assert still makes sense","commit_id":"0ed8c74dc49c87d3de9c27303602ec97357fa8ad"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b709c693bef2475c4d674c93f541beedc80505b0","unresolved":false,"context_lines":[{"line_number":1626,"context_line":"            sort_dir\u003dsearch_opts[\u0027sort_dir\u0027],"},{"line_number":1627,"context_line":"            search_opts\u003dsearch_opts_expected,"},{"line_number":1628,"context_line":"        )"},{"line_number":1629,"context_line":"        self.assertEqual(1, len(result[\u0027shares\u0027]))"},{"line_number":1630,"context_line":"        self.assertEqual(shares[1][\u0027id\u0027], result[\u0027shares\u0027][0][\u0027id\u0027])"},{"line_number":1631,"context_line":"        self.assertEqual("},{"line_number":1632,"context_line":"            shares[1][\u0027display_name\u0027], result[\u0027shares\u0027][0][\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_ba02396e","side":"PARENT","line":1629,"range":{"start_line":1629,"start_character":0,"end_line":1629,"end_character":50},"in_reply_to":"7faddb67_c1e8167c","updated":"2019-09-24 01:56:34.000000000","message":"Done","commit_id":"0ed8c74dc49c87d3de9c27303602ec97357fa8ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a549ab3c32fcc2d2432965fddfa5d7f9396f3bd","unresolved":false,"context_lines":[{"line_number":1764,"context_line":"                shares[1][\u0027instance\u0027][\u0027host\u0027], result[\u0027shares\u0027][0][\u0027host\u0027])"},{"line_number":1765,"context_line":"        self.assertEqual("},{"line_number":1766,"context_line":"            shares[1][\u0027instance\u0027][\u0027share_network_id\u0027],"},{"line_number":1767,"context_line":"            result[\u0027shares\u0027][0][\u0027share_network_id\u0027])"},{"line_number":1768,"context_line":"        if (api_version.APIVersionRequest(version) \u003e\u003d"},{"line_number":1769,"context_line":"                api_version.APIVersionRequest(\u00272.42\u0027)):"},{"line_number":1770,"context_line":"            self.assertEqual(3, result[\u0027count\u0027])"},{"line_number":1771,"context_line":""},{"line_number":1772,"context_line":"    def _list_detail_common_expected(self, admin\u003dFalse):"},{"line_number":1773,"context_line":"        share_dict \u003d {"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_41f42655","side":"PARENT","line":1770,"range":{"start_line":1767,"start_character":52,"end_line":1770,"end_character":48},"updated":"2019-09-04 23:39:09.000000000","message":"This assert should still exist, except the number of shares returned should be 1.","commit_id":"0ed8c74dc49c87d3de9c27303602ec97357fa8ad"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b709c693bef2475c4d674c93f541beedc80505b0","unresolved":false,"context_lines":[{"line_number":1764,"context_line":"                shares[1][\u0027instance\u0027][\u0027host\u0027], result[\u0027shares\u0027][0][\u0027host\u0027])"},{"line_number":1765,"context_line":"        self.assertEqual("},{"line_number":1766,"context_line":"            shares[1][\u0027instance\u0027][\u0027share_network_id\u0027],"},{"line_number":1767,"context_line":"            result[\u0027shares\u0027][0][\u0027share_network_id\u0027])"},{"line_number":1768,"context_line":"        if (api_version.APIVersionRequest(version) \u003e\u003d"},{"line_number":1769,"context_line":"                api_version.APIVersionRequest(\u00272.42\u0027)):"},{"line_number":1770,"context_line":"            self.assertEqual(3, result[\u0027count\u0027])"},{"line_number":1771,"context_line":""},{"line_number":1772,"context_line":"    def _list_detail_common_expected(self, admin\u003dFalse):"},{"line_number":1773,"context_line":"        share_dict \u003d {"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_5a6ea52f","side":"PARENT","line":1770,"range":{"start_line":1767,"start_character":52,"end_line":1770,"end_character":48},"in_reply_to":"7faddb67_41f42655","updated":"2019-09-24 01:56:34.000000000","message":"Yeah. Sure. Added it again.","commit_id":"0ed8c74dc49c87d3de9c27303602ec97357fa8ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a549ab3c32fcc2d2432965fddfa5d7f9396f3bd","unresolved":false,"context_lines":[{"line_number":1593,"context_line":"            {\u0027id\u0027: \u0027id3\u0027, \u0027display_name\u0027: \u0027n3\u0027},"},{"line_number":1594,"context_line":"        ]"},{"line_number":1595,"context_line":"        self.mock_object(share_api.API, \u0027get_all\u0027,"},{"line_number":1596,"context_line":"                         mock.Mock(return_value\u003dshares))"},{"line_number":1597,"context_line":""},{"line_number":1598,"context_line":"        result \u003d self.controller.index(req)"},{"line_number":1599,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_41dbc6e8","line":1596,"range":{"start_line":1596,"start_character":48,"end_line":1596,"end_character":54},"updated":"2019-09-04 23:39:09.000000000","message":"You\u0027re setting the limit and offset markers to \"1\" - which means you should retrieve only the second share...","commit_id":"2bf2bb5cf08b07c318f81515c453d57e97e95598"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6166714043c4b000806b106cb3216fb04eece609","unresolved":false,"context_lines":[{"line_number":1593,"context_line":"            {\u0027id\u0027: \u0027id3\u0027, \u0027display_name\u0027: \u0027n3\u0027},"},{"line_number":1594,"context_line":"        ]"},{"line_number":1595,"context_line":"        self.mock_object(share_api.API, \u0027get_all\u0027,"},{"line_number":1596,"context_line":"                         mock.Mock(return_value\u003dshares))"},{"line_number":1597,"context_line":""},{"line_number":1598,"context_line":"        result \u003d self.controller.index(req)"},{"line_number":1599,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_9d127060","line":1596,"range":{"start_line":1596,"start_character":48,"end_line":1596,"end_character":54},"in_reply_to":"7faddb67_41dbc6e8","updated":"2019-09-18 19:56:56.000000000","message":"Good. I\u0027ve changed it to return the first element.","commit_id":"2bf2bb5cf08b07c318f81515c453d57e97e95598"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b709c693bef2475c4d674c93f541beedc80505b0","unresolved":false,"context_lines":[{"line_number":1593,"context_line":"            {\u0027id\u0027: \u0027id3\u0027, \u0027display_name\u0027: \u0027n3\u0027},"},{"line_number":1594,"context_line":"        ]"},{"line_number":1595,"context_line":"        self.mock_object(share_api.API, \u0027get_all\u0027,"},{"line_number":1596,"context_line":"                         mock.Mock(return_value\u003dshares))"},{"line_number":1597,"context_line":""},{"line_number":1598,"context_line":"        result \u003d self.controller.index(req)"},{"line_number":1599,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_da1b757e","line":1596,"range":{"start_line":1596,"start_character":48,"end_line":1596,"end_character":54},"in_reply_to":"7faddb67_9d127060","updated":"2019-09-24 01:56:34.000000000","message":"Done","commit_id":"2bf2bb5cf08b07c318f81515c453d57e97e95598"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a549ab3c32fcc2d2432965fddfa5d7f9396f3bd","unresolved":false,"context_lines":[{"line_number":1623,"context_line":"        if use_admin_context:"},{"line_number":1624,"context_line":"            search_opts_expected.update({\u0027fake_key\u0027: \u0027fake_value\u0027})"},{"line_number":1625,"context_line":"            search_opts_expected[\u0027host\u0027] \u003d search_opts[\u0027host\u0027]"},{"line_number":1626,"context_line":"            search_opts_expected[\u0027limit\u0027] \u003d \u00271\u0027"},{"line_number":1627,"context_line":"            search_opts_expected[\u0027offset\u0027] \u003d \u00271\u0027"},{"line_number":1628,"context_line":"        share_api.API.get_all.assert_called_once_with("},{"line_number":1629,"context_line":"            req.environ[\u0027manila.context\u0027],"},{"line_number":1630,"context_line":"            sort_key\u003dsearch_opts[\u0027sort_key\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_e1ef5284","line":1627,"range":{"start_line":1626,"start_character":0,"end_line":1627,"end_character":48},"updated":"2019-09-04 23:39:09.000000000","message":"This should apply irrespective of the requester\u0027s context..","commit_id":"2bf2bb5cf08b07c318f81515c453d57e97e95598"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b709c693bef2475c4d674c93f541beedc80505b0","unresolved":false,"context_lines":[{"line_number":1623,"context_line":"        if use_admin_context:"},{"line_number":1624,"context_line":"            search_opts_expected.update({\u0027fake_key\u0027: \u0027fake_value\u0027})"},{"line_number":1625,"context_line":"            search_opts_expected[\u0027host\u0027] \u003d search_opts[\u0027host\u0027]"},{"line_number":1626,"context_line":"            search_opts_expected[\u0027limit\u0027] \u003d \u00271\u0027"},{"line_number":1627,"context_line":"            search_opts_expected[\u0027offset\u0027] \u003d \u00271\u0027"},{"line_number":1628,"context_line":"        share_api.API.get_all.assert_called_once_with("},{"line_number":1629,"context_line":"            req.environ[\u0027manila.context\u0027],"},{"line_number":1630,"context_line":"            sort_key\u003dsearch_opts[\u0027sort_key\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_ba10f9a9","line":1627,"range":{"start_line":1626,"start_character":0,"end_line":1627,"end_character":48},"in_reply_to":"7faddb67_e1ef5284","updated":"2019-09-24 01:56:34.000000000","message":"Done","commit_id":"2bf2bb5cf08b07c318f81515c453d57e97e95598"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a549ab3c32fcc2d2432965fddfa5d7f9396f3bd","unresolved":false,"context_lines":[{"line_number":1631,"context_line":"            sort_dir\u003dsearch_opts[\u0027sort_dir\u0027],"},{"line_number":1632,"context_line":"            search_opts\u003dsearch_opts_expected,"},{"line_number":1633,"context_line":"        )"},{"line_number":1634,"context_line":"        self.assertEqual(shares[1][\u0027id\u0027], result[\u0027shares\u0027][1][\u0027id\u0027])"},{"line_number":1635,"context_line":"        self.assertEqual("},{"line_number":1636,"context_line":"            shares[1][\u0027display_name\u0027], result[\u0027shares\u0027][1][\u0027name\u0027])"},{"line_number":1637,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_a1e5daa5","line":1634,"range":{"start_line":1634,"start_character":59,"end_line":1634,"end_character":60},"updated":"2019-09-04 23:39:09.000000000","message":"0 is still accurate, if you fix the mock return value on line 1596","commit_id":"2bf2bb5cf08b07c318f81515c453d57e97e95598"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b709c693bef2475c4d674c93f541beedc80505b0","unresolved":false,"context_lines":[{"line_number":1631,"context_line":"            sort_dir\u003dsearch_opts[\u0027sort_dir\u0027],"},{"line_number":1632,"context_line":"            search_opts\u003dsearch_opts_expected,"},{"line_number":1633,"context_line":"        )"},{"line_number":1634,"context_line":"        self.assertEqual(shares[1][\u0027id\u0027], result[\u0027shares\u0027][1][\u0027id\u0027])"},{"line_number":1635,"context_line":"        self.assertEqual("},{"line_number":1636,"context_line":"            shares[1][\u0027display_name\u0027], result[\u0027shares\u0027][1][\u0027name\u0027])"},{"line_number":1637,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_da07f581","line":1634,"range":{"start_line":1634,"start_character":59,"end_line":1634,"end_character":60},"in_reply_to":"7faddb67_a1e5daa5","updated":"2019-09-24 01:56:34.000000000","message":"Done","commit_id":"2bf2bb5cf08b07c318f81515c453d57e97e95598"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a549ab3c32fcc2d2432965fddfa5d7f9396f3bd","unresolved":false,"context_lines":[{"line_number":1741,"context_line":"        if use_admin_context:"},{"line_number":1742,"context_line":"            search_opts_expected.update({\u0027fake_key\u0027: \u0027fake_value\u0027})"},{"line_number":1743,"context_line":"            search_opts_expected[\u0027host\u0027] \u003d search_opts[\u0027host\u0027]"},{"line_number":1744,"context_line":"            search_opts_expected[\u0027limit\u0027] \u003d \u00271\u0027"},{"line_number":1745,"context_line":"            search_opts_expected[\u0027offset\u0027] \u003d \u00271\u0027"},{"line_number":1746,"context_line":"        share_api.API.get_all.assert_called_once_with("},{"line_number":1747,"context_line":"            req.environ[\u0027manila.context\u0027],"},{"line_number":1748,"context_line":"            sort_key\u003dsearch_opts[\u0027sort_key\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_61036243","line":1745,"range":{"start_line":1744,"start_character":0,"end_line":1745,"end_character":48},"updated":"2019-09-04 23:39:09.000000000","message":"same concern as above","commit_id":"2bf2bb5cf08b07c318f81515c453d57e97e95598"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b709c693bef2475c4d674c93f541beedc80505b0","unresolved":false,"context_lines":[{"line_number":1741,"context_line":"        if use_admin_context:"},{"line_number":1742,"context_line":"            search_opts_expected.update({\u0027fake_key\u0027: \u0027fake_value\u0027})"},{"line_number":1743,"context_line":"            search_opts_expected[\u0027host\u0027] \u003d search_opts[\u0027host\u0027]"},{"line_number":1744,"context_line":"            search_opts_expected[\u0027limit\u0027] \u003d \u00271\u0027"},{"line_number":1745,"context_line":"            search_opts_expected[\u0027offset\u0027] \u003d \u00271\u0027"},{"line_number":1746,"context_line":"        share_api.API.get_all.assert_called_once_with("},{"line_number":1747,"context_line":"            req.environ[\u0027manila.context\u0027],"},{"line_number":1748,"context_line":"            sort_key\u003dsearch_opts[\u0027sort_key\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_da7a95ef","line":1745,"range":{"start_line":1744,"start_character":0,"end_line":1745,"end_character":48},"in_reply_to":"7faddb67_61036243","updated":"2019-09-24 01:56:34.000000000","message":"Done","commit_id":"2bf2bb5cf08b07c318f81515c453d57e97e95598"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"179843f87973f8b62c8beb5d8737a4146f5bd744","unresolved":false,"context_lines":[{"line_number":1630,"context_line":"        self.assertEqual(shares[1][\u0027id\u0027], result[\u0027shares\u0027][0][\u0027id\u0027])"},{"line_number":1631,"context_line":"        self.assertEqual("},{"line_number":1632,"context_line":"            shares[1][\u0027display_name\u0027], result[\u0027shares\u0027][0][\u0027name\u0027])"},{"line_number":1633,"context_line":"        if (api_version.APIVersionRequest(version) \u003e\u003d"},{"line_number":1634,"context_line":"                api_version.APIVersionRequest(\u00272.42\u0027)):"},{"line_number":1635,"context_line":"            self.assertEqual(3, result[\u0027count\u0027])"},{"line_number":1636,"context_line":""},{"line_number":1637,"context_line":"    def test_share_list_summary(self):"},{"line_number":1638,"context_line":"        self.mock_object(share_api.API, \u0027get_all\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_f33d0c8f","side":"PARENT","line":1635,"range":{"start_line":1633,"start_character":0,"end_line":1635,"end_character":48},"updated":"2019-09-26 00:23:12.000000000","message":"Retain this, but do what you\u0027re doing on https://review.opendev.org/#/c/650986/9/manila/tests/api/v2/test_shares.py@1718","commit_id":"0ed8c74dc49c87d3de9c27303602ec97357fa8ad"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"210bb686413b48b9a35aa0ab492269e3e0427945","unresolved":false,"context_lines":[{"line_number":1630,"context_line":"        self.assertEqual(shares[1][\u0027id\u0027], result[\u0027shares\u0027][0][\u0027id\u0027])"},{"line_number":1631,"context_line":"        self.assertEqual("},{"line_number":1632,"context_line":"            shares[1][\u0027display_name\u0027], result[\u0027shares\u0027][0][\u0027name\u0027])"},{"line_number":1633,"context_line":"        if (api_version.APIVersionRequest(version) \u003e\u003d"},{"line_number":1634,"context_line":"                api_version.APIVersionRequest(\u00272.42\u0027)):"},{"line_number":1635,"context_line":"            self.assertEqual(3, result[\u0027count\u0027])"},{"line_number":1636,"context_line":""},{"line_number":1637,"context_line":"    def test_share_list_summary(self):"},{"line_number":1638,"context_line":"        self.mock_object(share_api.API, \u0027get_all\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_febcf306","side":"PARENT","line":1635,"range":{"start_line":1633,"start_character":0,"end_line":1635,"end_character":48},"in_reply_to":"3fa7e38b_f33d0c8f","updated":"2019-09-26 03:01:07.000000000","message":"Yep. This method is doing what is on line 1718. Just added it again and changed the assert to assertEqual(1, result[\u0027count\u0027]). Is it what you meant?","commit_id":"0ed8c74dc49c87d3de9c27303602ec97357fa8ad"}],"manila/tests/db/sqlalchemy/test_api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a549ab3c32fcc2d2432965fddfa5d7f9396f3bd","unresolved":false,"context_lines":[{"line_number":549,"context_line":"    def test_share_get_all_with_limit(self, limit, offset):"},{"line_number":550,"context_line":"        for i in range(limit + 5):"},{"line_number":551,"context_line":"            db_utils.create_share()"},{"line_number":552,"context_line":"        filter \u003d {\u0027limit\u0027: limit, \u0027offset\u0027: offset}"},{"line_number":553,"context_line":"        actual_result \u003d db_api.share_get_all(self.ctxt, filters\u003dfilter)"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"        self.assertEqual(limit, len(actual_result))"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_e1bd1268","line":552,"range":{"start_line":552,"start_character":8,"end_line":552,"end_character":14},"updated":"2019-09-04 23:39:09.000000000","message":"you\u0027re shadowing a python builtin called \"filter\". Perhaps rename this \"filters\"","commit_id":"2bf2bb5cf08b07c318f81515c453d57e97e95598"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b709c693bef2475c4d674c93f541beedc80505b0","unresolved":false,"context_lines":[{"line_number":549,"context_line":"    def test_share_get_all_with_limit(self, limit, offset):"},{"line_number":550,"context_line":"        for i in range(limit + 5):"},{"line_number":551,"context_line":"            db_utils.create_share()"},{"line_number":552,"context_line":"        filter \u003d {\u0027limit\u0027: limit, \u0027offset\u0027: offset}"},{"line_number":553,"context_line":"        actual_result \u003d db_api.share_get_all(self.ctxt, filters\u003dfilter)"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"        self.assertEqual(limit, len(actual_result))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_1ae26da1","line":552,"range":{"start_line":552,"start_character":8,"end_line":552,"end_character":14},"in_reply_to":"7faddb67_e1bd1268","updated":"2019-09-24 01:56:34.000000000","message":"Well observed, thanks. Changed the variable name.","commit_id":"2bf2bb5cf08b07c318f81515c453d57e97e95598"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a549ab3c32fcc2d2432965fddfa5d7f9396f3bd","unresolved":false,"context_lines":[{"line_number":550,"context_line":"        for i in range(limit + 5):"},{"line_number":551,"context_line":"            db_utils.create_share()"},{"line_number":552,"context_line":"        filter \u003d {\u0027limit\u0027: limit, \u0027offset\u0027: offset}"},{"line_number":553,"context_line":"        actual_result \u003d db_api.share_get_all(self.ctxt, filters\u003dfilter)"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"        self.assertEqual(limit, len(actual_result))"},{"line_number":556,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_21556a1e","line":553,"range":{"start_line":553,"start_character":8,"end_line":553,"end_character":71},"updated":"2019-09-04 23:39:09.000000000","message":"To prove offset is working, I would try to retrieve the other shares and assert that the IDs of the other shares aren\u0027t there in this result.. \n\n  filters \u003d {\u0027limit\u0027: offset, \u0027offset\u0027: 0}\n  shares_not_requested \u003d db_api.share_get_all(self.ctxt, filters\u003dfilters)\n\n  filters \u003d {\u0027limit\u0027: limit, \u0027offset\u0027: offset}\n  shares_requested \u003d db_api.share_get_all(self.ctxt, filters\u003dfilters)\n\n \n\n  shares_not_requested_ids \u003d [s[\u0027id\u0027] for s in shares_not_requested]\n  shares_requested_ids \u003d [s[\u0027id\u0027] for s in shares_requested]\n\n \n\n  self.assertEqual(offset, len(shares_not_requested_ids))\n  self.assertEqual(limit, len(shares_requested_ids))\n  self.assertEqual(0, len(set(shares_requested_ids) \u0026 set(shares_requested_ids))","commit_id":"2bf2bb5cf08b07c318f81515c453d57e97e95598"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b709c693bef2475c4d674c93f541beedc80505b0","unresolved":false,"context_lines":[{"line_number":550,"context_line":"        for i in range(limit + 5):"},{"line_number":551,"context_line":"            db_utils.create_share()"},{"line_number":552,"context_line":"        filter \u003d {\u0027limit\u0027: limit, \u0027offset\u0027: offset}"},{"line_number":553,"context_line":"        actual_result \u003d db_api.share_get_all(self.ctxt, filters\u003dfilter)"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"        self.assertEqual(limit, len(actual_result))"},{"line_number":556,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_fdef4b1b","line":553,"range":{"start_line":553,"start_character":8,"end_line":553,"end_character":71},"in_reply_to":"7faddb67_21556a1e","updated":"2019-09-24 01:56:34.000000000","message":"Great suggestion, thanks. I\u0027ve modified few things regarding your suggestion. First, I\u0027ve added a sort_dir\u003d\u0027asc\u0027 while using the shares_get_all_method for the first time. If I keep as it was, it was ever going to retrieve the results in the same order and the shares_requested and shares_not_requested lists were having equal items. In this way, I\u0027m also able to do another thing you just suggested (check if the ids of the other shares are not there in the results).","commit_id":"2bf2bb5cf08b07c318f81515c453d57e97e95598"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a64bfd2a606c42bebb796f6a6960ffd37972dad2","unresolved":false,"context_lines":[{"line_number":564,"context_line":"        self.assertEqual(limit, len(shares_requested_ids))"},{"line_number":565,"context_line":"        self.assertEqual(0, len("},{"line_number":566,"context_line":"            set(shares_requested_ids) \u0026 set(shares_not_requested_ids)))"},{"line_number":567,"context_line":"        for share_id in shares_not_requested_ids:"},{"line_number":568,"context_line":"            self.assertNotIn(share_id, shares_requested_ids)"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    @ddt.data(None, \u0027writable\u0027)"},{"line_number":571,"context_line":"    def test_share_get_has_replicas_field(self, replication_type):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_fdc2eb58","line":568,"range":{"start_line":567,"start_character":8,"end_line":568,"end_character":60},"updated":"2019-09-24 02:13:11.000000000","message":"Not needed. Will remove.","commit_id":"834868c6f22dad0757c460dde88e4abdfc49e51d"}],"releasenotes/notes/bug-1795463-fix-pagination-slowness-8fcda3746aa13940.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fd4a00b1b1d5baee5909037754986b2c2c11571e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When the OpenStack administrator has a busy environment that contains many"},{"line_number":5,"context_line":"    shares, the list operation with `--limit` parameter was taking too long to"},{"line_number":6,"context_line":"    respond. This slowness has now been fixed. See the `launchpad bug 1795463"},{"line_number":7,"context_line":"    \u003chttps://bugs.launchpad.net/manila/+bug/1795463\u003e`."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_ee044517","line":6,"range":{"start_line":6,"start_character":18,"end_line":6,"end_character":26},"updated":"2019-08-01 16:20:31.000000000","message":"lag","commit_id":"6e850f9f1074f889992989cf6a8a0f81a04128dd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fd4a00b1b1d5baee5909037754986b2c2c11571e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When the OpenStack administrator has a busy environment that contains many"},{"line_number":5,"context_line":"    shares, the list operation with `--limit` parameter was taking too long to"},{"line_number":6,"context_line":"    respond. This slowness has now been fixed. See the `launchpad bug 1795463"},{"line_number":7,"context_line":"    \u003chttps://bugs.launchpad.net/manila/+bug/1795463\u003e`."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_2e16dd4a","line":7,"range":{"start_line":6,"start_character":55,"end_line":7,"end_character":53},"updated":"2019-08-01 16:20:31.000000000","message":"`launchpad bug 1795463 \n    \u003chttps://bugs.launchpad.net/manila/+bug/1795463\u003e`_.","commit_id":"6e850f9f1074f889992989cf6a8a0f81a04128dd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a549ab3c32fcc2d2432965fddfa5d7f9396f3bd","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When the OpenStack administrator has a busy environment that contains many"},{"line_number":5,"context_line":"    shares, the list operation with `--limit` parameter was taking too long to"},{"line_number":6,"context_line":"    respond. This lag has now been fixed. See the `launchpad bug 1795463 "},{"line_number":7,"context_line":"    \u003chttps://bugs.launchpad.net/manila/+bug/1795463\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_e130b209","line":6,"range":{"start_line":6,"start_character":71,"end_line":6,"end_character":72},"updated":"2019-09-04 23:39:09.000000000","message":"nit: remove the trailing space after this","commit_id":"2bf2bb5cf08b07c318f81515c453d57e97e95598"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b709c693bef2475c4d674c93f541beedc80505b0","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When the OpenStack administrator has a busy environment that contains many"},{"line_number":5,"context_line":"    shares, the list operation with `--limit` parameter was taking too long to"},{"line_number":6,"context_line":"    respond. This lag has now been fixed. See the `launchpad bug 1795463 "},{"line_number":7,"context_line":"    \u003chttps://bugs.launchpad.net/manila/+bug/1795463\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_dac85523","line":6,"range":{"start_line":6,"start_character":71,"end_line":6,"end_character":72},"in_reply_to":"7faddb67_e130b209","updated":"2019-09-24 01:56:34.000000000","message":"Done","commit_id":"2bf2bb5cf08b07c318f81515c453d57e97e95598"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a549ab3c32fcc2d2432965fddfa5d7f9396f3bd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    When the OpenStack administrator has a busy environment that contains many"},{"line_number":5,"context_line":"    shares, the list operation with `--limit` parameter was taking too long to"},{"line_number":6,"context_line":"    respond. This lag has now been fixed. See the `launchpad bug 1795463 "},{"line_number":7,"context_line":"    \u003chttps://bugs.launchpad.net/manila/+bug/1795463\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_a1363a01","line":7,"range":{"start_line":7,"start_character":54,"end_line":7,"end_character":55},"updated":"2019-09-04 23:39:09.000000000","message":"nit: \"for more details\"","commit_id":"2bf2bb5cf08b07c318f81515c453d57e97e95598"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b709c693bef2475c4d674c93f541beedc80505b0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    When the OpenStack administrator has a busy environment that contains many"},{"line_number":5,"context_line":"    shares, the list operation with `--limit` parameter was taking too long to"},{"line_number":6,"context_line":"    respond. This lag has now been fixed. See the `launchpad bug 1795463 "},{"line_number":7,"context_line":"    \u003chttps://bugs.launchpad.net/manila/+bug/1795463\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_facd1131","line":7,"range":{"start_line":7,"start_character":54,"end_line":7,"end_character":55},"in_reply_to":"7faddb67_a1363a01","updated":"2019-09-24 01:56:34.000000000","message":"Done","commit_id":"2bf2bb5cf08b07c318f81515c453d57e97e95598"}]}