)]}'
{"manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7f23c28fba5df0887d33f1b6ae3386d9ac48668d","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        if not self._licenses:"},{"line_number":259,"context_line":"            self._licenses \u003d self._client.get_licenses()"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        if \u0027snaprestore\u0027 not in self._licenses:"},{"line_number":262,"context_line":"            return False"},{"line_number":263,"context_line":"        else:"},{"line_number":264,"context_line":"            return True"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    @na_utils.trace"},{"line_number":267,"context_line":"    def _get_aggregate_node(self, aggregate_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_ebcc3b36","line":264,"range":{"start_line":261,"start_character":8,"end_line":264,"end_character":23},"updated":"2019-06-27 00:55:20.000000000","message":"or simply, \n\n  return \u0027snaprestore\u0027 in self._licenses","commit_id":"2953c1c427cf3ed6e328ee7c447d685e60a798d0"},{"author":{"_account_id":29831,"name":"Naresh Kumar Gunjalli","email":"NareshKumar.Gunjalli@netapp.com","username":"nareshkumarg"},"change_message_id":"63e6a2699ef85ca7b4525317633627e527d2dfcc","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        if not self._licenses:"},{"line_number":259,"context_line":"            self._licenses \u003d self._client.get_licenses()"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        if \u0027snaprestore\u0027 not in self._licenses:"},{"line_number":262,"context_line":"            return False"},{"line_number":263,"context_line":"        else:"},{"line_number":264,"context_line":"            return True"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    @na_utils.trace"},{"line_number":267,"context_line":"    def _get_aggregate_node(self, aggregate_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_f19c0ec1","line":264,"range":{"start_line":261,"start_character":8,"end_line":264,"end_character":23},"in_reply_to":"9fb8cfa7_ebcc3b36","updated":"2019-06-28 09:42:46.000000000","message":"Done","commit_id":"2953c1c427cf3ed6e328ee7c447d685e60a798d0"}],"manila/tests/share/drivers/netapp/dataontap/cluster_mode/test_lib_base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7f23c28fba5df0887d33f1b6ae3386d9ac48668d","unresolved":false,"context_lines":[{"line_number":336,"context_line":"                         \u0027get_licenses\u0027,"},{"line_number":337,"context_line":"                         mock.Mock(return_value\u003dlicenses))"},{"line_number":338,"context_line":"        result \u003d self.library._check_snaprestore_license()"},{"line_number":339,"context_line":"        self.assertFalse(result)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"    def test_check_snaprestore_license_found(self):"},{"line_number":342,"context_line":"        self.mock_object(self.client,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_8b581f8a","line":339,"range":{"start_line":339,"start_character":13,"end_line":339,"end_character":24},"updated":"2019-06-27 00:55:20.000000000","message":"assertEqual(False, result)\n\nhttps://jamescooke.info/python-unittest-asserttrue-is-truthy-assertfalse-is-falsy.html","commit_id":"2953c1c427cf3ed6e328ee7c447d685e60a798d0"},{"author":{"_account_id":29831,"name":"Naresh Kumar Gunjalli","email":"NareshKumar.Gunjalli@netapp.com","username":"nareshkumarg"},"change_message_id":"63e6a2699ef85ca7b4525317633627e527d2dfcc","unresolved":false,"context_lines":[{"line_number":336,"context_line":"                         \u0027get_licenses\u0027,"},{"line_number":337,"context_line":"                         mock.Mock(return_value\u003dlicenses))"},{"line_number":338,"context_line":"        result \u003d self.library._check_snaprestore_license()"},{"line_number":339,"context_line":"        self.assertFalse(result)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"    def test_check_snaprestore_license_found(self):"},{"line_number":342,"context_line":"        self.mock_object(self.client,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_b1a216fb","line":339,"range":{"start_line":339,"start_character":13,"end_line":339,"end_character":24},"in_reply_to":"9fb8cfa7_8b581f8a","updated":"2019-06-28 09:42:46.000000000","message":"Done","commit_id":"2953c1c427cf3ed6e328ee7c447d685e60a798d0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7f23c28fba5df0887d33f1b6ae3386d9ac48668d","unresolved":false,"context_lines":[{"line_number":343,"context_line":"                         \u0027get_licenses\u0027,"},{"line_number":344,"context_line":"                         mock.Mock(return_value\u003dfake.LICENSES))"},{"line_number":345,"context_line":"        result \u003d self.library._check_snaprestore_license()"},{"line_number":346,"context_line":"        self.assertTrue(result)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    def test_get_aggregate_node_cluster_creds(self):"},{"line_number":349,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_ab5de379","line":346,"range":{"start_line":346,"start_character":13,"end_line":346,"end_character":23},"updated":"2019-06-27 00:55:20.000000000","message":"assertEqual(True, result)","commit_id":"2953c1c427cf3ed6e328ee7c447d685e60a798d0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3ee76e15d5aed45038096316acc06a7bee0e7bc7","unresolved":false,"context_lines":[{"line_number":343,"context_line":"                         \u0027get_licenses\u0027,"},{"line_number":344,"context_line":"                         mock.Mock(return_value\u003dfake.LICENSES))"},{"line_number":345,"context_line":"        result \u003d self.library._check_snaprestore_license()"},{"line_number":346,"context_line":"        self.assertTrue(result)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    def test_get_aggregate_node_cluster_creds(self):"},{"line_number":349,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_9a75a266","line":346,"range":{"start_line":346,"start_character":13,"end_line":346,"end_character":23},"in_reply_to":"9fb8cfa7_91ab52d4","updated":"2019-06-28 17:46:39.000000000","message":"Ah, that\u0027s right, I forgot we had M313.. \n\nCan you update both of these to use assertIs()?\n\n self.assertIs(True, result)\n self.assertIs(False, result)\n\nis a better check than self.assertTrue(result). It\u0027s hard to write a hacking check for assertIs(True, ...) vs assertTrue(...), because we can\u0027t always anticipate that the called is expecting a truthy value, as opposed to the boolean ``True``.","commit_id":"2953c1c427cf3ed6e328ee7c447d685e60a798d0"},{"author":{"_account_id":29831,"name":"Naresh Kumar Gunjalli","email":"NareshKumar.Gunjalli@netapp.com","username":"nareshkumarg"},"change_message_id":"63e6a2699ef85ca7b4525317633627e527d2dfcc","unresolved":false,"context_lines":[{"line_number":343,"context_line":"                         \u0027get_licenses\u0027,"},{"line_number":344,"context_line":"                         mock.Mock(return_value\u003dfake.LICENSES))"},{"line_number":345,"context_line":"        result \u003d self.library._check_snaprestore_license()"},{"line_number":346,"context_line":"        self.assertTrue(result)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    def test_get_aggregate_node_cluster_creds(self):"},{"line_number":349,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_91ab52d4","line":346,"range":{"start_line":346,"start_character":13,"end_line":346,"end_character":23},"in_reply_to":"9fb8cfa7_ab5de379","updated":"2019-06-28 09:42:46.000000000","message":"Am unable to do this as pep8 unit tests is complaining about it..\nmanila/tests/share/drivers/netapp/dataontap/cluster_mode/test_lib_base.py:346:9: M313  Unit tests should use assertTrue(value) instead of using assertEqual(True, value).\nERROR: InvocationError for command /opt/stack/new/manila/.tox/pep8/bin/flake8 manila (exited with code 1)","commit_id":"2953c1c427cf3ed6e328ee7c447d685e60a798d0"}]}