)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"338ea876edc56e53504cfb244ae9c79db44689c6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Corey Bryant \u003ccorey.bryant@canonical.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-05 11:52:41 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Python 3 Train unit tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a mechanically generated patch to ensure unit testing is in place"},{"line_number":10,"context_line":"for all of the Tested Runtimes for Train."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_a6efa2ae","line":7,"updated":"2019-07-10 15:36:12.000000000","message":"We already have 3.6 and 3.7 unit tests, please change to \"Standardize Python 3 unit test jobs\" or some such.","commit_id":"65c1e3507dfce36dbbf6e089ec6c0f8291d906c1"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"9ff1e8615522f5d8cf1ef748bca359a81254fe79","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Corey Bryant \u003ccorey.bryant@canonical.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-05 11:52:41 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Python 3 Train unit tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a mechanically generated patch to ensure unit testing is in place"},{"line_number":10,"context_line":"for all of the Tested Runtimes for Train."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_e7ad9431","line":7,"in_reply_to":"7faddb67_8778602a","updated":"2019-07-10 17:49:33.000000000","message":"My point is only that the header implies that Python 3 Train unit tests aren\u0027t there already and we already made a specific effort to test with python 3.6 and 3.7 in gate to meet the goal.  But since this is a mechanically generated patch I won\u0027t continue to ask that the commit header be refined for accuracy the way we do in the normal course of reviews with human generated patches.","commit_id":"65c1e3507dfce36dbbf6e089ec6c0f8291d906c1"},{"author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"change_message_id":"74d27425339e66002643e8eb8f20a47104dbc906","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Corey Bryant \u003ccorey.bryant@canonical.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-05 11:52:41 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Python 3 Train unit tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a mechanically generated patch to ensure unit testing is in place"},{"line_number":10,"context_line":"for all of the Tested Runtimes for Train."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_8778602a","line":7,"in_reply_to":"7faddb67_a6efa2ae","updated":"2019-07-10 17:21:29.000000000","message":"But this patch is adding openstack-python3-train-jobs. Sorry I don\u0027t really get this comment. This is a lot of churn for such a small patch that is also landing across the rest of openstack.","commit_id":"65c1e3507dfce36dbbf6e089ec6c0f8291d906c1"}],"tox.ini":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"af93093303f53698521fd2a86f187a41a11d357e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 2.0"},{"line_number":3,"context_line":"skipsdist \u003d True"},{"line_number":4,"context_line":"envlist \u003d py27,py37,pep8"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"},{"line_number":7,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"7faddb67_31c79248","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":19},"updated":"2019-07-08 21:30:10.000000000","message":"Can we leave the default envlist at py3?\nThis enables us to test with whatever version of python3 is installed","commit_id":"65c1e3507dfce36dbbf6e089ec6c0f8291d906c1"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"9ff1e8615522f5d8cf1ef748bca359a81254fe79","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 2.0"},{"line_number":3,"context_line":"skipsdist \u003d True"},{"line_number":4,"context_line":"envlist \u003d py27,py37,pep8"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"},{"line_number":7,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"7faddb67_47326812","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":19},"in_reply_to":"7faddb67_27b64cdb","updated":"2019-07-10 17:49:33.000000000","message":"I hate to be a PITA but our request is to not change tox.ini unnecessarily.","commit_id":"65c1e3507dfce36dbbf6e089ec6c0f8291d906c1"},{"author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"change_message_id":"d34bc78b23ca7af57d3212de6aa19a97b4dda624","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 2.0"},{"line_number":3,"context_line":"skipsdist \u003d True"},{"line_number":4,"context_line":"envlist \u003d py27,py37,pep8"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"},{"line_number":7,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"7faddb67_a92b0e2e","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":19},"in_reply_to":"7faddb67_31c79248","updated":"2019-07-09 13:27:22.000000000","message":"Yes, you can. It\u0027s just misleading because the gate will catch py36/py37 bugs and the developer could be running py34 or py35 if you use py3 in the envlist.","commit_id":"65c1e3507dfce36dbbf6e089ec6c0f8291d906c1"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"8a2a67598b014cd9ff9705fe24701a1f72f3f7b7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 2.0"},{"line_number":3,"context_line":"skipsdist \u003d True"},{"line_number":4,"context_line":"envlist \u003d py27,py37,pep8"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"},{"line_number":7,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"7faddb67_72ac0c34","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":19},"in_reply_to":"7faddb67_327a14f1","updated":"2019-07-10 13:00:37.000000000","message":"True, but my point is that there is no actual gain in gate coverage (that\u0027s handled by the jobs) and there\u0027s a slight extra burden for new contributors and for us supporting them.  One more thing to explain that doesn\u0027t actually gain anything.","commit_id":"65c1e3507dfce36dbbf6e089ec6c0f8291d906c1"},{"author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"change_message_id":"e58dced43fc4a46e1af397fcb27a4a59941913c0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 2.0"},{"line_number":3,"context_line":"skipsdist \u003d True"},{"line_number":4,"context_line":"envlist \u003d py27,py37,pep8"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"},{"line_number":7,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"7faddb67_327a14f1","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":19},"in_reply_to":"7faddb67_6bd50343","updated":"2019-07-10 12:50:39.000000000","message":"Note they can still run basic unit tests by specifying the py3 env explicitly, ie. \u0027tox -e py36\u0027 etc. This is only what gets run by the default \u0027tox\u0027 command.","commit_id":"65c1e3507dfce36dbbf6e089ec6c0f8291d906c1"},{"author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"change_message_id":"ae84b34b6d3841e31cc67562ad14662bc8355d06","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 2.0"},{"line_number":3,"context_line":"skipsdist \u003d True"},{"line_number":4,"context_line":"envlist \u003d py27,py37,pep8"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"},{"line_number":7,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"7faddb67_d537eae2","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":19},"in_reply_to":"7faddb67_72ac0c34","updated":"2019-07-10 13:08:20.000000000","message":"Yes I can see that. But I\u0027d argue that there is a gain in if you are developing software that supports Python 3.7 you should probably be encouraged to develop that software on a modern operating system that supports it.","commit_id":"65c1e3507dfce36dbbf6e089ec6c0f8291d906c1"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"32dfdba598dc31e604fa33b6d06754f0365038c9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 2.0"},{"line_number":3,"context_line":"skipsdist \u003d True"},{"line_number":4,"context_line":"envlist \u003d py27,py37,pep8"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"},{"line_number":7,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"7faddb67_6bd50343","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":19},"in_reply_to":"7faddb67_a92b0e2e","updated":"2019-07-09 20:43:59.000000000","message":"We are running py36 and py37 in gate so there is no chance that we won\u0027t test these pre-merge.  It\u0027s a convenience for developers to be able to run basic unit tests on their laptops even if the latest py3 isn\u0027t installed there.\n\nWe deliberately set the version in envlist to py3 for this reason.\n\nSo I this is a step backwards.","commit_id":"65c1e3507dfce36dbbf6e089ec6c0f8291d906c1"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"338ea876edc56e53504cfb244ae9c79db44689c6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 2.0"},{"line_number":3,"context_line":"skipsdist \u003d True"},{"line_number":4,"context_line":"envlist \u003d py27,py37,pep8"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"},{"line_number":7,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"7faddb67_e6ccba62","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":19},"in_reply_to":"7faddb67_d537eae2","updated":"2019-07-10 15:36:12.000000000","message":"That\u0027s a reasonable opinion, but it goes way beyond the scope of meeting the cross-project goal of testing 3.6 and 3.7 in gate.","commit_id":"65c1e3507dfce36dbbf6e089ec6c0f8291d906c1"},{"author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"change_message_id":"74d27425339e66002643e8eb8f20a47104dbc906","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 2.0"},{"line_number":3,"context_line":"skipsdist \u003d True"},{"line_number":4,"context_line":"envlist \u003d py27,py37,pep8"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"},{"line_number":7,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"7faddb67_27b64cdb","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":19},"in_reply_to":"7faddb67_e6ccba62","updated":"2019-07-10 17:21:29.000000000","message":"It\u0027s not beyond the scope at all. It\u0027s written in the TC train goal as a stretch goal. That behind said, it is a stretch goal so I interpret that as not a requirement to meet the goal, so I can drop this bit. https://governance.openstack.org/tc/goals/train/python3-updates.html","commit_id":"65c1e3507dfce36dbbf6e089ec6c0f8291d906c1"}]}