)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7e5ca3d66c57789a7d3a9f4767873d6084cc8349","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     DingDong \u003cDong.ding@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-09-05 04:01:33 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Unity] Driver supports the mode that does not create and destory share servers (DHSS\u003dFalse)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Support \u0027driver_handles_share_servers \u003d False\u0027 in manila.conf."},{"line_number":10,"context_line":"In such mode, need set unity_share_server in manila.conf, driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5faad753_672533ab","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":92},"updated":"2019-09-10 22:50:33.000000000","message":"Please keep the title of your commit message under 50 characters:\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"8d26a34cd1aa8242289420a52e10eba2614cf0e6"}],"doc/source/admin/emc_unity_driver.rst":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"5efc22df2ed88190bba5458ce7e5fb3bf085643c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"Requirements"},{"line_number":35,"context_line":"------------"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- Unity OE 4.0.1 or higher."},{"line_number":38,"context_line":"- StorOps 1.1.0 or higher is installed on Manila node."},{"line_number":39,"context_line":"- Following licenses are activated on Unity:"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"5faad753_cadc4848","line":37,"updated":"2019-09-10 00:35:05.000000000","message":"The corresponding config doc says \u0027Unity QE 4.1.x or higher\u0027\n\nI know this isn\u0027t part of your changeset, but do you want to fix this inconsistency while you are here?","commit_id":"8d26a34cd1aa8242289420a52e10eba2614cf0e6"}],"doc/source/configuration/shared-file-systems/drivers/dell-emc-unity-driver.rst":[{"author":{"_account_id":18742,"name":"Ryan Liang","email":"ryan.liang@emc.com","username":"RyanLiang"},"change_message_id":"e769c5547d02dd41dc6d8837a0059ba98d739ef5","unresolved":false,"context_lines":[{"line_number":104,"context_line":"``NFS`` shares and ``user`` based authentication method for ``CIFS`` shares"},{"line_number":105,"context_line":"respectively. For ``CIFS`` share, Microsoft Active Directory is the only"},{"line_number":106,"context_line":"supported security services."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Pre-configurations"},{"line_number":109,"context_line":"~~~~~~~~~~~~~~~~~~"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_fe438c3d","line":107,"updated":"2019-08-02 07:53:48.000000000","message":"Add a section to describe the un-handle-share-servers support.\n1. What does the customer need to do? like creating a NAS server beforehand.\n2. Give out a sample configuration.\n3. Give out a sample usage when DHSS\u003dFalse.\n4. Any limitations?","commit_id":"e72506400d40f693736fd15c8e25db6e278cce32"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"7c0385219a418803b8e6d5d155048e45cbfc4374","unresolved":false,"context_lines":[{"line_number":104,"context_line":"``NFS`` shares and ``user`` based authentication method for ``CIFS`` shares"},{"line_number":105,"context_line":"respectively. For ``CIFS`` share, Microsoft Active Directory is the only"},{"line_number":106,"context_line":"supported security services."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Pre-configurations"},{"line_number":109,"context_line":"~~~~~~~~~~~~~~~~~~"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_fbedc524","line":107,"in_reply_to":"7faddb67_fe438c3d","updated":"2019-08-05 07:39:06.000000000","message":"Done","commit_id":"e72506400d40f693736fd15c8e25db6e278cce32"},{"author":{"_account_id":18742,"name":"Ryan Liang","email":"ryan.liang@emc.com","username":"RyanLiang"},"change_message_id":"e769c5547d02dd41dc6d8837a0059ba98d739ef5","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    unity_share_data_pools \u003d \u003ccomma separated pool names\u003e"},{"line_number":166,"context_line":"    unity_ethernet_ports \u003d \u003ccomma separated ports list\u003e"},{"line_number":167,"context_line":"    driver_handles_share_servers \u003d True/False"},{"line_number":168,"context_line":"    unity_nas_server \u003d \u003cname of NAS server in Unity system\u003e"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"- ``emc_share_backend``"},{"line_number":171,"context_line":"    The plugin name. Set it to `unity` for the Unity driver."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_7ef47cf1","line":168,"range":{"start_line":168,"start_character":4,"end_line":168,"end_character":20},"updated":"2019-08-02 07:53:48.000000000","message":"s/unity_nas_server/unity_share_server","commit_id":"e72506400d40f693736fd15c8e25db6e278cce32"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"7c0385219a418803b8e6d5d155048e45cbfc4374","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    unity_share_data_pools \u003d \u003ccomma separated pool names\u003e"},{"line_number":166,"context_line":"    unity_ethernet_ports \u003d \u003ccomma separated ports list\u003e"},{"line_number":167,"context_line":"    driver_handles_share_servers \u003d True/False"},{"line_number":168,"context_line":"    unity_nas_server \u003d \u003cname of NAS server in Unity system\u003e"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"- ``emc_share_backend``"},{"line_number":171,"context_line":"    The plugin name. Set it to `unity` for the Unity driver."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_795b36f5","line":168,"range":{"start_line":168,"start_character":4,"end_line":168,"end_character":20},"in_reply_to":"7faddb67_7ef47cf1","updated":"2019-08-05 07:39:06.000000000","message":"Done","commit_id":"e72506400d40f693736fd15c8e25db6e278cce32"},{"author":{"_account_id":18742,"name":"Ryan Liang","email":"ryan.liang@emc.com","username":"RyanLiang"},"change_message_id":"e769c5547d02dd41dc6d8837a0059ba98d739ef5","unresolved":false,"context_lines":[{"line_number":229,"context_line":""},{"line_number":230,"context_line":"- ``driver_handles_share_servers``"},{"line_number":231,"context_line":"    Unity driver requires this option to be as ``True`` or ``False``."},{"line_number":232,"context_line":"    Need sets ``unity_nas_server`` when the value is ``False``."},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"- ``unity_nas_server``"},{"line_number":235,"context_line":"    One of NAS server names in Unity, it is used for share creation when"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_0353af3a","line":232,"range":{"start_line":232,"start_character":4,"end_line":232,"end_character":13},"updated":"2019-08-02 07:53:48.000000000","message":"s/Need sets/Need to set/","commit_id":"e72506400d40f693736fd15c8e25db6e278cce32"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"7c0385219a418803b8e6d5d155048e45cbfc4374","unresolved":false,"context_lines":[{"line_number":229,"context_line":""},{"line_number":230,"context_line":"- ``driver_handles_share_servers``"},{"line_number":231,"context_line":"    Unity driver requires this option to be as ``True`` or ``False``."},{"line_number":232,"context_line":"    Need sets ``unity_nas_server`` when the value is ``False``."},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"- ``unity_nas_server``"},{"line_number":235,"context_line":"    One of NAS server names in Unity, it is used for share creation when"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_39713e77","line":232,"range":{"start_line":232,"start_character":4,"end_line":232,"end_character":13},"in_reply_to":"7faddb67_0353af3a","updated":"2019-08-05 07:39:06.000000000","message":"Done","commit_id":"e72506400d40f693736fd15c8e25db6e278cce32"},{"author":{"_account_id":18742,"name":"Ryan Liang","email":"ryan.liang@emc.com","username":"RyanLiang"},"change_message_id":"e769c5547d02dd41dc6d8837a0059ba98d739ef5","unresolved":false,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":"- ``unity_nas_server``"},{"line_number":235,"context_line":"    One of NAS server names in Unity, it is used for share creation when"},{"line_number":236,"context_line":"    driver is in un-handles share server mode."},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"Restart of ``manila-share`` service is needed for the configuration"},{"line_number":239,"context_line":"changes to take effect."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_5e05000f","line":236,"updated":"2019-08-02 07:53:48.000000000","message":"the driver","commit_id":"e72506400d40f693736fd15c8e25db6e278cce32"},{"author":{"_account_id":18742,"name":"Ryan Liang","email":"ryan.liang@emc.com","username":"RyanLiang"},"change_message_id":"e769c5547d02dd41dc6d8837a0059ba98d739ef5","unresolved":false,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":"- ``unity_nas_server``"},{"line_number":235,"context_line":"    One of NAS server names in Unity, it is used for share creation when"},{"line_number":236,"context_line":"    driver is in un-handles share server mode."},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"Restart of ``manila-share`` service is needed for the configuration"},{"line_number":239,"context_line":"changes to take effect."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_7e0a3c20","line":236,"range":{"start_line":236,"start_character":17,"end_line":236,"end_character":40},"updated":"2019-08-02 07:53:48.000000000","message":"un-handle-share-servers","commit_id":"e72506400d40f693736fd15c8e25db6e278cce32"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"7c0385219a418803b8e6d5d155048e45cbfc4374","unresolved":false,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":"- ``unity_nas_server``"},{"line_number":235,"context_line":"    One of NAS server names in Unity, it is used for share creation when"},{"line_number":236,"context_line":"    driver is in un-handles share server mode."},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"Restart of ``manila-share`` service is needed for the configuration"},{"line_number":239,"context_line":"changes to take effect."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_f96646bb","line":236,"range":{"start_line":236,"start_character":17,"end_line":236,"end_character":40},"in_reply_to":"7faddb67_7e0a3c20","updated":"2019-08-05 07:39:06.000000000","message":"Done","commit_id":"e72506400d40f693736fd15c8e25db6e278cce32"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"98341785f755f4b0c186e778fad0ed1e0e6348f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7faddb67_8bd7c322","updated":"2019-09-03 12:11:16.000000000","message":"I\u0027ve realized that in the admin guide of the Unity driver [1] there are some informations that may be important to update regarding the changes you\u0027re doing in this patch. Could you please take a look?\n[1] https://review.opendev.org/#/c/673948/8/doc/source/admin/emc_unity_driver.rst","commit_id":"2b356fb0562ce7842a53cd51436b304d2b2e6b82"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"333630d843ab25081b3a832ee7de5f1c7cf261e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7faddb67_e9e5f8db","in_reply_to":"7faddb67_54b07ffd","updated":"2019-09-05 04:05:56.000000000","message":"Done","commit_id":"2b356fb0562ce7842a53cd51436b304d2b2e6b82"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"5efc22df2ed88190bba5458ce7e5fb3bf085643c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5faad753_ea882420","in_reply_to":"7faddb67_54b07ffd","updated":"2019-09-10 00:35:05.000000000","message":"Ideally the configuration guide document would focus on configuration details and the administrative guide would be more general, and perhaps refer to the configuration guide where necessary.  What we have instead is a jumble of almost the same information in both places.  I\u0027m not suggesting that you fix that as part of this patch and your driver is not the only one in this situation.","commit_id":"2b356fb0562ce7842a53cd51436b304d2b2e6b82"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"3d04716ab15e3fcf093ccaf9cb7ab9f158db8217","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7faddb67_54b07ffd","in_reply_to":"7faddb67_8bd7c322","updated":"2019-09-04 02:11:36.000000000","message":"Hi, Carlos\n\nWe are out of sync of these two files, I have question about them, why we need two different doc for same driver here?\nCan we merge them to single one? \n\nThanks,\nDing Dong","commit_id":"2b356fb0562ce7842a53cd51436b304d2b2e6b82"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"98341785f755f4b0c186e778fad0ed1e0e6348f0","unresolved":false,"context_lines":[{"line_number":260,"context_line":"    Unity driver requires this option to be as ``True`` or ``False``."},{"line_number":261,"context_line":"    Need to set ``unity_share_server`` when the value is ``False``."},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"- ``unity_share_server``"},{"line_number":264,"context_line":"    One of NAS server names in Unity, it is used for share creation when"},{"line_number":265,"context_line":"    the driver is in ``DHSS\u003dFalse`` mode."},{"line_number":266,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7faddb67_8b3b4399","line":263,"range":{"start_line":263,"start_character":2,"end_line":263,"end_character":24},"updated":"2019-09-03 12:11:16.000000000","message":"Wouldn\u0027t be better do add this option in the below manila-unity table?","commit_id":"2b356fb0562ce7842a53cd51436b304d2b2e6b82"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"333630d843ab25081b3a832ee7de5f1c7cf261e4","unresolved":false,"context_lines":[{"line_number":260,"context_line":"    Unity driver requires this option to be as ``True`` or ``False``."},{"line_number":261,"context_line":"    Need to set ``unity_share_server`` when the value is ``False``."},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"- ``unity_share_server``"},{"line_number":264,"context_line":"    One of NAS server names in Unity, it is used for share creation when"},{"line_number":265,"context_line":"    the driver is in ``DHSS\u003dFalse`` mode."},{"line_number":266,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7faddb67_a9c62048","line":263,"range":{"start_line":263,"start_character":2,"end_line":263,"end_character":24},"in_reply_to":"7faddb67_8b3b4399","updated":"2019-09-05 04:05:56.000000000","message":"Done","commit_id":"2b356fb0562ce7842a53cd51436b304d2b2e6b82"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7e5ca3d66c57789a7d3a9f4767873d6084cc8349","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  - Thin Provisioning"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  - Fiber Channel (FC)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  - Internet Small Computer System Interface (iSCSI)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Supported shared filesystems and operations"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5faad753_a7bb2bc2","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":52},"updated":"2019-09-10 22:50:33.000000000","message":"Curious why either of these matter for NFS/CIFS access to Unity...","commit_id":"8d26a34cd1aa8242289420a52e10eba2614cf0e6"}],"manila/share/drivers/dell_emc/plugins/unity/connection.py":[{"author":{"_account_id":18742,"name":"Ryan Liang","email":"ryan.liang@emc.com","username":"RyanLiang"},"change_message_id":"e769c5547d02dd41dc6d8837a0059ba98d739ef5","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                                 \u0027balance.\u0027,"},{"line_number":63,"context_line":"               help\u003d\u0027Storage processor to host the NAS server. Obsolete.\u0027),"},{"line_number":64,"context_line":"    cfg.StrOpt(\u0027unity_nas_server\u0027,"},{"line_number":65,"context_line":"               help\u003d\u0027NAS server used for creating share when driver \u0027"},{"line_number":66,"context_line":"                    \u0027is in un-handles share servers mode\u0027),"},{"line_number":67,"context_line":"]"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_1ec6a89b","line":65,"updated":"2019-08-02 07:53:48.000000000","message":"Add notes about it is required when DHSS\u003dFalse","commit_id":"e72506400d40f693736fd15c8e25db6e278cce32"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"7c0385219a418803b8e6d5d155048e45cbfc4374","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                                 \u0027balance.\u0027,"},{"line_number":63,"context_line":"               help\u003d\u0027Storage processor to host the NAS server. Obsolete.\u0027),"},{"line_number":64,"context_line":"    cfg.StrOpt(\u0027unity_nas_server\u0027,"},{"line_number":65,"context_line":"               help\u003d\u0027NAS server used for creating share when driver \u0027"},{"line_number":66,"context_line":"                    \u0027is in un-handles share servers mode\u0027),"},{"line_number":67,"context_line":"]"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_593d1a8c","line":65,"in_reply_to":"7faddb67_1ec6a89b","updated":"2019-08-05 07:39:06.000000000","message":"Done","commit_id":"e72506400d40f693736fd15c8e25db6e278cce32"},{"author":{"_account_id":18742,"name":"Ryan Liang","email":"ryan.liang@emc.com","username":"RyanLiang"},"change_message_id":"e769c5547d02dd41dc6d8837a0059ba98d739ef5","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        self._config_pool(pool_name)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def get_server_name(self, share_server\u003dNone):"},{"line_number":127,"context_line":"        if self.driver_handles_share_servers is False:"},{"line_number":128,"context_line":"            if not self.unity_nas_server:"},{"line_number":129,"context_line":"                msg \u003d (\"Make sure there is NAS server name \""},{"line_number":130,"context_line":"                       \"configured for share creation when driver \""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_5e3d008c","line":127,"range":{"start_line":127,"start_character":11,"end_line":127,"end_character":53},"updated":"2019-08-02 07:53:48.000000000","message":"`not self.driver_handles_share_servers`","commit_id":"e72506400d40f693736fd15c8e25db6e278cce32"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"7c0385219a418803b8e6d5d155048e45cbfc4374","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        self._config_pool(pool_name)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def get_server_name(self, share_server\u003dNone):"},{"line_number":127,"context_line":"        if self.driver_handles_share_servers is False:"},{"line_number":128,"context_line":"            if not self.unity_nas_server:"},{"line_number":129,"context_line":"                msg \u003d (\"Make sure there is NAS server name \""},{"line_number":130,"context_line":"                       \"configured for share creation when driver \""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_5e42e069","line":127,"range":{"start_line":127,"start_character":11,"end_line":127,"end_character":53},"in_reply_to":"7faddb67_5e3d008c","updated":"2019-08-05 07:39:06.000000000","message":"Done","commit_id":"e72506400d40f693736fd15c8e25db6e278cce32"},{"author":{"_account_id":18742,"name":"Ryan Liang","email":"ryan.liang@emc.com","username":"RyanLiang"},"change_message_id":"e769c5547d02dd41dc6d8837a0059ba98d739ef5","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def get_server_name(self, share_server\u003dNone):"},{"line_number":127,"context_line":"        if self.driver_handles_share_servers is False:"},{"line_number":128,"context_line":"            if not self.unity_nas_server:"},{"line_number":129,"context_line":"                msg \u003d (\"Make sure there is NAS server name \""},{"line_number":130,"context_line":"                       \"configured for share creation when driver \""},{"line_number":131,"context_line":"                       \"is in un-handles share servers mode.\")"},{"line_number":132,"context_line":"                raise exception.BadConfigurationException(reason\u003dmsg)"},{"line_number":133,"context_line":"            else:"},{"line_number":134,"context_line":"                return self.unity_nas_server"},{"line_number":135,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_9e2e1841","line":132,"range":{"start_line":128,"start_character":12,"end_line":132,"end_character":69},"updated":"2019-08-02 07:53:48.000000000","message":"Move this check into `connect` method. Then the driver could quick fail when starting up instead of reporting errors when creating shares.","commit_id":"e72506400d40f693736fd15c8e25db6e278cce32"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"7c0385219a418803b8e6d5d155048e45cbfc4374","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def get_server_name(self, share_server\u003dNone):"},{"line_number":127,"context_line":"        if self.driver_handles_share_servers is False:"},{"line_number":128,"context_line":"            if not self.unity_nas_server:"},{"line_number":129,"context_line":"                msg \u003d (\"Make sure there is NAS server name \""},{"line_number":130,"context_line":"                       \"configured for share creation when driver \""},{"line_number":131,"context_line":"                       \"is in un-handles share servers mode.\")"},{"line_number":132,"context_line":"                raise exception.BadConfigurationException(reason\u003dmsg)"},{"line_number":133,"context_line":"            else:"},{"line_number":134,"context_line":"                return self.unity_nas_server"},{"line_number":135,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_be519438","line":132,"range":{"start_line":128,"start_character":12,"end_line":132,"end_character":69},"in_reply_to":"7faddb67_9e2e1841","updated":"2019-08-05 07:39:06.000000000","message":"Done","commit_id":"e72506400d40f693736fd15c8e25db6e278cce32"},{"author":{"_account_id":18742,"name":"Ryan Liang","email":"ryan.liang@emc.com","username":"RyanLiang"},"change_message_id":"e769c5547d02dd41dc6d8837a0059ba98d739ef5","unresolved":false,"context_lines":[{"line_number":249,"context_line":"            self.client.create_nfs_share(backend_snap, share_name)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"            locations \u003d self._get_nfs_location("},{"line_number":252,"context_line":"                nas_server.file_interface, share_name)"},{"line_number":253,"context_line":"        return locations"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_7e29dc34","line":252,"updated":"2019-08-02 07:53:48.000000000","message":"Revert this line.","commit_id":"e72506400d40f693736fd15c8e25db6e278cce32"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"7c0385219a418803b8e6d5d155048e45cbfc4374","unresolved":false,"context_lines":[{"line_number":249,"context_line":"            self.client.create_nfs_share(backend_snap, share_name)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"            locations \u003d self._get_nfs_location("},{"line_number":252,"context_line":"                nas_server.file_interface, share_name)"},{"line_number":253,"context_line":"        return locations"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_1e7788d6","line":252,"in_reply_to":"7faddb67_7e29dc34","updated":"2019-08-05 07:39:06.000000000","message":"Done","commit_id":"e72506400d40f693736fd15c8e25db6e278cce32"}],"releasenotes/notes/unity-un-handles-share-server-mode-support-e179c092ab148948.yaml":[{"author":{"_account_id":18742,"name":"Ryan Liang","email":"ryan.liang@emc.com","username":"RyanLiang"},"change_message_id":"e769c5547d02dd41dc6d8837a0059ba98d739ef5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Un-handles share server mode support has been added for Dell EMC Unity Manila driver."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_3ea04490","line":3,"updated":"2019-08-02 07:53:48.000000000","message":"Put `Dell EMC Unity:` to the beginning.","commit_id":"e72506400d40f693736fd15c8e25db6e278cce32"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"7c0385219a418803b8e6d5d155048e45cbfc4374","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Un-handles share server mode support has been added for Dell EMC Unity Manila driver."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_9e061886","line":3,"in_reply_to":"7faddb67_3ea04490","updated":"2019-08-05 07:39:06.000000000","message":"Done","commit_id":"e72506400d40f693736fd15c8e25db6e278cce32"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"1d410cfca4df6af9df825abf9610f043960f192b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Dell EMC Unity Manila driver supports un-handles share server mode."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_9518ee1e","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":71},"updated":"2019-08-07 11:32:35.000000000","message":"I suggest:\n\n  Dell EMC Unity Manila driver now supports the mode in which it does not itself create and destroy share servers (DHSS\u003dFalse).","commit_id":"b9e7af99066f66d7bbc44533bcee9bd920765a47"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"f4e481007257746816bce3503188c5c996995495","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Dell EMC Unity Manila driver supports un-handles share server mode."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_884a0559","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":71},"in_reply_to":"7faddb67_9518ee1e","updated":"2019-08-08 02:59:46.000000000","message":"Done","commit_id":"b9e7af99066f66d7bbc44533bcee9bd920765a47"}]}