)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0ae4b8d0d45a5afe1b8896ac09c3e6ff854b3e08","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Douglas Viroel \u003cviroel@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-19 20:00:19 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[NetApp] Adds support for replication with DHSS\u003dTrue"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds support for replication with DHSS\u003dTrue on"},{"line_number":10,"context_line":"NetApp driver. It now handles peering operations between"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_e947d476","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":13},"updated":"2019-08-27 11:13:41.000000000","message":"Add","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"bcbbc89fd02258ef057aa36f806cfdb105dfae21","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Douglas Viroel \u003cviroel@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-19 20:00:19 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[NetApp] Adds support for replication with DHSS\u003dTrue"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds support for replication with DHSS\u003dTrue on"},{"line_number":10,"context_line":"NetApp driver. It now handles peering operations between"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_6738c49e","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":13},"in_reply_to":"7faddb67_e947d476","updated":"2019-08-28 16:05:48.000000000","message":"Done","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9daee6018f6b12c6f42ee50f189df0d063e207f5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Douglas Viroel \u003cviroel@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-09-02 14:18:05 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[NetApp] Adds support for replication with DHSS\u003dTrue"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds support for replication with DHSS\u003dTrue on"},{"line_number":10,"context_line":"NetApp driver. It now handles peering operations between"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7faddb67_e5be74d2","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":13},"updated":"2019-09-05 11:23:28.000000000","message":"nit: Add\nI saw you changed this and in PS 4 this was changed to \"Add\". For some reason it became \"Adds\" again. But you can update only if there\u0027s a need to upload a new PS. :)","commit_id":"32c9eb80f11e57509f9f72259e7c744c6d1130dd"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6d1066e001ac9b25243214952cab76e9df7fd10c","unresolved":false,"context_lines":[{"line_number":3119,"context_line":"        if passphrase:"},{"line_number":3120,"context_line":"            api_args[\u0027passphrase\u0027] \u003d passphrase"},{"line_number":3121,"context_line":""},{"line_number":3122,"context_line":"        self.send_request(\u0027cluster-peer-create\u0027, api_args)"},{"line_number":3123,"context_line":""},{"line_number":3124,"context_line":"    @na_utils.trace"},{"line_number":3125,"context_line":"    def get_cluster_peers(self, remote_cluster_name\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_88e70513","line":3122,"range":{"start_line":3122,"start_character":57,"end_line":3122,"end_character":58},"updated":"2019-09-11 20:25:35.000000000","message":"This is also scoped to \"ontap_cluster\" - but the driver isn\u0027t using this API - however, enable_tunneling\u003dFalse here too for future proofing","commit_id":"32c9eb80f11e57509f9f72259e7c744c6d1130dd"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"3a148bb0dbcce5a55119bde3245ef01617df6cf1","unresolved":false,"context_lines":[{"line_number":3119,"context_line":"        if passphrase:"},{"line_number":3120,"context_line":"            api_args[\u0027passphrase\u0027] \u003d passphrase"},{"line_number":3121,"context_line":""},{"line_number":3122,"context_line":"        self.send_request(\u0027cluster-peer-create\u0027, api_args)"},{"line_number":3123,"context_line":""},{"line_number":3124,"context_line":"    @na_utils.trace"},{"line_number":3125,"context_line":"    def get_cluster_peers(self, remote_cluster_name\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_4ee03597","line":3122,"range":{"start_line":3122,"start_character":57,"end_line":3122,"end_character":58},"in_reply_to":"5faad753_88e70513","updated":"2019-09-11 22:25:14.000000000","message":"We are not using these calls, however it\u0027s good to append this information to avoid issues in the future. Thanks for pointing that out.","commit_id":"32c9eb80f11e57509f9f72259e7c744c6d1130dd"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0ae4b8d0d45a5afe1b8896ac09c3e6ff854b3e08","unresolved":false,"context_lines":[{"line_number":1462,"context_line":"                \u0027netapp_disk_type\u0027: disk_types,"},{"line_number":1463,"context_line":"            })"},{"line_number":1464,"context_line":""},{"line_number":1465,"context_line":"    def find_active_replica(self, replica_list):"},{"line_number":1466,"context_line":"        # NOTE(ameade): Find current active replica. There can only be one"},{"line_number":1467,"context_line":"        # active replica (SnapMirror source volume) at a time in cDOT."},{"line_number":1468,"context_line":"        for r in replica_list:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_04d0152b","line":1465,"range":{"start_line":1465,"start_character":8,"end_line":1465,"end_character":27},"updated":"2019-08-27 11:13:41.000000000","message":"Is there a specific reason that made this method needed to become public?","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"bcbbc89fd02258ef057aa36f806cfdb105dfae21","unresolved":false,"context_lines":[{"line_number":1462,"context_line":"                \u0027netapp_disk_type\u0027: disk_types,"},{"line_number":1463,"context_line":"            })"},{"line_number":1464,"context_line":""},{"line_number":1465,"context_line":"    def find_active_replica(self, replica_list):"},{"line_number":1466,"context_line":"        # NOTE(ameade): Find current active replica. There can only be one"},{"line_number":1467,"context_line":"        # active replica (SnapMirror source volume) at a time in cDOT."},{"line_number":1468,"context_line":"        for r in replica_list:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_0758f0f7","line":1465,"range":{"start_line":1465,"start_character":8,"end_line":1465,"end_character":27},"in_reply_to":"7faddb67_04d0152b","updated":"2019-08-28 16:05:48.000000000","message":"Yes, it\u0027s now being used by the multi_svm library.","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6d1066e001ac9b25243214952cab76e9df7fd10c","unresolved":false,"context_lines":[{"line_number":294,"context_line":"            },"},{"line_number":295,"context_line":"        }"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        if (self.configuration.replication_domain):"},{"line_number":298,"context_line":"            data[\u0027replication_type\u0027] \u003d \u0027dr\u0027"},{"line_number":299,"context_line":"            data[\u0027replication_domain\u0027] \u003d self.configuration.replication_domain"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_28e131d1","line":297,"range":{"start_line":297,"start_character":11,"end_line":297,"end_character":12},"updated":"2019-09-11 20:25:35.000000000","message":"nit: drop braces","commit_id":"32c9eb80f11e57509f9f72259e7c744c6d1130dd"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"3a148bb0dbcce5a55119bde3245ef01617df6cf1","unresolved":false,"context_lines":[{"line_number":294,"context_line":"            },"},{"line_number":295,"context_line":"        }"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        if (self.configuration.replication_domain):"},{"line_number":298,"context_line":"            data[\u0027replication_type\u0027] \u003d \u0027dr\u0027"},{"line_number":299,"context_line":"            data[\u0027replication_domain\u0027] \u003d self.configuration.replication_domain"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_eef0016a","line":297,"range":{"start_line":297,"start_character":11,"end_line":297,"end_character":12},"in_reply_to":"5faad753_28e131d1","updated":"2019-09-11 22:25:14.000000000","message":"Done","commit_id":"32c9eb80f11e57509f9f72259e7c744c6d1130dd"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0ae4b8d0d45a5afe1b8896ac09c3e6ff854b3e08","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                       access_rules, share_snapshots, share_server\u003dNone):"},{"line_number":439,"context_line":"        \"\"\"Creates the new replica on this backend and sets up SnapMirror."},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"        In multi-svm scneario, it creates the peering between the associated"},{"line_number":442,"context_line":"        vservers before creating the share replica and setting up the"},{"line_number":443,"context_line":"        SnapMirror."},{"line_number":444,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_34fc603e","line":441,"range":{"start_line":441,"start_character":8,"end_line":441,"end_character":20},"updated":"2019-08-27 11:13:41.000000000","message":"What about: It creates ....\nOr: In a multi-svm scenarios ...","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0ae4b8d0d45a5afe1b8896ac09c3e6ff854b3e08","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                       access_rules, share_snapshots, share_server\u003dNone):"},{"line_number":439,"context_line":"        \"\"\"Creates the new replica on this backend and sets up SnapMirror."},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"        In multi-svm scneario, it creates the peering between the associated"},{"line_number":442,"context_line":"        vservers before creating the share replica and setting up the"},{"line_number":443,"context_line":"        SnapMirror."},{"line_number":444,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_d4faac41","line":441,"range":{"start_line":441,"start_character":21,"end_line":441,"end_character":29},"updated":"2019-08-27 11:13:41.000000000","message":"scenario","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"bcbbc89fd02258ef057aa36f806cfdb105dfae21","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                       access_rules, share_snapshots, share_server\u003dNone):"},{"line_number":439,"context_line":"        \"\"\"Creates the new replica on this backend and sets up SnapMirror."},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"        In multi-svm scneario, it creates the peering between the associated"},{"line_number":442,"context_line":"        vservers before creating the share replica and setting up the"},{"line_number":443,"context_line":"        SnapMirror."},{"line_number":444,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_e76cb49e","line":441,"range":{"start_line":441,"start_character":21,"end_line":441,"end_character":29},"in_reply_to":"7faddb67_d4faac41","updated":"2019-08-28 16:05:48.000000000","message":"Done","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0ae4b8d0d45a5afe1b8896ac09c3e6ff854b3e08","unresolved":false,"context_lines":[{"line_number":451,"context_line":"        src_replica \u003d self.find_active_replica(replica_list)"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"        src_replica_host \u003d share_utils.extract_host("},{"line_number":454,"context_line":"            src_replica[\u0027host\u0027], level\u003d\u0027backend_name\u0027)"},{"line_number":455,"context_line":"        src_replica_client \u003d data_motion.get_client_for_backend("},{"line_number":456,"context_line":"            src_replica_host, vserver_name\u003dsrc_vserver)"},{"line_number":457,"context_line":"        # Cluster name is needed for setting up the vserver peering"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_549c7c0d","line":454,"range":{"start_line":454,"start_character":39,"end_line":454,"end_character":53},"updated":"2019-08-27 11:13:41.000000000","message":"You are using this twice. What about assigning this value into a variable and use the variable here and below?","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9daee6018f6b12c6f42ee50f189df0d063e207f5","unresolved":false,"context_lines":[{"line_number":451,"context_line":"        src_replica \u003d self.find_active_replica(replica_list)"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"        src_replica_host \u003d share_utils.extract_host("},{"line_number":454,"context_line":"            src_replica[\u0027host\u0027], level\u003d\u0027backend_name\u0027)"},{"line_number":455,"context_line":"        src_replica_client \u003d data_motion.get_client_for_backend("},{"line_number":456,"context_line":"            src_replica_host, vserver_name\u003dsrc_vserver)"},{"line_number":457,"context_line":"        # Cluster name is needed for setting up the vserver peering"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_45cf487e","line":454,"range":{"start_line":454,"start_character":39,"end_line":454,"end_character":53},"in_reply_to":"7faddb67_470348bf","updated":"2019-09-05 11:23:28.000000000","message":"Good. Thanks for answering. :)","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"bcbbc89fd02258ef057aa36f806cfdb105dfae21","unresolved":false,"context_lines":[{"line_number":451,"context_line":"        src_replica \u003d self.find_active_replica(replica_list)"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"        src_replica_host \u003d share_utils.extract_host("},{"line_number":454,"context_line":"            src_replica[\u0027host\u0027], level\u003d\u0027backend_name\u0027)"},{"line_number":455,"context_line":"        src_replica_client \u003d data_motion.get_client_for_backend("},{"line_number":456,"context_line":"            src_replica_host, vserver_name\u003dsrc_vserver)"},{"line_number":457,"context_line":"        # Cluster name is needed for setting up the vserver peering"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_470348bf","line":454,"range":{"start_line":454,"start_character":39,"end_line":454,"end_character":53},"in_reply_to":"7faddb67_549c7c0d","updated":"2019-08-28 16:05:48.000000000","message":"This one I prefer to left in this way, because the rest of the code is doing the same thing.","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0ae4b8d0d45a5afe1b8896ac09c3e6ff854b3e08","unresolved":false,"context_lines":[{"line_number":493,"context_line":"        # Check if there are no remaining SnapMirror connections and if a"},{"line_number":494,"context_line":"        # vserver peering exists and delete it."},{"line_number":495,"context_line":"        snapmirrors \u003d self._get_snapmirrors(vserver, peer_vserver)"},{"line_number":496,"context_line":"        snapmirrors_peer \u003d self._get_snapmirrors(peer_vserver, vserver)"},{"line_number":497,"context_line":"        peers \u003d self._get_vserver_peers(peer_vserver, vserver)"},{"line_number":498,"context_line":"        if not (snapmirrors or snapmirrors_peer) and peers:"},{"line_number":499,"context_line":"            self._delete_vserver_peer(peer_vserver, vserver)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_f48a48ba","line":496,"range":{"start_line":496,"start_character":8,"end_line":496,"end_character":24},"updated":"2019-08-27 11:13:41.000000000","message":"maybe snapmirrors_from_peer \u003d ... ?","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"bcbbc89fd02258ef057aa36f806cfdb105dfae21","unresolved":false,"context_lines":[{"line_number":493,"context_line":"        # Check if there are no remaining SnapMirror connections and if a"},{"line_number":494,"context_line":"        # vserver peering exists and delete it."},{"line_number":495,"context_line":"        snapmirrors \u003d self._get_snapmirrors(vserver, peer_vserver)"},{"line_number":496,"context_line":"        snapmirrors_peer \u003d self._get_snapmirrors(peer_vserver, vserver)"},{"line_number":497,"context_line":"        peers \u003d self._get_vserver_peers(peer_vserver, vserver)"},{"line_number":498,"context_line":"        if not (snapmirrors or snapmirrors_peer) and peers:"},{"line_number":499,"context_line":"            self._delete_vserver_peer(peer_vserver, vserver)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_870060ad","line":496,"range":{"start_line":496,"start_character":8,"end_line":496,"end_character":24},"in_reply_to":"7faddb67_f48a48ba","updated":"2019-08-28 16:05:48.000000000","message":"Done","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6d1066e001ac9b25243214952cab76e9df7fd10c","unresolved":false,"context_lines":[{"line_number":545,"context_line":""},{"line_number":546,"context_line":"        return vserver, peer_vserver"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    def _get_cluster_peers(self, context, remote_cluster_name\u003dNone):"},{"line_number":549,"context_line":"        return self._client.get_cluster_peers(remote_cluster_name)"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"    def _get_vserver_peers(self, vserver\u003dNone, peer_vserver\u003dNone):"},{"line_number":552,"context_line":"        return self._client.get_vserver_peers(vserver, peer_vserver)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_28cb711e","line":549,"range":{"start_line":548,"start_character":0,"end_line":549,"end_character":66},"updated":"2019-09-11 20:25:35.000000000","message":"Unused. \n\nDo you expect that clusters will be peered before in case of multiple NetApp clusters?","commit_id":"32c9eb80f11e57509f9f72259e7c744c6d1130dd"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"bc97225aab7f2b83233cc147e3dc7d9d164b2986","unresolved":false,"context_lines":[{"line_number":545,"context_line":""},{"line_number":546,"context_line":"        return vserver, peer_vserver"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    def _get_cluster_peers(self, context, remote_cluster_name\u003dNone):"},{"line_number":549,"context_line":"        return self._client.get_cluster_peers(remote_cluster_name)"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"    def _get_vserver_peers(self, vserver\u003dNone, peer_vserver\u003dNone):"},{"line_number":552,"context_line":"        return self._client.get_vserver_peers(vserver, peer_vserver)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_79413d39","line":549,"range":{"start_line":548,"start_character":0,"end_line":549,"end_character":66},"in_reply_to":"5faad753_0ef47d5a","updated":"2019-09-11 22:34:30.000000000","message":"Oh, forgot to answer your question: Yes, it\u0027s expected that the cluster peering will be made beforehand.","commit_id":"32c9eb80f11e57509f9f72259e7c744c6d1130dd"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"3a148bb0dbcce5a55119bde3245ef01617df6cf1","unresolved":false,"context_lines":[{"line_number":545,"context_line":""},{"line_number":546,"context_line":"        return vserver, peer_vserver"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    def _get_cluster_peers(self, context, remote_cluster_name\u003dNone):"},{"line_number":549,"context_line":"        return self._client.get_cluster_peers(remote_cluster_name)"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"    def _get_vserver_peers(self, vserver\u003dNone, peer_vserver\u003dNone):"},{"line_number":552,"context_line":"        return self._client.get_vserver_peers(vserver, peer_vserver)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_0ef47d5a","line":549,"range":{"start_line":548,"start_character":0,"end_line":549,"end_character":66},"in_reply_to":"5faad753_28cb711e","updated":"2019-09-11 22:25:14.000000000","message":"Removed.","commit_id":"32c9eb80f11e57509f9f72259e7c744c6d1130dd"}],"manila/tests/share/drivers/netapp/dataontap/client/test_client_cmode.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0ae4b8d0d45a5afe1b8896ac09c3e6ff854b3e08","unresolved":false,"context_lines":[{"line_number":5590,"context_line":""},{"line_number":5591,"context_line":"        self.mock_object(self.client, \u0027send_request\u0027)"},{"line_number":5592,"context_line":""},{"line_number":5593,"context_line":"        self.client.create_vserver_peer(\u0027fake_vserver\u0027, \u0027fake_vserver_peer\u0027,"},{"line_number":5594,"context_line":"                                        peer_cluster_name\u003dcluster_name)"},{"line_number":5595,"context_line":""},{"line_number":5596,"context_line":"        vserver_peer_create_args \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_b431300d","line":5593,"range":{"start_line":5593,"start_character":41,"end_line":5593,"end_character":53},"updated":"2019-08-27 11:13:41.000000000","message":"You\u0027re using this values more than once. What about assigning this fake value to variable and use it below?","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"bcbbc89fd02258ef057aa36f806cfdb105dfae21","unresolved":false,"context_lines":[{"line_number":5590,"context_line":""},{"line_number":5591,"context_line":"        self.mock_object(self.client, \u0027send_request\u0027)"},{"line_number":5592,"context_line":""},{"line_number":5593,"context_line":"        self.client.create_vserver_peer(\u0027fake_vserver\u0027, \u0027fake_vserver_peer\u0027,"},{"line_number":5594,"context_line":"                                        peer_cluster_name\u003dcluster_name)"},{"line_number":5595,"context_line":""},{"line_number":5596,"context_line":"        vserver_peer_create_args \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_27296c36","line":5593,"range":{"start_line":5593,"start_character":41,"end_line":5593,"end_character":53},"in_reply_to":"7faddb67_b431300d","updated":"2019-08-28 16:05:48.000000000","message":"Done","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"}],"manila/tests/share/drivers/netapp/dataontap/cluster_mode/test_lib_multi_svm.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0ae4b8d0d45a5afe1b8896ac09c3e6ff854b3e08","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.client \u003d self.library._client"},{"line_number":67,"context_line":"        self.fake_new_replica \u003d copy.deepcopy(fake.SHARE)"},{"line_number":68,"context_line":"        self.fake_new_ss \u003d copy.deepcopy(fake.SHARE_SERVER)"},{"line_number":69,"context_line":"        self.fake_new_vserver \u003d \u0027fake_new_vserver\u0027"},{"line_number":70,"context_line":"        self.fake_new_ss[\u0027backend_details\u0027][\u0027vserver_name\u0027] \u003d ("},{"line_number":71,"context_line":"            self.fake_new_vserver"},{"line_number":72,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_7414184e","line":69,"range":{"start_line":69,"start_character":13,"end_line":69,"end_character":29},"updated":"2019-08-27 11:13:41.000000000","message":"maybe fake_new_vserver_name?","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"bcbbc89fd02258ef057aa36f806cfdb105dfae21","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.client \u003d self.library._client"},{"line_number":67,"context_line":"        self.fake_new_replica \u003d copy.deepcopy(fake.SHARE)"},{"line_number":68,"context_line":"        self.fake_new_ss \u003d copy.deepcopy(fake.SHARE_SERVER)"},{"line_number":69,"context_line":"        self.fake_new_vserver \u003d \u0027fake_new_vserver\u0027"},{"line_number":70,"context_line":"        self.fake_new_ss[\u0027backend_details\u0027][\u0027vserver_name\u0027] \u003d ("},{"line_number":71,"context_line":"            self.fake_new_vserver"},{"line_number":72,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_87194023","line":69,"range":{"start_line":69,"start_character":13,"end_line":69,"end_character":29},"in_reply_to":"7faddb67_7414184e","updated":"2019-08-28 16:05:48.000000000","message":"Done","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0ae4b8d0d45a5afe1b8896ac09c3e6ff854b3e08","unresolved":false,"context_lines":[{"line_number":836,"context_line":"                         \u0027get_network_interfaces\u0027,"},{"line_number":837,"context_line":"                         mock.Mock(return_value\u003dnet_interfaces))"},{"line_number":838,"context_line":"        security_services \u003d fake.NETWORK_INFO[\u0027security_services\u0027]"},{"line_number":839,"context_line":"        self.mock_object(self.library, \u0027_delete_vserver_peers\u0027)"},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"        self.library._delete_vserver(fake.VSERVER1,"},{"line_number":842,"context_line":"                                     security_services\u003dsecurity_services,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_d404ec1a","line":839,"range":{"start_line":839,"start_character":8,"end_line":839,"end_character":63},"updated":"2019-08-27 11:13:41.000000000","message":"could you please add an assert to this mock?","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"bcbbc89fd02258ef057aa36f806cfdb105dfae21","unresolved":false,"context_lines":[{"line_number":836,"context_line":"                         \u0027get_network_interfaces\u0027,"},{"line_number":837,"context_line":"                         mock.Mock(return_value\u003dnet_interfaces))"},{"line_number":838,"context_line":"        security_services \u003d fake.NETWORK_INFO[\u0027security_services\u0027]"},{"line_number":839,"context_line":"        self.mock_object(self.library, \u0027_delete_vserver_peers\u0027)"},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"        self.library._delete_vserver(fake.VSERVER1,"},{"line_number":842,"context_line":"                                     security_services\u003dsecurity_services,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_a7147cea","line":839,"range":{"start_line":839,"start_character":8,"end_line":839,"end_character":63},"in_reply_to":"7faddb67_d404ec1a","updated":"2019-08-28 16:05:48.000000000","message":"Done","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0ae4b8d0d45a5afe1b8896ac09c3e6ff854b3e08","unresolved":false,"context_lines":[{"line_number":865,"context_line":"                         mock.Mock(return_value\u003dTrue))"},{"line_number":866,"context_line":"        mock_delete_vserver_vlans \u003d self.mock_object(self.library,"},{"line_number":867,"context_line":"                                                     \u0027_delete_vserver_vlans\u0027)"},{"line_number":868,"context_line":"        self.mock_object(self.library, \u0027_delete_vserver_peers\u0027)"},{"line_number":869,"context_line":"        self.mock_object("},{"line_number":870,"context_line":"            vserver_client, \u0027get_network_interfaces\u0027,"},{"line_number":871,"context_line":"            mock.Mock(return_value\u003dc_fake.NETWORK_INTERFACES_MULTIPLE))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_f4ffa8ff","line":868,"range":{"start_line":868,"start_character":8,"end_line":868,"end_character":63},"updated":"2019-08-27 11:13:41.000000000","message":"same as above","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"bcbbc89fd02258ef057aa36f806cfdb105dfae21","unresolved":false,"context_lines":[{"line_number":865,"context_line":"                         mock.Mock(return_value\u003dTrue))"},{"line_number":866,"context_line":"        mock_delete_vserver_vlans \u003d self.mock_object(self.library,"},{"line_number":867,"context_line":"                                                     \u0027_delete_vserver_vlans\u0027)"},{"line_number":868,"context_line":"        self.mock_object(self.library, \u0027_delete_vserver_peers\u0027)"},{"line_number":869,"context_line":"        self.mock_object("},{"line_number":870,"context_line":"            vserver_client, \u0027get_network_interfaces\u0027,"},{"line_number":871,"context_line":"            mock.Mock(return_value\u003dc_fake.NETWORK_INTERFACES_MULTIPLE))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_07db104f","line":868,"range":{"start_line":868,"start_character":8,"end_line":868,"end_character":63},"in_reply_to":"7faddb67_f4ffa8ff","updated":"2019-08-28 16:05:48.000000000","message":"Done","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0ae4b8d0d45a5afe1b8896ac09c3e6ff854b3e08","unresolved":false,"context_lines":[{"line_number":898,"context_line":"                         mock.Mock(return_value\u003dFalse))"},{"line_number":899,"context_line":"        mock_delete_vserver_vlans \u003d self.mock_object(self.library,"},{"line_number":900,"context_line":"                                                     \u0027_delete_vserver_vlans\u0027)"},{"line_number":901,"context_line":"        self.mock_object(self.library, \u0027_delete_vserver_peers\u0027)"},{"line_number":902,"context_line":"        self.mock_object(vserver_client,"},{"line_number":903,"context_line":"                         \u0027get_network_interfaces\u0027,"},{"line_number":904,"context_line":"                         mock.Mock(return_value\u003dinterfaces))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_b7fff2fe","line":901,"range":{"start_line":901,"start_character":8,"end_line":901,"end_character":63},"updated":"2019-08-27 11:13:41.000000000","message":"same as above","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"bcbbc89fd02258ef057aa36f806cfdb105dfae21","unresolved":false,"context_lines":[{"line_number":898,"context_line":"                         mock.Mock(return_value\u003dFalse))"},{"line_number":899,"context_line":"        mock_delete_vserver_vlans \u003d self.mock_object(self.library,"},{"line_number":900,"context_line":"                                                     \u0027_delete_vserver_vlans\u0027)"},{"line_number":901,"context_line":"        self.mock_object(self.library, \u0027_delete_vserver_peers\u0027)"},{"line_number":902,"context_line":"        self.mock_object(vserver_client,"},{"line_number":903,"context_line":"                         \u0027get_network_interfaces\u0027,"},{"line_number":904,"context_line":"                         mock.Mock(return_value\u003dinterfaces))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_27de4c3e","line":901,"range":{"start_line":901,"start_character":8,"end_line":901,"end_character":63},"in_reply_to":"7faddb67_b7fff2fe","updated":"2019-08-28 16:05:48.000000000","message":"Done","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0ae4b8d0d45a5afe1b8896ac09c3e6ff854b3e08","unresolved":false,"context_lines":[{"line_number":916,"context_line":"            fake.IPSPACE)"},{"line_number":917,"context_line":"        mock_delete_vserver_vlans.assert_called_once_with(interfaces)"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"    def test_delete_vserver_peers(self):"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":"        self.mock_object(self.library,"},{"line_number":922,"context_line":"                         \u0027_get_vserver_peers\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_370b0223","line":919,"range":{"start_line":919,"start_character":8,"end_line":919,"end_character":33},"updated":"2019-08-27 11:13:41.000000000","message":"test__delete_vserver_peers","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"bcbbc89fd02258ef057aa36f806cfdb105dfae21","unresolved":false,"context_lines":[{"line_number":916,"context_line":"            fake.IPSPACE)"},{"line_number":917,"context_line":"        mock_delete_vserver_vlans.assert_called_once_with(interfaces)"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"    def test_delete_vserver_peers(self):"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":"        self.mock_object(self.library,"},{"line_number":922,"context_line":"                         \u0027_get_vserver_peers\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_c7e41811","line":919,"range":{"start_line":919,"start_character":8,"end_line":919,"end_character":33},"in_reply_to":"7faddb67_370b0223","updated":"2019-08-28 16:05:48.000000000","message":"Done","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0ae4b8d0d45a5afe1b8896ac09c3e6ff854b3e08","unresolved":false,"context_lines":[{"line_number":973,"context_line":"        self.mock_object(data_motion, \u0027get_client_for_backend\u0027,"},{"line_number":974,"context_line":"                         mock.Mock(side_effect\u003d[self.fake_new_client,"},{"line_number":975,"context_line":"                                                self.fake_client]))"},{"line_number":976,"context_line":"        self.mock_object(self.library, \u0027_get_vserver_peers\u0027,"},{"line_number":977,"context_line":"                         mock.Mock(return_value\u003d[]))"},{"line_number":978,"context_line":"        self.mock_object(self.fake_new_client, \u0027get_cluster_name\u0027,"},{"line_number":979,"context_line":"                         mock.Mock(return_value\u003dfake_cluster_name))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_77a5fa02","line":976,"range":{"start_line":976,"start_character":40,"end_line":976,"end_character":58},"updated":"2019-08-27 11:13:41.000000000","message":"We have a scenario where this can return an existent vserver peering. In your opinion, this is something that we should strongly consider to have an unit test/ddt covering?","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"bcbbc89fd02258ef057aa36f806cfdb105dfae21","unresolved":false,"context_lines":[{"line_number":973,"context_line":"        self.mock_object(data_motion, \u0027get_client_for_backend\u0027,"},{"line_number":974,"context_line":"                         mock.Mock(side_effect\u003d[self.fake_new_client,"},{"line_number":975,"context_line":"                                                self.fake_client]))"},{"line_number":976,"context_line":"        self.mock_object(self.library, \u0027_get_vserver_peers\u0027,"},{"line_number":977,"context_line":"                         mock.Mock(return_value\u003d[]))"},{"line_number":978,"context_line":"        self.mock_object(self.fake_new_client, \u0027get_cluster_name\u0027,"},{"line_number":979,"context_line":"                         mock.Mock(return_value\u003dfake_cluster_name))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_07b470f1","line":976,"range":{"start_line":976,"start_character":40,"end_line":976,"end_character":58},"in_reply_to":"7faddb67_77a5fa02","updated":"2019-08-28 16:05:48.000000000","message":"Yes, you\u0027re correct. Just added the new scenario to cover when the vserver peering already exists.","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0ae4b8d0d45a5afe1b8896ac09c3e6ff854b3e08","unresolved":false,"context_lines":[{"line_number":1038,"context_line":"        self.library._get_vservers_from_replicas.assert_called_once_with("},{"line_number":1039,"context_line":"            None, [self.fake_replica], self.fake_new_replica"},{"line_number":1040,"context_line":"        )"},{"line_number":1041,"context_line":"        base_class \u003d lib_base.NetAppCmodeFileStorageLibrary"},{"line_number":1042,"context_line":"        base_class.delete_replica.assert_called_once_with("},{"line_number":1043,"context_line":"            None, [self.fake_replica], self.fake_new_replica, []"},{"line_number":1044,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_57547efe","line":1041,"range":{"start_line":1041,"start_character":8,"end_line":1041,"end_character":59},"updated":"2019-08-27 11:13:41.000000000","message":"I think it\u0027s a nice idea to declare this variable in the beginning of this method \u0027cause it may me reused in 1027 line.","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"bcbbc89fd02258ef057aa36f806cfdb105dfae21","unresolved":false,"context_lines":[{"line_number":1038,"context_line":"        self.library._get_vservers_from_replicas.assert_called_once_with("},{"line_number":1039,"context_line":"            None, [self.fake_replica], self.fake_new_replica"},{"line_number":1040,"context_line":"        )"},{"line_number":1041,"context_line":"        base_class \u003d lib_base.NetAppCmodeFileStorageLibrary"},{"line_number":1042,"context_line":"        base_class.delete_replica.assert_called_once_with("},{"line_number":1043,"context_line":"            None, [self.fake_replica], self.fake_new_replica, []"},{"line_number":1044,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_e7c83476","line":1041,"range":{"start_line":1041,"start_character":8,"end_line":1041,"end_character":59},"in_reply_to":"7faddb67_57547efe","updated":"2019-08-28 16:05:48.000000000","message":"Done","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0ae4b8d0d45a5afe1b8896ac09c3e6ff854b3e08","unresolved":false,"context_lines":[{"line_number":1054,"context_line":"        )"},{"line_number":1055,"context_line":""},{"line_number":1056,"context_line":"    def test_get_vservers_from_replicas(self):"},{"line_number":1057,"context_line":"        self.mock_object(self.library, \u0027find_active_replica\u0027,"},{"line_number":1058,"context_line":"                         mock.Mock(return_value\u003dself.fake_replica))"},{"line_number":1059,"context_line":"        vserver, peer_vserver \u003d self.library._get_vservers_from_replicas("},{"line_number":1060,"context_line":"            None, [self.fake_replica], self.fake_new_replica)"},{"line_number":1061,"context_line":"        self.assertEqual(self.fake_vserver, vserver)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_77573a03","line":1058,"range":{"start_line":1057,"start_character":8,"end_line":1058,"end_character":66},"updated":"2019-08-27 11:13:41.000000000","message":"Could you please add an assert to this mock?","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"bcbbc89fd02258ef057aa36f806cfdb105dfae21","unresolved":false,"context_lines":[{"line_number":1054,"context_line":"        )"},{"line_number":1055,"context_line":""},{"line_number":1056,"context_line":"    def test_get_vservers_from_replicas(self):"},{"line_number":1057,"context_line":"        self.mock_object(self.library, \u0027find_active_replica\u0027,"},{"line_number":1058,"context_line":"                         mock.Mock(return_value\u003dself.fake_replica))"},{"line_number":1059,"context_line":"        vserver, peer_vserver \u003d self.library._get_vservers_from_replicas("},{"line_number":1060,"context_line":"            None, [self.fake_replica], self.fake_new_replica)"},{"line_number":1061,"context_line":"        self.assertEqual(self.fake_vserver, vserver)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_87c70065","line":1058,"range":{"start_line":1057,"start_character":8,"end_line":1058,"end_character":66},"in_reply_to":"7faddb67_77573a03","updated":"2019-08-28 16:05:48.000000000","message":"Done","commit_id":"842b9ce7f76aaaa621c78ec1898841e95da954f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c7d7633aa893eb73e7550df9fcf9c68f61defdf6","unresolved":false,"context_lines":[{"line_number":911,"context_line":""},{"line_number":912,"context_line":"        self.library._delete_vserver(fake.VSERVER1,"},{"line_number":913,"context_line":"                                     security_services\u003dsecurity_services)"},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"        self.library._client.get_vserver_ipspace.assert_called_once_with("},{"line_number":916,"context_line":"            fake.VSERVER1)"},{"line_number":917,"context_line":"        self.library._client.delete_vserver.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_471ebe70","line":914,"updated":"2019-08-30 17:26:41.000000000","message":"Still need an assert to \u0027_delete_vserver_peers\u0027","commit_id":"daff73f81747aad0023e15a7052f241c6f80f367"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"129ce8cda27cd83541947a265056e0ddfc26c721","unresolved":false,"context_lines":[{"line_number":911,"context_line":""},{"line_number":912,"context_line":"        self.library._delete_vserver(fake.VSERVER1,"},{"line_number":913,"context_line":"                                     security_services\u003dsecurity_services)"},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"        self.library._client.get_vserver_ipspace.assert_called_once_with("},{"line_number":916,"context_line":"            fake.VSERVER1)"},{"line_number":917,"context_line":"        self.library._client.delete_vserver.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_8f603937","line":914,"in_reply_to":"7faddb67_471ebe70","updated":"2019-09-02 17:20:03.000000000","message":"Forgot this one. Thanks.","commit_id":"daff73f81747aad0023e15a7052f241c6f80f367"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6d1066e001ac9b25243214952cab76e9df7fd10c","unresolved":false,"context_lines":[{"line_number":1069,"context_line":"                         mock.Mock(return_value\u003dself.fake_replica))"},{"line_number":1070,"context_line":"        vserver, peer_vserver \u003d self.library._get_vservers_from_replicas("},{"line_number":1071,"context_line":"            None, [self.fake_replica], self.fake_new_replica)"},{"line_number":1072,"context_line":"        self.library.find_active_replica.assert_called_once_with("},{"line_number":1073,"context_line":"            [self.fake_replica]"},{"line_number":1074,"context_line":"        )"},{"line_number":1075,"context_line":"        self.assertEqual(self.fake_vserver, vserver)"},{"line_number":1076,"context_line":"        self.assertEqual(self.fake_new_vserver_name, peer_vserver)"},{"line_number":1077,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_a8ad2132","line":1074,"range":{"start_line":1072,"start_character":7,"end_line":1074,"end_character":9},"updated":"2019-09-11 20:25:35.000000000","message":"nit: in these test files, declarations, actual function calls and asserts are separated with one blank line","commit_id":"32c9eb80f11e57509f9f72259e7c744c6d1130dd"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"3a148bb0dbcce5a55119bde3245ef01617df6cf1","unresolved":false,"context_lines":[{"line_number":1069,"context_line":"                         mock.Mock(return_value\u003dself.fake_replica))"},{"line_number":1070,"context_line":"        vserver, peer_vserver \u003d self.library._get_vservers_from_replicas("},{"line_number":1071,"context_line":"            None, [self.fake_replica], self.fake_new_replica)"},{"line_number":1072,"context_line":"        self.library.find_active_replica.assert_called_once_with("},{"line_number":1073,"context_line":"            [self.fake_replica]"},{"line_number":1074,"context_line":"        )"},{"line_number":1075,"context_line":"        self.assertEqual(self.fake_vserver, vserver)"},{"line_number":1076,"context_line":"        self.assertEqual(self.fake_new_vserver_name, peer_vserver)"},{"line_number":1077,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_8eff0d33","line":1074,"range":{"start_line":1072,"start_character":7,"end_line":1074,"end_character":9},"in_reply_to":"5faad753_a8ad2132","updated":"2019-09-11 22:25:14.000000000","message":"You\u0027re right. I think that I fix it most of the added tests.","commit_id":"32c9eb80f11e57509f9f72259e7c744c6d1130dd"}],"releasenotes/notes/netapp-replication-dhss-true-5b2887de8e9a2cb5.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c7d7633aa893eb73e7550df9fcf9c68f61defdf6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added share replica operations for driver mode  "},{"line_number":5,"context_line":"    ``driver_handles_share_server`` set to True, allowing shares and "},{"line_number":6,"context_line":"    snapshots to be replicated on dynamically created share servers."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_2afee904","line":4,"range":{"start_line":4,"start_character":50,"end_line":4,"end_character":52},"updated":"2019-08-30 17:26:41.000000000","message":"Please remove this blank spaces","commit_id":"daff73f81747aad0023e15a7052f241c6f80f367"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"129ce8cda27cd83541947a265056e0ddfc26c721","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added share replica operations for driver mode  "},{"line_number":5,"context_line":"    ``driver_handles_share_server`` set to True, allowing shares and "},{"line_number":6,"context_line":"    snapshots to be replicated on dynamically created share servers."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_af65f546","line":4,"range":{"start_line":4,"start_character":50,"end_line":4,"end_character":52},"in_reply_to":"7faddb67_2afee904","updated":"2019-09-02 17:20:03.000000000","message":"Done","commit_id":"daff73f81747aad0023e15a7052f241c6f80f367"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c7d7633aa893eb73e7550df9fcf9c68f61defdf6","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added share replica operations for driver mode  "},{"line_number":5,"context_line":"    ``driver_handles_share_server`` set to True, allowing shares and "},{"line_number":6,"context_line":"    snapshots to be replicated on dynamically created share servers."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_4a03250e","line":5,"range":{"start_line":5,"start_character":68,"end_line":5,"end_character":69},"updated":"2019-08-30 17:26:41.000000000","message":"same","commit_id":"daff73f81747aad0023e15a7052f241c6f80f367"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"129ce8cda27cd83541947a265056e0ddfc26c721","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added share replica operations for driver mode  "},{"line_number":5,"context_line":"    ``driver_handles_share_server`` set to True, allowing shares and "},{"line_number":6,"context_line":"    snapshots to be replicated on dynamically created share servers."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_4f56c160","line":5,"range":{"start_line":5,"start_character":68,"end_line":5,"end_character":69},"in_reply_to":"7faddb67_4a03250e","updated":"2019-09-02 17:20:03.000000000","message":"Done","commit_id":"daff73f81747aad0023e15a7052f241c6f80f367"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6d1066e001ac9b25243214952cab76e9df7fd10c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added share replica operations for driver mode"},{"line_number":5,"context_line":"    ``driver_handles_share_server`` set to True, allowing shares and"},{"line_number":6,"context_line":"    snapshots to be replicated on dynamically created share servers."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5faad753_c86dfd04","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":68},"updated":"2019-09-11 20:25:35.000000000","message":"The NetApp driver now supports replication with ``driver_handles_share_servers`` set to True, in addition to the mode where the driver does not handle the creation and management of share servers. For replication to work across ONTAP clusters, clusters must be peered in advance.","commit_id":"32c9eb80f11e57509f9f72259e7c744c6d1130dd"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"3a148bb0dbcce5a55119bde3245ef01617df6cf1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added share replica operations for driver mode"},{"line_number":5,"context_line":"    ``driver_handles_share_server`` set to True, allowing shares and"},{"line_number":6,"context_line":"    snapshots to be replicated on dynamically created share servers."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5faad753_0e99dd1d","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":68},"in_reply_to":"5faad753_c86dfd04","updated":"2019-09-11 22:25:14.000000000","message":"Thanks for helping to clarify this. Was a good idea to advice about the cluster peering.","commit_id":"32c9eb80f11e57509f9f72259e7c744c6d1130dd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6d18cc06526200d8013440be07c39b11bfc8e358","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The NetApp driver now supports replication with"},{"line_number":5,"context_line":"    ``driver_handles_share_server`` set to True, in addition to the mode where"},{"line_number":6,"context_line":"    the driver does not handle the creation and management of share servers."},{"line_number":7,"context_line":"    For replication to work across ONTAP clusters, clusters must be peered in"},{"line_number":8,"context_line":"    advance."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5faad753_6e04114b","line":5,"range":{"start_line":5,"start_character":27,"end_line":5,"end_character":33},"updated":"2019-09-11 22:14:37.000000000","message":"servers","commit_id":"17dbf71de69115bdd769e09dcecfa70a1d942db6"}]}