)]}'
{"manila/compute/nova.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"502855ec23b4e5266044749b029a8a2d587052ee","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        client \u003d novaclient(context)"},{"line_number":273,"context_line":"        try:"},{"line_number":274,"context_line":"            # New novaclient without \u0027images\u0027 API proxy"},{"line_number":275,"context_line":"            return client.glance.find_image(name)"},{"line_number":276,"context_line":"        except nova_exception.NotFound:"},{"line_number":277,"context_line":"            raise exception.ServiceInstanceException("},{"line_number":278,"context_line":"                _(\"Image with name \u0027%s\u0027 was not found.\") % name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_7cd37202","line":275,"range":{"start_line":275,"start_character":12,"end_line":275,"end_character":49},"updated":"2019-11-14 14:52:05.000000000","message":"What if we\u0027re using an older nova client?","commit_id":"f80907bd6df5952b3c7e409dd8e97f7f898ee7c4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3d58562f051dbf78533846ef94cfc9de16715b0d","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        client \u003d novaclient(context)"},{"line_number":273,"context_line":"        try:"},{"line_number":274,"context_line":"            # New novaclient without \u0027images\u0027 API proxy"},{"line_number":275,"context_line":"            return client.glance.find_image(name)"},{"line_number":276,"context_line":"        except nova_exception.NotFound:"},{"line_number":277,"context_line":"            raise exception.ServiceInstanceException("},{"line_number":278,"context_line":"                _(\"Image with name \u0027%s\u0027 was not found.\") % name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_55f8527a","line":275,"range":{"start_line":275,"start_character":12,"end_line":275,"end_character":49},"in_reply_to":"3fa7e38b_2c05c214","updated":"2019-12-12 15:03:12.000000000","message":"Makes sense, we shouldn\u0027t expect anyone installing such an old version of the nova client in the share node.\n\nThe minimum required nova client is 9.1.0 [1] and it has find_image [2]\n\n[1] https://opendev.org/openstack/manila/src/commit/62efe7b88598fedd46f010d04aa79b8acacc4332/requirements.txt#L45\n[2] https://opendev.org/openstack/python-novaclient/src/tag/9.1.0/novaclient/v2/images.py#L40","commit_id":"f80907bd6df5952b3c7e409dd8e97f7f898ee7c4"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"3ae81e1e386fa93d8e3760fbd36edd2f064743e2","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        client \u003d novaclient(context)"},{"line_number":273,"context_line":"        try:"},{"line_number":274,"context_line":"            # New novaclient without \u0027images\u0027 API proxy"},{"line_number":275,"context_line":"            return client.glance.find_image(name)"},{"line_number":276,"context_line":"        except nova_exception.NotFound:"},{"line_number":277,"context_line":"            raise exception.ServiceInstanceException("},{"line_number":278,"context_line":"                _(\"Image with name \u0027%s\u0027 was not found.\") % name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_2c05c214","line":275,"range":{"start_line":275,"start_character":12,"end_line":275,"end_character":49},"in_reply_to":"3fa7e38b_7cd37202","updated":"2019-11-15 05:08:52.000000000","message":"I found that the \u0027find_image\u0027 has been supported since stable/ocata. Should we consider more older novaclient?","commit_id":"f80907bd6df5952b3c7e409dd8e97f7f898ee7c4"}],"releasenotes/notes/bug_1844046-fix-image-not-found-629415d50cd6042a.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3d58562f051dbf78533846ef94cfc9de16715b0d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Glance image list API supports pagination, but `_get_service_image`"},{"line_number":5,"context_line":"    uses novaclient.glance.list() that only return images in one page."},{"line_number":6,"context_line":"    When the image needed by share server is not returned in the first"},{"line_number":7,"context_line":"    page, the exception occurs. This patch will use `find_image` method"},{"line_number":8,"context_line":"    to get the image."},{"line_number":9,"context_line":"    Since latest novaclient has no proxy to lookup image, so only"},{"line_number":10,"context_line":"    novaclient.glance."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_35d036f4","line":10,"range":{"start_line":4,"start_character":4,"end_line":10,"end_character":22},"updated":"2019-12-12 15:03:12.000000000","message":"This is too descriptive for a release note, and references a code patch which readers may not be interested in checking out. Here\u0027s a view of the release notes from our last release: https://docs.openstack.org/releasenotes/manila/train.html\n\nI suggest rewriting this a little more briefly:\n\n  The Generic driver has been fixed to invoke compute image\n  retrieval by ID rather than list all images and implement a filter.\n  This prevents failures in case there are a lot of images available\n  and the image service returns a paginated response.","commit_id":"f80907bd6df5952b3c7e409dd8e97f7f898ee7c4"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"d48510d36cf31312de2a86e00091156c7de18287","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Glance image list API supports pagination, but `_get_service_image`"},{"line_number":5,"context_line":"    uses novaclient.glance.list() that only return images in one page."},{"line_number":6,"context_line":"    When the image needed by share server is not returned in the first"},{"line_number":7,"context_line":"    page, the exception occurs. This patch will use `find_image` method"},{"line_number":8,"context_line":"    to get the image."},{"line_number":9,"context_line":"    Since latest novaclient has no proxy to lookup image, so only"},{"line_number":10,"context_line":"    novaclient.glance."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_383a63c3","line":10,"range":{"start_line":4,"start_character":4,"end_line":10,"end_character":22},"in_reply_to":"3fa7e38b_35d036f4","updated":"2020-01-01 13:49:54.000000000","message":"\u003e This is too descriptive for a release note, and references a code\n \u003e patch which readers may not be interested in checking out. Here\u0027s a\n \u003e view of the release notes from our last release: https://docs.openstack.org/releasenotes/manila/train.html\n \u003e \n \u003e I suggest rewriting this a little more briefly:\n \u003e \n \u003e The Generic driver has been fixed to invoke compute image\n \u003e retrieval by ID rather than list all images and implement a filter.\n \u003e This prevents failures in case there are a lot of images available\n \u003e and the image service returns a paginated response.","commit_id":"f80907bd6df5952b3c7e409dd8e97f7f898ee7c4"}]}