)]}'
{"manila/api/v2/share_networks.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"90bbaccf9e0ce30d068a003c3852c965942bb460","unresolved":false,"context_lines":[{"line_number":273,"context_line":"                subnet \u003d db_api.share_network_subnet_get_default_subnet("},{"line_number":274,"context_line":"                    context, id)"},{"line_number":275,"context_line":"                if not subnet:"},{"line_number":276,"context_line":"                    msg \u003d _(\"This operation cannot be completed. A default \""},{"line_number":277,"context_line":"                            \"share network subnet was not found in the \""},{"line_number":278,"context_line":"                            \"share network %(id)s.\") % {\u0027id\u0027: id}"},{"line_number":279,"context_line":"                    raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"                # NOTE(silvacarlose): If the default share network subnet have"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_41421c6a","line":278,"range":{"start_line":276,"start_character":65,"end_line":278,"end_character":42},"updated":"2019-10-11 02:02:47.000000000","message":"rephrase this slightly so we can convey more info:\n\n The share network %(id)s does not have a \u0027default\u0027 subnet \n that serves all availability zones, so subnet\n details (\u0027neutron_net_id\u0027, \u0027neutron_subnet_id\u0027) cannot\n be updated.","commit_id":"4b4a6775d273188e20c8f6e2886f520ae54d6c3b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a79577534f313a4e83d618db73b1e4ff7336f54e","unresolved":false,"context_lines":[{"line_number":273,"context_line":"                subnet \u003d db_api.share_network_subnet_get_default_subnet("},{"line_number":274,"context_line":"                    context, id)"},{"line_number":275,"context_line":"                if not subnet:"},{"line_number":276,"context_line":"                    msg \u003d _(\"This operation cannot be completed. A default \""},{"line_number":277,"context_line":"                            \"share network subnet was not found in the \""},{"line_number":278,"context_line":"                            \"share network %(id)s.\") % {\u0027id\u0027: id}"},{"line_number":279,"context_line":"                    raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"                # NOTE(silvacarlose): If the default share network subnet have"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8e3358ab","line":278,"range":{"start_line":276,"start_character":65,"end_line":278,"end_character":42},"in_reply_to":"3fa7e38b_41421c6a","updated":"2019-10-11 14:16:38.000000000","message":"Great. Really looks better in the way you suggested. Thanks","commit_id":"4b4a6775d273188e20c8f6e2886f520ae54d6c3b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"90bbaccf9e0ce30d068a003c3852c965942bb460","unresolved":false,"context_lines":[{"line_number":276,"context_line":"                    msg \u003d _(\"This operation cannot be completed. A default \""},{"line_number":277,"context_line":"                            \"share network subnet was not found in the \""},{"line_number":278,"context_line":"                            \"share network %(id)s.\") % {\u0027id\u0027: id}"},{"line_number":279,"context_line":"                    raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"                # NOTE(silvacarlose): If the default share network subnet have"},{"line_number":282,"context_line":"                # the fields neutron_net_id and neutron_subnet_id set as None,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_419bfc15","line":279,"range":{"start_line":279,"start_character":30,"end_line":279,"end_character":42},"updated":"2019-10-11 02:02:47.000000000","message":"BadRequest\n\n \n\nThe entity that wasn\u0027t found is not part of the URI - so this can\u0027t be HTTP404,\n\n \n\nHTTP404 is cacheable by clients - if, they went ahead and created a subnet and then decided to update the network, the client could stop the request by replaying its cache.","commit_id":"4b4a6775d273188e20c8f6e2886f520ae54d6c3b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a79577534f313a4e83d618db73b1e4ff7336f54e","unresolved":false,"context_lines":[{"line_number":276,"context_line":"                    msg \u003d _(\"This operation cannot be completed. A default \""},{"line_number":277,"context_line":"                            \"share network subnet was not found in the \""},{"line_number":278,"context_line":"                            \"share network %(id)s.\") % {\u0027id\u0027: id}"},{"line_number":279,"context_line":"                    raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"                # NOTE(silvacarlose): If the default share network subnet have"},{"line_number":282,"context_line":"                # the fields neutron_net_id and neutron_subnet_id set as None,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_ae1734ee","line":279,"range":{"start_line":279,"start_character":30,"end_line":279,"end_character":42},"in_reply_to":"3fa7e38b_419bfc15","updated":"2019-10-11 14:16:38.000000000","message":"Great concern, thanks.","commit_id":"4b4a6775d273188e20c8f6e2886f520ae54d6c3b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"90bbaccf9e0ce30d068a003c3852c965942bb460","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                subnet_neutron_net_and_subnet_id_are_empty \u003d ("},{"line_number":287,"context_line":"                    subnet[\u0027neutron_net_id\u0027] is None"},{"line_number":288,"context_line":"                    and subnet[\u0027neutron_subnet_id\u0027] is None)"},{"line_number":289,"context_line":"                update_values_without_neutron_net_or_subnet \u003d ("},{"line_number":290,"context_line":"                    \u0027neutron_net_id\u0027 not in update_values"},{"line_number":291,"context_line":"                    or \u0027neutron_subnet_id\u0027 not in update_values)"},{"line_number":292,"context_line":"                if (subnet_neutron_net_and_subnet_id_are_empty"},{"line_number":293,"context_line":"                        and update_values_without_neutron_net_or_subnet):"},{"line_number":294,"context_line":"                    msg \u003d _("}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_0c6a1bb2","line":291,"range":{"start_line":289,"start_character":62,"end_line":291,"end_character":64},"updated":"2019-10-11 02:02:47.000000000","message":"Should be:\n\n update_values.get(\u0027neutron_net_id\u0027) is None or \n  update_values.get(\u0027neutron_subnet_id\u0027) is None\n\nSo that you can also prevent updates where either value is null..","commit_id":"4b4a6775d273188e20c8f6e2886f520ae54d6c3b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a79577534f313a4e83d618db73b1e4ff7336f54e","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                subnet_neutron_net_and_subnet_id_are_empty \u003d ("},{"line_number":287,"context_line":"                    subnet[\u0027neutron_net_id\u0027] is None"},{"line_number":288,"context_line":"                    and subnet[\u0027neutron_subnet_id\u0027] is None)"},{"line_number":289,"context_line":"                update_values_without_neutron_net_or_subnet \u003d ("},{"line_number":290,"context_line":"                    \u0027neutron_net_id\u0027 not in update_values"},{"line_number":291,"context_line":"                    or \u0027neutron_subnet_id\u0027 not in update_values)"},{"line_number":292,"context_line":"                if (subnet_neutron_net_and_subnet_id_are_empty"},{"line_number":293,"context_line":"                        and update_values_without_neutron_net_or_subnet):"},{"line_number":294,"context_line":"                    msg \u003d _("}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8ea6f8c0","line":291,"range":{"start_line":289,"start_character":62,"end_line":291,"end_character":64},"in_reply_to":"3fa7e38b_0c6a1bb2","updated":"2019-10-11 14:16:38.000000000","message":"Thanks :)","commit_id":"4b4a6775d273188e20c8f6e2886f520ae54d6c3b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"90bbaccf9e0ce30d068a003c3852c965942bb460","unresolved":false,"context_lines":[{"line_number":293,"context_line":"                        and update_values_without_neutron_net_or_subnet):"},{"line_number":294,"context_line":"                    msg \u003d _("},{"line_number":295,"context_line":"                        \"To update the share network %(id)s you need to \""},{"line_number":296,"context_line":"                        \"specify both neutron_net_id and neutron_subnet_id \""},{"line_number":297,"context_line":"                        \"because these fields are currently \""},{"line_number":298,"context_line":"                        \"empty.\") % {\u0027id\u0027: id}"},{"line_number":299,"context_line":"                    raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_2c3ef7b7","line":296,"range":{"start_line":296,"start_character":38,"end_line":296,"end_character":52},"updated":"2019-10-11 02:02:47.000000000","message":"\u0027neutron_net_id\u0027 and \u0027neutron_subnet_id\u0027","commit_id":"4b4a6775d273188e20c8f6e2886f520ae54d6c3b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a79577534f313a4e83d618db73b1e4ff7336f54e","unresolved":false,"context_lines":[{"line_number":293,"context_line":"                        and update_values_without_neutron_net_or_subnet):"},{"line_number":294,"context_line":"                    msg \u003d _("},{"line_number":295,"context_line":"                        \"To update the share network %(id)s you need to \""},{"line_number":296,"context_line":"                        \"specify both neutron_net_id and neutron_subnet_id \""},{"line_number":297,"context_line":"                        \"because these fields are currently \""},{"line_number":298,"context_line":"                        \"empty.\") % {\u0027id\u0027: id}"},{"line_number":299,"context_line":"                    raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_0e920858","line":296,"range":{"start_line":296,"start_character":38,"end_line":296,"end_character":52},"in_reply_to":"3fa7e38b_2c3ef7b7","updated":"2019-10-11 14:16:38.000000000","message":"Done","commit_id":"4b4a6775d273188e20c8f6e2886f520ae54d6c3b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"90bbaccf9e0ce30d068a003c3852c965942bb460","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                    msg \u003d _("},{"line_number":295,"context_line":"                        \"To update the share network %(id)s you need to \""},{"line_number":296,"context_line":"                        \"specify both neutron_net_id and neutron_subnet_id \""},{"line_number":297,"context_line":"                        \"because these fields are currently \""},{"line_number":298,"context_line":"                        \"empty.\") % {\u0027id\u0027: id}"},{"line_number":299,"context_line":"                    raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":300,"context_line":"                db_api.share_network_subnet_update(context,"},{"line_number":301,"context_line":"                                                   subnet[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8c760ba4","line":298,"range":{"start_line":297,"start_character":25,"end_line":298,"end_character":31},"updated":"2019-10-11 02:02:47.000000000","message":"implied above, remove...","commit_id":"4b4a6775d273188e20c8f6e2886f520ae54d6c3b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a79577534f313a4e83d618db73b1e4ff7336f54e","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                    msg \u003d _("},{"line_number":295,"context_line":"                        \"To update the share network %(id)s you need to \""},{"line_number":296,"context_line":"                        \"specify both neutron_net_id and neutron_subnet_id \""},{"line_number":297,"context_line":"                        \"because these fields are currently \""},{"line_number":298,"context_line":"                        \"empty.\") % {\u0027id\u0027: id}"},{"line_number":299,"context_line":"                    raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":300,"context_line":"                db_api.share_network_subnet_update(context,"},{"line_number":301,"context_line":"                                                   subnet[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_ce971045","line":298,"range":{"start_line":297,"start_character":25,"end_line":298,"end_character":31},"in_reply_to":"3fa7e38b_8c760ba4","updated":"2019-10-11 14:16:38.000000000","message":"Done","commit_id":"4b4a6775d273188e20c8f6e2886f520ae54d6c3b"}],"manila/tests/api/v2/test_share_networks.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"90bbaccf9e0ce30d068a003c3852c965942bb460","unresolved":false,"context_lines":[{"line_number":855,"context_line":"            db_api.share_network_subnet_get_default_subnet.return_value \u003d ("},{"line_number":856,"context_line":"                fake_subnet)"},{"line_number":857,"context_line":"        body \u003d {"},{"line_number":858,"context_line":"            share_networks.RESOURCE_NAME: {\u0027neutron_subnet_id\u0027: \u0027new subnet\u0027}"},{"line_number":859,"context_line":"        }"},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"        self.assertRaises(exception_to_raise,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_47954c31","line":858,"range":{"start_line":858,"start_character":12,"end_line":858,"end_character":77},"updated":"2019-10-11 02:02:47.000000000","message":"could extend this with ddt:\n\n  share_networks.RESOURCE_NAME: {\u0027neutron_subnet_id\u0027: \u0027new subnet\u0027, \u0027neutron_subnet_id\u0027: None}\n  share_networks.RESOURCE_NAME: {\u0027neutron_subnet_id\u0027: None, \u0027neutron_subnet_id\u0027: \u0027neutron net\u0027}","commit_id":"4b4a6775d273188e20c8f6e2886f520ae54d6c3b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a79577534f313a4e83d618db73b1e4ff7336f54e","unresolved":false,"context_lines":[{"line_number":855,"context_line":"            db_api.share_network_subnet_get_default_subnet.return_value \u003d ("},{"line_number":856,"context_line":"                fake_subnet)"},{"line_number":857,"context_line":"        body \u003d {"},{"line_number":858,"context_line":"            share_networks.RESOURCE_NAME: {\u0027neutron_subnet_id\u0027: \u0027new subnet\u0027}"},{"line_number":859,"context_line":"        }"},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"        self.assertRaises(exception_to_raise,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8e303858","line":858,"range":{"start_line":858,"start_character":12,"end_line":858,"end_character":77},"in_reply_to":"3fa7e38b_47954c31","updated":"2019-10-11 14:16:38.000000000","message":"Done","commit_id":"4b4a6775d273188e20c8f6e2886f520ae54d6c3b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a5383f53ff369c831f3a612079535e0d9a681082","unresolved":false,"context_lines":[{"line_number":834,"context_line":"            self.context, fake_share_network_subnet[\u0027id\u0027],"},{"line_number":835,"context_line":"            body[\u0027share_network\u0027])"},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"    @ddt.data((webob_exc.HTTPBadRequest, fake_share_network_subnet, None,"},{"line_number":838,"context_line":"               \u0027new subnet\u0027),"},{"line_number":839,"context_line":"              (webob_exc.HTTPBadRequest, None, \u0027neutron net\u0027, None))"},{"line_number":840,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_6d929f59","line":837,"range":{"start_line":837,"start_character":15,"end_line":837,"end_character":39},"updated":"2019-10-11 17:55:07.000000000","message":"this doesn\u0027t change in both test cases supplied via ddt here... so drop as a parameter?","commit_id":"de2d94172bebc8d8771e2e67860d94559a86cece"}],"releasenotes/notes/bug-1846836-fix-share-network-update-unexpected-success-eba8f40db392c467.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"90bbaccf9e0ce30d068a003c3852c965942bb460","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed unexpected behavior when updating a share network `neutron_net_id`"},{"line_number":5,"context_line":"    or `neutron_subnet_id`. Now, Manila does not allow the update of share"},{"line_number":6,"context_line":"    networks that does not contain a default subnet."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_27c93058","line":4,"range":{"start_line":4,"start_character":46,"end_line":4,"end_character":59},"updated":"2019-10-11 02:02:47.000000000","message":"share network\u0027s","commit_id":"4b4a6775d273188e20c8f6e2886f520ae54d6c3b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a79577534f313a4e83d618db73b1e4ff7336f54e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed unexpected behavior when updating a share network `neutron_net_id`"},{"line_number":5,"context_line":"    or `neutron_subnet_id`. Now, Manila does not allow the update of share"},{"line_number":6,"context_line":"    networks that does not contain a default subnet."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_ce4dd03b","line":4,"range":{"start_line":4,"start_character":46,"end_line":4,"end_character":59},"in_reply_to":"3fa7e38b_27c93058","updated":"2019-10-11 14:16:38.000000000","message":"Done","commit_id":"4b4a6775d273188e20c8f6e2886f520ae54d6c3b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"90bbaccf9e0ce30d068a003c3852c965942bb460","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed unexpected behavior when updating a share network `neutron_net_id`"},{"line_number":5,"context_line":"    or `neutron_subnet_id`. Now, Manila does not allow the update of share"},{"line_number":6,"context_line":"    networks that does not contain a default subnet."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_47aeac81","line":6,"range":{"start_line":5,"start_character":55,"end_line":6,"end_character":52},"updated":"2019-10-11 02:02:47.000000000","message":"updating a share network that does not contain a default subnet.","commit_id":"4b4a6775d273188e20c8f6e2886f520ae54d6c3b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a79577534f313a4e83d618db73b1e4ff7336f54e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed unexpected behavior when updating a share network `neutron_net_id`"},{"line_number":5,"context_line":"    or `neutron_subnet_id`. Now, Manila does not allow the update of share"},{"line_number":6,"context_line":"    networks that does not contain a default subnet."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_2e56e4cf","line":6,"range":{"start_line":5,"start_character":55,"end_line":6,"end_character":52},"in_reply_to":"3fa7e38b_47aeac81","updated":"2019-10-11 14:16:38.000000000","message":"Done","commit_id":"4b4a6775d273188e20c8f6e2886f520ae54d6c3b"}]}