)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fe3e86fd9ee846bd475db4c770fec0217f375eb7","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"3. Try to get share server name from property \u0027identifier\u0027"},{"line_number":16,"context_line":"first in case this is managed share server"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I676475d0500ecce31a1a863926accec8585ac83a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_d31e7e0c","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":0},"updated":"2019-10-17 17:14:24.000000000","message":"Can you please file a blueprint for this on Launchpad?\n\nhttps://blueprints.launchpad.net/manila/","commit_id":"14d7272bdd36755727749e51b1aa9e56a0923757"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"320396e59db41fa8a260f87e638115e70b5a8fe7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[Unity] Manage/unmanage share server/share/snap"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. Try parse share_backend_id from export path in case"},{"line_number":10,"context_line":"it is managed share. path like:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"2. Try to take snapshot id from \u0027provider_location\u0027 in case"},{"line_number":13,"context_line":"this is managed snapshot"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1fa4df85_e37600d9","line":10,"range":{"start_line":10,"start_character":21,"end_line":10,"end_character":31},"updated":"2020-02-28 02:43:09.000000000","message":"were you going to add some example after this words?","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"}],"doc/source/configuration/shared-file-systems/drivers/dell-emc-unity-driver.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fe3e86fd9ee846bd475db4c770fec0217f375eb7","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"   .. code-block:: console"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"      $ Unisphere -\u003e Settings -\u003e Management -\u003e System Time and NTP"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"   Select ``Enable NTP synchronization`` and add your NTP server(s)."},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_9318061f","line":100,"range":{"start_line":100,"start_character":6,"end_line":100,"end_character":8},"updated":"2019-10-17 17:14:24.000000000","message":"doesn\u0027t look like a console command, so drop the $ maybe?","commit_id":"14d7272bdd36755727749e51b1aa9e56a0923757"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"f1d210334e77c79bcdefa678b1ae92cc695bc1bc","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"   .. code-block:: console"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"      $ Unisphere -\u003e Settings -\u003e Management -\u003e System Time and NTP"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"   Select ``Enable NTP synchronization`` and add your NTP server(s)."},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_ffcc988b","line":100,"range":{"start_line":100,"start_character":6,"end_line":100,"end_character":8},"in_reply_to":"3fa7e38b_9318061f","updated":"2019-10-18 02:12:08.000000000","message":"Done","commit_id":"14d7272bdd36755727749e51b1aa9e56a0923757"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fe3e86fd9ee846bd475db4c770fec0217f375eb7","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"   .. code-block:: console"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"      $ Unisphere -\u003e Settings -\u003e Management -\u003e DNS Server"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"   Select ``Configure DNS server address manually`` and add your DNS server(s)."},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_53d04e2c","line":115,"range":{"start_line":115,"start_character":5,"end_line":115,"end_character":8},"updated":"2019-10-17 17:14:24.000000000","message":"same","commit_id":"14d7272bdd36755727749e51b1aa9e56a0923757"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"f1d210334e77c79bcdefa678b1ae92cc695bc1bc","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"   .. code-block:: console"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"      $ Unisphere -\u003e Settings -\u003e Management -\u003e DNS Server"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"   Select ``Configure DNS server address manually`` and add your DNS server(s)."},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_1fcad46d","line":115,"range":{"start_line":115,"start_character":5,"end_line":115,"end_character":8},"in_reply_to":"3fa7e38b_53d04e2c","updated":"2019-10-18 02:12:08.000000000","message":"Done","commit_id":"14d7272bdd36755727749e51b1aa9e56a0923757"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a94fbcfb81c885a680af597ac3b332d173f699a8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"* Create/Delete snapshot of a share."},{"line_number":45,"context_line":"* Create a new share from snapshot."},{"line_number":46,"context_line":"* Revert a share to a snapshot."},{"line_number":47,"context_line":"* Manage/Unmanage a share server."},{"line_number":48,"context_line":"* Manage/Unmanage a share."},{"line_number":49,"context_line":"* Manage/Unmanage a snapshot."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Supported Network Topologies"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa7e38b_017a40b9","line":49,"range":{"start_line":47,"start_character":0,"end_line":49,"end_character":29},"updated":"2019-10-22 20:41:23.000000000","message":"I haven\u0027t found the driver implementation for: unmanage a share, unmanage a snapshot, unmanage a share with server and unmanage a snapshot with server.","commit_id":"b2c62cc01d9fce246a06d5d2901c984a20bd8447"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"93cfdea0ef743b857500db54316294c1ecc5262f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"* Create/Delete snapshot of a share."},{"line_number":45,"context_line":"* Create a new share from snapshot."},{"line_number":46,"context_line":"* Revert a share to a snapshot."},{"line_number":47,"context_line":"* Manage/Unmanage a share server."},{"line_number":48,"context_line":"* Manage/Unmanage a share."},{"line_number":49,"context_line":"* Manage/Unmanage a snapshot."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Supported Network Topologies"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa7e38b_ecaa786f","line":49,"range":{"start_line":47,"start_character":0,"end_line":49,"end_character":29},"in_reply_to":"3fa7e38b_017a40b9","updated":"2019-10-23 02:58:01.000000000","message":"The unmanage functions was supported by framework.\nJust remove the resource from Openstack side.\nBy default, all the drivers supported unmanage.\nThere is no special action needs on driver.","commit_id":"b2c62cc01d9fce246a06d5d2901c984a20bd8447"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"9c79a808f03bf5ccea2f30d404b8678af36b5afa","unresolved":false,"context_lines":[{"line_number":44,"context_line":"* Create/Delete snapshot of a share."},{"line_number":45,"context_line":"* Create a new share from snapshot."},{"line_number":46,"context_line":"* Revert a share to a snapshot."},{"line_number":47,"context_line":"* Manage/Unmanage a share server."},{"line_number":48,"context_line":"* Manage/Unmanage a share."},{"line_number":49,"context_line":"* Manage/Unmanage a snapshot."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Supported Network Topologies"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa7e38b_d6a66255","line":49,"range":{"start_line":47,"start_character":0,"end_line":49,"end_character":29},"in_reply_to":"3fa7e38b_37651b1e","updated":"2019-11-27 02:56:13.000000000","message":"add the ummanage related methods with log records.","commit_id":"b2c62cc01d9fce246a06d5d2901c984a20bd8447"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6716fc1f612e1ccd57371dc6435fc6d74562ab12","unresolved":false,"context_lines":[{"line_number":44,"context_line":"* Create/Delete snapshot of a share."},{"line_number":45,"context_line":"* Create a new share from snapshot."},{"line_number":46,"context_line":"* Revert a share to a snapshot."},{"line_number":47,"context_line":"* Manage/Unmanage a share server."},{"line_number":48,"context_line":"* Manage/Unmanage a share."},{"line_number":49,"context_line":"* Manage/Unmanage a snapshot."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Supported Network Topologies"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa7e38b_37651b1e","line":49,"range":{"start_line":47,"start_character":0,"end_line":49,"end_character":29},"in_reply_to":"3fa7e38b_ecaa786f","updated":"2019-10-24 12:37:54.000000000","message":"If no actions are needed, it\u0027s ok, but a empty method let the code more readable for other developers. This is up to you, since you\u0027re the maintainer. Thanks for answering.","commit_id":"b2c62cc01d9fce246a06d5d2901c984a20bd8447"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"f20f09c22c4e1f764cd21f583454a66d56de3b34","unresolved":false,"context_lines":[{"line_number":317,"context_line":""},{"line_number":318,"context_line":"To manage a share server existing in Unity System, you need to:"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"#. Create network, subnet, port(ip address of nas server in Unity system) and share network in OpenStack."},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    .. code-block:: console"},{"line_number":323,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1fa4df85_96d78d24","line":320,"range":{"start_line":320,"start_character":1,"end_line":320,"end_character":105},"updated":"2020-02-24 16:21:02.000000000","message":"Can you make sure that all text fits into 80 characters line\nCode snipped is ok to go over if need to.","commit_id":"b5f15acde5a715595dfdb383eb853c5e4cd7a3d1"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"8d0243696ca8f7b527e6bd9bf3356af004393146","unresolved":false,"context_lines":[{"line_number":317,"context_line":""},{"line_number":318,"context_line":"To manage a share server existing in Unity System, you need to:"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"#. Create network, subnet, port(ip address of nas server in Unity system) and share network in OpenStack."},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    .. code-block:: console"},{"line_number":323,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1fa4df85_beeff685","line":320,"range":{"start_line":320,"start_character":1,"end_line":320,"end_character":105},"in_reply_to":"1fa4df85_96d78d24","updated":"2020-02-25 02:00:15.000000000","message":"Done","commit_id":"b5f15acde5a715595dfdb383eb853c5e4cd7a3d1"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"f20f09c22c4e1f764cd21f583454a66d56de3b34","unresolved":false,"context_lines":[{"line_number":325,"context_line":"        $ openstack subnet create \u003csubnet_name\u003e --network \u003cnetwork_name\u003e --subnet-range \u003csubnet_range\u003e"},{"line_number":326,"context_line":"        $ openstack port create --network \u003cnetwork_name\u003e --fixed-ip subnet\u003d\u003csubnet_name\u003e,ip-address\u003d\u003cip address\u003e \\"},{"line_number":327,"context_line":"          \u003cport_name\u003e --device-owner\u003dmanila:share"},{"line_number":328,"context_line":"        $ manila share-network-create --name \u003cshare_network_name\u003e --neutron-net-id \u003cnetwork_name\u003e \\"},{"line_number":329,"context_line":"          --neutron-subnet-id \u003csubnet_name\u003e"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"#. Manage the share server in OpenStack, \u0027\u003cidentifier\u003e\u0027 is the nas server name in Unity system:"},{"line_number":332,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1fa4df85_d673c54c","line":329,"range":{"start_line":328,"start_character":0,"end_line":329,"end_character":43},"updated":"2020-02-24 16:21:02.000000000","message":"why are we still using manila and not openstack?","commit_id":"b5f15acde5a715595dfdb383eb853c5e4cd7a3d1"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"8d0243696ca8f7b527e6bd9bf3356af004393146","unresolved":false,"context_lines":[{"line_number":325,"context_line":"        $ openstack subnet create \u003csubnet_name\u003e --network \u003cnetwork_name\u003e --subnet-range \u003csubnet_range\u003e"},{"line_number":326,"context_line":"        $ openstack port create --network \u003cnetwork_name\u003e --fixed-ip subnet\u003d\u003csubnet_name\u003e,ip-address\u003d\u003cip address\u003e \\"},{"line_number":327,"context_line":"          \u003cport_name\u003e --device-owner\u003dmanila:share"},{"line_number":328,"context_line":"        $ manila share-network-create --name \u003cshare_network_name\u003e --neutron-net-id \u003cnetwork_name\u003e \\"},{"line_number":329,"context_line":"          --neutron-subnet-id \u003csubnet_name\u003e"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"#. Manage the share server in OpenStack, \u0027\u003cidentifier\u003e\u0027 is the nas server name in Unity system:"},{"line_number":332,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1fa4df85_5e004235","line":329,"range":{"start_line":328,"start_character":0,"end_line":329,"end_character":43},"in_reply_to":"1fa4df85_d673c54c","updated":"2020-02-25 02:00:15.000000000","message":"that is because\u0027openstack\u0027 commands list don\u0027t have create share-network related command. So still using manila.","commit_id":"b5f15acde5a715595dfdb383eb853c5e4cd7a3d1"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"320396e59db41fa8a260f87e638115e70b5a8fe7","unresolved":false,"context_lines":[{"line_number":327,"context_line":""},{"line_number":328,"context_line":"To manage a share server existing in Unity System, you need to:"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"#. Create network, subnet, port(ip address of nas server in Unity system) and"},{"line_number":331,"context_line":"   share network in OpenStack."},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    .. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1fa4df85_a61c966a","line":330,"updated":"2020-02-28 02:43:09.000000000","message":"nit: please add a blank space here","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"5fe111308edb9a9f8c16ce6ef0349793c36d2951","unresolved":false,"context_lines":[{"line_number":327,"context_line":""},{"line_number":328,"context_line":"To manage a share server existing in Unity System, you need to:"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"#. Create network, subnet, port(ip address of nas server in Unity system) and"},{"line_number":331,"context_line":"   share network in OpenStack."},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    .. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1fa4df85_9192f2f5","line":330,"in_reply_to":"1fa4df85_a61c966a","updated":"2020-03-03 08:12:44.000000000","message":"Done","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"320396e59db41fa8a260f87e638115e70b5a8fe7","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    .. code-block:: console"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        $ openstack network create \u003cnetwork_name\u003e --provider-network-type \u003cnetwork_type\u003e"},{"line_number":336,"context_line":"        $ openstack subnet create \u003csubnet_name\u003e --network \u003cnetwork_name\u003e --subnet-range \u003csubnet_range\u003e"},{"line_number":337,"context_line":"        $ openstack port create --network \u003cnetwork_name\u003e --fixed-ip subnet\u003d\u003csubnet_name\u003e,ip-address\u003d\u003cip address\u003e \\"},{"line_number":338,"context_line":"          \u003cport_name\u003e --device-owner\u003dmanila:share"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1fa4df85_66769ea7","line":335,"updated":"2020-02-28 02:43:09.000000000","message":"What do you think about formatting this as [1]?\n\n[1] https://review.opendev.org/#/c/688227/10/doc/source/configuration/shared-file-systems/drivers/dell-emc-unity-driver.rst@316","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"5fe111308edb9a9f8c16ce6ef0349793c36d2951","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    .. code-block:: console"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        $ openstack network create \u003cnetwork_name\u003e --provider-network-type \u003cnetwork_type\u003e"},{"line_number":336,"context_line":"        $ openstack subnet create \u003csubnet_name\u003e --network \u003cnetwork_name\u003e --subnet-range \u003csubnet_range\u003e"},{"line_number":337,"context_line":"        $ openstack port create --network \u003cnetwork_name\u003e --fixed-ip subnet\u003d\u003csubnet_name\u003e,ip-address\u003d\u003cip address\u003e \\"},{"line_number":338,"context_line":"          \u003cport_name\u003e --device-owner\u003dmanila:share"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1fa4df85_71c176e4","line":335,"in_reply_to":"1fa4df85_66769ea7","updated":"2020-03-03 08:12:44.000000000","message":"Done","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"320396e59db41fa8a260f87e638115e70b5a8fe7","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        $ manila share-network-create --name \u003cshare_network_name\u003e --neutron-net-id \u003cnetwork_name\u003e \\"},{"line_number":340,"context_line":"          --neutron-subnet-id \u003csubnet_name\u003e"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"#. Manage the share server in OpenStack, \u0027\u003cidentifier\u003e\u0027 is the nas server name"},{"line_number":343,"context_line":"   in Unity system:"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    .. code-block:: console"},{"line_number":346,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"1fa4df85_c65e7211","line":343,"range":{"start_line":342,"start_character":41,"end_line":343,"end_character":19},"updated":"2020-02-28 02:43:09.000000000","message":"this and the other below similar ocurrences, may be added as a note after the command example, or you can break the line and let this identifier below this \"Manage share server in OpenStack\". What do you think about it? If you have any other suggestion, we can take a look on it as well :)","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"5fe111308edb9a9f8c16ce6ef0349793c36d2951","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        $ manila share-network-create --name \u003cshare_network_name\u003e --neutron-net-id \u003cnetwork_name\u003e \\"},{"line_number":340,"context_line":"          --neutron-subnet-id \u003csubnet_name\u003e"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"#. Manage the share server in OpenStack, \u0027\u003cidentifier\u003e\u0027 is the nas server name"},{"line_number":343,"context_line":"   in Unity system:"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    .. code-block:: console"},{"line_number":346,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"1fa4df85_8c1c196b","line":343,"range":{"start_line":342,"start_character":41,"end_line":343,"end_character":19},"in_reply_to":"1fa4df85_c65e7211","updated":"2020-03-03 08:12:44.000000000","message":"Done","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1ec404b76fc6a1f939c2821b096f9c6ebf43fc87","unresolved":false,"context_lines":[{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    $ manila create nfs 1 --name ${target_share_name} --metadata source\u003dsnapshot --description \" \" --snapshot-id ${source_snapshot_id}"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"Supported manage share server"},{"line_number":326,"context_line":"-----------------------------"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"To manage a share server existing in Unity System, you need to:"}],"source_content_type":"text/x-rst","patch_set":12,"id":"df33271e_f3a16597","line":325,"range":{"start_line":325,"start_character":0,"end_line":325,"end_character":29},"updated":"2020-04-07 22:56:14.000000000","message":"nit: \"To manage an existing share server\" perhaps","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"714c02767a74e5041460d589c4ea52308bb58ddd","unresolved":false,"context_lines":[{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    $ manila create nfs 1 --name ${target_share_name} --metadata source\u003dsnapshot --description \" \" --snapshot-id ${source_snapshot_id}"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"Supported manage share server"},{"line_number":326,"context_line":"-----------------------------"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"To manage a share server existing in Unity System, you need to:"}],"source_content_type":"text/x-rst","patch_set":12,"id":"df33271e_2f63511c","line":325,"range":{"start_line":325,"start_character":0,"end_line":325,"end_character":29},"in_reply_to":"df33271e_f3a16597","updated":"2020-04-08 09:35:48.000000000","message":"Done","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1ec404b76fc6a1f939c2821b096f9c6ebf43fc87","unresolved":false,"context_lines":[{"line_number":349,"context_line":""},{"line_number":350,"context_line":"        \u0027${identifier}\u0027 is the nas server name in Unity system."},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"Supported unmanage share server"},{"line_number":353,"context_line":"-------------------------------"},{"line_number":354,"context_line":"To unmanage a snapshot existing in OpenStack:"},{"line_number":355,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df33271e_93b459d3","line":352,"range":{"start_line":352,"start_character":0,"end_line":352,"end_character":31},"updated":"2020-04-07 22:56:14.000000000","message":"nit: \"To un-manage a Manila share server\" perhaps","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"714c02767a74e5041460d589c4ea52308bb58ddd","unresolved":false,"context_lines":[{"line_number":349,"context_line":""},{"line_number":350,"context_line":"        \u0027${identifier}\u0027 is the nas server name in Unity system."},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"Supported unmanage share server"},{"line_number":353,"context_line":"-------------------------------"},{"line_number":354,"context_line":"To unmanage a snapshot existing in OpenStack:"},{"line_number":355,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df33271e_0f664d2a","line":352,"range":{"start_line":352,"start_character":0,"end_line":352,"end_character":31},"in_reply_to":"df33271e_93b459d3","updated":"2020-04-08 09:35:48.000000000","message":"Done","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1ec404b76fc6a1f939c2821b096f9c6ebf43fc87","unresolved":false,"context_lines":[{"line_number":351,"context_line":""},{"line_number":352,"context_line":"Supported unmanage share server"},{"line_number":353,"context_line":"-------------------------------"},{"line_number":354,"context_line":"To unmanage a snapshot existing in OpenStack:"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"    .. code-block:: console"},{"line_number":357,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df33271e_f3ca054d","line":354,"range":{"start_line":354,"start_character":14,"end_line":354,"end_character":22},"updated":"2020-04-07 22:56:14.000000000","message":"share server","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"714c02767a74e5041460d589c4ea52308bb58ddd","unresolved":false,"context_lines":[{"line_number":351,"context_line":""},{"line_number":352,"context_line":"Supported unmanage share server"},{"line_number":353,"context_line":"-------------------------------"},{"line_number":354,"context_line":"To unmanage a snapshot existing in OpenStack:"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"    .. code-block:: console"},{"line_number":357,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df33271e_6f6d5903","line":354,"range":{"start_line":354,"start_character":14,"end_line":354,"end_character":22},"in_reply_to":"df33271e_f3ca054d","updated":"2020-04-08 09:35:48.000000000","message":"Done","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1ec404b76fc6a1f939c2821b096f9c6ebf43fc87","unresolved":false,"context_lines":[{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        $ manila share-server-unmanage ${share_server_id}"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"Supported manage share"},{"line_number":361,"context_line":"----------------------"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"To manage a share existing in Unity System:"}],"source_content_type":"text/x-rst","patch_set":12,"id":"df33271e_d3c5413f","line":360,"range":{"start_line":360,"start_character":0,"end_line":360,"end_character":22},"updated":"2020-04-07 22:56:14.000000000","message":"nit: \"To manage an existing share\" perhaps","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"714c02767a74e5041460d589c4ea52308bb58ddd","unresolved":false,"context_lines":[{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        $ manila share-server-unmanage ${share_server_id}"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"Supported manage share"},{"line_number":361,"context_line":"----------------------"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"To manage a share existing in Unity System:"}],"source_content_type":"text/x-rst","patch_set":12,"id":"df33271e_af7641d7","line":360,"range":{"start_line":360,"start_character":0,"end_line":360,"end_character":22},"in_reply_to":"df33271e_d3c5413f","updated":"2020-04-08 09:35:48.000000000","message":"Done","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1ec404b76fc6a1f939c2821b096f9c6ebf43fc87","unresolved":false,"context_lines":[{"line_number":376,"context_line":"    .. note::"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"        \u0027${share_server_id}\u0027 is the id of share server in OpenStack."},{"line_number":379,"context_line":"        \u0027${share_type}\u0027 should have the property \u0027DHSS\u003dTrue\u0027."},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"- In DHSS\u003dFalse mode"},{"line_number":382,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df33271e_b3e6bde7","line":379,"range":{"start_line":379,"start_character":50,"end_line":379,"end_character":54},"updated":"2020-04-07 22:56:14.000000000","message":"driver_handles_share_servers","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"714c02767a74e5041460d589c4ea52308bb58ddd","unresolved":false,"context_lines":[{"line_number":376,"context_line":"    .. note::"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"        \u0027${share_server_id}\u0027 is the id of share server in OpenStack."},{"line_number":379,"context_line":"        \u0027${share_type}\u0027 should have the property \u0027DHSS\u003dTrue\u0027."},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"- In DHSS\u003dFalse mode"},{"line_number":382,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df33271e_ef80498e","line":379,"range":{"start_line":379,"start_character":50,"end_line":379,"end_character":54},"in_reply_to":"df33271e_b3e6bde7","updated":"2020-04-08 09:35:48.000000000","message":"Done","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1ec404b76fc6a1f939c2821b096f9c6ebf43fc87","unresolved":false,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    .. note::"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"        \u0027${share_type}\u0027 should have the property \u0027DHSS\u003dFalse\u0027."},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"Supported unmanage share"},{"line_number":393,"context_line":"------------------------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"df33271e_93e9f9b8","line":390,"range":{"start_line":390,"start_character":50,"end_line":390,"end_character":54},"updated":"2020-04-07 22:56:14.000000000","message":"driver_handles_share_servers","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"714c02767a74e5041460d589c4ea52308bb58ddd","unresolved":false,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    .. note::"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"        \u0027${share_type}\u0027 should have the property \u0027DHSS\u003dFalse\u0027."},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"Supported unmanage share"},{"line_number":393,"context_line":"------------------------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"df33271e_2f4cf19c","line":390,"range":{"start_line":390,"start_character":50,"end_line":390,"end_character":54},"in_reply_to":"df33271e_93e9f9b8","updated":"2020-04-08 09:35:48.000000000","message":"Done","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1ec404b76fc6a1f939c2821b096f9c6ebf43fc87","unresolved":false,"context_lines":[{"line_number":389,"context_line":""},{"line_number":390,"context_line":"        \u0027${share_type}\u0027 should have the property \u0027DHSS\u003dFalse\u0027."},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"Supported unmanage share"},{"line_number":393,"context_line":"------------------------"},{"line_number":394,"context_line":"To unmanage a share existing in OpenStack:"},{"line_number":395,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df33271e_53081190","line":392,"range":{"start_line":392,"start_character":0,"end_line":392,"end_character":24},"updated":"2020-04-07 22:56:14.000000000","message":"nit: \"To un-manage a Manila share\" perhaps","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"714c02767a74e5041460d589c4ea52308bb58ddd","unresolved":false,"context_lines":[{"line_number":389,"context_line":""},{"line_number":390,"context_line":"        \u0027${share_type}\u0027 should have the property \u0027DHSS\u003dFalse\u0027."},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"Supported unmanage share"},{"line_number":393,"context_line":"------------------------"},{"line_number":394,"context_line":"To unmanage a share existing in OpenStack:"},{"line_number":395,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df33271e_6f46f97e","line":392,"range":{"start_line":392,"start_character":0,"end_line":392,"end_character":24},"in_reply_to":"df33271e_53081190","updated":"2020-04-08 09:35:48.000000000","message":"Done","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1ec404b76fc6a1f939c2821b096f9c6ebf43fc87","unresolved":false,"context_lines":[{"line_number":397,"context_line":""},{"line_number":398,"context_line":"        $ manila unmanage ${share_id}"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"Supported manage snapshot"},{"line_number":401,"context_line":"-------------------------"},{"line_number":402,"context_line":"To manage a snapshot existing in Unity System, you need make sure the related"},{"line_number":403,"context_line":"share instance is existing in OpenStack, otherwise need to manage share first"}],"source_content_type":"text/x-rst","patch_set":12,"id":"df33271e_9302996e","line":400,"range":{"start_line":400,"start_character":0,"end_line":400,"end_character":25},"updated":"2020-04-07 22:56:14.000000000","message":"nit: \"To manage an existing share snapshot\" perhaps","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"714c02767a74e5041460d589c4ea52308bb58ddd","unresolved":false,"context_lines":[{"line_number":397,"context_line":""},{"line_number":398,"context_line":"        $ manila unmanage ${share_id}"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"Supported manage snapshot"},{"line_number":401,"context_line":"-------------------------"},{"line_number":402,"context_line":"To manage a snapshot existing in Unity System, you need make sure the related"},{"line_number":403,"context_line":"share instance is existing in OpenStack, otherwise need to manage share first"}],"source_content_type":"text/x-rst","patch_set":12,"id":"df33271e_8f5a5d4d","line":400,"range":{"start_line":400,"start_character":0,"end_line":400,"end_character":25},"in_reply_to":"df33271e_9302996e","updated":"2020-04-08 09:35:48.000000000","message":"Done","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1ec404b76fc6a1f939c2821b096f9c6ebf43fc87","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        \u0027${provider_location}\u0027 is the snapshot name in Unity system."},{"line_number":413,"context_line":"        \u0027${share_name}\u0027 is the share name or id in OpenStack."},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"Supported unmanage snapshot"},{"line_number":416,"context_line":"---------------------------"},{"line_number":417,"context_line":"To unmanage a snapshot existing in OpenStack:"},{"line_number":418,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df33271e_532db1fb","line":415,"range":{"start_line":415,"start_character":0,"end_line":415,"end_character":27},"updated":"2020-04-07 22:56:14.000000000","message":"nit: \"To un-manage a Manila share snapshot\" perhaps","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"714c02767a74e5041460d589c4ea52308bb58ddd","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        \u0027${provider_location}\u0027 is the snapshot name in Unity system."},{"line_number":413,"context_line":"        \u0027${share_name}\u0027 is the share name or id in OpenStack."},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"Supported unmanage snapshot"},{"line_number":416,"context_line":"---------------------------"},{"line_number":417,"context_line":"To unmanage a snapshot existing in OpenStack:"},{"line_number":418,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df33271e_ef59695a","line":415,"range":{"start_line":415,"start_character":0,"end_line":415,"end_character":27},"in_reply_to":"df33271e_532db1fb","updated":"2020-04-08 09:35:48.000000000","message":"Done","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"}],"manila/share/drivers/dell_emc/driver.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a94fbcfb81c885a680af597ac3b332d173f699a8","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            self.manage_existing_support \u003d False"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        if hasattr(self.plugin, \u0027manage_existing_with_server_support\u0027):"},{"line_number":109,"context_line":"            self.manage_existing_with_server_support \u003d \\"},{"line_number":110,"context_line":"                self.plugin.manage_existing_with_server_support"},{"line_number":111,"context_line":"        else:"},{"line_number":112,"context_line":"            self.manage_existing_with_server_support \u003d False"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_727f4866","line":109,"range":{"start_line":109,"start_character":55,"end_line":109,"end_character":56},"updated":"2019-10-22 20:41:23.000000000","message":"The use of parenthesis instead of backslash is a preferred way of breaking long line [1]\n\n[1] https://www.python.org/dev/peps/pep-0008/#maximum-line-length\n\n* Same for all backslashes below","commit_id":"b2c62cc01d9fce246a06d5d2901c984a20bd8447"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1ec404b76fc6a1f939c2821b096f9c6ebf43fc87","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                context, share_server, identifier, driver_options)"},{"line_number":183,"context_line":"            if containing_ips and len(containing_ips) \u003e 1:"},{"line_number":184,"context_line":"                # the share network cannot be created with multiple subnets"},{"line_number":185,"context_line":"                LOG.warning(\u0027Do not support share server with multiple \u0027"},{"line_number":186,"context_line":"                            \u0027interfaces.\u0027)"},{"line_number":187,"context_line":"            return containing_ips"},{"line_number":188,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":12,"id":"df33271e_9310d9aa","line":185,"range":{"start_line":185,"start_character":20,"end_line":185,"end_character":27},"updated":"2020-04-07 22:56:14.000000000","message":"error?\n\nSo, what really happens in this case?","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"714c02767a74e5041460d589c4ea52308bb58ddd","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                context, share_server, identifier, driver_options)"},{"line_number":183,"context_line":"            if containing_ips and len(containing_ips) \u003e 1:"},{"line_number":184,"context_line":"                # the share network cannot be created with multiple subnets"},{"line_number":185,"context_line":"                LOG.warning(\u0027Do not support share server with multiple \u0027"},{"line_number":186,"context_line":"                            \u0027interfaces.\u0027)"},{"line_number":187,"context_line":"            return containing_ips"},{"line_number":188,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":12,"id":"df33271e_ca457345","line":185,"range":{"start_line":185,"start_character":20,"end_line":185,"end_character":27},"in_reply_to":"df33271e_9310d9aa","updated":"2020-04-08 09:35:48.000000000","message":"Changed, just return the IPs returned by plugin.","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"}],"manila/share/drivers/dell_emc/plugins/unity/connection.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a94fbcfb81c885a680af597ac3b332d173f699a8","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            self.extend_share(share, share_size)"},{"line_number":244,"context_line":"        if new_size \u003c old_size:"},{"line_number":245,"context_line":"            self.shrink_share(share, share_size)"},{"line_number":246,"context_line":"        return {\"size\": share_size}"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def manage_existing_with_server(self, share, driver_options, share_server):"},{"line_number":249,"context_line":"        return self.manage_existing(share, driver_options, share_server)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_e15284de","line":246,"range":{"start_line":246,"start_character":8,"end_line":246,"end_character":34},"updated":"2019-10-22 20:41:23.000000000","message":"what about the export_locations?","commit_id":"b2c62cc01d9fce246a06d5d2901c984a20bd8447"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6716fc1f612e1ccd57371dc6435fc6d74562ab12","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            self.extend_share(share, share_size)"},{"line_number":244,"context_line":"        if new_size \u003c old_size:"},{"line_number":245,"context_line":"            self.shrink_share(share, share_size)"},{"line_number":246,"context_line":"        return {\"size\": share_size}"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def manage_existing_with_server(self, share, driver_options, share_server):"},{"line_number":249,"context_line":"        return self.manage_existing(share, driver_options, share_server)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_5758d754","line":246,"range":{"start_line":246,"start_character":8,"end_line":246,"end_character":34},"in_reply_to":"3fa7e38b_2c0c1041","updated":"2019-10-24 12:37:54.000000000","message":"OK, asked because the method documentation says that returns both.","commit_id":"b2c62cc01d9fce246a06d5d2901c984a20bd8447"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"9c79a808f03bf5ccea2f30d404b8678af36b5afa","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            self.extend_share(share, share_size)"},{"line_number":244,"context_line":"        if new_size \u003c old_size:"},{"line_number":245,"context_line":"            self.shrink_share(share, share_size)"},{"line_number":246,"context_line":"        return {\"size\": share_size}"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def manage_existing_with_server(self, share, driver_options, share_server):"},{"line_number":249,"context_line":"        return self.manage_existing(share, driver_options, share_server)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_76b8ce74","line":246,"range":{"start_line":246,"start_character":8,"end_line":246,"end_character":34},"in_reply_to":"3fa7e38b_5758d754","updated":"2019-11-27 02:56:13.000000000","message":"fixed, return the export location with original path value.","commit_id":"b2c62cc01d9fce246a06d5d2901c984a20bd8447"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"9c79a808f03bf5ccea2f30d404b8678af36b5afa","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            self.extend_share(share, share_size)"},{"line_number":244,"context_line":"        if new_size \u003c old_size:"},{"line_number":245,"context_line":"            self.shrink_share(share, share_size)"},{"line_number":246,"context_line":"        return {\"size\": share_size}"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def manage_existing_with_server(self, share, driver_options, share_server):"},{"line_number":249,"context_line":"        return self.manage_existing(share, driver_options, share_server)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_56b3529b","line":246,"range":{"start_line":246,"start_character":8,"end_line":246,"end_character":34},"in_reply_to":"3fa7e38b_e15284de","updated":"2019-11-27 02:56:13.000000000","message":"Done","commit_id":"b2c62cc01d9fce246a06d5d2901c984a20bd8447"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"93cfdea0ef743b857500db54316294c1ecc5262f","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            self.extend_share(share, share_size)"},{"line_number":244,"context_line":"        if new_size \u003c old_size:"},{"line_number":245,"context_line":"            self.shrink_share(share, share_size)"},{"line_number":246,"context_line":"        return {\"size\": share_size}"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def manage_existing_with_server(self, share, driver_options, share_server):"},{"line_number":249,"context_line":"        return self.manage_existing(share, driver_options, share_server)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_2c0c1041","line":246,"range":{"start_line":246,"start_character":8,"end_line":246,"end_character":34},"in_reply_to":"3fa7e38b_e15284de","updated":"2019-10-23 02:58:01.000000000","message":"The export_locations will be update by framework with the\noriginal values provided in share manage command.\nBecause we cannot rename the share id/path in driver side (Unity does not support this).\nSo, did not return the new generate share id here. Means nothing changed in old export_locations.\n\nSo in the future, driver will try to parse share_backend_id from export path in case it\u0027s managed share.","commit_id":"b2c62cc01d9fce246a06d5d2901c984a20bd8447"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a94fbcfb81c885a680af597ac3b332d173f699a8","unresolved":false,"context_lines":[{"line_number":281,"context_line":"                 \"with ID %(snapshot_id)s.\","},{"line_number":282,"context_line":"                 {\u0027provider_location\u0027: snapshot.get(\u0027provider_location\u0027),"},{"line_number":283,"context_line":"                  \u0027snapshot_id\u0027: snapshot[\u0027id\u0027]})"},{"line_number":284,"context_line":"        return {\"size\": snapshot_size, \"provider_location\": provider_location}"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def manage_existing_snapshot_with_server(self, snapshot, driver_options,"},{"line_number":287,"context_line":"                                             share_server):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_a1d1ec31","line":284,"range":{"start_line":284,"start_character":24,"end_line":284,"end_character":37},"updated":"2019-10-22 20:41:23.000000000","message":"Is this the real size of the snapshot? It will be the value provided in driver-options or the default value(1).","commit_id":"b2c62cc01d9fce246a06d5d2901c984a20bd8447"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"93cfdea0ef743b857500db54316294c1ecc5262f","unresolved":false,"context_lines":[{"line_number":281,"context_line":"                 \"with ID %(snapshot_id)s.\","},{"line_number":282,"context_line":"                 {\u0027provider_location\u0027: snapshot.get(\u0027provider_location\u0027),"},{"line_number":283,"context_line":"                  \u0027snapshot_id\u0027: snapshot[\u0027id\u0027]})"},{"line_number":284,"context_line":"        return {\"size\": snapshot_size, \"provider_location\": provider_location}"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def manage_existing_snapshot_with_server(self, snapshot, driver_options,"},{"line_number":287,"context_line":"                                             share_server):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_cc63fc40","line":284,"range":{"start_line":284,"start_character":24,"end_line":284,"end_character":37},"in_reply_to":"3fa7e38b_a1d1ec31","updated":"2019-10-23 02:58:01.000000000","message":"No, it\u0027s the value provided in driver-options.\nShare size will be overwrite by the share creation command if customer creates share from snapshot","commit_id":"b2c62cc01d9fce246a06d5d2901c984a20bd8447"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"320396e59db41fa8a260f87e638115e70b5a8fe7","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        :returns: Returns a dict with share size and export location."},{"line_number":197,"context_line":"        \"\"\""},{"line_number":198,"context_line":"        export_locations \u003d share[\u0027export_locations\u0027]"},{"line_number":199,"context_line":"        if not export_locations:"},{"line_number":200,"context_line":"            message \u003d (\"Failed to manage existing share: %s, missing \""},{"line_number":201,"context_line":"                       \"export locations\", share[\u0027id\u0027])"},{"line_number":202,"context_line":"            raise exception.BadConfigurationException(message)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_430cb43a","line":199,"range":{"start_line":199,"start_character":8,"end_line":199,"end_character":32},"updated":"2020-02-28 02:43:09.000000000","message":"is it possible to have a share without export locations at this point?","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"5fe111308edb9a9f8c16ce6ef0349793c36d2951","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        :returns: Returns a dict with share size and export location."},{"line_number":197,"context_line":"        \"\"\""},{"line_number":198,"context_line":"        export_locations \u003d share[\u0027export_locations\u0027]"},{"line_number":199,"context_line":"        if not export_locations:"},{"line_number":200,"context_line":"            message \u003d (\"Failed to manage existing share: %s, missing \""},{"line_number":201,"context_line":"                       \"export locations\", share[\u0027id\u0027])"},{"line_number":202,"context_line":"            raise exception.BadConfigurationException(message)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_ec5a6d4e","line":199,"range":{"start_line":199,"start_character":8,"end_line":199,"end_character":32},"in_reply_to":"1fa4df85_430cb43a","updated":"2020-03-03 08:12:44.000000000","message":"I think the framework already handled such situation.\nI just copied part of logic from other vendors for ref.","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"320396e59db41fa8a260f87e638115e70b5a8fe7","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        export_locations \u003d share[\u0027export_locations\u0027]"},{"line_number":199,"context_line":"        if not export_locations:"},{"line_number":200,"context_line":"            message \u003d (\"Failed to manage existing share: %s, missing \""},{"line_number":201,"context_line":"                       \"export locations\", share[\u0027id\u0027])"},{"line_number":202,"context_line":"            raise exception.BadConfigurationException(message)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_e3128058","line":201,"updated":"2020-02-28 02:43:09.000000000","message":"nit: please, add a period.","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"5fe111308edb9a9f8c16ce6ef0349793c36d2951","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        export_locations \u003d share[\u0027export_locations\u0027]"},{"line_number":199,"context_line":"        if not export_locations:"},{"line_number":200,"context_line":"            message \u003d (\"Failed to manage existing share: %s, missing \""},{"line_number":201,"context_line":"                       \"export locations\", share[\u0027id\u0027])"},{"line_number":202,"context_line":"            raise exception.BadConfigurationException(message)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_ac547522","line":201,"in_reply_to":"1fa4df85_e3128058","updated":"2020-03-03 08:12:44.000000000","message":"Done","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"320396e59db41fa8a260f87e638115e70b5a8fe7","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        try:"},{"line_number":205,"context_line":"            share_size \u003d int(driver_options.get(\"size\", 0))"},{"line_number":206,"context_line":"        except (ValueError, TypeError):"},{"line_number":207,"context_line":"            msg \u003d _(\"The size in driver options to manage share \""},{"line_number":208,"context_line":"                    \"%(share_id) should be an integer, in format \""},{"line_number":209,"context_line":"                    \"driver-options size\u003d\u003cSIZE\u003e. Value passed: \""},{"line_number":210,"context_line":"                    \"%(size)s.\") % {\u0027share_id\u0027: share[\u0027id\u0027],"},{"line_number":211,"context_line":"                                    \u0027size\u0027: driver_options.get(\"size\")}"}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_e00d963e","line":208,"range":{"start_line":207,"start_character":21,"end_line":208,"end_character":53},"updated":"2020-02-28 02:43:09.000000000","message":"The driver options\u0027 size to manage the share %(share_id)s, should be an integer\nI\u0027ve found some more occurences like this below...","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"5fe111308edb9a9f8c16ce6ef0349793c36d2951","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        try:"},{"line_number":205,"context_line":"            share_size \u003d int(driver_options.get(\"size\", 0))"},{"line_number":206,"context_line":"        except (ValueError, TypeError):"},{"line_number":207,"context_line":"            msg \u003d _(\"The size in driver options to manage share \""},{"line_number":208,"context_line":"                    \"%(share_id) should be an integer, in format \""},{"line_number":209,"context_line":"                    \"driver-options size\u003d\u003cSIZE\u003e. Value passed: \""},{"line_number":210,"context_line":"                    \"%(size)s.\") % {\u0027share_id\u0027: share[\u0027id\u0027],"},{"line_number":211,"context_line":"                                    \u0027size\u0027: driver_options.get(\"size\")}"}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_d74a9a25","line":208,"range":{"start_line":207,"start_character":21,"end_line":208,"end_character":53},"in_reply_to":"1fa4df85_e00d963e","updated":"2020-03-03 08:12:44.000000000","message":"Done","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"320396e59db41fa8a260f87e638115e70b5a8fe7","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        except (ValueError, TypeError):"},{"line_number":207,"context_line":"            msg \u003d _(\"The size in driver options to manage share \""},{"line_number":208,"context_line":"                    \"%(share_id) should be an integer, in format \""},{"line_number":209,"context_line":"                    \"driver-options size\u003d\u003cSIZE\u003e. Value passed: \""},{"line_number":210,"context_line":"                    \"%(size)s.\") % {\u0027share_id\u0027: share[\u0027id\u0027],"},{"line_number":211,"context_line":"                                    \u0027size\u0027: driver_options.get(\"size\")}"},{"line_number":212,"context_line":"            raise exception.ManageInvalidShare(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_a0079e1c","line":209,"range":{"start_line":209,"start_character":55,"end_line":209,"end_character":61},"updated":"2020-02-28 02:43:09.000000000","message":"maybe: specified","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"5fe111308edb9a9f8c16ce6ef0349793c36d2951","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        except (ValueError, TypeError):"},{"line_number":207,"context_line":"            msg \u003d _(\"The size in driver options to manage share \""},{"line_number":208,"context_line":"                    \"%(share_id) should be an integer, in format \""},{"line_number":209,"context_line":"                    \"driver-options size\u003d\u003cSIZE\u003e. Value passed: \""},{"line_number":210,"context_line":"                    \"%(size)s.\") % {\u0027share_id\u0027: share[\u0027id\u0027],"},{"line_number":211,"context_line":"                                    \u0027size\u0027: driver_options.get(\"size\")}"},{"line_number":212,"context_line":"            raise exception.ManageInvalidShare(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_f76eb694","line":209,"range":{"start_line":209,"start_character":55,"end_line":209,"end_character":61},"in_reply_to":"1fa4df85_a0079e1c","updated":"2020-03-03 08:12:44.000000000","message":"Done","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"320396e59db41fa8a260f87e638115e70b5a8fe7","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            raise exception.ManageInvalidShare(reason\u003dmsg)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        if not share_size:"},{"line_number":215,"context_line":"            msg \u003d _(\"Share %s has no size specified for manage. \""},{"line_number":216,"context_line":"                    \"Use default value 1, set size in driver options if you \""},{"line_number":217,"context_line":"                    \"want.\") % {\u0027share_id\u0027: share[\u0027id\u0027]}"},{"line_number":218,"context_line":"            LOG.warning(msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_432594aa","line":215,"range":{"start_line":215,"start_character":27,"end_line":215,"end_character":29},"updated":"2020-02-28 02:43:09.000000000","message":"%(share_id)s","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"320396e59db41fa8a260f87e638115e70b5a8fe7","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            raise exception.ManageInvalidShare(reason\u003dmsg)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        if not share_size:"},{"line_number":215,"context_line":"            msg \u003d _(\"Share %s has no size specified for manage. \""},{"line_number":216,"context_line":"                    \"Use default value 1, set size in driver options if you \""},{"line_number":217,"context_line":"                    \"want.\") % {\u0027share_id\u0027: share[\u0027id\u0027]}"},{"line_number":218,"context_line":"            LOG.warning(msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_83506c0c","line":215,"range":{"start_line":215,"start_character":37,"end_line":215,"end_character":62},"updated":"2020-02-28 02:43:09.000000000","message":"maybe: manage specified size?","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"5fe111308edb9a9f8c16ce6ef0349793c36d2951","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            raise exception.ManageInvalidShare(reason\u003dmsg)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        if not share_size:"},{"line_number":215,"context_line":"            msg \u003d _(\"Share %s has no size specified for manage. \""},{"line_number":216,"context_line":"                    \"Use default value 1, set size in driver options if you \""},{"line_number":217,"context_line":"                    \"want.\") % {\u0027share_id\u0027: share[\u0027id\u0027]}"},{"line_number":218,"context_line":"            LOG.warning(msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_b7683e87","line":215,"range":{"start_line":215,"start_character":27,"end_line":215,"end_character":29},"in_reply_to":"1fa4df85_432594aa","updated":"2020-03-03 08:12:44.000000000","message":"Done","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"5fe111308edb9a9f8c16ce6ef0349793c36d2951","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            raise exception.ManageInvalidShare(reason\u003dmsg)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        if not share_size:"},{"line_number":215,"context_line":"            msg \u003d _(\"Share %s has no size specified for manage. \""},{"line_number":216,"context_line":"                    \"Use default value 1, set size in driver options if you \""},{"line_number":217,"context_line":"                    \"want.\") % {\u0027share_id\u0027: share[\u0027id\u0027]}"},{"line_number":218,"context_line":"            LOG.warning(msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_37120e0b","line":215,"range":{"start_line":215,"start_character":37,"end_line":215,"end_character":62},"in_reply_to":"1fa4df85_83506c0c","updated":"2020-03-03 08:12:44.000000000","message":"Done","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"320396e59db41fa8a260f87e638115e70b5a8fe7","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        backend_share \u003d self.client.get_share(share_id,"},{"line_number":223,"context_line":"                                              share[\u0027share_proto\u0027])"},{"line_number":224,"context_line":"        if not backend_share:"},{"line_number":225,"context_line":"            message \u003d (\"Could not find the backend share, please make sure \""},{"line_number":226,"context_line":"                       \"the export location is right.\")"},{"line_number":227,"context_line":"            raise exception.BadConfigurationException(message)"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_83794c94","line":225,"range":{"start_line":225,"start_character":39,"end_line":225,"end_character":56},"updated":"2020-02-28 02:43:09.000000000","message":"the share in the backend","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"320396e59db41fa8a260f87e638115e70b5a8fe7","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        if share_server:"},{"line_number":231,"context_line":"            backend_share_server \u003d self._get_server_name(share_server)"},{"line_number":232,"context_line":"            if not backend_share_server:"},{"line_number":233,"context_line":"                message \u003d (\"Could not find the backend share server: %s, \""},{"line_number":234,"context_line":"                           \"please make sure the share sever name is existing \""},{"line_number":235,"context_line":"                           \"in Unity System.\", share_server)"},{"line_number":236,"context_line":"                raise exception.BadConfigurationException(message)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_437354b2","line":233,"range":{"start_line":233,"start_character":47,"end_line":233,"end_character":67},"updated":"2020-02-28 02:43:09.000000000","message":"share server in the backend","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"5fe111308edb9a9f8c16ce6ef0349793c36d2951","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        if share_server:"},{"line_number":231,"context_line":"            backend_share_server \u003d self._get_server_name(share_server)"},{"line_number":232,"context_line":"            if not backend_share_server:"},{"line_number":233,"context_line":"                message \u003d (\"Could not find the backend share server: %s, \""},{"line_number":234,"context_line":"                           \"please make sure the share sever name is existing \""},{"line_number":235,"context_line":"                           \"in Unity System.\", share_server)"},{"line_number":236,"context_line":"                raise exception.BadConfigurationException(message)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_f7f316e6","line":233,"range":{"start_line":233,"start_character":47,"end_line":233,"end_character":67},"in_reply_to":"1fa4df85_437354b2","updated":"2020-03-03 08:12:44.000000000","message":"Done","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"320396e59db41fa8a260f87e638115e70b5a8fe7","unresolved":false,"context_lines":[{"line_number":231,"context_line":"            backend_share_server \u003d self._get_server_name(share_server)"},{"line_number":232,"context_line":"            if not backend_share_server:"},{"line_number":233,"context_line":"                message \u003d (\"Could not find the backend share server: %s, \""},{"line_number":234,"context_line":"                           \"please make sure the share sever name is existing \""},{"line_number":235,"context_line":"                           \"in Unity System.\", share_server)"},{"line_number":236,"context_line":"                raise exception.BadConfigurationException(message)"},{"line_number":237,"context_line":"        LOG.info(\"Share %(shr_path)s in Unity will be managed with ID \""},{"line_number":238,"context_line":"                 \"%(shr_id)s.\","}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_c35e6411","line":235,"range":{"start_line":234,"start_character":45,"end_line":235,"end_character":43},"updated":"2020-02-28 02:43:09.000000000","message":"that the share server with the specified name exists in the backend.","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"5fe111308edb9a9f8c16ce6ef0349793c36d2951","unresolved":false,"context_lines":[{"line_number":231,"context_line":"            backend_share_server \u003d self._get_server_name(share_server)"},{"line_number":232,"context_line":"            if not backend_share_server:"},{"line_number":233,"context_line":"                message \u003d (\"Could not find the backend share server: %s, \""},{"line_number":234,"context_line":"                           \"please make sure the share sever name is existing \""},{"line_number":235,"context_line":"                           \"in Unity System.\", share_server)"},{"line_number":236,"context_line":"                raise exception.BadConfigurationException(message)"},{"line_number":237,"context_line":"        LOG.info(\"Share %(shr_path)s in Unity will be managed with ID \""},{"line_number":238,"context_line":"                 \"%(shr_id)s.\","}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_572eaa43","line":235,"range":{"start_line":234,"start_character":45,"end_line":235,"end_character":43},"in_reply_to":"1fa4df85_c35e6411","updated":"2020-03-03 08:12:44.000000000","message":"Done","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"320396e59db41fa8a260f87e638115e70b5a8fe7","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                           \"please make sure the share sever name is existing \""},{"line_number":235,"context_line":"                           \"in Unity System.\", share_server)"},{"line_number":236,"context_line":"                raise exception.BadConfigurationException(message)"},{"line_number":237,"context_line":"        LOG.info(\"Share %(shr_path)s in Unity will be managed with ID \""},{"line_number":238,"context_line":"                 \"%(shr_id)s.\","},{"line_number":239,"context_line":"                 {\u0027shr_path\u0027: share[\u0027export_locations\u0027][0][\u0027path\u0027],"},{"line_number":240,"context_line":"                  \u0027shr_id\u0027: share[\u0027id\u0027]})"}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_63e9b018","line":237,"range":{"start_line":237,"start_character":37,"end_line":237,"end_character":53},"updated":"2020-02-28 02:43:09.000000000","message":"is being managed with ID","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"320396e59db41fa8a260f87e638115e70b5a8fe7","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                  \u0027shr_id\u0027: share[\u0027id\u0027]})"},{"line_number":241,"context_line":"        new_size \u003d unity_utils.gib_to_byte(share_size)"},{"line_number":242,"context_line":"        old_size \u003d backend_share.filesystem.size_total"},{"line_number":243,"context_line":"        if new_size \u003e old_size:"},{"line_number":244,"context_line":"            self.extend_share(share, share_size)"},{"line_number":245,"context_line":"        if new_size \u003c old_size:"},{"line_number":246,"context_line":"            self.shrink_share(share, share_size)"},{"line_number":247,"context_line":"        # export_locations was not changed, return original value"},{"line_number":248,"context_line":"        return {\"size\": share_size, \u0027export_locations\u0027: {"},{"line_number":249,"context_line":"            \u0027path\u0027: share[\u0027export_locations\u0027][0][\u0027path\u0027]}}"}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_e34a8025","line":246,"range":{"start_line":243,"start_character":0,"end_line":246,"end_character":48},"updated":"2020-02-28 02:43:09.000000000","message":"Some things to ask about this:\nLet\u0027s suppose the share that is being managed, has as total 10 GB of capacity, and 8 out of 10 GB consumed. If the new value is 7 GB, it is going to cause data loss.\nAnd the user is possibly not expecting to receive a share extend/shrink error to happen during the manage operation.\n\nSo IMHO, this operation should not happen at this point. Something I\u0027d recommend is to make the manage operation happen and then if the user wants to, he is going to be able to extend/shrink the share and he is going to be aware of the error that occurred for each operation.\nAlso, the old_size value may be set to a ceil and then you let manila know what is the limit.","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"5fe111308edb9a9f8c16ce6ef0349793c36d2951","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                  \u0027shr_id\u0027: share[\u0027id\u0027]})"},{"line_number":241,"context_line":"        new_size \u003d unity_utils.gib_to_byte(share_size)"},{"line_number":242,"context_line":"        old_size \u003d backend_share.filesystem.size_total"},{"line_number":243,"context_line":"        if new_size \u003e old_size:"},{"line_number":244,"context_line":"            self.extend_share(share, share_size)"},{"line_number":245,"context_line":"        if new_size \u003c old_size:"},{"line_number":246,"context_line":"            self.shrink_share(share, share_size)"},{"line_number":247,"context_line":"        # export_locations was not changed, return original value"},{"line_number":248,"context_line":"        return {\"size\": share_size, \u0027export_locations\u0027: {"},{"line_number":249,"context_line":"            \u0027path\u0027: share[\u0027export_locations\u0027][0][\u0027path\u0027]}}"}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_37e0cefa","line":246,"range":{"start_line":243,"start_character":0,"end_line":246,"end_character":48},"in_reply_to":"1fa4df85_e34a8025","updated":"2020-03-03 08:12:44.000000000","message":"Done","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"320396e59db41fa8a260f87e638115e70b5a8fe7","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        provider_location \u003d snapshot.get(\u0027provider_location\u0027)"},{"line_number":274,"context_line":"        snap \u003d self.client.get_snapshot(provider_location)"},{"line_number":275,"context_line":"        if not snap:"},{"line_number":276,"context_line":"            message \u003d (\"Could not find the backend snapshot with \""},{"line_number":277,"context_line":"                       \"provider_location: %s, please make sure \""},{"line_number":278,"context_line":"                       \"the snapshot is existing in Unity System.\","},{"line_number":279,"context_line":"                       provider_location)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_83170ca4","line":276,"range":{"start_line":276,"start_character":39,"end_line":276,"end_character":59},"updated":"2020-02-28 02:43:09.000000000","message":"a snapshot in the backend with...","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"320396e59db41fa8a260f87e638115e70b5a8fe7","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        if not snap:"},{"line_number":276,"context_line":"            message \u003d (\"Could not find the backend snapshot with \""},{"line_number":277,"context_line":"                       \"provider_location: %s, please make sure \""},{"line_number":278,"context_line":"                       \"the snapshot is existing in Unity System.\","},{"line_number":279,"context_line":"                       provider_location)"},{"line_number":280,"context_line":"            raise exception.BadConfigurationException(message)"},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_431114ac","line":278,"range":{"start_line":278,"start_character":37,"end_line":278,"end_character":64},"updated":"2020-02-28 02:43:09.000000000","message":"maybe: exists in the backend","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1ec404b76fc6a1f939c2821b096f9c6ebf43fc87","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        if not export_locations:"},{"line_number":200,"context_line":"            message \u003d (\"Failed to manage existing share: %s, missing \""},{"line_number":201,"context_line":"                       \"export locations.\", share[\u0027id\u0027])"},{"line_number":202,"context_line":"            raise exception.BadConfigurationException(message)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        try:"},{"line_number":205,"context_line":"            share_size \u003d int(driver_options.get(\"size\", 0))"}],"source_content_type":"text/x-python","patch_set":12,"id":"df33271e_537bf1f2","line":202,"range":{"start_line":202,"start_character":28,"end_line":202,"end_character":53},"updated":"2020-04-07 22:56:14.000000000","message":"ManageInvalidShare; this isn\u0027t configuration...","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"714c02767a74e5041460d589c4ea52308bb58ddd","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        if not export_locations:"},{"line_number":200,"context_line":"            message \u003d (\"Failed to manage existing share: %s, missing \""},{"line_number":201,"context_line":"                       \"export locations.\", share[\u0027id\u0027])"},{"line_number":202,"context_line":"            raise exception.BadConfigurationException(message)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        try:"},{"line_number":205,"context_line":"            share_size \u003d int(driver_options.get(\"size\", 0))"}],"source_content_type":"text/x-python","patch_set":12,"id":"df33271e_4f3e95da","line":202,"range":{"start_line":202,"start_character":28,"end_line":202,"end_character":53},"in_reply_to":"df33271e_537bf1f2","updated":"2020-04-08 09:35:48.000000000","message":"Done","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1ec404b76fc6a1f939c2821b096f9c6ebf43fc87","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            raise exception.ManageInvalidShare(reason\u003dmsg)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        if not share_size:"},{"line_number":215,"context_line":"            msg \u003d _(\"Share %(share_id)s has no managed specified size. \""},{"line_number":216,"context_line":"                    \"Use default value 1, set size in driver options if you \""},{"line_number":217,"context_line":"                    \"want.\") % {\u0027share_id\u0027: share[\u0027id\u0027]}"},{"line_number":218,"context_line":"            LOG.warning(msg)"}],"source_content_type":"text/x-python","patch_set":12,"id":"df33271e_f36b251c","line":215,"range":{"start_line":215,"start_character":47,"end_line":215,"end_character":54},"updated":"2020-04-07 22:56:14.000000000","message":"nit: remove word","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"714c02767a74e5041460d589c4ea52308bb58ddd","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            raise exception.ManageInvalidShare(reason\u003dmsg)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        if not share_size:"},{"line_number":215,"context_line":"            msg \u003d _(\"Share %(share_id)s has no managed specified size. \""},{"line_number":216,"context_line":"                    \"Use default value 1, set size in driver options if you \""},{"line_number":217,"context_line":"                    \"want.\") % {\u0027share_id\u0027: share[\u0027id\u0027]}"},{"line_number":218,"context_line":"            LOG.warning(msg)"}],"source_content_type":"text/x-python","patch_set":12,"id":"df33271e_2f31910c","line":215,"range":{"start_line":215,"start_character":47,"end_line":215,"end_character":54},"in_reply_to":"df33271e_f36b251c","updated":"2020-04-08 09:35:48.000000000","message":"Done","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1ec404b76fc6a1f939c2821b096f9c6ebf43fc87","unresolved":false,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        if not share_size:"},{"line_number":215,"context_line":"            msg \u003d _(\"Share %(share_id)s has no managed specified size. \""},{"line_number":216,"context_line":"                    \"Use default value 1, set size in driver options if you \""},{"line_number":217,"context_line":"                    \"want.\") % {\u0027share_id\u0027: share[\u0027id\u0027]}"},{"line_number":218,"context_line":"            LOG.warning(msg)"},{"line_number":219,"context_line":"            share_size \u003d 1"}],"source_content_type":"text/x-python","patch_set":12,"id":"df33271e_d366e155","line":216,"range":{"start_line":216,"start_character":21,"end_line":216,"end_character":24},"updated":"2020-04-07 22:56:14.000000000","message":"nit: Using","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"714c02767a74e5041460d589c4ea52308bb58ddd","unresolved":false,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        if not share_size:"},{"line_number":215,"context_line":"            msg \u003d _(\"Share %(share_id)s has no managed specified size. \""},{"line_number":216,"context_line":"                    \"Use default value 1, set size in driver options if you \""},{"line_number":217,"context_line":"                    \"want.\") % {\u0027share_id\u0027: share[\u0027id\u0027]}"},{"line_number":218,"context_line":"            LOG.warning(msg)"},{"line_number":219,"context_line":"            share_size \u003d 1"}],"source_content_type":"text/x-python","patch_set":12,"id":"df33271e_6f3b99ea","line":216,"range":{"start_line":216,"start_character":21,"end_line":216,"end_character":24},"in_reply_to":"df33271e_d366e155","updated":"2020-04-08 09:35:48.000000000","message":"Done","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1ec404b76fc6a1f939c2821b096f9c6ebf43fc87","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        if not backend_share:"},{"line_number":225,"context_line":"            message \u003d (\"Could not find the share in backend, please make sure \""},{"line_number":226,"context_line":"                       \"the export location is right.\")"},{"line_number":227,"context_line":"            raise exception.BadConfigurationException(message)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        # Check the share server when in DHSS\u003dtrue mode"},{"line_number":230,"context_line":"        if share_server:"}],"source_content_type":"text/x-python","patch_set":12,"id":"df33271e_1371690d","line":227,"range":{"start_line":227,"start_character":28,"end_line":227,"end_character":53},"updated":"2020-04-07 22:56:14.000000000","message":"ManageInvalidShare\n\nThis isn\u0027t a configuration issue.","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"714c02767a74e5041460d589c4ea52308bb58ddd","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        if not backend_share:"},{"line_number":225,"context_line":"            message \u003d (\"Could not find the share in backend, please make sure \""},{"line_number":226,"context_line":"                       \"the export location is right.\")"},{"line_number":227,"context_line":"            raise exception.BadConfigurationException(message)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        # Check the share server when in DHSS\u003dtrue mode"},{"line_number":230,"context_line":"        if share_server:"}],"source_content_type":"text/x-python","patch_set":12,"id":"df33271e_af2481c7","line":227,"range":{"start_line":227,"start_character":28,"end_line":227,"end_character":53},"in_reply_to":"df33271e_1371690d","updated":"2020-04-08 09:35:48.000000000","message":"Done","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1ec404b76fc6a1f939c2821b096f9c6ebf43fc87","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            raise exception.ManageInvalidShareSnapshot(reason\u003dmsg)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        if not snapshot_size:"},{"line_number":263,"context_line":"            msg \u003d _(\"Snapshot %(snap_id)s has no managed specified size. \""},{"line_number":264,"context_line":"                    \"Use default value 1, set size in driver options if you \""},{"line_number":265,"context_line":"                    \"want.\") % {\u0027snap_id\u0027: snapshot[\u0027id\u0027]}"},{"line_number":266,"context_line":"            LOG.info(msg)"}],"source_content_type":"text/x-python","patch_set":12,"id":"df33271e_93d3b9d5","line":263,"range":{"start_line":263,"start_character":49,"end_line":263,"end_character":56},"updated":"2020-04-07 22:56:14.000000000","message":"not: remove word","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"714c02767a74e5041460d589c4ea52308bb58ddd","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            raise exception.ManageInvalidShareSnapshot(reason\u003dmsg)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        if not snapshot_size:"},{"line_number":263,"context_line":"            msg \u003d _(\"Snapshot %(snap_id)s has no managed specified size. \""},{"line_number":264,"context_line":"                    \"Use default value 1, set size in driver options if you \""},{"line_number":265,"context_line":"                    \"want.\") % {\u0027snap_id\u0027: snapshot[\u0027id\u0027]}"},{"line_number":266,"context_line":"            LOG.info(msg)"}],"source_content_type":"text/x-python","patch_set":12,"id":"df33271e_8f1ffd6e","line":263,"range":{"start_line":263,"start_character":49,"end_line":263,"end_character":56},"in_reply_to":"df33271e_93d3b9d5","updated":"2020-04-08 09:35:48.000000000","message":"Done","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1ec404b76fc6a1f939c2821b096f9c6ebf43fc87","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                       \"provider_location: %s, please make sure \""},{"line_number":273,"context_line":"                       \"the snapshot exists in the backend.\","},{"line_number":274,"context_line":"                       provider_location)"},{"line_number":275,"context_line":"            raise exception.BadConfigurationException(message)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        LOG.info(\"Snapshot %(provider_location)s in Unity will be managed \""},{"line_number":278,"context_line":"                 \"with ID %(snapshot_id)s.\","}],"source_content_type":"text/x-python","patch_set":12,"id":"df33271e_f3d965f4","line":275,"range":{"start_line":275,"start_character":28,"end_line":275,"end_character":53},"updated":"2020-04-07 22:56:14.000000000","message":"ManageInvalidShareSnapshot","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"714c02767a74e5041460d589c4ea52308bb58ddd","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                       \"provider_location: %s, please make sure \""},{"line_number":273,"context_line":"                       \"the snapshot exists in the backend.\","},{"line_number":274,"context_line":"                       provider_location)"},{"line_number":275,"context_line":"            raise exception.BadConfigurationException(message)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        LOG.info(\"Snapshot %(provider_location)s in Unity will be managed \""},{"line_number":278,"context_line":"                 \"with ID %(snapshot_id)s.\","}],"source_content_type":"text/x-python","patch_set":12,"id":"df33271e_ef2e89a3","line":275,"range":{"start_line":275,"start_character":28,"end_line":275,"end_character":53},"in_reply_to":"df33271e_f3d965f4","updated":"2020-04-08 09:35:48.000000000","message":"Done","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1ec404b76fc6a1f939c2821b096f9c6ebf43fc87","unresolved":false,"context_lines":[{"line_number":306,"context_line":"            message \u003d (\"Could not find the backend share server by server \""},{"line_number":307,"context_line":"                       \"name: %s, please make sure  the share server is \""},{"line_number":308,"context_line":"                       \"existing in the backend.\", identifier)"},{"line_number":309,"context_line":"            raise exception.BadConfigurationException(message)"},{"line_number":310,"context_line":"        return identifier, driver_options"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def get_share_server_network_info("}],"source_content_type":"text/x-python","patch_set":12,"id":"df33271e_33fd8d3a","line":309,"range":{"start_line":309,"start_character":28,"end_line":309,"end_character":53},"updated":"2020-04-07 22:56:14.000000000","message":"you can use ManageInvalidShare here...","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"714c02767a74e5041460d589c4ea52308bb58ddd","unresolved":false,"context_lines":[{"line_number":306,"context_line":"            message \u003d (\"Could not find the backend share server by server \""},{"line_number":307,"context_line":"                       \"name: %s, please make sure  the share server is \""},{"line_number":308,"context_line":"                       \"existing in the backend.\", identifier)"},{"line_number":309,"context_line":"            raise exception.BadConfigurationException(message)"},{"line_number":310,"context_line":"        return identifier, driver_options"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def get_share_server_network_info("}],"source_content_type":"text/x-python","patch_set":12,"id":"df33271e_cf29059c","line":309,"range":{"start_line":309,"start_character":28,"end_line":309,"end_character":53},"in_reply_to":"df33271e_33fd8d3a","updated":"2020-04-08 09:35:48.000000000","message":"Done","commit_id":"2e78bbc3edf782df6085926e0cdcd0776d449ce6"}],"manila/tests/share/drivers/dell_emc/plugins/unity/test_connection.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"320396e59db41fa8a260f87e638115e70b5a8fe7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1fa4df85_c329849b","updated":"2020-02-28 02:43:09.000000000","message":"I have realized you have added the unit tests for the positive cases. Could you please add more unit tests to the negative cases as well? You can use [1] as a reference of what has been covered and what is not covered by unit tests.\n\n[1] https://12a12650416815df833f-aa881d493e66ac85e397d3a18f294794.ssl.cf2.rackcdn.com/688227/10/check/openstack-tox-cover/a15caf3/cover/manila_share_drivers_dell_emc_plugins_unity_connection_py.html","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"320396e59db41fa8a260f87e638115e70b5a8fe7","unresolved":false,"context_lines":[{"line_number":756,"context_line":"        driver_options \u003d {\u0027size\u0027: 8}"},{"line_number":757,"context_line":"        result \u003d connection.manage_existing_snapshot(snapshot,"},{"line_number":758,"context_line":"                                                     driver_options, None)"},{"line_number":759,"context_line":"        expected \u003d {\u0027provider_location\u0027: \u002723047-ef2344-4563cvw-r4323cwed\u0027,"},{"line_number":760,"context_line":"                    \u0027size\u0027: 8}"},{"line_number":761,"context_line":"        self.assertEqual(expected, result)"},{"line_number":762,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_a39248f5","line":759,"range":{"start_line":759,"start_character":41,"end_line":759,"end_character":73},"updated":"2020-02-28 02:43:09.000000000","message":"this value is being used more than once, what do you think about setting this to a variable and use the variable to access the value?","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"320396e59db41fa8a260f87e638115e70b5a8fe7","unresolved":false,"context_lines":[{"line_number":797,"context_line":"        share \u003d mocked_input[\u0027managed_nfs_share\u0027]"},{"line_number":798,"context_line":"        driver_options \u003d {\u0027size\u0027: 3}"},{"line_number":799,"context_line":"        result \u003d connection.manage_existing(share, driver_options)"},{"line_number":800,"context_line":"        path \u003d \u0027172.168.201.201:/ad1caddf-097e-462c-8ac6-5592ed6fe22f\u0027"},{"line_number":801,"context_line":"        expected \u003d {\u0027export_locations\u0027: {\u0027path\u0027: path}, \u0027size\u0027: 3}"},{"line_number":802,"context_line":"        self.assertEqual(expected, result)"},{"line_number":803,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_63be9066","line":800,"range":{"start_line":800,"start_character":15,"end_line":800,"end_character":70},"updated":"2020-02-28 02:43:09.000000000","message":"same as above... here and below, for the other occurrences","commit_id":"fb48ff55c3e43e4af82b34bcdbac04c31719fe74"}]}