)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"016e00f9dccd12e76f11fb7a653ec94a85c712da","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PowerMax and VNX Manila - Read only policy is not working correctly"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Guarantee that the -0.0.0.0/0.0.0.0 is always at the end of the"},{"line_number":10,"context_line":"access host string when you grant or deny access to a share."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I813191abc592703d6aa7ea55c5be81d1a6089f39"},{"line_number":13,"context_line":"Closes-Bug: #1845147"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_5f9c73be","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":60},"updated":"2019-11-14 01:52:09.000000000","message":"This explains what is being done - can you explain why this has to be done as well?","commit_id":"24ace56139331b265d6d30792000ad3fcdfb9848"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"313b027cb51e654d640076a80a60067c30d2be20","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PowerMax and VNX Manila - Read only policy is not working correctly"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Guarantee that the -0.0.0.0/0.0.0.0 is always at the end of the"},{"line_number":10,"context_line":"access host string when you grant or deny access to a share."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I813191abc592703d6aa7ea55c5be81d1a6089f39"},{"line_number":13,"context_line":"Closes-Bug: #1845147"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_7dd83b7e","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":60},"in_reply_to":"3fa7e38b_5f9c73be","updated":"2019-11-15 16:26:16.000000000","message":"Sure","commit_id":"24ace56139331b265d6d30792000ad3fcdfb9848"}],"manila/share/drivers/dell_emc/plugins/powermax/object_manager.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"016e00f9dccd12e76f11fb7a653ec94a85c712da","unresolved":false,"context_lines":[{"line_number":2031,"context_line":""},{"line_number":2032,"context_line":"        if access_hosts is None:"},{"line_number":2033,"context_line":"            access_hosts \u003d set()"},{"line_number":2034,"context_line":"        if \u0027-0.0.0.0/0.0.0.0\u0027 in access_hosts:"},{"line_number":2035,"context_line":"            access_hosts.remove(\u0027-0.0.0.0/0.0.0.0\u0027)"},{"line_number":2036,"context_line":"        access_str \u003d (\u0027access\u003d%(access)s\u0027 % {\u0027access\u0027: \u0027:\u0027.join("},{"line_number":2037,"context_line":"            list(access_hosts) + [\u0027-0.0.0.0/0.0.0.0\u0027])})"},{"line_number":2038,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_ff7bdf77","line":2035,"range":{"start_line":2034,"start_character":0,"end_line":2035,"end_character":51},"updated":"2019-11-14 01:52:09.000000000","message":"nit: Not pythonic, or thread safe\n\nplease replace with the following:\n\n try:\n     access_hosts.remove(\u0027-0.0.0.0/0.0.0.0\u0027)\n except (ValueError, KeyError):\n     pass","commit_id":"24ace56139331b265d6d30792000ad3fcdfb9848"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"313b027cb51e654d640076a80a60067c30d2be20","unresolved":false,"context_lines":[{"line_number":2031,"context_line":""},{"line_number":2032,"context_line":"        if access_hosts is None:"},{"line_number":2033,"context_line":"            access_hosts \u003d set()"},{"line_number":2034,"context_line":"        if \u0027-0.0.0.0/0.0.0.0\u0027 in access_hosts:"},{"line_number":2035,"context_line":"            access_hosts.remove(\u0027-0.0.0.0/0.0.0.0\u0027)"},{"line_number":2036,"context_line":"        access_str \u003d (\u0027access\u003d%(access)s\u0027 % {\u0027access\u0027: \u0027:\u0027.join("},{"line_number":2037,"context_line":"            list(access_hosts) + [\u0027-0.0.0.0/0.0.0.0\u0027])})"},{"line_number":2038,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_1aa6ed55","line":2035,"range":{"start_line":2034,"start_character":0,"end_line":2035,"end_character":51},"in_reply_to":"3fa7e38b_ff7bdf77","updated":"2019-11-15 16:26:16.000000000","message":"Sure.","commit_id":"24ace56139331b265d6d30792000ad3fcdfb9848"}],"manila/share/drivers/dell_emc/plugins/vnx/object_manager.py":[{"author":{"_account_id":18742,"name":"Ryan Liang","email":"ryan.liang@emc.com","username":"RyanLiang"},"change_message_id":"3e0ef245565695762e384e92e5788c4f717d3d0c","unresolved":false,"context_lines":[{"line_number":2028,"context_line":"                          root_hosts, access_hosts):"},{"line_number":2029,"context_line":""},{"line_number":2030,"context_line":"        if access_hosts is None:"},{"line_number":2031,"context_line":"            access_str \u003d \u0027access\u003d-0.0.0.0/0.0.0.0\u0027"},{"line_number":2032,"context_line":"        else:"},{"line_number":2033,"context_line":"            # Guarantee that -0.0.0.0/0.0.0.0 is always at the end of the"},{"line_number":2034,"context_line":"            # access host string"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_dec257e9","line":2031,"updated":"2019-10-30 01:34:21.000000000","message":"The code may be more concise.\nif access_hosts is None:\n    access_hosts \u003d set()\n\naccess_hosts.discard(\u0027-0.0.0.0/0.0.0.0\u0027)\naccess_str \u003d (\u0027access\u003d%(access)s\u0027\n              % {\u0027access\u0027: \u0027:\u0027.join(list(access_hosts) + [\u0027-0.0.0.0/0.0.0.0\u0027])})","commit_id":"120532ca870ba860bc2030602fe35fab6be91157"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"4acb60902028028a98f5a188eb20f02175625dff","unresolved":false,"context_lines":[{"line_number":2028,"context_line":"                          root_hosts, access_hosts):"},{"line_number":2029,"context_line":""},{"line_number":2030,"context_line":"        if access_hosts is None:"},{"line_number":2031,"context_line":"            access_str \u003d \u0027access\u003d-0.0.0.0/0.0.0.0\u0027"},{"line_number":2032,"context_line":"        else:"},{"line_number":2033,"context_line":"            # Guarantee that -0.0.0.0/0.0.0.0 is always at the end of the"},{"line_number":2034,"context_line":"            # access host string"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8b6a3cb0","line":2031,"in_reply_to":"3fa7e38b_dec257e9","updated":"2019-11-03 16:36:37.000000000","message":"Thanks Ryan","commit_id":"120532ca870ba860bc2030602fe35fab6be91157"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"016e00f9dccd12e76f11fb7a653ec94a85c712da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3fa7e38b_1fcd9bb6","updated":"2019-11-14 01:52:09.000000000","message":"I see that this driver is also versioned, shouldn\u0027t that version number be updated as well?\n\nhttps://opendev.org/openstack/manila/src/commit/24337fe73959f11a824540b5dc8b38e93843e2e4/manila/share/drivers/dell_emc/plugins/vnx/connection.py#L36-L43","commit_id":"24ace56139331b265d6d30792000ad3fcdfb9848"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"313b027cb51e654d640076a80a60067c30d2be20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3fa7e38b_1a54ad21","in_reply_to":"3fa7e38b_1fcd9bb6","updated":"2019-11-15 16:26:16.000000000","message":"Yes.  I will update this.","commit_id":"24ace56139331b265d6d30792000ad3fcdfb9848"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"016e00f9dccd12e76f11fb7a653ec94a85c712da","unresolved":false,"context_lines":[{"line_number":2029,"context_line":""},{"line_number":2030,"context_line":"        if access_hosts is None:"},{"line_number":2031,"context_line":"            access_hosts \u003d set()"},{"line_number":2032,"context_line":"        if \u0027-0.0.0.0/0.0.0.0\u0027 in access_hosts:"},{"line_number":2033,"context_line":"            access_hosts.remove(\u0027-0.0.0.0/0.0.0.0\u0027)"},{"line_number":2034,"context_line":"        access_str \u003d (\u0027access\u003d%(access)s\u0027 % {\u0027access\u0027: \u0027:\u0027.join("},{"line_number":2035,"context_line":"            list(access_hosts) + [\u0027-0.0.0.0/0.0.0.0\u0027])})"},{"line_number":2036,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_5fd31360","line":2033,"range":{"start_line":2032,"start_character":8,"end_line":2033,"end_character":51},"updated":"2019-11-14 01:52:09.000000000","message":"same comment as in the powermax file","commit_id":"24ace56139331b265d6d30792000ad3fcdfb9848"}]}