)]}'
{"api-ref/source/parameters.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7226d940011e38959d25a02b2791e71ed4aecef8","unresolved":true,"context_lines":[{"line_number":2347,"context_line":"    is `False`."},{"line_number":2348,"context_line":"  in: body"},{"line_number":2349,"context_line":"  required: false"},{"line_number":2350,"context_line":"  type: boolean"},{"line_number":2351,"context_line":"share_group_host:"},{"line_number":2352,"context_line":"  description: |"},{"line_number":2353,"context_line":"    The share group host name."}],"source_content_type":"text/x-yaml","patch_set":30,"id":"8b7da9e5_3783c188","line":2350,"range":{"start_line":2350,"start_character":2,"end_line":2350,"end_character":15},"updated":"2021-07-14 00:08:43.000000000","message":"min_version is necessary here, after you make microversion changes","commit_id":"e1cb613f937b3a2d7635e597ad1182df5a59628e"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"8dce98e6f476ec2606c134341ed2243da583e7fb","unresolved":true,"context_lines":[{"line_number":2347,"context_line":"    is `False`."},{"line_number":2348,"context_line":"  in: body"},{"line_number":2349,"context_line":"  required: false"},{"line_number":2350,"context_line":"  type: boolean"},{"line_number":2351,"context_line":"share_group_host:"},{"line_number":2352,"context_line":"  description: |"},{"line_number":2353,"context_line":"    The share group host name."}],"source_content_type":"text/x-yaml","patch_set":30,"id":"e35b23a3_bbae3833","line":2350,"range":{"start_line":2350,"start_character":2,"end_line":2350,"end_character":15},"in_reply_to":"8b7da9e5_3783c188","updated":"2021-07-14 06:29:26.000000000","message":"ok, i will add a new min_version.","commit_id":"e1cb613f937b3a2d7635e597ad1182df5a59628e"}],"manila/api/openstack/rest_api_version_history.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3f7105c736803129adf34e8f7f7bdb71deaea6cf","unresolved":true,"context_lines":[{"line_number":356,"context_line":"2.64"},{"line_number":357,"context_line":"----"},{"line_number":358,"context_line":"  Added \u0027force\u0027 field to extend share api, which can extend share directly"},{"line_number":359,"context_line":"  without go through share scheduler."},{"line_number":360,"context_line":""}],"source_content_type":"text/x-rst","patch_set":32,"id":"ccbfb17c_627ab5a2","line":359,"range":{"start_line":359,"start_character":10,"end_line":359,"end_character":12},"updated":"2021-07-29 05:53:39.000000000","message":"nit: \"routing the request\"","commit_id":"7b818c4e0f106f591d1bfc9c3abb5e0831fe3fcc"}],"manila/api/v1/shares.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"bd4d1a1a9bff6c9e7f6b28b29856951990215f14","unresolved":false,"context_lines":[{"line_number":495,"context_line":"    def _extend(self, req, id, body):"},{"line_number":496,"context_line":"        \"\"\"Extend size of a share.\"\"\""},{"line_number":497,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":498,"context_line":"        share, size , force \u003d self._get_valid_extend_parameters("},{"line_number":499,"context_line":"            context, id, body, \u0027os-extend\u0027)"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":14,"id":"1f621f24_3fcc0c69","line":498,"updated":"2020-11-06 10:05:18.000000000","message":"pep8: E203 whitespace before \u0027,\u0027","commit_id":"2b0105b84baeae39b61f9e581df8488df50908ca"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"772cbaf80c7f7e43fd7474143f213812421c6504","unresolved":false,"context_lines":[{"line_number":539,"context_line":"        except (KeyError, ValueError, TypeError):"},{"line_number":540,"context_line":"            force \u003d False"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"        # only admin user can use use force as True"},{"line_number":543,"context_line":"        if force and not context.is_admin():"},{"line_number":544,"context_line":"            force \u003d False"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"        return share, size, force"}],"source_content_type":"text/x-python","patch_set":16,"id":"1f621f24_b168431d","line":543,"range":{"start_line":542,"start_character":8,"end_line":543,"end_character":44},"updated":"2020-11-09 08:24:31.000000000","message":"Please don\u0027t hardcode the is_admin check, better make the force option controllable via oslo policy","commit_id":"d0d91edc083869a25b398dc73c481793b12b4fea"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"7dcacf18884e4ec3a76e2ae37723c29dfa0a2f35","unresolved":false,"context_lines":[{"line_number":539,"context_line":"        except (KeyError, ValueError, TypeError):"},{"line_number":540,"context_line":"            force \u003d False"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"        # only admin user can use use force as True"},{"line_number":543,"context_line":"        if force and not context.is_admin():"},{"line_number":544,"context_line":"            force \u003d False"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"        return share, size, force"}],"source_content_type":"text/x-python","patch_set":16,"id":"f1840282_6166c3fe","line":543,"range":{"start_line":542,"start_character":8,"end_line":543,"end_character":44},"in_reply_to":"1f621f24_b168431d","updated":"2020-11-25 07:40:23.000000000","message":"yes, i will add force_extend in oslo policy.","commit_id":"d0d91edc083869a25b398dc73c481793b12b4fea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7226d940011e38959d25a02b2791e71ed4aecef8","unresolved":true,"context_lines":[{"line_number":515,"context_line":"    def _extend(self, req, id, body):"},{"line_number":516,"context_line":"        \"\"\"Extend size of a share.\"\"\""},{"line_number":517,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":518,"context_line":"        share, size, force \u003d self._get_valid_extend_parameters("},{"line_number":519,"context_line":"            context, id, body, \u0027os-extend\u0027)"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"        try:"},{"line_number":522,"context_line":"            self.share_api.extend(context, share, size, force\u003dforce)"}],"source_content_type":"text/x-python","patch_set":30,"id":"b0200117_ebb22495","line":519,"range":{"start_line":518,"start_character":7,"end_line":519,"end_character":43},"updated":"2021-07-14 00:08:43.000000000","message":"Haixin: force cannot be added retroactively to the API, this needs to be introduced in a new API microversion\n\nThe changes in this file are okay, but lets prevent older API version consumers from getting access to this parameter by overriding the extend method in the v2 api, like the manage API here: https://opendev.org/openstack/manila/src/commit/6c329e1a80f34cfbf6b077bbafe15693cb34a919/manila/api/v2/shares.py#L414-L428","commit_id":"e1cb613f937b3a2d7635e597ad1182df5a59628e"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"8dce98e6f476ec2606c134341ed2243da583e7fb","unresolved":true,"context_lines":[{"line_number":515,"context_line":"    def _extend(self, req, id, body):"},{"line_number":516,"context_line":"        \"\"\"Extend size of a share.\"\"\""},{"line_number":517,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":518,"context_line":"        share, size, force \u003d self._get_valid_extend_parameters("},{"line_number":519,"context_line":"            context, id, body, \u0027os-extend\u0027)"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"        try:"},{"line_number":522,"context_line":"            self.share_api.extend(context, share, size, force\u003dforce)"}],"source_content_type":"text/x-python","patch_set":30,"id":"3f1a67de_db4d682f","line":519,"range":{"start_line":518,"start_character":7,"end_line":519,"end_character":43},"in_reply_to":"b0200117_ebb22495","updated":"2021-07-14 06:29:26.000000000","message":"ok, i will do it in v2 api.","commit_id":"e1cb613f937b3a2d7635e597ad1182df5a59628e"}],"manila/policies/shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0082f5f7d54c079751ea24b357bf1ad0bd805757","unresolved":true,"context_lines":[{"line_number":420,"context_line":"                \u0027path\u0027: \u0027/shares/{share_id}/action\u0027,"},{"line_number":421,"context_line":"            }"},{"line_number":422,"context_line":"        ],"},{"line_number":423,"context_line":"        deprecated_rule\u003ddeprecated_share_extend"},{"line_number":424,"context_line":"    ),"},{"line_number":425,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":426,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027force_extend\u0027,"}],"source_content_type":"text/x-python","patch_set":30,"id":"f80be871_b7fc1275","line":423,"range":{"start_line":423,"start_character":8,"end_line":423,"end_character":47},"updated":"2021-07-14 00:10:19.000000000","message":"While we\u0027re still supporting non-scoped RBAC policies, this deprecated rule can be reused as the deprecated rule for the below policy; no need to introduce a different policy for non-scoped users","commit_id":"e1cb613f937b3a2d7635e597ad1182df5a59628e"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"8dce98e6f476ec2606c134341ed2243da583e7fb","unresolved":false,"context_lines":[{"line_number":420,"context_line":"                \u0027path\u0027: \u0027/shares/{share_id}/action\u0027,"},{"line_number":421,"context_line":"            }"},{"line_number":422,"context_line":"        ],"},{"line_number":423,"context_line":"        deprecated_rule\u003ddeprecated_share_extend"},{"line_number":424,"context_line":"    ),"},{"line_number":425,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":426,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027force_extend\u0027,"}],"source_content_type":"text/x-python","patch_set":30,"id":"1c6d6e1e_5dd6d528","line":423,"range":{"start_line":423,"start_character":8,"end_line":423,"end_character":47},"in_reply_to":"f80be871_b7fc1275","updated":"2021-07-14 06:29:26.000000000","message":"Done","commit_id":"e1cb613f937b3a2d7635e597ad1182df5a59628e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7226d940011e38959d25a02b2791e71ed4aecef8","unresolved":true,"context_lines":[{"line_number":424,"context_line":"    ),"},{"line_number":425,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":426,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027force_extend\u0027,"},{"line_number":427,"context_line":"        check_str\u003dbase.RULE_ADMIN_API,"},{"line_number":428,"context_line":"        description\u003d\"Force extend share.\","},{"line_number":429,"context_line":"        operations\u003d["},{"line_number":430,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":30,"id":"48d69d7c_7af0b7d8","line":427,"range":{"start_line":427,"start_character":23,"end_line":427,"end_character":37},"updated":"2021-07-14 00:08:43.000000000","message":"this has to be \"SYSTEM_ADMIN_OR_PROJECT_ADMIN\"\n\ni.e, prevent regular member users from using force","commit_id":"e1cb613f937b3a2d7635e597ad1182df5a59628e"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"8dce98e6f476ec2606c134341ed2243da583e7fb","unresolved":false,"context_lines":[{"line_number":424,"context_line":"    ),"},{"line_number":425,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":426,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027force_extend\u0027,"},{"line_number":427,"context_line":"        check_str\u003dbase.RULE_ADMIN_API,"},{"line_number":428,"context_line":"        description\u003d\"Force extend share.\","},{"line_number":429,"context_line":"        operations\u003d["},{"line_number":430,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba1c8668_72f089e2","line":427,"range":{"start_line":427,"start_character":23,"end_line":427,"end_character":37},"in_reply_to":"48d69d7c_7af0b7d8","updated":"2021-07-14 06:29:26.000000000","message":"Done","commit_id":"e1cb613f937b3a2d7635e597ad1182df5a59628e"}],"manila/scheduler/manager.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4d8c58169a50c3062cb2176372ffb55fce6467b","unresolved":false,"context_lines":[{"line_number":312,"context_line":"                     request_spec\u003dNone, filter_properties\u003dNone):"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        def _extend_share_set_error(self, context, ex, request_spec):"},{"line_number":315,"context_line":"            share_state \u003d {"},{"line_number":316,"context_line":"                \u0027share_state\u0027: {\u0027status\u0027: constants.STATUS_AVAILABLE}}"},{"line_number":317,"context_line":"            self._set_share_state_and_notify(\u0027extend_share\u0027, share_state,"},{"line_number":318,"context_line":"                                             context, ex, request_spec)"},{"line_number":319,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_00d81651","line":316,"range":{"start_line":315,"start_character":26,"end_line":316,"end_character":70},"updated":"2020-04-22 18:15:12.000000000","message":"This should just be {\u0027status\u0027: constants.STATUS_AVAILABLE}","commit_id":"a62593b2edbb92cf9c4c2c5ec9a24df27832caf5"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"3e9efecb273f4b34a45d3e91ea6e440980a1ff8c","unresolved":false,"context_lines":[{"line_number":312,"context_line":"                     request_spec\u003dNone, filter_properties\u003dNone):"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        def _extend_share_set_error(self, context, ex, request_spec):"},{"line_number":315,"context_line":"            share_state \u003d {"},{"line_number":316,"context_line":"                \u0027share_state\u0027: {\u0027status\u0027: constants.STATUS_AVAILABLE}}"},{"line_number":317,"context_line":"            self._set_share_state_and_notify(\u0027extend_share\u0027, share_state,"},{"line_number":318,"context_line":"                                             context, ex, request_spec)"},{"line_number":319,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_969c625e","line":316,"range":{"start_line":315,"start_character":26,"end_line":316,"end_character":70},"in_reply_to":"1f493fa4_00d81651","updated":"2020-04-23 08:07:23.000000000","message":"Done","commit_id":"a62593b2edbb92cf9c4c2c5ec9a24df27832caf5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4d8c58169a50c3062cb2176372ffb55fce6467b","unresolved":false,"context_lines":[{"line_number":318,"context_line":"                                             context, ex, request_spec)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        try:"},{"line_number":321,"context_line":"            backend_state \u003d self.driver.host_passes_filters("},{"line_number":322,"context_line":"                context,"},{"line_number":323,"context_line":"                share[\u0027host\u0027],"},{"line_number":324,"context_line":"                request_spec, filter_properties)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_a0b16292","line":321,"range":{"start_line":321,"start_character":12,"end_line":321,"end_character":25},"updated":"2020-04-22 18:15:12.000000000","message":"what does this name mean?\n\nperhaps \"target_host\" is a better name?","commit_id":"a62593b2edbb92cf9c4c2c5ec9a24df27832caf5"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"3e9efecb273f4b34a45d3e91ea6e440980a1ff8c","unresolved":false,"context_lines":[{"line_number":318,"context_line":"                                             context, ex, request_spec)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        try:"},{"line_number":321,"context_line":"            backend_state \u003d self.driver.host_passes_filters("},{"line_number":322,"context_line":"                context,"},{"line_number":323,"context_line":"                share[\u0027host\u0027],"},{"line_number":324,"context_line":"                request_spec, filter_properties)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_b9998f6f","line":321,"range":{"start_line":321,"start_character":12,"end_line":321,"end_character":25},"in_reply_to":"1f493fa4_a0b16292","updated":"2020-04-23 08:07:23.000000000","message":"Done","commit_id":"a62593b2edbb92cf9c4c2c5ec9a24df27832caf5"}],"manila/scheduler/rpcapi.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"73afa51748402e9b70ada9b4a0c290c23aad1741","unresolved":true,"context_lines":[{"line_number":151,"context_line":"        call_context \u003d self.client.prepare(version\u003d\u00271.11\u0027)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        msg_args \u003d {"},{"line_number":154,"context_line":"            \u0027share\u0027: share,"},{"line_number":155,"context_line":"            \u0027new_size\u0027: new_size,"},{"line_number":156,"context_line":"            \u0027reservations\u0027: reservations,"},{"line_number":157,"context_line":"            \u0027request_spec\u0027: request_spec,"}],"source_content_type":"text/x-python","patch_set":25,"id":"32f2c6ae_a152f3a0","line":154,"range":{"start_line":154,"start_character":12,"end_line":154,"end_character":27},"updated":"2021-07-08 15:50:55.000000000","message":"serializing this is going to be a problem because we don\u0027t eager load all the connected tables; \nAll the other RPC methods here just pass the share_id; can we do that here as well? Remember we\u0027ve already \"serialized\" the relevant scheduler information in the request spec and the filter properties","commit_id":"924630271bd6b4be97cc7a74cb28ed29a41c2895"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"5fba05b1d10c70296f87b318d9e4a5a95b484e42","unresolved":true,"context_lines":[{"line_number":151,"context_line":"        call_context \u003d self.client.prepare(version\u003d\u00271.11\u0027)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        msg_args \u003d {"},{"line_number":154,"context_line":"            \u0027share\u0027: share,"},{"line_number":155,"context_line":"            \u0027new_size\u0027: new_size,"},{"line_number":156,"context_line":"            \u0027reservations\u0027: reservations,"},{"line_number":157,"context_line":"            \u0027request_spec\u0027: request_spec,"}],"source_content_type":"text/x-python","patch_set":25,"id":"43ea5e88_d1c66090","line":154,"range":{"start_line":154,"start_character":12,"end_line":154,"end_character":27},"in_reply_to":"32f2c6ae_a152f3a0","updated":"2021-07-12 08:42:06.000000000","message":"thanks, Goutham Pacha Ravi, i will try.","commit_id":"924630271bd6b4be97cc7a74cb28ed29a41c2895"}],"manila/share/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4d8c58169a50c3062cb2176372ffb55fce6467b","unresolved":false,"context_lines":[{"line_number":773,"context_line":"                    \u0027mount_snapshot_support\u0027)"},{"line_number":774,"context_line":"            ),"},{"line_number":775,"context_line":"            \u0027share_proto\u0027: kwargs.get(\u0027share_proto\u0027, share.get(\u0027share_proto\u0027)),"},{"line_number":776,"context_line":"            \u0027share_type_id\u0027: share_type.get(\u0027id\u0027),"},{"line_number":777,"context_line":"            \u0027is_public\u0027: kwargs.get(\u0027is_public\u0027, share.get(\u0027is_public\u0027)),"},{"line_number":778,"context_line":"            \u0027share_group_id\u0027: kwargs.get("},{"line_number":779,"context_line":"                \u0027share_group_id\u0027, share.get(\u0027share_group_id\u0027)),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_e007ea1b","line":776,"range":{"start_line":776,"start_character":29,"end_line":776,"end_character":50},"updated":"2020-04-22 18:15:12.000000000","message":"Why change this? share_type shouldn\u0027t be {} - we\u0027ll have bigger problems in the scheduler if it is.","commit_id":"a62593b2edbb92cf9c4c2c5ec9a24df27832caf5"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"3e9efecb273f4b34a45d3e91ea6e440980a1ff8c","unresolved":false,"context_lines":[{"line_number":773,"context_line":"                    \u0027mount_snapshot_support\u0027)"},{"line_number":774,"context_line":"            ),"},{"line_number":775,"context_line":"            \u0027share_proto\u0027: kwargs.get(\u0027share_proto\u0027, share.get(\u0027share_proto\u0027)),"},{"line_number":776,"context_line":"            \u0027share_type_id\u0027: share_type.get(\u0027id\u0027),"},{"line_number":777,"context_line":"            \u0027is_public\u0027: kwargs.get(\u0027is_public\u0027, share.get(\u0027is_public\u0027)),"},{"line_number":778,"context_line":"            \u0027share_group_id\u0027: kwargs.get("},{"line_number":779,"context_line":"                \u0027share_group_id\u0027, share.get(\u0027share_group_id\u0027)),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_56313aa2","line":776,"range":{"start_line":776,"start_character":29,"end_line":776,"end_character":50},"in_reply_to":"1f493fa4_e007ea1b","updated":"2020-04-23 08:07:23.000000000","message":"yes, the share will have default share type , even if share type is not specified when created.","commit_id":"a62593b2edbb92cf9c4c2c5ec9a24df27832caf5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aadf69344bc7b19212177ffe2c79124a927c7d3d","unresolved":false,"context_lines":[{"line_number":1993,"context_line":"                consumed\u003d_consumed(\u0027gigabytes\u0027),"},{"line_number":1994,"context_line":"                quota\u003dquotas[\u0027gigabytes\u0027])"},{"line_number":1995,"context_line":""},{"line_number":1996,"context_line":"        self.update(context, share, {\u0027status\u0027: constants.STATUS_EXTENDING})"},{"line_number":1997,"context_line":""},{"line_number":1998,"context_line":"        share_type \u003d {}"},{"line_number":1999,"context_line":"        share_type_id \u003d share[\u0027instance\u0027][\u0027share_type_id\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_8e03b042","line":1996,"range":{"start_line":1996,"start_character":8,"end_line":1996,"end_character":75},"updated":"2020-04-23 00:37:49.000000000","message":"You noted having database detached issues, it\u0027s likely because something is accessing the share model in the RPC layer post the SQLAlchemy session closure. This is the last method that interacts with the database, can you try updating your share ref here?\n\n share \u003d self.update(context, share, {\u0027status\u0027: constants.STATUS_EXTENDING})","commit_id":"a62593b2edbb92cf9c4c2c5ec9a24df27832caf5"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"3e9efecb273f4b34a45d3e91ea6e440980a1ff8c","unresolved":false,"context_lines":[{"line_number":1993,"context_line":"                consumed\u003d_consumed(\u0027gigabytes\u0027),"},{"line_number":1994,"context_line":"                quota\u003dquotas[\u0027gigabytes\u0027])"},{"line_number":1995,"context_line":""},{"line_number":1996,"context_line":"        self.update(context, share, {\u0027status\u0027: constants.STATUS_EXTENDING})"},{"line_number":1997,"context_line":""},{"line_number":1998,"context_line":"        share_type \u003d {}"},{"line_number":1999,"context_line":"        share_type_id \u003d share[\u0027instance\u0027][\u0027share_type_id\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_9349148d","line":1996,"range":{"start_line":1996,"start_character":8,"end_line":1996,"end_character":75},"in_reply_to":"1f493fa4_8e03b042","updated":"2020-04-23 08:07:23.000000000","message":"thank you, Goutham, This problem has been bothering me for a long time, i will try.","commit_id":"a62593b2edbb92cf9c4c2c5ec9a24df27832caf5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4d8c58169a50c3062cb2176372ffb55fce6467b","unresolved":false,"context_lines":[{"line_number":1997,"context_line":""},{"line_number":1998,"context_line":"        share_type \u003d {}"},{"line_number":1999,"context_line":"        share_type_id \u003d share[\u0027instance\u0027][\u0027share_type_id\u0027]"},{"line_number":2000,"context_line":"        if share_type_id:"},{"line_number":2001,"context_line":"            share_type \u003d share_types.get_share_type(context,"},{"line_number":2002,"context_line":"                                                    share_type_id)"},{"line_number":2003,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_8b70c774","line":2000,"range":{"start_line":2000,"start_character":8,"end_line":2000,"end_character":25},"updated":"2020-04-22 18:15:12.000000000","message":"All shares should have a share_type, so this condition isn\u0027t necessary..","commit_id":"a62593b2edbb92cf9c4c2c5ec9a24df27832caf5"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"3e9efecb273f4b34a45d3e91ea6e440980a1ff8c","unresolved":false,"context_lines":[{"line_number":1997,"context_line":""},{"line_number":1998,"context_line":"        share_type \u003d {}"},{"line_number":1999,"context_line":"        share_type_id \u003d share[\u0027instance\u0027][\u0027share_type_id\u0027]"},{"line_number":2000,"context_line":"        if share_type_id:"},{"line_number":2001,"context_line":"            share_type \u003d share_types.get_share_type(context,"},{"line_number":2002,"context_line":"                                                    share_type_id)"},{"line_number":2003,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_f673267f","line":2000,"range":{"start_line":2000,"start_character":8,"end_line":2000,"end_character":25},"in_reply_to":"1f493fa4_8b70c774","updated":"2020-04-23 08:07:23.000000000","message":"Done","commit_id":"a62593b2edbb92cf9c4c2c5ec9a24df27832caf5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"d08ce4920dd54e7c5ead319fe94239da07a59aba","unresolved":false,"context_lines":[{"line_number":2126,"context_line":"                    raise exception.ShareReplicaSizeExceedsAvailableQuota("},{"line_number":2127,"context_line":"                        message\u003dmsg)"},{"line_number":2128,"context_line":""},{"line_number":2129,"context_line":"        share \u003d self.update(context, share,"},{"line_number":2130,"context_line":"                            {\u0027status\u0027: constants.STATUS_EXTENDING})"},{"line_number":2131,"context_line":""},{"line_number":2132,"context_line":"        share_type \u003d share_types.get_share_type("},{"line_number":2133,"context_line":"            context, share[\u0027instance\u0027][\u0027share_type_id\u0027])"},{"line_number":2134,"context_line":""},{"line_number":2135,"context_line":"        request_spec \u003d self._get_request_spec_dict(share, share_type)"},{"line_number":2136,"context_line":"        self.scheduler_rpcapi.extend_share(context, share, new_size,"},{"line_number":2137,"context_line":"                                           reservations, request_spec)"},{"line_number":2138,"context_line":"        LOG.info(\"Extend share request issued successfully.\","},{"line_number":2139,"context_line":"                 resource\u003dshare)"},{"line_number":2140,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"ff570b3c_bbf2016e","line":2137,"range":{"start_line":2129,"start_character":0,"end_line":2137,"end_character":70},"updated":"2020-05-29 02:31:24.000000000","message":"Haixin, we were wondering if would be better to continue to have both modes, go to the scheduler or continue directly to share manager. We can achieve this by adding a new config to enable/disable going to scheduler when extending share (same thing that create from snapshot has).\nReason: some admins deploy and configure their environment considering that the back end reserved space could be use to increase some workloads, and at the same time, avoiding the creation of new shares in this back end.","commit_id":"5dbea7352d6a2207db811a50ffca0b0be50c9bd8"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"54826acceb5673048cc18492d0987d3e1007ea5a","unresolved":false,"context_lines":[{"line_number":2126,"context_line":"                    raise exception.ShareReplicaSizeExceedsAvailableQuota("},{"line_number":2127,"context_line":"                        message\u003dmsg)"},{"line_number":2128,"context_line":""},{"line_number":2129,"context_line":"        share \u003d self.update(context, share,"},{"line_number":2130,"context_line":"                            {\u0027status\u0027: constants.STATUS_EXTENDING})"},{"line_number":2131,"context_line":""},{"line_number":2132,"context_line":"        share_type \u003d share_types.get_share_type("},{"line_number":2133,"context_line":"            context, share[\u0027instance\u0027][\u0027share_type_id\u0027])"},{"line_number":2134,"context_line":""},{"line_number":2135,"context_line":"        request_spec \u003d self._get_request_spec_dict(share, share_type)"},{"line_number":2136,"context_line":"        self.scheduler_rpcapi.extend_share(context, share, new_size,"},{"line_number":2137,"context_line":"                                           reservations, request_spec)"},{"line_number":2138,"context_line":"        LOG.info(\"Extend share request issued successfully.\","},{"line_number":2139,"context_line":"                 resource\u003dshare)"},{"line_number":2140,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1f621f24_89c6d247","line":2137,"range":{"start_line":2129,"start_character":0,"end_line":2137,"end_character":70},"in_reply_to":"ff570b3c_bbf2016e","updated":"2020-11-06 07:41:16.000000000","message":"yes，i will add a parameter to the API layer that lets the user choose whether to go through the scheduler or not","commit_id":"5dbea7352d6a2207db811a50ffca0b0be50c9bd8"}]}