)]}'
{"id":"openstack%2Fmanila~706751","triplet_id":"openstack%2Fmanila~stable%2Ftrain~I9fa29e9e5ed7dd2c620b56efab559f4cec25aced","project":"openstack/manila","branch":"stable/train","topic":"manila/generic-improvements","hashtags":[],"change_id":"I9fa29e9e5ed7dd2c620b56efab559f4cec25aced","subject":"Refactor route clearing to linux interface","status":"MERGED","created":"2020-02-10 08:36:54.000000000","updated":"2020-02-15 04:46:42.000000000","submitted":"2020-02-10 15:18:07.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"706751-1581347887330-25e6796c","meta_rev_id":"0857d32fb6271358429cc2ec13ad794731c11741","_number":706751,"virtual_id_number":706751,"owner":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2020-02-15 04:46:42.000000000","post_submit":true,"_account_id":21863,"name":"Infinidat CI","email":"jenkins@infinidat.com","username":"infinidat-openstack"},{"value":0,"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-02-10 15:18:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"all":[{"value":0,"_account_id":21863,"name":"Infinidat CI","email":"jenkins@infinidat.com","username":"infinidat-openstack"},{"value":2,"date":"2020-02-10 11:51:00.000000000","_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"all":[{"value":0,"_account_id":21863,"name":"Infinidat CI","email":"jenkins@infinidat.com","username":"infinidat-openstack"},{"value":1,"date":"2020-02-10 11:51:00.000000000","_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"_account_id":21863,"name":"Infinidat CI","email":"jenkins@infinidat.com","username":"infinidat-openstack"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-02-10 11:51:00.000000000","updated_by":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"reviewer":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"state":"REVIEWER"},{"updated":"2020-02-10 15:18:06.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-02-15 04:46:42.000000000","updated_by":{"_account_id":21863,"name":"Infinidat CI","email":"jenkins@infinidat.com","username":"infinidat-openstack"},"reviewer":{"_account_id":21863,"name":"Infinidat CI","email":"jenkins@infinidat.com","username":"infinidat-openstack"},"state":"REVIEWER"}],"messages":[{"id":"15d7fb8137d510f381f2cbd74e3bc2ccdb8ab2fb","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2020-02-10 08:36:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d9a9bf8e6f2ae12f9379d2ada7bad1bcdcd1b7fb","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2020-02-10 08:40:33.000000000","message":"Topic changed from manila/generic-improvements-train to manila/generic-improvements","accounts_in_message":[],"_revision_number":1},{"id":"ad546242c5db6b5cca9baa628acb9d1ebcf12724","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-10 11:11:19.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/af488f72fc7345feb8180c484347025c : SUCCESS in 11m 25s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/46aa66410c1b4e0d85bb090428415ea6 : SUCCESS in 16m 39s (non-voting)\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1e618ee642d94fb4948762380907a437 : SUCCESS in 9m 05s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/20278c766fce464d879f03d19fcdc759 : SUCCESS in 10m 08s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/5dfbc34408704452889c1fd64fdc99de : SUCCESS in 11m 00s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/70269b2f99c04c32899451e3fdfa4276 : SUCCESS in 8m 48s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/ac223891d01f40618da91d81c4c14ef3 : SUCCESS in 9m 32s\n- manila-tox-genconfig https://zuul.opendev.org/t/openstack/build/604e8d2d3456451ab557a9c7edff1739 : SUCCESS in 7m 42s\n- manila-tempest-dsvm-mysql-generic https://zuul.opendev.org/t/openstack/build/90daef52a92b4fcf973f7283fae26037 : SUCCESS in 1h 28m 59s (non-voting)\n- manila-tempest-dsvm-postgres-container https://zuul.opendev.org/t/openstack/build/a25c10e8015b4841a53088e4f56f5d36 : SUCCESS in 1h 07m 04s (non-voting)\n- manila-tempest-dsvm-postgres-zfsonlinux https://zuul.opendev.org/t/openstack/build/331fe4fa427740bda68eacc8a8776802 : SUCCESS in 1h 14m 03s (non-voting)\n- manila-tempest-dsvm-postgres-generic-singlebackend https://zuul.opendev.org/t/openstack/build/95e01e0629654eb4b1f0443601c44af0 : SUCCESS in 53m 35s (non-voting)\n- manila-tempest-dsvm-generic-no-share-servers https://zuul.opendev.org/t/openstack/build/053b6c78e1cb4bd6a443f67e6467cc7c : SUCCESS in 1h 10m 29s (non-voting)\n- manila-tempest-dsvm-scenario https://zuul.opendev.org/t/openstack/build/90bd7114e188416a95d7398e98649d6f : FAILURE in 1h 56m 04s (non-voting)\n- manila-tempest-minimal-dsvm-cephfs-native https://zuul.opendev.org/t/openstack/build/93d6d2b070f24f239b7a88ea3b0ba4e8 : SUCCESS in 30m 32s (non-voting)\n- manila-tempest-minimal-dsvm-cephfs-nfs https://zuul.opendev.org/t/openstack/build/23899f5a4714462eab2562a130fc8862 : SUCCESS in 1h 30m 22s (non-voting)\n- manila-tempest-dsvm-glusterfs-nfs https://zuul.opendev.org/t/openstack/build/11f03a4132cf46a5a1ed9896f2983028 : SUCCESS in 1h 10m 17s (non-voting)\n- manila-tempest-minimal-dsvm-dummy https://zuul.opendev.org/t/openstack/build/9c645bd344414e2189c8932563ed77ee : SUCCESS in 49m 17s\n- manila-tempest-minimal-dsvm-dummy-py2 https://zuul.opendev.org/t/openstack/build/ceb2773494654999b76070182a3ea65f : SUCCESS in 54m 52s\n- manila-tempest-minimal-dsvm-lvm https://zuul.opendev.org/t/openstack/build/6147bec86cf64d3fa69191885adc5fd5 : SUCCESS in 59m 12s\n- manila-tempest-minimal-lvm-ipv6-only https://zuul.opendev.org/t/openstack/build/c9fc195d26074e54ad58fdbd777935bf : SUCCESS in 1h 07m 43s\n- manila-grenade https://zuul.opendev.org/t/openstack/build/f9d3811320c4432b99cfd07d125680c5 : SUCCESS in 31m 50s (non-voting)\n- manila-rally-no-ss https://zuul.opendev.org/t/openstack/build/b182b2e2f1574d5bbe218bd7e8aaddc0 : SUCCESS in 36m 23s (non-voting)\n- manila-rally-ss https://zuul.opendev.org/t/openstack/build/b3b4ca5c9af046798237ecc9505bccfe : SUCCESS in 49m 49s (non-voting)\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/0e65b62dba2f4a4ab47ac4ceaea25c0b : SUCCESS in 6m 40s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"48140052492ed7c6c254d2a10fc65a559f7b6659","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2020-02-10 11:51:00.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"c9db4fa1c1d11d7c8b330b696003bc122b865296","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-10 13:53:02.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"cebba50326d958e246e40fb58e38acc2df7e5927","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-10 15:18:06.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6d9eb0731bb5450a9875730a7c04e301 : SUCCESS in 9m 36s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/402150f26a2249888c067725fd260b0f : SUCCESS in 8m 25s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7f619b2f2549454ea94c7bcddfe9a0e8 : SUCCESS in 7m 39s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/6ed6a312a783488c9e18d623abe9569e : SUCCESS in 8m 28s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6a7a2ebef5634c3e809c990e2de981b9 : SUCCESS in 8m 19s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/2276419a249741be92fe75d9ab8bfdad : SUCCESS in 9m 05s\n- manila-tox-genconfig https://zuul.opendev.org/t/openstack/build/e97daec45b64400e9ef61c281f7a2700 : SUCCESS in 5m 29s\n- manila-tempest-minimal-dsvm-dummy https://zuul.opendev.org/t/openstack/build/338d542d08ca4923a9b9fc97f4702328 : SUCCESS in 43m 16s\n- manila-tempest-minimal-dsvm-lvm https://zuul.opendev.org/t/openstack/build/dc27ad5874a4411a9b182220d648e252 : SUCCESS in 1h 03m 28s\n- manila-tempest-minimal-lvm-ipv6-only https://zuul.opendev.org/t/openstack/build/584f8a7588ae4ac5b56e7b2371131d33 : SUCCESS in 1h 15m 22s","accounts_in_message":[],"_revision_number":1},{"id":"7cab30a21a5061c090c65b67f8f191dae54f419f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-10 15:18:07.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"ff4d241cd6b975524c8bfa79bfb83dab1cfa40b3","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-10 15:21:13.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/664795cfe0b8454085d1e975c0d68139 : SUCCESS in 2m 22s","accounts_in_message":[],"_revision_number":1},{"id":"0857d32fb6271358429cc2ec13ad794731c11741","author":{"_account_id":21863,"name":"Infinidat CI","email":"jenkins@infinidat.com","username":"infinidat-openstack"},"date":"2020-02-15 04:46:42.000000000","message":"Patch Set 1:\n\nBuild failed.  To recheck use \u0027run-INFINIDAT\u0027.  For 3rd party ci contact info: https://wiki.openstack.org/wiki/ThirdPartySystems\n\n- dsvm-tempest-infinibox-nfs http://openstack-ci-logs.aws.infinidat.com/51/706751/1/check/dsvm-tempest-infinibox-nfs/3dbf6ad : EXCEPTION","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ccc781d0847ae0e5c4903108a93c148675e06b43","revisions":{"ccc781d0847ae0e5c4903108a93c148675e06b43":{"kind":"REWORK","_number":1,"created":"2020-02-10 08:36:54.000000000","uploader":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"ref":"refs/changes/51/706751/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/manila","ref":"refs/changes/51/706751/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/manila refs/changes/51/706751/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/manila refs/changes/51/706751/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/manila refs/changes/51/706751/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/manila refs/changes/51/706751/1"}}},"commit":{"parents":[{"commit":"c5e2a0084fc18e3a711a7c281f0f5bd16b239583","subject":"clear_outdated_routes: reduce neutron calls","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/manila/commit/c5e2a0084fc18e3a711a7c281f0f5bd16b239583"}]}],"author":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2020-01-30 15:50:46.000000000","tz":60},"committer":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2020-02-10 08:32:44.000000000","tz":60},"subject":"Refactor route clearing to linux interface","message":"Refactor route clearing to linux interface\n\nThe code for clearing routes currently lives inside the\nservice_instance module but it belongs better inside the linux\ninterface ones.\n\nThis patch refactors it into there, which can allow for a true\nnoop driver as all network operations would happen inside that\nsection.\n\nChange-Id: I9fa29e9e5ed7dd2c620b56efab559f4cec25aced\n(cherry picked from commit e7858ad084a1ef1014afdcec9ad13349ad477cbd)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/manila/commit/ccc781d0847ae0e5c4903108a93c148675e06b43"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/manila/commit/ccc781d0847ae0e5c4903108a93c148675e06b43"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}