)]}'
{"manila/share/drivers/cephfs/client/client_base.py":[{"author":{"_account_id":31638,"name":"Jos Collin","email":"jcollin@redhat.com","username":"jcollin"},"change_message_id":"f40634dfa77a5365889491dd48c582262dce24d0","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    # Path"},{"line_number":27,"context_line":"    @abc.abstractmethod"},{"line_number":28,"context_line":"    def cephfs_share_path(self):"},{"line_number":29,"context_line":"        pass"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    # Client connection"},{"line_number":32,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_5cd4d31e","line":29,"updated":"2020-02-18 07:25:30.000000000","message":"I think this should be an exception instead of pass? Same for other abstract methods too.","commit_id":"7c1c585d00bba6cafb94724b7a0593cfa49930a0"},{"author":{"_account_id":31638,"name":"Jos Collin","email":"jcollin@redhat.com","username":"jcollin"},"change_message_id":"e670911c7a7887d55eaee4cfcae9c46d3ec683b5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    # Path"},{"line_number":27,"context_line":"    @abc.abstractmethod"},{"line_number":28,"context_line":"    def cephfs_share_path(self):"},{"line_number":29,"context_line":"        pass"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    # Client connection"},{"line_number":32,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_1d3403ab","line":29,"in_reply_to":"3fa7e38b_42f8614a","updated":"2020-02-19 04:08:33.000000000","message":"Please ignore this comment. As I learned, abc does the abstraction better.","commit_id":"7c1c585d00bba6cafb94724b7a0593cfa49930a0"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c8e02412b408f300593be435da9e23ff59ad4c63","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    # Path"},{"line_number":27,"context_line":"    @abc.abstractmethod"},{"line_number":28,"context_line":"    def cephfs_share_path(self):"},{"line_number":29,"context_line":"        pass"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    # Client connection"},{"line_number":32,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_42f8614a","line":29,"in_reply_to":"3fa7e38b_5cd4d31e","updated":"2020-02-18 18:01:08.000000000","message":"So... this is the actual way of defining abstract classes I knew on Python. Maybe I am missing something? I\u0027ll check docs to double check :)","commit_id":"7c1c585d00bba6cafb94724b7a0593cfa49930a0"}],"manila/share/drivers/cephfs/client/client_cephmgr.py":[{"author":{"_account_id":31638,"name":"Jos Collin","email":"jcollin@redhat.com","username":"jcollin"},"change_message_id":"2b804e02988c41d6eacfaf004de4849ad08bb120","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        # group_name \u003d group_name"},{"line_number":100,"context_line":"        # --force"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        utils.execute(\"ceph fs subvolume rm %s %s\" % (vol_name, subvol_name))"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def purge_volume(self):"},{"line_number":105,"context_line":"        # FIXME(vkmc) Not yet implemented in the"}],"source_content_type":"text/x-python","patch_set":10,"id":"df33271e_e99c045f","line":102,"updated":"2020-04-06 09:50:23.000000000","message":"How to create or rm a subvolume/snapshot in a group?","commit_id":"1aede7e9efe58bb165c9c6b3d889a151d7a10dd3"}],"manila/share/drivers/cephfs/driver.py":[{"author":{"_account_id":31638,"name":"Jos Collin","email":"jcollin@redhat.com","username":"jcollin"},"change_message_id":"f40634dfa77a5365889491dd48c582262dce24d0","unresolved":false,"context_lines":[{"line_number":107,"context_line":"CONF \u003d cfg.CONF"},{"line_number":108,"context_line":"CONF.register_opts(cephfs_opts)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"CEPH_CLIENT_LEGACY \u003d [\u0027jewel\u0027, \u0027luminous\u0027, \u0027mimic\u0027]"},{"line_number":111,"context_line":"CEPH_CLIENT_MGR \u003d [\u0027nautilus\u0027]"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_dc89a3c8","line":110,"updated":"2020-02-18 07:25:30.000000000","message":"Nit: The term \u0027LEGACY\u0027 gives a first impression that you are going to use an Adapter in the design, but my further analysis reveals that it\u0027s not.","commit_id":"7c1c585d00bba6cafb94724b7a0593cfa49930a0"},{"author":{"_account_id":31638,"name":"Jos Collin","email":"jcollin@redhat.com","username":"jcollin"},"change_message_id":"e670911c7a7887d55eaee4cfcae9c46d3ec683b5","unresolved":false,"context_lines":[{"line_number":107,"context_line":"CONF \u003d cfg.CONF"},{"line_number":108,"context_line":"CONF.register_opts(cephfs_opts)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"CEPH_CLIENT_LEGACY \u003d [\u0027jewel\u0027, \u0027luminous\u0027, \u0027mimic\u0027]"},{"line_number":111,"context_line":"CEPH_CLIENT_MGR \u003d [\u0027nautilus\u0027]"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_dd950b33","line":110,"in_reply_to":"3fa7e38b_53c4b961","updated":"2020-02-19 04:08:33.000000000","message":"To avoid confusion, these are basically Ceph release code names - CEPH_CLIENT_LEGACY and CEPH_CLIENT_MGR. I\u0027m thinking  CEPH_VOLUME_CLIENT, if that\u0027s appropriate from Manila perspective  :)","commit_id":"7c1c585d00bba6cafb94724b7a0593cfa49930a0"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c8e02412b408f300593be435da9e23ff59ad4c63","unresolved":false,"context_lines":[{"line_number":107,"context_line":"CONF \u003d cfg.CONF"},{"line_number":108,"context_line":"CONF.register_opts(cephfs_opts)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"CEPH_CLIENT_LEGACY \u003d [\u0027jewel\u0027, \u0027luminous\u0027, \u0027mimic\u0027]"},{"line_number":111,"context_line":"CEPH_CLIENT_MGR \u003d [\u0027nautilus\u0027]"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_53c4b961","line":110,"in_reply_to":"3fa7e38b_dc89a3c8","updated":"2020-02-18 18:01:08.000000000","message":"Good point. I called it legacy just because it is the client we are using for versions that are \u003c Nautilus. Any suggestion on a better naming?","commit_id":"7c1c585d00bba6cafb94724b7a0593cfa49930a0"},{"author":{"_account_id":31638,"name":"Jos Collin","email":"jcollin@redhat.com","username":"jcollin"},"change_message_id":"f40634dfa77a5365889491dd48c582262dce24d0","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    if codename in CEPH_CLIENT_LEGACY:"},{"line_number":123,"context_line":"        client \u003d client_legacy.ClientLegacy(auth_id, conf_path, cluster_name,"},{"line_number":124,"context_line":"                                            volume_prefix)"},{"line_number":125,"context_line":"    elif codename in CEPH_CLIENT_MGR:"},{"line_number":126,"context_line":"        client \u003d client_cephmgr.ClientCephMgr()"},{"line_number":127,"context_line":"    else:"},{"line_number":128,"context_line":"        raise exception.ManilaException("}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_7ca74fbd","line":125,"updated":"2020-02-18 07:25:30.000000000","message":"Then add octopus too in `CEPH_CLIENT_MGR`? Or use a meaningful name like `CEPH_CLIENT_MGR_SUPPORTED_VERSIONS`?","commit_id":"7c1c585d00bba6cafb94724b7a0593cfa49930a0"},{"author":{"_account_id":31638,"name":"Jos Collin","email":"jcollin@redhat.com","username":"jcollin"},"change_message_id":"e670911c7a7887d55eaee4cfcae9c46d3ec683b5","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    if codename in CEPH_CLIENT_LEGACY:"},{"line_number":123,"context_line":"        client \u003d client_legacy.ClientLegacy(auth_id, conf_path, cluster_name,"},{"line_number":124,"context_line":"                                            volume_prefix)"},{"line_number":125,"context_line":"    elif codename in CEPH_CLIENT_MGR:"},{"line_number":126,"context_line":"        client \u003d client_cephmgr.ClientCephMgr()"},{"line_number":127,"context_line":"    else:"},{"line_number":128,"context_line":"        raise exception.ManilaException("}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_bd05af6a","line":125,"in_reply_to":"3fa7e38b_53891927","updated":"2020-02-19 04:08:33.000000000","message":"I think we should add it, as Octopus would be released soon. I also think since this is a new thing in Manila, Manila should focus on Octopus instead of Nautilus to be latest. What do you think about that?","commit_id":"7c1c585d00bba6cafb94724b7a0593cfa49930a0"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c8e02412b408f300593be435da9e23ff59ad4c63","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    if codename in CEPH_CLIENT_LEGACY:"},{"line_number":123,"context_line":"        client \u003d client_legacy.ClientLegacy(auth_id, conf_path, cluster_name,"},{"line_number":124,"context_line":"                                            volume_prefix)"},{"line_number":125,"context_line":"    elif codename in CEPH_CLIENT_MGR:"},{"line_number":126,"context_line":"        client \u003d client_cephmgr.ClientCephMgr()"},{"line_number":127,"context_line":"    else:"},{"line_number":128,"context_line":"        raise exception.ManilaException("}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_53891927","line":125,"in_reply_to":"3fa7e38b_7ca74fbd","updated":"2020-02-18 18:01:08.000000000","message":"Not sure what is the status of implementation of the cephmgr vol client in Octopus. If we can use it instead of the ceph_volume_client, then we should add it.","commit_id":"7c1c585d00bba6cafb94724b7a0593cfa49930a0"},{"author":{"_account_id":31638,"name":"Jos Collin","email":"jcollin@redhat.com","username":"jcollin"},"change_message_id":"f40634dfa77a5365889491dd48c582262dce24d0","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        # NOTE(vkmc) For newer deploys we will get a wrapper for"},{"line_number":238,"context_line":"        # the ceph-mgr vol client, for older deploys (before nautilus)"},{"line_number":239,"context_line":"        # we will get a wrapper for ceph_volume_lib"},{"line_number":240,"context_line":"        self._volume_client \u003d get_ceph_client(codename, auth_id,"},{"line_number":241,"context_line":"                                              conf_path, cluster_name,"},{"line_number":242,"context_line":"                                              volume_prefix\u003dvolume_prefix)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_5cde1310","line":239,"updated":"2020-02-18 07:25:30.000000000","message":"Unnecessary comment. This is understood here.","commit_id":"7c1c585d00bba6cafb94724b7a0593cfa49930a0"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c8e02412b408f300593be435da9e23ff59ad4c63","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        # NOTE(vkmc) For newer deploys we will get a wrapper for"},{"line_number":238,"context_line":"        # the ceph-mgr vol client, for older deploys (before nautilus)"},{"line_number":239,"context_line":"        # we will get a wrapper for ceph_volume_lib"},{"line_number":240,"context_line":"        self._volume_client \u003d get_ceph_client(codename, auth_id,"},{"line_number":241,"context_line":"                                              conf_path, cluster_name,"},{"line_number":242,"context_line":"                                              volume_prefix\u003dvolume_prefix)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_0287c9b5","line":239,"in_reply_to":"3fa7e38b_5cde1310","updated":"2020-02-18 18:01:08.000000000","message":"Sure, will remove","commit_id":"7c1c585d00bba6cafb94724b7a0593cfa49930a0"},{"author":{"_account_id":31638,"name":"Jos Collin","email":"jcollin@redhat.com","username":"jcollin"},"change_message_id":"f40634dfa77a5365889491dd48c582262dce24d0","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        self._volume_client \u003d get_ceph_client(codename, auth_id,"},{"line_number":241,"context_line":"                                              conf_path, cluster_name,"},{"line_number":242,"context_line":"                                              volume_prefix\u003dvolume_prefix)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        LOG.info(\"[%(be)s}] Ceph client found, connecting...\","},{"line_number":245,"context_line":"                 {\"be\": self.backend_name})"},{"line_number":246,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_fc749fcf","line":243,"updated":"2020-02-18 07:25:30.000000000","message":"Catch the exception here and avoid wrong log info.","commit_id":"7c1c585d00bba6cafb94724b7a0593cfa49930a0"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c8e02412b408f300593be435da9e23ff59ad4c63","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        self._volume_client \u003d get_ceph_client(codename, auth_id,"},{"line_number":241,"context_line":"                                              conf_path, cluster_name,"},{"line_number":242,"context_line":"                                              volume_prefix\u003dvolume_prefix)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        LOG.info(\"[%(be)s}] Ceph client found, connecting...\","},{"line_number":245,"context_line":"                 {\"be\": self.backend_name})"},{"line_number":246,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_427dc1c1","line":243,"in_reply_to":"3fa7e38b_fc749fcf","updated":"2020-02-18 18:01:08.000000000","message":"Sure, I could move this to the client directly","commit_id":"7c1c585d00bba6cafb94724b7a0593cfa49930a0"}]}