)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"eefc19275c5127a298f266c11e7bf052f1463ce4","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially-implements: bp create-share-from-snapshot-in-another-pool-or-backend"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: Iece5bc2c1aa6485f3533711baf514bb852357820"},{"line_number":15,"context_line":"Depends-On: I15311089c45be1574857d46caa073e89424e716d"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I124803734c81d3630c5147f5f3bb75724489c929"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"df33271e_9abc3c07","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":53},"updated":"2020-04-09 03:49:17.000000000","message":"Andre, please remove this 2 dependencies in a next PS. Thanks!","commit_id":"6ce8a5f9a2bcd6f895d4992c3090c119448ec27e"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ddc1912324ad9b8cb3c21657112b24bfdaa7f1f5","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially-implements: bp create-share-from-snapshot-in-another-pool-or-backend"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: Iece5bc2c1aa6485f3533711baf514bb852357820"},{"line_number":15,"context_line":"Depends-On: I15311089c45be1574857d46caa073e89424e716d"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I124803734c81d3630c5147f5f3bb75724489c929"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"df33271e_c18b6765","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":53},"in_reply_to":"df33271e_9abc3c07","updated":"2020-04-09 20:24:20.000000000","message":"Done","commit_id":"6ce8a5f9a2bcd6f895d4992c3090c119448ec27e"}],"contrib/ci/post_test_hook.sh":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"260c1439886d592e1b19d73625951d38cab9b918","unresolved":false,"context_lines":[{"line_number":228,"context_line":"    RUN_MANILA_HOST_ASSISTED_MIGRATION_TESTS\u003dTrue"},{"line_number":229,"context_line":"    RUN_MANILA_DRIVER_ASSISTED_MIGRATION_TESTS\u003dTrue"},{"line_number":230,"context_line":"    RUN_MANILA_REPLICATION_TESTS\u003dTrue"},{"line_number":231,"context_line":"    RUN_MANILA_CREATE_SHARE_FROM_SNAPSHOT_IN_ANOTHER_POOL_OR_AZ_TESTS\u003dTrue"},{"line_number":232,"context_line":"    iniset $TEMPEST_CONFIG share enable_ip_rules_for_protocols \u0027nfs\u0027"},{"line_number":233,"context_line":"    iniset $TEMPEST_CONFIG share enable_user_rules_for_protocols \u0027\u0027"},{"line_number":234,"context_line":"    iniset $TEMPEST_CONFIG share enable_cert_rules_for_protocols \u0027\u0027"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1fa4df85_09d0a0c8","line":231,"range":{"start_line":231,"start_character":4,"end_line":231,"end_character":74},"updated":"2020-03-06 20:24:34.000000000","message":"try this:\ninitset $TEMPEST_CONFIG run_create_share_from_snapshot_in_another_pool_or_az_tests True","commit_id":"afd32e847c3b874fa06c1d9c76027ec0fc958058"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"dfdef95eed8c93bfa08e54f9c7b38eb6e62f28ae","unresolved":false,"context_lines":[{"line_number":228,"context_line":"    RUN_MANILA_HOST_ASSISTED_MIGRATION_TESTS\u003dTrue"},{"line_number":229,"context_line":"    RUN_MANILA_DRIVER_ASSISTED_MIGRATION_TESTS\u003dTrue"},{"line_number":230,"context_line":"    RUN_MANILA_REPLICATION_TESTS\u003dTrue"},{"line_number":231,"context_line":"    RUN_MANILA_CREATE_SHARE_FROM_SNAPSHOT_IN_ANOTHER_POOL_OR_AZ_TESTS\u003dTrue"},{"line_number":232,"context_line":"    iniset $TEMPEST_CONFIG share enable_ip_rules_for_protocols \u0027nfs\u0027"},{"line_number":233,"context_line":"    iniset $TEMPEST_CONFIG share enable_user_rules_for_protocols \u0027\u0027"},{"line_number":234,"context_line":"    iniset $TEMPEST_CONFIG share enable_cert_rules_for_protocols \u0027\u0027"}],"source_content_type":"text/x-sh","patch_set":4,"id":"df33271e_474b3486","line":231,"range":{"start_line":231,"start_character":74,"end_line":231,"end_character":74},"updated":"2020-04-07 17:58:39.000000000","message":"Remove this line if you are going to keep 247.  Or drop 247 and add a lines to (1) init RUN_MANILA_CREATE_SHARE_FROM_SNAPSHOT_IN_ANOTHER_POOLOR_AZ_TESTS to false, earlier, for all drivers, and (2) iniset tempest config to the value of this variable more towards the end (somewhere around line 295ff).","commit_id":"a639713f8fd714ee38a55047cab9bf1a7ffafa3c"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"2d610f06d8882be8fb25020a8175f5512084d77c","unresolved":false,"context_lines":[{"line_number":228,"context_line":"    RUN_MANILA_HOST_ASSISTED_MIGRATION_TESTS\u003dTrue"},{"line_number":229,"context_line":"    RUN_MANILA_DRIVER_ASSISTED_MIGRATION_TESTS\u003dTrue"},{"line_number":230,"context_line":"    RUN_MANILA_REPLICATION_TESTS\u003dTrue"},{"line_number":231,"context_line":"    RUN_MANILA_CREATE_SHARE_FROM_SNAPSHOT_IN_ANOTHER_POOL_OR_AZ_TESTS\u003dTrue"},{"line_number":232,"context_line":"    iniset $TEMPEST_CONFIG share enable_ip_rules_for_protocols \u0027nfs\u0027"},{"line_number":233,"context_line":"    iniset $TEMPEST_CONFIG share enable_user_rules_for_protocols \u0027\u0027"},{"line_number":234,"context_line":"    iniset $TEMPEST_CONFIG share enable_cert_rules_for_protocols \u0027\u0027"}],"source_content_type":"text/x-sh","patch_set":4,"id":"df33271e_b777b73a","line":231,"range":{"start_line":231,"start_character":74,"end_line":231,"end_character":74},"in_reply_to":"df33271e_474b3486","updated":"2020-04-08 23:14:25.000000000","message":"Hi Tom, I removed the line 231. Thank you for the comment.","commit_id":"a639713f8fd714ee38a55047cab9bf1a7ffafa3c"}],"contrib/ci/pre_test_hook.sh":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"dfdef95eed8c93bfa08e54f9c7b38eb6e62f28ae","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    MANILA_SERVICE_IMAGE_ENABLED\u003dTrue"},{"line_number":159,"context_line":"    echo \"SHARE_DRIVER\u003dmanila.share.drivers.zfsonlinux.driver.ZFSonLinuxShareDriver\" \u003e\u003e $localconf"},{"line_number":160,"context_line":"    echo \"RUN_MANILA_REPLICATION_TESTS\u003dTrue\" \u003e\u003e $localconf"},{"line_number":161,"context_line":"    # Enable the use scheduler for the create share from snapshot"},{"line_number":162,"context_line":"    echo \"MANILA_USE_SCHEDULER_CREATING_SHARE_FROM_SNAPSHOT\u003dTrue\" \u003e\u003e $localconf"},{"line_number":163,"context_line":"    # Set the replica_state_update_interval to 60 seconds to make"},{"line_number":164,"context_line":"    # replication tests run faster. The default is 300, which is greater than"}],"source_content_type":"text/x-sh","patch_set":4,"id":"df33271e_2791d047","line":161,"range":{"start_line":161,"start_character":6,"end_line":161,"end_character":65},"updated":"2020-04-07 17:58:39.000000000","message":"Suggest:\n   # Enable using the scheduler when creating a share from snapshot","commit_id":"a639713f8fd714ee38a55047cab9bf1a7ffafa3c"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"2d610f06d8882be8fb25020a8175f5512084d77c","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    MANILA_SERVICE_IMAGE_ENABLED\u003dTrue"},{"line_number":159,"context_line":"    echo \"SHARE_DRIVER\u003dmanila.share.drivers.zfsonlinux.driver.ZFSonLinuxShareDriver\" \u003e\u003e $localconf"},{"line_number":160,"context_line":"    echo \"RUN_MANILA_REPLICATION_TESTS\u003dTrue\" \u003e\u003e $localconf"},{"line_number":161,"context_line":"    # Enable the use scheduler for the create share from snapshot"},{"line_number":162,"context_line":"    echo \"MANILA_USE_SCHEDULER_CREATING_SHARE_FROM_SNAPSHOT\u003dTrue\" \u003e\u003e $localconf"},{"line_number":163,"context_line":"    # Set the replica_state_update_interval to 60 seconds to make"},{"line_number":164,"context_line":"    # replication tests run faster. The default is 300, which is greater than"}],"source_content_type":"text/x-sh","patch_set":4,"id":"df33271e_d7919b48","line":161,"range":{"start_line":161,"start_character":6,"end_line":161,"end_character":65},"in_reply_to":"df33271e_2791d047","updated":"2020-04-08 23:14:25.000000000","message":"Done. Thank you!","commit_id":"a639713f8fd714ee38a55047cab9bf1a7ffafa3c"}],"devstack/plugin.sh":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a107c9defae29edbe961ea9007031068bcbb28cd","unresolved":false,"context_lines":[{"line_number":659,"context_line":"                # Give ssh user sudo access"},{"line_number":660,"context_line":"                echo \"$MANILA_ZFSONLINUX_SSH_USERNAME ALL\u003d(ALL) NOPASSWD: ALL\" | sudo tee -a /etc/sudoers \u003e /dev/null"},{"line_number":661,"context_line":"                iniset $MANILA_CONF DEFAULT data_node_access_ips $MANILA_ZFSONLINUX_SERVICE_IP"},{"line_number":662,"context_line":"                iniset $MANILA_CONF DEFAULT use_scheduler_creating_share_from_snapshot $MANILA_USE_SCHEDULER_CREATING_SHARE_FROM_SNAPSHOT"},{"line_number":663,"context_line":"            fi"},{"line_number":664,"context_line":"        fi"},{"line_number":665,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"1fa4df85_60032b75","line":662,"range":{"start_line":662,"start_character":24,"end_line":662,"end_character":35},"updated":"2020-03-11 17:00:13.000000000","message":"I think that we should move this to the manila.conf default configs, and all jobs will config this with the default value, which is False.\nAlso, move this config to a new change since its not tied to ZFSonLinux","commit_id":"cb7d33879889bbfe7d1d49e6813457a3f355962b"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"11e54c6fce85d31c934b8c17db78fec0a2ef5afe","unresolved":false,"context_lines":[{"line_number":659,"context_line":"                # Give ssh user sudo access"},{"line_number":660,"context_line":"                echo \"$MANILA_ZFSONLINUX_SSH_USERNAME ALL\u003d(ALL) NOPASSWD: ALL\" | sudo tee -a /etc/sudoers \u003e /dev/null"},{"line_number":661,"context_line":"                iniset $MANILA_CONF DEFAULT data_node_access_ips $MANILA_ZFSONLINUX_SERVICE_IP"},{"line_number":662,"context_line":"                iniset $MANILA_CONF DEFAULT use_scheduler_creating_share_from_snapshot $MANILA_USE_SCHEDULER_CREATING_SHARE_FROM_SNAPSHOT"},{"line_number":663,"context_line":"            fi"},{"line_number":664,"context_line":"        fi"},{"line_number":665,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"1fa4df85_c02c5fae","line":662,"range":{"start_line":662,"start_character":24,"end_line":662,"end_character":35},"in_reply_to":"1fa4df85_60032b75","updated":"2020-03-11 17:48:48.000000000","message":"Sure, thank you Douglas. Done!","commit_id":"cb7d33879889bbfe7d1d49e6813457a3f355962b"}],"devstack/settings":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a107c9defae29edbe961ea9007031068bcbb28cd","unresolved":false,"context_lines":[{"line_number":126,"context_line":"MANILA_SERVICE_INSTANCE_USER\u003d${MANILA_SERVICE_INSTANCE_USER:-\"manila\"}"},{"line_number":127,"context_line":"MANILA_SERVICE_IMAGE_URL\u003d${MANILA_SERVICE_IMAGE_URL:-\"http://tarballs.openstack.org/manila-image-elements/images/manila-service-image-master.qcow2\"}"},{"line_number":128,"context_line":"MANILA_SERVICE_IMAGE_NAME\u003d${MANILA_SERVICE_IMAGE_NAME:-\"manila-service-image-master\"}"},{"line_number":129,"context_line":"MANILA_USE_SCHEDULER_CREATING_SHARE_FROM_SNAPSHOT\u003d${MANILA_USE_SCHEDULER_CREATING_SHARE_FROM_SNAPSHOT:-\"False\"}"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"# Third party CI Vendors should set this to false to skip the service image download"},{"line_number":132,"context_line":"MANILA_SERVICE_IMAGE_ENABLED\u003d$(trueorfalse True MANILA_SERVICE_IMAGE_ENABLED)"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1fa4df85_a02e03f8","line":129,"range":{"start_line":129,"start_character":0,"end_line":129,"end_character":111},"updated":"2020-03-11 17:00:13.000000000","message":"Lets move this to a different change since other drivers may depend on this to test the feature.","commit_id":"cb7d33879889bbfe7d1d49e6813457a3f355962b"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"11e54c6fce85d31c934b8c17db78fec0a2ef5afe","unresolved":false,"context_lines":[{"line_number":126,"context_line":"MANILA_SERVICE_INSTANCE_USER\u003d${MANILA_SERVICE_INSTANCE_USER:-\"manila\"}"},{"line_number":127,"context_line":"MANILA_SERVICE_IMAGE_URL\u003d${MANILA_SERVICE_IMAGE_URL:-\"http://tarballs.openstack.org/manila-image-elements/images/manila-service-image-master.qcow2\"}"},{"line_number":128,"context_line":"MANILA_SERVICE_IMAGE_NAME\u003d${MANILA_SERVICE_IMAGE_NAME:-\"manila-service-image-master\"}"},{"line_number":129,"context_line":"MANILA_USE_SCHEDULER_CREATING_SHARE_FROM_SNAPSHOT\u003d${MANILA_USE_SCHEDULER_CREATING_SHARE_FROM_SNAPSHOT:-\"False\"}"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"# Third party CI Vendors should set this to false to skip the service image download"},{"line_number":132,"context_line":"MANILA_SERVICE_IMAGE_ENABLED\u003d$(trueorfalse True MANILA_SERVICE_IMAGE_ENABLED)"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1fa4df85_1b3c26be","line":129,"range":{"start_line":129,"start_character":0,"end_line":129,"end_character":111},"in_reply_to":"1fa4df85_a02e03f8","updated":"2020-03-11 17:48:48.000000000","message":"sure.","commit_id":"cb7d33879889bbfe7d1d49e6813457a3f355962b"}],"manila/share/drivers/zfsonlinux/driver.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"dfdef95eed8c93bfa08e54f9c7b38eb6e62f28ae","unresolved":false,"context_lines":[{"line_number":579,"context_line":"                {\u0027id\u0027: snapshot[\u0027id\u0027], \u0027name\u0027: snapshot_name})"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"    @ensure_share_server_not_provided"},{"line_number":582,"context_line":"    def create_share_from_snapshot(self, context, share, snapshot,"},{"line_number":583,"context_line":"                                   share_server\u003dNone):"},{"line_number":584,"context_line":"        \"\"\"Is called to create a share from snapshot.\"\"\""},{"line_number":585,"context_line":"        backend_name \u003d share_utils.extract_host("}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_0d2e6ba4","line":582,"range":{"start_line":582,"start_character":8,"end_line":582,"end_character":36},"updated":"2020-04-07 17:58:39.000000000","message":"I suspect this code would be cleaner and simpler if you just worked with src_backend_name, src_backend_pool_name, and src_backend_ssh_cmd (or src dict with these fields) and dst_backendname, dst_backend_pool_name, and dst_backend_ssh_cmd in every case.  (dst fields are currently just backend_name, pool_name, ssh_cmd).\n\nIn the case of same pool and back end the fields will match.\n\nWould make fewer lines and make cleaner self.execute invocation.","commit_id":"a639713f8fd714ee38a55047cab9bf1a7ffafa3c"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"2d610f06d8882be8fb25020a8175f5512084d77c","unresolved":false,"context_lines":[{"line_number":579,"context_line":"                {\u0027id\u0027: snapshot[\u0027id\u0027], \u0027name\u0027: snapshot_name})"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"    @ensure_share_server_not_provided"},{"line_number":582,"context_line":"    def create_share_from_snapshot(self, context, share, snapshot,"},{"line_number":583,"context_line":"                                   share_server\u003dNone):"},{"line_number":584,"context_line":"        \"\"\"Is called to create a share from snapshot.\"\"\""},{"line_number":585,"context_line":"        backend_name \u003d share_utils.extract_host("}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_77cb6f52","line":582,"range":{"start_line":582,"start_character":8,"end_line":582,"end_character":36},"in_reply_to":"df33271e_0d2e6ba4","updated":"2020-04-08 23:14:25.000000000","message":"Hi Tom, in the new patch set I tried rename the variables as you suggest. Thank you!","commit_id":"a639713f8fd714ee38a55047cab9bf1a7ffafa3c"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"68c68b2b874cceef14943e8696df91d863f18c02","unresolved":false,"context_lines":[{"line_number":596,"context_line":"            \u0027host\u0027: self.service_ip,"},{"line_number":597,"context_line":"        }"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"        dst_backend_pool_name \u003d share_utils.extract_host(share[\u0027host\u0027], level\u003d\u0027pool\u0027)"},{"line_number":600,"context_line":"        options \u003d self._get_dataset_creation_options(share, is_readonly\u003dFalse)"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"        self.private_storage.update("}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_cf9452eb","line":599,"updated":"2020-04-08 18:00:44.000000000","message":"pep8: E501 line too long (85 \u003e 79 characters)","commit_id":"8f3166db2bb8df7cf48b17a74791e71b0627cfdc"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"68c68b2b874cceef14943e8696df91d863f18c02","unresolved":false,"context_lines":[{"line_number":611,"context_line":""},{"line_number":612,"context_line":"        # NOTE(andrebeltrami): Implementing the support for create share"},{"line_number":613,"context_line":"        # from snapshot in different backends in different hosts"},{"line_number":614,"context_line":"        if dst_backend_name is not None and dst_backend_name !\u003d src_backend_name:"},{"line_number":615,"context_line":"            src_config \u003d get_backend_configuration(src_backend_name)"},{"line_number":616,"context_line":"            src_backend_ssh_cmd \u003d \u0027%(username)s@%(host)s\u0027 % {"},{"line_number":617,"context_line":"                \u0027username\u0027: src_config.zfs_ssh_username,"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_af974eeb","line":614,"updated":"2020-04-08 18:00:44.000000000","message":"pep8: E501 line too long (81 \u003e 79 characters)","commit_id":"8f3166db2bb8df7cf48b17a74791e71b0627cfdc"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0d0ad08a0a4ded1b7645e0a0387ed5692b91a734","unresolved":false,"context_lines":[{"line_number":609,"context_line":"            }"},{"line_number":610,"context_line":"        )"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"        # NOTE(andrebeltrami): Implementing the support for create share"},{"line_number":613,"context_line":"        # from snapshot in different backends in different hosts"},{"line_number":614,"context_line":"        if dst_backend_name is not None and dst_backend_name !\u003d src_backend_name:"},{"line_number":615,"context_line":"            src_config \u003d get_backend_configuration(src_backend_name)"},{"line_number":616,"context_line":"            src_backend_ssh_cmd \u003d \u0027%(username)s@%(host)s\u0027 % {"},{"line_number":617,"context_line":"                \u0027username\u0027: src_config.zfs_ssh_username,"},{"line_number":618,"context_line":"                \u0027host\u0027: src_config.zfs_service_ip,"},{"line_number":619,"context_line":"            }"},{"line_number":620,"context_line":"            self.execute("},{"line_number":621,"context_line":"                # NOTE(vponomaryov): SSH is used as workaround for \u0027execute\u0027"},{"line_number":622,"context_line":"                # implementation restriction that does not support usage"},{"line_number":623,"context_line":"                # of \u0027|\u0027."},{"line_number":624,"context_line":"                \u0027ssh\u0027, src_backend_ssh_cmd,"},{"line_number":625,"context_line":"                \u0027sudo\u0027, \u0027zfs\u0027, \u0027send\u0027, \u0027-vD\u0027, src_snapshot_name, \u0027|\u0027,"},{"line_number":626,"context_line":"                \u0027ssh\u0027, dst_backend_ssh_cmd,"},{"line_number":627,"context_line":"                \u0027sudo\u0027, \u0027zfs\u0027, \u0027receive\u0027, \u0027-v\u0027, dataset_name,"},{"line_number":628,"context_line":"            )"},{"line_number":629,"context_line":"        else:"},{"line_number":630,"context_line":"            self.execute("},{"line_number":631,"context_line":"                # NOTE(vponomaryov): SSH is used as workaround for \u0027execute\u0027"},{"line_number":632,"context_line":"                # implementation restriction that does not support usage"},{"line_number":633,"context_line":"                # of \u0027|\u0027."},{"line_number":634,"context_line":"                \u0027ssh\u0027, dst_backend_ssh_cmd,"},{"line_number":635,"context_line":"                \u0027sudo\u0027, \u0027zfs\u0027, \u0027send\u0027, \u0027-vD\u0027, src_snapshot_name, \u0027|\u0027,"},{"line_number":636,"context_line":"                \u0027sudo\u0027, \u0027zfs\u0027, \u0027receive\u0027, \u0027-v\u0027, dataset_name,"},{"line_number":637,"context_line":"            )"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"        # Apply options based on used share type that may differ from"},{"line_number":640,"context_line":"        # one used for original share."}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_b72177fe","line":637,"range":{"start_line":612,"start_character":0,"end_line":637,"end_character":13},"updated":"2020-04-08 12:38:37.000000000","message":"The simplification I\u0027m suggesting is to just do:\n   src_config \u003d ...\n   src_backend_ssh_cmd \u003d ....\n   self.execute(\n     \u0027ssh\u0027, src_backend_cmd,\n      ...\n      \u0027ssh\u0027, dst_backend_cmd,\n      ....\n     )\nin every case, irrespective of whether src backend and dst backend are the same.\n\nIf this will work it would be simpler code.","commit_id":"8f3166db2bb8df7cf48b17a74791e71b0627cfdc"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"2d610f06d8882be8fb25020a8175f5512084d77c","unresolved":false,"context_lines":[{"line_number":609,"context_line":"            }"},{"line_number":610,"context_line":"        )"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"        # NOTE(andrebeltrami): Implementing the support for create share"},{"line_number":613,"context_line":"        # from snapshot in different backends in different hosts"},{"line_number":614,"context_line":"        if dst_backend_name is not None and dst_backend_name !\u003d src_backend_name:"},{"line_number":615,"context_line":"            src_config \u003d get_backend_configuration(src_backend_name)"},{"line_number":616,"context_line":"            src_backend_ssh_cmd \u003d \u0027%(username)s@%(host)s\u0027 % {"},{"line_number":617,"context_line":"                \u0027username\u0027: src_config.zfs_ssh_username,"},{"line_number":618,"context_line":"                \u0027host\u0027: src_config.zfs_service_ip,"},{"line_number":619,"context_line":"            }"},{"line_number":620,"context_line":"            self.execute("},{"line_number":621,"context_line":"                # NOTE(vponomaryov): SSH is used as workaround for \u0027execute\u0027"},{"line_number":622,"context_line":"                # implementation restriction that does not support usage"},{"line_number":623,"context_line":"                # of \u0027|\u0027."},{"line_number":624,"context_line":"                \u0027ssh\u0027, src_backend_ssh_cmd,"},{"line_number":625,"context_line":"                \u0027sudo\u0027, \u0027zfs\u0027, \u0027send\u0027, \u0027-vD\u0027, src_snapshot_name, \u0027|\u0027,"},{"line_number":626,"context_line":"                \u0027ssh\u0027, dst_backend_ssh_cmd,"},{"line_number":627,"context_line":"                \u0027sudo\u0027, \u0027zfs\u0027, \u0027receive\u0027, \u0027-v\u0027, dataset_name,"},{"line_number":628,"context_line":"            )"},{"line_number":629,"context_line":"        else:"},{"line_number":630,"context_line":"            self.execute("},{"line_number":631,"context_line":"                # NOTE(vponomaryov): SSH is used as workaround for \u0027execute\u0027"},{"line_number":632,"context_line":"                # implementation restriction that does not support usage"},{"line_number":633,"context_line":"                # of \u0027|\u0027."},{"line_number":634,"context_line":"                \u0027ssh\u0027, dst_backend_ssh_cmd,"},{"line_number":635,"context_line":"                \u0027sudo\u0027, \u0027zfs\u0027, \u0027send\u0027, \u0027-vD\u0027, src_snapshot_name, \u0027|\u0027,"},{"line_number":636,"context_line":"                \u0027sudo\u0027, \u0027zfs\u0027, \u0027receive\u0027, \u0027-v\u0027, dataset_name,"},{"line_number":637,"context_line":"            )"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"        # Apply options based on used share type that may differ from"},{"line_number":640,"context_line":"        # one used for original share."}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_37fa7074","line":637,"range":{"start_line":612,"start_character":0,"end_line":637,"end_character":13},"in_reply_to":"df33271e_b72177fe","updated":"2020-04-08 23:14:25.000000000","message":"Hi Tom, I will try the modification that you suggest. Thank you!","commit_id":"8f3166db2bb8df7cf48b17a74791e71b0627cfdc"}],"manila/tests/share/drivers/zfsonlinux/test_driver.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"dbd077131184dce39be59bdf8479dd853b19fdda","unresolved":false,"context_lines":[{"line_number":844,"context_line":"            snap_instance[\u0027share_instance_id\u0027],"},{"line_number":845,"context_line":"            {\u0027dataset_name\u0027: dataset_name})"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"        if dst_backend_name \u003d\u003d src_backend_name:"},{"line_number":848,"context_line":"            self.mock_object("},{"line_number":849,"context_line":"                zfs_driver, \u0027get_backend_configuration\u0027,"},{"line_number":850,"context_line":"                mock.Mock(return_value\u003dtype("},{"line_number":851,"context_line":"                    \u0027FakeConfig\u0027, (object,), {"},{"line_number":852,"context_line":"                        \u0027zfs_ssh_username\u0027: \u0027someuser\u0027,"},{"line_number":853,"context_line":"                        \u0027zfs_service_ip\u0027: \u00272.2.2.2\u0027"},{"line_number":854,"context_line":"                    })))"},{"line_number":855,"context_line":"        else:"},{"line_number":856,"context_line":"            self.mock_object("},{"line_number":857,"context_line":"                zfs_driver, \u0027get_backend_configuration\u0027,"},{"line_number":858,"context_line":"                mock.Mock(return_value\u003dtype("},{"line_number":859,"context_line":"                    \u0027FakeConfig\u0027, (object,), {"},{"line_number":860,"context_line":"                        \u0027zfs_ssh_username\u0027: \u0027someuser2\u0027,"},{"line_number":861,"context_line":"                        \u0027zfs_service_ip\u0027: \u00273.3.3.3\u0027"},{"line_number":862,"context_line":"                    })))"},{"line_number":863,"context_line":""},{"line_number":864,"context_line":"        result \u003d self.driver.create_share_from_snapshot("},{"line_number":865,"context_line":"            context, share, snap_instance, share_server\u003dNone)"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_ab8f3528","line":862,"range":{"start_line":847,"start_character":0,"end_line":862,"end_character":24},"updated":"2020-04-09 01:44:07.000000000","message":"It seems that you are setting different answers for the source share but your test is testing against different destinations. Please fix this.","commit_id":"6ce8a5f9a2bcd6f895d4992c3090c119448ec27e"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ddc1912324ad9b8cb3c21657112b24bfdaa7f1f5","unresolved":false,"context_lines":[{"line_number":844,"context_line":"            snap_instance[\u0027share_instance_id\u0027],"},{"line_number":845,"context_line":"            {\u0027dataset_name\u0027: dataset_name})"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"        if dst_backend_name \u003d\u003d src_backend_name:"},{"line_number":848,"context_line":"            self.mock_object("},{"line_number":849,"context_line":"                zfs_driver, \u0027get_backend_configuration\u0027,"},{"line_number":850,"context_line":"                mock.Mock(return_value\u003dtype("},{"line_number":851,"context_line":"                    \u0027FakeConfig\u0027, (object,), {"},{"line_number":852,"context_line":"                        \u0027zfs_ssh_username\u0027: \u0027someuser\u0027,"},{"line_number":853,"context_line":"                        \u0027zfs_service_ip\u0027: \u00272.2.2.2\u0027"},{"line_number":854,"context_line":"                    })))"},{"line_number":855,"context_line":"        else:"},{"line_number":856,"context_line":"            self.mock_object("},{"line_number":857,"context_line":"                zfs_driver, \u0027get_backend_configuration\u0027,"},{"line_number":858,"context_line":"                mock.Mock(return_value\u003dtype("},{"line_number":859,"context_line":"                    \u0027FakeConfig\u0027, (object,), {"},{"line_number":860,"context_line":"                        \u0027zfs_ssh_username\u0027: \u0027someuser2\u0027,"},{"line_number":861,"context_line":"                        \u0027zfs_service_ip\u0027: \u00273.3.3.3\u0027"},{"line_number":862,"context_line":"                    })))"},{"line_number":863,"context_line":""},{"line_number":864,"context_line":"        result \u003d self.driver.create_share_from_snapshot("},{"line_number":865,"context_line":"            context, share, snap_instance, share_server\u003dNone)"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_a1dd8371","line":862,"range":{"start_line":847,"start_character":0,"end_line":862,"end_character":24},"in_reply_to":"df33271e_ab8f3528","updated":"2020-04-09 20:24:20.000000000","message":"Done","commit_id":"6ce8a5f9a2bcd6f895d4992c3090c119448ec27e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c08804c460ac32d0fe556819435cb948596e5c98","unresolved":false,"context_lines":[{"line_number":877,"context_line":"            self.driver.private_storage.get("},{"line_number":878,"context_line":"                snap_instance[\u0027share_instance_id\u0027], \u0027dataset_name\u0027))"},{"line_number":879,"context_line":"        self.assertEqual("},{"line_number":880,"context_line":"            \u0027someuser@2.2.2.2\u0027,"},{"line_number":881,"context_line":"            self.driver.private_storage.get(share[\u0027id\u0027], \u0027ssh_cmd\u0027))"},{"line_number":882,"context_line":"        self.assertEqual("},{"line_number":883,"context_line":"            \u0027bar\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_a0ee341f","line":880,"updated":"2020-04-08 23:52:39.000000000","message":"This assertEqual will depend on the ddt case being evaluated. Say, if the dst_backend_name !\u003d src_backend_name this assertEqual will fail. Or am I missing something?","commit_id":"6ce8a5f9a2bcd6f895d4992c3090c119448ec27e"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ddc1912324ad9b8cb3c21657112b24bfdaa7f1f5","unresolved":false,"context_lines":[{"line_number":877,"context_line":"            self.driver.private_storage.get("},{"line_number":878,"context_line":"                snap_instance[\u0027share_instance_id\u0027], \u0027dataset_name\u0027))"},{"line_number":879,"context_line":"        self.assertEqual("},{"line_number":880,"context_line":"            \u0027someuser@2.2.2.2\u0027,"},{"line_number":881,"context_line":"            self.driver.private_storage.get(share[\u0027id\u0027], \u0027ssh_cmd\u0027))"},{"line_number":882,"context_line":"        self.assertEqual("},{"line_number":883,"context_line":"            \u0027bar\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_81daff74","line":880,"in_reply_to":"df33271e_6b988d74","updated":"2020-04-09 20:24:20.000000000","message":"Hi all, I think now the test was improved. Thank you!","commit_id":"6ce8a5f9a2bcd6f895d4992c3090c119448ec27e"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"dbd077131184dce39be59bdf8479dd853b19fdda","unresolved":false,"context_lines":[{"line_number":877,"context_line":"            self.driver.private_storage.get("},{"line_number":878,"context_line":"                snap_instance[\u0027share_instance_id\u0027], \u0027dataset_name\u0027))"},{"line_number":879,"context_line":"        self.assertEqual("},{"line_number":880,"context_line":"            \u0027someuser@2.2.2.2\u0027,"},{"line_number":881,"context_line":"            self.driver.private_storage.get(share[\u0027id\u0027], \u0027ssh_cmd\u0027))"},{"line_number":882,"context_line":"        self.assertEqual("},{"line_number":883,"context_line":"            \u0027bar\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_6b988d74","line":880,"in_reply_to":"df33271e_a0ee341f","updated":"2020-04-09 01:44:07.000000000","message":"It seems that the config saved on private_storage is the config for the new share, that is the destination share, and the \u0027ip\u0027 and \u0027user\u0027 are being retrieve from manila config. The confusion is that he shall test against different source backends since his mocks are providing different info for each test. Its working but its not correct I guess.","commit_id":"6ce8a5f9a2bcd6f895d4992c3090c119448ec27e"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"5c96b9af391d0d04bf59d1641cda1aa4b892c9a9","unresolved":false,"context_lines":[{"line_number":887,"context_line":"                mock.call("},{"line_number":888,"context_line":"                    \u0027ssh\u0027, src_ssh_host,"},{"line_number":889,"context_line":"                    \u0027sudo\u0027, \u0027zfs\u0027, \u0027send\u0027, \u0027-vD\u0027, snap_name, \u0027|\u0027,"},{"line_number":890,"context_line":"                    \u0027ssh\u0027, src_ssh_host,"},{"line_number":891,"context_line":"                    \u0027sudo\u0027, \u0027zfs\u0027, \u0027receive\u0027, \u0027-v\u0027,"},{"line_number":892,"context_line":"                    \u0027%s\u0027 % dataset_name),"},{"line_number":893,"context_line":"                mock.call("}],"source_content_type":"text/x-python","patch_set":8,"id":"df33271e_bc5daa16","line":890,"range":{"start_line":890,"start_character":27,"end_line":890,"end_character":39},"updated":"2020-04-09 21:04:00.000000000","message":"dst_ssh_host","commit_id":"324de5062153f0ba99ce9861b1056ed3164e2032"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"6ec26a99d2947b684145184063dc9516a7e9fb36","unresolved":false,"context_lines":[{"line_number":887,"context_line":"                mock.call("},{"line_number":888,"context_line":"                    \u0027ssh\u0027, src_ssh_host,"},{"line_number":889,"context_line":"                    \u0027sudo\u0027, \u0027zfs\u0027, \u0027send\u0027, \u0027-vD\u0027, snap_name, \u0027|\u0027,"},{"line_number":890,"context_line":"                    \u0027ssh\u0027, src_ssh_host,"},{"line_number":891,"context_line":"                    \u0027sudo\u0027, \u0027zfs\u0027, \u0027receive\u0027, \u0027-v\u0027,"},{"line_number":892,"context_line":"                    \u0027%s\u0027 % dataset_name),"},{"line_number":893,"context_line":"                mock.call("}],"source_content_type":"text/x-python","patch_set":8,"id":"df33271e_bceacad4","line":890,"range":{"start_line":890,"start_character":27,"end_line":890,"end_character":39},"in_reply_to":"df33271e_bc5daa16","updated":"2020-04-09 21:17:41.000000000","message":"Looking again, I realize that if it\u0027s not necessary. In PS 9, I removed it.","commit_id":"324de5062153f0ba99ce9861b1056ed3164e2032"}],"releasenotes/notes/zfsonlinux-driver-improvement-create-share-from-snapshot-another-backend-44296f572681be35.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3750ea80caeecc5d17d5fa10a881cc70b7c3754e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"    In this release, the operation create share from snapshot was improved"},{"line_number":4,"context_line":"    in the ZFSonLinux driver. Now, the operator using the ZFSonLinux driver"},{"line_number":5,"context_line":"    can create a share from snapshot in different pools or backends."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df33271e_5098d5be","line":5,"range":{"start_line":5,"start_character":67,"end_line":5,"end_character":68},"updated":"2020-04-09 07:08:21.000000000","message":"by specifying the Manila API configuration option \"[DEFAULT]/use_scheduler_creating_share_from_snapshot\"","commit_id":"6ce8a5f9a2bcd6f895d4992c3090c119448ec27e"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ddc1912324ad9b8cb3c21657112b24bfdaa7f1f5","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"    In this release, the operation create share from snapshot was improved"},{"line_number":4,"context_line":"    in the ZFSonLinux driver. Now, the operator using the ZFSonLinux driver"},{"line_number":5,"context_line":"    can create a share from snapshot in different pools or backends."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df33271e_81483f2d","line":5,"range":{"start_line":5,"start_character":67,"end_line":5,"end_character":68},"in_reply_to":"df33271e_5098d5be","updated":"2020-04-09 20:24:20.000000000","message":"Done.","commit_id":"6ce8a5f9a2bcd6f895d4992c3090c119448ec27e"}]}