)]}'
{"manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"176fb91c28bea96d7d5cd73ed59b05eb217f49f7","unresolved":false,"context_lines":[{"line_number":2225,"context_line":"        # Modify volume properties per share type extra-specs"},{"line_number":2226,"context_line":"        extra_specs \u003d share_types.get_extra_specs_from_share("},{"line_number":2227,"context_line":"            destination_share)"},{"line_number":2228,"context_line":"        extra_specs \u003d self._remap_standard_boolean_extra_specs(extra_specs)"},{"line_number":2229,"context_line":"        self._check_extra_specs_validity(destination_share, extra_specs)"},{"line_number":2230,"context_line":"        provisioning_options \u003d self._get_provisioning_options(extra_specs)"},{"line_number":2231,"context_line":"        qos_policy_group_name \u003d self._modify_or_create_qos_for_existing_share("},{"line_number":2232,"context_line":"            destination_share, extra_specs, vserver, vserver_client)"},{"line_number":2233,"context_line":"        if qos_policy_group_name:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_bf576926","line":2230,"range":{"start_line":2228,"start_character":8,"end_line":2230,"end_character":74},"updated":"2020-03-30 13:20:37.000000000","message":"What do you think about using `provisioning_options \u003d self._get_provisioning_options_for_share(destination_share, vserver, replica\u003dTrue)` ?","commit_id":"9250e02b56fa4a0d93fe4c32cdfac4eceab8d095"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"ecd398f53908be41bfd0c49aad0440c45a47da2d","unresolved":false,"context_lines":[{"line_number":2225,"context_line":"        # Modify volume properties per share type extra-specs"},{"line_number":2226,"context_line":"        extra_specs \u003d share_types.get_extra_specs_from_share("},{"line_number":2227,"context_line":"            destination_share)"},{"line_number":2228,"context_line":"        extra_specs \u003d self._remap_standard_boolean_extra_specs(extra_specs)"},{"line_number":2229,"context_line":"        self._check_extra_specs_validity(destination_share, extra_specs)"},{"line_number":2230,"context_line":"        provisioning_options \u003d self._get_provisioning_options(extra_specs)"},{"line_number":2231,"context_line":"        qos_policy_group_name \u003d self._modify_or_create_qos_for_existing_share("},{"line_number":2232,"context_line":"            destination_share, extra_specs, vserver, vserver_client)"},{"line_number":2233,"context_line":"        if qos_policy_group_name:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_b9b6613d","line":2230,"range":{"start_line":2228,"start_character":8,"end_line":2230,"end_character":74},"in_reply_to":"df33271e_bf576926","updated":"2020-03-30 16:28:18.000000000","message":"Thank you for your suggestion. I really don\u0027t like how `_get_provisioning_options_for_share` creates a qos-policy-group in a method called get_* and we are planning to fix this in a feature refactor. \nSetting replica\u003dTrue will avoid this but, imho this isn\u0027t so clear for who is reading the code. Both ways are acceptable I guess, but Daniel didn\u0027t test with this call.","commit_id":"9250e02b56fa4a0d93fe4c32cdfac4eceab8d095"}]}