)]}'
{"manila/share/drivers/cephfs/driver.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"cba801cf4687eb3632942f83c13087c2d0beb740","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        group \u003d share[\u0027share_group_id\u0027]"},{"line_number":271,"context_line":"        data_isolated \u003d extra_specs.get(\"cephfs:data_isolated\", False)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        namespace_isolated \u003d \u0027--namespace-isolated\u0027 if data_isolated else \u0027\u0027"},{"line_number":274,"context_line":"        group_name \u003d \u0027--group_name\u0027 + group if group else \u0027\u0027"},{"line_number":275,"context_line":"        mode \u003d self.configuration.cephfs_volume_mode"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_bfac3b9f","line":273,"updated":"2020-08-07 19:37:13.000000000","message":"In newer ceph versions we call \"namespace_isolated\" what we used to call \"data_isolated\". We need to continue getting data_isolated from extra_specs for backwards compatibility. Do we also want to look for namespace_isolated?","commit_id":"c8cf90a7d5e791500c8c5e5a51bd4fda0aaa46d5"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"33c2410a8f67fe0ab6c0f9b2d9aa87d59b85d62f","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        group \u003d share[\u0027share_group_id\u0027]"},{"line_number":271,"context_line":"        data_isolated \u003d extra_specs.get(\"cephfs:data_isolated\", False)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        namespace_isolated \u003d \u0027--namespace-isolated\u0027 if data_isolated else \u0027\u0027"},{"line_number":274,"context_line":"        group_name \u003d \u0027--group_name\u0027 + group if group else \u0027\u0027"},{"line_number":275,"context_line":"        mode \u003d self.configuration.cephfs_volume_mode"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_f30787c8","line":273,"updated":"2020-08-19 12:09:21.000000000","message":"ceph_volume_client library creates shares/subvolumes that are RADOS namespace isolated by default. So we always need to set the`--namespace_isolated` flag when creating subvolumes with the ceph-mgr volumes interface.\n\nData isolated option tells the ceph_volume_client to create a separate data pool for a share. Ceph-mgr volumes can\u0027t do that now. Also, creating data pools for each share is not scalable and an option we might want to deprecate. That\u0027s an another discussion though. Maybe for now, setting data isolated can be a no op.","commit_id":"cdedb9ad3982c1fda8f6f2850061023b237a5ae2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"ed8cba39b87106d4ca357980b0bc856f3bba2f57","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        group \u003d share[\u0027share_group_id\u0027]"},{"line_number":271,"context_line":"        data_isolated \u003d extra_specs.get(\"cephfs:data_isolated\", False)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        namespace_isolated \u003d \u0027--namespace-isolated\u0027 if data_isolated else \u0027\u0027"},{"line_number":274,"context_line":"        group_name \u003d \u0027--group_name\u0027 + group if group else \u0027\u0027"},{"line_number":275,"context_line":"        mode \u003d self.configuration.cephfs_volume_mode"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_5911a3ac","line":273,"in_reply_to":"9f560f44_f30787c8","updated":"2020-11-18 00:15:12.000000000","message":"Very well, fixing that, thanks Ramana.","commit_id":"cdedb9ad3982c1fda8f6f2850061023b237a5ae2"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"33c2410a8f67fe0ab6c0f9b2d9aa87d59b85d62f","unresolved":false,"context_lines":[{"line_number":293,"context_line":"                                 \u0027--user\u0027, \u0027manila\u0027)"},{"line_number":294,"context_line":"            path \u003d path[0].rstrip(\"\\n\")"},{"line_number":295,"context_line":"        except processutils.ProcessExecutionError:"},{"line_number":296,"context_line":"            raise"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        mountpath \u003d {\u0027mount_path\u0027: path}"},{"line_number":299,"context_line":"        export_locations \u003d self.protocol_helper.get_export_locations(share,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_5384730c","line":296,"updated":"2020-08-19 12:09:21.000000000","message":"what\u0027s the benefit of just raising again?","commit_id":"cdedb9ad3982c1fda8f6f2850061023b237a5ae2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"ed8cba39b87106d4ca357980b0bc856f3bba2f57","unresolved":false,"context_lines":[{"line_number":293,"context_line":"                                 \u0027--user\u0027, \u0027manila\u0027)"},{"line_number":294,"context_line":"            path \u003d path[0].rstrip(\"\\n\")"},{"line_number":295,"context_line":"        except processutils.ProcessExecutionError:"},{"line_number":296,"context_line":"            raise"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        mountpath \u003d {\u0027mount_path\u0027: path}"},{"line_number":299,"context_line":"        export_locations \u003d self.protocol_helper.get_export_locations(share,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_99221b01","line":296,"in_reply_to":"9f560f44_5384730c","updated":"2020-11-18 00:15:12.000000000","message":"No benefit, we should handle this exception properly, this is just WIP code.","commit_id":"cdedb9ad3982c1fda8f6f2850061023b237a5ae2"}],"manila/tests/share/drivers/cephfs/test_driver.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"cba801cf4687eb3632942f83c13087c2d0beb740","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        (self._driver._volume_client.destroy_snapshot_group."},{"line_number":362,"context_line":"         assert_called_once_with(\"sgid\", \"snapid\"))"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    # def test_delete_driver(self):"},{"line_number":365,"context_line":"    #     # Create share to prompt volume_client construction"},{"line_number":366,"context_line":"    #     self._driver.create_share(self._context,"},{"line_number":367,"context_line":"    #                               self._share)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_9fd5f71e","line":364,"updated":"2020-08-07 19:37:13.000000000","message":"We won\u0027t be using this function anymore so it\u0027s safe to remove this test, will do when we finish porting the whole driver","commit_id":"c8cf90a7d5e791500c8c5e5a51bd4fda0aaa46d5"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"cba801cf4687eb3632942f83c13087c2d0beb740","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        self.assertIsNone(self._driver._volume_client)"},{"line_number":376,"context_line":"        del self._driver"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    # def test_connect_noevict(self):"},{"line_number":379,"context_line":"    #     # When acting as \"admin\", driver should skip evicting"},{"line_number":380,"context_line":"    #     self._driver.configuration.local_conf.set_override(\u0027cephfs_auth_id\u0027,"},{"line_number":381,"context_line":"    #                                                        \"admin\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_ff1eb309","line":378,"updated":"2020-08-07 19:37:13.000000000","message":"We won\u0027t be using this function anymore so it\u0027s safe to remove this test, will do when we finish porting the whole driver","commit_id":"c8cf90a7d5e791500c8c5e5a51bd4fda0aaa46d5"}]}