)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"1c1e0bfb1145f1b77a7c026023c72db4060838e0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"uppon share servers configured with specific NFS max transfer"},{"line_number":11,"context_line":"limits. An administrator is now able to set the share type"},{"line_number":12,"context_line":"extra-specs `netapp:udp_max_xfer_size` and"},{"line_number":13,"context_line":"`netapp:udp_max_xfer_size`. While creating a share server or"},{"line_number":14,"context_line":"providing a share server to a share or a share group, the NetApp"},{"line_number":15,"context_line":"driver will consider these extra-specs to decide wheter to create"},{"line_number":16,"context_line":"or reuse a share server."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_b7b7dbd8","line":13,"range":{"start_line":13,"start_character":8,"end_line":13,"end_character":11},"updated":"2020-08-17 19:05:03.000000000","message":"tcp","commit_id":"588578325611d3cfd0d1e985ce27ebf692c21ce4"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"1c1e0bfb1145f1b77a7c026023c72db4060838e0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"extra-specs `netapp:udp_max_xfer_size` and"},{"line_number":13,"context_line":"`netapp:udp_max_xfer_size`. While creating a share server or"},{"line_number":14,"context_line":"providing a share server to a share or a share group, the NetApp"},{"line_number":15,"context_line":"driver will consider these extra-specs to decide wheter to create"},{"line_number":16,"context_line":"or reuse a share server."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Share server now contain the details:nfs_config field, which"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_97ba97bd","line":15,"range":{"start_line":15,"start_character":49,"end_line":15,"end_character":55},"updated":"2020-08-17 19:05:03.000000000","message":"whether","commit_id":"588578325611d3cfd0d1e985ce27ebf692c21ce4"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"1c1e0bfb1145f1b77a7c026023c72db4060838e0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"driver will consider these extra-specs to decide wheter to create"},{"line_number":16,"context_line":"or reuse a share server."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Share server now contain the details:nfs_config field, which"},{"line_number":19,"context_line":"stores the server NFS configuration dictionary. In case the server"},{"line_number":20,"context_line":"does not have a NFS configuration requirement, it saves as the"},{"line_number":21,"context_line":"default NFS values, retrieved at the driver startup. A server"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_17c6874a","line":18,"range":{"start_line":18,"start_character":17,"end_line":18,"end_character":24},"updated":"2020-08-17 19:05:03.000000000","message":"contains","commit_id":"588578325611d3cfd0d1e985ce27ebf692c21ce4"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"1c1e0bfb1145f1b77a7c026023c72db4060838e0","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Share server now contain the details:nfs_config field, which"},{"line_number":19,"context_line":"stores the server NFS configuration dictionary. In case the server"},{"line_number":20,"context_line":"does not have a NFS configuration requirement, it saves as the"},{"line_number":21,"context_line":"default NFS values, retrieved at the driver startup. A server"},{"line_number":22,"context_line":"without details:nfs_config is considered as using the default one."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The share server manage operation was modified to also retrieve"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_b7dcfb18","line":21,"range":{"start_line":20,"start_character":47,"end_line":21,"end_character":18},"updated":"2020-08-17 19:05:03.000000000","message":"it saves the default NFS values","commit_id":"588578325611d3cfd0d1e985ce27ebf692c21ce4"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"1c1e0bfb1145f1b77a7c026023c72db4060838e0","unresolved":false,"context_lines":[{"line_number":24,"context_line":"The share server manage operation was modified to also retrieve"},{"line_number":25,"context_line":"its NFS max transfer configurations."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"The share manage operation was modified to check wheter the NFS"},{"line_number":28,"context_line":"max transfer extra-specs are matching the share server configured"},{"line_number":29,"context_line":"values."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_d7b40fd4","line":27,"range":{"start_line":27,"start_character":49,"end_line":27,"end_character":55},"updated":"2020-08-17 19:05:03.000000000","message":"whether","commit_id":"588578325611d3cfd0d1e985ce27ebf692c21ce4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"12bcffd2053718a4947aa713f52fe0fcd5b6c688","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[NetApp] Enables configuring NFS transfer limits"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"From this this change, shares and share groups can be created"},{"line_number":10,"context_line":"uppon share servers configured with specific NFS max transfer"},{"line_number":11,"context_line":"limits. An administrator is now able to set the share type"},{"line_number":12,"context_line":"extra-specs `netapp:udp_max_xfer_size` and"},{"line_number":13,"context_line":"`netapp:tcp_max_xfer_size`. While creating a share server or"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_03707fa3","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":5},"updated":"2020-09-10 22:47:10.000000000","message":"nit: upon","commit_id":"a7e1e46ecead763a0aeb9b03589a51d292d7ebc5"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"1c1e0bfb1145f1b77a7c026023c72db4060838e0","unresolved":false,"context_lines":[{"line_number":1379,"context_line":"    @na_utils.trace"},{"line_number":1380,"context_line":"    def _configure_nfs(self, nfs_config):"},{"line_number":1381,"context_line":"        \"\"\"Sets the nfs configuraton\"\"\""},{"line_number":1382,"context_line":"        self.send_request(\u0027nfs-service-modify\u0027, nfs_config)"},{"line_number":1383,"context_line":""},{"line_number":1384,"context_line":"    @na_utils.trace"},{"line_number":1385,"context_line":"    def _create_default_nfs_export_rules(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_57a75fa8","line":1382,"updated":"2020-08-17 19:05:03.000000000","message":"Please put the max-xfer-size somehow behind a feature switch (I think _init_features() can help) . I\u0027m not entirely sure why, but it won\u0027t let me set tcp-max-xfer-size with nfs-service-modify on ONTAP 9.3 (it works with ONTAP CLI commandline ssh though, see https://community.netapp.com/t5/ONTAP-Discussions/ONTAP-9-3-setting-tcp-max-xfer-size-via-api-sdk/td-p/143130)\nIt works for me on ONTAP 9.6. I did not have the versions 9.4 and 9.5 in between at hand to test","commit_id":"588578325611d3cfd0d1e985ce27ebf692c21ce4"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"7f3ccd5787123608e33188559b1230031242c78b","unresolved":false,"context_lines":[{"line_number":1379,"context_line":"    @na_utils.trace"},{"line_number":1380,"context_line":"    def _configure_nfs(self, nfs_config):"},{"line_number":1381,"context_line":"        \"\"\"Sets the nfs configuraton\"\"\""},{"line_number":1382,"context_line":"        self.send_request(\u0027nfs-service-modify\u0027, nfs_config)"},{"line_number":1383,"context_line":""},{"line_number":1384,"context_line":"    @na_utils.trace"},{"line_number":1385,"context_line":"    def _create_default_nfs_export_rules(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_c2d42622","line":1382,"in_reply_to":"9f560f44_57a75fa8","updated":"2020-09-04 17:36:07.000000000","message":"Thanks for raising that issue Maurice. The 9.3 API documentation doesn\u0027t have both \u0027tcp-max-xfer-size\u0027 and \u0027udp-max-xfer-size\u0027 parameters for \u0027nfs-modify\u0027. I was able to find this configuration only for \u003e\u003d 9.4;\nAt this moment we have been testing with ONTAP 9.6 and 9.7 in our lab.","commit_id":"588578325611d3cfd0d1e985ce27ebf692c21ce4"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"7f3ccd5787123608e33188559b1230031242c78b","unresolved":false,"context_lines":[{"line_number":4074,"context_line":"        return self.parse_nfs_config(child_elem, desired_args)"},{"line_number":4075,"context_line":""},{"line_number":4076,"context_line":"    @na_utils.trace"},{"line_number":4077,"context_line":"    def parse_nfs_config(self, parent_elem, desired_args):"},{"line_number":4078,"context_line":"        \"\"\"Parse the get NFS config operation returning the desired params\"\"\""},{"line_number":4079,"context_line":"        nfs_info_elem \u003d parent_elem.get_child_by_name(\u0027nfs-info\u0027)"},{"line_number":4080,"context_line":""},{"line_number":4081,"context_line":"        nfs_config \u003d {}"},{"line_number":4082,"context_line":"        for arg in desired_args:"},{"line_number":4083,"context_line":"            nfs_config[arg] \u003d nfs_info_elem.get_child_content(arg)"},{"line_number":4084,"context_line":""},{"line_number":4085,"context_line":"        return nfs_config"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_a206521f","line":4085,"range":{"start_line":4077,"start_character":0,"end_line":4085,"end_character":25},"updated":"2020-09-04 17:36:07.000000000","message":"For ONTAP \u003c\u003d 9.3 is expected that the nfs-info will not return \u0027tcp[udp]-max-xfer-size\u0027 default values. So in this case it will be set as None.","commit_id":"588578325611d3cfd0d1e985ce27ebf692c21ce4"}],"manila/share/drivers/netapp/dataontap/cluster_mode/drv_single_svm.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"12bcffd2053718a4947aa713f52fe0fcd5b6c688","unresolved":false,"context_lines":[{"line_number":287,"context_line":"    def choose_share_server_compatible_with_share(self, context, share_servers,"},{"line_number":288,"context_line":"                                                  share, snapshot\u003dNone,"},{"line_number":289,"context_line":"                                                  share_group\u003dNone):"},{"line_number":290,"context_line":"        return self.library.choose_share_server_compatible_with_share("},{"line_number":291,"context_line":"            context, share_servers, share, snapshot, share_group)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    def choose_share_server_compatible_with_share_group("},{"line_number":294,"context_line":"            self, context, share_servers, share_group_ref,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_63afbbe2","line":291,"range":{"start_line":290,"start_character":8,"end_line":291,"end_character":65},"updated":"2020-09-10 22:47:10.000000000","message":"shouldn\u0027t this raise NotImplementedError","commit_id":"a7e1e46ecead763a0aeb9b03589a51d292d7ebc5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"12bcffd2053718a4947aa713f52fe0fcd5b6c688","unresolved":false,"context_lines":[{"line_number":293,"context_line":"    def choose_share_server_compatible_with_share_group("},{"line_number":294,"context_line":"            self, context, share_servers, share_group_ref,"},{"line_number":295,"context_line":"            share_group_snapshot\u003dNone):"},{"line_number":296,"context_line":"        return self.library.choose_share_server_compatible_with_share_group("},{"line_number":297,"context_line":"            context, share_servers, share_group_ref,"},{"line_number":298,"context_line":"            share_group_snapshot\u003dshare_group_snapshot)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_a3b55334","line":298,"range":{"start_line":296,"start_character":15,"end_line":298,"end_character":54},"updated":"2020-09-10 22:47:10.000000000","message":"same","commit_id":"a7e1e46ecead763a0aeb9b03589a51d292d7ebc5"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"7f3ccd5787123608e33188559b1230031242c78b","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        # Performance monitoring library"},{"line_number":162,"context_line":"        self._perf_library \u003d performance.PerformanceLibrary(self._client)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        # Fill the default NFS config for the vserver"},{"line_number":165,"context_line":"        self._default_nfs_config \u003d self._client.get_nfs_config_default(list("},{"line_number":166,"context_line":"            self.NFS_CONFIG_EXTRA_SPECS_MAP.values()))"},{"line_number":167,"context_line":"        LOG.debug(\u0027The default NFS configuration: %s\u0027,"},{"line_number":168,"context_line":"                  self._default_nfs_config)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    @na_utils.trace"},{"line_number":171,"context_line":"    def _set_cluster_info(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_45877bb7","line":168,"range":{"start_line":164,"start_character":0,"end_line":168,"end_character":43},"updated":"2020-09-04 17:36:07.000000000","message":"Only for ONTAP \u003e\u003d 9.4?\nOr this will be filled with None for both tcp/udp configs. You need to make sure that this values set to None won\u0027t be a problem in share server setup for ONTAP.","commit_id":"588578325611d3cfd0d1e985ce27ebf692c21ce4"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"7f3ccd5787123608e33188559b1230031242c78b","unresolved":false,"context_lines":[{"line_number":2345,"context_line":"                self._check_extra_specs_validity("},{"line_number":2346,"context_line":"                    destination_share, extra_specs)"},{"line_number":2347,"context_line":""},{"line_number":2348,"context_line":"                # NOTE (felipe_rodrigues): NetApp only can migrate across same"},{"line_number":2349,"context_line":"                # server, so it does not need to check that the destination"},{"line_number":2350,"context_line":"                # share has the same NFS config as the destination server."},{"line_number":2351,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_02ad7e9a","line":2348,"range":{"start_line":2348,"start_character":67,"end_line":2348,"end_character":73},"updated":"2020-09-04 17:36:07.000000000","message":"within the","commit_id":"588578325611d3cfd0d1e985ce27ebf692c21ce4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"12bcffd2053718a4947aa713f52fe0fcd5b6c688","unresolved":false,"context_lines":[{"line_number":2843,"context_line":"        # Mount the volume on the destination vserver"},{"line_number":2844,"context_line":"        dest_vserver_client.mount_volume(volume_name)"},{"line_number":2845,"context_line":""},{"line_number":2846,"context_line":"    def choose_share_server_compatible_with_share(self, context, share_servers,"},{"line_number":2847,"context_line":"                                                  share, snapshot\u003dNone,"},{"line_number":2848,"context_line":"                                                  share_group\u003dNone):"},{"line_number":2849,"context_line":"        raise NotImplementedError()"},{"line_number":2850,"context_line":""},{"line_number":2851,"context_line":"    def choose_share_server_compatible_with_share_group("},{"line_number":2852,"context_line":"            self, context, share_servers, share_group_ref,"},{"line_number":2853,"context_line":"            share_group_snapshot\u003dNone):"},{"line_number":2854,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_fea4fe08","line":2854,"range":{"start_line":2846,"start_character":0,"end_line":2854,"end_character":35},"updated":"2020-09-10 22:47:10.000000000","message":"This needs to be in drv_single_svm file","commit_id":"a7e1e46ecead763a0aeb9b03589a51d292d7ebc5"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"7f3ccd5787123608e33188559b1230031242c78b","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        for network_allocation in network_info[\u0027network_allocations\u0027]:"},{"line_number":130,"context_line":"            ports[network_allocation[\u0027id\u0027]] \u003d network_allocation[\u0027ip_address\u0027]"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        nfs_config \u003d self._default_nfs_config"},{"line_number":133,"context_line":"        if metadata and \u0027share_type_id\u0027 in metadata:"},{"line_number":134,"context_line":"            extra_specs \u003d share_types.get_share_type_extra_specs("},{"line_number":135,"context_line":"                metadata[\u0027share_type_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_056c6306","line":132,"range":{"start_line":132,"start_character":26,"end_line":132,"end_character":45},"updated":"2020-09-04 17:36:07.000000000","message":"We can use the default values \u003d\u003d None to identify that this ONTAP may not support tcp/udp-max-xter-size configs.","commit_id":"588578325611d3cfd0d1e985ce27ebf692c21ce4"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"7f3ccd5787123608e33188559b1230031242c78b","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"            try:"},{"line_number":152,"context_line":"                self._create_vserver(vserver_name, network_info,"},{"line_number":153,"context_line":"                                     nfs_config\u003dnfs_config)"},{"line_number":154,"context_line":"            except Exception as e:"},{"line_number":155,"context_line":"                e.detail_data \u003d {\u0027server_details\u0027: server_details}"},{"line_number":156,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_c54a6b81","line":153,"range":{"start_line":153,"start_character":48,"end_line":153,"end_character":58},"updated":"2020-09-04 17:36:07.000000000","message":"this \u0027nfs_config\u0027 must be None for ONTAP \u003c 9.4; Or will fail on vserver creation.","commit_id":"588578325611d3cfd0d1e985ce27ebf692c21ce4"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"7f3ccd5787123608e33188559b1230031242c78b","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                    extra_specs[key], key)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @na_utils.trace"},{"line_number":173,"context_line":"    def _check_if_extra_spec_is_positve(self, value, key):"},{"line_number":174,"context_line":"        \"\"\"Check if extra_spec has a valid positive int value.\"\"\""},{"line_number":175,"context_line":"        if int(value) \u003c 0:"},{"line_number":176,"context_line":"            args \u003d {\u0027value\u0027: value, \u0027key\u0027: key}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_8e6b821d","line":173,"range":{"start_line":173,"start_character":32,"end_line":173,"end_character":39},"updated":"2020-09-04 17:36:07.000000000","message":"positive","commit_id":"588578325611d3cfd0d1e985ce27ebf692c21ce4"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"7f3ccd5787123608e33188559b1230031242c78b","unresolved":false,"context_lines":[{"line_number":552,"context_line":"        if new_vserver_name !\u003d old_vserver_name:"},{"line_number":553,"context_line":"            self._client.rename_vserver(old_vserver_name, new_vserver_name)"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"        nfs_config \u003d self._client.get_nfs_config("},{"line_number":556,"context_line":"            list(self.NFS_CONFIG_EXTRA_SPECS_MAP.values()), new_vserver_name)"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"        backend_details \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_455e5b45","line":555,"range":{"start_line":555,"start_character":8,"end_line":555,"end_character":18},"updated":"2020-09-04 17:36:07.000000000","message":"check if they are None before updating backend details, since the ONTAP might not support configure/read these nfs configs.","commit_id":"588578325611d3cfd0d1e985ce27ebf692c21ce4"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"7f3ccd5787123608e33188559b1230031242c78b","unresolved":false,"context_lines":[{"line_number":664,"context_line":"        as the same configuration."},{"line_number":665,"context_line":"        \"\"\""},{"line_number":666,"context_line":"        share_server_nfs \u003d (jsonutils.loads("},{"line_number":667,"context_line":"                            share_server[\u0027backend_details\u0027][\u0027nfs_config\u0027])"},{"line_number":668,"context_line":"                            if \u0027backend_details\u0027 in share_server and"},{"line_number":669,"context_line":"                            \u0027nfs_config\u0027 in share_server[\u0027backend_details\u0027]"},{"line_number":670,"context_line":"                            else None)"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"        if share_server_nfs \u003d\u003d expected_nfs_config:"},{"line_number":673,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_c52f0ba5","line":670,"range":{"start_line":667,"start_character":29,"end_line":670,"end_character":37},"updated":"2020-09-04 17:36:07.000000000","message":"Or:\njsonutils.loads(share_server.get(\u0027backend_details\u0027,{}).get(\u0027nfs_config\u0027, None))","commit_id":"588578325611d3cfd0d1e985ce27ebf692c21ce4"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"7f3ccd5787123608e33188559b1230031242c78b","unresolved":false,"context_lines":[{"line_number":699,"context_line":"            return None"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"        extra_specs \u003d share_types.get_extra_specs_from_share(share)"},{"line_number":702,"context_line":"        nfs_config \u003d self._get_nfs_config_provisioning_options(extra_specs)"},{"line_number":703,"context_line":"        for share_server in share_servers:"},{"line_number":704,"context_line":"            if self._check_reuse_share_server(share_server, share_group,"},{"line_number":705,"context_line":"                                              nfs_config):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_801b4171","line":702,"range":{"start_line":702,"start_character":8,"end_line":702,"end_character":75},"updated":"2020-09-04 17:36:07.000000000","message":"we need to prevent filling the nfs_config here when ONTAP \u003c 9.4 too. Same for \u0027choose_share_server_compatible_with_share_group\u0027","commit_id":"588578325611d3cfd0d1e985ce27ebf692c21ce4"}],"releasenotes/notes/netapp-cdot-multi-svm-configure-nfs-95c9154e1aa28751.yaml":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"7f3ccd5787123608e33188559b1230031242c78b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - For NetApp ONTAP driver, administrators are now able to set share"},{"line_number":4,"context_line":"    servers max NFS transfer limits. These limits can be configured by"},{"line_number":5,"context_line":"    setting two new extra-specs to share types: `netapp:tcp_max_xfer_size`"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_c04b795c","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"updated":"2020-09-04 17:36:07.000000000","message":"worth mentioning that will work only with ONTAP \u003e\u003d 9.4","commit_id":"588578325611d3cfd0d1e985ce27ebf692c21ce4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"12bcffd2053718a4947aa713f52fe0fcd5b6c688","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - For NetApp ONTAP driver, administrators are now able to set share"},{"line_number":4,"context_line":"    servers max NFS transfer limits. These limits can be configured by"},{"line_number":5,"context_line":"    setting two new extra-specs to share types: `netapp:tcp_max_xfer_size`"},{"line_number":6,"context_line":"    and  `netapp:udp_max_xfer_size`. The driver will consider these limits"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_de601aa8","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":4},"updated":"2020-09-10 22:47:10.000000000","message":"when using \u0027:\u0027 in the text, you\u0027ll need to begin the yaml section with \n\n \"- |\"\n\nto create a block of text...","commit_id":"a7e1e46ecead763a0aeb9b03589a51d292d7ebc5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"12bcffd2053718a4947aa713f52fe0fcd5b6c688","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    under Manila management, the driver will check if the share type"},{"line_number":9,"context_line":"    extra-specs values match the share server configured NFS limits."},{"line_number":10,"context_line":"    This change does not have effect in DHSS\u003dFalse environments and relies"},{"line_number":11,"context_line":"    on ONTAP features available only in versions equal and greater than"},{"line_number":12,"context_line":"    ``9.4``."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_3ec15681","line":11,"range":{"start_line":11,"start_character":54,"end_line":11,"end_character":55},"updated":"2020-09-10 22:47:10.000000000","message":"nit: to","commit_id":"a7e1e46ecead763a0aeb9b03589a51d292d7ebc5"}]}