)]}'
{"manila/api/openstack/api_version_request.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"d2ccd687579c8f87acd8e537295c37c16d2be4d2","unresolved":false,"context_lines":[{"line_number":148,"context_line":"             \"progress\" which indicates the completion of a share creation"},{"line_number":149,"context_line":"             operation as a percentage."},{"line_number":150,"context_line":"    * 2.55 - Share groups feature is no longer considered experimental."},{"line_number":151,"context_line":"    * 2.56 - Added Share server migration operations:"},{"line_number":152,"context_line":"             \u0027share_server_migration_check\u0027"},{"line_number":153,"context_line":"             \u0027share_server_migration_cancel\u0027"},{"line_number":154,"context_line":"             \u0027share_server_migration_complete\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_03dffb65","line":151,"range":{"start_line":151,"start_character":6,"end_line":151,"end_character":11},"updated":"2020-09-09 19:27:39.000000000","message":"2.57","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b6515f490448625bb3fe67aa5583230922ec197c","unresolved":false,"context_lines":[{"line_number":148,"context_line":"             \"progress\" which indicates the completion of a share creation"},{"line_number":149,"context_line":"             operation as a percentage."},{"line_number":150,"context_line":"    * 2.55 - Share groups feature is no longer considered experimental."},{"line_number":151,"context_line":"    * 2.56 - Added Share server migration operations:"},{"line_number":152,"context_line":"             \u0027share_server_migration_check\u0027"},{"line_number":153,"context_line":"             \u0027share_server_migration_cancel\u0027"},{"line_number":154,"context_line":"             \u0027share_server_migration_complete\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_3ece8d2c","line":151,"range":{"start_line":151,"start_character":6,"end_line":151,"end_character":11},"in_reply_to":"9f560f44_03dffb65","updated":"2020-09-10 02:15:06.000000000","message":"Done","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"d2ccd687579c8f87acd8e537295c37c16d2be4d2","unresolved":false,"context_lines":[{"line_number":161,"context_line":"# The default api version request is defined to be the"},{"line_number":162,"context_line":"# minimum version of the API supported."},{"line_number":163,"context_line":"_MIN_API_VERSION \u003d \"2.0\""},{"line_number":164,"context_line":"_MAX_API_VERSION \u003d \"2.56\""},{"line_number":165,"context_line":"DEFAULT_API_VERSION \u003d _MIN_API_VERSION"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_c3d86380","line":164,"range":{"start_line":164,"start_character":18,"end_line":164,"end_character":25},"updated":"2020-09-09 19:27:39.000000000","message":"2.57","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b6515f490448625bb3fe67aa5583230922ec197c","unresolved":false,"context_lines":[{"line_number":161,"context_line":"# The default api version request is defined to be the"},{"line_number":162,"context_line":"# minimum version of the API supported."},{"line_number":163,"context_line":"_MIN_API_VERSION \u003d \"2.0\""},{"line_number":164,"context_line":"_MAX_API_VERSION \u003d \"2.56\""},{"line_number":165,"context_line":"DEFAULT_API_VERSION \u003d _MIN_API_VERSION"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_1ed109cd","line":164,"range":{"start_line":164,"start_character":18,"end_line":164,"end_character":25},"in_reply_to":"9f560f44_c3d86380","updated":"2020-09-10 02:15:06.000000000","message":"Done","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"}],"manila/api/openstack/rest_api_version_history.rst":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"d2ccd687579c8f87acd8e537295c37c16d2be4d2","unresolved":false,"context_lines":[{"line_number":306,"context_line":"------------------------"},{"line_number":307,"context_line":"  Share groups feature is no longer considered experimental."},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"2.56"},{"line_number":310,"context_line":"----"},{"line_number":311,"context_line":"  Added share server migration feature. A two-phase approach that migrates"},{"line_number":312,"context_line":"  a share server and all its resources to a new host."}],"source_content_type":"text/x-rst","patch_set":7,"id":"9f560f44_e3c48794","line":309,"range":{"start_line":309,"start_character":3,"end_line":309,"end_character":4},"updated":"2020-09-09 19:27:39.000000000","message":"2.57","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b6515f490448625bb3fe67aa5583230922ec197c","unresolved":false,"context_lines":[{"line_number":306,"context_line":"------------------------"},{"line_number":307,"context_line":"  Share groups feature is no longer considered experimental."},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"2.56"},{"line_number":310,"context_line":"----"},{"line_number":311,"context_line":"  Added share server migration feature. A two-phase approach that migrates"},{"line_number":312,"context_line":"  a share server and all its resources to a new host."}],"source_content_type":"text/x-rst","patch_set":7,"id":"9f560f44_7edbe5eb","line":309,"range":{"start_line":309,"start_character":3,"end_line":309,"end_character":4},"in_reply_to":"9f560f44_e3c48794","updated":"2020-09-10 02:15:06.000000000","message":"Done","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"}],"manila/api/v2/share_servers.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a36c8f88a7176a12b9598b0abb4c496bfe2bb826","unresolved":false,"context_lines":[{"line_number":272,"context_line":"            msg \u003d _(\u0027Share server %s not found\u0027) % id"},{"line_number":273,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        self.share_api.share_server_migration_complete(context, share_server)"},{"line_number":276,"context_line":"        return webob.Response(status_int\u003dhttp_client.ACCEPTED)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    @wsgi.Controller.api_version(\u00272.56\u0027, experimental\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_71e32fd9","line":275,"range":{"start_line":275,"start_character":8,"end_line":275,"end_character":77},"updated":"2020-09-01 01:58:08.000000000","message":"- Add a try/except according (Conflict/BadRequest)","commit_id":"8ecca23f456549c9dd405273b944b4063ca2b026"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a36c8f88a7176a12b9598b0abb4c496bfe2bb826","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        except exception.ShareServerNotFound:"},{"line_number":288,"context_line":"            msg \u003d _(\u0027Share server %s not found\u0027) % id"},{"line_number":289,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":290,"context_line":"        self.share_api.share_server_migration_cancel(context, share_server)"},{"line_number":291,"context_line":"        return webob.Response(status_int\u003dhttp_client.ACCEPTED)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    @wsgi.Controller.api_version(\u00272.56\u0027, experimental\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_0f60c700","line":290,"range":{"start_line":290,"start_character":23,"end_line":290,"end_character":52},"updated":"2020-09-01 01:58:08.000000000","message":"Add try/except here also.","commit_id":"8ecca23f456549c9dd405273b944b4063ca2b026"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a36c8f88a7176a12b9598b0abb4c496bfe2bb826","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        except exception.ShareServerNotFound:"},{"line_number":303,"context_line":"            msg \u003d _(\u0027Share server %s not found\u0027) % id"},{"line_number":304,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":305,"context_line":"        result \u003d self.share_api.share_server_migration_get_progress("},{"line_number":306,"context_line":"            context, share_server)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        # refresh share model"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_2f530b3b","line":305,"range":{"start_line":305,"start_character":32,"end_line":305,"end_character":67},"updated":"2020-09-01 01:58:08.000000000","message":"Add try/except here also.","commit_id":"8ecca23f456549c9dd405273b944b4063ca2b026"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3b0f57d7c0bac5f7fa3f21cdf46bb5e142c5c145","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    valid_statuses \u003d {"},{"line_number":44,"context_line":"        \u0027status\u0027: {"},{"line_number":45,"context_line":"            constants.STATUS_ACTIVE,"},{"line_number":46,"context_line":"            constants.STATUS_ERROR,"},{"line_number":47,"context_line":"            constants.STATUS_DELETING,"},{"line_number":48,"context_line":"            constants.STATUS_CREATING,"},{"line_number":49,"context_line":"            constants.STATUS_MANAGING,"},{"line_number":50,"context_line":"            constants.STATUS_UNMANAGING,"},{"line_number":51,"context_line":"            constants.STATUS_UNMANAGE_ERROR,"},{"line_number":52,"context_line":"            constants.STATUS_MANAGE_ERROR,"},{"line_number":53,"context_line":"            constants.STATUS_SERVER_MIGRATING,"},{"line_number":54,"context_line":"            constants.STATUS_SERVER_MIGRATING_TO,"},{"line_number":55,"context_line":"        },"},{"line_number":56,"context_line":"        \u0027task_state\u0027: set(constants.SERVER_TASK_STATE_STATUSES),"},{"line_number":57,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_5fbdc3d5","line":54,"range":{"start_line":45,"start_character":0,"end_line":54,"end_character":49},"updated":"2020-09-01 19:21:13.000000000","message":"move this to constants for consistency..","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5de59631aac220c6052c8b5a4e0320358f1f6294","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    valid_statuses \u003d {"},{"line_number":44,"context_line":"        \u0027status\u0027: {"},{"line_number":45,"context_line":"            constants.STATUS_ACTIVE,"},{"line_number":46,"context_line":"            constants.STATUS_ERROR,"},{"line_number":47,"context_line":"            constants.STATUS_DELETING,"},{"line_number":48,"context_line":"            constants.STATUS_CREATING,"},{"line_number":49,"context_line":"            constants.STATUS_MANAGING,"},{"line_number":50,"context_line":"            constants.STATUS_UNMANAGING,"},{"line_number":51,"context_line":"            constants.STATUS_UNMANAGE_ERROR,"},{"line_number":52,"context_line":"            constants.STATUS_MANAGE_ERROR,"},{"line_number":53,"context_line":"            constants.STATUS_SERVER_MIGRATING,"},{"line_number":54,"context_line":"            constants.STATUS_SERVER_MIGRATING_TO,"},{"line_number":55,"context_line":"        },"},{"line_number":56,"context_line":"        \u0027task_state\u0027: set(constants.SERVER_TASK_STATE_STATUSES),"},{"line_number":57,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_4575bbcb","line":54,"range":{"start_line":45,"start_character":0,"end_line":54,"end_character":49},"in_reply_to":"9f560f44_5fbdc3d5","updated":"2020-09-08 12:22:09.000000000","message":"Done","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3b0f57d7c0bac5f7fa3f21cdf46bb5e142c5c145","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    @wsgi.Controller.api_version(\u00272.56\u0027, experimental\u003dTrue)"},{"line_number":264,"context_line":"    @wsgi.action(\"migration_complete\")"},{"line_number":265,"context_line":"    @wsgi.Controller.authorize"},{"line_number":266,"context_line":"    def share_server_migration_complete(self, req, id, body):"},{"line_number":267,"context_line":"        \"\"\"Invokes 2nd phase of share server migration.\"\"\""},{"line_number":268,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":269,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_dfc43344","line":266,"range":{"start_line":266,"start_character":0,"end_line":266,"end_character":4},"updated":"2020-09-01 19:21:13.000000000","message":"@wsgi.response(http_client.ACCEPTED)","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5de59631aac220c6052c8b5a4e0320358f1f6294","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    @wsgi.Controller.api_version(\u00272.56\u0027, experimental\u003dTrue)"},{"line_number":264,"context_line":"    @wsgi.action(\"migration_complete\")"},{"line_number":265,"context_line":"    @wsgi.Controller.authorize"},{"line_number":266,"context_line":"    def share_server_migration_complete(self, req, id, body):"},{"line_number":267,"context_line":"        \"\"\"Invokes 2nd phase of share server migration.\"\"\""},{"line_number":268,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":269,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_257087da","line":266,"range":{"start_line":266,"start_character":0,"end_line":266,"end_character":4},"in_reply_to":"9f560f44_dfc43344","updated":"2020-09-08 12:22:09.000000000","message":"Done","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3b0f57d7c0bac5f7fa3f21cdf46bb5e142c5c145","unresolved":false,"context_lines":[{"line_number":286,"context_line":"    @wsgi.Controller.api_version(\u00272.56\u0027, experimental\u003dTrue)"},{"line_number":287,"context_line":"    @wsgi.action(\"migration_cancel\")"},{"line_number":288,"context_line":"    @wsgi.Controller.authorize"},{"line_number":289,"context_line":"    def share_server_migration_cancel(self, req, id, body):"},{"line_number":290,"context_line":"        \"\"\"Attempts to cancel share migration.\"\"\""},{"line_number":291,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":292,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_7fdb6720","line":289,"range":{"start_line":289,"start_character":3,"end_line":289,"end_character":4},"updated":"2020-09-01 19:21:13.000000000","message":"@wsgi.response(http_client.ACCEPTED)","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5de59631aac220c6052c8b5a4e0320358f1f6294","unresolved":false,"context_lines":[{"line_number":286,"context_line":"    @wsgi.Controller.api_version(\u00272.56\u0027, experimental\u003dTrue)"},{"line_number":287,"context_line":"    @wsgi.action(\"migration_cancel\")"},{"line_number":288,"context_line":"    @wsgi.Controller.authorize"},{"line_number":289,"context_line":"    def share_server_migration_cancel(self, req, id, body):"},{"line_number":290,"context_line":"        \"\"\"Attempts to cancel share migration.\"\"\""},{"line_number":291,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":292,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_657a7fba","line":289,"range":{"start_line":289,"start_character":3,"end_line":289,"end_character":4},"in_reply_to":"9f560f44_7fdb6720","updated":"2020-09-08 12:22:09.000000000","message":"Done","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3b0f57d7c0bac5f7fa3f21cdf46bb5e142c5c145","unresolved":false,"context_lines":[{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        try:"},{"line_number":300,"context_line":"            self.share_api.share_server_migration_cancel(context, share_server)"},{"line_number":301,"context_line":"        except exception.ServiceIsDown as e:"},{"line_number":302,"context_line":"            raise exc.HTTPConflict(explanation\u003de.msg)"},{"line_number":303,"context_line":"        except exception.InvalidShareServer as e:"},{"line_number":304,"context_line":"            raise exc.HTTPBadRequest(explanation\u003de.msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_dff2739b","line":301,"range":{"start_line":301,"start_character":15,"end_line":301,"end_character":44},"updated":"2020-09-01 19:21:13.000000000","message":"Share server manage responds with HTTP400\nShare migration also should respond with HTTP400","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5de59631aac220c6052c8b5a4e0320358f1f6294","unresolved":false,"context_lines":[{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        try:"},{"line_number":300,"context_line":"            self.share_api.share_server_migration_cancel(context, share_server)"},{"line_number":301,"context_line":"        except exception.ServiceIsDown as e:"},{"line_number":302,"context_line":"            raise exc.HTTPConflict(explanation\u003de.msg)"},{"line_number":303,"context_line":"        except exception.InvalidShareServer as e:"},{"line_number":304,"context_line":"            raise exc.HTTPBadRequest(explanation\u003de.msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_05458370","line":301,"range":{"start_line":301,"start_character":15,"end_line":301,"end_character":44},"in_reply_to":"9f560f44_dff2739b","updated":"2020-09-08 12:22:09.000000000","message":"Done","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6aca1109d6cad40af7a02da67c479891279eb130","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        try:"},{"line_number":269,"context_line":"            share_server \u003d db_api.share_server_get("},{"line_number":270,"context_line":"                context, id)"},{"line_number":271,"context_line":"        except exception.ShareServerNotFound:"},{"line_number":272,"context_line":"            msg \u003d _(\u0027Share server %s not found\u0027) % id"},{"line_number":273,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        try:"},{"line_number":276,"context_line":"            self.share_api.share_server_migration_complete(context,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_c86520e3","line":273,"range":{"start_line":271,"start_character":44,"end_line":273,"end_character":51},"updated":"2020-09-09 18:49:51.000000000","message":"redundant:\n\n  except exception.ShareServerNotFound as e:\n       raise exc.HTTPNotFound(explanation\u003de.msg)","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b6515f490448625bb3fe67aa5583230922ec197c","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        try:"},{"line_number":269,"context_line":"            share_server \u003d db_api.share_server_get("},{"line_number":270,"context_line":"                context, id)"},{"line_number":271,"context_line":"        except exception.ShareServerNotFound:"},{"line_number":272,"context_line":"            msg \u003d _(\u0027Share server %s not found\u0027) % id"},{"line_number":273,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        try:"},{"line_number":276,"context_line":"            self.share_api.share_server_migration_complete(context,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_3e320d5f","line":273,"range":{"start_line":271,"start_character":44,"end_line":273,"end_character":51},"in_reply_to":"9f560f44_c86520e3","updated":"2020-09-10 02:15:06.000000000","message":"Done","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6aca1109d6cad40af7a02da67c479891279eb130","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        try:"},{"line_number":290,"context_line":"            share_server \u003d db_api.share_server_get("},{"line_number":291,"context_line":"                context, id)"},{"line_number":292,"context_line":"        except exception.ShareServerNotFound:"},{"line_number":293,"context_line":"            msg \u003d _(\u0027Share server %s not found\u0027) % id"},{"line_number":294,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        try:"},{"line_number":297,"context_line":"            self.share_api.share_server_migration_cancel(context, share_server)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_a8a0acf4","line":294,"range":{"start_line":292,"start_character":8,"end_line":294,"end_character":51},"updated":"2020-09-09 18:49:51.000000000","message":"same","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b6515f490448625bb3fe67aa5583230922ec197c","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        try:"},{"line_number":290,"context_line":"            share_server \u003d db_api.share_server_get("},{"line_number":291,"context_line":"                context, id)"},{"line_number":292,"context_line":"        except exception.ShareServerNotFound:"},{"line_number":293,"context_line":"            msg \u003d _(\u0027Share server %s not found\u0027) % id"},{"line_number":294,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        try:"},{"line_number":297,"context_line":"            self.share_api.share_server_migration_cancel(context, share_server)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_1e358945","line":294,"range":{"start_line":292,"start_character":8,"end_line":294,"end_character":51},"in_reply_to":"9f560f44_a8a0acf4","updated":"2020-09-10 02:15:06.000000000","message":"Done","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6aca1109d6cad40af7a02da67c479891279eb130","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        try:"},{"line_number":309,"context_line":"            share_server \u003d db_api.share_server_get("},{"line_number":310,"context_line":"                context, id)"},{"line_number":311,"context_line":"        except exception.ShareServerNotFound:"},{"line_number":312,"context_line":"            msg \u003d _(\u0027Share server %s not found\u0027) % id"},{"line_number":313,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        try:"},{"line_number":316,"context_line":"            result \u003d self.share_api.share_server_migration_get_progress("}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_288dbc7b","line":313,"range":{"start_line":311,"start_character":0,"end_line":313,"end_character":51},"updated":"2020-09-09 18:49:51.000000000","message":"same","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b6515f490448625bb3fe67aa5583230922ec197c","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        try:"},{"line_number":309,"context_line":"            share_server \u003d db_api.share_server_get("},{"line_number":310,"context_line":"                context, id)"},{"line_number":311,"context_line":"        except exception.ShareServerNotFound:"},{"line_number":312,"context_line":"            msg \u003d _(\u0027Share server %s not found\u0027) % id"},{"line_number":313,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        try:"},{"line_number":316,"context_line":"            result \u003d self.share_api.share_server_migration_get_progress("}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_7e3f6524","line":313,"range":{"start_line":311,"start_character":0,"end_line":313,"end_character":51},"in_reply_to":"9f560f44_288dbc7b","updated":"2020-09-10 02:15:06.000000000","message":"Done","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6aca1109d6cad40af7a02da67c479891279eb130","unresolved":false,"context_lines":[{"line_number":379,"context_line":"                bool_param_values[\u0027nondisruptive\u0027],"},{"line_number":380,"context_line":"                bool_param_values[\u0027preserve_snapshots\u0027],"},{"line_number":381,"context_line":"                new_share_network\u003dnew_share_network)"},{"line_number":382,"context_line":"        except (exception.InvalidShareServer,"},{"line_number":383,"context_line":"                exception.ServiceIsDown) as e:"},{"line_number":384,"context_line":"            raise exc.HTTPConflict(explanation\u003de.msg)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"        return self._migration_view_builder.build_check_migration("},{"line_number":387,"context_line":"            params, result)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_c8e24001","line":384,"range":{"start_line":382,"start_character":0,"end_line":384,"end_character":53},"updated":"2020-09-09 18:49:51.000000000","message":"align with migration_start..","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b6515f490448625bb3fe67aa5583230922ec197c","unresolved":false,"context_lines":[{"line_number":379,"context_line":"                bool_param_values[\u0027nondisruptive\u0027],"},{"line_number":380,"context_line":"                bool_param_values[\u0027preserve_snapshots\u0027],"},{"line_number":381,"context_line":"                new_share_network\u003dnew_share_network)"},{"line_number":382,"context_line":"        except (exception.InvalidShareServer,"},{"line_number":383,"context_line":"                exception.ServiceIsDown) as e:"},{"line_number":384,"context_line":"            raise exc.HTTPConflict(explanation\u003de.msg)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"        return self._migration_view_builder.build_check_migration("},{"line_number":387,"context_line":"            params, result)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_be457db6","line":384,"range":{"start_line":382,"start_character":0,"end_line":384,"end_character":53},"in_reply_to":"9f560f44_c8e24001","updated":"2020-09-10 02:15:06.000000000","message":"make sense, done","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"829ae2fac08fd4a0f599c8efd589d36bab7ce876","unresolved":false,"context_lines":[{"line_number":383,"context_line":"                exception.ServiceIsDown) as e:"},{"line_number":384,"context_line":"            raise exc.HTTPConflict(explanation\u003de.msg)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"        return self._migration_view_builder.build_check_migration("},{"line_number":387,"context_line":"            params, result)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_a8942c37","line":386,"range":{"start_line":386,"start_character":65,"end_line":386,"end_character":66},"updated":"2020-09-09 19:37:09.000000000","message":"send req, so you can use it for context lookup if necessary..","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b6515f490448625bb3fe67aa5583230922ec197c","unresolved":false,"context_lines":[{"line_number":383,"context_line":"                exception.ServiceIsDown) as e:"},{"line_number":384,"context_line":"            raise exc.HTTPConflict(explanation\u003de.msg)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"        return self._migration_view_builder.build_check_migration("},{"line_number":387,"context_line":"            params, result)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_9e4079a4","line":386,"range":{"start_line":386,"start_character":65,"end_line":386,"end_character":66},"in_reply_to":"9f560f44_a8942c37","updated":"2020-09-10 02:15:06.000000000","message":"Done","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"9ebc6a76945a7bb08720d21aa500e296a78dc2d9","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @wsgi.Controller.api_version(\u00272.49\u0027)  # noqa"},{"line_number":87,"context_line":"    @wsgi.response(202)"},{"line_number":88,"context_line":"    def manage(self, req, body):  # pylint: disable\u003dfunction-redefined"},{"line_number":89,"context_line":"        body.get(\u0027share_server\u0027, {}).pop(\u0027share_network_subnet_id\u0027, None)"},{"line_number":90,"context_line":"        return self._manage(req, body)"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_49110d5d","line":88,"updated":"2020-09-10 04:42:44.000000000","message":"pep8: F811 redefinition of unused \u0027manage\u0027 from line 83","commit_id":"f9b3eb32a920964513e49c5a7726590e62217baf"}],"manila/api/views/share_server_migration.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3b0f57d7c0bac5f7fa3f21cdf46bb5e142c5c145","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def build_check_migration(self, params, result):"},{"line_number":37,"context_line":"        \"\"\"View of share server migration check.\"\"\""},{"line_number":38,"context_line":"        requested_capabilities \u003d {"},{"line_number":39,"context_line":"            \u0027writable\u0027: params[\u0027writable\u0027],"},{"line_number":40,"context_line":"            \u0027nondisruptive\u0027: params[\u0027nondisruptive\u0027],"},{"line_number":41,"context_line":"            \u0027preserve_snapshots\u0027: params[\u0027preserve_snapshots\u0027],"},{"line_number":42,"context_line":"            \u0027share_network_id\u0027: params[\u0027new_share_network_id\u0027],"},{"line_number":43,"context_line":"            \u0027host\u0027: params[\u0027host\u0027],"},{"line_number":44,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_d365511f","line":41,"range":{"start_line":39,"start_character":12,"end_line":41,"end_character":63},"updated":"2020-09-01 19:21:13.000000000","message":"Ensure these are booleans","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5de59631aac220c6052c8b5a4e0320358f1f6294","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def build_check_migration(self, params, result):"},{"line_number":37,"context_line":"        \"\"\"View of share server migration check.\"\"\""},{"line_number":38,"context_line":"        requested_capabilities \u003d {"},{"line_number":39,"context_line":"            \u0027writable\u0027: params[\u0027writable\u0027],"},{"line_number":40,"context_line":"            \u0027nondisruptive\u0027: params[\u0027nondisruptive\u0027],"},{"line_number":41,"context_line":"            \u0027preserve_snapshots\u0027: params[\u0027preserve_snapshots\u0027],"},{"line_number":42,"context_line":"            \u0027share_network_id\u0027: params[\u0027new_share_network_id\u0027],"},{"line_number":43,"context_line":"            \u0027host\u0027: params[\u0027host\u0027],"},{"line_number":44,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_0008d125","line":41,"range":{"start_line":39,"start_character":12,"end_line":41,"end_character":63},"in_reply_to":"9f560f44_d365511f","updated":"2020-09-08 12:22:09.000000000","message":"you mean check again here? Or only in the api[1] is ok?\n[1] https://review.opendev.org/#/c/747043/5/manila/api/v2/share_servers.py@362","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"829ae2fac08fd4a0f599c8efd589d36bab7ce876","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        self.update_versioned_resource_dict(request, result, progress)"},{"line_number":34,"context_line":"        return result"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def build_check_migration(self, params, result):"},{"line_number":37,"context_line":"        \"\"\"View of share server migration check.\"\"\""},{"line_number":38,"context_line":"        requested_capabilities \u003d {"},{"line_number":39,"context_line":"            \u0027writable\u0027: params[\u0027writable\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_6805f479","line":36,"range":{"start_line":36,"start_character":35,"end_line":36,"end_character":36},"updated":"2020-09-09 19:37:09.000000000","message":"accept request object here for context checking in the future.","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b6515f490448625bb3fe67aa5583230922ec197c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        self.update_versioned_resource_dict(request, result, progress)"},{"line_number":34,"context_line":"        return result"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def build_check_migration(self, params, result):"},{"line_number":37,"context_line":"        \"\"\"View of share server migration check.\"\"\""},{"line_number":38,"context_line":"        requested_capabilities \u003d {"},{"line_number":39,"context_line":"            \u0027writable\u0027: params[\u0027writable\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_5ed6e1c4","line":36,"range":{"start_line":36,"start_character":35,"end_line":36,"end_character":36},"in_reply_to":"9f560f44_6805f479","updated":"2020-09-10 02:15:06.000000000","message":"Done","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"829ae2fac08fd4a0f599c8efd589d36bab7ce876","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            \u0027requested_capabilities\u0027: requested_capabilities,"},{"line_number":56,"context_line":"            \u0027supported_capabilities\u0027: supported_capabilities,"},{"line_number":57,"context_line":"        }"},{"line_number":58,"context_line":"        return view"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_a830ac56","line":58,"range":{"start_line":58,"start_character":7,"end_line":58,"end_character":19},"updated":"2020-09-09 19:37:09.000000000","message":"call update_versioned_resource_dict here too.. \n\n \n capabilities \u003d {\u0027requested\u0027: copy.copy(params), \u0027supported\u0027: copy.copy(result)}\n self.update_versioned_resource_dict(req, view, capabilities)","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b6515f490448625bb3fe67aa5583230922ec197c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            \u0027requested_capabilities\u0027: requested_capabilities,"},{"line_number":56,"context_line":"            \u0027supported_capabilities\u0027: supported_capabilities,"},{"line_number":57,"context_line":"        }"},{"line_number":58,"context_line":"        return view"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_9edcf9e1","line":58,"range":{"start_line":58,"start_character":7,"end_line":58,"end_character":19},"in_reply_to":"9f560f44_a830ac56","updated":"2020-09-10 02:15:06.000000000","message":"Done","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"}],"manila/db/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"829ae2fac08fd4a0f599c8efd589d36bab7ce876","unresolved":false,"context_lines":[{"line_number":354,"context_line":"    \"\"\"Returns all share instances with given share_server_id.\"\"\""},{"line_number":355,"context_line":"    return IMPL.share_instances_get_all_by_share_server(context,"},{"line_number":356,"context_line":"                                                        share_server_id,"},{"line_number":357,"context_line":"                                                        with_share_data)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"def share_instances_get_all_by_host(context, host, with_share_data\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_c83a4032","line":357,"range":{"start_line":357,"start_character":56,"end_line":357,"end_character":71},"updated":"2020-09-09 19:37:09.000000000","message":"pass kwargs as kwargs","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b6515f490448625bb3fe67aa5583230922ec197c","unresolved":false,"context_lines":[{"line_number":354,"context_line":"    \"\"\"Returns all share instances with given share_server_id.\"\"\""},{"line_number":355,"context_line":"    return IMPL.share_instances_get_all_by_share_server(context,"},{"line_number":356,"context_line":"                                                        share_server_id,"},{"line_number":357,"context_line":"                                                        with_share_data)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"def share_instances_get_all_by_host(context, host, with_share_data\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_def31172","line":357,"range":{"start_line":357,"start_character":56,"end_line":357,"end_character":71},"in_reply_to":"9f560f44_c83a4032","updated":"2020-09-10 02:15:06.000000000","message":"Done","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"829ae2fac08fd4a0f599c8efd589d36bab7ce876","unresolved":false,"context_lines":[{"line_number":687,"context_line":"        context, share_snapshot_instance_id, export_locations, delete\u003dTrue):"},{"line_number":688,"context_line":"    \"\"\"Update export locations of a share instance.\"\"\""},{"line_number":689,"context_line":"    return IMPL.share_snapshot_instance_export_locations_update("},{"line_number":690,"context_line":"        context, share_snapshot_instance_id, export_locations, delete)"},{"line_number":691,"context_line":""},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"def share_snapshot_instance_export_locations_get_all("}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_681334b9","line":690,"range":{"start_line":690,"start_character":63,"end_line":690,"end_character":69},"updated":"2020-09-09 19:37:09.000000000","message":"pass kwargs as kwargs","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b6515f490448625bb3fe67aa5583230922ec197c","unresolved":false,"context_lines":[{"line_number":687,"context_line":"        context, share_snapshot_instance_id, export_locations, delete\u003dTrue):"},{"line_number":688,"context_line":"    \"\"\"Update export locations of a share instance.\"\"\""},{"line_number":689,"context_line":"    return IMPL.share_snapshot_instance_export_locations_update("},{"line_number":690,"context_line":"        context, share_snapshot_instance_id, export_locations, delete)"},{"line_number":691,"context_line":""},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"def share_snapshot_instance_export_locations_get_all("}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_3ee7adae","line":690,"range":{"start_line":690,"start_character":63,"end_line":690,"end_character":69},"in_reply_to":"9f560f44_681334b9","updated":"2020-09-10 02:15:06.000000000","message":"Done","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"}],"manila/db/migrations/alembic/versions/5aa813ae673d_add_task_state_field_for_share_servers_.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"36730a28b46fbaed0d8044198a76d00f2fd9786c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9f560f44_60605102","updated":"2020-09-10 21:10:04.000000000","message":"Any reason why this file has a underscore at the end of the name?","commit_id":"39efc2bde81c2a0c747a491d3a778b822ca263b8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"56b8324af64aefd2d83415ed97deec51d32510a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9f560f44_63ddfb6e","in_reply_to":"9f560f44_60605102","updated":"2020-09-10 21:46:43.000000000","message":"Ops. Wasn\u0027t supposed to have it :)\nWill remove","commit_id":"39efc2bde81c2a0c747a491d3a778b822ca263b8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"713d72cdde5629a16dc53193de741c46254722a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9f560f44_0384ff09","in_reply_to":"9f560f44_63ddfb6e","updated":"2020-09-10 21:49:19.000000000","message":"Will remove in another change or in the next patch if there will be need to upload another one in this change* :)","commit_id":"39efc2bde81c2a0c747a491d3a778b822ca263b8"}],"manila/db/sqlalchemy/models.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7f805c7033d85bc64642db4bc4ac5bb519e30b94","unresolved":false,"context_lines":[{"line_number":1011,"context_line":"    is_auto_deletable \u003d Column(Boolean, default\u003dTrue)"},{"line_number":1012,"context_line":"    identifier \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":1013,"context_line":"    task_state \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":1014,"context_line":"    source_share_server_id \u003d Column(String(36), nullable\u003dTrue)"},{"line_number":1015,"context_line":"    status \u003d Column(Enum("},{"line_number":1016,"context_line":"        constants.STATUS_INACTIVE, constants.STATUS_ACTIVE,"},{"line_number":1017,"context_line":"        constants.STATUS_ERROR, constants.STATUS_DELETING,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_0f7efd68","line":1014,"range":{"start_line":1014,"start_character":29,"end_line":1014,"end_character":62},"updated":"2020-09-09 20:10:35.000000000","message":"ForeignKey(\u0027share_servers.id\u0027)","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b6515f490448625bb3fe67aa5583230922ec197c","unresolved":false,"context_lines":[{"line_number":1011,"context_line":"    is_auto_deletable \u003d Column(Boolean, default\u003dTrue)"},{"line_number":1012,"context_line":"    identifier \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":1013,"context_line":"    task_state \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":1014,"context_line":"    source_share_server_id \u003d Column(String(36), nullable\u003dTrue)"},{"line_number":1015,"context_line":"    status \u003d Column(Enum("},{"line_number":1016,"context_line":"        constants.STATUS_INACTIVE, constants.STATUS_ACTIVE,"},{"line_number":1017,"context_line":"        constants.STATUS_ERROR, constants.STATUS_DELETING,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_7e04854a","line":1014,"range":{"start_line":1014,"start_character":29,"end_line":1014,"end_character":62},"in_reply_to":"9f560f44_0f7efd68","updated":"2020-09-10 02:15:06.000000000","message":"Done","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"}],"manila/share/api.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a36c8f88a7176a12b9598b0abb4c496bfe2bb826","unresolved":false,"context_lines":[{"line_number":2397,"context_line":"                                     new_share_network\u003dNone):"},{"line_number":2398,"context_line":"        \"\"\"Migrates share server to a new host.\"\"\""},{"line_number":2399,"context_line":""},{"line_number":2400,"context_line":"        shares, types, service, new_share_network_id \u003d ("},{"line_number":2401,"context_line":"            self._migration_initial_checks(context, share_server, dest_host,"},{"line_number":2402,"context_line":"                                           new_share_network))"},{"line_number":2403,"context_line":""},{"line_number":2404,"context_line":"        result \u003d self.share_rpcapi.share_server_migration_check("},{"line_number":2405,"context_line":"            context, share_server[\u0027id\u0027], dest_host, writable, nondisruptive,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_521fff6a","line":2402,"range":{"start_line":2400,"start_character":0,"end_line":2402,"end_character":62},"updated":"2020-09-01 01:58:08.000000000","message":"try/except","commit_id":"8ecca23f456549c9dd405273b944b4063ca2b026"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3b0f57d7c0bac5f7fa3f21cdf46bb5e142c5c145","unresolved":false,"context_lines":[{"line_number":2267,"context_line":""},{"line_number":2268,"context_line":"    def get_share_server_migration_request_spec_dict("},{"line_number":2269,"context_line":"            self, context, share_instances, snapshot_instances, **kwargs):"},{"line_number":2270,"context_line":""},{"line_number":2271,"context_line":"        shares_total_size \u003d sum([instance.get(\u0027size\u0027, 0)"},{"line_number":2272,"context_line":"                                 for instance in share_instances])"},{"line_number":2273,"context_line":"        snapshots_total_size \u003d sum([instance.get(\u0027size\u0027, 0)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_c2a3bcff","line":2270,"range":{"start_line":2270,"start_character":0,"end_line":2270,"end_character":0},"updated":"2020-09-01 19:21:13.000000000","message":"Docstring please, including where it is used..","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5de59631aac220c6052c8b5a4e0320358f1f6294","unresolved":false,"context_lines":[{"line_number":2267,"context_line":""},{"line_number":2268,"context_line":"    def get_share_server_migration_request_spec_dict("},{"line_number":2269,"context_line":"            self, context, share_instances, snapshot_instances, **kwargs):"},{"line_number":2270,"context_line":""},{"line_number":2271,"context_line":"        shares_total_size \u003d sum([instance.get(\u0027size\u0027, 0)"},{"line_number":2272,"context_line":"                                 for instance in share_instances])"},{"line_number":2273,"context_line":"        snapshots_total_size \u003d sum([instance.get(\u0027size\u0027, 0)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_7b585c55","line":2270,"range":{"start_line":2270,"start_character":0,"end_line":2270,"end_character":0},"in_reply_to":"9f560f44_c2a3bcff","updated":"2020-09-08 12:22:09.000000000","message":"Done","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3b0f57d7c0bac5f7fa3f21cdf46bb5e142c5c145","unresolved":false,"context_lines":[{"line_number":2331,"context_line":"                    \"before starting a new migration.\")"},{"line_number":2332,"context_line":"            raise exception.InvalidShareServer(reason\u003dmsg)"},{"line_number":2333,"context_line":""},{"line_number":2334,"context_line":"        for share in shares:"},{"line_number":2335,"context_line":"            if share[\u0027status\u0027] !\u003d constants.STATUS_AVAILABLE:"},{"line_number":2336,"context_line":"                msg \u003d _(\u0027Share %(share_id)s status must be available, \u0027"},{"line_number":2337,"context_line":"                        \u0027but current status is: %(share_status)s.\u0027) % {"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_3f20cff7","line":2334,"range":{"start_line":2334,"start_character":8,"end_line":2334,"end_character":28},"updated":"2020-09-01 19:21:13.000000000","message":"It\u0027s possible that between the retrieval on 2294 and this line, some share operation is initiated.","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5de59631aac220c6052c8b5a4e0320358f1f6294","unresolved":false,"context_lines":[{"line_number":2331,"context_line":"                    \"before starting a new migration.\")"},{"line_number":2332,"context_line":"            raise exception.InvalidShareServer(reason\u003dmsg)"},{"line_number":2333,"context_line":""},{"line_number":2334,"context_line":"        for share in shares:"},{"line_number":2335,"context_line":"            if share[\u0027status\u0027] !\u003d constants.STATUS_AVAILABLE:"},{"line_number":2336,"context_line":"                msg \u003d _(\u0027Share %(share_id)s status must be available, \u0027"},{"line_number":2337,"context_line":"                        \u0027but current status is: %(share_status)s.\u0027) % {"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_3b7544cd","line":2334,"range":{"start_line":2334,"start_character":8,"end_line":2334,"end_character":28},"in_reply_to":"9f560f44_3f20cff7","updated":"2020-09-08 12:22:09.000000000","message":"Done. Added some extra validations in the db layer to ensure that at least the shares and snapshots\u0027 status haven\u0027t changed.","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3b0f57d7c0bac5f7fa3f21cdf46bb5e142c5c145","unresolved":false,"context_lines":[{"line_number":2463,"context_line":"            context, share_server, dest_host, writable, nondisruptive,"},{"line_number":2464,"context_line":"            preserve_snapshots, new_share_network_id)"},{"line_number":2465,"context_line":""},{"line_number":2466,"context_line":"        return 202"},{"line_number":2467,"context_line":""},{"line_number":2468,"context_line":"    def share_server_migration_complete(self, context, share_server):"},{"line_number":2469,"context_line":"        \"\"\"Invokes 2nd phase of share server migration.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_3f060f22","line":2466,"range":{"start_line":2466,"start_character":8,"end_line":2466,"end_character":18},"updated":"2020-09-01 19:21:13.000000000","message":"remove, move to api wrapper file..","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5de59631aac220c6052c8b5a4e0320358f1f6294","unresolved":false,"context_lines":[{"line_number":2463,"context_line":"            context, share_server, dest_host, writable, nondisruptive,"},{"line_number":2464,"context_line":"            preserve_snapshots, new_share_network_id)"},{"line_number":2465,"context_line":""},{"line_number":2466,"context_line":"        return 202"},{"line_number":2467,"context_line":""},{"line_number":2468,"context_line":"    def share_server_migration_complete(self, context, share_server):"},{"line_number":2469,"context_line":"        \"\"\"Invokes 2nd phase of share server migration.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_a029258a","line":2466,"range":{"start_line":2466,"start_character":8,"end_line":2466,"end_character":18},"in_reply_to":"9f560f44_3f060f22","updated":"2020-09-08 12:22:09.000000000","message":"Done","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3b0f57d7c0bac5f7fa3f21cdf46bb5e142c5c145","unresolved":false,"context_lines":[{"line_number":2514,"context_line":"            msg \u003d self._migration_validate_error_message("},{"line_number":2515,"context_line":"                share_server, resource_type\u003d\u0027share_server\u0027)"},{"line_number":2516,"context_line":"            if msg is None:"},{"line_number":2517,"context_line":"                msg \u003d _(\"Migration of share server %s cannot be cancelled at \""},{"line_number":2518,"context_line":"                        \"this moment.\") % share_server[\u0027id\u0027]"},{"line_number":2519,"context_line":"            LOG.error(msg)"},{"line_number":2520,"context_line":"            raise exception.InvalidShareServer(reason\u003dmsg)"},{"line_number":2521,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_ff0bf727","line":2518,"range":{"start_line":2517,"start_character":25,"end_line":2518,"end_character":37},"updated":"2020-09-01 19:21:13.000000000","message":"When can it be? Can we provide a hint?","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5de59631aac220c6052c8b5a4e0320358f1f6294","unresolved":false,"context_lines":[{"line_number":2514,"context_line":"            msg \u003d self._migration_validate_error_message("},{"line_number":2515,"context_line":"                share_server, resource_type\u003d\u0027share_server\u0027)"},{"line_number":2516,"context_line":"            if msg is None:"},{"line_number":2517,"context_line":"                msg \u003d _(\"Migration of share server %s cannot be cancelled at \""},{"line_number":2518,"context_line":"                        \"this moment.\") % share_server[\u0027id\u0027]"},{"line_number":2519,"context_line":"            LOG.error(msg)"},{"line_number":2520,"context_line":"            raise exception.InvalidShareServer(reason\u003dmsg)"},{"line_number":2521,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_7b2dfca6","line":2518,"range":{"start_line":2517,"start_character":25,"end_line":2518,"end_character":37},"in_reply_to":"9f560f44_ff0bf727","updated":"2020-09-08 12:22:09.000000000","message":"Done","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eff5f4519b4527415dbe2c898293ae45254fba83","unresolved":false,"context_lines":[{"line_number":2359,"context_line":"            azs \u003d share_type[\u0027extra_specs\u0027].get(\u0027availability_zones\u0027, \u0027\u0027)"},{"line_number":2360,"context_line":"            if azs and service[\u0027availability_zone\u0027][\u0027name\u0027] not in azs:"},{"line_number":2361,"context_line":"                msg \u003d _(\"Share server %(server)s cannot be migrated to host \""},{"line_number":2362,"context_line":"                        \"%(dest)s because share type %(type)s present in one \""},{"line_number":2363,"context_line":"                        \"of its shares, and it is not supported within the \""},{"line_number":2364,"context_line":"                        \"availability zone (%(az)s) that the host is in.\")"},{"line_number":2365,"context_line":"                type_name \u003d \u0027%s\u0027 % (share_type[\u0027name\u0027] or \u0027\u0027)"},{"line_number":2366,"context_line":"                type_id \u003d \u0027(ID: %s)\u0027 % share_type[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_7204be4a","line":2363,"range":{"start_line":2362,"start_character":62,"end_line":2363,"end_character":38},"updated":"2020-09-09 21:40:20.000000000","message":"is used by one of the shares, and this share type is not supported","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b6515f490448625bb3fe67aa5583230922ec197c","unresolved":false,"context_lines":[{"line_number":2359,"context_line":"            azs \u003d share_type[\u0027extra_specs\u0027].get(\u0027availability_zones\u0027, \u0027\u0027)"},{"line_number":2360,"context_line":"            if azs and service[\u0027availability_zone\u0027][\u0027name\u0027] not in azs:"},{"line_number":2361,"context_line":"                msg \u003d _(\"Share server %(server)s cannot be migrated to host \""},{"line_number":2362,"context_line":"                        \"%(dest)s because share type %(type)s present in one \""},{"line_number":2363,"context_line":"                        \"of its shares, and it is not supported within the \""},{"line_number":2364,"context_line":"                        \"availability zone (%(az)s) that the host is in.\")"},{"line_number":2365,"context_line":"                type_name \u003d \u0027%s\u0027 % (share_type[\u0027name\u0027] or \u0027\u0027)"},{"line_number":2366,"context_line":"                type_id \u003d \u0027(ID: %s)\u0027 % share_type[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_1e6d8902","line":2363,"range":{"start_line":2362,"start_character":62,"end_line":2363,"end_character":38},"in_reply_to":"9f560f44_7204be4a","updated":"2020-09-10 02:15:06.000000000","message":"done, thanks","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eff5f4519b4527415dbe2c898293ae45254fba83","unresolved":false,"context_lines":[{"line_number":2515,"context_line":"        if (share_server[\u0027status\u0027] !\u003d constants.STATUS_SERVER_MIGRATING"},{"line_number":2516,"context_line":"                or (share_server[\u0027task_state\u0027] !\u003d"},{"line_number":2517,"context_line":"                    constants.TASK_STATE_MIGRATION_DRIVER_PHASE1_DONE)):"},{"line_number":2518,"context_line":"            msg \u003d _(\"Share server %s is not migrating or the first migration \""},{"line_number":2519,"context_line":"                    \"phase did not completed yet.\") % share_server[\u0027id\u0027]"},{"line_number":2520,"context_line":"            LOG.error(msg)"},{"line_number":2521,"context_line":"            raise exception.InvalidShareServer(reason\u003dmsg)"},{"line_number":2522,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_72fafe74","line":2519,"range":{"start_line":2518,"start_character":11,"end_line":2519,"end_character":72},"updated":"2020-09-09 21:40:20.000000000","message":"suggest separating these error messages. \n\n\"Share server %s is not migrating\"\n\n\"The first phase of migration has to finish to request the completion of server %s\u0027s migration\"","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b6515f490448625bb3fe67aa5583230922ec197c","unresolved":false,"context_lines":[{"line_number":2515,"context_line":"        if (share_server[\u0027status\u0027] !\u003d constants.STATUS_SERVER_MIGRATING"},{"line_number":2516,"context_line":"                or (share_server[\u0027task_state\u0027] !\u003d"},{"line_number":2517,"context_line":"                    constants.TASK_STATE_MIGRATION_DRIVER_PHASE1_DONE)):"},{"line_number":2518,"context_line":"            msg \u003d _(\"Share server %s is not migrating or the first migration \""},{"line_number":2519,"context_line":"                    \"phase did not completed yet.\") % share_server[\u0027id\u0027]"},{"line_number":2520,"context_line":"            LOG.error(msg)"},{"line_number":2521,"context_line":"            raise exception.InvalidShareServer(reason\u003dmsg)"},{"line_number":2522,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_5e7261e4","line":2519,"range":{"start_line":2518,"start_character":11,"end_line":2519,"end_character":72},"in_reply_to":"9f560f44_72fafe74","updated":"2020-09-10 02:15:06.000000000","message":"sure, thanks!","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eed7b86897c360da2b73851ce79c02d229494e94","unresolved":false,"context_lines":[{"line_number":2571,"context_line":""},{"line_number":2572,"context_line":"        if share_server[\u0027status\u0027] !\u003d constants.STATUS_SERVER_MIGRATING:"},{"line_number":2573,"context_line":"            msg \u003d _(\"Migration progress of share server %s cannot be \""},{"line_number":2574,"context_line":"                    \"obtained. The provided share server is not being \""},{"line_number":2575,"context_line":"                    \"migrated.\") % share_server[\u0027id\u0027]"},{"line_number":2576,"context_line":"            LOG.error(msg)"},{"line_number":2577,"context_line":"            raise exception.InvalidShareServer(reason\u003dmsg)"},{"line_number":2578,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_8fe84ddf","line":2575,"range":{"start_line":2574,"start_character":64,"end_line":2575,"end_character":29},"updated":"2020-09-09 20:31:26.000000000","message":"\"the source of an ongoing migration\"?\n\nBecause the request can be made with a share server that has the status \"migrating_to\"","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eed7b86897c360da2b73851ce79c02d229494e94","unresolved":false,"context_lines":[{"line_number":2573,"context_line":"            msg \u003d _(\"Migration progress of share server %s cannot be \""},{"line_number":2574,"context_line":"                    \"obtained. The provided share server is not being \""},{"line_number":2575,"context_line":"                    \"migrated.\") % share_server[\u0027id\u0027]"},{"line_number":2576,"context_line":"            LOG.error(msg)"},{"line_number":2577,"context_line":"            raise exception.InvalidShareServer(reason\u003dmsg)"},{"line_number":2578,"context_line":""},{"line_number":2579,"context_line":"        if (share_server[\u0027task_state\u0027] \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_0fab9d87","line":2576,"range":{"start_line":2576,"start_character":0,"end_line":2576,"end_character":12},"updated":"2020-09-09 20:31:26.000000000","message":"How does one know when the migration is complete?\nWhen the The source share server will be deleted and this call will fail - Should we disallow the call with the source and ask that they check with the destination?\n\ni.e.; if a request to get progress is made with an ID of a server that\u0027s begun migration, we query the database for a server with the \"source_share_server_id\" set to the ID in the request, and still relay the progress - and perhaps, respond with the destination share server ID in the start_migration API. WDYT?\n\nWhen the share server is deleted, they will then know why","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5ec6e2ce27c127370a6fcec98ee4d12a3f8089ad","unresolved":false,"context_lines":[{"line_number":2573,"context_line":"            msg \u003d _(\"Migration progress of share server %s cannot be \""},{"line_number":2574,"context_line":"                    \"obtained. The provided share server is not being \""},{"line_number":2575,"context_line":"                    \"migrated.\") % share_server[\u0027id\u0027]"},{"line_number":2576,"context_line":"            LOG.error(msg)"},{"line_number":2577,"context_line":"            raise exception.InvalidShareServer(reason\u003dmsg)"},{"line_number":2578,"context_line":""},{"line_number":2579,"context_line":"        if (share_server[\u0027task_state\u0027] \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_2fe4a1df","line":2576,"range":{"start_line":2576,"start_character":0,"end_line":2576,"end_character":12},"in_reply_to":"9f560f44_0fab9d87","updated":"2020-09-09 20:32:34.000000000","message":"s/i.e./or","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"23051afac0f4b8136541d383c898daa848d54190","unresolved":false,"context_lines":[{"line_number":2573,"context_line":"            msg \u003d _(\"Migration progress of share server %s cannot be \""},{"line_number":2574,"context_line":"                    \"obtained. The provided share server is not being \""},{"line_number":2575,"context_line":"                    \"migrated.\") % share_server[\u0027id\u0027]"},{"line_number":2576,"context_line":"            LOG.error(msg)"},{"line_number":2577,"context_line":"            raise exception.InvalidShareServer(reason\u003dmsg)"},{"line_number":2578,"context_line":""},{"line_number":2579,"context_line":"        if (share_server[\u0027task_state\u0027] \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_8f196dd2","line":2576,"range":{"start_line":2576,"start_character":0,"end_line":2576,"end_character":12},"in_reply_to":"9f560f44_2fe4a1df","updated":"2020-09-09 20:38:19.000000000","message":"My concern is that this API works until phase 1 is complete, but can stop working at phase 2 with a 404 because the share server doesn\u0027t exist.. which sounds a bit weird, no? Is this the expected behavior? If yes, we can document it so... \n\nBut, unless an administrator requests to list share servers before phase2, they won\u0027t know what the destination share server ID is... So perhaps the migration_start API and migration_get_progress APIs should return the destination share server ID.","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"693dc2f77dbcff2e94dbc7f6de40e1bb376ea9db","unresolved":false,"context_lines":[{"line_number":2573,"context_line":"            msg \u003d _(\"Migration progress of share server %s cannot be \""},{"line_number":2574,"context_line":"                    \"obtained. The provided share server is not being \""},{"line_number":2575,"context_line":"                    \"migrated.\") % share_server[\u0027id\u0027]"},{"line_number":2576,"context_line":"            LOG.error(msg)"},{"line_number":2577,"context_line":"            raise exception.InvalidShareServer(reason\u003dmsg)"},{"line_number":2578,"context_line":""},{"line_number":2579,"context_line":"        if (share_server[\u0027task_state\u0027] \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_d2082ada","line":2576,"range":{"start_line":2576,"start_character":0,"end_line":2576,"end_character":12},"in_reply_to":"9f560f44_8f196dd2","updated":"2020-09-09 21:08:08.000000000","message":"Its true, admin may face hard times to identify destination ids since we don\u0027t provide in any API so far. I think that is feasible to provide the the destination share-server-id in the migration-get-progress and migration-complete. \n\nAbout \u0027get-progress\u0027 we can check in the DB for the source_share_server_id, but we\u0027ll need to skip the validation on the api, that check if the id exists. I think that makes sense too.","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b8bace1a076a9d487a543d246238888b73b7e757","unresolved":false,"context_lines":[{"line_number":2596,"context_line":"                \u0027task_state\u0027: dest_share_server[\u0027task_state\u0027],"},{"line_number":2597,"context_line":"            }"},{"line_number":2598,"context_line":"        # Source server still exists so it must be in \u0027server_migrating\u0027 status"},{"line_number":2599,"context_line":"        if (share_server and"},{"line_number":2600,"context_line":"                share_server[\u0027status\u0027] !\u003d constants.STATUS_SERVER_MIGRATING):"},{"line_number":2601,"context_line":"            msg \u003d _(\"Migration progress of share server %s cannot be \""},{"line_number":2602,"context_line":"                    \"obtained. The provided share server is not being \""}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_5642383c","line":2599,"range":{"start_line":2599,"start_character":8,"end_line":2599,"end_character":24},"updated":"2020-09-10 18:17:53.000000000","message":"not necessary?","commit_id":"39efc2bde81c2a0c747a491d3a778b822ca263b8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8c54f95259bf833451753c00c601bf11f985622e","unresolved":false,"context_lines":[{"line_number":2596,"context_line":"                \u0027task_state\u0027: dest_share_server[\u0027task_state\u0027],"},{"line_number":2597,"context_line":"            }"},{"line_number":2598,"context_line":"        # Source server still exists so it must be in \u0027server_migrating\u0027 status"},{"line_number":2599,"context_line":"        if (share_server and"},{"line_number":2600,"context_line":"                share_server[\u0027status\u0027] !\u003d constants.STATUS_SERVER_MIGRATING):"},{"line_number":2601,"context_line":"            msg \u003d _(\"Migration progress of share server %s cannot be \""},{"line_number":2602,"context_line":"                    \"obtained. The provided share server is not being \""}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_36fa2474","line":2599,"range":{"start_line":2599,"start_character":8,"end_line":2599,"end_character":24},"in_reply_to":"9f560f44_5642383c","updated":"2020-09-10 18:29:45.000000000","message":"I agree that it is not necessary, since if the share server was not found, the code statement from line 2581 will raise an exception.\nWill remove in the next PS","commit_id":"39efc2bde81c2a0c747a491d3a778b822ca263b8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"e94d07812d2b2560b5899326d74530a82be0524b","unresolved":false,"context_lines":[{"line_number":2596,"context_line":"                \u0027task_state\u0027: dest_share_server[\u0027task_state\u0027],"},{"line_number":2597,"context_line":"            }"},{"line_number":2598,"context_line":"        # Source server still exists so it must be in \u0027server_migrating\u0027 status"},{"line_number":2599,"context_line":"        if (share_server and"},{"line_number":2600,"context_line":"                share_server[\u0027status\u0027] !\u003d constants.STATUS_SERVER_MIGRATING):"},{"line_number":2601,"context_line":"            msg \u003d _(\"Migration progress of share server %s cannot be \""},{"line_number":2602,"context_line":"                    \"obtained. The provided share server is not being \""}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_76f01c92","line":2599,"range":{"start_line":2599,"start_character":8,"end_line":2599,"end_character":24},"in_reply_to":"9f560f44_5642383c","updated":"2020-09-10 18:29:01.000000000","message":"not its not :)","commit_id":"39efc2bde81c2a0c747a491d3a778b822ca263b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b8bace1a076a9d487a543d246238888b73b7e757","unresolved":false,"context_lines":[{"line_number":2640,"context_line":""},{"line_number":2641,"context_line":"        result.update({"},{"line_number":2642,"context_line":"            \u0027destination_share_server_id\u0027: dest_share_server[\u0027id\u0027],"},{"line_number":2643,"context_line":"            \u0027task_state\u0027: dest_share_server[\u0027task_state\u0027]"},{"line_number":2644,"context_line":"        })"},{"line_number":2645,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_76a93c7a","line":2643,"range":{"start_line":2643,"start_character":12,"end_line":2643,"end_character":57},"updated":"2020-09-10 18:17:53.000000000","message":"I don\u0027t get this update. my understanding is that the destination\u0027s task states are never manipulated","commit_id":"39efc2bde81c2a0c747a491d3a778b822ca263b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"470e34b321b815e79a180c7938a9bf1cc026abc0","unresolved":false,"context_lines":[{"line_number":2640,"context_line":""},{"line_number":2641,"context_line":"        result.update({"},{"line_number":2642,"context_line":"            \u0027destination_share_server_id\u0027: dest_share_server[\u0027id\u0027],"},{"line_number":2643,"context_line":"            \u0027task_state\u0027: dest_share_server[\u0027task_state\u0027]"},{"line_number":2644,"context_line":"        })"},{"line_number":2645,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_4a68cc1f","line":2643,"range":{"start_line":2643,"start_character":12,"end_line":2643,"end_character":57},"in_reply_to":"9f560f44_362864e0","updated":"2020-09-10 19:15:35.000000000","message":"I see, I missed that - and probably misunderstood, thanks for the clarification!","commit_id":"39efc2bde81c2a0c747a491d3a778b822ca263b8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"e94d07812d2b2560b5899326d74530a82be0524b","unresolved":false,"context_lines":[{"line_number":2640,"context_line":""},{"line_number":2641,"context_line":"        result.update({"},{"line_number":2642,"context_line":"            \u0027destination_share_server_id\u0027: dest_share_server[\u0027id\u0027],"},{"line_number":2643,"context_line":"            \u0027task_state\u0027: dest_share_server[\u0027task_state\u0027]"},{"line_number":2644,"context_line":"        })"},{"line_number":2645,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_362864e0","line":2643,"range":{"start_line":2643,"start_character":12,"end_line":2643,"end_character":57},"in_reply_to":"9f560f44_76a93c7a","updated":"2020-09-10 18:29:01.000000000","message":"We decided, since the beginning of the implementation, that both source and destinations task_states can be updated. They always have the same task_state, so we can use destination or source here.\nThe admin can do a share-server-show in the destination server to search for the source-share-server-id and also see the task_state.","commit_id":"39efc2bde81c2a0c747a491d3a778b822ca263b8"}],"manila/share/driver.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a36c8f88a7176a12b9598b0abb4c496bfe2bb826","unresolved":false,"context_lines":[{"line_number":2878,"context_line":""},{"line_number":2879,"context_line":"        :param context: The \u0027context.RequestContext\u0027 object for the request."},{"line_number":2880,"context_line":"        :param src_share_server: Reference to the original share server."},{"line_number":2881,"context_line":"        :param dest_share_server: Reference to the share server to be used by"},{"line_number":2882,"context_line":"            as destination."},{"line_number":2883,"context_line":"        :param shares: All shares in the source share server that should be"},{"line_number":2884,"context_line":"            migrated."}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_0a6d5531","line":2881,"range":{"start_line":2881,"start_character":75,"end_line":2881,"end_character":77},"updated":"2020-09-01 01:58:08.000000000","message":"remove","commit_id":"8ecca23f456549c9dd405273b944b4063ca2b026"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a36c8f88a7176a12b9598b0abb4c496bfe2bb826","unresolved":false,"context_lines":[{"line_number":2936,"context_line":"        \"\"\"Cancels migration of a given share server to another host."},{"line_number":2937,"context_line":""},{"line_number":2938,"context_line":"        .. note::"},{"line_number":2939,"context_line":"           Is called in source share server\u0027s backend to cancel migration."},{"line_number":2940,"context_line":""},{"line_number":2941,"context_line":"        If possible, driver can implement a way to cancel an in-progress"},{"line_number":2942,"context_line":"        migration."}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_b40bebd2","line":2939,"range":{"start_line":2939,"start_character":24,"end_line":2939,"end_character":30},"updated":"2020-09-01 01:58:08.000000000","message":"destination","commit_id":"8ecca23f456549c9dd405273b944b4063ca2b026"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a36c8f88a7176a12b9598b0abb4c496bfe2bb826","unresolved":false,"context_lines":[{"line_number":2977,"context_line":"            belong to the source share server. The backend can check if the"},{"line_number":2978,"context_line":"            capabilities match and if there is available space to the new share"},{"line_number":2979,"context_line":"            server."},{"line_number":2980,"context_line":"        :return: A dictionary containing values indicating if destination"},{"line_number":2981,"context_line":"            backend is compatible, if share can remain writable during"},{"line_number":2982,"context_line":"            migration, if it can preserve all file metadata and if it can"},{"line_number":2983,"context_line":"            perform migration of given share non-disruptively."},{"line_number":2984,"context_line":""},{"line_number":2985,"context_line":"            Example::"},{"line_number":2986,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d47adf21","line":2983,"range":{"start_line":2980,"start_character":17,"end_line":2983,"end_character":62},"updated":"2020-09-01 01:58:08.000000000","message":"update","commit_id":"8ecca23f456549c9dd405273b944b4063ca2b026"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a36c8f88a7176a12b9598b0abb4c496bfe2bb826","unresolved":false,"context_lines":[{"line_number":3011,"context_line":"        \"\"\"Completes migration of a given share server to another host."},{"line_number":3012,"context_line":""},{"line_number":3013,"context_line":"        .. note::"},{"line_number":3014,"context_line":"            Is called in source share server\u0027s backend to complete migration."},{"line_number":3015,"context_line":""},{"line_number":3016,"context_line":"        If driver is implementing 2-phase migration, this method should"},{"line_number":3017,"context_line":"        perform the disruptive tasks related to the 2nd phase of migration,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_1471f744","line":3014,"range":{"start_line":3014,"start_character":25,"end_line":3014,"end_character":31},"updated":"2020-09-01 01:58:08.000000000","message":"destination","commit_id":"8ecca23f456549c9dd405273b944b4063ca2b026"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a36c8f88a7176a12b9598b0abb4c496bfe2bb826","unresolved":false,"context_lines":[{"line_number":3013,"context_line":"        .. note::"},{"line_number":3014,"context_line":"            Is called in source share server\u0027s backend to complete migration."},{"line_number":3015,"context_line":""},{"line_number":3016,"context_line":"        If driver is implementing 2-phase migration, this method should"},{"line_number":3017,"context_line":"        perform the disruptive tasks related to the 2nd phase of migration,"},{"line_number":3018,"context_line":"        thus completing it. Driver should also delete all original data from"},{"line_number":3019,"context_line":"        source backend."},{"line_number":3020,"context_line":""},{"line_number":3021,"context_line":"        :param context: The \u0027context.RequestContext\u0027 object for the request."},{"line_number":3022,"context_line":"        :param src_share_server: Reference to the original share server."}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_949a275f","line":3019,"range":{"start_line":3016,"start_character":0,"end_line":3019,"end_character":23},"updated":"2020-09-01 01:58:08.000000000","message":"We only share 2-phase migration... re-phrase","commit_id":"8ecca23f456549c9dd405273b944b4063ca2b026"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7a1987f0f86373fd9b0a31b8da7b7843c3703974","unresolved":false,"context_lines":[{"line_number":2912,"context_line":"        raise NotImplementedError()"},{"line_number":2913,"context_line":""},{"line_number":2914,"context_line":"    def share_server_migration_get_progress(self, context, src_share_server,"},{"line_number":2915,"context_line":"                                            dest_share_server):"},{"line_number":2916,"context_line":"        \"\"\"Obtains progress of migration of a share server to another host."},{"line_number":2917,"context_line":""},{"line_number":2918,"context_line":"        .. note::"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_a2d208d0","line":2915,"range":{"start_line":2915,"start_character":61,"end_line":2915,"end_character":62},"updated":"2020-09-01 19:31:25.000000000","message":"add shares, snapshots here as well","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5de59631aac220c6052c8b5a4e0320358f1f6294","unresolved":false,"context_lines":[{"line_number":2912,"context_line":"        raise NotImplementedError()"},{"line_number":2913,"context_line":""},{"line_number":2914,"context_line":"    def share_server_migration_get_progress(self, context, src_share_server,"},{"line_number":2915,"context_line":"                                            dest_share_server):"},{"line_number":2916,"context_line":"        \"\"\"Obtains progress of migration of a share server to another host."},{"line_number":2917,"context_line":""},{"line_number":2918,"context_line":"        .. note::"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_5b28f895","line":2915,"range":{"start_line":2915,"start_character":61,"end_line":2915,"end_character":62},"in_reply_to":"9f560f44_a2d208d0","updated":"2020-09-08 12:22:09.000000000","message":"Done","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3b0f57d7c0bac5f7fa3f21cdf46bb5e142c5c145","unresolved":false,"context_lines":[{"line_number":2954,"context_line":""},{"line_number":2955,"context_line":"    def share_server_migration_check_compatibility("},{"line_number":2956,"context_line":"            self, context, share_server, dest_host, old_share_network,"},{"line_number":2957,"context_line":"            new_share_network, shares_request_spec):"},{"line_number":2958,"context_line":"        \"\"\"Checks destination compatibility for migration of a share server."},{"line_number":2959,"context_line":""},{"line_number":2960,"context_line":"        .. note::"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_a2b328e9","line":2957,"range":{"start_line":2957,"start_character":31,"end_line":2957,"end_character":50},"updated":"2020-09-01 19:21:13.000000000","message":"What does this look like?","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5de59631aac220c6052c8b5a4e0320358f1f6294","unresolved":false,"context_lines":[{"line_number":2954,"context_line":""},{"line_number":2955,"context_line":"    def share_server_migration_check_compatibility("},{"line_number":2956,"context_line":"            self, context, share_server, dest_host, old_share_network,"},{"line_number":2957,"context_line":"            new_share_network, shares_request_spec):"},{"line_number":2958,"context_line":"        \"\"\"Checks destination compatibility for migration of a share server."},{"line_number":2959,"context_line":""},{"line_number":2960,"context_line":"        .. note::"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_7b069c22","line":2957,"range":{"start_line":2957,"start_character":31,"end_line":2957,"end_character":50},"in_reply_to":"9f560f44_a2b328e9","updated":"2020-09-08 12:22:09.000000000","message":"Done","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"}],"manila/share/manager.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b32fd4f26270f18fd038ff005c2ed9e6007e388b","unresolved":false,"context_lines":[{"line_number":5123,"context_line":"                                 \"completed first phase successfully.\","},{"line_number":5124,"context_line":"                                 share_server[\u0027id\u0027])"},{"line_number":5125,"context_line":"                    else:"},{"line_number":5126,"context_line":"                        if (share_server[\u0027task_state\u0027] \u003d\u003d"},{"line_number":5127,"context_line":"                                constants.TASK_STATE_MIGRATION_CANCELLED):"},{"line_number":5128,"context_line":"                            LOG.warning("},{"line_number":5129,"context_line":"                                \"Share Server Migration for share %s was \""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_836e6bfd","line":5126,"updated":"2020-08-24 19:24:22.000000000","message":"In order to have the below condition satisfied, a new share_server_get should be performed in the database. Otherwise, the reference to the share server will always remain the same where the task_state field is \u0027constants.TASK_STATE_MIGRATION_DRIVER_IN_PROGRESS\u0027.","commit_id":"8ecca23f456549c9dd405273b944b4063ca2b026"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6aca1109d6cad40af7a02da67c479891279eb130","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                    \u0027next step of migration in the storage backend, for a \u0027"},{"line_number":109,"context_line":"                    \u0027migrating share.\u0027),"},{"line_number":110,"context_line":"    cfg.IntOpt(\u0027server_migration_driver_continue_update_interval\u0027,"},{"line_number":111,"context_line":"               default\u003d120,"},{"line_number":112,"context_line":"               help\u003d\u0027This value, specified in seconds, determines how often \u0027"},{"line_number":113,"context_line":"                    \u0027the share manager will poll the driver to perform the \u0027"},{"line_number":114,"context_line":"                    \u0027next step of migration in the storage backend, for a \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_1149725f","line":111,"range":{"start_line":111,"start_character":23,"end_line":111,"end_character":26},"updated":"2020-09-09 18:49:51.000000000","message":"Per discussion, please set this to a higher default value, 15 minutes perhaps.","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b6515f490448625bb3fe67aa5583230922ec197c","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                    \u0027next step of migration in the storage backend, for a \u0027"},{"line_number":109,"context_line":"                    \u0027migrating share.\u0027),"},{"line_number":110,"context_line":"    cfg.IntOpt(\u0027server_migration_driver_continue_update_interval\u0027,"},{"line_number":111,"context_line":"               default\u003d120,"},{"line_number":112,"context_line":"               help\u003d\u0027This value, specified in seconds, determines how often \u0027"},{"line_number":113,"context_line":"                    \u0027the share manager will poll the driver to perform the \u0027"},{"line_number":114,"context_line":"                    \u0027next step of migration in the storage backend, for a \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_fe1415a2","line":111,"range":{"start_line":111,"start_character":23,"end_line":111,"end_character":26},"in_reply_to":"9f560f44_1149725f","updated":"2020-09-10 02:15:06.000000000","message":"Done","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6aca1109d6cad40af7a02da67c479891279eb130","unresolved":false,"context_lines":[{"line_number":4953,"context_line":""},{"line_number":4954,"context_line":"        return True"},{"line_number":4955,"context_line":""},{"line_number":4956,"context_line":"    @utils.require_driver_initialized"},{"line_number":4957,"context_line":"    def share_server_migration_check(self, context, share_server_id, dest_host,"},{"line_number":4958,"context_line":"                                     writable, nondisruptive,"},{"line_number":4959,"context_line":"                                     preserve_snapshots, new_share_network_id):"},{"line_number":4960,"context_line":"        driver_result \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_717f0e66","line":4957,"range":{"start_line":4956,"start_character":4,"end_line":4957,"end_character":4},"updated":"2020-09-09 18:49:51.000000000","message":"+\n@add_hooks","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b6515f490448625bb3fe67aa5583230922ec197c","unresolved":false,"context_lines":[{"line_number":4953,"context_line":""},{"line_number":4954,"context_line":"        return True"},{"line_number":4955,"context_line":""},{"line_number":4956,"context_line":"    @utils.require_driver_initialized"},{"line_number":4957,"context_line":"    def share_server_migration_check(self, context, share_server_id, dest_host,"},{"line_number":4958,"context_line":"                                     writable, nondisruptive,"},{"line_number":4959,"context_line":"                                     preserve_snapshots, new_share_network_id):"},{"line_number":4960,"context_line":"        driver_result \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_de1791a2","line":4957,"range":{"start_line":4956,"start_character":4,"end_line":4957,"end_character":4},"in_reply_to":"9f560f44_717f0e66","updated":"2020-09-10 02:15:06.000000000","message":"Done","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6aca1109d6cad40af7a02da67c479891279eb130","unresolved":false,"context_lines":[{"line_number":5022,"context_line":""},{"line_number":5023,"context_line":"        return result"},{"line_number":5024,"context_line":""},{"line_number":5025,"context_line":"    @utils.require_driver_initialized"},{"line_number":5026,"context_line":"    def share_server_migration_start("},{"line_number":5027,"context_line":"            self, context, share_server_id, dest_host, writable,"},{"line_number":5028,"context_line":"            nondisruptive, preserve_snapshots, new_share_network_id\u003dNone):"},{"line_number":5029,"context_line":"        \"\"\"Migrates a share server from current host to another host.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_5182ca53","line":5026,"range":{"start_line":5025,"start_character":4,"end_line":5026,"end_character":4},"updated":"2020-09-09 18:49:51.000000000","message":"+\n@add_hooks","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b6515f490448625bb3fe67aa5583230922ec197c","unresolved":false,"context_lines":[{"line_number":5022,"context_line":""},{"line_number":5023,"context_line":"        return result"},{"line_number":5024,"context_line":""},{"line_number":5025,"context_line":"    @utils.require_driver_initialized"},{"line_number":5026,"context_line":"    def share_server_migration_start("},{"line_number":5027,"context_line":"            self, context, share_server_id, dest_host, writable,"},{"line_number":5028,"context_line":"            nondisruptive, preserve_snapshots, new_share_network_id\u003dNone):"},{"line_number":5029,"context_line":"        \"\"\"Migrates a share server from current host to another host.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_3e0b2d7d","line":5026,"range":{"start_line":5025,"start_character":4,"end_line":5026,"end_character":4},"in_reply_to":"9f560f44_5182ca53","updated":"2020-09-10 02:15:06.000000000","message":"Done","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6aca1109d6cad40af7a02da67c479891279eb130","unresolved":false,"context_lines":[{"line_number":5056,"context_line":""},{"line_number":5057,"context_line":"    @periodic_task.periodic_task("},{"line_number":5058,"context_line":"        spacing\u003dCONF.server_migration_driver_continue_update_interval)"},{"line_number":5059,"context_line":"    @utils.require_driver_initialized"},{"line_number":5060,"context_line":"    def share_server_migration_driver_continue(self, context):"},{"line_number":5061,"context_line":"        \"\"\"Invokes driver to continue migration of share server.\"\"\""},{"line_number":5062,"context_line":""},{"line_number":5063,"context_line":"        # Searching for destination share servers"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_f1b15e46","line":5060,"range":{"start_line":5059,"start_character":4,"end_line":5060,"end_character":4},"updated":"2020-09-09 18:49:51.000000000","message":"+\n@add_hooks","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6aca1109d6cad40af7a02da67c479891279eb130","unresolved":false,"context_lines":[{"line_number":5147,"context_line":"                            \"failed.\") % src_share_server[\u0027id\u0027]"},{"line_number":5148,"context_line":"                    LOG.exception(msg)"},{"line_number":5149,"context_line":""},{"line_number":5150,"context_line":"    @utils.require_driver_initialized"},{"line_number":5151,"context_line":"    def share_server_migration_complete(self, context, src_share_server_id,"},{"line_number":5152,"context_line":"                                        dest_share_server_id):"},{"line_number":5153,"context_line":"        \"\"\"Invokes driver to complete the migration of share server.\"\"\""},{"line_number":5154,"context_line":"        dest_server \u003d self.db.share_server_get(context, dest_share_server_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_11b7b23c","line":5151,"range":{"start_line":5150,"start_character":4,"end_line":5151,"end_character":4},"updated":"2020-09-09 18:49:51.000000000","message":"+\n@add_hooks","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b6515f490448625bb3fe67aa5583230922ec197c","unresolved":false,"context_lines":[{"line_number":5147,"context_line":"                            \"failed.\") % src_share_server[\u0027id\u0027]"},{"line_number":5148,"context_line":"                    LOG.exception(msg)"},{"line_number":5149,"context_line":""},{"line_number":5150,"context_line":"    @utils.require_driver_initialized"},{"line_number":5151,"context_line":"    def share_server_migration_complete(self, context, src_share_server_id,"},{"line_number":5152,"context_line":"                                        dest_share_server_id):"},{"line_number":5153,"context_line":"        \"\"\"Invokes driver to complete the migration of share server.\"\"\""},{"line_number":5154,"context_line":"        dest_server \u003d self.db.share_server_get(context, dest_share_server_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_be4c5dc8","line":5151,"range":{"start_line":5150,"start_character":4,"end_line":5151,"end_character":4},"in_reply_to":"9f560f44_11b7b23c","updated":"2020-09-10 02:15:06.000000000","message":"Done","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6aca1109d6cad40af7a02da67c479891279eb130","unresolved":false,"context_lines":[{"line_number":5304,"context_line":"            self._check_delete_share_server("},{"line_number":5305,"context_line":"                context, share_server\u003dsource_share_server, remote_host\u003dTrue)"},{"line_number":5306,"context_line":""},{"line_number":5307,"context_line":"    @utils.require_driver_initialized"},{"line_number":5308,"context_line":"    def share_server_migration_cancel(self, context, src_share_server_id,"},{"line_number":5309,"context_line":"                                      dest_share_server_id):"},{"line_number":5310,"context_line":"        share_server \u003d self.db.share_server_get(context, src_share_server_id)"},{"line_number":5311,"context_line":"        dest_share_server \u003d self.db.share_server_get(context,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_d1ac1af0","line":5308,"range":{"start_line":5307,"start_character":4,"end_line":5308,"end_character":4},"updated":"2020-09-09 18:49:51.000000000","message":"+\n@add_hooks","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b6515f490448625bb3fe67aa5583230922ec197c","unresolved":false,"context_lines":[{"line_number":5304,"context_line":"            self._check_delete_share_server("},{"line_number":5305,"context_line":"                context, share_server\u003dsource_share_server, remote_host\u003dTrue)"},{"line_number":5306,"context_line":""},{"line_number":5307,"context_line":"    @utils.require_driver_initialized"},{"line_number":5308,"context_line":"    def share_server_migration_cancel(self, context, src_share_server_id,"},{"line_number":5309,"context_line":"                                      dest_share_server_id):"},{"line_number":5310,"context_line":"        share_server \u003d self.db.share_server_get(context, src_share_server_id)"},{"line_number":5311,"context_line":"        dest_share_server \u003d self.db.share_server_get(context,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_9e47d9a3","line":5308,"range":{"start_line":5307,"start_character":4,"end_line":5308,"end_character":4},"in_reply_to":"9f560f44_d1ac1af0","updated":"2020-09-10 02:15:06.000000000","message":"Done","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6aca1109d6cad40af7a02da67c479891279eb130","unresolved":false,"context_lines":[{"line_number":5367,"context_line":"        LOG.info(\"Share Migration for share %s was cancelled.\","},{"line_number":5368,"context_line":"                 share_server[\u0027id\u0027])"},{"line_number":5369,"context_line":""},{"line_number":5370,"context_line":"    @utils.require_driver_initialized"},{"line_number":5371,"context_line":"    def share_server_migration_get_progress("},{"line_number":5372,"context_line":"            self, context, src_share_server_id, dest_share_server_id):"},{"line_number":5373,"context_line":""},{"line_number":5374,"context_line":"        share_server \u003d self.db.share_server_get(context, src_share_server_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_319c76be","line":5371,"range":{"start_line":5370,"start_character":4,"end_line":5371,"end_character":4},"updated":"2020-09-09 18:49:51.000000000","message":"+\n@add_hooks","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b6515f490448625bb3fe67aa5583230922ec197c","unresolved":false,"context_lines":[{"line_number":5367,"context_line":"        LOG.info(\"Share Migration for share %s was cancelled.\","},{"line_number":5368,"context_line":"                 share_server[\u0027id\u0027])"},{"line_number":5369,"context_line":""},{"line_number":5370,"context_line":"    @utils.require_driver_initialized"},{"line_number":5371,"context_line":"    def share_server_migration_get_progress("},{"line_number":5372,"context_line":"            self, context, src_share_server_id, dest_share_server_id):"},{"line_number":5373,"context_line":""},{"line_number":5374,"context_line":"        share_server \u003d self.db.share_server_get(context, src_share_server_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_fec7f510","line":5371,"range":{"start_line":5370,"start_character":4,"end_line":5371,"end_character":4},"in_reply_to":"9f560f44_319c76be","updated":"2020-09-10 02:15:06.000000000","message":"Done","commit_id":"ad42f62200f00c8b876eb9127ad7bb4c330037d6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"693dc2f77dbcff2e94dbc7f6de40e1bb376ea9db","unresolved":false,"context_lines":[{"line_number":5324,"context_line":"            context, share_server, dest_share_server,"},{"line_number":5325,"context_line":"            share_instances, snapshot_instances)"},{"line_number":5326,"context_line":""},{"line_number":5327,"context_line":"        # NOTE(dviroel): After cancelling the migration we should set the new"},{"line_number":5328,"context_line":"        # share server to INVALID since it may contain an invalid configuration"},{"line_number":5329,"context_line":"        # to be reused. We also cleanup the source_share_server_id to unblock"},{"line_number":5330,"context_line":"        # new migrations."},{"line_number":5331,"context_line":"        self.db.share_server_update("},{"line_number":5332,"context_line":"            context, dest_share_server_id,"},{"line_number":5333,"context_line":"            {\u0027task_state\u0027: constants.TASK_STATE_MIGRATION_CANCELLED,"},{"line_number":5334,"context_line":"             \u0027status\u0027: constants.STATUS_INACTIVE,"},{"line_number":5335,"context_line":"             \u0027source_share_server_id\u0027: None})"},{"line_number":5336,"context_line":""},{"line_number":5337,"context_line":"        self._check_delete_share_server(context,"},{"line_number":5338,"context_line":"                                        share_server\u003ddest_share_server)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_12a58203","line":5335,"range":{"start_line":5327,"start_character":0,"end_line":5335,"end_character":45},"updated":"2020-09-09 21:08:08.000000000","message":"Since the status of the share-server will be updated to INACTIVE, we don\u0027t need to care about blocking new migrations.\nRemove the \"\u0027source_share_server_id\u0027: None\" from this update.","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"836a32205ebdce5b5d4c10deef62ba7587934d5f","unresolved":false,"context_lines":[{"line_number":5324,"context_line":"            context, share_server, dest_share_server,"},{"line_number":5325,"context_line":"            share_instances, snapshot_instances)"},{"line_number":5326,"context_line":""},{"line_number":5327,"context_line":"        # NOTE(dviroel): After cancelling the migration we should set the new"},{"line_number":5328,"context_line":"        # share server to INVALID since it may contain an invalid configuration"},{"line_number":5329,"context_line":"        # to be reused. We also cleanup the source_share_server_id to unblock"},{"line_number":5330,"context_line":"        # new migrations."},{"line_number":5331,"context_line":"        self.db.share_server_update("},{"line_number":5332,"context_line":"            context, dest_share_server_id,"},{"line_number":5333,"context_line":"            {\u0027task_state\u0027: constants.TASK_STATE_MIGRATION_CANCELLED,"},{"line_number":5334,"context_line":"             \u0027status\u0027: constants.STATUS_INACTIVE,"},{"line_number":5335,"context_line":"             \u0027source_share_server_id\u0027: None})"},{"line_number":5336,"context_line":""},{"line_number":5337,"context_line":"        self._check_delete_share_server(context,"},{"line_number":5338,"context_line":"                                        share_server\u003ddest_share_server)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_356d10cc","line":5335,"range":{"start_line":5327,"start_character":0,"end_line":5335,"end_character":45},"in_reply_to":"9f560f44_12a58203","updated":"2020-09-09 21:55:31.000000000","message":"+1\n\nWith that you will require that the admin cleans this up before re-attempting migration","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"836a32205ebdce5b5d4c10deef62ba7587934d5f","unresolved":false,"context_lines":[{"line_number":5359,"context_line":"            self, context, src_share_server_id, dest_share_server_id):"},{"line_number":5360,"context_line":""},{"line_number":5361,"context_line":"        src_share_server \u003d self.db.share_server_get(context,"},{"line_number":5362,"context_line":"                                                    src_share_server_id)"},{"line_number":5363,"context_line":"        dest_share_server \u003d self.db.share_server_get(context,"},{"line_number":5364,"context_line":"                                                     dest_share_server_id)"},{"line_number":5365,"context_line":"        share_instances \u003d ("},{"line_number":5366,"context_line":"            self.db.share_instances_get_all_by_share_server("},{"line_number":5367,"context_line":"                context, src_share_server_id, with_share_data\u003dTrue))"},{"line_number":5368,"context_line":"        share_instance_ids \u003d [x.id for x in share_instances]"},{"line_number":5369,"context_line":""},{"line_number":5370,"context_line":"        snapshot_instances \u003d ("},{"line_number":5371,"context_line":"            self.db.share_snapshot_instance_get_all_with_filters("},{"line_number":5372,"context_line":"                context,"},{"line_number":5373,"context_line":"                {\u0027share_instance_ids\u0027: share_instance_ids}))"},{"line_number":5374,"context_line":""},{"line_number":5375,"context_line":"        if src_share_server[\u0027task_state\u0027] !\u003d ("},{"line_number":5376,"context_line":"                constants.TASK_STATE_MIGRATION_DRIVER_IN_PROGRESS):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_753ca8c7","line":5373,"range":{"start_line":5362,"start_character":72,"end_line":5373,"end_character":60},"updated":"2020-09-09 21:55:31.000000000","message":"nit: do this after the check on line 5375","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b6515f490448625bb3fe67aa5583230922ec197c","unresolved":false,"context_lines":[{"line_number":5359,"context_line":"            self, context, src_share_server_id, dest_share_server_id):"},{"line_number":5360,"context_line":""},{"line_number":5361,"context_line":"        src_share_server \u003d self.db.share_server_get(context,"},{"line_number":5362,"context_line":"                                                    src_share_server_id)"},{"line_number":5363,"context_line":"        dest_share_server \u003d self.db.share_server_get(context,"},{"line_number":5364,"context_line":"                                                     dest_share_server_id)"},{"line_number":5365,"context_line":"        share_instances \u003d ("},{"line_number":5366,"context_line":"            self.db.share_instances_get_all_by_share_server("},{"line_number":5367,"context_line":"                context, src_share_server_id, with_share_data\u003dTrue))"},{"line_number":5368,"context_line":"        share_instance_ids \u003d [x.id for x in share_instances]"},{"line_number":5369,"context_line":""},{"line_number":5370,"context_line":"        snapshot_instances \u003d ("},{"line_number":5371,"context_line":"            self.db.share_snapshot_instance_get_all_with_filters("},{"line_number":5372,"context_line":"                context,"},{"line_number":5373,"context_line":"                {\u0027share_instance_ids\u0027: share_instance_ids}))"},{"line_number":5374,"context_line":""},{"line_number":5375,"context_line":"        if src_share_server[\u0027task_state\u0027] !\u003d ("},{"line_number":5376,"context_line":"                constants.TASK_STATE_MIGRATION_DRIVER_IN_PROGRESS):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_be7d7db3","line":5373,"range":{"start_line":5362,"start_character":72,"end_line":5373,"end_character":60},"in_reply_to":"9f560f44_753ca8c7","updated":"2020-09-10 02:15:06.000000000","message":"Done","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e5dc9da85ff8179f93faa2371b6be48095209bfe","unresolved":false,"context_lines":[{"line_number":1103,"context_line":"    def _cast_access_rules_to_readonly(self, context, src_share_instance,"},{"line_number":1104,"context_line":"                                       share_server, dest_host\u003dNone):"},{"line_number":1105,"context_line":"        self._cast_access_rules_to_readonly_for_server("},{"line_number":1106,"context_line":"            context, [src_share_instance], share_server, dest_host)"},{"line_number":1107,"context_line":""},{"line_number":1108,"context_line":"    def _cast_access_rules_to_readonly_for_server("},{"line_number":1109,"context_line":"            self, context, src_share_instances, share_server, dest_host\u003dNone):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_633cdbc7","line":1106,"range":{"start_line":1106,"start_character":57,"end_line":1106,"end_character":66},"updated":"2020-09-10 21:19:42.000000000","message":"pass kwargs as kwargs","commit_id":"39efc2bde81c2a0c747a491d3a778b822ca263b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e5dc9da85ff8179f93faa2371b6be48095209bfe","unresolved":false,"context_lines":[{"line_number":4866,"context_line":"                # driver doesn\u0027t support \u0027writable\u0027."},{"line_number":4867,"context_line":"                self._cast_access_rules_to_readonly_for_server("},{"line_number":4868,"context_line":"                    context, share_instances, source_share_server,"},{"line_number":4869,"context_line":"                    source_share_server[\u0027host\u0027])"},{"line_number":4870,"context_line":""},{"line_number":4871,"context_line":"            LOG.debug(\"Initiating driver migration for share server %s.\","},{"line_number":4872,"context_line":"                      source_share_server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_231f835b","line":4869,"range":{"start_line":4869,"start_character":20,"end_line":4869,"end_character":47},"updated":"2020-09-10 21:19:42.000000000","message":"pass kwargs as kwargs","commit_id":"39efc2bde81c2a0c747a491d3a778b822ca263b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4572103856aa14ae62daa82cbaa10c536752afb5","unresolved":false,"context_lines":[{"line_number":5005,"context_line":"        try:"},{"line_number":5006,"context_line":"            if not self.driver.driver_handles_share_servers:"},{"line_number":5007,"context_line":"                LOG.error(\u0027This operation is supported only on backends that \u0027"},{"line_number":5008,"context_line":"                          \u0027handles share servers.\u0027)"},{"line_number":5009,"context_line":"                raise"},{"line_number":5010,"context_line":""},{"line_number":5011,"context_line":"            self._share_server_migration_start_driver("}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_6d220a54","line":5008,"range":{"start_line":5008,"start_character":27,"end_line":5008,"end_character":34},"updated":"2020-09-10 20:00:03.000000000","message":"nit: handle","commit_id":"39efc2bde81c2a0c747a491d3a778b822ca263b8"}],"manila/share/migration.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"836a32205ebdce5b5d4c10deef62ba7587934d5f","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            self.delete_instance_and_wait(new_instance)"},{"line_number":134,"context_line":"        except Exception:"},{"line_number":135,"context_line":"            LOG.warning(\"Failed to cleanup new instance during generic\""},{"line_number":136,"context_line":"                        \" migration for share.\")"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def cleanup_access_rules(self, share_instances, share_server,"},{"line_number":139,"context_line":"                             dest_host\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_92519233","line":136,"range":{"start_line":136,"start_character":46,"end_line":136,"end_character":48},"updated":"2020-09-09 21:55:31.000000000","message":"you can still log new_instance[\u0027share_id\u0027]","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b6515f490448625bb3fe67aa5583230922ec197c","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            self.delete_instance_and_wait(new_instance)"},{"line_number":134,"context_line":"        except Exception:"},{"line_number":135,"context_line":"            LOG.warning(\"Failed to cleanup new instance during generic\""},{"line_number":136,"context_line":"                        \" migration for share.\")"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def cleanup_access_rules(self, share_instances, share_server,"},{"line_number":139,"context_line":"                             dest_host\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_9e7879c1","line":136,"range":{"start_line":136,"start_character":46,"end_line":136,"end_character":48},"in_reply_to":"9f560f44_92519233","updated":"2020-09-10 02:15:06.000000000","message":"Done","commit_id":"fed0a78b9173b6051d082f28f0da63cf3105bdf8"}],"manila/share/rpcapi.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a36c8f88a7176a12b9598b0abb4c496bfe2bb826","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        1.18 - Remove unused \"share_id\" parameter from revert_to_snapshot()"},{"line_number":78,"context_line":"        1.19 - Add manage_share_server() and unmanage_share_server()"},{"line_number":79,"context_line":"        1.20 - Add share_server_migration_start, share_server_migration_check()"},{"line_number":80,"context_line":"            and share_server_get_progress()"},{"line_number":81,"context_line":"    \"\"\""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    BASE_RPC_API_VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_94ace79f","line":80,"updated":"2020-09-01 01:58:08.000000000","message":"missing mention to share_server_migration_complete() and cancel()","commit_id":"8ecca23f456549c9dd405273b944b4063ca2b026"}],"manila/tests/db/migrations/alembic/migrations_data_checks.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"72171c8dc067770cae678696c6970459e77158b5","unresolved":false,"context_lines":[{"line_number":2952,"context_line":"class ShareServerTaskState(BaseMigrationChecks):"},{"line_number":2953,"context_line":""},{"line_number":2954,"context_line":"    def setup_upgrade_data(self, engine):"},{"line_number":2955,"context_line":"        user_id \u003d \u0027user_id\u0027"},{"line_number":2956,"context_line":"        project_id \u003d \u0027project_id\u0027"},{"line_number":2957,"context_line":""},{"line_number":2958,"context_line":"        # Create share server"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_8559935b","line":2955,"updated":"2020-08-20 04:49:04.000000000","message":"pep8: F841 local variable \u0027user_id\u0027 is assigned to but never used","commit_id":"1e32949056dce92527c6c676e25add474e5010b9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"72171c8dc067770cae678696c6970459e77158b5","unresolved":false,"context_lines":[{"line_number":2953,"context_line":""},{"line_number":2954,"context_line":"    def setup_upgrade_data(self, engine):"},{"line_number":2955,"context_line":"        user_id \u003d \u0027user_id\u0027"},{"line_number":2956,"context_line":"        project_id \u003d \u0027project_id\u0027"},{"line_number":2957,"context_line":""},{"line_number":2958,"context_line":"        # Create share server"},{"line_number":2959,"context_line":"        share_server_data \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_65543f22","line":2956,"updated":"2020-08-20 04:49:04.000000000","message":"pep8: F841 local variable \u0027project_id\u0027 is assigned to but never used","commit_id":"1e32949056dce92527c6c676e25add474e5010b9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b8bace1a076a9d487a543d246238888b73b7e757","unresolved":false,"context_lines":[{"line_number":2964,"context_line":"    def check_upgrade(self, engine, data):"},{"line_number":2965,"context_line":"        ss_table \u003d utils.load_table(\u0027share_servers\u0027, engine)"},{"line_number":2966,"context_line":"        for ss in engine.execute(ss_table.select()):"},{"line_number":2967,"context_line":"            self.test_case.assertTrue(hasattr(ss, \u0027task_state\u0027))"},{"line_number":2968,"context_line":"            self.test_case.assertTrue(hasattr(ss, \u0027source_share_server_id\u0027))"},{"line_number":2969,"context_line":""},{"line_number":2970,"context_line":"    def check_downgrade(self, engine):"},{"line_number":2971,"context_line":"        ss_table \u003d utils.load_table(\u0027share_servers\u0027, engine)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_5b6f015f","line":2968,"range":{"start_line":2967,"start_character":13,"end_line":2968,"end_character":76},"updated":"2020-09-10 18:17:53.000000000","message":"assert that the defaults are None","commit_id":"39efc2bde81c2a0c747a491d3a778b822ca263b8"}]}