)]}'
{"manila/api/v2/share_replica_export_locations.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"5316b8f68b13a078f62d54e3a0274c6eaee57e94","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def index(self, req, share_replica_id):"},{"line_number":51,"context_line":"        return self._index(req, share_replica_id)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    # pylint: enable\u003dfunction-redefined"},{"line_number":54,"context_line":"    @wsgi.Controller.authorize(\u0027index\u0027)"},{"line_number":55,"context_line":"    def _index(self, req, share_replica_id):"},{"line_number":56,"context_line":"        \"\"\"Return a list of export locations for the share instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_3b76dfd9","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":39},"updated":"2020-09-05 17:39:17.000000000","message":"I think that is not needed for \u0027_index\u0027","commit_id":"ee5ebc8462977a486d931a634606ee424ba990d8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9ac247d6792e7e83918353b73cfb1eabc183e067","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def index(self, req, share_replica_id):"},{"line_number":51,"context_line":"        return self._index(req, share_replica_id)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    # pylint: enable\u003dfunction-redefined"},{"line_number":54,"context_line":"    @wsgi.Controller.authorize(\u0027index\u0027)"},{"line_number":55,"context_line":"    def _index(self, req, share_replica_id):"},{"line_number":56,"context_line":"        \"\"\"Return a list of export locations for the share instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_f0e761e2","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":39},"in_reply_to":"9f560f44_3b76dfd9","updated":"2020-09-06 20:13:42.000000000","message":"This is kinda tricky. In the above method, I\u0027m not declaring this in front of the method name (for character limits purpose and pylint will still complain if I break the method\u0027s declaration line). So if I do not enable again, as I\u0027m doing here, pylint will not behave as expected.\nSo in the line 48 I\u0027m disabling it and as soon as the redeclared method ends, there is need to enable it again.\nThis issue was faced in the past and this was the way we have chosen to solve. More details about it in [1]\n\n[1] https://review.opendev.org/#/c/706959/6/manila/api/v2/share_group_snapshots.py@248","commit_id":"ee5ebc8462977a486d931a634606ee424ba990d8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"5316b8f68b13a078f62d54e3a0274c6eaee57e94","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    def show(self, req, share_replica_id, export_location_uuid):"},{"line_number":75,"context_line":"        return self._show(req, share_replica_id, export_location_uuid)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    # pylint: enable\u003dfunction-redefined"},{"line_number":78,"context_line":"    @wsgi.Controller.authorize(\u0027show\u0027)"},{"line_number":79,"context_line":"    def _show(self, req, share_replica_id, export_location_uuid):"},{"line_number":80,"context_line":"        \"\"\"Return data about the requested export location.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_5b7913c3","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":39},"updated":"2020-09-05 17:39:17.000000000","message":"same as L53","commit_id":"ee5ebc8462977a486d931a634606ee424ba990d8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9ac247d6792e7e83918353b73cfb1eabc183e067","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    def show(self, req, share_replica_id, export_location_uuid):"},{"line_number":75,"context_line":"        return self._show(req, share_replica_id, export_location_uuid)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    # pylint: enable\u003dfunction-redefined"},{"line_number":78,"context_line":"    @wsgi.Controller.authorize(\u0027show\u0027)"},{"line_number":79,"context_line":"    def _show(self, req, share_replica_id, export_location_uuid):"},{"line_number":80,"context_line":"        \"\"\"Return data about the requested export location.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_50d0cdf7","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":39},"in_reply_to":"9f560f44_5b7913c3","updated":"2020-09-06 20:13:42.000000000","message":"answered above :)","commit_id":"ee5ebc8462977a486d931a634606ee424ba990d8"}],"manila/api/v2/share_replicas.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"9ece7487fd893dc4f4f65ab4f5509239bd8e0cf5","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    def delete(self, req, id):  # pylint: disable\u003dfunction-redefined"},{"line_number":184,"context_line":"        return self._delete(req, id)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    @wsgi.Controller.authorize(\u0027delete\u0027)"},{"line_number":187,"context_line":"    def _delete(self, req, id):"},{"line_number":188,"context_line":"        \"\"\"Delete a replica.\"\"\""},{"line_number":189,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_85ab531b","line":186,"updated":"2020-08-20 04:44:39.000000000","message":"pep8: F811 redefinition of unused \u0027_delete\u0027 from line 54","commit_id":"f0dda6a3943eeb3067b5caeb449f176d4385074d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"927069eb1391d9156949ab9efb9bda29a7c83a29","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    def create(self, req, body):"},{"line_number":134,"context_line":"        return self._create(req, body)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    @wsgi.response(202)"},{"line_number":137,"context_line":"    @wsgi.Controller.api_version(GRADUATION_VERSION)  # noqa"},{"line_number":138,"context_line":"    def create(self, req, body):  # pylint: disable\u003dfunction-redefined"},{"line_number":139,"context_line":"        return self._create(req, body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_9fbc2e07","line":136,"updated":"2020-08-20 20:03:35.000000000","message":"pep8: F811 redefinition of unused \u0027create\u0027 from line 130","commit_id":"cc96bb0fc3cf4cbf01e538dbf773247e282f0668"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5cb9bf05831a48ec5e7e320b126425b7741296c4","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    @wsgi.Controller.api_version("},{"line_number":107,"context_line":"        MIN_SUPPORTED_API_VERSION, PRE_GRADUATION_VERSION, experimental\u003dTrue)"},{"line_number":108,"context_line":"    def show(self, req, id):"},{"line_number":109,"context_line":"        \"\"\"Returns a detailed list of replicas.\"\"\""},{"line_number":110,"context_line":"        return self._show(req, id)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @wsgi.Controller.api_version(GRADUATION_VERSION)  # noqa"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_a27c5f20","line":109,"range":{"start_line":109,"start_character":11,"end_line":109,"end_character":47},"updated":"2020-09-08 22:56:12.000000000","message":"Return data about the given replica.","commit_id":"ee5ebc8462977a486d931a634606ee424ba990d8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5cb9bf05831a48ec5e7e320b126425b7741296c4","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @wsgi.Controller.api_version(GRADUATION_VERSION)  # noqa"},{"line_number":113,"context_line":"    def show(self, req, id):  # pylint: disable\u003dfunction-redefined"},{"line_number":114,"context_line":"        \"\"\"Returns a detailed list of replicas.\"\"\""},{"line_number":115,"context_line":"        return self._show(req, id)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    @wsgi.Controller.authorize(\u0027show\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_82795b30","line":114,"range":{"start_line":114,"start_character":11,"end_line":114,"end_character":46},"updated":"2020-09-08 22:56:12.000000000","message":"Return data about the given replica.","commit_id":"ee5ebc8462977a486d931a634606ee424ba990d8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"5316b8f68b13a078f62d54e3a0274c6eaee57e94","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        return self._delete_share_replica(req, id)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    @wsgi.Controller.authorize(\u0027delete\u0027)"},{"line_number":188,"context_line":"    def _delete_share_replica(self, req, id):"},{"line_number":189,"context_line":"        \"\"\"Delete a replica.\"\"\""},{"line_number":190,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_fb410765","line":188,"range":{"start_line":188,"start_character":8,"end_line":188,"end_character":29},"updated":"2020-09-05 17:39:17.000000000","message":"nit: _delete","commit_id":"ee5ebc8462977a486d931a634606ee424ba990d8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9ac247d6792e7e83918353b73cfb1eabc183e067","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        return self._delete_share_replica(req, id)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    @wsgi.Controller.authorize(\u0027delete\u0027)"},{"line_number":188,"context_line":"    def _delete_share_replica(self, req, id):"},{"line_number":189,"context_line":"        \"\"\"Delete a replica.\"\"\""},{"line_number":190,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_30cd595d","line":188,"range":{"start_line":188,"start_character":8,"end_line":188,"end_character":29},"in_reply_to":"9f560f44_fb410765","updated":"2020-09-06 20:13:42.000000000","message":"_delete is already defined in [1] and I would be overwriting the existent method that has another behavior :)\n\n[1] https://review.opendev.org/#/c/747073/4/manila/api/v2/share_replicas.py@54","commit_id":"ee5ebc8462977a486d931a634606ee424ba990d8"}]}