)]}'
{"manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fb1f88c0dc47a45a48848181870419276ef7a864","unresolved":false,"context_lines":[{"line_number":554,"context_line":"        extra_specs \u003d share_types.get_extra_specs_from_share(share)"},{"line_number":555,"context_line":"        provisioning_options \u003d self._get_provisioning_options(extra_specs)"},{"line_number":556,"context_line":"        if provisioning_options.get(\u0027adaptive_qos_policy_group\u0027) is not None:"},{"line_number":557,"context_line":"            msg \u003d _(\"The extra spec \u0027adaptive_qos_policy_group\u0027 is not \""},{"line_number":558,"context_line":"                    \"supported when a share creation from snapshot is placed \""},{"line_number":559,"context_line":"                    \"in another pool or backend.\")"},{"line_number":560,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"        parent_share_server \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_2a13f902","line":559,"range":{"start_line":557,"start_character":21,"end_line":559,"end_character":48},"updated":"2020-09-23 17:59:41.000000000","message":"Why is this?","commit_id":"6bae6b2cfc97d2f7029afd1cc43d5625dc7c7fd0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e699f2e35774f6fff8e2cfa6096066063c2012e6","unresolved":false,"context_lines":[{"line_number":554,"context_line":"        extra_specs \u003d share_types.get_extra_specs_from_share(share)"},{"line_number":555,"context_line":"        provisioning_options \u003d self._get_provisioning_options(extra_specs)"},{"line_number":556,"context_line":"        if provisioning_options.get(\u0027adaptive_qos_policy_group\u0027) is not None:"},{"line_number":557,"context_line":"            msg \u003d _(\"The extra spec \u0027adaptive_qos_policy_group\u0027 is not \""},{"line_number":558,"context_line":"                    \"supported when a share creation from snapshot is placed \""},{"line_number":559,"context_line":"                    \"in another pool or backend.\")"},{"line_number":560,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"        parent_share_server \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_fec9c259","line":559,"range":{"start_line":557,"start_character":21,"end_line":559,"end_character":48},"in_reply_to":"9f560f44_0ad9d5f2","updated":"2020-09-23 19:03:55.000000000","message":"So why not allow it to fail?\n\nThat way an admin reading the logs will know they need to create a corresponding \"adaptive_qos_policy_group\" on the other backend..","commit_id":"6bae6b2cfc97d2f7029afd1cc43d5625dc7c7fd0"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"f5dea9b160f050a7119ff5a93599f48453cf0832","unresolved":false,"context_lines":[{"line_number":554,"context_line":"        extra_specs \u003d share_types.get_extra_specs_from_share(share)"},{"line_number":555,"context_line":"        provisioning_options \u003d self._get_provisioning_options(extra_specs)"},{"line_number":556,"context_line":"        if provisioning_options.get(\u0027adaptive_qos_policy_group\u0027) is not None:"},{"line_number":557,"context_line":"            msg \u003d _(\"The extra spec \u0027adaptive_qos_policy_group\u0027 is not \""},{"line_number":558,"context_line":"                    \"supported when a share creation from snapshot is placed \""},{"line_number":559,"context_line":"                    \"in another pool or backend.\")"},{"line_number":560,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"        parent_share_server \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_0ad9d5f2","line":559,"range":{"start_line":557,"start_character":21,"end_line":559,"end_character":48},"in_reply_to":"9f560f44_2a13f902","updated":"2020-09-23 18:40:21.000000000","message":"Depending on the destination host, we cannot guarantee that the adaptive_qos_policy_group will exists. So, like in replication, we could block this operation when source[\u0027host\u0027] is different from destination[\u0027host\u0027]. If both source and destination shares land in the same vserver, will work, but any other scenario can fail.","commit_id":"6bae6b2cfc97d2f7029afd1cc43d5625dc7c7fd0"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"9654ea9f1ea7cf145dfae0e95f328f4c8f00afc9","unresolved":false,"context_lines":[{"line_number":554,"context_line":"        extra_specs \u003d share_types.get_extra_specs_from_share(share)"},{"line_number":555,"context_line":"        provisioning_options \u003d self._get_provisioning_options(extra_specs)"},{"line_number":556,"context_line":"        if provisioning_options.get(\u0027adaptive_qos_policy_group\u0027) is not None:"},{"line_number":557,"context_line":"            msg \u003d _(\"The extra spec \u0027adaptive_qos_policy_group\u0027 is not \""},{"line_number":558,"context_line":"                    \"supported when a share creation from snapshot is placed \""},{"line_number":559,"context_line":"                    \"in another pool or backend.\")"},{"line_number":560,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"        parent_share_server \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_4199f377","line":559,"range":{"start_line":557,"start_character":21,"end_line":559,"end_character":48},"in_reply_to":"9f560f44_fec9c259","updated":"2020-09-23 19:51:23.000000000","message":"Yes, there is the possibility of get this working, if the policy is configured in multiple backends. I\u0027ll remove this.","commit_id":"6bae6b2cfc97d2f7029afd1cc43d5625dc7c7fd0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fb1f88c0dc47a45a48848181870419276ef7a864","unresolved":false,"context_lines":[{"line_number":1103,"context_line":"            msg \u003d _(\u0027Share cannot be provisioned with QoS without having \u0027"},{"line_number":1104,"context_line":"                    \u0027cluster credentials.\u0027)"},{"line_number":1105,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":1106,"context_line":""},{"line_number":1107,"context_line":"    def _get_nve_option(self, specs):"},{"line_number":1108,"context_line":"        if \u0027netapp_flexvol_encryption\u0027 in specs:"},{"line_number":1109,"context_line":"            nve \u003d specs[\u0027netapp_flexvol_encryption\u0027].lower() \u003d\u003d \u0027true\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_0ae5550a","line":1106,"range":{"start_line":1106,"start_character":0,"end_line":1106,"end_character":0},"updated":"2020-09-23 17:59:41.000000000","message":"Can you do the replication_type check here, rather than during the creation of a replica?","commit_id":"6bae6b2cfc97d2f7029afd1cc43d5625dc7c7fd0"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"f5dea9b160f050a7119ff5a93599f48453cf0832","unresolved":false,"context_lines":[{"line_number":1103,"context_line":"            msg \u003d _(\u0027Share cannot be provisioned with QoS without having \u0027"},{"line_number":1104,"context_line":"                    \u0027cluster credentials.\u0027)"},{"line_number":1105,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":1106,"context_line":""},{"line_number":1107,"context_line":"    def _get_nve_option(self, specs):"},{"line_number":1108,"context_line":"        if \u0027netapp_flexvol_encryption\u0027 in specs:"},{"line_number":1109,"context_line":"            nve \u003d specs[\u0027netapp_flexvol_encryption\u0027].lower() \u003d\u003d \u0027true\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_aa3a69e2","line":1106,"range":{"start_line":1106,"start_character":0,"end_line":1106,"end_character":0},"in_reply_to":"9f560f44_0ae5550a","updated":"2020-09-23 18:40:21.000000000","message":"Yes, it\u0027s possible, it will block the creation of the first share instead of blocking only the replicas.","commit_id":"6bae6b2cfc97d2f7029afd1cc43d5625dc7c7fd0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e699f2e35774f6fff8e2cfa6096066063c2012e6","unresolved":false,"context_lines":[{"line_number":1103,"context_line":"            msg \u003d _(\u0027Share cannot be provisioned with QoS without having \u0027"},{"line_number":1104,"context_line":"                    \u0027cluster credentials.\u0027)"},{"line_number":1105,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":1106,"context_line":""},{"line_number":1107,"context_line":"    def _get_nve_option(self, specs):"},{"line_number":1108,"context_line":"        if \u0027netapp_flexvol_encryption\u0027 in specs:"},{"line_number":1109,"context_line":"            nve \u003d specs[\u0027netapp_flexvol_encryption\u0027].lower() \u003d\u003d \u0027true\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_bee10ad2","line":1106,"range":{"start_line":1106,"start_character":0,"end_line":1106,"end_character":0},"in_reply_to":"9f560f44_aa3a69e2","updated":"2020-09-23 19:03:55.000000000","message":"Yes, that\u0027s better user experience? DR can be a day-2 activity - and failing fast/early is desirable.","commit_id":"6bae6b2cfc97d2f7029afd1cc43d5625dc7c7fd0"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"9654ea9f1ea7cf145dfae0e95f328f4c8f00afc9","unresolved":false,"context_lines":[{"line_number":1103,"context_line":"            msg \u003d _(\u0027Share cannot be provisioned with QoS without having \u0027"},{"line_number":1104,"context_line":"                    \u0027cluster credentials.\u0027)"},{"line_number":1105,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":1106,"context_line":""},{"line_number":1107,"context_line":"    def _get_nve_option(self, specs):"},{"line_number":1108,"context_line":"        if \u0027netapp_flexvol_encryption\u0027 in specs:"},{"line_number":1109,"context_line":"            nve \u003d specs[\u0027netapp_flexvol_encryption\u0027].lower() \u003d\u003d \u0027true\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_4172934b","line":1106,"range":{"start_line":1106,"start_character":0,"end_line":1106,"end_character":0},"in_reply_to":"9f560f44_bee10ad2","updated":"2020-09-23 19:51:23.000000000","message":"Yes, for sure is better to identify this problem in the share creation.","commit_id":"6bae6b2cfc97d2f7029afd1cc43d5625dc7c7fd0"}]}