)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"238ebafb9622f6bf60762aa3db098371a1aa21fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"2aae5eed_8fa2d2ba","updated":"2021-12-07 22:05:53.000000000","message":"Haixin: After applying https://review.opendev.org/c/openstack/manila/+/756450, i still see the usage of \"six\" in other places, were you planning to get them all? They\u0027ll need to be removed before we drop six from the requirement files: https://paste.opendev.org/show/811525/\n\n\nIf you think someone can help with the remaining occurrences let me know","commit_id":"f56485edfeee12ace37757d4f49df09c53a8ffd5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"05a460e3088fdf61c45afddee288a7e728432f7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"db1eb4de_1d7ad7ab","updated":"2021-12-07 21:51:50.000000000","message":"LGTM, want to merge this at the very end because we\u0027re dropping six from the lower-constraints and requirements files... ","commit_id":"f56485edfeee12ace37757d4f49df09c53a8ffd5"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c869aeda948f64cbae6bfb3f02efa7746df7b98a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"55a6c5ab_94725a39","updated":"2021-12-03 09:02:50.000000000","message":"recheck","commit_id":"f56485edfeee12ace37757d4f49df09c53a8ffd5"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"945a27e975f11c7f85a36f6050892050a532b258","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"63a3948a_17d2fb36","updated":"2021-12-06 03:13:35.000000000","message":"recheck","commit_id":"f56485edfeee12ace37757d4f49df09c53a8ffd5"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"7fdec29d3d1a3c09bb99c5be9c1a6614812cd28f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"63d3b8ed_5811ccac","updated":"2021-12-02 14:08:44.000000000","message":"run Pure Storage CI","commit_id":"f56485edfeee12ace37757d4f49df09c53a8ffd5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"45e71f057637f8ef6b0c0b0f7b524cb95d7260a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"80b30810_e22bf240","in_reply_to":"0aed556a_e1c5e956","updated":"2021-12-08 01:04:35.000000000","message":"Yes we can - we don\u0027t need the vendor maintainers\u0027 permission to make changes to the drivers; it would be nice to see all of their CI systems passing. However, many of them don\u0027t report consistently, so our best hope is to ensure that unit tests are passing.","commit_id":"f56485edfeee12ace37757d4f49df09c53a8ffd5"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c79ce15ac99eed945db0e7cca93c9bf05fc977f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"0aed556a_e1c5e956","in_reply_to":"2aae5eed_8fa2d2ba","updated":"2021-12-08 01:00:36.000000000","message":"we only remove six from manila major code https://review.opendev.org/q/topic:%22manila_remove_six%22+(status:open%20OR%20status:merged), but the driver code is not included, If we can modify the driver code without the authorization of the corresponding driver manufacturer, I will modify the driver in another patch.","commit_id":"f56485edfeee12ace37757d4f49df09c53a8ffd5"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"d0aaa8483be193458c6ad0f675e995bf2481d2c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"9c8b5930_d681c598","in_reply_to":"80b30810_e22bf240","updated":"2021-12-08 01:12:14.000000000","message":"ok, i will put another patch to remove six from driver code. 😄","commit_id":"f56485edfeee12ace37757d4f49df09c53a8ffd5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3f3f3095e5ae260c0784b224fcb75deadfc1d9d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"00fefc5b_53ef5949","in_reply_to":"9c8b5930_d681c598","updated":"2021-12-08 02:13:04.000000000","message":"Thanks Haixin! you can include that in this change, or just make a new one and we\u0027ll merge this change after that change; meanwhile, a minor comment in manila/share/drivers/generic.py if you wish to make another patch here.","commit_id":"f56485edfeee12ace37757d4f49df09c53a8ffd5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"adcbd22445d86b0a7ac5e4763aa53dc5c8ff4476","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"a242aa55_de250276","updated":"2021-12-09 18:41:51.000000000","message":"LGTM, thank you!","commit_id":"cb47c38570f098360408273238e88a33d0704f0c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"61096e9a8142a98b45b09bf14d2a4a16b5847768","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"a7febdf4_62daaf02","updated":"2021-12-09 18:48:36.000000000","message":"Setting W-1 because there\u0027s more changes that must merge before this one; we can review this and keep it ready for merge in the meanwhile!","commit_id":"cb47c38570f098360408273238e88a33d0704f0c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"bb1f773425243918e65f961fcc10f1b35d87bf48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"f9e3a979_f3783896","updated":"2022-02-10 22:26:27.000000000","message":"Cloned and performed a grep to make sure\nNo more mentions of it in the code. Thanks for working on this removal, haixin!","commit_id":"7f2b25332a2030d147083c90ab268c126575a3ce"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"65a58f1b0fa8e0ff4107937c553d726a24361f6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"9661656f_141a3d8a","updated":"2022-02-10 22:40:25.000000000","message":"Thanks Haixin and Carlos - lets get this in and cause those merge conflicts sooner than later.. ","commit_id":"7f2b25332a2030d147083c90ab268c126575a3ce"}],"manila/share/drivers/generic.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b5959485ab7f9dd0dc82e3b8b428bc4e5ea1714e","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                      \"permanently on server \u0027%(instance_id)s\u0027.\","},{"line_number":300,"context_line":"                      {\"share_id\": share_id,"},{"line_number":301,"context_line":"                       \"instance_id\": server_details[\u0027instance_id\u0027]})"},{"line_number":302,"context_line":"            raise exception.ShareBackendException(msg\u003dstr(e))"},{"line_number":303,"context_line":"        try:"},{"line_number":304,"context_line":"            # Remount it to avoid postponed point of failure"},{"line_number":305,"context_line":"            self._ssh_exec(server_details, [\u0027sudo\u0027, \u0027mount\u0027, \u0027-a\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_98e0adcd","line":302,"updated":"2020-10-09 05:47:20.000000000","message":"pep8: M325 str() and unicode() cannot be used on an exception.  Remove or use six.text_type()","commit_id":"a4d86d4e9604fe819624ab18b67195c370cf7fa9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b5959485ab7f9dd0dc82e3b8b428bc4e5ea1714e","unresolved":false,"context_lines":[{"line_number":320,"context_line":"                      \"permanently on server \u0027%(instance_id)s\u0027.\","},{"line_number":321,"context_line":"                      {\"share_id\": share_id,"},{"line_number":322,"context_line":"                       \"instance_id\": server_details[\u0027instance_id\u0027]})"},{"line_number":323,"context_line":"            raise exception.ShareBackendException(msg\u003dstr(e))"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    def _mount_device(self, share, server_details, volume):"},{"line_number":326,"context_line":"        \"\"\"Mounts block device to the directory on service vm."}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_78e5d9da","line":323,"updated":"2020-10-09 05:47:20.000000000","message":"pep8: M325 str() and unicode() cannot be used on an exception.  Remove or use six.text_type()","commit_id":"a4d86d4e9604fe819624ab18b67195c370cf7fa9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b5959485ab7f9dd0dc82e3b8b428bc4e5ea1714e","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                    LOG.warning(\"Mount point \u0027%(path)s\u0027 already exists on \""},{"line_number":369,"context_line":"                                \"server \u0027%(server)s\u0027.\", log_data)"},{"line_number":370,"context_line":"            except exception.ProcessExecutionError as e:"},{"line_number":371,"context_line":"                raise exception.ShareBackendException(msg\u003dstr(e))"},{"line_number":372,"context_line":"        return _mount_device_with_lock()"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    @utils.retry(exception.ProcessExecutionError)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_d8cd055f","line":371,"updated":"2020-10-09 05:47:20.000000000","message":"pep8: M325 str() and unicode() cannot be used on an exception.  Remove or use six.text_type()","commit_id":"a4d86d4e9604fe819624ab18b67195c370cf7fa9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b5959485ab7f9dd0dc82e3b8b428bc4e5ea1714e","unresolved":false,"context_lines":[{"line_number":713,"context_line":"            raise exception.ShareShrinkingPossibleDataLoss("},{"line_number":714,"context_line":"                share_id\u003dshare[\u0027id\u0027])"},{"line_number":715,"context_line":"        except Exception as e:"},{"line_number":716,"context_line":"            msg \u003d _(\"Cannot shrink share: %s\") % str(e)"},{"line_number":717,"context_line":"            raise exception.Invalid(msg)"},{"line_number":718,"context_line":"        finally:"},{"line_number":719,"context_line":"            self._mount_device(share, server_details, volume)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_b8cad142","line":716,"updated":"2020-10-09 05:47:20.000000000","message":"pep8: M325 str() and unicode() cannot be used on an exception.  Remove or use six.text_type()","commit_id":"a4d86d4e9604fe819624ab18b67195c370cf7fa9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b5959485ab7f9dd0dc82e3b8b428bc4e5ea1714e","unresolved":false,"context_lines":[{"line_number":737,"context_line":"                       % str(new_size))"},{"line_number":738,"context_line":"                raise exception.Invalid(msg)"},{"line_number":739,"context_line":"            else:"},{"line_number":740,"context_line":"                msg \u003d _(\"Cannot resize file-system: %s\") % str(e)"},{"line_number":741,"context_line":"                raise exception.ManilaException(msg)"},{"line_number":742,"context_line":""},{"line_number":743,"context_line":"    def _is_share_server_active(self, context, share_server):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_18d49de9","line":740,"updated":"2020-10-09 05:47:20.000000000","message":"pep8: M325 str() and unicode() cannot be used on an exception.  Remove or use six.text_type()","commit_id":"a4d86d4e9604fe819624ab18b67195c370cf7fa9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b5959485ab7f9dd0dc82e3b8b428bc4e5ea1714e","unresolved":false,"context_lines":[{"line_number":938,"context_line":"                    return self.volume_api.get("},{"line_number":939,"context_line":"                        self.admin_context, driver_options[\u0027volume_id\u0027])"},{"line_number":940,"context_line":"                except exception.VolumeNotFound as e:"},{"line_number":941,"context_line":"                    raise exception.ManageInvalidShare(reason\u003dstr(e))"},{"line_number":942,"context_line":""},{"line_number":943,"context_line":"            # NOTE(vponomaryov): Manila can only combine volume name by itself,"},{"line_number":944,"context_line":"            # nowhere to get volume ID from. Return None since Cinder volume"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_f8d0c9f6","line":941,"updated":"2020-10-09 05:47:20.000000000","message":"pep8: M325 str() and unicode() cannot be used on an exception.  Remove or use six.text_type()","commit_id":"a4d86d4e9604fe819624ab18b67195c370cf7fa9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b5959485ab7f9dd0dc82e3b8b428bc4e5ea1714e","unresolved":false,"context_lines":[{"line_number":996,"context_line":"                provider_location)"},{"line_number":997,"context_line":"        except exception.VolumeSnapshotNotFound as e:"},{"line_number":998,"context_line":"            raise exception.ManageInvalidShareSnapshot("},{"line_number":999,"context_line":"                reason\u003dstr(e))"},{"line_number":1000,"context_line":""},{"line_number":1001,"context_line":"        if volume_snapshot:"},{"line_number":1002,"context_line":"            snapshot_size \u003d volume_snapshot[\u0027size\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_5803b576","line":999,"updated":"2020-10-09 05:47:20.000000000","message":"pep8: M325 str() and unicode() cannot be used on an exception.  Remove or use six.text_type()","commit_id":"a4d86d4e9604fe819624ab18b67195c370cf7fa9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b5959485ab7f9dd0dc82e3b8b428bc4e5ea1714e","unresolved":false,"context_lines":[{"line_number":1043,"context_line":"        except Exception as e:"},{"line_number":1044,"context_line":"            msg \u003d _(\"Cannot calculate size of share %(path)s : %(error)s\") % {"},{"line_number":1045,"context_line":"                \u0027path\u0027: mount_path,"},{"line_number":1046,"context_line":"                \u0027error\u0027: str(e)"},{"line_number":1047,"context_line":"            }"},{"line_number":1048,"context_line":"            raise exception.ManageInvalidShare(reason\u003dmsg)"},{"line_number":1049,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_3808818f","line":1046,"updated":"2020-10-09 05:47:20.000000000","message":"pep8: M325 str() and unicode() cannot be used on an exception.  Remove or use six.text_type()","commit_id":"a4d86d4e9604fe819624ab18b67195c370cf7fa9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b5959485ab7f9dd0dc82e3b8b428bc4e5ea1714e","unresolved":false,"context_lines":[{"line_number":1058,"context_line":"            msg \u003d _(\"Cannot calculate consumed space on share \""},{"line_number":1059,"context_line":"                    \"%(path)s : %(error)s\") % {"},{"line_number":1060,"context_line":"                \u0027path\u0027: mount_path,"},{"line_number":1061,"context_line":"                \u0027error\u0027: str(e)"},{"line_number":1062,"context_line":"            }"},{"line_number":1063,"context_line":"            raise exception.InvalidShare(reason\u003dmsg)"},{"line_number":1064,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_98f9cd83","line":1061,"updated":"2020-10-09 05:47:20.000000000","message":"pep8: M325 str() and unicode() cannot be used on an exception.  Remove or use six.text_type()","commit_id":"a4d86d4e9604fe819624ab18b67195c370cf7fa9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3595a0f700f502a31de91cb6fe48911cfb19f2ec","unresolved":true,"context_lines":[{"line_number":727,"context_line":"        command \u003d [\u0027sudo\u0027, \u0027resize2fs\u0027, volume[\u0027mountpoint\u0027]]"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"        if new_size:"},{"line_number":730,"context_line":"            command.append(\"%sG\" % str(new_size))"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"        try:"},{"line_number":733,"context_line":"            self._ssh_exec(server_details, command)"}],"source_content_type":"text/x-python","patch_set":6,"id":"d5ed90a7_0864372f","line":730,"range":{"start_line":730,"start_character":35,"end_line":730,"end_character":48},"updated":"2021-01-28 00:26:52.000000000","message":"No need to cast this, %s will implicitly type cast it.","commit_id":"09e29fc8939bfd39bf56089e98e5fc7a6eee40d7"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"286ae814edc5c6fb230f6729463177902678872e","unresolved":false,"context_lines":[{"line_number":727,"context_line":"        command \u003d [\u0027sudo\u0027, \u0027resize2fs\u0027, volume[\u0027mountpoint\u0027]]"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"        if new_size:"},{"line_number":730,"context_line":"            command.append(\"%sG\" % str(new_size))"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"        try:"},{"line_number":733,"context_line":"            self._ssh_exec(server_details, command)"}],"source_content_type":"text/x-python","patch_set":6,"id":"0f547a0a_e98ed107","line":730,"range":{"start_line":730,"start_character":35,"end_line":730,"end_character":48},"in_reply_to":"d5ed90a7_0864372f","updated":"2021-01-28 05:49:07.000000000","message":"Done","commit_id":"09e29fc8939bfd39bf56089e98e5fc7a6eee40d7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3595a0f700f502a31de91cb6fe48911cfb19f2ec","unresolved":true,"context_lines":[{"line_number":734,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":735,"context_line":"            if e.stderr.find(\u0027New size smaller than minimum\u0027) !\u003d -1:"},{"line_number":736,"context_line":"                msg \u003d (_(\"Invalid \u0027new_size\u0027 provided: %s\")"},{"line_number":737,"context_line":"                       % str(new_size))"},{"line_number":738,"context_line":"                raise exception.Invalid(msg)"},{"line_number":739,"context_line":"            else:"},{"line_number":740,"context_line":"                msg \u003d _(\"Cannot resize file-system: %s\") % str(e)"}],"source_content_type":"text/x-python","patch_set":6,"id":"61df5880_d96a35a8","line":737,"range":{"start_line":737,"start_character":25,"end_line":737,"end_character":38},"updated":"2021-01-28 00:26:52.000000000","message":"same as above","commit_id":"09e29fc8939bfd39bf56089e98e5fc7a6eee40d7"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"286ae814edc5c6fb230f6729463177902678872e","unresolved":false,"context_lines":[{"line_number":734,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":735,"context_line":"            if e.stderr.find(\u0027New size smaller than minimum\u0027) !\u003d -1:"},{"line_number":736,"context_line":"                msg \u003d (_(\"Invalid \u0027new_size\u0027 provided: %s\")"},{"line_number":737,"context_line":"                       % str(new_size))"},{"line_number":738,"context_line":"                raise exception.Invalid(msg)"},{"line_number":739,"context_line":"            else:"},{"line_number":740,"context_line":"                msg \u003d _(\"Cannot resize file-system: %s\") % str(e)"}],"source_content_type":"text/x-python","patch_set":6,"id":"d0647839_62435345","line":737,"range":{"start_line":737,"start_character":25,"end_line":737,"end_character":38},"in_reply_to":"61df5880_d96a35a8","updated":"2021-01-28 05:49:07.000000000","message":"Done","commit_id":"09e29fc8939bfd39bf56089e98e5fc7a6eee40d7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3595a0f700f502a31de91cb6fe48911cfb19f2ec","unresolved":true,"context_lines":[{"line_number":737,"context_line":"                       % str(new_size))"},{"line_number":738,"context_line":"                raise exception.Invalid(msg)"},{"line_number":739,"context_line":"            else:"},{"line_number":740,"context_line":"                msg \u003d _(\"Cannot resize file-system: %s\") % str(e)"},{"line_number":741,"context_line":"                raise exception.ManilaException(msg)"},{"line_number":742,"context_line":""},{"line_number":743,"context_line":"    def _is_share_server_active(self, context, share_server):"}],"source_content_type":"text/x-python","patch_set":6,"id":"a75da24d_b30ab5b5","line":740,"range":{"start_line":740,"start_character":59,"end_line":740,"end_character":65},"updated":"2021-01-28 00:26:52.000000000","message":"same as above","commit_id":"09e29fc8939bfd39bf56089e98e5fc7a6eee40d7"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"286ae814edc5c6fb230f6729463177902678872e","unresolved":false,"context_lines":[{"line_number":737,"context_line":"                       % str(new_size))"},{"line_number":738,"context_line":"                raise exception.Invalid(msg)"},{"line_number":739,"context_line":"            else:"},{"line_number":740,"context_line":"                msg \u003d _(\"Cannot resize file-system: %s\") % str(e)"},{"line_number":741,"context_line":"                raise exception.ManilaException(msg)"},{"line_number":742,"context_line":""},{"line_number":743,"context_line":"    def _is_share_server_active(self, context, share_server):"}],"source_content_type":"text/x-python","patch_set":6,"id":"86d7efc9_7b3fda36","line":740,"range":{"start_line":740,"start_character":59,"end_line":740,"end_character":65},"in_reply_to":"a75da24d_b30ab5b5","updated":"2021-01-28 05:49:07.000000000","message":"Done","commit_id":"09e29fc8939bfd39bf56089e98e5fc7a6eee40d7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3595a0f700f502a31de91cb6fe48911cfb19f2ec","unresolved":true,"context_lines":[{"line_number":1043,"context_line":"        except Exception as e:"},{"line_number":1044,"context_line":"            msg \u003d _(\"Cannot calculate size of share %(path)s : %(error)s\") % {"},{"line_number":1045,"context_line":"                \u0027path\u0027: mount_path,"},{"line_number":1046,"context_line":"                \u0027error\u0027: str(e)"},{"line_number":1047,"context_line":"            }"},{"line_number":1048,"context_line":"            raise exception.ManageInvalidShare(reason\u003dmsg)"},{"line_number":1049,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"2de15344_6d7ca37f","line":1046,"range":{"start_line":1046,"start_character":25,"end_line":1046,"end_character":31},"updated":"2021-01-28 00:26:52.000000000","message":"No need to cast this, %s will implicitly type cast it.","commit_id":"09e29fc8939bfd39bf56089e98e5fc7a6eee40d7"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"286ae814edc5c6fb230f6729463177902678872e","unresolved":false,"context_lines":[{"line_number":1043,"context_line":"        except Exception as e:"},{"line_number":1044,"context_line":"            msg \u003d _(\"Cannot calculate size of share %(path)s : %(error)s\") % {"},{"line_number":1045,"context_line":"                \u0027path\u0027: mount_path,"},{"line_number":1046,"context_line":"                \u0027error\u0027: str(e)"},{"line_number":1047,"context_line":"            }"},{"line_number":1048,"context_line":"            raise exception.ManageInvalidShare(reason\u003dmsg)"},{"line_number":1049,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"8e6050b0_618fb635","line":1046,"range":{"start_line":1046,"start_character":25,"end_line":1046,"end_character":31},"in_reply_to":"2de15344_6d7ca37f","updated":"2021-01-28 05:49:07.000000000","message":"Done","commit_id":"09e29fc8939bfd39bf56089e98e5fc7a6eee40d7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3595a0f700f502a31de91cb6fe48911cfb19f2ec","unresolved":true,"context_lines":[{"line_number":1058,"context_line":"            msg \u003d _(\"Cannot calculate consumed space on share \""},{"line_number":1059,"context_line":"                    \"%(path)s : %(error)s\") % {"},{"line_number":1060,"context_line":"                \u0027path\u0027: mount_path,"},{"line_number":1061,"context_line":"                \u0027error\u0027: str(e)"},{"line_number":1062,"context_line":"            }"},{"line_number":1063,"context_line":"            raise exception.InvalidShare(reason\u003dmsg)"},{"line_number":1064,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ddd2e3e6_7f6a4353","line":1061,"range":{"start_line":1061,"start_character":25,"end_line":1061,"end_character":31},"updated":"2021-01-28 00:26:52.000000000","message":"No need to cast this, %s will implicitly type cast it.","commit_id":"09e29fc8939bfd39bf56089e98e5fc7a6eee40d7"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"286ae814edc5c6fb230f6729463177902678872e","unresolved":false,"context_lines":[{"line_number":1058,"context_line":"            msg \u003d _(\"Cannot calculate consumed space on share \""},{"line_number":1059,"context_line":"                    \"%(path)s : %(error)s\") % {"},{"line_number":1060,"context_line":"                \u0027path\u0027: mount_path,"},{"line_number":1061,"context_line":"                \u0027error\u0027: str(e)"},{"line_number":1062,"context_line":"            }"},{"line_number":1063,"context_line":"            raise exception.InvalidShare(reason\u003dmsg)"},{"line_number":1064,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"667d8661_175cb462","line":1061,"range":{"start_line":1061,"start_character":25,"end_line":1061,"end_character":31},"in_reply_to":"ddd2e3e6_7f6a4353","updated":"2021-01-28 05:49:07.000000000","message":"Done","commit_id":"09e29fc8939bfd39bf56089e98e5fc7a6eee40d7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6061946ab5839512fe26d8ea27179087b67f1f83","unresolved":true,"context_lines":[{"line_number":954,"context_line":""},{"line_number":955,"context_line":"            attached_volumes \u003d [vol.id for vol in instance_volumes]"},{"line_number":956,"context_line":"            LOG.debug(\u0027Manage: attached volumes \u003d %s\u0027,"},{"line_number":957,"context_line":"                      str(attached_volumes))"},{"line_number":958,"context_line":""},{"line_number":959,"context_line":"            if share_volume[\u0027id\u0027] not in attached_volumes:"},{"line_number":960,"context_line":"                msg \u003d _(\"Provided volume %s is not attached \""}],"source_content_type":"text/x-python","patch_set":7,"id":"01ba1c4b_5c878fc1","line":957,"range":{"start_line":957,"start_character":22,"end_line":957,"end_character":25},"updated":"2021-01-29 21:13:58.000000000","message":"no need to convert, formatting will handle this","commit_id":"566dd8a926d62f0ada40b1b083852b67f15b2ad1"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"6fe41589fbcf2fd2702ffa9d6f0cfc2ee453905c","unresolved":false,"context_lines":[{"line_number":954,"context_line":""},{"line_number":955,"context_line":"            attached_volumes \u003d [vol.id for vol in instance_volumes]"},{"line_number":956,"context_line":"            LOG.debug(\u0027Manage: attached volumes \u003d %s\u0027,"},{"line_number":957,"context_line":"                      str(attached_volumes))"},{"line_number":958,"context_line":""},{"line_number":959,"context_line":"            if share_volume[\u0027id\u0027] not in attached_volumes:"},{"line_number":960,"context_line":"                msg \u003d _(\"Provided volume %s is not attached \""}],"source_content_type":"text/x-python","patch_set":7,"id":"c9ddc505_f4a80b6f","line":957,"range":{"start_line":957,"start_character":22,"end_line":957,"end_character":25},"in_reply_to":"01ba1c4b_5c878fc1","updated":"2021-02-01 09:54:25.000000000","message":"Done","commit_id":"566dd8a926d62f0ada40b1b083852b67f15b2ad1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"05a460e3088fdf61c45afddee288a7e728432f7f","unresolved":true,"context_lines":[{"line_number":956,"context_line":""},{"line_number":957,"context_line":"            attached_volumes \u003d [vol.id for vol in instance_volumes]"},{"line_number":958,"context_line":"            LOG.debug(\u0027Manage: attached volumes \u003d %s\u0027,"},{"line_number":959,"context_line":"                      str(attached_volumes))"},{"line_number":960,"context_line":""},{"line_number":961,"context_line":"            if share_volume[\u0027id\u0027] not in attached_volumes:"},{"line_number":962,"context_line":"                msg \u003d _(\"Provided volume %s is not attached \""}],"source_content_type":"text/x-python","patch_set":14,"id":"91a9a984_9ffd5ab3","line":959,"range":{"start_line":959,"start_character":22,"end_line":959,"end_character":25},"updated":"2021-12-07 21:51:50.000000000","message":"no need to string cast this..","commit_id":"f56485edfeee12ace37757d4f49df09c53a8ffd5"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"ce56f2ef17873d95ddf812281efd9d89aea32df7","unresolved":false,"context_lines":[{"line_number":956,"context_line":""},{"line_number":957,"context_line":"            attached_volumes \u003d [vol.id for vol in instance_volumes]"},{"line_number":958,"context_line":"            LOG.debug(\u0027Manage: attached volumes \u003d %s\u0027,"},{"line_number":959,"context_line":"                      str(attached_volumes))"},{"line_number":960,"context_line":""},{"line_number":961,"context_line":"            if share_volume[\u0027id\u0027] not in attached_volumes:"},{"line_number":962,"context_line":"                msg \u003d _(\"Provided volume %s is not attached \""}],"source_content_type":"text/x-python","patch_set":14,"id":"b1cd922c_bc28f99a","line":959,"range":{"start_line":959,"start_character":22,"end_line":959,"end_character":25},"in_reply_to":"91a9a984_9ffd5ab3","updated":"2021-12-09 08:54:47.000000000","message":"Done","commit_id":"f56485edfeee12ace37757d4f49df09c53a8ffd5"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"bb1f773425243918e65f961fcc10f1b35d87bf48","unresolved":true,"context_lines":[{"line_number":739,"context_line":"                       % new_size)"},{"line_number":740,"context_line":"                raise exception.Invalid(msg)"},{"line_number":741,"context_line":"            else:"},{"line_number":742,"context_line":"                msg \u003d _(\"Cannot resize file-system: %s\") % e"},{"line_number":743,"context_line":"                raise exception.ManilaException(msg)"},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"    def _is_share_server_active(self, context, share_server):"}],"source_content_type":"text/x-python","patch_set":16,"id":"f8a4be73_0a0fb4ae","line":742,"range":{"start_line":742,"start_character":59,"end_line":742,"end_character":60},"updated":"2022-02-10 22:26:27.000000000","message":"could be str(e) to follow the pattern adopted above","commit_id":"7f2b25332a2030d147083c90ab268c126575a3ce"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"65a58f1b0fa8e0ff4107937c553d726a24361f6f","unresolved":true,"context_lines":[{"line_number":739,"context_line":"                       % new_size)"},{"line_number":740,"context_line":"                raise exception.Invalid(msg)"},{"line_number":741,"context_line":"            else:"},{"line_number":742,"context_line":"                msg \u003d _(\"Cannot resize file-system: %s\") % e"},{"line_number":743,"context_line":"                raise exception.ManilaException(msg)"},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"    def _is_share_server_active(self, context, share_server):"}],"source_content_type":"text/x-python","patch_set":16,"id":"9b363bfc_debca8c2","line":742,"range":{"start_line":742,"start_character":59,"end_line":742,"end_character":60},"in_reply_to":"f8a4be73_0a0fb4ae","updated":"2022-02-10 22:40:25.000000000","message":"You really don\u0027t need to type cast the exception... %s formats the exception as a string which calls into the __str__ representation; so a lot of this string casting is redundant.. \n\nI took a mental note to get one of our interns to remove these in a follow up patch.","commit_id":"7f2b25332a2030d147083c90ab268c126575a3ce"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"bb1f773425243918e65f961fcc10f1b35d87bf48","unresolved":true,"context_lines":[{"line_number":1044,"context_line":"        except Exception as e:"},{"line_number":1045,"context_line":"            msg \u003d _(\"Cannot calculate size of share %(path)s : %(error)s\") % {"},{"line_number":1046,"context_line":"                \u0027path\u0027: mount_path,"},{"line_number":1047,"context_line":"                \u0027error\u0027: e"},{"line_number":1048,"context_line":"            }"},{"line_number":1049,"context_line":"            raise exception.ManageInvalidShare(reason\u003dmsg)"},{"line_number":1050,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"8e001b9d_ad2b03a7","line":1047,"range":{"start_line":1047,"start_character":25,"end_line":1047,"end_character":26},"updated":"2022-02-10 22:26:27.000000000","message":"same","commit_id":"7f2b25332a2030d147083c90ab268c126575a3ce"}],"manila/share/drivers/helpers.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3595a0f700f502a31de91cb6fe48911cfb19f2ec","unresolved":true,"context_lines":[{"line_number":185,"context_line":"    if addr.version \u003d\u003d 4:"},{"line_number":186,"context_line":"        return str(addr)"},{"line_number":187,"context_line":"    else:"},{"line_number":188,"context_line":"        return \u0027[%s]\u0027 % str(addr)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"class NFSHelper(NASHelperBase):"}],"source_content_type":"text/x-python","patch_set":6,"id":"84bba8a5_107ab874","line":188,"range":{"start_line":188,"start_character":24,"end_line":188,"end_character":33},"updated":"2021-01-28 00:26:52.000000000","message":"No need to cast this, %s will implicitly type cast it.","commit_id":"09e29fc8939bfd39bf56089e98e5fc7a6eee40d7"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"286ae814edc5c6fb230f6729463177902678872e","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    if addr.version \u003d\u003d 4:"},{"line_number":186,"context_line":"        return str(addr)"},{"line_number":187,"context_line":"    else:"},{"line_number":188,"context_line":"        return \u0027[%s]\u0027 % str(addr)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"class NFSHelper(NASHelperBase):"}],"source_content_type":"text/x-python","patch_set":6,"id":"f73819c3_d491af36","line":188,"range":{"start_line":188,"start_character":24,"end_line":188,"end_character":33},"in_reply_to":"84bba8a5_107ab874","updated":"2021-01-28 05:49:07.000000000","message":"Done","commit_id":"09e29fc8939bfd39bf56089e98e5fc7a6eee40d7"}],"manila/share_group/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3595a0f700f502a31de91cb6fe48911cfb19f2ec","unresolved":true,"context_lines":[{"line_number":326,"context_line":"            search_opts \u003d {}"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        LOG.debug(\"Searching for share_groups by: %s\","},{"line_number":329,"context_line":"                  str(search_opts))"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        # Get filtered list of share_groups"},{"line_number":332,"context_line":"        if search_opts.pop(\u0027all_tenants\u0027, 0) and context.is_admin:"}],"source_content_type":"text/x-python","patch_set":6,"id":"c640cade_f5fee307","line":329,"range":{"start_line":329,"start_character":18,"end_line":329,"end_character":34},"updated":"2021-01-28 00:26:52.000000000","message":"No need to cast this; %s will take care of casting it implicitly","commit_id":"09e29fc8939bfd39bf56089e98e5fc7a6eee40d7"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"286ae814edc5c6fb230f6729463177902678872e","unresolved":false,"context_lines":[{"line_number":326,"context_line":"            search_opts \u003d {}"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        LOG.debug(\"Searching for share_groups by: %s\","},{"line_number":329,"context_line":"                  str(search_opts))"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        # Get filtered list of share_groups"},{"line_number":332,"context_line":"        if search_opts.pop(\u0027all_tenants\u0027, 0) and context.is_admin:"}],"source_content_type":"text/x-python","patch_set":6,"id":"987a0785_6ada6a3e","line":329,"range":{"start_line":329,"start_character":18,"end_line":329,"end_character":34},"in_reply_to":"c640cade_f5fee307","updated":"2021-01-28 05:49:07.000000000","message":"Done","commit_id":"09e29fc8939bfd39bf56089e98e5fc7a6eee40d7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3595a0f700f502a31de91cb6fe48911cfb19f2ec","unresolved":true,"context_lines":[{"line_number":481,"context_line":"        if search_opts is None:"},{"line_number":482,"context_line":"            search_opts \u003d {}"},{"line_number":483,"context_line":"        LOG.debug(\"Searching for share group snapshots by: %s\","},{"line_number":484,"context_line":"                  str(search_opts))"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"        # Get filtered list of share group snapshots"},{"line_number":487,"context_line":"        if search_opts.pop(\u0027all_tenants\u0027, 0) and context.is_admin:"}],"source_content_type":"text/x-python","patch_set":6,"id":"f8827758_896d619b","line":484,"range":{"start_line":484,"start_character":18,"end_line":484,"end_character":34},"updated":"2021-01-28 00:26:52.000000000","message":"same as above","commit_id":"09e29fc8939bfd39bf56089e98e5fc7a6eee40d7"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"286ae814edc5c6fb230f6729463177902678872e","unresolved":false,"context_lines":[{"line_number":481,"context_line":"        if search_opts is None:"},{"line_number":482,"context_line":"            search_opts \u003d {}"},{"line_number":483,"context_line":"        LOG.debug(\"Searching for share group snapshots by: %s\","},{"line_number":484,"context_line":"                  str(search_opts))"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"        # Get filtered list of share group snapshots"},{"line_number":487,"context_line":"        if search_opts.pop(\u0027all_tenants\u0027, 0) and context.is_admin:"}],"source_content_type":"text/x-python","patch_set":6,"id":"d3cc2c9e_aa334358","line":484,"range":{"start_line":484,"start_character":18,"end_line":484,"end_character":34},"in_reply_to":"f8827758_896d619b","updated":"2021-01-28 05:49:07.000000000","message":"Done","commit_id":"09e29fc8939bfd39bf56089e98e5fc7a6eee40d7"}],"manila/tests/test_utils.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3595a0f700f502a31de91cb6fe48911cfb19f2ec","unresolved":true,"context_lines":[{"line_number":810,"context_line":""},{"line_number":811,"context_line":"        output_value \u003d utils.convert_str(input_value)"},{"line_number":812,"context_line":""},{"line_number":813,"context_line":"        if six.PY2:"},{"line_number":814,"context_line":"            encodeutils.safe_encode.assert_called_once_with(input_value)"},{"line_number":815,"context_line":"            self.assertEqual("},{"line_number":816,"context_line":"                encodeutils.safe_encode.return_value, output_value)"},{"line_number":817,"context_line":"        else:"},{"line_number":818,"context_line":"            self.assertEqual(0, encodeutils.safe_encode.call_count)"},{"line_number":819,"context_line":"            self.assertEqual(input_value, output_value)"},{"line_number":820,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dc9fd5fd_096410df","line":817,"range":{"start_line":813,"start_character":8,"end_line":817,"end_character":13},"updated":"2021-01-28 00:26:52.000000000","message":"we can now remove this","commit_id":"09e29fc8939bfd39bf56089e98e5fc7a6eee40d7"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"286ae814edc5c6fb230f6729463177902678872e","unresolved":false,"context_lines":[{"line_number":810,"context_line":""},{"line_number":811,"context_line":"        output_value \u003d utils.convert_str(input_value)"},{"line_number":812,"context_line":""},{"line_number":813,"context_line":"        if six.PY2:"},{"line_number":814,"context_line":"            encodeutils.safe_encode.assert_called_once_with(input_value)"},{"line_number":815,"context_line":"            self.assertEqual("},{"line_number":816,"context_line":"                encodeutils.safe_encode.return_value, output_value)"},{"line_number":817,"context_line":"        else:"},{"line_number":818,"context_line":"            self.assertEqual(0, encodeutils.safe_encode.call_count)"},{"line_number":819,"context_line":"            self.assertEqual(input_value, output_value)"},{"line_number":820,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"a197f5d2_3e834bcc","line":817,"range":{"start_line":813,"start_character":8,"end_line":817,"end_character":13},"in_reply_to":"dc9fd5fd_096410df","updated":"2021-01-28 05:49:07.000000000","message":"Done","commit_id":"09e29fc8939bfd39bf56089e98e5fc7a6eee40d7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3595a0f700f502a31de91cb6fe48911cfb19f2ec","unresolved":true,"context_lines":[{"line_number":827,"context_line":""},{"line_number":828,"context_line":"        output_value \u003d utils.convert_str(input_value)"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"        if six.PY2:"},{"line_number":831,"context_line":"            encodeutils.safe_encode.assert_called_once_with(input_value)"},{"line_number":832,"context_line":"            self.assertEqual("},{"line_number":833,"context_line":"                encodeutils.safe_encode.return_value, output_value)"},{"line_number":834,"context_line":"        else:"},{"line_number":835,"context_line":"            self.assertEqual(0, encodeutils.safe_encode.call_count)"},{"line_number":836,"context_line":"            self.assertIsInstance(output_value, six.string_types)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9d26acda_82d6c438","line":833,"range":{"start_line":830,"start_character":0,"end_line":833,"end_character":67},"updated":"2021-01-28 00:26:52.000000000","message":"same as above","commit_id":"09e29fc8939bfd39bf56089e98e5fc7a6eee40d7"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"286ae814edc5c6fb230f6729463177902678872e","unresolved":false,"context_lines":[{"line_number":827,"context_line":""},{"line_number":828,"context_line":"        output_value \u003d utils.convert_str(input_value)"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"        if six.PY2:"},{"line_number":831,"context_line":"            encodeutils.safe_encode.assert_called_once_with(input_value)"},{"line_number":832,"context_line":"            self.assertEqual("},{"line_number":833,"context_line":"                encodeutils.safe_encode.return_value, output_value)"},{"line_number":834,"context_line":"        else:"},{"line_number":835,"context_line":"            self.assertEqual(0, encodeutils.safe_encode.call_count)"},{"line_number":836,"context_line":"            self.assertIsInstance(output_value, six.string_types)"}],"source_content_type":"text/x-python","patch_set":6,"id":"eb7d7be1_b3c273f7","line":833,"range":{"start_line":830,"start_character":0,"end_line":833,"end_character":67},"in_reply_to":"9d26acda_82d6c438","updated":"2021-01-28 05:49:07.000000000","message":"Done","commit_id":"09e29fc8939bfd39bf56089e98e5fc7a6eee40d7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6061946ab5839512fe26d8ea27179087b67f1f83","unresolved":true,"context_lines":[{"line_number":815,"context_line":""},{"line_number":816,"context_line":"    def test_convert_str_bytes_input(self):"},{"line_number":817,"context_line":"        self.mock_object(encodeutils, \u0027safe_encode\u0027)"},{"line_number":818,"context_line":"        input_value \u003d six.binary_type(\"binary_input\", \"utf-8\")"},{"line_number":819,"context_line":""},{"line_number":820,"context_line":"        output_value \u003d utils.convert_str(input_value)"},{"line_number":821,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"a47ad6fd_febddf40","line":818,"range":{"start_line":818,"start_character":22,"end_line":818,"end_character":62},"updated":"2021-01-29 21:13:58.000000000","message":"you can drop six here:\n\n \"binary_input\".encode(\u0027utf-8\u0027)\n\nor simply:\n  \n  b\u0027binary-input\u0027","commit_id":"566dd8a926d62f0ada40b1b083852b67f15b2ad1"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"6fe41589fbcf2fd2702ffa9d6f0cfc2ee453905c","unresolved":false,"context_lines":[{"line_number":815,"context_line":""},{"line_number":816,"context_line":"    def test_convert_str_bytes_input(self):"},{"line_number":817,"context_line":"        self.mock_object(encodeutils, \u0027safe_encode\u0027)"},{"line_number":818,"context_line":"        input_value \u003d six.binary_type(\"binary_input\", \"utf-8\")"},{"line_number":819,"context_line":""},{"line_number":820,"context_line":"        output_value \u003d utils.convert_str(input_value)"},{"line_number":821,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"21f5cc32_2f02f851","line":818,"range":{"start_line":818,"start_character":22,"end_line":818,"end_character":62},"in_reply_to":"a47ad6fd_febddf40","updated":"2021-02-01 09:54:25.000000000","message":"This patch is repeated with another patch:\nhttps://review.opendev.org/c/openstack/manila/+/757071/10/manila/tests/test_utils.py\nhttps://review.opendev.org/c/openstack/manila/+/757071/10/manila/tests/scheduler/test_scheduler_options.py\ni will removed change here.","commit_id":"566dd8a926d62f0ada40b1b083852b67f15b2ad1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6061946ab5839512fe26d8ea27179087b67f1f83","unresolved":true,"context_lines":[{"line_number":821,"context_line":""},{"line_number":822,"context_line":"        self.assertEqual(0, encodeutils.safe_encode.call_count)"},{"line_number":823,"context_line":"        self.assertIsInstance(output_value, six.string_types)"},{"line_number":824,"context_line":"        self.assertEqual(six.text_type(\"binary_input\"), output_value)"},{"line_number":825,"context_line":""},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":7,"id":"0b401e4d_7c613f4c","line":824,"range":{"start_line":824,"start_character":25,"end_line":824,"end_character":54},"updated":"2021-01-29 21:13:58.000000000","message":"b\u0027binary_input\u0027","commit_id":"566dd8a926d62f0ada40b1b083852b67f15b2ad1"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"6fe41589fbcf2fd2702ffa9d6f0cfc2ee453905c","unresolved":false,"context_lines":[{"line_number":821,"context_line":""},{"line_number":822,"context_line":"        self.assertEqual(0, encodeutils.safe_encode.call_count)"},{"line_number":823,"context_line":"        self.assertIsInstance(output_value, six.string_types)"},{"line_number":824,"context_line":"        self.assertEqual(six.text_type(\"binary_input\"), output_value)"},{"line_number":825,"context_line":""},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":7,"id":"6d27a9ed_d2e5186a","line":824,"range":{"start_line":824,"start_character":25,"end_line":824,"end_character":54},"in_reply_to":"0b401e4d_7c613f4c","updated":"2021-02-01 09:54:25.000000000","message":"same","commit_id":"566dd8a926d62f0ada40b1b083852b67f15b2ad1"}],"manila/utils.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b5959485ab7f9dd0dc82e3b8b428bc4e5ea1714e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"from oslo_concurrency import processutils"},{"line_number":37,"context_line":"from oslo_config import cfg"},{"line_number":38,"context_line":"from oslo_log import log"},{"line_number":39,"context_line":"from oslo_utils import encodeutils"},{"line_number":40,"context_line":"from oslo_utils import importutils"},{"line_number":41,"context_line":"from oslo_utils import netutils"},{"line_number":42,"context_line":"from oslo_utils import strutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_58da951c","line":39,"updated":"2020-10-09 05:47:20.000000000","message":"pep8: F401 \u0027oslo_utils.encodeutils\u0027 imported but unused","commit_id":"a4d86d4e9604fe819624ab18b67195c370cf7fa9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b5959485ab7f9dd0dc82e3b8b428bc4e5ea1714e","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        try:"},{"line_number":401,"context_line":"            all_tenants \u003d strutils.bool_from_string(all_tenants, True)"},{"line_number":402,"context_line":"        except ValueError as err:"},{"line_number":403,"context_line":"            raise exception.InvalidInput(str(err))"},{"line_number":404,"context_line":"    else:"},{"line_number":405,"context_line":"        # The empty string is considered enabling all_tenants"},{"line_number":406,"context_line":"        all_tenants \u003d \u0027all_tenants\u0027 in search_opts"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_38dfe10c","line":403,"updated":"2020-10-09 05:47:20.000000000","message":"pep8: M325 str() and unicode() cannot be used on an exception.  Remove or use six.text_type()","commit_id":"a4d86d4e9604fe819624ab18b67195c370cf7fa9"}],"manila/volume/cinder.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b5959485ab7f9dd0dc82e3b8b428bc4e5ea1714e","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            if isinstance(e, cinder_exception.NotFound):"},{"line_number":160,"context_line":"                raise exception.VolumeNotFound(volume_id\u003dvolume_id)"},{"line_number":161,"context_line":"            elif isinstance(e, cinder_exception.BadRequest):"},{"line_number":162,"context_line":"                raise exception.InvalidInput(reason\u003dstr(e))"},{"line_number":163,"context_line":"        return res"},{"line_number":164,"context_line":"    return wrapper"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_78fe796a","line":162,"updated":"2020-10-09 05:47:20.000000000","message":"pep8: M325 str() and unicode() cannot be used on an exception.  Remove or use six.text_type()","commit_id":"a4d86d4e9604fe819624ab18b67195c370cf7fa9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b5959485ab7f9dd0dc82e3b8b428bc4e5ea1714e","unresolved":false,"context_lines":[{"line_number":277,"context_line":"            item \u003d cinderclient(context).volumes.create(size, **kwargs)"},{"line_number":278,"context_line":"            return _untranslate_volume_summary_view(context, item)"},{"line_number":279,"context_line":"        except cinder_exception.BadRequest as e:"},{"line_number":280,"context_line":"            raise exception.InvalidInput(reason\u003dstr(e))"},{"line_number":281,"context_line":"        except cinder_exception.NotFound:"},{"line_number":282,"context_line":"            raise exception.NotFound("},{"line_number":283,"context_line":"                _(\"Error in creating cinder \""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_d8f6a590","line":280,"updated":"2020-10-09 05:47:20.000000000","message":"pep8: M325 str() and unicode() cannot be used on an exception.  Remove or use six.text_type()","commit_id":"a4d86d4e9604fe819624ab18b67195c370cf7fa9"}]}