)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"4bc2431af7609c2deac7b0532b0293dd80080f04","unresolved":true,"context_lines":[{"line_number":84,"context_line":"# configure_default_backends - configures default Manila backends with generic driver."},{"line_number":85,"context_line":"function configure_default_backends {"},{"line_number":86,"context_line":"    # Configure two default backends with generic drivers onboard"},{"line_number":87,"context_line":"    for group_name in $(echo $MANILA_ENABLED_BACKENDS | sed \"s/,/ /g\"); do"},{"line_number":88,"context_line":"        iniset $MANILA_CONF $group_name share_driver $SHARE_DRIVER"},{"line_number":89,"context_line":"        iniset $MANILA_CONF $group_name share_backend_name ${group_name^^}"},{"line_number":90,"context_line":"        iniset $MANILA_CONF $group_name path_to_public_key $MANILA_PATH_TO_PUBLIC_KEY"},{"line_number":91,"context_line":"        iniset $MANILA_CONF $group_name path_to_private_key $MANILA_PATH_TO_PRIVATE_KEY"},{"line_number":92,"context_line":"        iniset $MANILA_CONF $group_name service_image_name $MANILA_SERVICE_IMAGE_NAME"}],"source_content_type":"text/x-sh","patch_set":2,"id":"4da67988_eb46e409","line":89,"range":{"start_line":87,"start_character":0,"end_line":89,"end_character":74},"updated":"2020-12-16 12:32:12.000000000","message":"hum, another idea is to use IFS to create a array to iterate over\n\nIFS\u003d\u0027,\u0027 read -a backends \u003c\u003c\u003c \"${MANILA_ENABLED_BACKENDS}\"","commit_id":"8f40fa2bc56936322109204d4d7170a55f2921d0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"10801a4b73c3713d73fcc88d472ccd8d8f7674fb","unresolved":false,"context_lines":[{"line_number":1001,"context_line":""},{"line_number":1002,"context_line":""},{"line_number":1003,"context_line":"function install_libraries {"},{"line_number":1004,"context_line":"        if [ $(trueorfalse True RUN_MANILA_HOST_ASSISTED_MIGRATION_TESTS) \u003d\u003d True ]; then"},{"line_number":1005,"context_line":"            if is_ubuntu; then"},{"line_number":1006,"context_line":"                install_package nfs-common"},{"line_number":1007,"context_line":"            else"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1f621f24_9dd3de38","line":1004,"range":{"start_line":1004,"start_character":4,"end_line":1004,"end_character":8},"updated":"2021-01-15 21:10:21.000000000","message":"nit: reduce indent in this line and the following lines","commit_id":"8f40fa2bc56936322109204d4d7170a55f2921d0"}],"devstack/settings":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"4bc2431af7609c2deac7b0532b0293dd80080f04","unresolved":true,"context_lines":[{"line_number":14,"context_line":"# \u0027MANILA_ENABLED_BACKENDS\u0027."},{"line_number":15,"context_line":"# DEFAULT group is always defined, no need to specify it within \u0027MANILA_CONFIGURE_GROUPS\u0027."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# 4) \u0027CINDER_OVERSUBSCRIPTION_RATIO\u0027 - manila devstack-plugin env var that is"},{"line_number":18,"context_line":"# useful for all share drivers that use Cinder. If it is set, then it will be"},{"line_number":19,"context_line":"# applied for two Cinder options: \u0027max_over_subscription_ratio\u0027 and"},{"line_number":20,"context_line":"# \u0027lvm_max_over_subscription_ratio\u0027. Should be float. Example:"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"08e808b5_f8f9f1f3","line":17,"range":{"start_line":17,"start_character":2,"end_line":17,"end_character":3},"updated":"2020-12-16 12:32:12.000000000","message":"3)","commit_id":"8f40fa2bc56936322109204d4d7170a55f2921d0"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"b312d4fbf9010e64570726dcd02773a4c1f64fd3","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# \u0027MANILA_ENABLED_BACKENDS\u0027."},{"line_number":15,"context_line":"# DEFAULT group is always defined, no need to specify it within \u0027MANILA_CONFIGURE_GROUPS\u0027."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# 4) \u0027CINDER_OVERSUBSCRIPTION_RATIO\u0027 - manila devstack-plugin env var that is"},{"line_number":18,"context_line":"# useful for all share drivers that use Cinder. If it is set, then it will be"},{"line_number":19,"context_line":"# applied for two Cinder options: \u0027max_over_subscription_ratio\u0027 and"},{"line_number":20,"context_line":"# \u0027lvm_max_over_subscription_ratio\u0027. Should be float. Example:"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"4fb365fd_dd6b7c32","line":17,"range":{"start_line":17,"start_character":2,"end_line":17,"end_character":3},"in_reply_to":"08e808b5_f8f9f1f3","updated":"2021-01-15 21:59:15.000000000","message":"Done","commit_id":"8f40fa2bc56936322109204d4d7170a55f2921d0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"10801a4b73c3713d73fcc88d472ccd8d8f7674fb","unresolved":true,"context_lines":[{"line_number":135,"context_line":"MANILA_SERVICE_VM_FLAVOR_DISK\u003d${MANILA_SERVICE_VM_FLAVOR_DISK:-3}"},{"line_number":136,"context_line":"MANILA_SERVICE_VM_FLAVOR_VCPUS\u003d${MANILA_SERVICE_VM_FLAVOR_VCPUS:-1}"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# Enable this option when using a storage backend that is on the same host"},{"line_number":139,"context_line":"# as the devstack host, these iptable rules are necessary to allow mounting"},{"line_number":140,"context_line":"# shares from the host"},{"line_number":141,"context_line":"MANILA_ALLOW_NAS_SERVER_PORTS_ON_HOST\u003d${MANILA_ALLOW_NAS_SERVER_PORTS_ON_HOST:-False}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"712184e9_807ebc2c","line":138,"updated":"2021-01-15 21:10:21.000000000","message":"With this change, a previously optional parameter: MANILA_ENABLED_BACKENDS is becoming mandatory. Can we have a sensible default instead for those that don\u0027t want to use this option?\nWe configure \"default_backends\" for ease of use, and enable the generic driver - so can that be the default?\n\n MANILA_ENABLED_BACKENDS\u003dgeneric1,generic2\n\n\nWithout a default, our CI jobs are bound to fail, see the failing:\n\nGrenade Job: https://zuul.opendev.org/t/openstack/build/db716367b9bb488d9607e0c4cecf7314\nGeneric Driver job: https://zuul.opendev.org/t/openstack/build/13048e4451be4f0dbf058b3691687925\n\nSo we\u0027d either need to prevent this backwards incompatible change by having a default as indicated above, or fix the job manifests to set \"MANILA_ENABLED_BACKENDS\".","commit_id":"8f40fa2bc56936322109204d4d7170a55f2921d0"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"b312d4fbf9010e64570726dcd02773a4c1f64fd3","unresolved":false,"context_lines":[{"line_number":135,"context_line":"MANILA_SERVICE_VM_FLAVOR_DISK\u003d${MANILA_SERVICE_VM_FLAVOR_DISK:-3}"},{"line_number":136,"context_line":"MANILA_SERVICE_VM_FLAVOR_VCPUS\u003d${MANILA_SERVICE_VM_FLAVOR_VCPUS:-1}"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# Enable this option when using a storage backend that is on the same host"},{"line_number":139,"context_line":"# as the devstack host, these iptable rules are necessary to allow mounting"},{"line_number":140,"context_line":"# shares from the host"},{"line_number":141,"context_line":"MANILA_ALLOW_NAS_SERVER_PORTS_ON_HOST\u003d${MANILA_ALLOW_NAS_SERVER_PORTS_ON_HOST:-False}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"21aceaa6_0e1ba9f7","line":138,"in_reply_to":"481d577d_1bda1ceb","updated":"2021-01-15 21:59:15.000000000","message":"Done","commit_id":"8f40fa2bc56936322109204d4d7170a55f2921d0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cb5b610b8d4e084fd202e2b8341c6e11367937fd","unresolved":true,"context_lines":[{"line_number":135,"context_line":"MANILA_SERVICE_VM_FLAVOR_DISK\u003d${MANILA_SERVICE_VM_FLAVOR_DISK:-3}"},{"line_number":136,"context_line":"MANILA_SERVICE_VM_FLAVOR_VCPUS\u003d${MANILA_SERVICE_VM_FLAVOR_VCPUS:-1}"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# Enable this option when using a storage backend that is on the same host"},{"line_number":139,"context_line":"# as the devstack host, these iptable rules are necessary to allow mounting"},{"line_number":140,"context_line":"# shares from the host"},{"line_number":141,"context_line":"MANILA_ALLOW_NAS_SERVER_PORTS_ON_HOST\u003d${MANILA_ALLOW_NAS_SERVER_PORTS_ON_HOST:-False}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"481d577d_1bda1ceb","line":138,"in_reply_to":"712184e9_807ebc2c","updated":"2021-01-15 21:13:13.000000000","message":"suggested default\u0027s incorrect, it should be:\n\n MANILA_ENABLED_BACKENDS\u003d${MANILA_ENABLED_BACKENDS:-generic1,generic2}\n\nto prefer an override when users want.","commit_id":"8f40fa2bc56936322109204d4d7170a55f2921d0"}]}