)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5fdceeb52e04ca97d2bfb3a04cd31f9bbacdd3da","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-11-04 11:02:36 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add all key/values reported by driver to migration get progress view"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I91d455c585ff546cc65e57e8560f126a280eac8d"},{"line_number":10,"context_line":"Closes-Bug: #1902854"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f621f24_44f1136b","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":0},"updated":"2020-11-10 23:40:15.000000000","message":"This change has to be documented in the API Ref, please add: DocImpact in a line by itself so a documentation bug is reported. Alternatively you can add the changes to the APIRef to this patch itself. \n\nA release note is missing as well.","commit_id":"f7fb9ff4d7abf8cc05ba25202e040c67aa04d7af"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ca3298a7211cc84f64595495565fef78b6f6325d","unresolved":false,"context_lines":[{"line_number":1477,"context_line":"  description: |"},{"line_number":1478,"context_line":"    Additional driver specific details of the migration progress."},{"line_number":1479,"context_line":"  in: body"},{"line_number":1480,"context_line":"  required: false"},{"line_number":1481,"context_line":"  type: object"},{"line_number":1482,"context_line":"  min_version: 2.58"},{"line_number":1483,"context_line":"mount_snapshot_support:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f621f24_5d6522b4","line":1480,"range":{"start_line":1480,"start_character":12,"end_line":1480,"end_character":17},"updated":"2020-12-10 20:26:36.000000000","message":"true\n\nWill always be present, and can be null if drivers do not specify any details.","commit_id":"e96926317a11a331e1cd5bd6c07b4ddd6d1bc791"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"613468852adbb4ec5e1dfb4fc5536d1bde93ef59","unresolved":false,"context_lines":[{"line_number":1477,"context_line":"  description: |"},{"line_number":1478,"context_line":"    Additional driver specific details of the migration progress."},{"line_number":1479,"context_line":"  in: body"},{"line_number":1480,"context_line":"  required: false"},{"line_number":1481,"context_line":"  type: object"},{"line_number":1482,"context_line":"  min_version: 2.58"},{"line_number":1483,"context_line":"mount_snapshot_support:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1b6a2ff6_bac4a3b7","line":1480,"range":{"start_line":1480,"start_character":12,"end_line":1480,"end_character":17},"in_reply_to":"1f621f24_5d6522b4","updated":"2020-12-11 08:06:04.000000000","message":"done","commit_id":"e96926317a11a331e1cd5bd6c07b4ddd6d1bc791"}],"manila/api/views/share_migration.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5fdceeb52e04ca97d2bfb3a04cd31f9bbacdd3da","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    def get_progress(self, request, share, progress):"},{"line_number":26,"context_line":"        \"\"\"View of share migration job progress.\"\"\""},{"line_number":27,"context_line":"        result \u003d {"},{"line_number":28,"context_line":"            **progress,"},{"line_number":29,"context_line":"            \u0027task_state\u0027: share[\u0027task_state\u0027],"},{"line_number":30,"context_line":"        }"},{"line_number":31,"context_line":"        self.update_versioned_resource_dict(request, result, progress)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_c4db63ea","line":28,"range":{"start_line":28,"start_character":12,"end_line":28,"end_character":23},"updated":"2020-11-10 23:40:15.000000000","message":"it\u0027s possible that some drivers can send additional data to the get-progress call; but, we tried to design the API by having the common minimum information that all drivers can support. \n\nI think it\u0027s a fine idea presenting whatever driver info to the API consumer because we intend that this API is consumed by a system administrator and there may be no reason to abstract away information from them. However, can we add another JSON body here perhaps?\n\nWe can call the key \"details\", and have a null or {} default for it. \n\nAnother thing to remember is that this API is microversioned - while it is experimental, a change like this can be properly versioned with ease - see an example here: https://review.opendev.org/298115/","commit_id":"f7fb9ff4d7abf8cc05ba25202e040c67aa04d7af"}]}
