)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"a8594d693c05e1d220fac83fc7f0e5b5127b33c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"43969f7e_89da5432","updated":"2022-01-11 12:19:42.000000000","message":"fwiw: this check has become stricter now\n\nold behaviour with a float:\nas_int(1.0) returned 1\n\nnew behaviour\nstrutils.is_int_like(1.0) returns false and I get the error\n\"Share size \u00271.0\u0027 must be an integer and greater than 0\"","commit_id":"2cdcc5cf2bc031a3a3d6af9dc7c1d8dcf092c0d1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ecb031c511d2afd36ae501acfd800f2f8d7f235a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"74ab36ed_919c91bc","in_reply_to":"43969f7e_89da5432","updated":"2022-01-11 19:27:15.000000000","message":":( ouch. Is this going to affect your users? We can revert this if it does..","commit_id":"2cdcc5cf2bc031a3a3d6af9dc7c1d8dcf092c0d1"}],"manila/share/api.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"93edbaa51661565aa41cee3f63e31d6217b9da79","unresolved":true,"context_lines":[{"line_number":171,"context_line":"        else:"},{"line_number":172,"context_line":"            snapshot \u003d None"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        if not strutils.is_int_like(size) or int(size) \u003c\u003d 0:"},{"line_number":175,"context_line":"            msg \u003d (_(\"Share size \u0027%s\u0027 must be an integer and greater than 0\")"},{"line_number":176,"context_line":"                   % size)"},{"line_number":177,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"b5a92608_b68abc21","line":174,"updated":"2021-04-07 11:04:07.000000000","message":"This is simpler and easier to read but isn\u0027t functionally equivalent to the original code.  If the variable size is a string it remains a string and will cause an error at e.g. line 179 when compared with an integer.","commit_id":"c431c5c5e8d506aa381fa534609820b1635d3655"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"ec7ca0ab8503b7a1a69d5b6335bf82cac15b4a2b","unresolved":true,"context_lines":[{"line_number":171,"context_line":"        else:"},{"line_number":172,"context_line":"            snapshot \u003d None"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        if not strutils.is_int_like(size) or int(size) \u003c\u003d 0:"},{"line_number":175,"context_line":"            msg \u003d (_(\"Share size \u0027%s\u0027 must be an integer and greater than 0\")"},{"line_number":176,"context_line":"                   % size)"},{"line_number":177,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"d3ec4dd7_b4f3fc87","line":174,"in_reply_to":"b5a92608_b68abc21","updated":"2021-04-08 01:33:08.000000000","message":"after this check, we know the size must can be convert to int,mybe we should add one line to convert it.","commit_id":"c431c5c5e8d506aa381fa534609820b1635d3655"}]}