)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"c189cd1ba165ae4814ac2f803cb890a97548834c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ddf0a610_cf3e0be0","updated":"2023-09-26 08:18:17.000000000","message":"Shouldn\u0027t this be removed for all api versions?\nIt makes no sense to me that clients could specify an older microversion to still see the password.","commit_id":"3523994f16946d6314ff437bd5b42904def6c431"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9fb20afdae32023fad8f2567aa1a30412dff503e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4f68cce9_4a19e753","in_reply_to":"5cf79daa_d504469d","updated":"2023-09-26 13:48:10.000000000","message":"Hey, Maurice! Yes, I\u0027m with you... The redacting behavior is also compatible with what we have done in the access rules APIs...","commit_id":"3523994f16946d6314ff437bd5b42904def6c431"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"0c2d1f4a28ed6e5f4736597987f2e622403fe6f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5cf79daa_d504469d","in_reply_to":"ddf0a610_cf3e0be0","updated":"2023-09-26 08:19:43.000000000","message":"Maybe to not make a breaking change: keep the key in the older microversion, but redact the value?","commit_id":"3523994f16946d6314ff437bd5b42904def6c431"}],"manila/api/v1/share_servers.py":[{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"a99c33c5d50be3562e17896d224eccc789de409e","unresolved":true,"context_lines":[{"line_number":110,"context_line":"            raise exc.HTTPNotFound(explanation\u003de.msg)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        return self._view_builder.build_share_server_details("},{"line_number":113,"context_line":"            req, share_server[\u0027backend_details\u0027], share_server)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    @wsgi.Controller.authorize"},{"line_number":116,"context_line":"    def delete(self, req, id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"91a7c321_50008130","line":113,"updated":"2020-12-23 18:07:35.000000000","message":"The ``build_share_server_details`` method neither calls or is called by the ``_build_share_server_view`` method, where the versioning method is called. I changed its parameters so that the ``build_share_server_details`` method itself now calls the versioning method.","commit_id":"224bb32b661048506ae5f945fc25233b95382770"}],"manila/api/views/security_service.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"f76b5d0d7600df98fbbdc23cc97a1b0a5eaf4f07","unresolved":true,"context_lines":[{"line_number":49,"context_line":"            }"},{"line_number":50,"context_line":"        }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @common.ViewBuilder.versioned_method(\"2.58\")"},{"line_number":53,"context_line":"    def detail(self, request, security_service):"},{"line_number":54,"context_line":"        \"\"\"Detailed view of a single security service.\"\"\""},{"line_number":55,"context_line":"        view \u003d self.summary(request, security_service)"},{"line_number":56,"context_line":"        keys \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"ebfee05d_765e6259","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":48},"updated":"2020-12-16 13:00:41.000000000","message":"This detail method is already being used in detail_list.\nYou\u0027ll need to create another versioned method that just removes \u0027password\u0027 key.","commit_id":"381a7ae90b51471f67efdb40d13adbced7d8f71f"},{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"7a59c98d9a16138cdd65011336f27110c92472fb","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            }"},{"line_number":50,"context_line":"        }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @common.ViewBuilder.versioned_method(\"2.58\")"},{"line_number":53,"context_line":"    def detail(self, request, security_service):"},{"line_number":54,"context_line":"        \"\"\"Detailed view of a single security service.\"\"\""},{"line_number":55,"context_line":"        view \u003d self.summary(request, security_service)"},{"line_number":56,"context_line":"        keys \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"7c8c82df_ca0acbbb","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":48},"in_reply_to":"ebfee05d_765e6259","updated":"2020-12-23 17:34:49.000000000","message":"Done","commit_id":"381a7ae90b51471f67efdb40d13adbced7d8f71f"}],"manila/api/views/share_servers.py":[{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"a99c33c5d50be3562e17896d224eccc789de409e","unresolved":true,"context_lines":[{"line_number":90,"context_line":"    @common.ViewBuilder.versioned_method(\"2.58\")"},{"line_number":91,"context_line":"    def remove_security_service_password_field("},{"line_number":92,"context_line":"            self, context, share_server_dict, share_server):"},{"line_number":93,"context_line":"        if \u0027backend_details\u0027 in share_server_dict:"},{"line_number":94,"context_line":"            if \u0027security_service_active_directory\u0027 in ("},{"line_number":95,"context_line":"                share_server_dict[\u0027backend_details\u0027]):"},{"line_number":96,"context_line":"                ss_dict \u003d json.loads(share_server_dict[\u0027backend_details\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"0c139eb1_d703c3e7","line":93,"updated":"2020-12-23 18:07:35.000000000","message":"Checks if the dictionary being passed is the complete share server dictionary or the ``[\u0027backend_details\u0027]`` subdictionary.","commit_id":"224bb32b661048506ae5f945fc25233b95382770"}]}