)]}'
{"manila/scheduler/manager.py":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"77c95df3b13565aee5cf6e5c21f3e05fa17bdf93","unresolved":true,"context_lines":[{"line_number":104,"context_line":"        \"\"\"Process a capability update from a service node.\"\"\""},{"line_number":105,"context_line":"        if capabilities is None:"},{"line_number":106,"context_line":"            capabilities \u003d {}"},{"line_number":107,"context_line":"        elif timestamp:"},{"line_number":108,"context_line":"            timestamp \u003d datetime.strptime(timestamp,"},{"line_number":109,"context_line":"                                          timeutils.PERFECT_TIME_FORMAT)"},{"line_number":110,"context_line":"        self.driver.update_service_capabilities(service_name,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5679957b_9c38d79c","line":107,"range":{"start_line":107,"start_character":8,"end_line":107,"end_character":12},"updated":"2021-03-16 01:28:36.000000000","message":"Why we are using *elif*? IMO, \"capabilities\" and \"timstamp\" are not independent of each other.","commit_id":"70bb650e7f09cd5a4731827270358e3285eb2df3"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"21e9bd6949c34ac4811215d96a416d5ea9f201ac","unresolved":true,"context_lines":[{"line_number":104,"context_line":"        \"\"\"Process a capability update from a service node.\"\"\""},{"line_number":105,"context_line":"        if capabilities is None:"},{"line_number":106,"context_line":"            capabilities \u003d {}"},{"line_number":107,"context_line":"        elif timestamp:"},{"line_number":108,"context_line":"            timestamp \u003d datetime.strptime(timestamp,"},{"line_number":109,"context_line":"                                          timeutils.PERFECT_TIME_FORMAT)"},{"line_number":110,"context_line":"        self.driver.update_service_capabilities(service_name,"}],"source_content_type":"text/x-python","patch_set":7,"id":"f9a9b4f1_2249a9d6","line":107,"range":{"start_line":107,"start_character":8,"end_line":107,"end_character":12},"in_reply_to":"32f99c0d_2af34a4e","updated":"2021-03-18 00:55:01.000000000","message":"capabilities and timestamp are the parameters in the interface and default value is None, so *elif* or *if* all ok for this change.","commit_id":"70bb650e7f09cd5a4731827270358e3285eb2df3"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"84eebfdf10b8d907df437f310767cebaa11de683","unresolved":true,"context_lines":[{"line_number":104,"context_line":"        \"\"\"Process a capability update from a service node.\"\"\""},{"line_number":105,"context_line":"        if capabilities is None:"},{"line_number":106,"context_line":"            capabilities \u003d {}"},{"line_number":107,"context_line":"        elif timestamp:"},{"line_number":108,"context_line":"            timestamp \u003d datetime.strptime(timestamp,"},{"line_number":109,"context_line":"                                          timeutils.PERFECT_TIME_FORMAT)"},{"line_number":110,"context_line":"        self.driver.update_service_capabilities(service_name,"}],"source_content_type":"text/x-python","patch_set":7,"id":"32f99c0d_2af34a4e","line":107,"range":{"start_line":107,"start_character":8,"end_line":107,"end_character":12},"in_reply_to":"5679957b_9c38d79c","updated":"2021-03-16 08:19:39.000000000","message":"only capabilities is not none, we need to update timestamp. otherwise we no need to update timestamp.","commit_id":"70bb650e7f09cd5a4731827270358e3285eb2df3"}],"manila/scheduler/rpcapi.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5ce32d67ccf3263608170898651e117a70774b5d","unresolved":true,"context_lines":[{"line_number":65,"context_line":"                                    service_name, host,"},{"line_number":66,"context_line":"                                    capabilities):"},{"line_number":67,"context_line":"        call_context \u003d self.client.prepare(fanout\u003dTrue, version\u003d\u00271.0\u0027)"},{"line_number":68,"context_line":"        timestamp \u003d jsonutils.to_primitive(timeutils.utcnow())"},{"line_number":69,"context_line":"        call_context.cast(context,"},{"line_number":70,"context_line":"                          \u0027update_service_capabilities\u0027,"},{"line_number":71,"context_line":"                          service_name\u003dservice_name,"},{"line_number":72,"context_line":"                          host\u003dhost,"},{"line_number":73,"context_line":"                          capabilities\u003dcapabilities,"},{"line_number":74,"context_line":"                          timestamp\u003dtimestamp)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def get_pools(self, context, filters\u003dNone, cached\u003dFalse):"},{"line_number":77,"context_line":"        call_context \u003d self.client.prepare(version\u003d\u00271.9\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"622675c3_78ff533a","line":74,"range":{"start_line":68,"start_character":8,"end_line":74,"end_character":46},"updated":"2021-03-26 00:11:22.000000000","message":"I missed this during review. This will break upgrades. We\u0027ll need to version this change.","commit_id":"70bb650e7f09cd5a4731827270358e3285eb2df3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a61aac61804a2dff1131e94c5b110f1ff4ac56b1","unresolved":true,"context_lines":[{"line_number":65,"context_line":"                                    service_name, host,"},{"line_number":66,"context_line":"                                    capabilities):"},{"line_number":67,"context_line":"        call_context \u003d self.client.prepare(fanout\u003dTrue, version\u003d\u00271.0\u0027)"},{"line_number":68,"context_line":"        timestamp \u003d jsonutils.to_primitive(timeutils.utcnow())"},{"line_number":69,"context_line":"        call_context.cast(context,"},{"line_number":70,"context_line":"                          \u0027update_service_capabilities\u0027,"},{"line_number":71,"context_line":"                          service_name\u003dservice_name,"},{"line_number":72,"context_line":"                          host\u003dhost,"},{"line_number":73,"context_line":"                          capabilities\u003dcapabilities,"},{"line_number":74,"context_line":"                          timestamp\u003dtimestamp)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def get_pools(self, context, filters\u003dNone, cached\u003dFalse):"},{"line_number":77,"context_line":"        call_context \u003d self.client.prepare(version\u003d\u00271.9\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"a08b8eb6_8581e62e","line":74,"range":{"start_line":68,"start_character":8,"end_line":74,"end_character":46},"in_reply_to":"622675c3_78ff533a","updated":"2021-03-26 00:47:16.000000000","message":"https://review.opendev.org/c/openstack/manila/+/783124","commit_id":"70bb650e7f09cd5a4731827270358e3285eb2df3"}]}