)]}'
{"manila/api/openstack/api_version_request.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"5216af6591d223542e8ed22e2313f74cbf48d875","unresolved":true,"context_lines":[{"line_number":160,"context_line":"             view."},{"line_number":161,"context_line":"    * 2.59 - Add driver ``details`` field to migration get progress."},{"line_number":162,"context_line":"    * 2.60 - API URLs no longer need to include a project_id parameter."},{"line_number":163,"context_line":"    * 2.61 - Add ``per_share_size_limit`` configuation option."},{"line_number":164,"context_line":"\"\"\""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":3,"id":"48f6ec55_e051d8b8","line":163,"range":{"start_line":163,"start_character":42,"end_line":163,"end_character":54},"updated":"2021-03-07 22:39:49.000000000","message":"\u0027configuration\u0027\nPerhaps: Added \u0027per_share_size_limit\u0027 quota class configuration.","commit_id":"b1498c005d46b41436463990072e3ea8fe867956"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c3ddd0fe98e53de0ab85f677630967e4624f952a","unresolved":false,"context_lines":[{"line_number":160,"context_line":"             view."},{"line_number":161,"context_line":"    * 2.59 - Add driver ``details`` field to migration get progress."},{"line_number":162,"context_line":"    * 2.60 - API URLs no longer need to include a project_id parameter."},{"line_number":163,"context_line":"    * 2.61 - Add ``per_share_size_limit`` configuation option."},{"line_number":164,"context_line":"\"\"\""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":3,"id":"15303d19_88e5dded","line":163,"range":{"start_line":163,"start_character":42,"end_line":163,"end_character":54},"in_reply_to":"48f6ec55_e051d8b8","updated":"2021-03-08 09:28:27.000000000","message":"Done","commit_id":"b1498c005d46b41436463990072e3ea8fe867956"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"7ea213bada4b7e891a17d00cf04aecdd5c1a7ba2","unresolved":true,"context_lines":[{"line_number":167,"context_line":"# The default api version request is defined to be the"},{"line_number":168,"context_line":"# minimum version of the API supported."},{"line_number":169,"context_line":"_MIN_API_VERSION \u003d \"2.0\""},{"line_number":170,"context_line":"_MAX_API_VERSION \u003d \"2.61\""},{"line_number":171,"context_line":"DEFAULT_API_VERSION \u003d _MIN_API_VERSION"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7006b7b1_2edf22f6","line":170,"range":{"start_line":170,"start_character":19,"end_line":170,"end_character":25},"updated":"2021-03-07 23:02:06.000000000","message":"You have a microversion conflict since [1] got merged. Please, update to 2.62.\n[1] https://review.opendev.org/c/openstack/manila/+/765975","commit_id":"b1498c005d46b41436463990072e3ea8fe867956"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c3ddd0fe98e53de0ab85f677630967e4624f952a","unresolved":false,"context_lines":[{"line_number":167,"context_line":"# The default api version request is defined to be the"},{"line_number":168,"context_line":"# minimum version of the API supported."},{"line_number":169,"context_line":"_MIN_API_VERSION \u003d \"2.0\""},{"line_number":170,"context_line":"_MAX_API_VERSION \u003d \"2.61\""},{"line_number":171,"context_line":"DEFAULT_API_VERSION \u003d _MIN_API_VERSION"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"a90ceddd_dd0fd261","line":170,"range":{"start_line":170,"start_character":19,"end_line":170,"end_character":25},"in_reply_to":"7006b7b1_2edf22f6","updated":"2021-03-08 09:28:27.000000000","message":"Done","commit_id":"b1498c005d46b41436463990072e3ea8fe867956"}],"manila/api/v2/quota_sets.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"f3a8b59a723a8a458fa57096ca5bf38fce91be19","unresolved":true,"context_lines":[{"line_number":329,"context_line":"        elif req.api_version_request \u003c api_version.APIVersionRequest(\"2.53\"):"},{"line_number":330,"context_line":"            self._ensure_specific_microversion_args_are_absent("},{"line_number":331,"context_line":"                body, [\u0027share_replicas\u0027, \u0027replica_gigabytes\u0027], \"2.53\")"},{"line_number":332,"context_line":"        elif req.api_version_request \u003c api_version.APIVersionRequest(\"2.61\"):"},{"line_number":333,"context_line":"            self._ensure_specific_microversion_args_are_absent("},{"line_number":334,"context_line":"                body, [\u0027per_share_gigabytes\u0027], \"2.62\")"},{"line_number":335,"context_line":"        return self._update(req, id, body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7eaa1b_dab907d3","line":332,"range":{"start_line":332,"start_character":70,"end_line":332,"end_character":74},"updated":"2021-03-09 06:56:54.000000000","message":"2.62","commit_id":"622dda08708b7477fbba06c4f2e42db3eaafb7db"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"8e80077f456b0b1197ec08232a89463f647e99e4","unresolved":false,"context_lines":[{"line_number":329,"context_line":"        elif req.api_version_request \u003c api_version.APIVersionRequest(\"2.53\"):"},{"line_number":330,"context_line":"            self._ensure_specific_microversion_args_are_absent("},{"line_number":331,"context_line":"                body, [\u0027share_replicas\u0027, \u0027replica_gigabytes\u0027], \"2.53\")"},{"line_number":332,"context_line":"        elif req.api_version_request \u003c api_version.APIVersionRequest(\"2.61\"):"},{"line_number":333,"context_line":"            self._ensure_specific_microversion_args_are_absent("},{"line_number":334,"context_line":"                body, [\u0027per_share_gigabytes\u0027], \"2.62\")"},{"line_number":335,"context_line":"        return self._update(req, id, body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"163036bd_b61e5261","line":332,"range":{"start_line":332,"start_character":70,"end_line":332,"end_character":74},"in_reply_to":"3a7eaa1b_dab907d3","updated":"2021-03-09 11:37:02.000000000","message":"Done","commit_id":"622dda08708b7477fbba06c4f2e42db3eaafb7db"}],"manila/api/views/quota_class_sets.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c02af2f023e48440e5e9514c81334425520f2281","unresolved":true,"context_lines":[{"line_number":32,"context_line":"            \u0027snapshots\u0027,"},{"line_number":33,"context_line":"            \u0027snapshot_gigabytes\u0027,"},{"line_number":34,"context_line":"            \u0027share_networks\u0027,"},{"line_number":35,"context_line":"            \u0027per_share_gigabytes\u0027,"},{"line_number":36,"context_line":"        )"},{"line_number":37,"context_line":"        view \u003d {key: quota_class_set.get(key) for key in keys}"},{"line_number":38,"context_line":"        if quota_class:"}],"source_content_type":"text/x-python","patch_set":2,"id":"a3197a95_26f38aac","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":34},"updated":"2021-02-11 06:59:06.000000000","message":"You\u0027ll need to microversion this change. Here\u0027s an example of how that\u0027s done: https://review.opendev.org/c/openstack/manila/+/755666\n\nConsumers of the manila API at a particular microversion are given the contract that the API schema/behavior will not change, and all new changes will come with a new microversion. So, when you add a microversion around this change, you will also need to add unit test cases to ascertain that the previous behavior is maintained, and that the schema change that you\u0027re introducing is only made in the newer microversion. The theory of microversions is here: https://docs.openstack.org/manila/latest/contributor/api_microversion_dev.html","commit_id":"fe5ec1f5d7c2a25b7eadafb158dd32d50138279e"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"50e2fc446d6cf283ebf402d8c97f11803c2a4747","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            \u0027snapshots\u0027,"},{"line_number":33,"context_line":"            \u0027snapshot_gigabytes\u0027,"},{"line_number":34,"context_line":"            \u0027share_networks\u0027,"},{"line_number":35,"context_line":"            \u0027per_share_gigabytes\u0027,"},{"line_number":36,"context_line":"        )"},{"line_number":37,"context_line":"        view \u003d {key: quota_class_set.get(key) for key in keys}"},{"line_number":38,"context_line":"        if quota_class:"}],"source_content_type":"text/x-python","patch_set":2,"id":"b3dfce0e_4faae02f","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":34},"in_reply_to":"a3197a95_26f38aac","updated":"2021-02-12 08:45:00.000000000","message":"Done","commit_id":"fe5ec1f5d7c2a25b7eadafb158dd32d50138279e"}],"manila/db/migrations/alembic/versions/0c23aec99b74_add_per_share_gigabytes_quota_class.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"075bbc15004e0866445a43d8da73852408d5acb7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1a22452a_128b72da","updated":"2021-03-12 00:04:49.000000000","message":"This is a bit of an overkill - we don\u0027t need all the quotas in the database, just the ones the administrators have explicitly overridden. However, we should make note of this one in the release notes.","commit_id":"00452939426d36bf7e5c91f8067743780bc179f6"}],"manila/share/api.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"593a0a18fba37a1532a402634f60111f4d4b63ea","unresolved":true,"context_lines":[{"line_number":233,"context_line":"                         supported\u003dCONF.enabled_share_protocols))"},{"line_number":234,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        try:"},{"line_number":237,"context_line":"            values \u003d {\u0027per_share_gigabytes\u0027: size}"},{"line_number":238,"context_line":"            QUOTAS.limit_check(context, project_id\u003dcontext.project_id,"},{"line_number":239,"context_line":"                               **values)"},{"line_number":240,"context_line":"        except exception.OverQuota as e:"},{"line_number":241,"context_line":"            quotas \u003d e.kwargs[\u0027quotas\u0027]"},{"line_number":242,"context_line":"            raise exception.ShareSizeExceedsLimit("},{"line_number":243,"context_line":"                size\u003dsize, limit\u003dquotas[\u0027per_share_gigabytes\u0027])"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        deltas \u003d {\u0027shares\u0027: 1, \u0027gigabytes\u0027: size}"},{"line_number":246,"context_line":"        share_type_attributes \u003d self.get_share_attributes_from_share_type("}],"source_content_type":"text/x-python","patch_set":3,"id":"d5bf9ac3_f83d113e","line":243,"range":{"start_line":236,"start_character":8,"end_line":243,"end_character":63},"updated":"2021-03-07 14:39:54.000000000","message":"This should be checked during share extension as well, right?","commit_id":"b1498c005d46b41436463990072e3ea8fe867956"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"5216af6591d223542e8ed22e2313f74cbf48d875","unresolved":true,"context_lines":[{"line_number":2073,"context_line":"    def get_share_network(self, context, share_net_id):"},{"line_number":2074,"context_line":"        return self.db.share_network_get(context, share_net_id)"},{"line_number":2075,"context_line":""},{"line_number":2076,"context_line":"    def extend(self, context, share, new_size):"},{"line_number":2077,"context_line":"        policy.check_policy(context, \u0027share\u0027, \u0027extend\u0027)"},{"line_number":2078,"context_line":""},{"line_number":2079,"context_line":"        if share[\u0027status\u0027] !\u003d constants.STATUS_AVAILABLE:"}],"source_content_type":"text/x-python","patch_set":3,"id":"df309ebc_98d75525","line":2076,"range":{"start_line":2076,"start_character":8,"end_line":2076,"end_character":14},"updated":"2021-03-07 22:39:49.000000000","message":"As Carlos mentioned, you also need to check limits here.","commit_id":"b1498c005d46b41436463990072e3ea8fe867956"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c3ddd0fe98e53de0ab85f677630967e4624f952a","unresolved":false,"context_lines":[{"line_number":2073,"context_line":"    def get_share_network(self, context, share_net_id):"},{"line_number":2074,"context_line":"        return self.db.share_network_get(context, share_net_id)"},{"line_number":2075,"context_line":""},{"line_number":2076,"context_line":"    def extend(self, context, share, new_size):"},{"line_number":2077,"context_line":"        policy.check_policy(context, \u0027share\u0027, \u0027extend\u0027)"},{"line_number":2078,"context_line":""},{"line_number":2079,"context_line":"        if share[\u0027status\u0027] !\u003d constants.STATUS_AVAILABLE:"}],"source_content_type":"text/x-python","patch_set":3,"id":"219811b7_35056128","line":2076,"range":{"start_line":2076,"start_character":8,"end_line":2076,"end_character":14},"in_reply_to":"df309ebc_98d75525","updated":"2021-03-08 09:28:27.000000000","message":"Done","commit_id":"b1498c005d46b41436463990072e3ea8fe867956"}],"manila/share/manager.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"5216af6591d223542e8ed22e2313f74cbf48d875","unresolved":true,"context_lines":[{"line_number":2588,"context_line":"                    or {}"},{"line_number":2589,"context_line":"                )"},{"line_number":2590,"context_line":""},{"line_number":2591,"context_line":"            if not share_update.get(\u0027size\u0027):"},{"line_number":2592,"context_line":"                msg \u003d _(\"Driver cannot calculate share size.\")"},{"line_number":2593,"context_line":"                raise exception.InvalidShare(reason\u003dmsg)"},{"line_number":2594,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"a33e2ec9_0bbb469c","line":2591,"updated":"2021-03-07 22:39:49.000000000","message":"Shouldn\u0027t you check here too? based on the provided \u0027size\u0027","commit_id":"b1498c005d46b41436463990072e3ea8fe867956"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"30240a7fd2f2ed695b7525108b20ed4508131d5b","unresolved":true,"context_lines":[{"line_number":2588,"context_line":"                    or {}"},{"line_number":2589,"context_line":"                )"},{"line_number":2590,"context_line":""},{"line_number":2591,"context_line":"            if not share_update.get(\u0027size\u0027):"},{"line_number":2592,"context_line":"                msg \u003d _(\"Driver cannot calculate share size.\")"},{"line_number":2593,"context_line":"                raise exception.InvalidShare(reason\u003dmsg)"},{"line_number":2594,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"e4e21226_fc1b7699","line":2591,"in_reply_to":"a2919ea5_bc8b65de","updated":"2021-03-08 11:22:05.000000000","message":"Yes, seems to be a similar scenario. You still could check these limits and instead of raising an error, log a warning message saying that the managed share is over the limit for this project. Consider adding this if you provide a new PS. Thanks","commit_id":"b1498c005d46b41436463990072e3ea8fe867956"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c3ddd0fe98e53de0ab85f677630967e4624f952a","unresolved":true,"context_lines":[{"line_number":2588,"context_line":"                    or {}"},{"line_number":2589,"context_line":"                )"},{"line_number":2590,"context_line":""},{"line_number":2591,"context_line":"            if not share_update.get(\u0027size\u0027):"},{"line_number":2592,"context_line":"                msg \u003d _(\"Driver cannot calculate share size.\")"},{"line_number":2593,"context_line":"                raise exception.InvalidShare(reason\u003dmsg)"},{"line_number":2594,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"a2919ea5_bc8b65de","line":2591,"in_reply_to":"a33e2ec9_0bbb469c","updated":"2021-03-08 09:28:27.000000000","message":"We allow OverQuota in manage_share() because of bug 1863298. So I don\u0027t think check needed here. Opinion ?","commit_id":"b1498c005d46b41436463990072e3ea8fe867956"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"8e80077f456b0b1197ec08232a89463f647e99e4","unresolved":false,"context_lines":[{"line_number":2588,"context_line":"                    or {}"},{"line_number":2589,"context_line":"                )"},{"line_number":2590,"context_line":""},{"line_number":2591,"context_line":"            if not share_update.get(\u0027size\u0027):"},{"line_number":2592,"context_line":"                msg \u003d _(\"Driver cannot calculate share size.\")"},{"line_number":2593,"context_line":"                raise exception.InvalidShare(reason\u003dmsg)"},{"line_number":2594,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"f2d627be_bcde73be","line":2591,"in_reply_to":"e4e21226_fc1b7699","updated":"2021-03-09 11:37:02.000000000","message":"Done","commit_id":"b1498c005d46b41436463990072e3ea8fe867956"}],"manila/tests/api/v2/test_quota_class_sets.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a075be388b3bd11aa149e19d08db06b5755bbafc","unresolved":true,"context_lines":[{"line_number":88,"context_line":"        }"},{"line_number":89,"context_line":"        for k, v in quotas.items():"},{"line_number":90,"context_line":"            if k \u003d\u003d \u0027per_share_gigabytes\u0027:"},{"line_number":91,"context_line":"                CONF.set_default("},{"line_number":92,"context_line":"                    \u0027per_share_size_limit\u0027, quotas[\u0027per_share_gigabytes\u0027])"},{"line_number":93,"context_line":"            else:"},{"line_number":94,"context_line":"                CONF.set_default(\u0027quota_\u0027 + k, v)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fd3ccafd_214f9986","line":91,"range":{"start_line":91,"start_character":16,"end_line":91,"end_character":1},"updated":"2021-03-08 03:05:36.000000000","message":"CONF.set_default(k, v)","commit_id":"b1498c005d46b41436463990072e3ea8fe867956"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c3ddd0fe98e53de0ab85f677630967e4624f952a","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        }"},{"line_number":89,"context_line":"        for k, v in quotas.items():"},{"line_number":90,"context_line":"            if k \u003d\u003d \u0027per_share_gigabytes\u0027:"},{"line_number":91,"context_line":"                CONF.set_default("},{"line_number":92,"context_line":"                    \u0027per_share_size_limit\u0027, quotas[\u0027per_share_gigabytes\u0027])"},{"line_number":93,"context_line":"            else:"},{"line_number":94,"context_line":"                CONF.set_default(\u0027quota_\u0027 + k, v)"}],"source_content_type":"text/x-python","patch_set":3,"id":"f1469a8e_05e52c29","line":91,"range":{"start_line":91,"start_character":16,"end_line":91,"end_character":1},"in_reply_to":"fd3ccafd_214f9986","updated":"2021-03-08 09:28:27.000000000","message":"Done","commit_id":"b1498c005d46b41436463990072e3ea8fe867956"}],"manila/tests/api/v2/test_quota_sets.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a075be388b3bd11aa149e19d08db06b5755bbafc","unresolved":true,"context_lines":[{"line_number":82,"context_line":"        for k, v in quotas.items():"},{"line_number":83,"context_line":"            if k \u003d\u003d \u0027per_share_gigabytes\u0027:"},{"line_number":84,"context_line":"                CONF.set_default("},{"line_number":85,"context_line":"                    \u0027per_share_size_limit\u0027, quotas[\u0027per_share_gigabytes\u0027])"},{"line_number":86,"context_line":"            else:"},{"line_number":87,"context_line":"                CONF.set_default(\u0027quota_\u0027 + k, v)"},{"line_number":88,"context_line":"        expected \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"0d44ed00_a120446a","line":85,"range":{"start_line":85,"start_character":20,"end_line":85,"end_character":73},"updated":"2021-03-08 03:05:36.000000000","message":"k, v","commit_id":"b1498c005d46b41436463990072e3ea8fe867956"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a075be388b3bd11aa149e19d08db06b5755bbafc","unresolved":true,"context_lines":[{"line_number":180,"context_line":"        for k, v in quotas.items():"},{"line_number":181,"context_line":"            if k \u003d\u003d \u0027per_share_gigabytes\u0027:"},{"line_number":182,"context_line":"                CONF.set_default("},{"line_number":183,"context_line":"                    \u0027per_share_size_limit\u0027, quotas[\u0027per_share_gigabytes\u0027])"},{"line_number":184,"context_line":"            else:"},{"line_number":185,"context_line":"                CONF.set_default(\u0027quota_\u0027 + k, v)"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"986c646f_52285e81","line":183,"range":{"start_line":183,"start_character":20,"end_line":183,"end_character":73},"updated":"2021-03-08 03:05:36.000000000","message":"k, v","commit_id":"b1498c005d46b41436463990072e3ea8fe867956"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a075be388b3bd11aa149e19d08db06b5755bbafc","unresolved":true,"context_lines":[{"line_number":216,"context_line":"        for k, v in quotas.items():"},{"line_number":217,"context_line":"            if k \u003d\u003d \u0027per_share_gigabytes\u0027:"},{"line_number":218,"context_line":"                CONF.set_default("},{"line_number":219,"context_line":"                    \u0027per_share_size_limit\u0027, quotas[\u0027per_share_gigabytes\u0027])"},{"line_number":220,"context_line":"            else:"},{"line_number":221,"context_line":"                CONF.set_default(\u0027quota_\u0027 + k, v)"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"c4b4698c_68ff2e00","line":219,"range":{"start_line":219,"start_character":20,"end_line":219,"end_character":73},"updated":"2021-03-08 03:05:36.000000000","message":"same, and other place,","commit_id":"b1498c005d46b41436463990072e3ea8fe867956"}],"manila/tests/share/test_api.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a075be388b3bd11aa149e19d08db06b5755bbafc","unresolved":true,"context_lines":[{"line_number":865,"context_line":"    @ddt.data({\u0027overs\u0027: {\u0027per_share_gigabytes\u0027: \u0027fake\u0027},"},{"line_number":866,"context_line":"               \u0027expected_exception\u0027: exception.ShareSizeExceedsLimit})"},{"line_number":867,"context_line":"    @ddt.unpack"},{"line_number":868,"context_line":"    def test_create_share_over_per_share_size_limit(self, overs,"},{"line_number":869,"context_line":"                                                    expected_exception):"},{"line_number":870,"context_line":"        share, share_data \u003d self._setup_create_mocks()"},{"line_number":871,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"79fd36c0_c7fe5371","line":868,"range":{"start_line":868,"start_character":8,"end_line":868,"end_character":51},"updated":"2021-03-08 03:05:36.000000000","message":"if we also check at extend, here we should add an test to check extend share over per_share_size_limit.","commit_id":"b1498c005d46b41436463990072e3ea8fe867956"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c3ddd0fe98e53de0ab85f677630967e4624f952a","unresolved":false,"context_lines":[{"line_number":865,"context_line":"    @ddt.data({\u0027overs\u0027: {\u0027per_share_gigabytes\u0027: \u0027fake\u0027},"},{"line_number":866,"context_line":"               \u0027expected_exception\u0027: exception.ShareSizeExceedsLimit})"},{"line_number":867,"context_line":"    @ddt.unpack"},{"line_number":868,"context_line":"    def test_create_share_over_per_share_size_limit(self, overs,"},{"line_number":869,"context_line":"                                                    expected_exception):"},{"line_number":870,"context_line":"        share, share_data \u003d self._setup_create_mocks()"},{"line_number":871,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"2fd7f3c5_25a72448","line":868,"range":{"start_line":868,"start_character":8,"end_line":868,"end_character":51},"in_reply_to":"79fd36c0_c7fe5371","updated":"2021-03-08 09:28:27.000000000","message":"Added test for extend as well","commit_id":"b1498c005d46b41436463990072e3ea8fe867956"}]}