)]}'
{"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"90c03bf8a6e3782922b3ec80b0200e7bc943b0a0","unresolved":true,"context_lines":[{"line_number":1607,"context_line":"    def modify_ldap(self, new_security_service, current_security_service):"},{"line_number":1608,"context_line":"        \"\"\"Modifies LDAP client on a Vserver.\"\"\""},{"line_number":1609,"context_line":"        # Create a new ldap client"},{"line_number":1610,"context_line":"        self._create_ldap_client(new_security_service)"},{"line_number":1611,"context_line":""},{"line_number":1612,"context_line":"        # Delete current ldap config"},{"line_number":1613,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"db033771_e56fc838","line":1610,"range":{"start_line":1610,"start_character":0,"end_line":1610,"end_character":54},"updated":"2021-03-17 02:57:57.000000000","message":"Couple of issues here:\n\n- Shouldn\u0027t you do this only after the older client is detached from the vserver? An error on line 1614 can leave an orphaned ldap client\n- retrying the security service update can error out here since _create_ldap_client isn\u0027t idempotent.","commit_id":"ff91db3ecec454ff569187084ec04e45dff7fb21"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"4dee21fc4cbef1155290a502d28452dcfa05bf87","unresolved":true,"context_lines":[{"line_number":1607,"context_line":"    def modify_ldap(self, new_security_service, current_security_service):"},{"line_number":1608,"context_line":"        \"\"\"Modifies LDAP client on a Vserver.\"\"\""},{"line_number":1609,"context_line":"        # Create a new ldap client"},{"line_number":1610,"context_line":"        self._create_ldap_client(new_security_service)"},{"line_number":1611,"context_line":""},{"line_number":1612,"context_line":"        # Delete current ldap config"},{"line_number":1613,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"2d618406_67bff6f0","line":1610,"range":{"start_line":1610,"start_character":0,"end_line":1610,"end_character":54},"in_reply_to":"db033771_e56fc838","updated":"2021-03-25 21:09:01.000000000","message":"In ONTAP, we can create as many ldap client configs as needed, but only one can be active in the SVM (\u0027ldap-config-create\u0027 call). The decision for always creating the new ldap configuration first is because it is the operation that has more chance to fail, since user may provide a invalid IP/Server/User/Password parameter in the new security service.\nIt is very unlikely to happen an error different from OBJECTNOTFOUND in \u0027ldap-client-delete\u0027 operation, so I preffer to add a \u0027_delete_ldap_client(new_security_service) in its rollback to delete the previously created config.\nIf we do invert these operations, we\u0027ll need to also revert the \u0027ldap-config-delete\u0027 operation in the rollbacks.","commit_id":"ff91db3ecec454ff569187084ec04e45dff7fb21"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"90c03bf8a6e3782922b3ec80b0200e7bc943b0a0","unresolved":true,"context_lines":[{"line_number":1632,"context_line":"        try:"},{"line_number":1633,"context_line":"            self._delete_ldap_client(current_security_service)"},{"line_number":1634,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":1635,"context_line":"            if e.code !\u003d netapp_api.EOBJECTNOTFOUND:"},{"line_number":1636,"context_line":"                msg \u003d _(\"An error occurred while deleting original LDAP \""},{"line_number":1637,"context_line":"                        \"client configuration. %s\")"},{"line_number":1638,"context_line":"                raise exception.NetAppException(msg % e.message)"},{"line_number":1639,"context_line":"            else:"},{"line_number":1640,"context_line":"                msg \u003d _(\"Original LDAP client configuration was not found.\")"},{"line_number":1641,"context_line":"                LOG.debug(msg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacd63cf_d53febee","line":1638,"range":{"start_line":1635,"start_character":52,"end_line":1638,"end_character":64},"updated":"2021-03-17 02:57:57.000000000","message":"Do we care?\nCan\u0027t this just be logged for an administrator to clean up?","commit_id":"ff91db3ecec454ff569187084ec04e45dff7fb21"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"4dee21fc4cbef1155290a502d28452dcfa05bf87","unresolved":true,"context_lines":[{"line_number":1632,"context_line":"        try:"},{"line_number":1633,"context_line":"            self._delete_ldap_client(current_security_service)"},{"line_number":1634,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":1635,"context_line":"            if e.code !\u003d netapp_api.EOBJECTNOTFOUND:"},{"line_number":1636,"context_line":"                msg \u003d _(\"An error occurred while deleting original LDAP \""},{"line_number":1637,"context_line":"                        \"client configuration. %s\")"},{"line_number":1638,"context_line":"                raise exception.NetAppException(msg % e.message)"},{"line_number":1639,"context_line":"            else:"},{"line_number":1640,"context_line":"                msg \u003d _(\"Original LDAP client configuration was not found.\")"},{"line_number":1641,"context_line":"                LOG.debug(msg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fd5969cd_99670c2b","line":1638,"range":{"start_line":1635,"start_character":52,"end_line":1638,"end_character":64},"in_reply_to":"bacd63cf_d53febee","updated":"2021-03-25 21:09:01.000000000","message":"You are right, we can just log a warning, since a ldap config cleanup may be needed.","commit_id":"ff91db3ecec454ff569187084ec04e45dff7fb21"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"90c03bf8a6e3782922b3ec80b0200e7bc943b0a0","unresolved":true,"context_lines":[{"line_number":1425,"context_line":"                current_security_service\u003dcurrent_security_service):"},{"line_number":1426,"context_line":"            msg \u003d _(\"The requested security service update is not supported \""},{"line_number":1427,"context_line":"                    \"by the NetApp driver.\")"},{"line_number":1428,"context_line":"            LOG.exception(msg)"},{"line_number":1429,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":1430,"context_line":""},{"line_number":1431,"context_line":"        if current_security_service is None:"}],"source_content_type":"text/x-python","patch_set":7,"id":"c05d51b7_6f57caee","line":1428,"range":{"start_line":1428,"start_character":16,"end_line":1428,"end_character":25},"updated":"2021-03-17 02:57:57.000000000","message":"error","commit_id":"ff91db3ecec454ff569187084ec04e45dff7fb21"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"4dee21fc4cbef1155290a502d28452dcfa05bf87","unresolved":false,"context_lines":[{"line_number":1425,"context_line":"                current_security_service\u003dcurrent_security_service):"},{"line_number":1426,"context_line":"            msg \u003d _(\"The requested security service update is not supported \""},{"line_number":1427,"context_line":"                    \"by the NetApp driver.\")"},{"line_number":1428,"context_line":"            LOG.exception(msg)"},{"line_number":1429,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":1430,"context_line":""},{"line_number":1431,"context_line":"        if current_security_service is None:"}],"source_content_type":"text/x-python","patch_set":7,"id":"f139834c_88be07b2","line":1428,"range":{"start_line":1428,"start_character":16,"end_line":1428,"end_character":25},"in_reply_to":"c05d51b7_6f57caee","updated":"2021-03-25 21:09:01.000000000","message":"Done","commit_id":"ff91db3ecec454ff569187084ec04e45dff7fb21"}],"releasenotes/notes/netapp-add-security-service-update-718a68ebe60fd2b5.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"90c03bf8a6e3782922b3ec80b0200e7bc943b0a0","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    they are associated with in use share networks. Both add and update"},{"line_number":6,"context_line":"    operations are supported by all three security service types:"},{"line_number":7,"context_line":"    ``active_directory``, ``kerberos`` and ``ldap``. In order to update their"},{"line_number":8,"context_line":"    parameters in a non-disruptively way, ``active_directory`` and ``kerberos``"},{"line_number":9,"context_line":"    don\u0027t support ``domain`` updates."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"da409b94_d46821d9","line":8,"range":{"start_line":8,"start_character":24,"end_line":8,"end_character":36},"updated":"2021-03-17 02:57:57.000000000","message":"nit: disruptive","commit_id":"ff91db3ecec454ff569187084ec04e45dff7fb21"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"4dee21fc4cbef1155290a502d28452dcfa05bf87","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    they are associated with in use share networks. Both add and update"},{"line_number":6,"context_line":"    operations are supported by all three security service types:"},{"line_number":7,"context_line":"    ``active_directory``, ``kerberos`` and ``ldap``. In order to update their"},{"line_number":8,"context_line":"    parameters in a non-disruptively way, ``active_directory`` and ``kerberos``"},{"line_number":9,"context_line":"    don\u0027t support ``domain`` updates."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1a377435_d0a911a5","line":8,"range":{"start_line":8,"start_character":24,"end_line":8,"end_character":36},"in_reply_to":"da409b94_d46821d9","updated":"2021-03-25 21:09:01.000000000","message":"Done","commit_id":"ff91db3ecec454ff569187084ec04e45dff7fb21"}]}