)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"eace458b7a56d92ec5ba196423cd456b8dce504a","unresolved":true,"context_lines":[{"line_number":12,"context_line":"share protocol from given driver. Raise invalid request exception if"},{"line_number":13,"context_line":"needed association between share_network and security_service is"},{"line_number":14,"context_line":"missing for given driver e.g. ONTAP."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1900752"},{"line_number":17,"context_line":"Change-Id: Ib7e9850e6439ee5d04f826d129afb1ab06950ce7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"d45303c3_4c287664","line":15,"updated":"2021-06-10 17:05:36.000000000","message":"Could you please add DocImpact to the commit message?","commit_id":"0b57cc244ad75940c63287bce61f57e68b544af6"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"5b86ad782e620f797630e3ce8c32b9035856e6a3","unresolved":false,"context_lines":[{"line_number":12,"context_line":"share protocol from given driver. Raise invalid request exception if"},{"line_number":13,"context_line":"needed association between share_network and security_service is"},{"line_number":14,"context_line":"missing for given driver e.g. ONTAP."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1900752"},{"line_number":17,"context_line":"Change-Id: Ib7e9850e6439ee5d04f826d129afb1ab06950ce7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"c9229117_2942fca8","line":15,"in_reply_to":"d45303c3_4c287664","updated":"2021-06-14 10:27:22.000000000","message":"Done","commit_id":"0b57cc244ad75940c63287bce61f57e68b544af6"}],"manila/message/message_field.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"db6bcebe5ff82a64db9dd5fbdb0db854fe37dcc1","unresolved":true,"context_lines":[{"line_number":128,"context_line":"          \"user, password, ou and domain.\"))"},{"line_number":129,"context_line":"    MISSING_SECURITY_SERVICE \u003d ("},{"line_number":130,"context_line":"        \u0027024\u0027,"},{"line_number":131,"context_line":"        _(\"Share Driver failed to create share due to a security service \""},{"line_number":132,"context_line":"          \"is missing the association with the used share network. Please\""},{"line_number":133,"context_line":"          \"add security service to the share network.\"))"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    ALL \u003d ("}],"source_content_type":"text/x-python","patch_set":7,"id":"d6b41066_4fc954e9","line":132,"range":{"start_line":131,"start_character":47,"end_line":132,"end_character":65},"updated":"2021-07-14 00:31:02.000000000","message":"because a security service has not been added to the share network used","commit_id":"c0c5e9ca6a42431e4453b1d35d104ca23daf1a05"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c45d3eaca4eea79e530db75623f14affe60f0afb","unresolved":false,"context_lines":[{"line_number":128,"context_line":"          \"user, password, ou and domain.\"))"},{"line_number":129,"context_line":"    MISSING_SECURITY_SERVICE \u003d ("},{"line_number":130,"context_line":"        \u0027024\u0027,"},{"line_number":131,"context_line":"        _(\"Share Driver failed to create share due to a security service \""},{"line_number":132,"context_line":"          \"is missing the association with the used share network. Please\""},{"line_number":133,"context_line":"          \"add security service to the share network.\"))"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    ALL \u003d ("}],"source_content_type":"text/x-python","patch_set":7,"id":"f191ad4d_0a0d1982","line":132,"range":{"start_line":131,"start_character":47,"end_line":132,"end_character":65},"in_reply_to":"d6b41066_4fc954e9","updated":"2021-07-14 07:39:45.000000000","message":"Done","commit_id":"c0c5e9ca6a42431e4453b1d35d104ca23daf1a05"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"db6bcebe5ff82a64db9dd5fbdb0db854fe37dcc1","unresolved":true,"context_lines":[{"line_number":130,"context_line":"        \u0027024\u0027,"},{"line_number":131,"context_line":"        _(\"Share Driver failed to create share due to a security service \""},{"line_number":132,"context_line":"          \"is missing the association with the used share network. Please\""},{"line_number":133,"context_line":"          \"add security service to the share network.\"))"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    ALL \u003d ("},{"line_number":136,"context_line":"        UNKNOWN_ERROR,"}],"source_content_type":"text/x-python","patch_set":7,"id":"cfbb7e08_b2713f12","line":133,"range":{"start_line":133,"start_character":14,"end_line":133,"end_character":15},"updated":"2021-07-14 00:31:02.000000000","message":"a","commit_id":"c0c5e9ca6a42431e4453b1d35d104ca23daf1a05"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c45d3eaca4eea79e530db75623f14affe60f0afb","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        \u0027024\u0027,"},{"line_number":131,"context_line":"        _(\"Share Driver failed to create share due to a security service \""},{"line_number":132,"context_line":"          \"is missing the association with the used share network. Please\""},{"line_number":133,"context_line":"          \"add security service to the share network.\"))"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    ALL \u003d ("},{"line_number":136,"context_line":"        UNKNOWN_ERROR,"}],"source_content_type":"text/x-python","patch_set":7,"id":"d0d6ffef_f03f9d4e","line":133,"range":{"start_line":133,"start_character":14,"end_line":133,"end_character":15},"in_reply_to":"cfbb7e08_b2713f12","updated":"2021-07-14 07:39:45.000000000","message":"Done","commit_id":"c0c5e9ca6a42431e4453b1d35d104ca23daf1a05"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"483263afb40c31657bdd940888f29367e6717582","unresolved":true,"context_lines":[{"line_number":126,"context_line":"          \"authentication issue. The security service user has either \""},{"line_number":127,"context_line":"          \"insufficient privileges or wrong credentials. Please check your \""},{"line_number":128,"context_line":"          \"user, password, ou and domain.\"))"},{"line_number":129,"context_line":"    MISSING_SECURITY_SERVICE \u003d ("},{"line_number":130,"context_line":"        \u0027024\u0027,"},{"line_number":131,"context_line":"        _(\"Share Driver failed to create share because a security service \""},{"line_number":132,"context_line":"          \"has not been added to the share network used. Please add a \""},{"line_number":133,"context_line":"          \"security service to the share network.\"))"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    NO_DEFAULT_SHARE_TYPE \u003d ("},{"line_number":136,"context_line":"        \u0027024\u0027,"},{"line_number":137,"context_line":"        _(\"No default share type has been made available. \""}],"source_content_type":"text/x-python","patch_set":9,"id":"b2b0caf5_24813bf9","line":134,"range":{"start_line":129,"start_character":4,"end_line":134,"end_character":0},"updated":"2021-08-05 15:27:45.000000000","message":"there\u0027s a 024 message now, so this can be 025, and moved below.","commit_id":"319f2dad5526f8b71608b8350d90b18aa9c8ff69"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"197ee1e3b382046fbfbab8f23f22c1db26b0cc07","unresolved":false,"context_lines":[{"line_number":126,"context_line":"          \"authentication issue. The security service user has either \""},{"line_number":127,"context_line":"          \"insufficient privileges or wrong credentials. Please check your \""},{"line_number":128,"context_line":"          \"user, password, ou and domain.\"))"},{"line_number":129,"context_line":"    MISSING_SECURITY_SERVICE \u003d ("},{"line_number":130,"context_line":"        \u0027024\u0027,"},{"line_number":131,"context_line":"        _(\"Share Driver failed to create share because a security service \""},{"line_number":132,"context_line":"          \"has not been added to the share network used. Please add a \""},{"line_number":133,"context_line":"          \"security service to the share network.\"))"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    NO_DEFAULT_SHARE_TYPE \u003d ("},{"line_number":136,"context_line":"        \u0027024\u0027,"},{"line_number":137,"context_line":"        _(\"No default share type has been made available. \""}],"source_content_type":"text/x-python","patch_set":9,"id":"d1a83e08_64c4a652","line":134,"range":{"start_line":129,"start_character":4,"end_line":134,"end_character":0},"in_reply_to":"b2b0caf5_24813bf9","updated":"2021-08-05 15:34:29.000000000","message":"Done","commit_id":"319f2dad5526f8b71608b8350d90b18aa9c8ff69"}],"manila/share/driver.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d0054b24ff082475f0a7d8cf50ce18a6dabf5e92","unresolved":true,"context_lines":[{"line_number":3322,"context_line":"        \"\"\""},{"line_number":3323,"context_line":"        raise NotImplementedError()"},{"line_number":3324,"context_line":""},{"line_number":3325,"context_line":"    def get_share_network_security_service_assoc(self, context, share):"},{"line_number":3326,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":5,"id":"af064ba4_2a5daee3","line":3325,"range":{"start_line":3325,"start_character":8,"end_line":3325,"end_character":48},"updated":"2021-06-11 04:42:17.000000000","message":"Instead of introducing a new method that must get invoked every time a share is created, is it possible to just expect a driver attribute that you can check on? The base driver can set this attribute to None, or an empty dictionary; and the individual drivers can override this to a dict like this:\n\n self.dhss_mandatory_security_service_association \u003d {\n    \u0027nfs\u0027: None, \n    \u0027cifs\u0027: \u0027active_directory\u0027,\n }\n\n\ndrivers can initialize this statically in code, in their init methods and we can rely on it in the share manager and respond with a failure/user message.","commit_id":"0b57cc244ad75940c63287bce61f57e68b544af6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"eace458b7a56d92ec5ba196423cd456b8dce504a","unresolved":true,"context_lines":[{"line_number":3322,"context_line":"        \"\"\""},{"line_number":3323,"context_line":"        raise NotImplementedError()"},{"line_number":3324,"context_line":""},{"line_number":3325,"context_line":"    def get_share_network_security_service_assoc(self, context, share):"},{"line_number":3326,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":5,"id":"ae3fd5fe_4f2c268e","line":3325,"updated":"2021-06-10 17:05:36.000000000","message":"Please add a docstring to this method","commit_id":"0b57cc244ad75940c63287bce61f57e68b544af6"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"5b86ad782e620f797630e3ce8c32b9035856e6a3","unresolved":false,"context_lines":[{"line_number":3322,"context_line":"        \"\"\""},{"line_number":3323,"context_line":"        raise NotImplementedError()"},{"line_number":3324,"context_line":""},{"line_number":3325,"context_line":"    def get_share_network_security_service_assoc(self, context, share):"},{"line_number":3326,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":5,"id":"4084b042_afff57b3","line":3325,"in_reply_to":"ae3fd5fe_4f2c268e","updated":"2021-06-14 10:27:22.000000000","message":"Done","commit_id":"0b57cc244ad75940c63287bce61f57e68b544af6"}],"manila/share/drivers/netapp/dataontap/cluster_mode/drv_single_svm.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"eace458b7a56d92ec5ba196423cd456b8dce504a","unresolved":true,"context_lines":[{"line_number":333,"context_line":"        raise NotImplementedError"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    def get_share_network_security_service_assoc(self, context, share):"},{"line_number":336,"context_line":"        return self.library.get_share_network_security_service_assoc("},{"line_number":337,"context_line":"            context, share)"}],"source_content_type":"text/x-python","patch_set":5,"id":"4d1aba12_5856ec7b","line":337,"range":{"start_line":336,"start_character":8,"end_line":337,"end_character":27},"updated":"2021-06-10 17:05:36.000000000","message":"I think this should raise NotImplementedError, considering that in this file, we have the operations for the drv_single_svm (DHSS\u003dFalse), and the security service feature is meant to work only with DHSS\u003dTrue drivers...","commit_id":"0b57cc244ad75940c63287bce61f57e68b544af6"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"5b86ad782e620f797630e3ce8c32b9035856e6a3","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        raise NotImplementedError"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    def get_share_network_security_service_assoc(self, context, share):"},{"line_number":336,"context_line":"        return self.library.get_share_network_security_service_assoc("},{"line_number":337,"context_line":"            context, share)"}],"source_content_type":"text/x-python","patch_set":5,"id":"b394ad77_d31afedb","line":337,"range":{"start_line":336,"start_character":8,"end_line":337,"end_character":27},"in_reply_to":"4d1aba12_5856ec7b","updated":"2021-06-14 10:27:22.000000000","message":"Done","commit_id":"0b57cc244ad75940c63287bce61f57e68b544af6"}],"manila/share/manager.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"eace458b7a56d92ec5ba196423cd456b8dce504a","unresolved":true,"context_lines":[{"line_number":2009,"context_line":"        else:"},{"line_number":2010,"context_line":"            share_server \u003d None"},{"line_number":2011,"context_line":""},{"line_number":2012,"context_line":"        if share_network_id and self.driver.driver_handles_share_servers:"},{"line_number":2013,"context_line":"            ret_types \u003d self.driver.get_share_network_security_service_assoc("},{"line_number":2014,"context_line":"                context, share_instance)"},{"line_number":2015,"context_line":"            if ret_types:"}],"source_content_type":"text/x-python","patch_set":5,"id":"6415c8ec_d74ddde5","line":2012,"updated":"2021-06-10 17:05:36.000000000","message":"Could you please add some more unit tests to cover this change?\nhttps://6dca5728c40d535db466-4fcaafdedb24be0c657932ab646595c9.ssl.cf2.rackcdn.com/776875/5/check/openstack-tox-cover/412e02f/cover/manila_share_manager_py.html#t2015","commit_id":"0b57cc244ad75940c63287bce61f57e68b544af6"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"5b86ad782e620f797630e3ce8c32b9035856e6a3","unresolved":false,"context_lines":[{"line_number":2009,"context_line":"        else:"},{"line_number":2010,"context_line":"            share_server \u003d None"},{"line_number":2011,"context_line":""},{"line_number":2012,"context_line":"        if share_network_id and self.driver.driver_handles_share_servers:"},{"line_number":2013,"context_line":"            ret_types \u003d self.driver.get_share_network_security_service_assoc("},{"line_number":2014,"context_line":"                context, share_instance)"},{"line_number":2015,"context_line":"            if ret_types:"}],"source_content_type":"text/x-python","patch_set":5,"id":"6421492b_5d5426de","line":2012,"in_reply_to":"6415c8ec_d74ddde5","updated":"2021-06-14 10:27:22.000000000","message":"Done","commit_id":"0b57cc244ad75940c63287bce61f57e68b544af6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"eace458b7a56d92ec5ba196423cd456b8dce504a","unresolved":true,"context_lines":[{"line_number":2019,"context_line":"                for security_service in share_network[\u0027security_services\u0027]:"},{"line_number":2020,"context_line":"                    if security_service[\u0027type\u0027] in ret_types:"},{"line_number":2021,"context_line":"                        security_service_associated \u003d True"},{"line_number":2022,"context_line":"                        break"},{"line_number":2023,"context_line":"                if security_service_associated is False:"},{"line_number":2024,"context_line":"                    raise exception.InvalidRequest(_("},{"line_number":2025,"context_line":"                        \"Share network security service association is \""}],"source_content_type":"text/x-python","patch_set":5,"id":"88255923_4a9b8d82","line":2022,"range":{"start_line":2022,"start_character":24,"end_line":2022,"end_character":29},"updated":"2021-06-10 17:05:36.000000000","message":"I think this break should not exist here... I mean, you can have more than one security service associated with a share network, and this validation would only work for the first security service that matches, and it will not validate to possible other security services in the share network.","commit_id":"0b57cc244ad75940c63287bce61f57e68b544af6"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"5b86ad782e620f797630e3ce8c32b9035856e6a3","unresolved":false,"context_lines":[{"line_number":2019,"context_line":"                for security_service in share_network[\u0027security_services\u0027]:"},{"line_number":2020,"context_line":"                    if security_service[\u0027type\u0027] in ret_types:"},{"line_number":2021,"context_line":"                        security_service_associated \u003d True"},{"line_number":2022,"context_line":"                        break"},{"line_number":2023,"context_line":"                if security_service_associated is False:"},{"line_number":2024,"context_line":"                    raise exception.InvalidRequest(_("},{"line_number":2025,"context_line":"                        \"Share network security service association is \""}],"source_content_type":"text/x-python","patch_set":5,"id":"35ccdd5d_979160ed","line":2022,"range":{"start_line":2022,"start_character":24,"end_line":2022,"end_character":29},"in_reply_to":"88255923_4a9b8d82","updated":"2021-06-14 10:27:22.000000000","message":"Done","commit_id":"0b57cc244ad75940c63287bce61f57e68b544af6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"eace458b7a56d92ec5ba196423cd456b8dce504a","unresolved":true,"context_lines":[{"line_number":2024,"context_line":"                    raise exception.InvalidRequest(_("},{"line_number":2025,"context_line":"                        \"Share network security service association is \""},{"line_number":2026,"context_line":"                        \"mandatory for protocol %s.\") % share_instance.get("},{"line_number":2027,"context_line":"                        \u0027share_proto\u0027))"},{"line_number":2028,"context_line":""},{"line_number":2029,"context_line":"        status \u003d constants.STATUS_AVAILABLE"},{"line_number":2030,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ec03f013_7e13f5e8","line":2027,"updated":"2021-06-10 17:05:36.000000000","message":"We could possibly have a user message talking about this issue as well.","commit_id":"0b57cc244ad75940c63287bce61f57e68b544af6"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"5b86ad782e620f797630e3ce8c32b9035856e6a3","unresolved":false,"context_lines":[{"line_number":2024,"context_line":"                    raise exception.InvalidRequest(_("},{"line_number":2025,"context_line":"                        \"Share network security service association is \""},{"line_number":2026,"context_line":"                        \"mandatory for protocol %s.\") % share_instance.get("},{"line_number":2027,"context_line":"                        \u0027share_proto\u0027))"},{"line_number":2028,"context_line":""},{"line_number":2029,"context_line":"        status \u003d constants.STATUS_AVAILABLE"},{"line_number":2030,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7d64aa3c_0edb13a3","line":2027,"in_reply_to":"ec03f013_7e13f5e8","updated":"2021-06-14 10:27:22.000000000","message":"Done","commit_id":"0b57cc244ad75940c63287bce61f57e68b544af6"}],"manila/tests/share/test_manager.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"62209102b61d2d1323632a2f65ee15be3d679df8","unresolved":true,"context_lines":[{"line_number":2260,"context_line":""},{"line_number":2261,"context_line":"        self.mock_object(self.share_manager, \u0027driver\u0027)"},{"line_number":2262,"context_line":"        self.share_manager.driver.driver_handles_share_servers \u003d True"},{"line_number":2263,"context_line":"        self.share_manager.driver.\\"},{"line_number":2264,"context_line":"            dhss_mandatory_security_service_association \u003d {"},{"line_number":2265,"context_line":"                \u0027fake_proto\u0027: [\u0027fake_ss\u0027, \u0027fake_ss2\u0027, ]"},{"line_number":2266,"context_line":"            }"},{"line_number":2267,"context_line":"        ss_data \u003d {"},{"line_number":2268,"context_line":"            \u0027name\u0027: \u0027fake_name\u0027,"},{"line_number":2269,"context_line":"            \u0027ou\u0027: \u0027fake_ou\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"da677b08_4a9c0720","line":2266,"range":{"start_line":2263,"start_character":8,"end_line":2266,"end_character":13},"updated":"2021-07-28 22:50:42.000000000","message":"nit: this could be surrounded by ()","commit_id":"c949816dbf7ac92ff547d89bd5c9aad02626aea5"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"880655f2faedd08998838b2afc62312c609d1a85","unresolved":false,"context_lines":[{"line_number":2260,"context_line":""},{"line_number":2261,"context_line":"        self.mock_object(self.share_manager, \u0027driver\u0027)"},{"line_number":2262,"context_line":"        self.share_manager.driver.driver_handles_share_servers \u003d True"},{"line_number":2263,"context_line":"        self.share_manager.driver.\\"},{"line_number":2264,"context_line":"            dhss_mandatory_security_service_association \u003d {"},{"line_number":2265,"context_line":"                \u0027fake_proto\u0027: [\u0027fake_ss\u0027, \u0027fake_ss2\u0027, ]"},{"line_number":2266,"context_line":"            }"},{"line_number":2267,"context_line":"        ss_data \u003d {"},{"line_number":2268,"context_line":"            \u0027name\u0027: \u0027fake_name\u0027,"},{"line_number":2269,"context_line":"            \u0027ou\u0027: \u0027fake_ou\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"8ea8ffc9_4b36700a","line":2266,"range":{"start_line":2263,"start_character":8,"end_line":2266,"end_character":13},"in_reply_to":"da677b08_4a9c0720","updated":"2021-07-30 20:22:03.000000000","message":"Ack","commit_id":"c949816dbf7ac92ff547d89bd5c9aad02626aea5"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"62209102b61d2d1323632a2f65ee15be3d679df8","unresolved":true,"context_lines":[{"line_number":2485,"context_line":"            share_srv"},{"line_number":2486,"context_line":"        )"},{"line_number":2487,"context_line":"        self.share_manager.driver \u003d driver_mock"},{"line_number":2488,"context_line":"        self.share_manager.driver.\\"},{"line_number":2489,"context_line":"            dhss_mandatory_security_service_association \u003d {}"},{"line_number":2490,"context_line":"        self.share_manager.create_share_instance(self.context,"},{"line_number":2491,"context_line":"                                                 share.instance[\u0027id\u0027])"},{"line_number":2492,"context_line":"        self.assertFalse(self.share_manager.driver.setup_network.called)"}],"source_content_type":"text/x-python","patch_set":8,"id":"71a658d8_7a9a8db4","line":2489,"range":{"start_line":2488,"start_character":8,"end_line":2489,"end_character":60},"updated":"2021-07-28 22:50:42.000000000","message":"this could be surrounded by (), so the \\ could be avoided when breaking the line","commit_id":"c949816dbf7ac92ff547d89bd5c9aad02626aea5"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"bcc7e2c365d0620b01a6dd0b0782149ca8a06cf8","unresolved":true,"context_lines":[{"line_number":2485,"context_line":"            share_srv"},{"line_number":2486,"context_line":"        )"},{"line_number":2487,"context_line":"        self.share_manager.driver \u003d driver_mock"},{"line_number":2488,"context_line":"        self.share_manager.driver.\\"},{"line_number":2489,"context_line":"            dhss_mandatory_security_service_association \u003d {}"},{"line_number":2490,"context_line":"        self.share_manager.create_share_instance(self.context,"},{"line_number":2491,"context_line":"                                                 share.instance[\u0027id\u0027])"},{"line_number":2492,"context_line":"        self.assertFalse(self.share_manager.driver.setup_network.called)"}],"source_content_type":"text/x-python","patch_set":8,"id":"cf94bc49_bdc47318","line":2489,"range":{"start_line":2488,"start_character":8,"end_line":2489,"end_character":60},"in_reply_to":"49e9c60d_35a35f05","updated":"2021-08-05 20:36:00.000000000","message":"No worries, Kiran!","commit_id":"c949816dbf7ac92ff547d89bd5c9aad02626aea5"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"880655f2faedd08998838b2afc62312c609d1a85","unresolved":true,"context_lines":[{"line_number":2485,"context_line":"            share_srv"},{"line_number":2486,"context_line":"        )"},{"line_number":2487,"context_line":"        self.share_manager.driver \u003d driver_mock"},{"line_number":2488,"context_line":"        self.share_manager.driver.\\"},{"line_number":2489,"context_line":"            dhss_mandatory_security_service_association \u003d {}"},{"line_number":2490,"context_line":"        self.share_manager.create_share_instance(self.context,"},{"line_number":2491,"context_line":"                                                 share.instance[\u0027id\u0027])"},{"line_number":2492,"context_line":"        self.assertFalse(self.share_manager.driver.setup_network.called)"}],"source_content_type":"text/x-python","patch_set":8,"id":"49e9c60d_35a35f05","line":2489,"range":{"start_line":2488,"start_character":8,"end_line":2489,"end_character":60},"in_reply_to":"71a658d8_7a9a8db4","updated":"2021-07-30 20:22:03.000000000","message":"This does not work, I tried lot of combinations. If it fixes here, it breaks at Line 2264 with E999. So kept as it was. What say ??","commit_id":"c949816dbf7ac92ff547d89bd5c9aad02626aea5"}],"releasenotes/notes/bug-1900752-early-validate-mandatory-security-service-association-f48aecbbc47418cd.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"62209102b61d2d1323632a2f65ee15be3d679df8","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Validate the security service association based on share protocol from"},{"line_number":5,"context_line":"    the given driver. Raise invalid request exception if needed association"},{"line_number":6,"context_line":"    between share_network and security_service is missing."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"aa7e6e33_beb37ff6","line":6,"range":{"start_line":5,"start_character":22,"end_line":6,"end_character":57},"updated":"2021-07-28 22:50:42.000000000","message":"I think the mention to an exception could be avoided in this release note... I mean, the only thing a regular user would see in case of a failure, would be the user message for the given share.\nIMHO this paragraph could be rephrased to something like: Manila won\u0027t allow shares to be created when the specified protocol requires a specific security service type that is not associated to the share network.\nAlso, in the first line the issue could be briefly mentioned...\nMore details about release notes are available here: https://docs.openstack.org/manila/latest/contributor/adding_release_notes.html","commit_id":"c949816dbf7ac92ff547d89bd5c9aad02626aea5"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"880655f2faedd08998838b2afc62312c609d1a85","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Validate the security service association based on share protocol from"},{"line_number":5,"context_line":"    the given driver. Raise invalid request exception if needed association"},{"line_number":6,"context_line":"    between share_network and security_service is missing."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"b6928df1_65fd29ef","line":6,"range":{"start_line":5,"start_character":22,"end_line":6,"end_character":57},"in_reply_to":"aa7e6e33_beb37ff6","updated":"2021-07-30 20:22:03.000000000","message":"Done","commit_id":"c949816dbf7ac92ff547d89bd5c9aad02626aea5"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"bcc7e2c365d0620b01a6dd0b0782149ca8a06cf8","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    For some drivers, to create a share with specific protocol it is mandatory"},{"line_number":5,"context_line":"    to add a security service to the share network beforehand. If this is"},{"line_number":6,"context_line":"    forgotten the share ends up in error. Fixed it by early validation, so"},{"line_number":7,"context_line":"    that Manila won\u0027t allow shares to be created when the specified protocol"},{"line_number":8,"context_line":"    requires a specific security service type that is not associated to the"},{"line_number":9,"context_line":"    share network."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"197513c8_c4bda959","line":7,"range":{"start_line":6,"start_character":42,"end_line":7,"end_character":8},"updated":"2021-08-05 20:36:00.000000000","message":"From now on,","commit_id":"21c84b63f16ee42d9f06e0bf6b22abeeae39a7bd"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"fc015eba8477a83e3ae57ba61d6766501982dc73","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    For some drivers, to create a share with specific protocol it is mandatory"},{"line_number":5,"context_line":"    to add a security service to the share network beforehand. If this is"},{"line_number":6,"context_line":"    forgotten the share ends up in error. Fixed it by early validation, so"},{"line_number":7,"context_line":"    that Manila won\u0027t allow shares to be created when the specified protocol"},{"line_number":8,"context_line":"    requires a specific security service type that is not associated to the"},{"line_number":9,"context_line":"    share network."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3ef936ed_7c795a9b","line":7,"range":{"start_line":6,"start_character":42,"end_line":7,"end_character":8},"in_reply_to":"197513c8_c4bda959","updated":"2021-08-05 20:42:09.000000000","message":"Done","commit_id":"21c84b63f16ee42d9f06e0bf6b22abeeae39a7bd"}]}