)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"9fa8939272a7b9e393ae489f300b5e6cac49fb8c","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fixes  availability zone filter while creating from snapshot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes bug #1915706 in Manila UI, availability zone"},{"line_number":10,"context_line":"not being picked up correctly. Issue is invaild input"},{"line_number":11,"context_line":"error being raised, even when availability_zone provided"},{"line_number":12,"context_line":"is the same, as parent share\u0027s. Because in the filter"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bdf89362_37d88a31","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":31},"updated":"2021-05-06 07:09:58.000000000","message":"Maybe something like \"Fixes bug #1915706, that was discovered in manila UI\"\n\nBecause the change here is not a change to the UI.","commit_id":"da6f804977999add0ab3ce08c80c9e446687f4be"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"e170c751c65e5b7b6cc3eab3da79982f4b55d445","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fixes  availability zone filter while creating from snapshot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes bug #1915706 in Manila UI, availability zone"},{"line_number":10,"context_line":"not being picked up correctly. Issue is invaild input"},{"line_number":11,"context_line":"error being raised, even when availability_zone provided"},{"line_number":12,"context_line":"is the same, as parent share\u0027s. Because in the filter"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"e5e30378_4be65acf","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":31},"in_reply_to":"bdf89362_37d88a31","updated":"2021-05-06 14:43:38.000000000","message":"Done","commit_id":"da6f804977999add0ab3ce08c80c9e446687f4be"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"9fa8939272a7b9e393ae489f300b5e6cac49fb8c","unresolved":true,"context_lines":[{"line_number":7,"context_line":"fixes  availability zone filter while creating from snapshot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes bug #1915706 in Manila UI, availability zone"},{"line_number":10,"context_line":"not being picked up correctly. Issue is invaild input"},{"line_number":11,"context_line":"error being raised, even when availability_zone provided"},{"line_number":12,"context_line":"is the same, as parent share\u0027s. Because in the filter"},{"line_number":13,"context_line":"availability_zone is name and source_share_az"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"80ca2d25_cd69c3e1","line":10,"range":{"start_line":10,"start_character":40,"end_line":10,"end_character":47},"updated":"2021-05-06 07:09:58.000000000","message":"nit: invalid","commit_id":"da6f804977999add0ab3ce08c80c9e446687f4be"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"e170c751c65e5b7b6cc3eab3da79982f4b55d445","unresolved":false,"context_lines":[{"line_number":7,"context_line":"fixes  availability zone filter while creating from snapshot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes bug #1915706 in Manila UI, availability zone"},{"line_number":10,"context_line":"not being picked up correctly. Issue is invaild input"},{"line_number":11,"context_line":"error being raised, even when availability_zone provided"},{"line_number":12,"context_line":"is the same, as parent share\u0027s. Because in the filter"},{"line_number":13,"context_line":"availability_zone is name and source_share_az"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bffc3e52_4b0d6711","line":10,"range":{"start_line":10,"start_character":40,"end_line":10,"end_character":47},"in_reply_to":"80ca2d25_cd69c3e1","updated":"2021-05-06 14:43:38.000000000","message":"Done","commit_id":"da6f804977999add0ab3ce08c80c9e446687f4be"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"9fa8939272a7b9e393ae489f300b5e6cac49fb8c","unresolved":true,"context_lines":[{"line_number":13,"context_line":"availability_zone is name and source_share_az"},{"line_number":14,"context_line":"is id [1]. Now, regardless of availability_zone provided as"},{"line_number":15,"context_line":"id or name, it will always be converted to a name."},{"line_number":16,"context_line":"And if availaibity_zone is the same as parent share\u0027s"},{"line_number":17,"context_line":"operation will complete successfully."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[1] https://github.com/openstack/manila/blob/2e27c71877fdb601ba90b44c3573d8e50e099042/manila/share/api.py#L200"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1cd0682e_361bc45a","line":16,"range":{"start_line":16,"start_character":7,"end_line":16,"end_character":23},"updated":"2021-05-06 07:09:58.000000000","message":"nit: availability_zone","commit_id":"da6f804977999add0ab3ce08c80c9e446687f4be"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"e170c751c65e5b7b6cc3eab3da79982f4b55d445","unresolved":false,"context_lines":[{"line_number":13,"context_line":"availability_zone is name and source_share_az"},{"line_number":14,"context_line":"is id [1]. Now, regardless of availability_zone provided as"},{"line_number":15,"context_line":"id or name, it will always be converted to a name."},{"line_number":16,"context_line":"And if availaibity_zone is the same as parent share\u0027s"},{"line_number":17,"context_line":"operation will complete successfully."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[1] https://github.com/openstack/manila/blob/2e27c71877fdb601ba90b44c3573d8e50e099042/manila/share/api.py#L200"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1d329759_9fab920b","line":16,"range":{"start_line":16,"start_character":7,"end_line":16,"end_character":23},"in_reply_to":"1cd0682e_361bc45a","updated":"2021-05-06 14:43:38.000000000","message":"Done","commit_id":"da6f804977999add0ab3ce08c80c9e446687f4be"}],"manila/api/v1/shares.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"21ae430e8756aa27e135798bbc9731462ba3d7ea","unresolved":true,"context_lines":[{"line_number":281,"context_line":"                        \"share group\u0027s one (%(sg_az)s).\") % {"},{"line_number":282,"context_line":"                            \u0027s_az\u0027: availability_zone_id, \u0027sg_az\u0027: sg_az_id}"},{"line_number":283,"context_line":"                raise exception.InvalidInput(msg)"},{"line_number":284,"context_line":"            availability_zone_id \u003d sg_az_id"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        kwargs \u003d {"},{"line_number":287,"context_line":"            \u0027availability_zone\u0027: availability_zone_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"f773cf87_71cfc18e","side":"PARENT","line":284,"range":{"start_line":284,"start_character":12,"end_line":284,"end_character":43},"updated":"2021-04-03 07:40:50.000000000","message":"we can not delete this line, if create share only give share_group_id, but not availability_zone, then we need to get az from share_group_id.\n\nwe can change this to:\navailability_zone \u003d db.availability_zone_get(context, sg_az_id).name","commit_id":"9619ca32429e62bdf89ada3cddf9e53e4ccc1ad1"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"13fe032fb0db08e4f99cf686838059c46b99c14c","unresolved":false,"context_lines":[{"line_number":281,"context_line":"                        \"share group\u0027s one (%(sg_az)s).\") % {"},{"line_number":282,"context_line":"                            \u0027s_az\u0027: availability_zone_id, \u0027sg_az\u0027: sg_az_id}"},{"line_number":283,"context_line":"                raise exception.InvalidInput(msg)"},{"line_number":284,"context_line":"            availability_zone_id \u003d sg_az_id"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        kwargs \u003d {"},{"line_number":287,"context_line":"            \u0027availability_zone\u0027: availability_zone_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"825e4661_a66b41d1","side":"PARENT","line":284,"range":{"start_line":284,"start_character":12,"end_line":284,"end_character":43},"in_reply_to":"f773cf87_71cfc18e","updated":"2021-04-05 13:35:52.000000000","message":"Done","commit_id":"9619ca32429e62bdf89ada3cddf9e53e4ccc1ad1"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"21ae430e8756aa27e135798bbc9731462ba3d7ea","unresolved":true,"context_lines":[{"line_number":284,"context_line":"            availability_zone_id \u003d sg_az_id"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        kwargs \u003d {"},{"line_number":287,"context_line":"            \u0027availability_zone\u0027: availability_zone_id,"},{"line_number":288,"context_line":"            \u0027metadata\u0027: share.get(\u0027metadata\u0027),"},{"line_number":289,"context_line":"            \u0027is_public\u0027: share.get(\u0027is_public\u0027, False),"},{"line_number":290,"context_line":"            \u0027share_group_id\u0027: share_group_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"af0066b0_66179136","side":"PARENT","line":287,"range":{"start_line":287,"start_character":12,"end_line":287,"end_character":54},"updated":"2021-04-03 07:40:50.000000000","message":"good find, in manila/share/api.py#231, code like below:\nelif (availability_zone !\u003d source_share_az\nsource_share_az is az name, so here we should use az name, not az_id.","commit_id":"9619ca32429e62bdf89ada3cddf9e53e4ccc1ad1"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"13fe032fb0db08e4f99cf686838059c46b99c14c","unresolved":false,"context_lines":[{"line_number":284,"context_line":"            availability_zone_id \u003d sg_az_id"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        kwargs \u003d {"},{"line_number":287,"context_line":"            \u0027availability_zone\u0027: availability_zone_id,"},{"line_number":288,"context_line":"            \u0027metadata\u0027: share.get(\u0027metadata\u0027),"},{"line_number":289,"context_line":"            \u0027is_public\u0027: share.get(\u0027is_public\u0027, False),"},{"line_number":290,"context_line":"            \u0027share_group_id\u0027: share_group_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7bc348de_d63ca328","side":"PARENT","line":287,"range":{"start_line":287,"start_character":12,"end_line":287,"end_character":54},"in_reply_to":"af0066b0_66179136","updated":"2021-04-05 13:35:52.000000000","message":"Ack","commit_id":"9619ca32429e62bdf89ada3cddf9e53e4ccc1ad1"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"983bc8b51786e8922f0fa3937566172a1f98a02f","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        availability_zone_id \u003d None"},{"line_number":264,"context_line":"        availability_zone \u003d share.get(\u0027availability_zone\u0027)"},{"line_number":265,"context_line":"        if availability_zone:"},{"line_number":266,"context_line":"            try:"},{"line_number":267,"context_line":"                availability_zone_id \u003d db.availability_zone_get("},{"line_number":268,"context_line":"                    context, availability_zone).id"}],"source_content_type":"text/x-python","patch_set":4,"id":"cd97575e_f0102feb","line":265,"updated":"2021-04-28 19:04:44.000000000","message":"db.availability_zone_get is performed in this block","commit_id":"a69934cecd0990903bff1367db3f6242a29857bb"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"c6d0f26daa8def03e8c2164960a6151eb2fcacd0","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        availability_zone_id \u003d None"},{"line_number":264,"context_line":"        availability_zone \u003d share.get(\u0027availability_zone\u0027)"},{"line_number":265,"context_line":"        if availability_zone:"},{"line_number":266,"context_line":"            try:"},{"line_number":267,"context_line":"                availability_zone_id \u003d db.availability_zone_get("},{"line_number":268,"context_line":"                    context, availability_zone).id"}],"source_content_type":"text/x-python","patch_set":4,"id":"d43acec8_c7402598","line":265,"in_reply_to":"3164db4c_2e939e37","updated":"2021-04-29 11:42:42.000000000","message":"thanks haixin, but I think the change in essence is the same as the\ncode that already exists.\nOk, will try research a bit and understand what is the issue here thanks 😊","commit_id":"a69934cecd0990903bff1367db3f6242a29857bb"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"77e25adf0fc42dc385a1625eda30cebb0ce4c83b","unresolved":true,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        availability_zone_id \u003d None"},{"line_number":264,"context_line":"        availability_zone \u003d share.get(\u0027availability_zone\u0027)"},{"line_number":265,"context_line":"        if availability_zone:"},{"line_number":266,"context_line":"            try:"},{"line_number":267,"context_line":"                availability_zone_id \u003d db.availability_zone_get("},{"line_number":268,"context_line":"                    context, availability_zone).id"}],"source_content_type":"text/x-python","patch_set":4,"id":"f37e76e9_58fb6c1f","line":265,"in_reply_to":"7ceb2e2b_94d0d192","updated":"2021-04-30 01:46:02.000000000","message":"think about below case:\navailability_zone in request body is uuid form. for example it is \u0027123456\u0027\n\navailability_zone \u003d share.get(\u0027availability_zone\u0027)  # we get availability_zone  is \u0027123456\u0027\n    if availability_zone:                           # will be true\n        try:\n            availability_zone_id \u003d db.availability_zone_get(\n                 context, availability_zone).id   # here we check availability_zone from db,\n                                                    and get availability_zone_id is really\n                                                    \"123456\",but variable availability_zone\n                                                    is still \"123456\", we did not get it\u0027s\n                                                    name. \n        except exception.AvailabilityZoneNotFound as e:\n             raise exc.HTTPNotFound(explanation\u003dsix.text_type(e))\nshare_group_id \u003d share.get(\u0027share_group_id\u0027)  # share_group_id not exist in request body.\nif share_group_id:                            # share_group_id is None \n    ...                                       # skip from line 273 to 285\n\nkwargs \u003d {\n    \u0027availability_zone\u0027: availability_zone,   # here we found the variable availability_zone is\n                                              # still \"123456\", but not availability_zone name.\n                                              # here is the key point.\n    ....","commit_id":"a69934cecd0990903bff1367db3f6242a29857bb"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"bff2d7fb404ae781512f6a99a7e76772c12c1c6f","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        availability_zone_id \u003d None"},{"line_number":264,"context_line":"        availability_zone \u003d share.get(\u0027availability_zone\u0027)"},{"line_number":265,"context_line":"        if availability_zone:"},{"line_number":266,"context_line":"            try:"},{"line_number":267,"context_line":"                availability_zone_id \u003d db.availability_zone_get("},{"line_number":268,"context_line":"                    context, availability_zone).id"}],"source_content_type":"text/x-python","patch_set":4,"id":"7755da7e_e6eb341c","line":265,"in_reply_to":"c4435ab3_cf28034f","updated":"2021-07-05 13:17:55.000000000","message":"Makes sense :)","commit_id":"a69934cecd0990903bff1367db3f6242a29857bb"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"95c452386b84ef4f374e575b7ec3ba5aa3aeb98f","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        availability_zone_id \u003d None"},{"line_number":264,"context_line":"        availability_zone \u003d share.get(\u0027availability_zone\u0027)"},{"line_number":265,"context_line":"        if availability_zone:"},{"line_number":266,"context_line":"            try:"},{"line_number":267,"context_line":"                availability_zone_id \u003d db.availability_zone_get("},{"line_number":268,"context_line":"                    context, availability_zone).id"}],"source_content_type":"text/x-python","patch_set":4,"id":"3164db4c_2e939e37","line":265,"in_reply_to":"cd97575e_f0102feb","updated":"2021-04-29 01:49:49.000000000","message":"i know what carthaca means, mybe here we should change like below:\nif availability_zone:\n    try:\n        availability_zone_db \u003d db.availability_zone_get(\n            context, availability_zone)\n        availability_zone_id \u003d availability_zone_db.id\n        availability_zone \u003d availability_zone_db.name\n    except exception.AvailabilityZoneNotFound as e:\n        raise exc.HTTPNotFound(explanation\u003dsix.text_type(e))","commit_id":"a69934cecd0990903bff1367db3f6242a29857bb"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"497fccf947ff4ddd2b599aa8332f78a76a4fd4a9","unresolved":true,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        availability_zone_id \u003d None"},{"line_number":264,"context_line":"        availability_zone \u003d share.get(\u0027availability_zone\u0027)"},{"line_number":265,"context_line":"        if availability_zone:"},{"line_number":266,"context_line":"            try:"},{"line_number":267,"context_line":"                availability_zone_id \u003d db.availability_zone_get("},{"line_number":268,"context_line":"                    context, availability_zone).id"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ceb2e2b_94d0d192","line":265,"in_reply_to":"d43acec8_c7402598","updated":"2021-04-29 14:58:38.000000000","message":"I think Dina is right, although the refactor that haixin proposes will make the code easier to read.","commit_id":"a69934cecd0990903bff1367db3f6242a29857bb"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"2d3e3d7a3266b152859285994de2cd03037b4984","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        availability_zone_id \u003d None"},{"line_number":264,"context_line":"        availability_zone \u003d share.get(\u0027availability_zone\u0027)"},{"line_number":265,"context_line":"        if availability_zone:"},{"line_number":266,"context_line":"            try:"},{"line_number":267,"context_line":"                availability_zone_id \u003d db.availability_zone_get("},{"line_number":268,"context_line":"                    context, availability_zone).id"}],"source_content_type":"text/x-python","patch_set":4,"id":"c4435ab3_cf28034f","line":265,"in_reply_to":"f37e76e9_58fb6c1f","updated":"2021-05-05 19:46:31.000000000","message":"thanks a lot for help, haixin understood now :) I\u0027m sorry, didn\u0027t realize share_group_id is removed.fixed","commit_id":"a69934cecd0990903bff1367db3f6242a29857bb"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"983bc8b51786e8922f0fa3937566172a1f98a02f","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        availability_zone \u003d share.get(\u0027availability_zone\u0027)"},{"line_number":265,"context_line":"        if availability_zone:"},{"line_number":266,"context_line":"            try:"},{"line_number":267,"context_line":"                availability_zone_id \u003d db.availability_zone_get("},{"line_number":268,"context_line":"                    context, availability_zone).id"},{"line_number":269,"context_line":"            except exception.AvailabilityZoneNotFound as e:"},{"line_number":270,"context_line":"                raise exc.HTTPNotFound(explanation\u003dsix.text_type(e))"}],"source_content_type":"text/x-python","patch_set":4,"id":"415f3650_717c5300","line":267,"updated":"2021-04-28 19:04:44.000000000","message":"here availability_zone_id is set based on availability_zone var, which can be name or id.","commit_id":"a69934cecd0990903bff1367db3f6242a29857bb"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"ca907501d7d8dfd3f9a8cc0c296147ce697223ed","unresolved":true,"context_lines":[{"line_number":285,"context_line":"                context, sg_az_id).name"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        kwargs \u003d {"},{"line_number":288,"context_line":"            \u0027availability_zone\u0027: availability_zone,"},{"line_number":289,"context_line":"            \u0027metadata\u0027: share.get(\u0027metadata\u0027),"},{"line_number":290,"context_line":"            \u0027is_public\u0027: share.get(\u0027is_public\u0027, False),"},{"line_number":291,"context_line":"            \u0027share_group_id\u0027: share_group_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"4917966c_ee3fb938","line":288,"updated":"2021-04-28 16:50:58.000000000","message":"The provided availability_zone (from line 264 above) can be both, name or uuid.\nWhen no share_group_id is given I suppose this would break when giving the availability_zone param in form of a uuid","commit_id":"a69934cecd0990903bff1367db3f6242a29857bb"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"c7eff6e0f6eda9a54d9d36bb9865e66dc3e744db","unresolved":false,"context_lines":[{"line_number":285,"context_line":"                context, sg_az_id).name"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        kwargs \u003d {"},{"line_number":288,"context_line":"            \u0027availability_zone\u0027: availability_zone,"},{"line_number":289,"context_line":"            \u0027metadata\u0027: share.get(\u0027metadata\u0027),"},{"line_number":290,"context_line":"            \u0027is_public\u0027: share.get(\u0027is_public\u0027, False),"},{"line_number":291,"context_line":"            \u0027share_group_id\u0027: share_group_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"13e6e19e_1d5a96ac","line":288,"in_reply_to":"128b49f0_286c4137","updated":"2021-04-28 18:38:58.000000000","message":"This is only the case for `if share_group_id:`\nIn the case where share_group_id is not set, this `db.availability_zone_get()` is not performed, afaict.","commit_id":"a69934cecd0990903bff1367db3f6242a29857bb"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"983bc8b51786e8922f0fa3937566172a1f98a02f","unresolved":false,"context_lines":[{"line_number":285,"context_line":"                context, sg_az_id).name"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        kwargs \u003d {"},{"line_number":288,"context_line":"            \u0027availability_zone\u0027: availability_zone,"},{"line_number":289,"context_line":"            \u0027metadata\u0027: share.get(\u0027metadata\u0027),"},{"line_number":290,"context_line":"            \u0027is_public\u0027: share.get(\u0027is_public\u0027, False),"},{"line_number":291,"context_line":"            \u0027share_group_id\u0027: share_group_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fce0481_8dcff9fb","line":288,"in_reply_to":"13e6e19e_1d5a96ac","updated":"2021-04-28 19:04:44.000000000","message":"`db.availability_zone_get()` is not performed above.","commit_id":"a69934cecd0990903bff1367db3f6242a29857bb"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"7f24b3ff87e3dc437b3b8ca5e92e519cbf817bd2","unresolved":false,"context_lines":[{"line_number":285,"context_line":"                context, sg_az_id).name"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        kwargs \u003d {"},{"line_number":288,"context_line":"            \u0027availability_zone\u0027: availability_zone,"},{"line_number":289,"context_line":"            \u0027metadata\u0027: share.get(\u0027metadata\u0027),"},{"line_number":290,"context_line":"            \u0027is_public\u0027: share.get(\u0027is_public\u0027, False),"},{"line_number":291,"context_line":"            \u0027share_group_id\u0027: share_group_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"128b49f0_286c4137","line":288,"in_reply_to":"4917966c_ee3fb938","updated":"2021-04-28 17:05:22.000000000","message":"hi carthaca, thank you for reviewing. I think it wouldn\u0027break, as on Line#267, whether availability_zone is given as ID, or name, availability_zone_id is being retrieved, using availability_zone variable.:\ntry:\n267\n                availability_zone_id \u003d db.availability_zone_get(\n268\n                    context, availability_zone).id\n\nthen in if block check (L#279) is performed, I am assigning to availability_zone variable, availability_zone.name from database. This is the reason I think it won\u0027t break. What do you think?","commit_id":"a69934cecd0990903bff1367db3f6242a29857bb"}]}