)]}'
{"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"2635c1844aa24182018aba4930661cf5bc3169d9","unresolved":true,"context_lines":[{"line_number":1561,"context_line":"                    {servers_key_type: server.strip()})"},{"line_number":1562,"context_line":""},{"line_number":1563,"context_line":"        self.send_request(\u0027ldap-client-create\u0027, api_args)"},{"line_number":1564,"context_line":""},{"line_number":1565,"context_line":"        api_args \u003d {\u0027client-config\u0027: config_name, \u0027client-enabled\u0027: \u0027true\u0027}"},{"line_number":1566,"context_line":"        self.send_request(\u0027ldap-config-create\u0027, api_args)"},{"line_number":1567,"context_line":""},{"line_number":1568,"context_line":"    @na_utils.trace"},{"line_number":1569,"context_line":"    def configure_active_directory(self, security_service, vserver_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"e406cd6f_fde6a031","line":1566,"range":{"start_line":1564,"start_character":0,"end_line":1566,"end_character":57},"updated":"2021-03-09 13:22:53.000000000","message":"Need to add a retry operation here, since ONTAP may fail on the first try since it is still finishing to validate ldap client config. This behavior was seen in CI tests.","commit_id":"e140ff39ccb628f16394372a664472ea2355ced8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"11edbe0ed2e6d02a1e5440af9a7caa1e8f6eac84","unresolved":true,"context_lines":[{"line_number":1513,"context_line":""},{"line_number":1514,"context_line":"        if ad_domain:"},{"line_number":1515,"context_line":"            if ldap_servers:"},{"line_number":1516,"context_line":"                msg \u003d _(\"LDAP client cannot be configured with both \u0027server\u0027 \""},{"line_number":1517,"context_line":"                        \"and \u0027domain\u0027 parameters. Use \u0027server\u0027 for Linux/Unix \""},{"line_number":1518,"context_line":"                        \"LDAP servers or \u0027domain\u0027 for Active Directory LDAP \""},{"line_number":1519,"context_line":"                        \"servers.\")"},{"line_number":1520,"context_line":"                LOG.exception(msg)"},{"line_number":1521,"context_line":"                raise exception.NetAppException(msg)"},{"line_number":1522,"context_line":"            # RFC2307bis, for MS Active Directory LDAP server"}],"source_content_type":"text/x-python","patch_set":2,"id":"dc980b82_2b5f28c7","line":1519,"range":{"start_line":1516,"start_character":16,"end_line":1519,"end_character":35},"updated":"2021-03-10 16:40:21.000000000","message":"needs to be a user message as well","commit_id":"483010dd15d634ce43848608d253cf7fac62a8c8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c4d825bdd3ef7d8831d5025918b847f44279107f","unresolved":true,"context_lines":[{"line_number":1513,"context_line":""},{"line_number":1514,"context_line":"        if ad_domain:"},{"line_number":1515,"context_line":"            if ldap_servers:"},{"line_number":1516,"context_line":"                msg \u003d _(\"LDAP client cannot be configured with both \u0027server\u0027 \""},{"line_number":1517,"context_line":"                        \"and \u0027domain\u0027 parameters. Use \u0027server\u0027 for Linux/Unix \""},{"line_number":1518,"context_line":"                        \"LDAP servers or \u0027domain\u0027 for Active Directory LDAP \""},{"line_number":1519,"context_line":"                        \"servers.\")"},{"line_number":1520,"context_line":"                LOG.exception(msg)"},{"line_number":1521,"context_line":"                raise exception.NetAppException(msg)"},{"line_number":1522,"context_line":"            # RFC2307bis, for MS Active Directory LDAP server"}],"source_content_type":"text/x-python","patch_set":2,"id":"b1ba5676_c6105fe8","line":1519,"range":{"start_line":1516,"start_character":16,"end_line":1519,"end_character":35},"in_reply_to":"0486da01_fb8cc805","updated":"2021-03-10 19:08:13.000000000","message":"Totally, lets do that as a separate patch and an UX improvement opportunity","commit_id":"483010dd15d634ce43848608d253cf7fac62a8c8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"30f479cae367049b88305eecd98f3512404632cb","unresolved":true,"context_lines":[{"line_number":1513,"context_line":""},{"line_number":1514,"context_line":"        if ad_domain:"},{"line_number":1515,"context_line":"            if ldap_servers:"},{"line_number":1516,"context_line":"                msg \u003d _(\"LDAP client cannot be configured with both \u0027server\u0027 \""},{"line_number":1517,"context_line":"                        \"and \u0027domain\u0027 parameters. Use \u0027server\u0027 for Linux/Unix \""},{"line_number":1518,"context_line":"                        \"LDAP servers or \u0027domain\u0027 for Active Directory LDAP \""},{"line_number":1519,"context_line":"                        \"servers.\")"},{"line_number":1520,"context_line":"                LOG.exception(msg)"},{"line_number":1521,"context_line":"                raise exception.NetAppException(msg)"},{"line_number":1522,"context_line":"            # RFC2307bis, for MS Active Directory LDAP server"}],"source_content_type":"text/x-python","patch_set":2,"id":"0486da01_fb8cc805","line":1519,"range":{"start_line":1516,"start_character":16,"end_line":1519,"end_character":35},"in_reply_to":"dc980b82_2b5f28c7","updated":"2021-03-10 18:16:44.000000000","message":"I agree with you, but the driver interface \u0027setup_server\u0027 doesn\u0027t provide us both \u0027context\u0027 and \u0027project-id\u0027, needed to create a user message here. One idea is to modify share manager \u0027_setup_server\u0027 to provide this info as kwargs, wtyt?","commit_id":"483010dd15d634ce43848608d253cf7fac62a8c8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"11edbe0ed2e6d02a1e5440af9a7caa1e8f6eac84","unresolved":true,"context_lines":[{"line_number":1524,"context_line":"            bind_dn \u003d (security_service.get(\u0027user\u0027) + \u0027@\u0027 + ad_domain)"},{"line_number":1525,"context_line":"        else:"},{"line_number":1526,"context_line":"            if not ldap_servers:"},{"line_number":1527,"context_line":"                msg \u003d _(\"LDAP client cannot be configured without \u0027server\u0027 \""},{"line_number":1528,"context_line":"                        \"or \u0027domain\u0027 parameters. Use \u0027server\u0027 for Linux/Unix \""},{"line_number":1529,"context_line":"                        \"LDAP servers or \u0027domain\u0027 for Active Directory LDAP \""},{"line_number":1530,"context_line":"                        \"server.\")"},{"line_number":1531,"context_line":"                LOG.exception(msg)"},{"line_number":1532,"context_line":"                raise exception.NetAppException(msg)"},{"line_number":1533,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9e580c91_fc9b7e5d","line":1530,"range":{"start_line":1527,"start_character":23,"end_line":1530,"end_character":34},"updated":"2021-03-10 16:40:21.000000000","message":"needs to be a user message as well","commit_id":"483010dd15d634ce43848608d253cf7fac62a8c8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"30f479cae367049b88305eecd98f3512404632cb","unresolved":true,"context_lines":[{"line_number":1524,"context_line":"            bind_dn \u003d (security_service.get(\u0027user\u0027) + \u0027@\u0027 + ad_domain)"},{"line_number":1525,"context_line":"        else:"},{"line_number":1526,"context_line":"            if not ldap_servers:"},{"line_number":1527,"context_line":"                msg \u003d _(\"LDAP client cannot be configured without \u0027server\u0027 \""},{"line_number":1528,"context_line":"                        \"or \u0027domain\u0027 parameters. Use \u0027server\u0027 for Linux/Unix \""},{"line_number":1529,"context_line":"                        \"LDAP servers or \u0027domain\u0027 for Active Directory LDAP \""},{"line_number":1530,"context_line":"                        \"server.\")"},{"line_number":1531,"context_line":"                LOG.exception(msg)"},{"line_number":1532,"context_line":"                raise exception.NetAppException(msg)"},{"line_number":1533,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"f18970ee_2afb6c01","line":1530,"range":{"start_line":1527,"start_character":23,"end_line":1530,"end_character":34},"in_reply_to":"9e580c91_fc9b7e5d","updated":"2021-03-10 18:16:44.000000000","message":"same","commit_id":"483010dd15d634ce43848608d253cf7fac62a8c8"}],"manila/share/drivers/netapp/options.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"11edbe0ed2e6d02a1e5440af9a7caa1e8f6eac84","unresolved":true,"context_lines":[{"line_number":124,"context_line":"               help\u003d\u0027NetApp SnapMirror policy name template for Storage \u0027"},{"line_number":125,"context_line":"                    \u0027Virtual Machines (Vservers).\u0027,"},{"line_number":126,"context_line":"               default\u003d\u0027snapmirror_policy_%(share_server_id)s\u0027),"},{"line_number":127,"context_line":"    cfg.IntOpt(\u0027netapp_setup_security_service_timeout\u0027,"},{"line_number":128,"context_line":"               min\u003d0,"},{"line_number":129,"context_line":"               default\u003d300,  # 5 minutes,"},{"line_number":130,"context_line":"               help\u003d\u0027The maximum time in seconds to wait for a security \u0027"},{"line_number":131,"context_line":"                    \u0027service to complete its configuration. Currently \u0027"},{"line_number":132,"context_line":"                    \u0027supported only by LDAP security service.\u0027), ]"}],"source_content_type":"text/x-python","patch_set":2,"id":"f3abfcbe_100edaf2","line":129,"range":{"start_line":127,"start_character":10,"end_line":129,"end_character":41},"updated":"2021-03-10 16:40:21.000000000","message":"feels like there\u0027re way too many of this sort of options in manila, and no-one ever gives us feedback if they use them at all. This is one of those cases where we can take a call to not add one imo... \n\nWith default values, the retry decorator allows 10 attempts waiting for ~1000 seconds - maybe we can live with that?\n\nAlso justifies this bug fix to be back ported","commit_id":"483010dd15d634ce43848608d253cf7fac62a8c8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"30f479cae367049b88305eecd98f3512404632cb","unresolved":true,"context_lines":[{"line_number":124,"context_line":"               help\u003d\u0027NetApp SnapMirror policy name template for Storage \u0027"},{"line_number":125,"context_line":"                    \u0027Virtual Machines (Vservers).\u0027,"},{"line_number":126,"context_line":"               default\u003d\u0027snapmirror_policy_%(share_server_id)s\u0027),"},{"line_number":127,"context_line":"    cfg.IntOpt(\u0027netapp_setup_security_service_timeout\u0027,"},{"line_number":128,"context_line":"               min\u003d0,"},{"line_number":129,"context_line":"               default\u003d300,  # 5 minutes,"},{"line_number":130,"context_line":"               help\u003d\u0027The maximum time in seconds to wait for a security \u0027"},{"line_number":131,"context_line":"                    \u0027service to complete its configuration. Currently \u0027"},{"line_number":132,"context_line":"                    \u0027supported only by LDAP security service.\u0027), ]"}],"source_content_type":"text/x-python","patch_set":2,"id":"a47a85ca_a0d51614","line":129,"range":{"start_line":127,"start_character":10,"end_line":129,"end_character":41},"in_reply_to":"f3abfcbe_100edaf2","updated":"2021-03-10 18:16:44.000000000","message":"Yes, this is one that might pollute the list of available options, instead of being useful.","commit_id":"483010dd15d634ce43848608d253cf7fac62a8c8"}],"releasenotes/notes/bug-1916534-netapp-fix-ldap-security-service-c8ee6d36598722cf.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"11edbe0ed2e6d02a1e5440af9a7caa1e8f6eac84","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    `distinguished name` used for LDAP queries can now be configured using"},{"line_number":15,"context_line":"    security service `ou` parameter. Please refer to"},{"line_number":16,"context_line":"    `Launchpad Bug #1916534 \u003chttps://bugs.launchpad.net/manila/+bug/1916534\u003e`_"},{"line_number":17,"context_line":"    for more details."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7927cc06_be1bfa61","line":17,"range":{"start_line":17,"start_character":20,"end_line":17,"end_character":21},"updated":"2021-03-10 16:40:21.000000000","message":"the config opt added needs to be called out in the upgrade section","commit_id":"483010dd15d634ce43848608d253cf7fac62a8c8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8bdcc0404d28e28dff62591ee2433acfadd4f779","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    `distinguished name` used for LDAP queries can now be configured using"},{"line_number":15,"context_line":"    security service `ou` parameter. Please refer to"},{"line_number":16,"context_line":"    `Launchpad Bug #1916534 \u003chttps://bugs.launchpad.net/manila/+bug/1916534\u003e`_"},{"line_number":17,"context_line":"    for more details."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"186e565b_d6809a83","line":17,"range":{"start_line":17,"start_character":20,"end_line":17,"end_character":21},"in_reply_to":"7927cc06_be1bfa61","updated":"2021-03-10 19:08:49.000000000","message":"Config option was removed in PS3","commit_id":"483010dd15d634ce43848608d253cf7fac62a8c8"}]}