)]}'
{"manila/share/drivers/zadara/zadara.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7d3b083e618e4f0ee1b15df6cb91f1403a2b7b5c","unresolved":true,"context_lines":[{"line_number":368,"context_line":"                      \u0027It might be already deleted\u0027, share[\u0027id\u0027])"},{"line_number":369,"context_line":"            return"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        vpsa_srv \u003d self.vpsa._get_server_name(access_ip, True)"},{"line_number":372,"context_line":"        if not vpsa_srv:"},{"line_number":373,"context_line":"            raise manila_exception.ZadaraServerNotFound(name\u003daccess_ip)"},{"line_number":374,"context_line":"        servers_list \u003d self.vpsa._get_servers_attached_to_volume(volume)"},{"line_number":375,"context_line":"        if vpsa_srv not in servers_list:"},{"line_number":376,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"c7b81cfd_4bc2ccb9","line":373,"range":{"start_line":371,"start_character":0,"end_line":373,"end_character":71},"updated":"2021-03-17 06:10:40.000000000","message":"Should this be fatal? Raising an exception here will cause all rules to be set to \"error\". \nIf a rule wasn\u0027t present in the backend you could log it and return...","commit_id":"bb2f27bff1b0ccc959acb94257298c9af71356f2"},{"author":{"_account_id":32880,"name":"Ratnakaram Rajesh","email":"rajesh.r@zadara.com","username":"rratnaka"},"change_message_id":"a543992b24bf35f4bd1d24844d3f5f5d87469cf6","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                      \u0027It might be already deleted\u0027, share[\u0027id\u0027])"},{"line_number":369,"context_line":"            return"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        vpsa_srv \u003d self.vpsa._get_server_name(access_ip, True)"},{"line_number":372,"context_line":"        if not vpsa_srv:"},{"line_number":373,"context_line":"            raise manila_exception.ZadaraServerNotFound(name\u003daccess_ip)"},{"line_number":374,"context_line":"        servers_list \u003d self.vpsa._get_servers_attached_to_volume(volume)"},{"line_number":375,"context_line":"        if vpsa_srv not in servers_list:"},{"line_number":376,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"6c8dd15a_c2f065c2","line":373,"range":{"start_line":371,"start_character":0,"end_line":373,"end_character":71},"in_reply_to":"c7b81cfd_4bc2ccb9","updated":"2021-03-25 15:19:31.000000000","message":"Done","commit_id":"bb2f27bff1b0ccc959acb94257298c9af71356f2"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"70b9ab93d1d7f9d89a3f36aa487e19957dd0dbe9","unresolved":true,"context_lines":[{"line_number":352,"context_line":"        access_type \u003d access[\u0027access_type\u0027]"},{"line_number":353,"context_line":"        if access_type !\u003d \u0027ip\u0027:"},{"line_number":354,"context_line":"            LOG.error(\u0027Only ip access type is allowed for zadara vpsa.\u0027)"},{"line_number":355,"context_line":"            return"},{"line_number":356,"context_line":"        access_ip \u003d access[\u0027access_to\u0027]"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        # First: Check Active controller: if not valid, raise exception"}],"source_content_type":"text/x-python","patch_set":3,"id":"61250aae_7d114dbb","line":355,"range":{"start_line":355,"start_character":12,"end_line":355,"end_character":18},"updated":"2021-03-24 17:54:29.000000000","message":"Observation: you are logging an error, but by not raising an exception, the Share Manager layer will believe your operation completed successfully, therefore you are ignoring the error. In that case, it makes more sense to be a warning, instead of an error.\n\nSince you are deleting a rule that perhaps shouldn\u0027t be there in the first place (in the case of migration, it would have been added due to a different backend, and doesn\u0027t make sense in yours), it makes sense to ignore the error. Therefore warning level should be more appropriate, as this is not an error.","commit_id":"8a31f6d4550ee17a3a2b65ccfb20bbd3b774b396"},{"author":{"_account_id":32880,"name":"Ratnakaram Rajesh","email":"rajesh.r@zadara.com","username":"rratnaka"},"change_message_id":"a543992b24bf35f4bd1d24844d3f5f5d87469cf6","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        access_type \u003d access[\u0027access_type\u0027]"},{"line_number":353,"context_line":"        if access_type !\u003d \u0027ip\u0027:"},{"line_number":354,"context_line":"            LOG.error(\u0027Only ip access type is allowed for zadara vpsa.\u0027)"},{"line_number":355,"context_line":"            return"},{"line_number":356,"context_line":"        access_ip \u003d access[\u0027access_to\u0027]"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        # First: Check Active controller: if not valid, raise exception"}],"source_content_type":"text/x-python","patch_set":3,"id":"94d2649e_803e9b6e","line":355,"range":{"start_line":355,"start_character":12,"end_line":355,"end_character":18},"in_reply_to":"34c3ecf6_6f70a959","updated":"2021-03-25 15:19:31.000000000","message":"Done","commit_id":"8a31f6d4550ee17a3a2b65ccfb20bbd3b774b396"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c34124a59bbf806ffab9f22194e92ed4a72a4960","unresolved":true,"context_lines":[{"line_number":352,"context_line":"        access_type \u003d access[\u0027access_type\u0027]"},{"line_number":353,"context_line":"        if access_type !\u003d \u0027ip\u0027:"},{"line_number":354,"context_line":"            LOG.error(\u0027Only ip access type is allowed for zadara vpsa.\u0027)"},{"line_number":355,"context_line":"            return"},{"line_number":356,"context_line":"        access_ip \u003d access[\u0027access_to\u0027]"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        # First: Check Active controller: if not valid, raise exception"}],"source_content_type":"text/x-python","patch_set":3,"id":"34c3ecf6_6f70a959","line":355,"range":{"start_line":355,"start_character":12,"end_line":355,"end_character":18},"in_reply_to":"61250aae_7d114dbb","updated":"2021-03-24 22:47:44.000000000","message":"+1","commit_id":"8a31f6d4550ee17a3a2b65ccfb20bbd3b774b396"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"70b9ab93d1d7f9d89a3f36aa487e19957dd0dbe9","unresolved":true,"context_lines":[{"line_number":371,"context_line":"        vpsa_srv \u003d self.vpsa._get_server_name(access_ip, True)"},{"line_number":372,"context_line":"        if not vpsa_srv:"},{"line_number":373,"context_line":"            LOG.error(\u0027VPSA server %s could not be found.\u0027, access_ip)"},{"line_number":374,"context_line":"            return"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        servers_list \u003d self.vpsa._get_servers_attached_to_volume(volume)"},{"line_number":377,"context_line":"        if vpsa_srv not in servers_list:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1660396b_8ef8ab65","line":374,"range":{"start_line":374,"start_character":12,"end_line":374,"end_character":18},"updated":"2021-03-24 17:54:29.000000000","message":"same as above","commit_id":"8a31f6d4550ee17a3a2b65ccfb20bbd3b774b396"},{"author":{"_account_id":32880,"name":"Ratnakaram Rajesh","email":"rajesh.r@zadara.com","username":"rratnaka"},"change_message_id":"a543992b24bf35f4bd1d24844d3f5f5d87469cf6","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        vpsa_srv \u003d self.vpsa._get_server_name(access_ip, True)"},{"line_number":372,"context_line":"        if not vpsa_srv:"},{"line_number":373,"context_line":"            LOG.error(\u0027VPSA server %s could not be found.\u0027, access_ip)"},{"line_number":374,"context_line":"            return"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        servers_list \u003d self.vpsa._get_servers_attached_to_volume(volume)"},{"line_number":377,"context_line":"        if vpsa_srv not in servers_list:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fcd512f_5e3af98c","line":374,"range":{"start_line":374,"start_character":12,"end_line":374,"end_character":18},"in_reply_to":"1660396b_8ef8ab65","updated":"2021-03-25 15:19:31.000000000","message":"Done","commit_id":"8a31f6d4550ee17a3a2b65ccfb20bbd3b774b396"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"70b9ab93d1d7f9d89a3f36aa487e19957dd0dbe9","unresolved":true,"context_lines":[{"line_number":378,"context_line":"            LOG.error(\u0027VPSA server %(access_ip)s not attached to volume \u0027"},{"line_number":379,"context_line":"                      \u0027%(volume)s.\u0027,"},{"line_number":380,"context_line":"                      {\u0027access_ip\u0027: access_ip, \u0027volume\u0027: share[\u0027id\u0027]})"},{"line_number":381,"context_line":"            return"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        self.vpsa._detach_vpsa_volume(vpsa_vol\u003dvolume,"},{"line_number":384,"context_line":"                                      vpsa_srv\u003dvpsa_srv)"}],"source_content_type":"text/x-python","patch_set":3,"id":"73f1d441_7a3429f7","line":381,"range":{"start_line":381,"start_character":12,"end_line":381,"end_character":18},"updated":"2021-03-24 17:54:29.000000000","message":"same as above","commit_id":"8a31f6d4550ee17a3a2b65ccfb20bbd3b774b396"},{"author":{"_account_id":32880,"name":"Ratnakaram Rajesh","email":"rajesh.r@zadara.com","username":"rratnaka"},"change_message_id":"a543992b24bf35f4bd1d24844d3f5f5d87469cf6","unresolved":false,"context_lines":[{"line_number":378,"context_line":"            LOG.error(\u0027VPSA server %(access_ip)s not attached to volume \u0027"},{"line_number":379,"context_line":"                      \u0027%(volume)s.\u0027,"},{"line_number":380,"context_line":"                      {\u0027access_ip\u0027: access_ip, \u0027volume\u0027: share[\u0027id\u0027]})"},{"line_number":381,"context_line":"            return"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        self.vpsa._detach_vpsa_volume(vpsa_vol\u003dvolume,"},{"line_number":384,"context_line":"                                      vpsa_srv\u003dvpsa_srv)"}],"source_content_type":"text/x-python","patch_set":3,"id":"d5c77c3d_75f55b0e","line":381,"range":{"start_line":381,"start_character":12,"end_line":381,"end_character":18},"in_reply_to":"73f1d441_7a3429f7","updated":"2021-03-25 15:19:31.000000000","message":"Done","commit_id":"8a31f6d4550ee17a3a2b65ccfb20bbd3b774b396"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"70b9ab93d1d7f9d89a3f36aa487e19957dd0dbe9","unresolved":true,"context_lines":[{"line_number":387,"context_line":"                      delete_rules, share_server\u003dNone):"},{"line_number":388,"context_line":"        access_updates \u003d {}"},{"line_number":389,"context_line":"        if not (add_rules or delete_rules):"},{"line_number":390,"context_line":"            for access_rule in access_rules:"},{"line_number":391,"context_line":"                self._deny_access(context, share, access_rule)"},{"line_number":392,"context_line":"                try:"},{"line_number":393,"context_line":"                    self._allow_access(context, share, access_rule)"}],"source_content_type":"text/x-python","patch_set":3,"id":"85077fe9_b41132f2","line":390,"range":{"start_line":390,"start_character":11,"end_line":390,"end_character":44},"updated":"2021-03-24 17:54:29.000000000","message":"it would be useful to add a brief code comment here just to state that this is a special case for migration, where you want to delete and re-add all the rules.\n\nSource: driver.py docstring:\n\n``add_rules`` and ``delete_rules`` can be empty lists, in this\n        situation, drivers should ensure that the rules present in\n        ``access_rules`` are the same as those on the back end. One scenario\n        where this situation is forced is when the access_level is changed for\n        all existing rules (share migration and for readable replicas).","commit_id":"8a31f6d4550ee17a3a2b65ccfb20bbd3b774b396"},{"author":{"_account_id":32880,"name":"Ratnakaram Rajesh","email":"rajesh.r@zadara.com","username":"rratnaka"},"change_message_id":"a543992b24bf35f4bd1d24844d3f5f5d87469cf6","unresolved":false,"context_lines":[{"line_number":387,"context_line":"                      delete_rules, share_server\u003dNone):"},{"line_number":388,"context_line":"        access_updates \u003d {}"},{"line_number":389,"context_line":"        if not (add_rules or delete_rules):"},{"line_number":390,"context_line":"            for access_rule in access_rules:"},{"line_number":391,"context_line":"                self._deny_access(context, share, access_rule)"},{"line_number":392,"context_line":"                try:"},{"line_number":393,"context_line":"                    self._allow_access(context, share, access_rule)"}],"source_content_type":"text/x-python","patch_set":3,"id":"d5908a3b_5996678a","line":390,"range":{"start_line":390,"start_character":11,"end_line":390,"end_character":44},"in_reply_to":"85077fe9_b41132f2","updated":"2021-03-25 15:19:31.000000000","message":"Done","commit_id":"8a31f6d4550ee17a3a2b65ccfb20bbd3b774b396"}],"releasenotes/notes/bug-1917980-zadara-share-assisted-migration-2d8f8fdb51718faa.yaml":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c34124a59bbf806ffab9f22194e92ed4a72a4960","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed an issue in Zadara driver to support host assisted migration."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a4add720_0b1c7e35","line":4,"updated":"2021-03-24 22:47:44.000000000","message":"Could you add more context on the fix?","commit_id":"8a31f6d4550ee17a3a2b65ccfb20bbd3b774b396"},{"author":{"_account_id":32880,"name":"Ratnakaram Rajesh","email":"rajesh.r@zadara.com","username":"rratnaka"},"change_message_id":"a543992b24bf35f4bd1d24844d3f5f5d87469cf6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed an issue in Zadara driver to support host assisted migration."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9c7d9684_b44fa58f","line":4,"in_reply_to":"a4add720_0b1c7e35","updated":"2021-03-25 15:19:31.000000000","message":"Done","commit_id":"8a31f6d4550ee17a3a2b65ccfb20bbd3b774b396"}]}