)]}'
{"manila/policy.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"234ae99b6ab9357ec0d48cc093071bfc8446414a","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        # defaults have been changed and warning for each policy started"},{"line_number":71,"context_line":"        # filling the log limits for various tools. Once we move to new"},{"line_number":72,"context_line":"        # defaults only world then we can enable these warning again."},{"line_number":73,"context_line":"        _ENFORCER.suppress_default_change_warnings \u003d True"},{"line_number":74,"context_line":"        # Suppressing deprecation warnings is fine for tests. However we"},{"line_number":75,"context_line":"        # won\u0027t do it by default"},{"line_number":76,"context_line":"        _ENFORCER.suppress_deprecation_warnings \u003d suppress_deprecation_warnings"}],"source_content_type":"text/x-python","patch_set":1,"id":"010094e9_867ef16e","line":73,"updated":"2021-03-25 16:51:05.000000000","message":"Can this be controlled by the argument? We set this to True to set it to False immediately in all but the testing case, I think?","commit_id":"163bda5fbe7bf593e255898c66dab1b58fe794a6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aa4a811632c36863b3af8bfe0446bc74e4417586","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        # defaults have been changed and warning for each policy started"},{"line_number":71,"context_line":"        # filling the log limits for various tools. Once we move to new"},{"line_number":72,"context_line":"        # defaults only world then we can enable these warning again."},{"line_number":73,"context_line":"        _ENFORCER.suppress_default_change_warnings \u003d True"},{"line_number":74,"context_line":"        # Suppressing deprecation warnings is fine for tests. However we"},{"line_number":75,"context_line":"        # won\u0027t do it by default"},{"line_number":76,"context_line":"        _ENFORCER.suppress_deprecation_warnings \u003d suppress_deprecation_warnings"}],"source_content_type":"text/x-python","patch_set":1,"id":"0c3c5502_61791b25","line":73,"in_reply_to":"010094e9_867ef16e","updated":"2021-03-25 17:15:09.000000000","message":"Oh, Where do we set it to False after here?","commit_id":"163bda5fbe7bf593e255898c66dab1b58fe794a6"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"db4e8e9b1d9e15793ebf5aa8c4efb519c7dc1db9","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        # defaults have been changed and warning for each policy started"},{"line_number":71,"context_line":"        # filling the log limits for various tools. Once we move to new"},{"line_number":72,"context_line":"        # defaults only world then we can enable these warning again."},{"line_number":73,"context_line":"        _ENFORCER.suppress_default_change_warnings \u003d True"},{"line_number":74,"context_line":"        # Suppressing deprecation warnings is fine for tests. However we"},{"line_number":75,"context_line":"        # won\u0027t do it by default"},{"line_number":76,"context_line":"        _ENFORCER.suppress_deprecation_warnings \u003d suppress_deprecation_warnings"}],"source_content_type":"text/x-python","patch_set":1,"id":"17188e2f_b339b594","line":73,"in_reply_to":"0c3c5502_61791b25","updated":"2021-03-25 19:44:46.000000000","message":"By default, aren\u0027t we setting it to false on line 76?","commit_id":"163bda5fbe7bf593e255898c66dab1b58fe794a6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cf83d5a18dd155ba642705e1eaea9b13d4d5d2e9","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        # defaults have been changed and warning for each policy started"},{"line_number":71,"context_line":"        # filling the log limits for various tools. Once we move to new"},{"line_number":72,"context_line":"        # defaults only world then we can enable these warning again."},{"line_number":73,"context_line":"        _ENFORCER.suppress_default_change_warnings \u003d True"},{"line_number":74,"context_line":"        # Suppressing deprecation warnings is fine for tests. However we"},{"line_number":75,"context_line":"        # won\u0027t do it by default"},{"line_number":76,"context_line":"        _ENFORCER.suppress_deprecation_warnings \u003d suppress_deprecation_warnings"}],"source_content_type":"text/x-python","patch_set":1,"id":"5dd34863_c998c165","line":73,"in_reply_to":"17188e2f_b339b594","updated":"2021-03-25 22:36:52.000000000","message":"These are different though: \n\n\"suppress_default_change_warnings\" allows us to suppress the ones for a changing check string IF an admin hasn\u0027t overriden a given policy and the default behavior is changing - this is practically all of the API policies\nthat we changed this cycle. I can make this optional via a config argument in Xena; but I think for now, since we don\u0027t have all the test coverage and cannot confidently say that the default scopes and roles work with Wallaby, I think these warnings shouldn\u0027t be emitted - it might force admins to override policies or switch to using system/project scopes which we may not want yet:\n\nhttps://github.com/openstack/oslo.policy/blob/d8534850d9238e85ae0ea55bf2ac8583681fdb2b/oslo_policy/policy.py#L542-L547\n\nsuppress_deprecation_warnings is purely for tests - from what I understand it goes all the way and suppresses _any_ policy deprecation, not just where the default check string changes.","commit_id":"163bda5fbe7bf593e255898c66dab1b58fe794a6"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7cbe1c8f928c85b9ca4a792ddce6a3efce0b9450","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        # defaults have been changed and warning for each policy started"},{"line_number":71,"context_line":"        # filling the log limits for various tools. Once we move to new"},{"line_number":72,"context_line":"        # defaults only world then we can enable these warning again."},{"line_number":73,"context_line":"        _ENFORCER.suppress_default_change_warnings \u003d True"},{"line_number":74,"context_line":"        # Suppressing deprecation warnings is fine for tests. However we"},{"line_number":75,"context_line":"        # won\u0027t do it by default"},{"line_number":76,"context_line":"        _ENFORCER.suppress_deprecation_warnings \u003d suppress_deprecation_warnings"}],"source_content_type":"text/x-python","patch_set":1,"id":"649f2647_39c27c86","line":73,"in_reply_to":"5dd34863_c998c165","updated":"2021-03-26 02:26:14.000000000","message":"Oh - I see. I was confused because I thought this variable was being set again on line 76, but they\u0027re two separate variables.\n\nSorry for the confusion and thanks for clarifying.","commit_id":"163bda5fbe7bf593e255898c66dab1b58fe794a6"}]}