)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7316e762a20e4c759f625a56dc7e5b3aad8e3f8a","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Goutham Pacha Ravi \u003cgouthampravi@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-06-24 15:39:59 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds explicit error message"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a user sets a quota that is greater than 2147483647, an"},{"line_number":10,"context_line":"exlicit error message that \"Quota limit should not exceed 2147483647\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"cbbd9a22_fd5d48e4","line":7,"updated":"2021-06-24 18:07:30.000000000","message":"to what? The first line of a commit message is something developers will use in searches, so within space constraints convey as much information useful for such searches as you can.  I should be able to tell just by looking at the first line what the review is about and I can\u0027t really get that information here.","commit_id":"bb008c68d0510450f1b499c731bc29aa2df38bee"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7316e762a20e4c759f625a56dc7e5b3aad8e3f8a","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Adds explicit error message"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a user sets a quota that is greater than 2147483647, an"},{"line_number":10,"context_line":"exlicit error message that \"Quota limit should not exceed 2147483647\""},{"line_number":11,"context_line":"is communicated. This is better with regard to the initial message"},{"line_number":12,"context_line":"which was \"ERROR: The server has either erred or is"},{"line_number":13,"context_line":"incapable of performing the requested operation. (HTTP 500).\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"20c8be38_4083bc47","line":10,"updated":"2021-06-24 18:07:30.000000000","message":"explicit","commit_id":"bb008c68d0510450f1b499c731bc29aa2df38bee"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"586c145408d308e56a99e738f0bdaa6f5b304e34","unresolved":true,"context_lines":[{"line_number":681,"context_line":"        try:"},{"line_number":682,"context_line":"            quota_ref.save(session)"},{"line_number":683,"context_line":"        except Exception as e:"},{"line_number":684,"context_line":"            if \"Out of range value for column \u0027hard_limit\u0027\" in str(e):"},{"line_number":685,"context_line":"                msg \u003d _(\"Quota limit should not exceed 2147483647\")"},{"line_number":686,"context_line":"                raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":687,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"686f770b_10ff1ce9","line":684,"range":{"start_line":684,"start_character":16,"end_line":684,"end_character":69},"updated":"2021-03-24 21:51:38.000000000","message":"\"out of range\" in str(e).lower():","commit_id":"87c02e6fe33b2c04ad787b9bb2999fb718b6fac0"},{"author":{"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"},"change_message_id":"043a31a0d83efb92a8ab7872868d037ce668848f","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        try:"},{"line_number":682,"context_line":"            quota_ref.save(session)"},{"line_number":683,"context_line":"        except Exception as e:"},{"line_number":684,"context_line":"            if \"Out of range value for column \u0027hard_limit\u0027\" in str(e):"},{"line_number":685,"context_line":"                msg \u003d _(\"Quota limit should not exceed 2147483647\")"},{"line_number":686,"context_line":"                raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":687,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"acfcf0b9_bc9a0cbd","line":684,"range":{"start_line":684,"start_character":16,"end_line":684,"end_character":69},"in_reply_to":"686f770b_10ff1ce9","updated":"2021-03-24 22:25:42.000000000","message":"Ack","commit_id":"87c02e6fe33b2c04ad787b9bb2999fb718b6fac0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"586c145408d308e56a99e738f0bdaa6f5b304e34","unresolved":true,"context_lines":[{"line_number":684,"context_line":"            if \"Out of range value for column \u0027hard_limit\u0027\" in str(e):"},{"line_number":685,"context_line":"                msg \u003d _(\"Quota limit should not exceed 2147483647\")"},{"line_number":686,"context_line":"                raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":687,"context_line":"            else:"},{"line_number":688,"context_line":"                raise db_exception.DBError(e)"},{"line_number":689,"context_line":"    return quota_ref"},{"line_number":690,"context_line":""},{"line_number":691,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2ea6703e_c76a890d","line":688,"range":{"start_line":687,"start_character":12,"end_line":688,"end_character":45},"updated":"2021-03-24 21:51:38.000000000","message":"raise","commit_id":"87c02e6fe33b2c04ad787b9bb2999fb718b6fac0"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"f55752e28c73f1270a386bcf8f7021cb2a7da071","unresolved":true,"context_lines":[{"line_number":684,"context_line":"            if \"Out of range value for column \u0027hard_limit\u0027\" in str(e):"},{"line_number":685,"context_line":"                msg \u003d _(\"Quota limit should not exceed 2147483647\")"},{"line_number":686,"context_line":"                raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":687,"context_line":"            else:"},{"line_number":688,"context_line":"                raise db_exception.DBError(e)"},{"line_number":689,"context_line":"    return quota_ref"},{"line_number":690,"context_line":""},{"line_number":691,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"d474581a_21cd38fa","line":688,"range":{"start_line":687,"start_character":12,"end_line":688,"end_character":45},"in_reply_to":"0994e411_79998575","updated":"2021-03-29 20:02:08.000000000","message":"I believe he is suggesting you remove the else and use the raise instruction directly.","commit_id":"87c02e6fe33b2c04ad787b9bb2999fb718b6fac0"},{"author":{"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"},"change_message_id":"043a31a0d83efb92a8ab7872868d037ce668848f","unresolved":true,"context_lines":[{"line_number":684,"context_line":"            if \"Out of range value for column \u0027hard_limit\u0027\" in str(e):"},{"line_number":685,"context_line":"                msg \u003d _(\"Quota limit should not exceed 2147483647\")"},{"line_number":686,"context_line":"                raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":687,"context_line":"            else:"},{"line_number":688,"context_line":"                raise db_exception.DBError(e)"},{"line_number":689,"context_line":"    return quota_ref"},{"line_number":690,"context_line":""},{"line_number":691,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"0994e411_79998575","line":688,"range":{"start_line":687,"start_character":12,"end_line":688,"end_character":45},"in_reply_to":"2ea6703e_c76a890d","updated":"2021-03-24 22:25:42.000000000","message":"raise? What is to be raised here? I don\u0027t quite get it.","commit_id":"87c02e6fe33b2c04ad787b9bb2999fb718b6fac0"},{"author":{"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"},"change_message_id":"47190d35579f14323e4de7662116aa90bcbdd867","unresolved":true,"context_lines":[{"line_number":684,"context_line":"            if \"Out of range value for column \u0027hard_limit\u0027\" in str(e):"},{"line_number":685,"context_line":"                msg \u003d _(\"Quota limit should not exceed 2147483647\")"},{"line_number":686,"context_line":"                raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":687,"context_line":"            else:"},{"line_number":688,"context_line":"                raise db_exception.DBError(e)"},{"line_number":689,"context_line":"    return quota_ref"},{"line_number":690,"context_line":""},{"line_number":691,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"132913fa_b1033d63","line":688,"range":{"start_line":687,"start_character":12,"end_line":688,"end_character":45},"in_reply_to":"d474581a_21cd38fa","updated":"2021-04-02 04:05:50.000000000","message":"Okay, does that mean that both the InvalidInput exception (exception.InvalidInput) and db_exception (db_exception.DBError) are supposed to be raised incase the quota limit exceeds 2147483647? Like how it is in the second patchset?","commit_id":"87c02e6fe33b2c04ad787b9bb2999fb718b6fac0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"39e83de641e0fe2ce2d52e98087e980d59279451","unresolved":true,"context_lines":[{"line_number":684,"context_line":"            if \"out of range\" in str(e).lower():"},{"line_number":685,"context_line":"                msg \u003d _(\"Quota limit should not exceed 2147483647\")"},{"line_number":686,"context_line":"                raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":687,"context_line":"                raise db_exception.DBError(e)"},{"line_number":688,"context_line":"    return quota_ref"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a8ed8b9_7c9e5670","line":687,"range":{"start_line":687,"start_character":16,"end_line":687,"end_character":43},"updated":"2021-03-30 22:16:37.000000000","message":"this has no effect now, you\u0027ve got to move it out of the \"if\" block.\n\n try:\n    quota_ref.save(session)\n except Exception as e:\n    if \"out of range\" in str(e).lower():\n       msg \u003d _(\"Quota limit should not exceed 2147483647\")\n       raise exception.InvalidInput(reason\u003dmsg)\n    raise\n\n\nThe \"raise\" on the last statement, outside of the \"if\" block allows the last exception in the path to be raised. See some examples of exception handling here: https://docs.python.org/3/tutorial/errors.html","commit_id":"034bcf34ff607248b9b7291d67ad7308a32e68ec"}],"manila/tests/api/v2/test_quota_sets.py":[{"author":{"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"},"change_message_id":"3e4483fc26de46e9d63c0916eb6fae6b358c8fa1","unresolved":true,"context_lines":[{"line_number":447,"context_line":"            mock_policy_update_check_call, mock_policy_show_check_call])"},{"line_number":448,"context_line":"        quota_sets.db.share_type_get_by_name_or_id.assert_not_called()"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    @ddt.data(_get_request(True, True), _get_request(True, False))"},{"line_number":451,"context_line":"    def test_update_quota_with_value_greater_than_2147483647(self, req):"},{"line_number":452,"context_line":"        value \u003d 2147483648"},{"line_number":453,"context_line":"        body \u003d {\u0027quota_set\u0027: {\u0027tenant_id\u0027: self.project_id, \u0027shares\u0027: value}}"}],"source_content_type":"text/x-python","patch_set":4,"id":"31f808b6_a8763a53","line":450,"updated":"2021-04-09 17:33:03.000000000","message":"Goutham, here is the test.\nWhen the _get_request is (True,True) it passes. However, when it is (True,False), it fails.\nWhat could be the reason?","commit_id":"31407bfa6050dc4b5d5b86a49e8799beb43ff46e"}]}