)]}'
{"manila/share/api.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"903bf5342155dfbaa9d0c395a8a4a3669ad6ddb7","unresolved":true,"context_lines":[{"line_number":1019,"context_line":"        return snapshot"},{"line_number":1020,"context_line":""},{"line_number":1021,"context_line":"    def unmanage_snapshot(self, context, snapshot, host):"},{"line_number":1022,"context_line":"        if snapshot[\u0027status\u0027] \u003d\u003d constants.STATUS_MANAGE_ERROR:"},{"line_number":1023,"context_line":"            update_status \u003d constants.STATUS_MANAGE_ERROR_UNMANAGING"},{"line_number":1024,"context_line":"        else:"},{"line_number":1025,"context_line":"            update_status \u003d constants.STATUS_UNMANAGING"}],"source_content_type":"text/x-python","patch_set":3,"id":"3879dbcd_3a2e21c0","line":1022,"range":{"start_line":1022,"start_character":8,"end_line":1022,"end_character":63},"updated":"2021-04-08 11:25:36.000000000","message":"do we need to distinguish the state when delete snapshot?","commit_id":"cb30c36a9ab0fc4b43e42700669b5fd10e875ed6"},{"author":{"_account_id":30384,"name":"zhangboye","email":"zhangby09@chinatelecom.cn","username":"zhangboye"},"change_message_id":"6ebff61722cfb4453df14c4226b2d494dc1885d0","unresolved":true,"context_lines":[{"line_number":1019,"context_line":"        return snapshot"},{"line_number":1020,"context_line":""},{"line_number":1021,"context_line":"    def unmanage_snapshot(self, context, snapshot, host):"},{"line_number":1022,"context_line":"        if snapshot[\u0027status\u0027] \u003d\u003d constants.STATUS_MANAGE_ERROR:"},{"line_number":1023,"context_line":"            update_status \u003d constants.STATUS_MANAGE_ERROR_UNMANAGING"},{"line_number":1024,"context_line":"        else:"},{"line_number":1025,"context_line":"            update_status \u003d constants.STATUS_UNMANAGING"}],"source_content_type":"text/x-python","patch_set":3,"id":"22032941_97410e29","line":1022,"range":{"start_line":1022,"start_character":8,"end_line":1022,"end_character":63},"in_reply_to":"3879dbcd_3a2e21c0","updated":"2021-04-13 08:36:41.000000000","message":"ok,thanks for your suggestion. I will recheck it.","commit_id":"cb30c36a9ab0fc4b43e42700669b5fd10e875ed6"}],"manila/share/manager.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"903bf5342155dfbaa9d0c395a8a4a3669ad6ddb7","unresolved":true,"context_lines":[{"line_number":2827,"context_line":"                )"},{"line_number":2828,"context_line":""},{"line_number":2829,"context_line":"            if not snapshot_update.get(\u0027size\u0027):"},{"line_number":2830,"context_line":"                # NOTE(zhangboye)if failed to get real size of share_snapshot,"},{"line_number":2831,"context_line":"                # will not commit quota usages."},{"line_number":2832,"context_line":"                msg \u003d _(\"Driver cannot calculate share_snapshot size.\")"},{"line_number":2833,"context_line":"                raise exception.InvalidShareSnapshot(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"46f84915_1ab78a81","line":2830,"updated":"2021-04-08 11:25:36.000000000","message":"if we can not get size of snapshot from driver, we can use size of source share. we better not\nraise here.","commit_id":"cb30c36a9ab0fc4b43e42700669b5fd10e875ed6"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"903bf5342155dfbaa9d0c395a8a4a3669ad6ddb7","unresolved":true,"context_lines":[{"line_number":2832,"context_line":"                msg \u003d _(\"Driver cannot calculate share_snapshot size.\")"},{"line_number":2833,"context_line":"                raise exception.InvalidShareSnapshot(reason\u003dmsg)"},{"line_number":2834,"context_line":""},{"line_number":2835,"context_line":"            self._update_quota_usages(context, project_id, {"},{"line_number":2836,"context_line":"                \"snapshots\": 1,"},{"line_number":2837,"context_line":"                \"snapshot_gigabytes\": snapshot_update[\u0027size\u0027],"},{"line_number":2838,"context_line":"            })"}],"source_content_type":"text/x-python","patch_set":3,"id":"1e73fa8f_4cc4c5ce","line":2835,"range":{"start_line":2835,"start_character":12,"end_line":2835,"end_character":57},"updated":"2021-04-08 11:25:36.000000000","message":"if something go wrong below, can not _update_quota_usages here, or rollback later","commit_id":"cb30c36a9ab0fc4b43e42700669b5fd10e875ed6"}]}