)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ac55650232e563814d58588561d3145c246c0c88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2038d09a_3c215b9a","updated":"2021-11-26 15:23:08.000000000","message":"Thank you for the reviews, folks!\nPlease check the changes and answers inline","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"2639b05a5786b15f0afcc1c6402a6891597de377","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bdef4d50_bbc442d7","updated":"2021-11-05 09:26:51.000000000","message":"Thanks Carlos, some comments inline","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"91e1b9220fff9e2d724b11d0c900a4ee47650aa8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"985026de_7357b085","updated":"2021-11-05 06:04:06.000000000","message":"hi, Carlos and goutham\nthanks for your change,\nhere are some comments inline. please check it.\n","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"aa7f34e36c7e1ec5d048b73d9a589094bf7b1d78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"463d7124_0be59049","updated":"2021-12-02 01:07:03.000000000","message":"LGTM","commit_id":"eab74b580873f5761b4df48066ff8c3012755405"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"996e1e38f07d04df7caf918fc01cc69954724d1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fd1fe84f_54120b97","updated":"2021-12-06 13:35:48.000000000","message":"Thank you for reviewing, Goutham!\nAddressed the changes wrt your comments... Please check them inline :)","commit_id":"eab74b580873f5761b4df48066ff8c3012755405"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e0ee5f4adc2478033ccc943ed70b51684b46359","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b47a0e44_af60c16f","updated":"2021-12-04 18:37:19.000000000","message":"Thanks for your patience with this Carlos; i added several comments inline, please take a look!","commit_id":"eab74b580873f5761b4df48066ff8c3012755405"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"1a326bca7cc82f9965ccdccdb8445b82d5ace828","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1021fd6a_af5bd72c","updated":"2021-12-02 14:57:39.000000000","message":"run Pure Storage CI","commit_id":"eab74b580873f5761b4df48066ff8c3012755405"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"fb623d771973553a0afa66a822e3f7867f4d3603","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ad40a936_40b4dab5","updated":"2021-12-08 01:09:09.000000000","message":"LGTM","commit_id":"40da25f286b4da698d34a89fb44539b50fc2d39f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e98543242f104745dc9731fdfdfa0deda4c2f7fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2b329c21_39ec90ae","updated":"2021-12-06 23:50:47.000000000","message":"LGTM thank you for the changes. ","commit_id":"40da25f286b4da698d34a89fb44539b50fc2d39f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f13ec8fc7b64b66b9df81cc39cb9a2d43d19d39f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"15ac7687_2fc32f5b","updated":"2021-12-06 22:13:50.000000000","message":"Thanks for revisiting, Goutham. Please check answers and changes inline :)","commit_id":"40da25f286b4da698d34a89fb44539b50fc2d39f"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"2639b05a5786b15f0afcc1c6402a6891597de377","unresolved":true,"context_lines":[{"line_number":1238,"context_line":"  type: string"},{"line_number":1239,"context_line":"hosts_check_result:"},{"line_number":1240,"context_line":"  description: |"},{"line_number":1241,"context_line":"    Result received from each host in a check operation."},{"line_number":1242,"context_line":"  in: body"},{"line_number":1243,"context_line":"  required: true"},{"line_number":1244,"context_line":"  type: object"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0624f88c_f52e8776","line":1241,"range":{"start_line":1241,"start_character":40,"end_line":1241,"end_character":55},"updated":"2021-11-05 09:26:51.000000000","message":"\u0027security service update check operation\u0027\n\nnot sure if need to be succinct here :)","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ac55650232e563814d58588561d3145c246c0c88","unresolved":false,"context_lines":[{"line_number":1238,"context_line":"  type: string"},{"line_number":1239,"context_line":"hosts_check_result:"},{"line_number":1240,"context_line":"  description: |"},{"line_number":1241,"context_line":"    Result received from each host in a check operation."},{"line_number":1242,"context_line":"  in: body"},{"line_number":1243,"context_line":"  required: true"},{"line_number":1244,"context_line":"  type: object"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"171eaa9c_826409c4","line":1241,"range":{"start_line":1241,"start_character":40,"end_line":1241,"end_character":55},"in_reply_to":"0624f88c_f52e8776","updated":"2021-11-26 15:23:08.000000000","message":"Done","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"2639b05a5786b15f0afcc1c6402a6891597de377","unresolved":true,"context_lines":[{"line_number":1733,"context_line":"operation_is_compatible:"},{"line_number":1734,"context_line":"  description: |"},{"line_number":1735,"context_line":"    Indicates the result of a check operation. If ``True``, means that all"},{"line_number":1736,"context_line":"    share backends that would be involved in the proccess can hold such"},{"line_number":1737,"context_line":"    operation."},{"line_number":1738,"context_line":"  in: body"},{"line_number":1739,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"001a5652_07360673","line":1736,"range":{"start_line":1736,"start_character":4,"end_line":1736,"end_character":41},"updated":"2021-11-05 09:26:51.000000000","message":"yeah, nice, better then talking about share servers and details...","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ac55650232e563814d58588561d3145c246c0c88","unresolved":false,"context_lines":[{"line_number":1733,"context_line":"operation_is_compatible:"},{"line_number":1734,"context_line":"  description: |"},{"line_number":1735,"context_line":"    Indicates the result of a check operation. If ``True``, means that all"},{"line_number":1736,"context_line":"    share backends that would be involved in the proccess can hold such"},{"line_number":1737,"context_line":"    operation."},{"line_number":1738,"context_line":"  in: body"},{"line_number":1739,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"efdbb1b0_c1a8e507","line":1736,"range":{"start_line":1736,"start_character":4,"end_line":1736,"end_character":41},"in_reply_to":"001a5652_07360673","updated":"2021-11-26 15:23:08.000000000","message":":)","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"91e1b9220fff9e2d724b11d0c900a4ee47650aa8","unresolved":true,"context_lines":[{"line_number":2191,"context_line":"requested_operation_name:"},{"line_number":2192,"context_line":"  description: |"},{"line_number":2193,"context_line":"    The name of the check operation that was triggered in manila, being"},{"line_number":2194,"context_line":"    ``add_security_service`` or ``check_security_service``."},{"line_number":2195,"context_line":"  in: body"},{"line_number":2196,"context_line":"  required: true"},{"line_number":2197,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b0a6572e_4d5615cb","line":2194,"range":{"start_line":2194,"start_character":34,"end_line":2194,"end_character":39},"updated":"2021-11-05 06:04:06.000000000","message":"should be update, there is no \"check_security_service\" in manila.\nmanila/api/views/share_networks.py#43-45","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ac55650232e563814d58588561d3145c246c0c88","unresolved":false,"context_lines":[{"line_number":2191,"context_line":"requested_operation_name:"},{"line_number":2192,"context_line":"  description: |"},{"line_number":2193,"context_line":"    The name of the check operation that was triggered in manila, being"},{"line_number":2194,"context_line":"    ``add_security_service`` or ``check_security_service``."},{"line_number":2195,"context_line":"  in: body"},{"line_number":2196,"context_line":"  required: true"},{"line_number":2197,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6620cfb7_c1cedc31","line":2194,"range":{"start_line":2194,"start_character":34,"end_line":2194,"end_character":39},"in_reply_to":"b0a6572e_4d5615cb","updated":"2021-11-26 15:23:08.000000000","message":"Done","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"2639b05a5786b15f0afcc1c6402a6891597de377","unresolved":true,"context_lines":[{"line_number":2207,"context_line":"reset_operation:"},{"line_number":2208,"context_line":"  description: |"},{"line_number":2209,"context_line":"    Whether a share network security service check update or add operation for"},{"line_number":2210,"context_line":"    a given share server should ignore previous check results, and query all"},{"line_number":2211,"context_line":"    enable share backends again or not."},{"line_number":2212,"context_line":"  in: body"},{"line_number":2213,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7471568f_1a1a1a8d","line":2210,"range":{"start_line":2210,"start_character":12,"end_line":2210,"end_character":24},"updated":"2021-11-05 09:26:51.000000000","message":"share network","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ac55650232e563814d58588561d3145c246c0c88","unresolved":false,"context_lines":[{"line_number":2207,"context_line":"reset_operation:"},{"line_number":2208,"context_line":"  description: |"},{"line_number":2209,"context_line":"    Whether a share network security service check update or add operation for"},{"line_number":2210,"context_line":"    a given share server should ignore previous check results, and query all"},{"line_number":2211,"context_line":"    enable share backends again or not."},{"line_number":2212,"context_line":"  in: body"},{"line_number":2213,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"69f2989e_95b222bd","line":2210,"range":{"start_line":2210,"start_character":12,"end_line":2210,"end_character":24},"in_reply_to":"7471568f_1a1a1a8d","updated":"2021-11-26 15:23:08.000000000","message":"Done","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"2639b05a5786b15f0afcc1c6402a6891597de377","unresolved":true,"context_lines":[{"line_number":2345,"context_line":"  type: string"},{"line_number":2346,"context_line":"security_service_update_support:"},{"line_number":2347,"context_line":"  description: |"},{"line_number":2348,"context_line":"    Whether a share server supports security service updates or not."},{"line_number":2349,"context_line":"  in: body"},{"line_number":2350,"context_line":"  required: true"},{"line_number":2351,"context_line":"  type: boolean"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"784c2297_00d51dd0","line":2348,"range":{"start_line":2348,"start_character":20,"end_line":2348,"end_character":26},"updated":"2021-11-05 09:26:51.000000000","message":"\u0027network\u0027\nunderneath we know that are all share servers associated to a share network.","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ac55650232e563814d58588561d3145c246c0c88","unresolved":false,"context_lines":[{"line_number":2345,"context_line":"  type: string"},{"line_number":2346,"context_line":"security_service_update_support:"},{"line_number":2347,"context_line":"  description: |"},{"line_number":2348,"context_line":"    Whether a share server supports security service updates or not."},{"line_number":2349,"context_line":"  in: body"},{"line_number":2350,"context_line":"  required: true"},{"line_number":2351,"context_line":"  type: boolean"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1d8708b8_a16aabd6","line":2348,"range":{"start_line":2348,"start_character":20,"end_line":2348,"end_character":26},"in_reply_to":"784c2297_00d51dd0","updated":"2021-11-26 15:23:08.000000000","message":"Done","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"2639b05a5786b15f0afcc1c6402a6891597de377","unresolved":true,"context_lines":[{"line_number":2668,"context_line":"  type: string"},{"line_number":2669,"context_line":"share_network_security_service_update_support:"},{"line_number":2670,"context_line":"  description: |"},{"line_number":2671,"context_line":"    Whether all share servers within the share network support updating a"},{"line_number":2672,"context_line":"    security service when a share network is already being used or not."},{"line_number":2673,"context_line":"  in: body"},{"line_number":2674,"context_line":"  required: true"},{"line_number":2675,"context_line":"  type: boolean"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9e238894_73aea94d","line":2672,"range":{"start_line":2671,"start_character":4,"end_line":2672,"end_character":71},"updated":"2021-11-05 09:26:51.000000000","message":"we could think on simplify to \u0027Whether the share network supports updating....\u0027, maybe? I think that there are more variable then share server support, like shares and share-networks status. But also works","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ac55650232e563814d58588561d3145c246c0c88","unresolved":false,"context_lines":[{"line_number":2668,"context_line":"  type: string"},{"line_number":2669,"context_line":"share_network_security_service_update_support:"},{"line_number":2670,"context_line":"  description: |"},{"line_number":2671,"context_line":"    Whether all share servers within the share network support updating a"},{"line_number":2672,"context_line":"    security service when a share network is already being used or not."},{"line_number":2673,"context_line":"  in: body"},{"line_number":2674,"context_line":"  required: true"},{"line_number":2675,"context_line":"  type: boolean"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b3245385_c665d6d5","line":2672,"range":{"start_line":2671,"start_character":4,"end_line":2672,"end_character":71},"in_reply_to":"9e238894_73aea94d","updated":"2021-11-26 15:23:08.000000000","message":"Yeah, I tried to simplify this sentence... I believe we can be more brief here as you mentioned :)","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e0ee5f4adc2478033ccc943ed70b51684b46359","unresolved":true,"context_lines":[{"line_number":883,"context_line":"  type: string"},{"line_number":884,"context_line":"current_share_network_security_service_id:"},{"line_number":885,"context_line":"  description: |"},{"line_number":886,"context_line":"    The id of a security service that is currently attached to a share network."},{"line_number":887,"context_line":"  in: body"},{"line_number":888,"context_line":"  required: true"},{"line_number":889,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b4c67b86_2edf201c","line":886,"range":{"start_line":886,"start_character":8,"end_line":886,"end_character":10},"updated":"2021-12-04 18:37:19.000000000","message":"ID","commit_id":"eab74b580873f5761b4df48066ff8c3012755405"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"996e1e38f07d04df7caf918fc01cc69954724d1c","unresolved":false,"context_lines":[{"line_number":883,"context_line":"  type: string"},{"line_number":884,"context_line":"current_share_network_security_service_id:"},{"line_number":885,"context_line":"  description: |"},{"line_number":886,"context_line":"    The id of a security service that is currently attached to a share network."},{"line_number":887,"context_line":"  in: body"},{"line_number":888,"context_line":"  required: true"},{"line_number":889,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"4cfce679_27a6eb23","line":886,"range":{"start_line":886,"start_character":8,"end_line":886,"end_character":10},"in_reply_to":"b4c67b86_2edf201c","updated":"2021-12-06 13:35:48.000000000","message":"Done","commit_id":"eab74b580873f5761b4df48066ff8c3012755405"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e0ee5f4adc2478033ccc943ed70b51684b46359","unresolved":true,"context_lines":[{"line_number":1238,"context_line":"  type: string"},{"line_number":1239,"context_line":"hosts_check_result:"},{"line_number":1240,"context_line":"  description: |"},{"line_number":1241,"context_line":"    Result received from each host in a security service update check"},{"line_number":1242,"context_line":"    operation."},{"line_number":1243,"context_line":"  in: body"},{"line_number":1244,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"47b22c11_fc957166","line":1241,"range":{"start_line":1241,"start_character":4,"end_line":1241,"end_character":10},"updated":"2021-12-04 18:37:19.000000000","message":"add prefix: (Admin Only)","commit_id":"eab74b580873f5761b4df48066ff8c3012755405"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"996e1e38f07d04df7caf918fc01cc69954724d1c","unresolved":false,"context_lines":[{"line_number":1238,"context_line":"  type: string"},{"line_number":1239,"context_line":"hosts_check_result:"},{"line_number":1240,"context_line":"  description: |"},{"line_number":1241,"context_line":"    Result received from each host in a security service update check"},{"line_number":1242,"context_line":"    operation."},{"line_number":1243,"context_line":"  in: body"},{"line_number":1244,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5a6448fb_e3b7798e","line":1241,"range":{"start_line":1241,"start_character":4,"end_line":1241,"end_character":10},"in_reply_to":"47b22c11_fc957166","updated":"2021-12-06 13:35:48.000000000","message":"Done","commit_id":"eab74b580873f5761b4df48066ff8c3012755405"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e0ee5f4adc2478033ccc943ed70b51684b46359","unresolved":true,"context_lines":[{"line_number":1674,"context_line":"  type: string"},{"line_number":1675,"context_line":"new_share_network_security_service_id:"},{"line_number":1676,"context_line":"  description: |"},{"line_number":1677,"context_line":"    The id of a security service that is intended to be attached to a share"},{"line_number":1678,"context_line":"    network after a share network security service update operation."},{"line_number":1679,"context_line":"  in: body"},{"line_number":1680,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f696cfd_7db0ffe9","line":1677,"range":{"start_line":1677,"start_character":8,"end_line":1677,"end_character":10},"updated":"2021-12-04 18:37:19.000000000","message":"ID","commit_id":"eab74b580873f5761b4df48066ff8c3012755405"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e0ee5f4adc2478033ccc943ed70b51684b46359","unresolved":true,"context_lines":[{"line_number":1674,"context_line":"  type: string"},{"line_number":1675,"context_line":"new_share_network_security_service_id:"},{"line_number":1676,"context_line":"  description: |"},{"line_number":1677,"context_line":"    The id of a security service that is intended to be attached to a share"},{"line_number":1678,"context_line":"    network after a share network security service update operation."},{"line_number":1679,"context_line":"  in: body"},{"line_number":1680,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6b285490_8262459e","line":1677,"range":{"start_line":1677,"start_character":38,"end_line":1677,"end_character":52},"updated":"2021-12-04 18:37:19.000000000","message":"must","commit_id":"eab74b580873f5761b4df48066ff8c3012755405"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"996e1e38f07d04df7caf918fc01cc69954724d1c","unresolved":false,"context_lines":[{"line_number":1674,"context_line":"  type: string"},{"line_number":1675,"context_line":"new_share_network_security_service_id:"},{"line_number":1676,"context_line":"  description: |"},{"line_number":1677,"context_line":"    The id of a security service that is intended to be attached to a share"},{"line_number":1678,"context_line":"    network after a share network security service update operation."},{"line_number":1679,"context_line":"  in: body"},{"line_number":1680,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e73c3087_4724e577","line":1677,"range":{"start_line":1677,"start_character":38,"end_line":1677,"end_character":52},"in_reply_to":"6b285490_8262459e","updated":"2021-12-06 13:35:48.000000000","message":"Done","commit_id":"eab74b580873f5761b4df48066ff8c3012755405"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"996e1e38f07d04df7caf918fc01cc69954724d1c","unresolved":false,"context_lines":[{"line_number":1674,"context_line":"  type: string"},{"line_number":1675,"context_line":"new_share_network_security_service_id:"},{"line_number":1676,"context_line":"  description: |"},{"line_number":1677,"context_line":"    The id of a security service that is intended to be attached to a share"},{"line_number":1678,"context_line":"    network after a share network security service update operation."},{"line_number":1679,"context_line":"  in: body"},{"line_number":1680,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8f52fe64_5b37ab22","line":1677,"range":{"start_line":1677,"start_character":8,"end_line":1677,"end_character":10},"in_reply_to":"7f696cfd_7db0ffe9","updated":"2021-12-06 13:35:48.000000000","message":"Done","commit_id":"eab74b580873f5761b4df48066ff8c3012755405"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e0ee5f4adc2478033ccc943ed70b51684b46359","unresolved":true,"context_lines":[{"line_number":1733,"context_line":"  type: boolean"},{"line_number":1734,"context_line":"operation_is_compatible:"},{"line_number":1735,"context_line":"  description: |"},{"line_number":1736,"context_line":"    Indicates the result of a check operation. If ``True``, means that all"},{"line_number":1737,"context_line":"    share backends that would be involved in the proccess can hold such"},{"line_number":1738,"context_line":"    operation."},{"line_number":1739,"context_line":"  in: body"},{"line_number":1740,"context_line":"  required: true"},{"line_number":1741,"context_line":"  type: boolean"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"c72fc382_66408e1a","line":1738,"range":{"start_line":1736,"start_character":47,"end_line":1738,"end_character":14},"updated":"2021-12-04 18:37:19.000000000","message":"``True`` indicates that the addition/update of security service is possible.","commit_id":"eab74b580873f5761b4df48066ff8c3012755405"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"996e1e38f07d04df7caf918fc01cc69954724d1c","unresolved":false,"context_lines":[{"line_number":1733,"context_line":"  type: boolean"},{"line_number":1734,"context_line":"operation_is_compatible:"},{"line_number":1735,"context_line":"  description: |"},{"line_number":1736,"context_line":"    Indicates the result of a check operation. If ``True``, means that all"},{"line_number":1737,"context_line":"    share backends that would be involved in the proccess can hold such"},{"line_number":1738,"context_line":"    operation."},{"line_number":1739,"context_line":"  in: body"},{"line_number":1740,"context_line":"  required: true"},{"line_number":1741,"context_line":"  type: boolean"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"549588b7_5494b013","line":1738,"range":{"start_line":1736,"start_character":47,"end_line":1738,"end_character":14},"in_reply_to":"c72fc382_66408e1a","updated":"2021-12-06 13:35:48.000000000","message":"Done","commit_id":"eab74b580873f5761b4df48066ff8c3012755405"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e0ee5f4adc2478033ccc943ed70b51684b46359","unresolved":true,"context_lines":[{"line_number":2191,"context_line":"  type: object"},{"line_number":2192,"context_line":"requested_operation_name:"},{"line_number":2193,"context_line":"  description: |"},{"line_number":2194,"context_line":"    The name of the check operation that was triggered in manila, being"},{"line_number":2195,"context_line":"    ``add_security_service`` or ``update_security_service``."},{"line_number":2196,"context_line":"  in: body"},{"line_number":2197,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"302a4789_a33cb1ec","line":2194,"range":{"start_line":2194,"start_character":55,"end_line":2194,"end_character":64},"updated":"2021-12-04 18:37:19.000000000","message":"remove","commit_id":"eab74b580873f5761b4df48066ff8c3012755405"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"996e1e38f07d04df7caf918fc01cc69954724d1c","unresolved":false,"context_lines":[{"line_number":2191,"context_line":"  type: object"},{"line_number":2192,"context_line":"requested_operation_name:"},{"line_number":2193,"context_line":"  description: |"},{"line_number":2194,"context_line":"    The name of the check operation that was triggered in manila, being"},{"line_number":2195,"context_line":"    ``add_security_service`` or ``update_security_service``."},{"line_number":2196,"context_line":"  in: body"},{"line_number":2197,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"36ecf392_bc7994fa","line":2194,"range":{"start_line":2194,"start_character":55,"end_line":2194,"end_character":64},"in_reply_to":"302a4789_a33cb1ec","updated":"2021-12-06 13:35:48.000000000","message":"Done","commit_id":"eab74b580873f5761b4df48066ff8c3012755405"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e0ee5f4adc2478033ccc943ed70b51684b46359","unresolved":true,"context_lines":[{"line_number":2208,"context_line":"reset_operation:"},{"line_number":2209,"context_line":"  description: |"},{"line_number":2210,"context_line":"    Whether a share network security service check update or add operation for"},{"line_number":2211,"context_line":"    a given share network should ignore previous check results, and query all"},{"line_number":2212,"context_line":"    enable share backends again or not."},{"line_number":2213,"context_line":"  in: body"},{"line_number":2214,"context_line":"  required: true"},{"line_number":2215,"context_line":"  type: boolean"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"13e1c953_0e5f1c65","line":2212,"range":{"start_line":2211,"start_character":68,"end_line":2212,"end_character":39},"updated":"2021-12-04 18:37:19.000000000","message":"check the operation\u0027s compatibility again.","commit_id":"eab74b580873f5761b4df48066ff8c3012755405"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"996e1e38f07d04df7caf918fc01cc69954724d1c","unresolved":false,"context_lines":[{"line_number":2208,"context_line":"reset_operation:"},{"line_number":2209,"context_line":"  description: |"},{"line_number":2210,"context_line":"    Whether a share network security service check update or add operation for"},{"line_number":2211,"context_line":"    a given share network should ignore previous check results, and query all"},{"line_number":2212,"context_line":"    enable share backends again or not."},{"line_number":2213,"context_line":"  in: body"},{"line_number":2214,"context_line":"  required: true"},{"line_number":2215,"context_line":"  type: boolean"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"80952f11_9b1bb0a2","line":2212,"range":{"start_line":2211,"start_character":68,"end_line":2212,"end_character":39},"in_reply_to":"13e1c953_0e5f1c65","updated":"2021-12-06 13:35:48.000000000","message":"Done","commit_id":"eab74b580873f5761b4df48066ff8c3012755405"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e0ee5f4adc2478033ccc943ed70b51684b46359","unresolved":true,"context_lines":[{"line_number":2346,"context_line":"  type: string"},{"line_number":2347,"context_line":"security_service_update_support:"},{"line_number":2348,"context_line":"  description: |"},{"line_number":2349,"context_line":"    Whether a share network supports security service updates or not."},{"line_number":2350,"context_line":"  in: body"},{"line_number":2351,"context_line":"  required: true"},{"line_number":2352,"context_line":"  type: boolean"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9de268b3_f262fb65","line":2349,"range":{"start_line":2349,"start_character":20,"end_line":2349,"end_character":27},"updated":"2021-12-04 18:37:19.000000000","message":"network or server","commit_id":"eab74b580873f5761b4df48066ff8c3012755405"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"996e1e38f07d04df7caf918fc01cc69954724d1c","unresolved":false,"context_lines":[{"line_number":2346,"context_line":"  type: string"},{"line_number":2347,"context_line":"security_service_update_support:"},{"line_number":2348,"context_line":"  description: |"},{"line_number":2349,"context_line":"    Whether a share network supports security service updates or not."},{"line_number":2350,"context_line":"  in: body"},{"line_number":2351,"context_line":"  required: true"},{"line_number":2352,"context_line":"  type: boolean"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dba65ff1_cb07addf","line":2349,"range":{"start_line":2349,"start_character":20,"end_line":2349,"end_character":27},"in_reply_to":"9de268b3_f262fb65","updated":"2021-12-06 13:35:48.000000000","message":"Done","commit_id":"eab74b580873f5761b4df48066ff8c3012755405"}],"api-ref/source/samples/share-network-add-security-service-check-response.json":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"2639b05a5786b15f0afcc1c6402a6891597de377","unresolved":true,"context_lines":[{"line_number":6,"context_line":"        \"new_security_service\": \"8971c5f6-52ec-4c53-bf6a-3fae38a9221e\""},{"line_number":7,"context_line":"    },"},{"line_number":8,"context_line":"    \"hosts_check_result\": {"},{"line_number":9,"context_line":"        \"ubuntu@dummy2\": null"},{"line_number":10,"context_line":"    }"},{"line_number":11,"context_line":"}"}],"source_content_type":"application/json","patch_set":2,"id":"afa3568b_09c35a9e","line":9,"range":{"start_line":9,"start_character":25,"end_line":9,"end_character":29},"updated":"2021-11-05 09:26:51.000000000","message":"if compatible is \u0027true\u0027, shouldn\u0027t this host already reported that supports?","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ac55650232e563814d58588561d3145c246c0c88","unresolved":false,"context_lines":[{"line_number":6,"context_line":"        \"new_security_service\": \"8971c5f6-52ec-4c53-bf6a-3fae38a9221e\""},{"line_number":7,"context_line":"    },"},{"line_number":8,"context_line":"    \"hosts_check_result\": {"},{"line_number":9,"context_line":"        \"ubuntu@dummy2\": null"},{"line_number":10,"context_line":"    }"},{"line_number":11,"context_line":"}"}],"source_content_type":"application/json","patch_set":2,"id":"b3884e95_863412f4","line":9,"range":{"start_line":9,"start_character":25,"end_line":9,"end_character":29},"in_reply_to":"afa3568b_09c35a9e","updated":"2021-11-26 15:23:08.000000000","message":"yeah, it\u0027s supposed to be true. thanks!","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"}],"api-ref/source/samples/share-network-update-security-service-check-response.json":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"2639b05a5786b15f0afcc1c6402a6891597de377","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"compatible\": null,"},{"line_number":3,"context_line":"    \"requested_operation\": {"},{"line_number":4,"context_line":"        \"operation\": \"update_security_service\","},{"line_number":5,"context_line":"        \"current_security_service\": \"8971c5f6-52ec-4c53-bf6a-3fae38a9221e\","}],"source_content_type":"application/json","patch_set":2,"id":"b7246069_70d47174","line":2,"range":{"start_line":2,"start_character":18,"end_line":2,"end_character":22},"updated":"2021-11-05 09:26:51.000000000","message":"shuldn\u0027t be true? since all hosts are \u0027true\u0027?","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ac55650232e563814d58588561d3145c246c0c88","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"compatible\": null,"},{"line_number":3,"context_line":"    \"requested_operation\": {"},{"line_number":4,"context_line":"        \"operation\": \"update_security_service\","},{"line_number":5,"context_line":"        \"current_security_service\": \"8971c5f6-52ec-4c53-bf6a-3fae38a9221e\","}],"source_content_type":"application/json","patch_set":2,"id":"52591958_ef78b60c","line":2,"range":{"start_line":2,"start_character":18,"end_line":2,"end_character":22},"in_reply_to":"b7246069_70d47174","updated":"2021-11-26 15:23:08.000000000","message":"yes, it is! thanks","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"}],"api-ref/source/share-networks.inc":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"91e1b9220fff9e2d724b11d0c900a4ee47650aa8","unresolved":true,"context_lines":[{"line_number":585,"context_line":".. versionadded:: 2.63"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"Replaces a security service in a share network. Both current and the new"},{"line_number":588,"context_line":"security service must have the same type."},{"line_number":589,"context_line":""},{"line_number":590,"context_line":".. important::"},{"line_number":591,"context_line":"    Before calling the update share network security service API, make sure"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"eb1a9210_14606504","line":588,"range":{"start_line":588,"start_character":40,"end_line":588,"end_character":41},"updated":"2021-11-05 06:04:06.000000000","message":",current share network must has capability of security_service_update_support while it has shares, and all share servers of current share network must be active.","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ac55650232e563814d58588561d3145c246c0c88","unresolved":false,"context_lines":[{"line_number":585,"context_line":".. versionadded:: 2.63"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"Replaces a security service in a share network. Both current and the new"},{"line_number":588,"context_line":"security service must have the same type."},{"line_number":589,"context_line":""},{"line_number":590,"context_line":".. important::"},{"line_number":591,"context_line":"    Before calling the update share network security service API, make sure"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"3c318fba_5b13221a","line":588,"range":{"start_line":588,"start_character":40,"end_line":588,"end_character":41},"in_reply_to":"eb1a9210_14606504","updated":"2021-11-26 15:23:08.000000000","message":"Thanks for the suggestion\nI believe we only need to mention that security_service_update_support must have its value set to true.\nIf this value is set to true, means that all share servers are in an active state.","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"91e1b9220fff9e2d724b11d0c900a4ee47650aa8","unresolved":true,"context_lines":[{"line_number":678,"context_line":".. rest_status_code:: error status.yaml"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"   - 400"},{"line_number":681,"context_line":"   - 401"},{"line_number":682,"context_line":"   - 409"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"c7d2382e_b5bf2598","line":681,"updated":"2021-11-05 06:04:06.000000000","message":"need add 404, if share network id specified in request body can not be found","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ac55650232e563814d58588561d3145c246c0c88","unresolved":false,"context_lines":[{"line_number":678,"context_line":".. rest_status_code:: error status.yaml"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"   - 400"},{"line_number":681,"context_line":"   - 401"},{"line_number":682,"context_line":"   - 409"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"dc2f2663_9ae3945e","line":681,"in_reply_to":"c7d2382e_b5bf2598","updated":"2021-11-26 15:23:08.000000000","message":"Done","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"91e1b9220fff9e2d724b11d0c900a4ee47650aa8","unresolved":true,"context_lines":[{"line_number":741,"context_line":".. rest_status_code:: error status.yaml"},{"line_number":742,"context_line":""},{"line_number":743,"context_line":"   - 400"},{"line_number":744,"context_line":"   - 401"},{"line_number":745,"context_line":"   - 409"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"b2af2cf2_6ce87706","line":744,"updated":"2021-11-05 06:04:06.000000000","message":"also need 404.","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ac55650232e563814d58588561d3145c246c0c88","unresolved":false,"context_lines":[{"line_number":741,"context_line":".. rest_status_code:: error status.yaml"},{"line_number":742,"context_line":""},{"line_number":743,"context_line":"   - 400"},{"line_number":744,"context_line":"   - 401"},{"line_number":745,"context_line":"   - 409"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"fb6b05ff_f7d147fc","line":744,"in_reply_to":"b2af2cf2_6ce87706","updated":"2021-11-26 15:23:08.000000000","message":"Done","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"91e1b9220fff9e2d724b11d0c900a4ee47650aa8","unresolved":true,"context_lines":[{"line_number":801,"context_line":".. rest_status_code:: error status.yaml"},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"    - 400"},{"line_number":804,"context_line":"    - 403"},{"line_number":805,"context_line":"    - 404"},{"line_number":806,"context_line":""},{"line_number":807,"context_line":"Request parameters"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"f8067029_3836e0c4","line":804,"updated":"2021-11-05 06:04:06.000000000","message":"need add 401, User must authenticate before making a request. only admin can reset status.","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ac55650232e563814d58588561d3145c246c0c88","unresolved":false,"context_lines":[{"line_number":801,"context_line":".. rest_status_code:: error status.yaml"},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"    - 400"},{"line_number":804,"context_line":"    - 403"},{"line_number":805,"context_line":"    - 404"},{"line_number":806,"context_line":""},{"line_number":807,"context_line":"Request parameters"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"722eeb67_26512f32","line":804,"in_reply_to":"f8067029_3836e0c4","updated":"2021-11-26 15:23:08.000000000","message":"Done","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e0ee5f4adc2478033ccc943ed70b51684b46359","unresolved":true,"context_lines":[{"line_number":316,"context_line":"    As of API version 2.63, manila allows adding security services to share"},{"line_number":317,"context_line":"    networks that are being used if supported by the share backends. Before"},{"line_number":318,"context_line":"    requesting to add a security service to a share network that is in use,"},{"line_number":319,"context_line":"    make sure to call the API to check if the backends can hold such operation."},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"Response codes"},{"line_number":322,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"4ce5cc34_e88f3514","line":319,"range":{"start_line":319,"start_character":17,"end_line":319,"end_character":78},"updated":"2021-12-04 18:37:19.000000000","message":"This could be hyperlinked to the section below","commit_id":"eab74b580873f5761b4df48066ff8c3012755405"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"996e1e38f07d04df7caf918fc01cc69954724d1c","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    As of API version 2.63, manila allows adding security services to share"},{"line_number":317,"context_line":"    networks that are being used if supported by the share backends. Before"},{"line_number":318,"context_line":"    requesting to add a security service to a share network that is in use,"},{"line_number":319,"context_line":"    make sure to call the API to check if the backends can hold such operation."},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"Response codes"},{"line_number":322,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"68acde82_9e9071b6","line":319,"range":{"start_line":319,"start_character":17,"end_line":319,"end_character":78},"in_reply_to":"4ce5cc34_e88f3514","updated":"2021-12-06 13:35:48.000000000","message":"Done","commit_id":"eab74b580873f5761b4df48066ff8c3012755405"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e0ee5f4adc2478033ccc943ed70b51684b46359","unresolved":true,"context_lines":[{"line_number":591,"context_line":".. important::"},{"line_number":592,"context_line":"    Before calling the update share network security service API, make sure"},{"line_number":593,"context_line":"    to check if the share backends within the share network can hold the"},{"line_number":594,"context_line":"    operation, through the check update API."},{"line_number":595,"context_line":""},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"Response codes"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"fa168aa5_4113ddb7","line":594,"range":{"start_line":594,"start_character":27,"end_line":594,"end_character":43},"updated":"2021-12-04 18:37:19.000000000","message":"could be hyperlinked to the section below","commit_id":"eab74b580873f5761b4df48066ff8c3012755405"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"996e1e38f07d04df7caf918fc01cc69954724d1c","unresolved":false,"context_lines":[{"line_number":591,"context_line":".. important::"},{"line_number":592,"context_line":"    Before calling the update share network security service API, make sure"},{"line_number":593,"context_line":"    to check if the share backends within the share network can hold the"},{"line_number":594,"context_line":"    operation, through the check update API."},{"line_number":595,"context_line":""},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"Response codes"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"ff91b4d2_890458a6","line":594,"range":{"start_line":594,"start_character":27,"end_line":594,"end_character":43},"in_reply_to":"fa168aa5_4113ddb7","updated":"2021-12-06 13:35:48.000000000","message":"Done","commit_id":"eab74b580873f5761b4df48066ff8c3012755405"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e0ee5f4adc2478033ccc943ed70b51684b46359","unresolved":true,"context_lines":[{"line_number":663,"context_line":""},{"line_number":664,"context_line":".. versionadded:: 2.63"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"Checks if all the share backends that at the moment are tied to the share"},{"line_number":667,"context_line":"network can hold a update share network security service operation. This"},{"line_number":668,"context_line":"operation must be triggered before an actual request to update a share network"},{"line_number":669,"context_line":"security service is requested."},{"line_number":670,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"79ffc285_38b1999c","line":667,"range":{"start_line":666,"start_character":0,"end_line":667,"end_character":67},"updated":"2021-12-04 18:37:19.000000000","message":"\"Checks if an existing security service can be replaced on a share network that is in use.\"\n\n\nthe backend info is only visible to admins anyway..","commit_id":"eab74b580873f5761b4df48066ff8c3012755405"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"996e1e38f07d04df7caf918fc01cc69954724d1c","unresolved":false,"context_lines":[{"line_number":663,"context_line":""},{"line_number":664,"context_line":".. versionadded:: 2.63"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"Checks if all the share backends that at the moment are tied to the share"},{"line_number":667,"context_line":"network can hold a update share network security service operation. This"},{"line_number":668,"context_line":"operation must be triggered before an actual request to update a share network"},{"line_number":669,"context_line":"security service is requested."},{"line_number":670,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"b27770d3_48e1e443","line":667,"range":{"start_line":666,"start_character":0,"end_line":667,"end_character":67},"in_reply_to":"79ffc285_38b1999c","updated":"2021-12-06 13:35:48.000000000","message":"Done","commit_id":"eab74b580873f5761b4df48066ff8c3012755405"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e0ee5f4adc2478033ccc943ed70b51684b46359","unresolved":true,"context_lines":[{"line_number":727,"context_line":""},{"line_number":728,"context_line":".. versionadded:: 2.63"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"Checks if all the share backends that at the moment are tied to the share"},{"line_number":731,"context_line":"network can hold adding a security service to an in use share network. This"},{"line_number":732,"context_line":"operation must be triggered before an actual request to add a security service"},{"line_number":733,"context_line":"to an in use share network."},{"line_number":734,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"4d3b7b34_ecc638db","line":731,"range":{"start_line":730,"start_character":7,"end_line":731,"end_character":70},"updated":"2021-12-04 18:37:19.000000000","message":"\"Checks if a new security service can be added to a share network that\u0027s already in use.\"\n\nNot opposed to the detail but, to end users, backends and their capabilities won\u0027t make much sense/difference. The goal would be to know if an addition is possible abstracting away what manila needs to do to find out...","commit_id":"eab74b580873f5761b4df48066ff8c3012755405"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"996e1e38f07d04df7caf918fc01cc69954724d1c","unresolved":false,"context_lines":[{"line_number":727,"context_line":""},{"line_number":728,"context_line":".. versionadded:: 2.63"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"Checks if all the share backends that at the moment are tied to the share"},{"line_number":731,"context_line":"network can hold adding a security service to an in use share network. This"},{"line_number":732,"context_line":"operation must be triggered before an actual request to add a security service"},{"line_number":733,"context_line":"to an in use share network."},{"line_number":734,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"e080072c_01c297bf","line":731,"range":{"start_line":730,"start_character":7,"end_line":731,"end_character":70},"in_reply_to":"4d3b7b34_ecc638db","updated":"2021-12-06 13:35:48.000000000","message":"Done","commit_id":"eab74b580873f5761b4df48066ff8c3012755405"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eb3c7ef432c58898015881789b84c3b3444343fd","unresolved":true,"context_lines":[{"line_number":316,"context_line":"    As of API version 2.63, manila allows adding security services to share"},{"line_number":317,"context_line":"    networks that are being used if supported by the share backends. Before"},{"line_number":318,"context_line":"    requesting to add a security service to a share network that is in use,"},{"line_number":319,"context_line":"    make sure to :ref:`call the API to check if the backends can hold such"},{"line_number":320,"context_line":"    operation \u003cshare-net-sec-service-update-check\u003e`."},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"Response codes"},{"line_number":323,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"11e07c36_bcf7afe9","line":320,"range":{"start_line":319,"start_character":17,"end_line":320,"end_character":52},"updated":"2021-12-06 18:51:49.000000000","message":"This ref isn\u0027t working for some reason... \n\nCould you use the API header itself?\n\n `check-share-network-security-service-update-since-api-v2-63`","commit_id":"3bbe4694b7078506bc748f8829e63a5140aa88c2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f13ec8fc7b64b66b9df81cc39cb9a2d43d19d39f","unresolved":true,"context_lines":[{"line_number":316,"context_line":"    As of API version 2.63, manila allows adding security services to share"},{"line_number":317,"context_line":"    networks that are being used if supported by the share backends. Before"},{"line_number":318,"context_line":"    requesting to add a security service to a share network that is in use,"},{"line_number":319,"context_line":"    make sure to :ref:`call the API to check if the backends can hold such"},{"line_number":320,"context_line":"    operation \u003cshare-net-sec-service-update-check\u003e`."},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"Response codes"},{"line_number":323,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"5ceb60e6_131b1c30","line":320,"range":{"start_line":319,"start_character":17,"end_line":320,"end_character":52},"in_reply_to":"11e07c36_bcf7afe9","updated":"2021-12-06 22:13:50.000000000","message":"I tried a bunch of approaches but none of them worked :/\nAdded an absolute link for this","commit_id":"3bbe4694b7078506bc748f8829e63a5140aa88c2"}],"api-ref/source/share-servers.inc":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"91e1b9220fff9e2d724b11d0c900a4ee47650aa8","unresolved":true,"context_lines":[{"line_number":80,"context_line":"   - host: host_share_server_body"},{"line_number":81,"context_line":"   - updated_at: updated_at"},{"line_number":82,"context_line":"   - share_network_subnet_id: share_network_subnet_id_share_server_body"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Response example"},{"line_number":85,"context_line":"----------------"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"c2839e97_365cee82","line":83,"updated":"2021-11-05 06:04:06.000000000","message":"need is_auto_deletable, task_state, source_share_server_id, security_service_update_support.\nSome parameters may have been missed in the previous development, so let\u0027s complete them this time.","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ac55650232e563814d58588561d3145c246c0c88","unresolved":true,"context_lines":[{"line_number":80,"context_line":"   - host: host_share_server_body"},{"line_number":81,"context_line":"   - updated_at: updated_at"},{"line_number":82,"context_line":"   - share_network_subnet_id: share_network_subnet_id_share_server_body"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Response example"},{"line_number":85,"context_line":"----------------"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"fe21b76a_49ea2af2","line":83,"in_reply_to":"c2839e97_365cee82","updated":"2021-11-26 15:23:08.000000000","message":"Yes, that\u0027s true... The API answers with these parameters.\nBut in my humble opinion, the is_auto_deletable, task_state and source_share_server_id parameters shouldn\u0027t be added in this change. If those items are not here, then we are seeing a bug, that should possibly be filed as such on launchpad and tagged as low hanging fruits.","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"aa7f34e36c7e1ec5d048b73d9a589094bf7b1d78","unresolved":false,"context_lines":[{"line_number":80,"context_line":"   - host: host_share_server_body"},{"line_number":81,"context_line":"   - updated_at: updated_at"},{"line_number":82,"context_line":"   - share_network_subnet_id: share_network_subnet_id_share_server_body"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Response example"},{"line_number":85,"context_line":"----------------"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"a0e4359e_508dcc4a","line":83,"in_reply_to":"fe21b76a_49ea2af2","updated":"2021-12-02 01:07:03.000000000","message":"Done","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"91e1b9220fff9e2d724b11d0c900a4ee47650aa8","unresolved":true,"context_lines":[{"line_number":84,"context_line":"Response example"},{"line_number":85,"context_line":"----------------"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":".. literalinclude:: samples/share-servers-list-response.json"},{"line_number":88,"context_line":"   :language: javascript"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"c699760a_acb77051","line":87,"range":{"start_line":87,"start_character":28,"end_line":87,"end_character":60},"updated":"2021-11-05 06:04:06.000000000","message":"this file need to update,  to add new field.","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ac55650232e563814d58588561d3145c246c0c88","unresolved":false,"context_lines":[{"line_number":84,"context_line":"Response example"},{"line_number":85,"context_line":"----------------"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":".. literalinclude:: samples/share-servers-list-response.json"},{"line_number":88,"context_line":"   :language: javascript"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"d2753bfe_b50b41d4","line":87,"range":{"start_line":87,"start_character":28,"end_line":87,"end_character":60},"in_reply_to":"c699760a_acb77051","updated":"2021-11-26 15:23:08.000000000","message":"Done","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"91e1b9220fff9e2d724b11d0c900a4ee47650aa8","unresolved":true,"context_lines":[{"line_number":135,"context_line":"  - is_auto_deletable: share_server_show_is_auto_deletable"},{"line_number":136,"context_line":"  - share_network_subnet_id: share_network_subnet_id_share_server_body"},{"line_number":137,"context_line":"  - security_service_update_support: security_service_update_support"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Response example"},{"line_number":140,"context_line":"----------------"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"a9bfaecd_038d3930","line":138,"updated":"2021-11-05 06:04:06.000000000","message":"we also need \u0027task_state\u0027, \u0027source_share_server_id\u0027 since api 2.57.\nmanila/api/views/share_servers.py#80-85","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ac55650232e563814d58588561d3145c246c0c88","unresolved":true,"context_lines":[{"line_number":135,"context_line":"  - is_auto_deletable: share_server_show_is_auto_deletable"},{"line_number":136,"context_line":"  - share_network_subnet_id: share_network_subnet_id_share_server_body"},{"line_number":137,"context_line":"  - security_service_update_support: security_service_update_support"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Response example"},{"line_number":140,"context_line":"----------------"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"eee923e0_619e242d","line":138,"in_reply_to":"a9bfaecd_038d3930","updated":"2021-11-26 15:23:08.000000000","message":"IMHO this should be filed as a separate bug. Wdyt?","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"aa7f34e36c7e1ec5d048b73d9a589094bf7b1d78","unresolved":false,"context_lines":[{"line_number":135,"context_line":"  - is_auto_deletable: share_server_show_is_auto_deletable"},{"line_number":136,"context_line":"  - share_network_subnet_id: share_network_subnet_id_share_server_body"},{"line_number":137,"context_line":"  - security_service_update_support: security_service_update_support"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Response example"},{"line_number":140,"context_line":"----------------"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"0be75508_f2bc3f75","line":138,"in_reply_to":"eee923e0_619e242d","updated":"2021-12-02 01:07:03.000000000","message":"ok, we can put another doc bug about it.","commit_id":"e5d138b2386af0c74b224863ab82b94754e7e25a"}]}