)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"68e87b386d76aeafa17462b7c025c827e9cb6a20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ccf2b29e_5e849479","updated":"2021-12-08 20:30:44.000000000","message":"LGTM. Perhaps we should add more text to the release note that was merged in the other change partially addressing this bug... Wdyt?","commit_id":"7b7d18e14243c82c20b49f134a5a007f5f21fcdd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a4930cdf8ccb4354abd0976280a113b88f0d5af0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b66e68be_b53aab2f","updated":"2021-12-07 00:25:45.000000000","message":"Thanks, LGTM","commit_id":"7b7d18e14243c82c20b49f134a5a007f5f21fcdd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4d9996b0995f313a503a1f8e81bc787c2ce22ea1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2f0f0a29_beb1d5b1","in_reply_to":"41bcf78a_b1a5e67c","updated":"2021-12-08 23:01:55.000000000","message":"sry, just noticed we did add it with https://review.opendev.org/c/openstack/manila/+/786367/3/releasenotes/notes/bug-1924230-skip-periodic-task-for-active-replica-030a982af92f8a62.yaml\n\nThat should suffice?","commit_id":"7b7d18e14243c82c20b49f134a5a007f5f21fcdd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0c5382dedb7c8eba1b39505eb10598dfe15a1cc3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"41bcf78a_b1a5e67c","in_reply_to":"ccf2b29e_5e849479","updated":"2021-12-08 23:00:57.000000000","message":"We\u0027ll do that with another patch.","commit_id":"7b7d18e14243c82c20b49f134a5a007f5f21fcdd"}],"manila/share/manager.py":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"84df4c514bbe788e935393ea8e4b8b0949fab09f","unresolved":true,"context_lines":[{"line_number":2628,"context_line":"                    {\u0027replica_state\u0027: constants.STATUS_ERROR})"},{"line_number":2629,"context_line":"            # without a related active replica, we cannot act on any"},{"line_number":2630,"context_line":"            # non-active replica"},{"line_number":2631,"context_line":"            return"},{"line_number":2632,"context_line":""},{"line_number":2633,"context_line":"        # Get snapshots for the share."},{"line_number":2634,"context_line":"        share_snapshots \u003d self.db.share_snapshot_get_all_for_share("}],"source_content_type":"text/x-python","patch_set":1,"id":"38362136_79cec50a","line":2631,"updated":"2021-04-16 13:48:35.000000000","message":"I went that way instead of letting the driver decide.\n\nMaybe the driver can find out, which one is supposed to be the active replica, but this is a huge \u0027maybe\u0027 with a lot of uncertainty how the drivers would react. And definitely if we don\u0027t return here, more work is needed, at least _get_replica_snapshots_for_snapshot() would break.","commit_id":"0ddf16fcb6145ab5847519db788b53ceac86d955"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"7bed937f9c47a003846f1d774ff4ea1ecaea59d7","unresolved":true,"context_lines":[{"line_number":2614,"context_line":"                with_share_data\u003dTrue, with_share_server\u003dTrue)"},{"line_number":2615,"context_line":"        )"},{"line_number":2616,"context_line":""},{"line_number":2617,"context_line":"        _active_replica \u003d [x for x in replica_list"},{"line_number":2618,"context_line":"                           if x[\u0027replica_state\u0027] \u003d\u003d"},{"line_number":2619,"context_line":"                           constants.REPLICA_STATE_ACTIVE][0]"},{"line_number":2620,"context_line":""},{"line_number":2621,"context_line":"        # Get snapshots for the share."},{"line_number":2622,"context_line":"        share_snapshots \u003d self.db.share_snapshot_get_all_for_share("}],"source_content_type":"text/x-python","patch_set":2,"id":"a4a62d7a_da3a2677","side":"PARENT","line":2619,"range":{"start_line":2617,"start_character":8,"end_line":2619,"end_character":61},"updated":"2021-09-10 07:09:26.000000000","message":"good find, if there is no active replica, will get IndexError: list index out of range.","commit_id":"ad4315eb360ccc9afbd78d4bc5b5e5e0716df87b"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"7bed937f9c47a003846f1d774ff4ea1ecaea59d7","unresolved":true,"context_lines":[{"line_number":2563,"context_line":"        replicas \u003d self.db.share_replicas_get_all(context,"},{"line_number":2564,"context_line":"                                                  with_share_data\u003dTrue)"},{"line_number":2565,"context_line":""},{"line_number":2566,"context_line":"        # Filter only non-active replicas belonging to this backend"},{"line_number":2567,"context_line":"        def qualified_replica(r):"},{"line_number":2568,"context_line":"            return (share_utils.extract_host(r[\u0027host\u0027]) \u003d\u003d"},{"line_number":2569,"context_line":"                    share_utils.extract_host(self.host))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9558f27e_666afa6d","line":2566,"range":{"start_line":2566,"start_character":22,"end_line":2566,"end_character":32},"updated":"2021-09-10 07:09:26.000000000","message":"remove this word to align description and implementation.","commit_id":"095acb3ea4a0052a21d1e5e380e012bfebebbb49"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"05ce2f6e8cb1a55910affa0d242d54f0d84f1e63","unresolved":true,"context_lines":[{"line_number":2563,"context_line":"        replicas \u003d self.db.share_replicas_get_all(context,"},{"line_number":2564,"context_line":"                                                  with_share_data\u003dTrue)"},{"line_number":2565,"context_line":""},{"line_number":2566,"context_line":"        # Filter only non-active replicas belonging to this backend"},{"line_number":2567,"context_line":"        def qualified_replica(r):"},{"line_number":2568,"context_line":"            return (share_utils.extract_host(r[\u0027host\u0027]) \u003d\u003d"},{"line_number":2569,"context_line":"                    share_utils.extract_host(self.host))"}],"source_content_type":"text/x-python","patch_set":2,"id":"553c208f_7c925f1b","line":2566,"range":{"start_line":2566,"start_character":22,"end_line":2566,"end_character":32},"in_reply_to":"9558f27e_666afa6d","updated":"2021-09-10 07:48:40.000000000","message":"or just like what you does in https://review.opendev.org/c/openstack/manila/+/786367.","commit_id":"095acb3ea4a0052a21d1e5e380e012bfebebbb49"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"7bed937f9c47a003846f1d774ff4ea1ecaea59d7","unresolved":true,"context_lines":[{"line_number":2621,"context_line":"        if _active_replica is None:"},{"line_number":2622,"context_line":"            if share_replica[\u0027replica_state\u0027] !\u003d constants.STATUS_ERROR:"},{"line_number":2623,"context_line":"                # only log warning if replica_state was not already in error"},{"line_number":2624,"context_line":"                msg \u003d ((\"Replica parent share %(id)s has no active \""},{"line_number":2625,"context_line":"                        \"replica.\") % {\u0027id\u0027: share_replica[\u0027share_id\u0027]})"},{"line_number":2626,"context_line":"                LOG.warning(msg)"},{"line_number":2627,"context_line":"                self.db.share_replica_update(context, share_replica[\u0027id\u0027],"},{"line_number":2628,"context_line":"                                             {\u0027replica_state\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"b310d89e_8836347e","line":2625,"range":{"start_line":2624,"start_character":16,"end_line":2625,"end_character":72},"updated":"2021-09-10 07:09:26.000000000","message":"msg \u003d ((\"Replica parent share %(id)s has no active \"\n        \"replica, will reset replica %(r_id)s to error\") % {\u0027id\u0027: share_replica[\u0027share_id\u0027],\n                                                            \u0027r_id\u0027: share_replica[\u0027id\u0027]})","commit_id":"095acb3ea4a0052a21d1e5e380e012bfebebbb49"}]}