)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"554391e8db58300e964952df1defcf6e802e9c23","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Filter shares by share type \"extra_specs\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It\u0027s possible to use share type \"extra_specs\" as key\u003dvalue"},{"line_number":10,"context_line":"pairs to filter shares by. However, this doesn\u0027t seem to"},{"line_number":11,"context_line":"work as intended."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df4d2330_6ec3bbf1","line":9,"updated":"2021-06-18 15:02:31.000000000","message":"Commit message should explain what the fix does, not so much what the bug is.\n\nI\u0027d rephrase it as something like:\n\n\"This change fixes the query being used to filter share types. We were using an or clause instead of an and clause, and that was causing all the extra specs to be shown instead of the ones that the user specified. With this fix, manila users will be able to filter shares by share type extra_specs accurately.\"","commit_id":"386c112724b3fa140de45ea79ee2107d1e679013"},{"author":{"_account_id":32493,"name":"Kafilat Adeleke","email":"adelekekafilatadenike@gmail.com","username":"kafilat-adeleke"},"change_message_id":"58ba82a9c8e22745bd249528af02d47af3a5d0ec","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Filter shares by share type \"extra_specs\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It\u0027s possible to use share type \"extra_specs\" as key\u003dvalue"},{"line_number":10,"context_line":"pairs to filter shares by. However, this doesn\u0027t seem to"},{"line_number":11,"context_line":"work as intended."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"63ee0cd2_4c110eb5","line":9,"in_reply_to":"df4d2330_6ec3bbf1","updated":"2021-06-19 08:17:04.000000000","message":"Done","commit_id":"386c112724b3fa140de45ea79ee2107d1e679013"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"f2af1206010419afc8a7dbf8ca53564029d3b726","unresolved":true,"context_lines":[{"line_number":2016,"context_line":"            models.ShareTypeExtraSpecs.share_type_id \u003d\u003d"},{"line_number":2017,"context_line":"            models.ShareInstance.share_type_id)"},{"line_number":2018,"context_line":"        for k, v in filters[\u0027extra_specs\u0027].items():"},{"line_number":2019,"context_line":"            query \u003d query.filter(or_(models.ShareTypeExtraSpecs.key \u003d\u003d k,"},{"line_number":2020,"context_line":"                                     models.ShareTypeExtraSpecs.value \u003d\u003d v))"},{"line_number":2021,"context_line":""},{"line_number":2022,"context_line":"    return query"}],"source_content_type":"text/x-python","patch_set":2,"id":"3e99c577_e301d5fb","side":"PARENT","line":2019,"range":{"start_line":2019,"start_character":33,"end_line":2019,"end_character":35},"updated":"2021-06-10 07:23:26.000000000","message":"maybe, here should be and.\nquery \u003d query.filter(and_(models.ShareTypeExtraSpecs.key \u003d\u003d k,\n                          models.ShareTypeExtraSpecs.value \u003d\u003d v)","commit_id":"fac7fc52ebb9cd656f91722b082ed7e32b4360ed"}],"releasenotes/notes/bug-192912-fix-filtering-shares-by-extra-specs-b79235301306bcf2.yaml":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"554391e8db58300e964952df1defcf6e802e9c23","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"     Filtering shares by share type \"extra_specs\" as key\u003dvalue has been fixed."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"2f3bd692_9732def5","line":4,"updated":"2021-06-18 15:02:31.000000000","message":"Same here, it would be more useful to see more information of what is the actual fix.\n\nA wrong internal database query was causing the output to be incorrect. Filtering shares by share-type \"extra_specs\" as key\u003dvalue now returns the expected output.","commit_id":"386c112724b3fa140de45ea79ee2107d1e679013"},{"author":{"_account_id":32493,"name":"Kafilat Adeleke","email":"adelekekafilatadenike@gmail.com","username":"kafilat-adeleke"},"change_message_id":"58ba82a9c8e22745bd249528af02d47af3a5d0ec","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"     Filtering shares by share type \"extra_specs\" as key\u003dvalue has been fixed."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"094b27bc_ae9a43bc","line":4,"in_reply_to":"2f3bd692_9732def5","updated":"2021-06-19 08:17:04.000000000","message":"Done","commit_id":"386c112724b3fa140de45ea79ee2107d1e679013"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"74f1ce642aa819f16b01bf73efc20df600ca4fa9","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A wrong internal database query was causing the output to be"},{"line_number":5,"context_line":"    incorrect. Filtering shares by share-type \"extra_specs\" as"},{"line_number":6,"context_line":"    key\u003dvalue now returns the expected output."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5199cd17_d326024c","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":15},"updated":"2021-06-21 16:34:12.000000000","message":"This sentence can either be removed or added after the next sentence..","commit_id":"632a780885f64ff09cee03a9b86628e1abe4a640"}]}