)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"5edcfa581e283473fe2cb603ff584b91cac4e88f","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add config option reserved_share_from_snapshot_percentage."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This config option allows different value for reservation on the some"},{"line_number":10,"context_line":"platforms, where shares can only be created from the snapshot on the"},{"line_number":11,"context_line":"host where snapshot was taken e.g. NetApp. The lower value of this"},{"line_number":12,"context_line":"config option against existing (reserved_share_percentage) allows to"},{"line_number":13,"context_line":"create shares from the snapshot on the same host upto a higher"},{"line_number":14,"context_line":"threshold even though non-snapshot/regular share create fails."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1118112d_c0c29d85","line":11,"range":{"start_line":10,"start_character":17,"end_line":11,"end_character":42},"updated":"2021-08-10 19:17:58.000000000","message":"That is not correct. NetApp driver can create shares from snapshot in different hosts.","commit_id":"c2fd0666837d86652d282ebe1157d13cdb73c711"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4b3f4bb24bd77116c0160ee654ff77f40fe94c7e","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add config option reserved_share_from_snapshot_percentage."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This config option allows different value for reservation on the some"},{"line_number":10,"context_line":"platforms, where shares can only be created from the snapshot on the"},{"line_number":11,"context_line":"host where snapshot was taken e.g. NetApp. The lower value of this"},{"line_number":12,"context_line":"config option against existing (reserved_share_percentage) allows to"},{"line_number":13,"context_line":"create shares from the snapshot on the same host upto a higher"},{"line_number":14,"context_line":"threshold even though non-snapshot/regular share create fails."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"13573197_5397537a","line":11,"range":{"start_line":10,"start_character":17,"end_line":11,"end_character":42},"in_reply_to":"1118112d_c0c29d85","updated":"2021-08-10 20:26:00.000000000","message":"removed NetApp reference and did some rewording.","commit_id":"c2fd0666837d86652d282ebe1157d13cdb73c711"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"5edcfa581e283473fe2cb603ff584b91cac4e88f","unresolved":true,"context_lines":[{"line_number":10,"context_line":"platforms, where shares can only be created from the snapshot on the"},{"line_number":11,"context_line":"host where snapshot was taken e.g. NetApp. The lower value of this"},{"line_number":12,"context_line":"config option against existing (reserved_share_percentage) allows to"},{"line_number":13,"context_line":"create shares from the snapshot on the same host upto a higher"},{"line_number":14,"context_line":"threshold even though non-snapshot/regular share create fails."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1938060"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"93792140_059b22f6","line":13,"range":{"start_line":13,"start_character":49,"end_line":13,"end_character":53},"updated":"2021-08-10 19:17:58.000000000","message":"up to","commit_id":"c2fd0666837d86652d282ebe1157d13cdb73c711"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4b3f4bb24bd77116c0160ee654ff77f40fe94c7e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"platforms, where shares can only be created from the snapshot on the"},{"line_number":11,"context_line":"host where snapshot was taken e.g. NetApp. The lower value of this"},{"line_number":12,"context_line":"config option against existing (reserved_share_percentage) allows to"},{"line_number":13,"context_line":"create shares from the snapshot on the same host upto a higher"},{"line_number":14,"context_line":"threshold even though non-snapshot/regular share create fails."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1938060"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a6cd41b2_836ad4b8","line":13,"range":{"start_line":13,"start_character":49,"end_line":13,"end_character":53},"in_reply_to":"93792140_059b22f6","updated":"2021-08-10 20:26:00.000000000","message":"Done","commit_id":"c2fd0666837d86652d282ebe1157d13cdb73c711"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b2b97309c1c38fd13a8ad59fedeb6ec1a4d4aa4f","unresolved":true,"context_lines":[{"line_number":12,"context_line":"this config option against existing (reserved_share_percentage) allows"},{"line_number":13,"context_line":"to create shares from the snapshot on the same host up to a higher"},{"line_number":14,"context_line":"threshold even though non-snapshot/regular share create fails."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1938060"},{"line_number":17,"context_line":"Change-Id: I390da933fe92875e3c7ee40709eacacc030278dc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b55ac8e4_7ea64d6a","line":15,"updated":"2021-08-11 13:51:33.000000000","message":"Please add DocImpact... This must be documented in some places as well, like: https://docs.openstack.org/manila/latest/contributor/driver_requirements.html#capabilities :)","commit_id":"7789295b6622c7339d837428b9740cae7c35c61f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"127544b124cbd0cc8b7464d45bd67f5789562264","unresolved":false,"context_lines":[{"line_number":12,"context_line":"this config option against existing (reserved_share_percentage) allows"},{"line_number":13,"context_line":"to create shares from the snapshot on the same host up to a higher"},{"line_number":14,"context_line":"threshold even though non-snapshot/regular share create fails."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1938060"},{"line_number":17,"context_line":"Change-Id: I390da933fe92875e3c7ee40709eacacc030278dc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fcf54c60_d12e165e","line":15,"in_reply_to":"b55ac8e4_7ea64d6a","updated":"2021-08-11 16:15:37.000000000","message":"Done","commit_id":"7789295b6622c7339d837428b9740cae7c35c61f"}],"manila/scheduler/filters/capacity.py":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"5edcfa581e283473fe2cb603ff584b91cac4e88f","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        free_space \u003d host_state.free_capacity_gb"},{"line_number":44,"context_line":"        total_space \u003d host_state.total_capacity_gb"},{"line_number":45,"context_line":"        if filter_properties.get(\u0027snapshot_id\u0027, None) is None:"},{"line_number":46,"context_line":"            reserved \u003d float(host_state.reserved_percentage) / 100"},{"line_number":47,"context_line":"        else:"},{"line_number":48,"context_line":"            reserved \u003d float(host_state.reserved_snapshot_percentage) / 100"}],"source_content_type":"text/x-python","patch_set":1,"id":"54b87d62_b7888207","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":62},"updated":"2021-08-10 19:17:58.000000000","message":"the get without the entity set already returns None. Given you only want to check if it exists:\n\nif filter_properties.get(\u0027snapshot_id\u0027):\n   ...\nelse:","commit_id":"c2fd0666837d86652d282ebe1157d13cdb73c711"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4b3f4bb24bd77116c0160ee654ff77f40fe94c7e","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        free_space \u003d host_state.free_capacity_gb"},{"line_number":44,"context_line":"        total_space \u003d host_state.total_capacity_gb"},{"line_number":45,"context_line":"        if filter_properties.get(\u0027snapshot_id\u0027, None) is None:"},{"line_number":46,"context_line":"            reserved \u003d float(host_state.reserved_percentage) / 100"},{"line_number":47,"context_line":"        else:"},{"line_number":48,"context_line":"            reserved \u003d float(host_state.reserved_snapshot_percentage) / 100"}],"source_content_type":"text/x-python","patch_set":1,"id":"35d209b6_fbdf2737","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":62},"in_reply_to":"54b87d62_b7888207","updated":"2021-08-10 20:26:00.000000000","message":"Done","commit_id":"c2fd0666837d86652d282ebe1157d13cdb73c711"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"5edcfa581e283473fe2cb603ff584b91cac4e88f","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        if filter_properties.get(\u0027snapshot_id\u0027, None) is None:"},{"line_number":46,"context_line":"            reserved \u003d float(host_state.reserved_percentage) / 100"},{"line_number":47,"context_line":"        else:"},{"line_number":48,"context_line":"            reserved \u003d float(host_state.reserved_snapshot_percentage) / 100"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        if free_space \u003d\u003d \u0027unknown\u0027:"},{"line_number":51,"context_line":"            # NOTE(zhiteng) for those back-ends cannot report actual"}],"source_content_type":"text/x-python","patch_set":1,"id":"510b9c11_b5dee464","line":48,"range":{"start_line":48,"start_character":12,"end_line":48,"end_character":75},"updated":"2021-08-10 19:17:58.000000000","message":"question: should it be used only when the new share is on same host ?!","commit_id":"c2fd0666837d86652d282ebe1157d13cdb73c711"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4b3f4bb24bd77116c0160ee654ff77f40fe94c7e","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        if filter_properties.get(\u0027snapshot_id\u0027, None) is None:"},{"line_number":46,"context_line":"            reserved \u003d float(host_state.reserved_percentage) / 100"},{"line_number":47,"context_line":"        else:"},{"line_number":48,"context_line":"            reserved \u003d float(host_state.reserved_snapshot_percentage) / 100"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        if free_space \u003d\u003d \u0027unknown\u0027:"},{"line_number":51,"context_line":"            # NOTE(zhiteng) for those back-ends cannot report actual"}],"source_content_type":"text/x-python","patch_set":1,"id":"9c6f2211_af0d3461","line":48,"range":{"start_line":48,"start_character":12,"end_line":48,"end_character":75},"in_reply_to":"510b9c11_b5dee464","updated":"2021-08-10 20:26:00.000000000","message":"The new share can be on same host or different host as long as that host meets the reserved capacity criteria.","commit_id":"c2fd0666837d86652d282ebe1157d13cdb73c711"}],"manila/share/driver.py":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"5edcfa581e283473fe2cb603ff584b91cac4e88f","unresolved":true,"context_lines":[{"line_number":51,"context_line":"             \"be created from the snapshot on the host where snapshot was \""},{"line_number":52,"context_line":"             \"taken, so we can set lower value in this option against \""},{"line_number":53,"context_line":"             \"reserved_share_percentage and allow to create shares from the \""},{"line_number":54,"context_line":"             \"snapshot on the same host upto a higher threshold.\"),"},{"line_number":55,"context_line":"    cfg.StrOpt("},{"line_number":56,"context_line":"        \u0027share_backend_name\u0027,"},{"line_number":57,"context_line":"        help\u003d\u0027The backend name for a given driver implementation.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"f943af90_00d1740f","line":54,"range":{"start_line":54,"start_character":40,"end_line":54,"end_character":44},"updated":"2021-08-10 19:17:58.000000000","message":"up to","commit_id":"c2fd0666837d86652d282ebe1157d13cdb73c711"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4b3f4bb24bd77116c0160ee654ff77f40fe94c7e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"             \"be created from the snapshot on the host where snapshot was \""},{"line_number":52,"context_line":"             \"taken, so we can set lower value in this option against \""},{"line_number":53,"context_line":"             \"reserved_share_percentage and allow to create shares from the \""},{"line_number":54,"context_line":"             \"snapshot on the same host upto a higher threshold.\"),"},{"line_number":55,"context_line":"    cfg.StrOpt("},{"line_number":56,"context_line":"        \u0027share_backend_name\u0027,"},{"line_number":57,"context_line":"        help\u003d\u0027The backend name for a given driver implementation.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"a11a01da_de385869","line":54,"range":{"start_line":54,"start_character":40,"end_line":54,"end_character":44},"in_reply_to":"f943af90_00d1740f","updated":"2021-08-10 20:26:00.000000000","message":"Done","commit_id":"c2fd0666837d86652d282ebe1157d13cdb73c711"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b2b97309c1c38fd13a8ad59fedeb6ec1a4d4aa4f","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        help\u003d\"The percentage of backend capacity reserved. Used for shares \""},{"line_number":50,"context_line":"             \"created from the snapshot. On some platforms, shares can only \""},{"line_number":51,"context_line":"             \"be created from the snapshot on the host where snapshot was \""},{"line_number":52,"context_line":"             \"taken, so we can set lower value in this option against \""},{"line_number":53,"context_line":"             \"reserved_share_percentage and allow to create shares from the \""},{"line_number":54,"context_line":"             \"snapshot on the same host up to a higher threshold.\"),"},{"line_number":55,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":2,"id":"a9b2dd93_eb8f8bb6","line":52,"range":{"start_line":52,"start_character":62,"end_line":52,"end_character":69},"updated":"2021-08-11 13:51:33.000000000","message":"compared to","commit_id":"7789295b6622c7339d837428b9740cae7c35c61f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b2b97309c1c38fd13a8ad59fedeb6ec1a4d4aa4f","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        help\u003d\"The percentage of backend capacity reserved. Used for shares \""},{"line_number":50,"context_line":"             \"created from the snapshot. On some platforms, shares can only \""},{"line_number":51,"context_line":"             \"be created from the snapshot on the host where snapshot was \""},{"line_number":52,"context_line":"             \"taken, so we can set lower value in this option against \""},{"line_number":53,"context_line":"             \"reserved_share_percentage and allow to create shares from the \""},{"line_number":54,"context_line":"             \"snapshot on the same host up to a higher threshold.\"),"},{"line_number":55,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":2,"id":"39729cd6_dbd6ce47","line":52,"range":{"start_line":52,"start_character":34,"end_line":52,"end_character":35},"updated":"2021-08-11 13:51:33.000000000","message":"nit: set a lower value","commit_id":"7789295b6622c7339d837428b9740cae7c35c61f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"127544b124cbd0cc8b7464d45bd67f5789562264","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        help\u003d\"The percentage of backend capacity reserved. Used for shares \""},{"line_number":50,"context_line":"             \"created from the snapshot. On some platforms, shares can only \""},{"line_number":51,"context_line":"             \"be created from the snapshot on the host where snapshot was \""},{"line_number":52,"context_line":"             \"taken, so we can set lower value in this option against \""},{"line_number":53,"context_line":"             \"reserved_share_percentage and allow to create shares from the \""},{"line_number":54,"context_line":"             \"snapshot on the same host up to a higher threshold.\"),"},{"line_number":55,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":2,"id":"5cb387ae_e3e86905","line":52,"range":{"start_line":52,"start_character":34,"end_line":52,"end_character":35},"in_reply_to":"39729cd6_dbd6ce47","updated":"2021-08-11 16:15:37.000000000","message":"Done","commit_id":"7789295b6622c7339d837428b9740cae7c35c61f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"127544b124cbd0cc8b7464d45bd67f5789562264","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        help\u003d\"The percentage of backend capacity reserved. Used for shares \""},{"line_number":50,"context_line":"             \"created from the snapshot. On some platforms, shares can only \""},{"line_number":51,"context_line":"             \"be created from the snapshot on the host where snapshot was \""},{"line_number":52,"context_line":"             \"taken, so we can set lower value in this option against \""},{"line_number":53,"context_line":"             \"reserved_share_percentage and allow to create shares from the \""},{"line_number":54,"context_line":"             \"snapshot on the same host up to a higher threshold.\"),"},{"line_number":55,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":2,"id":"a7ae13c8_11a3a34b","line":52,"range":{"start_line":52,"start_character":62,"end_line":52,"end_character":69},"in_reply_to":"a9b2dd93_eb8f8bb6","updated":"2021-08-11 16:15:37.000000000","message":"Done","commit_id":"7789295b6622c7339d837428b9740cae7c35c61f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b2b97309c1c38fd13a8ad59fedeb6ec1a4d4aa4f","unresolved":true,"context_lines":[{"line_number":50,"context_line":"             \"created from the snapshot. On some platforms, shares can only \""},{"line_number":51,"context_line":"             \"be created from the snapshot on the host where snapshot was \""},{"line_number":52,"context_line":"             \"taken, so we can set lower value in this option against \""},{"line_number":53,"context_line":"             \"reserved_share_percentage and allow to create shares from the \""},{"line_number":54,"context_line":"             \"snapshot on the same host up to a higher threshold.\"),"},{"line_number":55,"context_line":"    cfg.StrOpt("},{"line_number":56,"context_line":"        \u0027share_backend_name\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ed0efcc_04b4f67d","line":53,"range":{"start_line":53,"start_character":39,"end_line":53,"end_character":40},"updated":"2021-08-11 13:51:33.000000000","message":"nit: please add a comma","commit_id":"7789295b6622c7339d837428b9740cae7c35c61f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"127544b124cbd0cc8b7464d45bd67f5789562264","unresolved":false,"context_lines":[{"line_number":50,"context_line":"             \"created from the snapshot. On some platforms, shares can only \""},{"line_number":51,"context_line":"             \"be created from the snapshot on the host where snapshot was \""},{"line_number":52,"context_line":"             \"taken, so we can set lower value in this option against \""},{"line_number":53,"context_line":"             \"reserved_share_percentage and allow to create shares from the \""},{"line_number":54,"context_line":"             \"snapshot on the same host up to a higher threshold.\"),"},{"line_number":55,"context_line":"    cfg.StrOpt("},{"line_number":56,"context_line":"        \u0027share_backend_name\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e57b7659_4270547d","line":53,"range":{"start_line":53,"start_character":39,"end_line":53,"end_character":40},"in_reply_to":"3ed0efcc_04b4f67d","updated":"2021-08-11 16:15:37.000000000","message":"Done","commit_id":"7789295b6622c7339d837428b9740cae7c35c61f"}],"manila/share/drivers/purestorage/flashblade.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b2b97309c1c38fd13a8ad59fedeb6ec1a4d4aa4f","unresolved":true,"context_lines":[{"line_number":146,"context_line":"        ) \u003d self._get_available_capacity()"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        reserved_share_percentage \u003d self.configuration.safe_get("},{"line_number":149,"context_line":"            \"reserved_share_percentage\""},{"line_number":150,"context_line":"        )"},{"line_number":151,"context_line":"        if reserved_share_percentage is None:"},{"line_number":152,"context_line":"            reserved_share_percentage \u003d 0"}],"source_content_type":"text/x-python","patch_set":2,"id":"bb7a0cfb_26c93780","line":149,"range":{"start_line":149,"start_character":13,"end_line":149,"end_character":38},"updated":"2021-08-11 13:51:33.000000000","message":"😮\nNice catch!","commit_id":"7789295b6622c7339d837428b9740cae7c35c61f"}],"releasenotes/notes/add-reserved-share-from-snapshot-gigabytes-2d913ae1fc533690.yaml":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"5edcfa581e283473fe2cb603ff584b91cac4e88f","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    On some platforms, shares can only be created from the snapshot on the"},{"line_number":8,"context_line":"    host where snapshot was taken, so we can set lower value in this option"},{"line_number":9,"context_line":"    against \u0027reserved_share_percentage\u0027 and allow to create shares from the"},{"line_number":10,"context_line":"    snapshot on the same host upto a higher threshold. The default value is 0."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"363009e0_bcf1e5dc","line":10,"range":{"start_line":10,"start_character":30,"end_line":10,"end_character":34},"updated":"2021-08-10 19:17:58.000000000","message":"up to","commit_id":"c2fd0666837d86652d282ebe1157d13cdb73c711"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4b3f4bb24bd77116c0160ee654ff77f40fe94c7e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    On some platforms, shares can only be created from the snapshot on the"},{"line_number":8,"context_line":"    host where snapshot was taken, so we can set lower value in this option"},{"line_number":9,"context_line":"    against \u0027reserved_share_percentage\u0027 and allow to create shares from the"},{"line_number":10,"context_line":"    snapshot on the same host upto a higher threshold. The default value is 0."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3e035f0e_417342b4","line":10,"range":{"start_line":10,"start_character":30,"end_line":10,"end_character":34},"in_reply_to":"363009e0_bcf1e5dc","updated":"2021-08-10 20:26:00.000000000","message":"Done","commit_id":"c2fd0666837d86652d282ebe1157d13cdb73c711"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b2b97309c1c38fd13a8ad59fedeb6ec1a4d4aa4f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    \u0027reserved_share_from_snapshot_gigabytes\u0027 backend config option allows to"},{"line_number":5,"context_line":"    set different value for percentage reservation during share creation,"},{"line_number":6,"context_line":"    applicable for shares created from the snapshot."},{"line_number":7,"context_line":"    On some platforms, shares can only be created from the snapshot on the"},{"line_number":8,"context_line":"    host where snapshot was taken, so we can set lower value in this option"},{"line_number":9,"context_line":"    against \u0027reserved_share_percentage\u0027 and allow to create shares from the"},{"line_number":10,"context_line":"    snapshot on the same host up to a higher threshold. The default value"},{"line_number":11,"context_line":"    is 0."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9c188259_9eb0c226","line":11,"range":{"start_line":4,"start_character":4,"end_line":11,"end_character":8},"updated":"2021-08-11 13:51:33.000000000","message":"Perhaps this is something that could go in the documentation, and here only mention that a new option was added to help Manila to place shares that are being created from snapshot. In this way, we won\u0027t give much details here and we can have more details in the documentation :)","commit_id":"7789295b6622c7339d837428b9740cae7c35c61f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"127544b124cbd0cc8b7464d45bd67f5789562264","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    \u0027reserved_share_from_snapshot_gigabytes\u0027 backend config option allows to"},{"line_number":5,"context_line":"    set different value for percentage reservation during share creation,"},{"line_number":6,"context_line":"    applicable for shares created from the snapshot."},{"line_number":7,"context_line":"    On some platforms, shares can only be created from the snapshot on the"},{"line_number":8,"context_line":"    host where snapshot was taken, so we can set lower value in this option"},{"line_number":9,"context_line":"    against \u0027reserved_share_percentage\u0027 and allow to create shares from the"},{"line_number":10,"context_line":"    snapshot on the same host up to a higher threshold. The default value"},{"line_number":11,"context_line":"    is 0."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6547b885_d6f2d091","line":11,"range":{"start_line":4,"start_character":4,"end_line":11,"end_character":8},"in_reply_to":"9c188259_9eb0c226","updated":"2021-08-11 16:15:37.000000000","message":"Done","commit_id":"7789295b6622c7339d837428b9740cae7c35c61f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8bdad5a9b12153c48c06445c25c7fb629abd94af","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    \u0027reserved_share_from_snapshot_percentage\u0027 backend config option allows"},{"line_number":5,"context_line":"    Manila to consider different reservation percentage for shares that are"},{"line_number":6,"context_line":"    being created from the snapshot. The default value is 0."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9d7277c4_10fe8a25","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":60},"updated":"2021-08-26 19:47:37.000000000","message":"There\u0027s an upgrade impact to this; currently, whether shares are provisioned from snapshots or not, we set aside  a reserved_share_percentage amount and ensure we don\u0027t cross into that - however - if existing deployers upgrade to this release and forget to set reserved_share_from_snapshot_percentage, we\u0027ll default this to 0 and hence lose the reservation that was previously being set aside, \n\nInstead of defaulting to 0 when the value isn\u0027t set, can we default to the value of \"reserved_share_percentage\"? \nIf we do that, we don\u0027t break people that 1) don\u0027t want to reserve space for snapshot-clones separately from normal shares, and 2) forget to set this option, but are relying on \"reserved_share_percentage\".","commit_id":"012027ef189b0dde2a7c6ec9d9facecccac140de"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"0599f7e1cae5c5a9f913d04a18b5fd5b504103a8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    \u0027reserved_share_from_snapshot_percentage\u0027 backend config option allows"},{"line_number":5,"context_line":"    Manila to consider different reservation percentage for shares that are"},{"line_number":6,"context_line":"    being created from the snapshot. The default value is 0."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3af55f7c_c126ebc0","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":60},"in_reply_to":"9d7277c4_10fe8a25","updated":"2021-08-27 17:34:14.000000000","message":"Done","commit_id":"012027ef189b0dde2a7c6ec9d9facecccac140de"}]}