)]}'
{"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bd05495796d06794712865a3077b025f2eca62c","unresolved":true,"context_lines":[{"line_number":3279,"context_line":""},{"line_number":3280,"context_line":"    @na_utils.trace"},{"line_number":3281,"context_line":"    def remove_cifs_share(self, share_name):"},{"line_number":3282,"context_line":"        try:"},{"line_number":3283,"context_line":"            self.send_request(\u0027cifs-share-delete\u0027, {\u0027share-name\u0027: share_name})"},{"line_number":3284,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":3285,"context_line":"            if e.code \u003d\u003d netapp_api.EOBJECTNOTFOUND:"},{"line_number":3286,"context_line":"                return"},{"line_number":3287,"context_line":"            raise"},{"line_number":3288,"context_line":""},{"line_number":3289,"context_line":"    @na_utils.trace"},{"line_number":3290,"context_line":"    def add_nfs_export_rule(self, policy_name, client_match, readonly,"}],"source_content_type":"text/x-python","patch_set":4,"id":"af615b2d_557b2b53","line":3287,"range":{"start_line":3282,"start_character":8,"end_line":3287,"end_character":17},"updated":"2021-09-02 04:57:09.000000000","message":"Does this manifest because of replication? If not, do you want to submit this as a separate bugfix so it can be backported?","commit_id":"9912a95b58eee0860a9cdd94d0a07c6dae2b4e87"}],"manila/share/drivers/netapp/dataontap/cluster_mode/data_motion.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"109d0d32c8121aec11187205cc1266bcffa91c00","unresolved":true,"context_lines":[{"line_number":739,"context_line":"                    \"Retries exhausted. Aborting\") % source_vserver"},{"line_number":740,"context_line":"            raise exception.NetAppException(message\u003dmsg)"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"    def wait_for_mount_replica(self, vserver_client, share_name, timeout\u003d300):"},{"line_number":743,"context_line":"        \"\"\"Mount a replica share that is waiting for snapmirror initialize.\"\"\""},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"        interval \u003d 10"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ac7cdfe_1bf859aa","line":742,"range":{"start_line":742,"start_character":73,"end_line":742,"end_character":76},"updated":"2021-08-26 21:48:49.000000000","message":"is there a specific need to have this value set?","commit_id":"e44970c3e0dac8a6627582c580ee99900d071756"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"5f80fa123d4d858e1472e77fc7343f213d603d91","unresolved":true,"context_lines":[{"line_number":739,"context_line":"                    \"Retries exhausted. Aborting\") % source_vserver"},{"line_number":740,"context_line":"            raise exception.NetAppException(message\u003dmsg)"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"    def wait_for_mount_replica(self, vserver_client, share_name, timeout\u003d300):"},{"line_number":743,"context_line":"        \"\"\"Mount a replica share that is waiting for snapmirror initialize.\"\"\""},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"        interval \u003d 10"}],"source_content_type":"text/x-python","patch_set":2,"id":"a6138c91_82c73bd9","line":742,"range":{"start_line":742,"start_character":73,"end_line":742,"end_character":76},"in_reply_to":"9ac7cdfe_1bf859aa","updated":"2021-08-31 10:42:16.000000000","message":"no, I changed it.","commit_id":"e44970c3e0dac8a6627582c580ee99900d071756"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bd05495796d06794712865a3077b025f2eca62c","unresolved":true,"context_lines":[{"line_number":746,"context_line":"        \"\"\"Mount a replica share that is waiting for snapmirror initialize.\"\"\""},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"        interval \u003d 10"},{"line_number":749,"context_line":"        retries \u003d (timeout / interval or 1)"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"        @utils.retry(exception.ShareBusyException, interval\u003dinterval,"},{"line_number":752,"context_line":"                     retries\u003dretries, backoff_rate\u003d1)"}],"source_content_type":"text/x-python","patch_set":4,"id":"b0903c0a_83f750e9","line":749,"range":{"start_line":749,"start_character":19,"end_line":749,"end_character":37},"updated":"2021-09-02 04:57:09.000000000","message":"timeout // interval","commit_id":"9912a95b58eee0860a9cdd94d0a07c6dae2b4e87"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"9f7a9786b247726da4bbd7d87a6264c920c27a5e","unresolved":false,"context_lines":[{"line_number":746,"context_line":"        \"\"\"Mount a replica share that is waiting for snapmirror initialize.\"\"\""},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"        interval \u003d 10"},{"line_number":749,"context_line":"        retries \u003d (timeout / interval or 1)"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"        @utils.retry(exception.ShareBusyException, interval\u003dinterval,"},{"line_number":752,"context_line":"                     retries\u003dretries, backoff_rate\u003d1)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ca322751_e2208df1","line":749,"range":{"start_line":749,"start_character":19,"end_line":749,"end_character":37},"in_reply_to":"b0903c0a_83f750e9","updated":"2021-09-02 18:10:19.000000000","message":"Done","commit_id":"9912a95b58eee0860a9cdd94d0a07c6dae2b4e87"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"109d0d32c8121aec11187205cc1266bcffa91c00","unresolved":true,"context_lines":[{"line_number":2053,"context_line":"                    helper.update_access(new_replica, share_name, access_rules)"},{"line_number":2054,"context_line":"                except Exception:"},{"line_number":2055,"context_line":"                    model_update[\u0027access_rules_status\u0027] \u003d ("},{"line_number":2056,"context_line":"                        constants.SHARE_INSTANCE_RULES_SYNCING)"},{"line_number":2057,"context_line":""},{"line_number":2058,"context_line":"        return model_update"},{"line_number":2059,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3d0952b9_c7851abc","line":2056,"range":{"start_line":2056,"start_character":34,"end_line":2056,"end_character":62},"updated":"2021-08-26 21:48:49.000000000","message":"is there a specific reason to set the rules to SHARE_INSTANCE_RULES_SYNCING in case of a failure?\nWill we be retrying this operation afterwards? If not, why don\u0027t set this to error right away?","commit_id":"e44970c3e0dac8a6627582c580ee99900d071756"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"5f80fa123d4d858e1472e77fc7343f213d603d91","unresolved":true,"context_lines":[{"line_number":2053,"context_line":"                    helper.update_access(new_replica, share_name, access_rules)"},{"line_number":2054,"context_line":"                except Exception:"},{"line_number":2055,"context_line":"                    model_update[\u0027access_rules_status\u0027] \u003d ("},{"line_number":2056,"context_line":"                        constants.SHARE_INSTANCE_RULES_SYNCING)"},{"line_number":2057,"context_line":""},{"line_number":2058,"context_line":"        return model_update"},{"line_number":2059,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"c9964f6f_e4d7e1fc","line":2056,"range":{"start_line":2056,"start_character":34,"end_line":2056,"end_character":62},"in_reply_to":"3d0952b9_c7851abc","updated":"2021-08-31 10:42:16.000000000","message":"Yeah, the idea is that it could be retried afterwards, like the promotion does in error applying the rules.","commit_id":"e44970c3e0dac8a6627582c580ee99900d071756"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ad5be5ccae77799ba8ab058d3967430f04d21c83","unresolved":false,"context_lines":[{"line_number":2053,"context_line":"                    helper.update_access(new_replica, share_name, access_rules)"},{"line_number":2054,"context_line":"                except Exception:"},{"line_number":2055,"context_line":"                    model_update[\u0027access_rules_status\u0027] \u003d ("},{"line_number":2056,"context_line":"                        constants.SHARE_INSTANCE_RULES_SYNCING)"},{"line_number":2057,"context_line":""},{"line_number":2058,"context_line":"        return model_update"},{"line_number":2059,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"6a9b06f1_6196cb5a","line":2056,"range":{"start_line":2056,"start_character":34,"end_line":2056,"end_character":62},"in_reply_to":"c9964f6f_e4d7e1fc","updated":"2021-09-03 11:04:18.000000000","message":"Ack","commit_id":"e44970c3e0dac8a6627582c580ee99900d071756"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"109d0d32c8121aec11187205cc1266bcffa91c00","unresolved":true,"context_lines":[{"line_number":2423,"context_line":"        replica[\u0027replica_state\u0027] \u003d constants.REPLICA_STATE_OUT_OF_SYNC"},{"line_number":2424,"context_line":"        replica[\u0027status\u0027] \u003d constants.STATUS_AVAILABLE"},{"line_number":2425,"context_line":"        if is_dr:"},{"line_number":2426,"context_line":"            replica[\u0027export_locations\u0027] \u003d []"},{"line_number":2427,"context_line":"        else:"},{"line_number":2428,"context_line":"            # NOTE(felipe_rodrigues): readable replica might be in an error"},{"line_number":2429,"context_line":"            # state without mounting and export. Retries to recover it."}],"source_content_type":"text/x-python","patch_set":2,"id":"627febf7_e31ac27c","line":2426,"updated":"2021-08-26 21:48:49.000000000","message":"since nothing else is done with the replica variable, you could already return here","commit_id":"e44970c3e0dac8a6627582c580ee99900d071756"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"5f80fa123d4d858e1472e77fc7343f213d603d91","unresolved":true,"context_lines":[{"line_number":2423,"context_line":"        replica[\u0027replica_state\u0027] \u003d constants.REPLICA_STATE_OUT_OF_SYNC"},{"line_number":2424,"context_line":"        replica[\u0027status\u0027] \u003d constants.STATUS_AVAILABLE"},{"line_number":2425,"context_line":"        if is_dr:"},{"line_number":2426,"context_line":"            replica[\u0027export_locations\u0027] \u003d []"},{"line_number":2427,"context_line":"        else:"},{"line_number":2428,"context_line":"            # NOTE(felipe_rodrigues): readable replica might be in an error"},{"line_number":2429,"context_line":"            # state without mounting and export. Retries to recover it."}],"source_content_type":"text/x-python","patch_set":2,"id":"6dad8cc1_aa9e0f44","line":2426,"in_reply_to":"627febf7_e31ac27c","updated":"2021-08-31 10:42:16.000000000","message":"done","commit_id":"e44970c3e0dac8a6627582c580ee99900d071756"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"109d0d32c8121aec11187205cc1266bcffa91c00","unresolved":true,"context_lines":[{"line_number":2460,"context_line":"                    replica, replica_volume_name, access_rules)"},{"line_number":2461,"context_line":"            except Exception:"},{"line_number":2462,"context_line":"                replica[\u0027access_rules_status\u0027] \u003d ("},{"line_number":2463,"context_line":"                    constants.SHARE_INSTANCE_RULES_SYNCING)"},{"line_number":2464,"context_line":"            else:"},{"line_number":2465,"context_line":"                replica[\u0027access_rules_status\u0027] \u003d constants.STATUS_ACTIVE"},{"line_number":2466,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f11cfd7_086f3ef5","line":2463,"range":{"start_line":2463,"start_character":30,"end_line":2463,"end_character":58},"updated":"2021-08-26 21:48:49.000000000","message":"is there a specific reason to set this rules to syncing?","commit_id":"e44970c3e0dac8a6627582c580ee99900d071756"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"5f80fa123d4d858e1472e77fc7343f213d603d91","unresolved":true,"context_lines":[{"line_number":2460,"context_line":"                    replica, replica_volume_name, access_rules)"},{"line_number":2461,"context_line":"            except Exception:"},{"line_number":2462,"context_line":"                replica[\u0027access_rules_status\u0027] \u003d ("},{"line_number":2463,"context_line":"                    constants.SHARE_INSTANCE_RULES_SYNCING)"},{"line_number":2464,"context_line":"            else:"},{"line_number":2465,"context_line":"                replica[\u0027access_rules_status\u0027] \u003d constants.STATUS_ACTIVE"},{"line_number":2466,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bdb69bb4_6bd5027c","line":2463,"range":{"start_line":2463,"start_character":30,"end_line":2463,"end_character":58},"in_reply_to":"7f11cfd7_086f3ef5","updated":"2021-08-31 10:42:16.000000000","message":"uhh.. the same reason as we do when promoting the replica. I think it may be used for retry later, instead of putting in an error state.","commit_id":"e44970c3e0dac8a6627582c580ee99900d071756"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"9f7a9786b247726da4bbd7d87a6264c920c27a5e","unresolved":false,"context_lines":[{"line_number":2460,"context_line":"                    replica, replica_volume_name, access_rules)"},{"line_number":2461,"context_line":"            except Exception:"},{"line_number":2462,"context_line":"                replica[\u0027access_rules_status\u0027] \u003d ("},{"line_number":2463,"context_line":"                    constants.SHARE_INSTANCE_RULES_SYNCING)"},{"line_number":2464,"context_line":"            else:"},{"line_number":2465,"context_line":"                replica[\u0027access_rules_status\u0027] \u003d constants.STATUS_ACTIVE"},{"line_number":2466,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"6c930c67_862c0fed","line":2463,"range":{"start_line":2463,"start_character":30,"end_line":2463,"end_character":58},"in_reply_to":"8862bafb_4d7d063d","updated":"2021-09-02 18:10:19.000000000","message":"Done. Changing to SHARE_INSTANCE_RULES_ERROR.","commit_id":"e44970c3e0dac8a6627582c580ee99900d071756"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bd05495796d06794712865a3077b025f2eca62c","unresolved":true,"context_lines":[{"line_number":2460,"context_line":"                    replica, replica_volume_name, access_rules)"},{"line_number":2461,"context_line":"            except Exception:"},{"line_number":2462,"context_line":"                replica[\u0027access_rules_status\u0027] \u003d ("},{"line_number":2463,"context_line":"                    constants.SHARE_INSTANCE_RULES_SYNCING)"},{"line_number":2464,"context_line":"            else:"},{"line_number":2465,"context_line":"                replica[\u0027access_rules_status\u0027] \u003d constants.STATUS_ACTIVE"},{"line_number":2466,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"8862bafb_4d7d063d","line":2463,"range":{"start_line":2463,"start_character":30,"end_line":2463,"end_character":58},"in_reply_to":"bdb69bb4_6bd5027c","updated":"2021-09-02 04:57:09.000000000","message":"Retry by who? I can\u0027t think any negative consequence of leaving this in a syncing state.. however, we\u0027re not logging any failures either - so it\u0027d make debugging this quite hard..","commit_id":"e44970c3e0dac8a6627582c580ee99900d071756"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bd05495796d06794712865a3077b025f2eca62c","unresolved":true,"context_lines":[{"line_number":2056,"context_line":"                try:"},{"line_number":2057,"context_line":"                    helper.update_access(new_replica, share_name, access_rules)"},{"line_number":2058,"context_line":"                except Exception:"},{"line_number":2059,"context_line":"                    model_update[\u0027access_rules_status\u0027] \u003d ("},{"line_number":2060,"context_line":"                        constants.SHARE_INSTANCE_RULES_SYNCING)"},{"line_number":2061,"context_line":""},{"line_number":2062,"context_line":"        return model_update"},{"line_number":2063,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"178cd8be_fa65cfa5","line":2060,"range":{"start_line":2059,"start_character":20,"end_line":2060,"end_character":63},"updated":"2021-09-02 04:57:09.000000000","message":"Why \"syncing\", and not \"error\"?","commit_id":"9912a95b58eee0860a9cdd94d0a07c6dae2b4e87"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"9f7a9786b247726da4bbd7d87a6264c920c27a5e","unresolved":false,"context_lines":[{"line_number":2056,"context_line":"                try:"},{"line_number":2057,"context_line":"                    helper.update_access(new_replica, share_name, access_rules)"},{"line_number":2058,"context_line":"                except Exception:"},{"line_number":2059,"context_line":"                    model_update[\u0027access_rules_status\u0027] \u003d ("},{"line_number":2060,"context_line":"                        constants.SHARE_INSTANCE_RULES_SYNCING)"},{"line_number":2061,"context_line":""},{"line_number":2062,"context_line":"        return model_update"},{"line_number":2063,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5cac9883_ad1c9c74","line":2060,"range":{"start_line":2059,"start_character":20,"end_line":2060,"end_character":63},"in_reply_to":"178cd8be_fa65cfa5","updated":"2021-09-02 18:10:19.000000000","message":"Makes sense. Changing to SHARE_INSTANCE_RULES_ERROR.","commit_id":"9912a95b58eee0860a9cdd94d0a07c6dae2b4e87"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bd05495796d06794712865a3077b025f2eca62c","unresolved":true,"context_lines":[{"line_number":2435,"context_line":"        replica_volume_name, replica_vserver, replica_backend \u003d ("},{"line_number":2436,"context_line":"            dm_session.get_backend_info_for_share(replica))"},{"line_number":2437,"context_line":"        replica_client \u003d data_motion.get_client_for_backend("},{"line_number":2438,"context_line":"            replica_backend, vserver_nae\u003dreplica_vserver)"},{"line_number":2439,"context_line":""},{"line_number":2440,"context_line":"        try:"},{"line_number":2441,"context_line":"            replica_config \u003d data_motion.get_backend_configuration("}],"source_content_type":"text/x-python","patch_set":4,"id":"4d3f088b_8fef0ab6","line":2438,"range":{"start_line":2438,"start_character":29,"end_line":2438,"end_character":40},"updated":"2021-09-02 04:57:09.000000000","message":"vserver_name\n\nStrange how this isn\u0027t a failure..","commit_id":"9912a95b58eee0860a9cdd94d0a07c6dae2b4e87"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"9f7a9786b247726da4bbd7d87a6264c920c27a5e","unresolved":false,"context_lines":[{"line_number":2435,"context_line":"        replica_volume_name, replica_vserver, replica_backend \u003d ("},{"line_number":2436,"context_line":"            dm_session.get_backend_info_for_share(replica))"},{"line_number":2437,"context_line":"        replica_client \u003d data_motion.get_client_for_backend("},{"line_number":2438,"context_line":"            replica_backend, vserver_nae\u003dreplica_vserver)"},{"line_number":2439,"context_line":""},{"line_number":2440,"context_line":"        try:"},{"line_number":2441,"context_line":"            replica_config \u003d data_motion.get_backend_configuration("}],"source_content_type":"text/x-python","patch_set":4,"id":"5a356723_48c76953","line":2438,"range":{"start_line":2438,"start_character":29,"end_line":2438,"end_character":40},"in_reply_to":"4d3f088b_8fef0ab6","updated":"2021-09-02 18:10:19.000000000","message":"Yes, it\u0027s weird to me too. I\u0027ll fix.","commit_id":"9912a95b58eee0860a9cdd94d0a07c6dae2b4e87"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bd05495796d06794712865a3077b025f2eca62c","unresolved":true,"context_lines":[{"line_number":2468,"context_line":"                replica, replica_volume_name, access_rules)"},{"line_number":2469,"context_line":"        except Exception:"},{"line_number":2470,"context_line":"            replica[\u0027access_rules_status\u0027] \u003d ("},{"line_number":2471,"context_line":"                constants.SHARE_INSTANCE_RULES_SYNCING)"},{"line_number":2472,"context_line":"        else:"},{"line_number":2473,"context_line":"            replica[\u0027access_rules_status\u0027] \u003d constants.STATUS_ACTIVE"},{"line_number":2474,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"4a845a0a_f6a8585a","line":2471,"range":{"start_line":2471,"start_character":26,"end_line":2471,"end_character":54},"updated":"2021-09-02 04:57:09.000000000","message":"why syncing and not \"error\"?","commit_id":"9912a95b58eee0860a9cdd94d0a07c6dae2b4e87"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"9f7a9786b247726da4bbd7d87a6264c920c27a5e","unresolved":false,"context_lines":[{"line_number":2468,"context_line":"                replica, replica_volume_name, access_rules)"},{"line_number":2469,"context_line":"        except Exception:"},{"line_number":2470,"context_line":"            replica[\u0027access_rules_status\u0027] \u003d ("},{"line_number":2471,"context_line":"                constants.SHARE_INSTANCE_RULES_SYNCING)"},{"line_number":2472,"context_line":"        else:"},{"line_number":2473,"context_line":"            replica[\u0027access_rules_status\u0027] \u003d constants.STATUS_ACTIVE"},{"line_number":2474,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"2c18baf7_2be90ca9","line":2471,"range":{"start_line":2471,"start_character":26,"end_line":2471,"end_character":54},"in_reply_to":"4a845a0a_f6a8585a","updated":"2021-09-02 18:10:19.000000000","message":"Makes sense. Changing to SHARE_INSTANCE_RULES_ERROR.","commit_id":"9912a95b58eee0860a9cdd94d0a07c6dae2b4e87"}],"manila/share/drivers/netapp/options.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bd05495796d06794712865a3077b025f2eca62c","unresolved":true,"context_lines":[{"line_number":214,"context_line":"               min\u003d0,"},{"line_number":215,"context_line":"               default\u003d3600,  # One Hour"},{"line_number":216,"context_line":"               help\u003d\u0027The maximum time in seconds to wait for mounting \u0027"},{"line_number":217,"context_line":"                    \u0027a replica that is being initialized its snapmirror \u0027"},{"line_number":218,"context_line":"                    \u0027relationship.\u0027),"},{"line_number":219,"context_line":"]"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":4,"id":"80f9b1fe_5fe62e96","line":218,"range":{"start_line":217,"start_character":30,"end_line":218,"end_character":33},"updated":"2021-09-02 04:57:09.000000000","message":"this isn\u0027t needed i think..","commit_id":"9912a95b58eee0860a9cdd94d0a07c6dae2b4e87"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"9f7a9786b247726da4bbd7d87a6264c920c27a5e","unresolved":false,"context_lines":[{"line_number":214,"context_line":"               min\u003d0,"},{"line_number":215,"context_line":"               default\u003d3600,  # One Hour"},{"line_number":216,"context_line":"               help\u003d\u0027The maximum time in seconds to wait for mounting \u0027"},{"line_number":217,"context_line":"                    \u0027a replica that is being initialized its snapmirror \u0027"},{"line_number":218,"context_line":"                    \u0027relationship.\u0027),"},{"line_number":219,"context_line":"]"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":4,"id":"53c16329_f68294cc","line":218,"range":{"start_line":217,"start_character":30,"end_line":218,"end_character":33},"in_reply_to":"80f9b1fe_5fe62e96","updated":"2021-09-02 18:10:19.000000000","message":"Done","commit_id":"9912a95b58eee0860a9cdd94d0a07c6dae2b4e87"}],"manila/tests/share/drivers/netapp/dataontap/cluster_mode/test_data_motion.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bd05495796d06794712865a3077b025f2eca62c","unresolved":true,"context_lines":[{"line_number":200,"context_line":"        )"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    @ddt.data(True, False)"},{"line_number":203,"context_line":"    def test_create_snapmirror(self, mount):"},{"line_number":204,"context_line":"        mock_dest_client \u003d mock.Mock()"},{"line_number":205,"context_line":"        self.mock_object(data_motion, \u0027get_client_for_backend\u0027,"},{"line_number":206,"context_line":"                         mock.Mock(return_value\u003dmock_dest_client))"}],"source_content_type":"text/x-python","patch_set":4,"id":"b6cdc845_2ff96887","line":203,"range":{"start_line":203,"start_character":29,"end_line":203,"end_character":30},"updated":"2021-09-02 04:57:09.000000000","message":"_mount\n\n\nddt inflates the test case name with the parameters:\n\n test_create_snapmirror_1_True\n test_create_snapmirror_2_False\n\n\nso it\u0027d be more descriptive if you added what the parameters are for:\n\n test_create_snapmirror_mount_1_True\n test_create_snapmirror_mount_2_False","commit_id":"9912a95b58eee0860a9cdd94d0a07c6dae2b4e87"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"9f7a9786b247726da4bbd7d87a6264c920c27a5e","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        )"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    @ddt.data(True, False)"},{"line_number":203,"context_line":"    def test_create_snapmirror(self, mount):"},{"line_number":204,"context_line":"        mock_dest_client \u003d mock.Mock()"},{"line_number":205,"context_line":"        self.mock_object(data_motion, \u0027get_client_for_backend\u0027,"},{"line_number":206,"context_line":"                         mock.Mock(return_value\u003dmock_dest_client))"}],"source_content_type":"text/x-python","patch_set":4,"id":"c904499e_bec2218c","line":203,"range":{"start_line":203,"start_character":29,"end_line":203,"end_character":30},"in_reply_to":"b6cdc845_2ff96887","updated":"2021-09-02 18:10:19.000000000","message":"Done","commit_id":"9912a95b58eee0860a9cdd94d0a07c6dae2b4e87"}],"manila/tests/share/drivers/netapp/dataontap/cluster_mode/test_lib_base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bd05495796d06794712865a3077b025f2eca62c","unresolved":true,"context_lines":[{"line_number":1815,"context_line":"         .assert_called_once_with(qos_policy_name))"},{"line_number":1816,"context_line":"        self.assertEqual(0, lib_base.LOG.info.call_count)"},{"line_number":1817,"context_line":""},{"line_number":1818,"context_line":"    def test__delete_share_no_remove(self):"},{"line_number":1819,"context_line":""},{"line_number":1820,"context_line":"        vserver_client \u003d mock.Mock()"},{"line_number":1821,"context_line":"        mock_share_exists \u003d self.mock_object(self.library,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3db2b2eb_7fabb752","line":1818,"range":{"start_line":1818,"start_character":30,"end_line":1818,"end_character":36},"updated":"2021-09-02 04:57:09.000000000","message":"_qos?","commit_id":"9912a95b58eee0860a9cdd94d0a07c6dae2b4e87"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"9f7a9786b247726da4bbd7d87a6264c920c27a5e","unresolved":false,"context_lines":[{"line_number":1815,"context_line":"         .assert_called_once_with(qos_policy_name))"},{"line_number":1816,"context_line":"        self.assertEqual(0, lib_base.LOG.info.call_count)"},{"line_number":1817,"context_line":""},{"line_number":1818,"context_line":"    def test__delete_share_no_remove(self):"},{"line_number":1819,"context_line":""},{"line_number":1820,"context_line":"        vserver_client \u003d mock.Mock()"},{"line_number":1821,"context_line":"        mock_share_exists \u003d self.mock_object(self.library,"}],"source_content_type":"text/x-python","patch_set":4,"id":"c0c3cbe8_b24379ee","line":1818,"range":{"start_line":1818,"start_character":30,"end_line":1818,"end_character":36},"in_reply_to":"3db2b2eb_7fabb752","updated":"2021-09-02 18:10:19.000000000","message":"I talked to Felipe and the idea here is to test delete share without remove export and qos so I will rename this function to `test__delete_share_no_remove_qos_and_export`","commit_id":"9912a95b58eee0860a9cdd94d0a07c6dae2b4e87"}],"releasenotes/notes/netapp-readable-replica-cb7d5460ad7b3b0e.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"109d0d32c8121aec11187205cc1266bcffa91c00","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp ONTAP driver: added support for `readable` replication. The driver"},{"line_number":5,"context_line":"    will keep having support for the `dr` type as well, being the driver"},{"line_number":6,"context_line":"    replication type a list containing both."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fee0fbe2_97b3f9d5","line":5,"range":{"start_line":5,"start_character":9,"end_line":5,"end_character":14},"updated":"2021-08-26 21:48:49.000000000","message":"continue","commit_id":"e44970c3e0dac8a6627582c580ee99900d071756"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"5f80fa123d4d858e1472e77fc7343f213d603d91","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp ONTAP driver: added support for `readable` replication. The driver"},{"line_number":5,"context_line":"    will keep having support for the `dr` type as well, being the driver"},{"line_number":6,"context_line":"    replication type a list containing both."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"976dc1f3_d292b6d2","line":5,"range":{"start_line":5,"start_character":9,"end_line":5,"end_character":14},"in_reply_to":"fee0fbe2_97b3f9d5","updated":"2021-08-31 10:42:16.000000000","message":"done","commit_id":"e44970c3e0dac8a6627582c580ee99900d071756"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"109d0d32c8121aec11187205cc1266bcffa91c00","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp ONTAP driver: added support for `readable` replication. The driver"},{"line_number":5,"context_line":"    will keep having support for the `dr` type as well, being the driver"},{"line_number":6,"context_line":"    replication type a list containing both."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9b6db317_7acdeade","line":6,"range":{"start_line":5,"start_character":56,"end_line":6,"end_character":44},"updated":"2021-08-26 21:48:49.000000000","message":"Perhaps we don\u0027t need to keep this phrase.","commit_id":"e44970c3e0dac8a6627582c580ee99900d071756"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"5f80fa123d4d858e1472e77fc7343f213d603d91","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp ONTAP driver: added support for `readable` replication. The driver"},{"line_number":5,"context_line":"    will keep having support for the `dr` type as well, being the driver"},{"line_number":6,"context_line":"    replication type a list containing both."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b4b79c23_c6ae041d","line":6,"range":{"start_line":5,"start_character":56,"end_line":6,"end_character":44},"in_reply_to":"9b6db317_7acdeade","updated":"2021-08-31 10:42:16.000000000","message":"done","commit_id":"e44970c3e0dac8a6627582c580ee99900d071756"}]}