)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":25,"context_line":"- The NetApp ONTAP driver can now reuse network allocations from"},{"line_number":26,"context_line":"the source share server in case a share network change wasn\u0027t"},{"line_number":27,"context_line":"identified."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Change-Id: Idf1581d933d11280287f6801fd4aa886a627f66f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"45d9fba7_2699d41d","line":28,"updated":"2021-08-27 12:20:24.000000000","message":"Depends-on with Core change ?","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":25,"context_line":"- The NetApp ONTAP driver can now reuse network allocations from"},{"line_number":26,"context_line":"the source share server in case a share network change wasn\u0027t"},{"line_number":27,"context_line":"identified."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Change-Id: Idf1581d933d11280287f6801fd4aa886a627f66f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"76aaa635_4c91d6ab","line":28,"in_reply_to":"45d9fba7_2699d41d","updated":"2021-08-28 21:57:50.000000000","message":"This change is rebased on top of the core change, so the dependency is already sinalized somehow... But the depends-on can be added as well","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"}],"manila/share/drivers/netapp/dataontap/client/api.py":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":126,"context_line":"        self._protocol \u003d transport_type.lower()"},{"line_number":127,"context_line":"        self._refresh_conn \u003d True"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def get_server_type(self):"},{"line_number":130,"context_line":"        return self._server_type"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def set_server_type(self, server_type):"}],"source_content_type":"text/x-python","patch_set":10,"id":"119f616a_eae1afa3","line":129,"range":{"start_line":129,"start_character":8,"end_line":129,"end_character":23},"updated":"2021-08-27 12:20:24.000000000","message":"add documentaion: \"\"\"bla bla.\"\"\"","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        self._protocol \u003d transport_type.lower()"},{"line_number":127,"context_line":"        self._refresh_conn \u003d True"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def get_server_type(self):"},{"line_number":130,"context_line":"        return self._server_type"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def set_server_type(self, server_type):"}],"source_content_type":"text/x-python","patch_set":10,"id":"aa694390_db97f146","line":129,"range":{"start_line":129,"start_character":8,"end_line":129,"end_character":23},"in_reply_to":"119f616a_eae1afa3","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":219,"context_line":"        \"\"\""},{"line_number":220,"context_line":"        pass"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def _build_session(self):"},{"line_number":223,"context_line":"        if self._auth_style \u003d\u003d STYLE_LOGIN_PASSWORD:"},{"line_number":224,"context_line":"            auth_handler \u003d self._create_basic_auth_handler()"},{"line_number":225,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"bb44da29_936bdd16","line":222,"range":{"start_line":222,"start_character":8,"end_line":222,"end_character":22},"updated":"2021-08-27 12:20:24.000000000","message":"add documentaion: \"\"\"bla bla.\"\"\"","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        \"\"\""},{"line_number":220,"context_line":"        pass"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def _build_session(self):"},{"line_number":223,"context_line":"        if self._auth_style \u003d\u003d STYLE_LOGIN_PASSWORD:"},{"line_number":224,"context_line":"            auth_handler \u003d self._create_basic_auth_handler()"},{"line_number":225,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"bbf58f57_873bf884","line":222,"range":{"start_line":222,"start_character":8,"end_line":222,"end_character":22},"in_reply_to":"bb44da29_936bdd16","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        self._session.headers \u003d headers"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    def _build_headers(self):"},{"line_number":236,"context_line":"        raise NotImplementedError()"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def _create_basic_auth_handler(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9c91db3d_c4411159","line":235,"range":{"start_line":235,"start_character":8,"end_line":235,"end_character":22},"updated":"2021-08-27 12:20:24.000000000","message":"add documentaion: \"\"\"bla bla.\"\"\"","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        self._session.headers \u003d headers"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    def _build_headers(self):"},{"line_number":236,"context_line":"        raise NotImplementedError()"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def _create_basic_auth_handler(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1650ca50_3fbb02dd","line":235,"range":{"start_line":235,"start_character":8,"end_line":235,"end_character":22},"in_reply_to":"9c91db3d_c4411159","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":235,"context_line":"    def _build_headers(self):"},{"line_number":236,"context_line":"        raise NotImplementedError()"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def _create_basic_auth_handler(self):"},{"line_number":239,"context_line":"        return auth.HTTPBasicAuth(self._username, self._password)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def _create_certificate_auth_handler(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"77726b6e_a570761f","line":238,"range":{"start_line":238,"start_character":8,"end_line":238,"end_character":34},"updated":"2021-08-27 12:20:24.000000000","message":"add documentaion: \"\"\"bla bla.\"\"\"","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":235,"context_line":"    def _build_headers(self):"},{"line_number":236,"context_line":"        raise NotImplementedError()"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def _create_basic_auth_handler(self):"},{"line_number":239,"context_line":"        return auth.HTTPBasicAuth(self._username, self._password)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def _create_certificate_auth_handler(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5b0b3abd_7fba0830","line":238,"range":{"start_line":238,"start_character":8,"end_line":238,"end_character":34},"in_reply_to":"77726b6e_a570761f","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":238,"context_line":"    def _create_basic_auth_handler(self):"},{"line_number":239,"context_line":"        return auth.HTTPBasicAuth(self._username, self._password)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def _create_certificate_auth_handler(self):"},{"line_number":242,"context_line":"        raise NotImplementedError()"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    def __str__(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"74f99983_f9f09e69","line":241,"range":{"start_line":241,"start_character":8,"end_line":241,"end_character":40},"updated":"2021-08-27 12:20:24.000000000","message":"add documentaion: \"\"\"bla bla.\"\"\"","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":238,"context_line":"    def _create_basic_auth_handler(self):"},{"line_number":239,"context_line":"        return auth.HTTPBasicAuth(self._username, self._password)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def _create_certificate_auth_handler(self):"},{"line_number":242,"context_line":"        raise NotImplementedError()"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    def __str__(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"dd5f9dc6_a6f40d10","line":241,"range":{"start_line":241,"start_character":8,"end_line":241,"end_character":40},"in_reply_to":"74f99983_f9f09e69","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":241,"context_line":"    def _create_certificate_auth_handler(self):"},{"line_number":242,"context_line":"        raise NotImplementedError()"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    def __str__(self):"},{"line_number":245,"context_line":"        return \"server: %s\" % (self._host)"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"dc374510_7cf40155","line":244,"range":{"start_line":244,"start_character":8,"end_line":244,"end_character":15},"updated":"2021-08-27 12:20:24.000000000","message":"add documentaion: \"\"\"bla bla.\"\"\"","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":241,"context_line":"    def _create_certificate_auth_handler(self):"},{"line_number":242,"context_line":"        raise NotImplementedError()"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    def __str__(self):"},{"line_number":245,"context_line":"        return \"server: %s\" % (self._host)"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"d7de978c_4fec838f","line":244,"range":{"start_line":244,"start_character":8,"end_line":244,"end_character":15},"in_reply_to":"dc374510_7cf40155","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":265,"context_line":"        self.set_server_type(server_type)"},{"line_number":266,"context_line":"        self._set_port()"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def _set_port(self):"},{"line_number":269,"context_line":"        if self._protocol \u003d\u003d TRANSPORT_TYPE_HTTP:"},{"line_number":270,"context_line":"            if self._server_type \u003d\u003d ZapiClient.SERVER_TYPE_FILER:"},{"line_number":271,"context_line":"                self.set_port(80)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7b7bf42a_a7f73c1a","line":268,"range":{"start_line":268,"start_character":8,"end_line":268,"end_character":17},"updated":"2021-08-27 12:20:24.000000000","message":"add documentaion: \"\"\"bla bla.\"\"\"","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        self.set_server_type(server_type)"},{"line_number":266,"context_line":"        self._set_port()"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def _set_port(self):"},{"line_number":269,"context_line":"        if self._protocol \u003d\u003d TRANSPORT_TYPE_HTTP:"},{"line_number":270,"context_line":"            if self._server_type \u003d\u003d ZapiClient.SERVER_TYPE_FILER:"},{"line_number":271,"context_line":"                self.set_port(80)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9e616621_9eb4b677","line":268,"range":{"start_line":268,"start_character":8,"end_line":268,"end_character":17},"in_reply_to":"7b7bf42a_a7f73c1a","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":415,"context_line":"        processed_response \u003d self._parse_response(response)"},{"line_number":416,"context_line":"        return processed_response.get_child_by_name(\u0027results\u0027)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"    def _get_url(self):"},{"line_number":419,"context_line":"        host \u003d self._host"},{"line_number":420,"context_line":"        if \u0027:\u0027 in host:"},{"line_number":421,"context_line":"            host \u003d \u0027[%s]\u0027 % host"}],"source_content_type":"text/x-python","patch_set":10,"id":"fd677d81_1e868923","line":418,"range":{"start_line":418,"start_character":8,"end_line":418,"end_character":16},"updated":"2021-08-27 12:20:24.000000000","message":"add documentaion: \"\"\"bla bla.\"\"\"","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":415,"context_line":"        processed_response \u003d self._parse_response(response)"},{"line_number":416,"context_line":"        return processed_response.get_child_by_name(\u0027results\u0027)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"    def _get_url(self):"},{"line_number":419,"context_line":"        host \u003d self._host"},{"line_number":420,"context_line":"        if \u0027:\u0027 in host:"},{"line_number":421,"context_line":"            host \u003d \u0027[%s]\u0027 % host"}],"source_content_type":"text/x-python","patch_set":10,"id":"83d264a3_17967135","line":418,"range":{"start_line":418,"start_character":8,"end_line":418,"end_character":16},"in_reply_to":"fd677d81_1e868923","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":421,"context_line":"            host \u003d \u0027[%s]\u0027 % host"},{"line_number":422,"context_line":"        return \u0027%s://%s:%s/%s\u0027 % (self._protocol, host, self._port, self._url)"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"    def _build_headers(self):"},{"line_number":425,"context_line":"        return {\u0027Content-Type\u0027: \u0027text/xml\u0027}"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"891f6ca9_8938357a","line":424,"range":{"start_line":424,"start_character":8,"end_line":424,"end_character":22},"updated":"2021-08-27 12:20:24.000000000","message":"add documentaion: \"\"\"bla bla.\"\"\"","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":421,"context_line":"            host \u003d \u0027[%s]\u0027 % host"},{"line_number":422,"context_line":"        return \u0027%s://%s:%s/%s\u0027 % (self._protocol, host, self._port, self._url)"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"    def _build_headers(self):"},{"line_number":425,"context_line":"        return {\u0027Content-Type\u0027: \u0027text/xml\u0027}"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"e8ce4b85_5cdb7a47","line":424,"range":{"start_line":424,"start_character":8,"end_line":424,"end_character":22},"in_reply_to":"891f6ca9_8938357a","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":437,"context_line":"            port\u003dport, trace\u003dtrace, api_trace_pattern\u003dapi_trace_pattern)"},{"line_number":438,"context_line":"        self._set_port()"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"    def _set_port(self):"},{"line_number":441,"context_line":"        if self._protocol \u003d\u003d TRANSPORT_TYPE_HTTP:"},{"line_number":442,"context_line":"            self.set_port(80)"},{"line_number":443,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"100c9ad4_c1c6810d","line":440,"range":{"start_line":440,"start_character":8,"end_line":440,"end_character":17},"updated":"2021-08-27 12:20:24.000000000","message":"add documentaion: \"\"\"bla bla.\"\"\"","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":493,"context_line":"            }"},{"line_number":494,"context_line":"            LOG.debug(message)"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        query \u003d api_args.get(\"query\") if api_args else None"},{"line_number":497,"context_line":"        if query:"},{"line_number":498,"context_line":"            action_url \u003d self._add_query_params_to_url("},{"line_number":499,"context_line":"                action_url, api_args[\u0027query\u0027])"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"        url \u003d self._get_base_url() + action_url"},{"line_number":502,"context_line":"        data \u003d jsonutils.dumps(data) if data else data"}],"source_content_type":"text/x-python","patch_set":10,"id":"63337473_28c9cabf","line":499,"range":{"start_line":496,"start_character":7,"end_line":499,"end_character":46},"updated":"2021-08-27 12:20:24.000000000","message":"you are adding the query params after logging the request. So, the LOG message cannot reflect the entire request. Please, move the sequence.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":493,"context_line":"            }"},{"line_number":494,"context_line":"            LOG.debug(message)"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        query \u003d api_args.get(\"query\") if api_args else None"},{"line_number":497,"context_line":"        if query:"},{"line_number":498,"context_line":"            action_url \u003d self._add_query_params_to_url("},{"line_number":499,"context_line":"                action_url, api_args[\u0027query\u0027])"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"        url \u003d self._get_base_url() + action_url"},{"line_number":502,"context_line":"        data \u003d jsonutils.dumps(data) if data else data"}],"source_content_type":"text/x-python","patch_set":10,"id":"f428f156_5d6f669c","line":499,"range":{"start_line":496,"start_character":7,"end_line":499,"end_character":46},"in_reply_to":"63337473_28c9cabf","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"e1a388c56315d7dad3aed0773fb3877d08092ee1","unresolved":true,"context_lines":[{"line_number":469,"context_line":"        if na_element and not isinstance(na_element, NaElement):"},{"line_number":470,"context_line":"            raise ValueError(\u0027NaElement must be supplied to invoke API\u0027)"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"        api_name \u003d na_element.get_name()"},{"line_number":473,"context_line":"        api_name_matches_regex \u003d (re.match(self._api_trace_pattern, api_name)"},{"line_number":474,"context_line":"                                  is not None)"},{"line_number":475,"context_line":"        data \u003d api_args.get(\"body\") if api_args else {}"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"        if (not hasattr(self, \u0027_session\u0027) or not self._session"},{"line_number":478,"context_line":"                or self._refresh_conn):"},{"line_number":479,"context_line":"            self._build_session()"},{"line_number":480,"context_line":"        request_method, action_url \u003d self._get_request_info("},{"line_number":481,"context_line":"            api_name, self._session)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        url_params \u003d api_args.get(\"url_params\") if api_args else None"},{"line_number":484,"context_line":"        if url_params:"},{"line_number":485,"context_line":"            action_url \u003d action_url % url_params"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"        if self._trace and api_name_matches_regex:"},{"line_number":488,"context_line":"            message \u003d (\"Request: %(method)s %(url)s. Request body \""},{"line_number":489,"context_line":"                       \"%(body)s\") % {"},{"line_number":490,"context_line":"                \"method\": request_method,"},{"line_number":491,"context_line":"                \"url\": action_url,"},{"line_number":492,"context_line":"                \"body\": data"},{"line_number":493,"context_line":"            }"},{"line_number":494,"context_line":"            LOG.debug(message)"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        query \u003d api_args.get(\"query\") if api_args else None"},{"line_number":497,"context_line":"        if query:"},{"line_number":498,"context_line":"            action_url \u003d self._add_query_params_to_url("},{"line_number":499,"context_line":"                action_url, api_args[\u0027query\u0027])"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"        url \u003d self._get_base_url() + action_url"},{"line_number":502,"context_line":"        data \u003d jsonutils.dumps(data) if data else data"},{"line_number":503,"context_line":"        try:"},{"line_number":504,"context_line":"            if hasattr(self, \u0027_timeout\u0027):"},{"line_number":505,"context_line":"                response \u003d request_method("}],"source_content_type":"text/x-python","patch_set":10,"id":"2a5192dc_7b6969f5","line":502,"range":{"start_line":472,"start_character":8,"end_line":502,"end_character":54},"updated":"2021-08-25 14:37:16.000000000","message":"wouldn\u0027t it be better if the url and data mounting/parsing were on another method?","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":469,"context_line":"        if na_element and not isinstance(na_element, NaElement):"},{"line_number":470,"context_line":"            raise ValueError(\u0027NaElement must be supplied to invoke API\u0027)"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"        api_name \u003d na_element.get_name()"},{"line_number":473,"context_line":"        api_name_matches_regex \u003d (re.match(self._api_trace_pattern, api_name)"},{"line_number":474,"context_line":"                                  is not None)"},{"line_number":475,"context_line":"        data \u003d api_args.get(\"body\") if api_args else {}"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"        if (not hasattr(self, \u0027_session\u0027) or not self._session"},{"line_number":478,"context_line":"                or self._refresh_conn):"},{"line_number":479,"context_line":"            self._build_session()"},{"line_number":480,"context_line":"        request_method, action_url \u003d self._get_request_info("},{"line_number":481,"context_line":"            api_name, self._session)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        url_params \u003d api_args.get(\"url_params\") if api_args else None"},{"line_number":484,"context_line":"        if url_params:"},{"line_number":485,"context_line":"            action_url \u003d action_url % url_params"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"        if self._trace and api_name_matches_regex:"},{"line_number":488,"context_line":"            message \u003d (\"Request: %(method)s %(url)s. Request body \""},{"line_number":489,"context_line":"                       \"%(body)s\") % {"},{"line_number":490,"context_line":"                \"method\": request_method,"},{"line_number":491,"context_line":"                \"url\": action_url,"},{"line_number":492,"context_line":"                \"body\": data"},{"line_number":493,"context_line":"            }"},{"line_number":494,"context_line":"            LOG.debug(message)"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        query \u003d api_args.get(\"query\") if api_args else None"},{"line_number":497,"context_line":"        if query:"},{"line_number":498,"context_line":"            action_url \u003d self._add_query_params_to_url("},{"line_number":499,"context_line":"                action_url, api_args[\u0027query\u0027])"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"        url \u003d self._get_base_url() + action_url"},{"line_number":502,"context_line":"        data \u003d jsonutils.dumps(data) if data else data"},{"line_number":503,"context_line":"        try:"},{"line_number":504,"context_line":"            if hasattr(self, \u0027_timeout\u0027):"},{"line_number":505,"context_line":"                response \u003d request_method("}],"source_content_type":"text/x-python","patch_set":10,"id":"cc6c1b27_5c1ac5b8","line":502,"range":{"start_line":472,"start_character":8,"end_line":502,"end_character":54},"in_reply_to":"2a5192dc_7b6969f5","updated":"2021-08-28 21:57:50.000000000","message":"it would be the case... I\u0027d say I kept this way because there aren\u0027t other places needing to mount a url to send the request, neither to transform the body...","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":542,"context_line":"                   or \u0027Execution status is failed due to unknown reason\u0027)"},{"line_number":543,"context_line":"        raise NaApiError(code, msg)"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"    def _get_base_url(self):"},{"line_number":546,"context_line":"        host \u003d self._host"},{"line_number":547,"context_line":"        if \u0027:\u0027 in host:"},{"line_number":548,"context_line":"            host \u003d \u0027[%s]\u0027 % host"}],"source_content_type":"text/x-python","patch_set":10,"id":"49a6deb3_8acdb775","line":545,"range":{"start_line":545,"start_character":8,"end_line":545,"end_character":21},"updated":"2021-08-27 12:20:24.000000000","message":"add documentaion: \"\"\"bla bla.\"\"\"","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":542,"context_line":"                   or \u0027Execution status is failed due to unknown reason\u0027)"},{"line_number":543,"context_line":"        raise NaApiError(code, msg)"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"    def _get_base_url(self):"},{"line_number":546,"context_line":"        host \u003d self._host"},{"line_number":547,"context_line":"        if \u0027:\u0027 in host:"},{"line_number":548,"context_line":"            host \u003d \u0027[%s]\u0027 % host"}],"source_content_type":"text/x-python","patch_set":10,"id":"d17ab6dc_ddd98a96","line":545,"range":{"start_line":545,"start_character":8,"end_line":545,"end_character":21},"in_reply_to":"49a6deb3_8acdb775","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":548,"context_line":"            host \u003d \u0027[%s]\u0027 % host"},{"line_number":549,"context_line":"        return \u0027%s://%s:%s/api/\u0027 % (self._protocol, host, self._port)"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"    def _build_headers(self):"},{"line_number":552,"context_line":"        headers \u003d {"},{"line_number":553,"context_line":"            \"Accept\": \"application/json\","},{"line_number":554,"context_line":"            \"Content-Type\": \"application/json\""}],"source_content_type":"text/x-python","patch_set":10,"id":"df3599b7_bd3ad3cd","line":551,"range":{"start_line":551,"start_character":8,"end_line":551,"end_character":22},"updated":"2021-08-27 12:20:24.000000000","message":"add documentaion: \"\"\"bla bla.\"\"\"","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":548,"context_line":"            host \u003d \u0027[%s]\u0027 % host"},{"line_number":549,"context_line":"        return \u0027%s://%s:%s/api/\u0027 % (self._protocol, host, self._port)"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"    def _build_headers(self):"},{"line_number":552,"context_line":"        headers \u003d {"},{"line_number":553,"context_line":"            \"Accept\": \"application/json\","},{"line_number":554,"context_line":"            \"Content-Type\": \"application/json\""}],"source_content_type":"text/x-python","patch_set":10,"id":"9f2bed37_21c1b7a7","line":551,"range":{"start_line":551,"start_character":8,"end_line":551,"end_character":22},"in_reply_to":"df3599b7_bd3ad3cd","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a112b4545d63b298cbc835f5825e6d4c7de1c8db","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"dce5d096_d1434eb3","updated":"2021-09-07 19:39:37.000000000","message":"The unit test coverage for this file\u0027s pretty low - including the new methods you\u0027re adding/refactoring: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_26a/803624/14/check/openstack-tox-cover/26a65d1/cover/manila_share_drivers_netapp_dataontap_client_api_py.html","commit_id":"74d5a1b2cf81090d96e12910d880c1c60a96f0ab"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d4d26034aa76334bfec707402542f5e12585af8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"53dd3b16_e53f3fcb","in_reply_to":"dce5d096_d1434eb3","updated":"2021-09-07 20:02:40.000000000","message":"Ack. Will work on it","commit_id":"74d5a1b2cf81090d96e12910d880c1c60a96f0ab"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"85a001429790ddc78a84195d28ed69f5d2c6b38c","unresolved":true,"context_lines":[{"line_number":105,"context_line":"    def set_style(self, style):"},{"line_number":106,"context_line":"        \"\"\"Set the authorization style for communicating with the server."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        Supports basic_auth for now. Certificate_auth mode to be done."},{"line_number":109,"context_line":"        \"\"\""},{"line_number":110,"context_line":"        if style.lower() not in (STYLE_LOGIN_PASSWORD, STYLE_CERTIFICATE):"},{"line_number":111,"context_line":"            raise ValueError(\u0027Unsupported authentication style\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"7ea6ccd2_9e5662b3","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":69},"updated":"2021-09-08 13:09:37.000000000","message":"seems enabled to me","commit_id":"74d5a1b2cf81090d96e12910d880c1c60a96f0ab"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ccb78455a3496840eae6419611d9cb71df4cfa8d","unresolved":true,"context_lines":[{"line_number":2855,"context_line":"    @na_utils.trace"},{"line_number":2856,"context_line":"    def get_volume_junction_path(self, volume_name, is_style_cifs\u003dFalse):"},{"line_number":2857,"context_line":"        \"\"\"Gets a volume junction path.\"\"\""},{"line_number":2858,"context_line":"        # api_args \u003d {"},{"line_number":2859,"context_line":"        #     \u0027volume\u0027: volume_name,"},{"line_number":2860,"context_line":"        #     \u0027is-style-cifs\u0027: six.text_type(is_style_cifs).lower(),"},{"line_number":2861,"context_line":"        # }"},{"line_number":2862,"context_line":"        # result \u003d self.send_request(\u0027volume-get-volume-path\u0027, api_args)"},{"line_number":2863,"context_line":"        # volume \u003d self.get_volume(volume_name)"},{"line_number":2864,"context_line":"        # return volume[\u0027junction-path\u0027]"},{"line_number":2865,"context_line":"        # NOTE(carloss): UNDO THIS AFTER TESTS WITH NEW ONTAP VERSION!"},{"line_number":2866,"context_line":""},{"line_number":2867,"context_line":"        api_args \u003d {"},{"line_number":2868,"context_line":"            \u0027volume\u0027: volume_name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"f3ba0967_eee76027","line":2865,"range":{"start_line":2858,"start_character":0,"end_line":2865,"end_character":70},"updated":"2021-08-16 12:34:23.000000000","message":"need to remove this :)","commit_id":"c6abbd14f1656cf3f7a20fd069a8427a3a07d28a"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"40cb2b31a995e5150084b53bc9a6ada0b69945ef","unresolved":true,"context_lines":[{"line_number":5461,"context_line":""},{"line_number":5462,"context_line":"        :param request_data: the body to be sent to the request."},{"line_number":5463,"context_line":"        :param headers: additional headers to the request."},{"line_number":5464,"context_line":"        :param query: filters to the request."},{"line_number":5465,"context_line":"        \"\"\""},{"line_number":5466,"context_line":"        request \u003d {"},{"line_number":5467,"context_line":"            \"body\": request_data,"}],"source_content_type":"text/x-python","patch_set":4,"id":"4a636de7_87c5f444","line":5464,"updated":"2021-08-12 12:38:15.000000000","message":"I believe you may have forgotten to add the `url_params` here","commit_id":"c6abbd14f1656cf3f7a20fd069a8427a3a07d28a"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"e1a388c56315d7dad3aed0773fb3877d08092ee1","unresolved":true,"context_lines":[{"line_number":2855,"context_line":"    @na_utils.trace"},{"line_number":2856,"context_line":"    def get_volume_junction_path(self, volume_name, is_style_cifs\u003dFalse):"},{"line_number":2857,"context_line":"        \"\"\"Gets a volume junction path.\"\"\""},{"line_number":2858,"context_line":"        # api_args \u003d {"},{"line_number":2859,"context_line":"        #     \u0027volume\u0027: volume_name,"},{"line_number":2860,"context_line":"        #     \u0027is-style-cifs\u0027: six.text_type(is_style_cifs).lower(),"},{"line_number":2861,"context_line":"        # }"},{"line_number":2862,"context_line":"        # result \u003d self.send_request(\u0027volume-get-volume-path\u0027, api_args)"},{"line_number":2863,"context_line":"        # volume \u003d self.get_volume(volume_name)"},{"line_number":2864,"context_line":"        # return volume[\u0027junction-path\u0027]"},{"line_number":2865,"context_line":"        # NOTE(carloss): UNDO THIS AFTER TESTS WITH NEW ONTAP VERSION!"},{"line_number":2866,"context_line":""},{"line_number":2867,"context_line":"        api_args \u003d {"},{"line_number":2868,"context_line":"            \u0027volume\u0027: volume_name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"38fb901f_cbcc91ff","line":2865,"range":{"start_line":2858,"start_character":7,"end_line":2865,"end_character":70},"updated":"2021-08-25 14:37:16.000000000","message":"you might have forgotten these comments","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":2855,"context_line":"    @na_utils.trace"},{"line_number":2856,"context_line":"    def get_volume_junction_path(self, volume_name, is_style_cifs\u003dFalse):"},{"line_number":2857,"context_line":"        \"\"\"Gets a volume junction path.\"\"\""},{"line_number":2858,"context_line":"        # api_args \u003d {"},{"line_number":2859,"context_line":"        #     \u0027volume\u0027: volume_name,"},{"line_number":2860,"context_line":"        #     \u0027is-style-cifs\u0027: six.text_type(is_style_cifs).lower(),"},{"line_number":2861,"context_line":"        # }"},{"line_number":2862,"context_line":"        # result \u003d self.send_request(\u0027volume-get-volume-path\u0027, api_args)"},{"line_number":2863,"context_line":"        # volume \u003d self.get_volume(volume_name)"},{"line_number":2864,"context_line":"        # return volume[\u0027junction-path\u0027]"},{"line_number":2865,"context_line":"        # NOTE(carloss): UNDO THIS AFTER TESTS WITH NEW ONTAP VERSION!"},{"line_number":2866,"context_line":""},{"line_number":2867,"context_line":"        api_args \u003d {"},{"line_number":2868,"context_line":"            \u0027volume\u0027: volume_name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"a4cd9f9d_a701ae7e","line":2865,"range":{"start_line":2858,"start_character":7,"end_line":2865,"end_character":70},"in_reply_to":"38fb901f_cbcc91ff","updated":"2021-08-28 21:57:50.000000000","message":"You\u0027re totally right. Thanks!","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"e1a388c56315d7dad3aed0773fb3877d08092ee1","unresolved":true,"context_lines":[{"line_number":5456,"context_line":""},{"line_number":5457,"context_line":"    @na_utils.trace"},{"line_number":5458,"context_line":"    def _format_request(self, request_data, headers\u003d{}, query\u003d{},"},{"line_number":5459,"context_line":"                        url_params\u003d{}):"},{"line_number":5460,"context_line":"        \"\"\"Receives the request data and formats it into a request pattern."},{"line_number":5461,"context_line":""},{"line_number":5462,"context_line":"        :param request_data: the body to be sent to the request."}],"source_content_type":"text/x-python","patch_set":10,"id":"29c86edb_7c580729","line":5459,"range":{"start_line":5459,"start_character":24,"end_line":5459,"end_character":37},"updated":"2021-08-25 14:37:16.000000000","message":"this one was mentioned by nahim also on https://review.opendev.org/c/openstack/manila/+/803624/4/manila/share/drivers/netapp/dataontap/client/client_cmode.py#5464\n\nurl_params is not listed as a param on the comment block below","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":5456,"context_line":""},{"line_number":5457,"context_line":"    @na_utils.trace"},{"line_number":5458,"context_line":"    def _format_request(self, request_data, headers\u003d{}, query\u003d{},"},{"line_number":5459,"context_line":"                        url_params\u003d{}):"},{"line_number":5460,"context_line":"        \"\"\"Receives the request data and formats it into a request pattern."},{"line_number":5461,"context_line":""},{"line_number":5462,"context_line":"        :param request_data: the body to be sent to the request."}],"source_content_type":"text/x-python","patch_set":10,"id":"fe2b2f5a_17cea87f","line":5459,"range":{"start_line":5459,"start_character":24,"end_line":5459,"end_character":37},"in_reply_to":"29c86edb_7c580729","updated":"2021-08-28 21:57:50.000000000","message":"Sorry I missed it. Added it to the params list as well!","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":5512,"context_line":""},{"line_number":5513,"context_line":"        api_args \u003d self._format_request(request)"},{"line_number":5514,"context_line":""},{"line_number":5515,"context_line":"        try:"},{"line_number":5516,"context_line":"            result \u003d self.send_request("},{"line_number":5517,"context_line":"                \u0027svm-migration-start\u0027, api_args\u003dapi_args, use_zapi\u003dFalse)"},{"line_number":5518,"context_line":"        except netapp_api.NaApiError:"},{"line_number":5519,"context_line":"            msg \u003d \"Could not start share server migration.\""},{"line_number":5520,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":5521,"context_line":""},{"line_number":5522,"context_line":"        return result"},{"line_number":5523,"context_line":""},{"line_number":5524,"context_line":"    @na_utils.trace"},{"line_number":5525,"context_line":"    def get_migration_check_job_state(self, job_id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"92827bb5_538b8d20","line":5522,"range":{"start_line":5515,"start_character":7,"end_line":5522,"end_character":20},"updated":"2021-08-27 12:20:24.000000000","message":"why are you catching this error just to raise a different msg ? You could leave it without try/catch and the caller try/catch the call providing the appropriate log. Replace all code by:\n\nreturn self.send_request()","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":5512,"context_line":""},{"line_number":5513,"context_line":"        api_args \u003d self._format_request(request)"},{"line_number":5514,"context_line":""},{"line_number":5515,"context_line":"        try:"},{"line_number":5516,"context_line":"            result \u003d self.send_request("},{"line_number":5517,"context_line":"                \u0027svm-migration-start\u0027, api_args\u003dapi_args, use_zapi\u003dFalse)"},{"line_number":5518,"context_line":"        except netapp_api.NaApiError:"},{"line_number":5519,"context_line":"            msg \u003d \"Could not start share server migration.\""},{"line_number":5520,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":5521,"context_line":""},{"line_number":5522,"context_line":"        return result"},{"line_number":5523,"context_line":""},{"line_number":5524,"context_line":"    @na_utils.trace"},{"line_number":5525,"context_line":"    def get_migration_check_job_state(self, job_id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"cb003a18_98279478","line":5522,"range":{"start_line":5515,"start_character":7,"end_line":5522,"end_character":20},"in_reply_to":"92827bb5_538b8d20","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":5522,"context_line":"        return result"},{"line_number":5523,"context_line":""},{"line_number":5524,"context_line":"    @na_utils.trace"},{"line_number":5525,"context_line":"    def get_migration_check_job_state(self, job_id):"},{"line_number":5526,"context_line":"        try:"},{"line_number":5527,"context_line":"            job \u003d self.get_job(job_id)"},{"line_number":5528,"context_line":"            return job.get(\"state\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"bca18b33_3813c1a0","line":5525,"range":{"start_line":5525,"start_character":8,"end_line":5525,"end_character":37},"updated":"2021-08-27 12:20:24.000000000","message":"please add function documentation","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":5522,"context_line":"        return result"},{"line_number":5523,"context_line":""},{"line_number":5524,"context_line":"    @na_utils.trace"},{"line_number":5525,"context_line":"    def get_migration_check_job_state(self, job_id):"},{"line_number":5526,"context_line":"        try:"},{"line_number":5527,"context_line":"            job \u003d self.get_job(job_id)"},{"line_number":5528,"context_line":"            return job.get(\"state\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"5b2b873b_3cf558ae","line":5525,"range":{"start_line":5525,"start_character":8,"end_line":5525,"end_character":37},"in_reply_to":"bca18b33_3813c1a0","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":5528,"context_line":"            return job.get(\"state\")"},{"line_number":5529,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":5530,"context_line":"            if e.code \u003d\u003d netapp_api.ENFS_V4_0_ENABLED_MIGRATION_FAILURE:"},{"line_number":5531,"context_line":"                msg \u003d _("},{"line_number":5532,"context_line":"                    \u0027NFS v4.0 is not supported while migrating vservers.\u0027)"},{"line_number":5533,"context_line":"                LOG.error(msg)"},{"line_number":5534,"context_line":"                raise exception.NetAppException(message\u003de.message)"},{"line_number":5535,"context_line":"            if e.code \u003d\u003d netapp_api.EVSERVER_MIGRATION_TO_NON_AFF_CLUSTER:"},{"line_number":5536,"context_line":"                msg \u003d _(\u0027Both source and destination clusters must be AFF \u0027"},{"line_number":5537,"context_line":"                        \u0027systems.\u0027)"},{"line_number":5538,"context_line":"                LOG.error(msg)"},{"line_number":5539,"context_line":"                raise exception.NetAppException(message\u003de.message)"},{"line_number":5540,"context_line":"            msg \u003d (_(\u0027Failed to check migration support. Reason: \u0027"},{"line_number":5541,"context_line":"                     \u0027%s\u0027 % e.message))"}],"source_content_type":"text/x-python","patch_set":10,"id":"f37c7ae1_2f1cf141","line":5538,"range":{"start_line":5531,"start_character":18,"end_line":5538,"end_character":30},"updated":"2021-08-27 12:20:24.000000000","message":"add those information to commit message/release notes: \"only supported with 9.10 AFF and without NFSv4.0 enabled.\"","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":5556,"context_line":"        api_args \u003d self._format_request("},{"line_number":5557,"context_line":"            request, url_params\u003durl_params)"},{"line_number":5558,"context_line":""},{"line_number":5559,"context_line":"        job \u003d self.send_request("},{"line_number":5560,"context_line":"            \u0027svm-migration-complete\u0027, api_args\u003dapi_args, use_zapi\u003dFalse)"},{"line_number":5561,"context_line":"        return job"},{"line_number":5562,"context_line":""},{"line_number":5563,"context_line":"    @na_utils.trace"},{"line_number":5564,"context_line":"    def svm_migrate_cancel(self, migration_id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"0de5cff6_054891e3","line":5561,"range":{"start_line":5559,"start_character":8,"end_line":5561,"end_character":18},"updated":"2021-08-27 12:20:24.000000000","message":"nit: save some lines: return self.send_request()","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":5556,"context_line":"        api_args \u003d self._format_request("},{"line_number":5557,"context_line":"            request, url_params\u003durl_params)"},{"line_number":5558,"context_line":""},{"line_number":5559,"context_line":"        job \u003d self.send_request("},{"line_number":5560,"context_line":"            \u0027svm-migration-complete\u0027, api_args\u003dapi_args, use_zapi\u003dFalse)"},{"line_number":5561,"context_line":"        return job"},{"line_number":5562,"context_line":""},{"line_number":5563,"context_line":"    @na_utils.trace"},{"line_number":5564,"context_line":"    def svm_migrate_cancel(self, migration_id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"35d2b82a_c9830d3d","line":5561,"range":{"start_line":5559,"start_character":8,"end_line":5561,"end_character":18},"in_reply_to":"0de5cff6_054891e3","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":5571,"context_line":"            \"svm_migration_id\": migration_id"},{"line_number":5572,"context_line":"        }"},{"line_number":5573,"context_line":"        api_args \u003d self._format_request(request, url_params\u003durl_params)"},{"line_number":5574,"context_line":"        job \u003d self.send_request("},{"line_number":5575,"context_line":"            \u0027svm-migration-cancel\u0027, api_args\u003dapi_args, use_zapi\u003dFalse)"},{"line_number":5576,"context_line":"        return job"},{"line_number":5577,"context_line":""},{"line_number":5578,"context_line":"    @na_utils.trace"},{"line_number":5579,"context_line":"    def svm_migration_get(self, migration_id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"6602463b_8bfedd7e","line":5576,"range":{"start_line":5574,"start_character":8,"end_line":5576,"end_character":18},"updated":"2021-08-27 12:20:24.000000000","message":"nit: save some lines: return self.send_request()","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":5571,"context_line":"            \"svm_migration_id\": migration_id"},{"line_number":5572,"context_line":"        }"},{"line_number":5573,"context_line":"        api_args \u003d self._format_request(request, url_params\u003durl_params)"},{"line_number":5574,"context_line":"        job \u003d self.send_request("},{"line_number":5575,"context_line":"            \u0027svm-migration-cancel\u0027, api_args\u003dapi_args, use_zapi\u003dFalse)"},{"line_number":5576,"context_line":"        return job"},{"line_number":5577,"context_line":""},{"line_number":5578,"context_line":"    @na_utils.trace"},{"line_number":5579,"context_line":"    def svm_migration_get(self, migration_id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a2a4232_22ad979a","line":5576,"range":{"start_line":5574,"start_character":8,"end_line":5576,"end_character":18},"in_reply_to":"6602463b_8bfedd7e","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":5586,"context_line":"            \"svm_migration_id\": migration_id"},{"line_number":5587,"context_line":"        }"},{"line_number":5588,"context_line":"        api_args \u003d self._format_request(request, url_params\u003durl_params)"},{"line_number":5589,"context_line":"        result \u003d self.send_request("},{"line_number":5590,"context_line":"            \u0027svm-migration-get\u0027, api_args\u003dapi_args, use_zapi\u003dFalse)"},{"line_number":5591,"context_line":"        return result"},{"line_number":5592,"context_line":""},{"line_number":5593,"context_line":"    @na_utils.trace"},{"line_number":5594,"context_line":"    def svm_migrate_pause(self, migration_id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"b6159f81_7b139098","line":5591,"range":{"start_line":5589,"start_character":8,"end_line":5591,"end_character":21},"updated":"2021-08-27 12:20:24.000000000","message":"nit: save some lines: return self.send_request()","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":5586,"context_line":"            \"svm_migration_id\": migration_id"},{"line_number":5587,"context_line":"        }"},{"line_number":5588,"context_line":"        api_args \u003d self._format_request(request, url_params\u003durl_params)"},{"line_number":5589,"context_line":"        result \u003d self.send_request("},{"line_number":5590,"context_line":"            \u0027svm-migration-get\u0027, api_args\u003dapi_args, use_zapi\u003dFalse)"},{"line_number":5591,"context_line":"        return result"},{"line_number":5592,"context_line":""},{"line_number":5593,"context_line":"    @na_utils.trace"},{"line_number":5594,"context_line":"    def svm_migrate_pause(self, migration_id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"d8f23933_d172ba57","line":5591,"range":{"start_line":5589,"start_character":8,"end_line":5591,"end_character":21},"in_reply_to":"b6159f81_7b139098","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":5604,"context_line":"        }"},{"line_number":5605,"context_line":"        api_args \u003d self._format_request("},{"line_number":5606,"context_line":"            request, url_params\u003durl_params)"},{"line_number":5607,"context_line":"        job \u003d self.send_request("},{"line_number":5608,"context_line":"            \u0027svm-migration-pause\u0027, api_args\u003dapi_args, use_zapi\u003dFalse)"},{"line_number":5609,"context_line":"        return job"},{"line_number":5610,"context_line":""},{"line_number":5611,"context_line":"    @na_utils.trace"},{"line_number":5612,"context_line":"    def get_job(self, job_uuid):"}],"source_content_type":"text/x-python","patch_set":10,"id":"f3620249_cf74aa4b","line":5609,"range":{"start_line":5607,"start_character":8,"end_line":5609,"end_character":18},"updated":"2021-08-27 12:20:24.000000000","message":"nit: save some lines: return self.send_request()","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":5604,"context_line":"        }"},{"line_number":5605,"context_line":"        api_args \u003d self._format_request("},{"line_number":5606,"context_line":"            request, url_params\u003durl_params)"},{"line_number":5607,"context_line":"        job \u003d self.send_request("},{"line_number":5608,"context_line":"            \u0027svm-migration-pause\u0027, api_args\u003dapi_args, use_zapi\u003dFalse)"},{"line_number":5609,"context_line":"        return job"},{"line_number":5610,"context_line":""},{"line_number":5611,"context_line":"    @na_utils.trace"},{"line_number":5612,"context_line":"    def get_job(self, job_uuid):"}],"source_content_type":"text/x-python","patch_set":10,"id":"3c96658b_43f86f14","line":5609,"range":{"start_line":5607,"start_character":8,"end_line":5609,"end_character":18},"in_reply_to":"f3620249_cf74aa4b","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":5609,"context_line":"        return job"},{"line_number":5610,"context_line":""},{"line_number":5611,"context_line":"    @na_utils.trace"},{"line_number":5612,"context_line":"    def get_job(self, job_uuid):"},{"line_number":5613,"context_line":"        request \u003d {}"},{"line_number":5614,"context_line":"        url_params \u003d {"},{"line_number":5615,"context_line":"            \"job_uuid\": job_uuid"}],"source_content_type":"text/x-python","patch_set":10,"id":"5d53ecbe_bb5bfbe4","line":5612,"range":{"start_line":5612,"start_character":8,"end_line":5612,"end_character":15},"updated":"2021-08-27 12:20:24.000000000","message":"please add function documentation","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":5609,"context_line":"        return job"},{"line_number":5610,"context_line":""},{"line_number":5611,"context_line":"    @na_utils.trace"},{"line_number":5612,"context_line":"    def get_job(self, job_uuid):"},{"line_number":5613,"context_line":"        request \u003d {}"},{"line_number":5614,"context_line":"        url_params \u003d {"},{"line_number":5615,"context_line":"            \"job_uuid\": job_uuid"}],"source_content_type":"text/x-python","patch_set":10,"id":"7782b072_14daaca7","line":5612,"range":{"start_line":5612,"start_character":8,"end_line":5612,"end_character":15},"in_reply_to":"5d53ecbe_bb5bfbe4","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":5617,"context_line":""},{"line_number":5618,"context_line":"        api_args \u003d self._format_request(request, url_params\u003durl_params)"},{"line_number":5619,"context_line":""},{"line_number":5620,"context_line":"        result \u003d self.send_request("},{"line_number":5621,"context_line":"            \u0027get-job\u0027, api_args\u003dapi_args, use_zapi\u003dFalse)"},{"line_number":5622,"context_line":""},{"line_number":5623,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":10,"id":"4c9db7d6_dd97a1d8","line":5623,"range":{"start_line":5620,"start_character":8,"end_line":5623,"end_character":21},"updated":"2021-08-27 12:20:24.000000000","message":"nit: save some lines: return self.send_request()","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":5617,"context_line":""},{"line_number":5618,"context_line":"        api_args \u003d self._format_request(request, url_params\u003durl_params)"},{"line_number":5619,"context_line":""},{"line_number":5620,"context_line":"        result \u003d self.send_request("},{"line_number":5621,"context_line":"            \u0027get-job\u0027, api_args\u003dapi_args, use_zapi\u003dFalse)"},{"line_number":5622,"context_line":""},{"line_number":5623,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":10,"id":"9ae0d8d7_f7fd9cd2","line":5623,"range":{"start_line":5620,"start_character":8,"end_line":5623,"end_character":21},"in_reply_to":"4c9db7d6_dd97a1d8","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a112b4545d63b298cbc835f5825e6d4c7de1c8db","unresolved":true,"context_lines":[{"line_number":5551,"context_line":"            job \u003d self.get_job(job_id)"},{"line_number":5552,"context_line":"            return job"},{"line_number":5553,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":5554,"context_line":"            if e.code \u003d\u003d netapp_api.ENFS_V4_0_ENABLED_MIGRATION_FAILURE:"},{"line_number":5555,"context_line":"                msg \u003d _("},{"line_number":5556,"context_line":"                    \u0027NFS v4.0 is not supported while migrating vservers.\u0027)"},{"line_number":5557,"context_line":"                LOG.error(msg)"},{"line_number":5558,"context_line":"                raise exception.NetAppException(message\u003de.message)"},{"line_number":5559,"context_line":"            if e.code \u003d\u003d netapp_api.EVSERVER_MIGRATION_TO_NON_AFF_CLUSTER:"},{"line_number":5560,"context_line":"                msg \u003d _(\u0027Both source and destination clusters must be AFF \u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"7d91839c_b1208121","line":5557,"range":{"start_line":5554,"start_character":12,"end_line":5557,"end_character":30},"updated":"2021-09-07 19:39:37.000000000","message":"This error isn\u0027t surfaced before the migration begins? \nShould the driver disable v4  before starting the migration so this situation doesn\u0027t occur. \n\nIf v4 is enabled, and nondisruptive migration is requested, perhaps you can deny the nondisruptive migration capability during migration check; since its not possible to know if clients are connected with v4.0. wdyt?","commit_id":"74d5a1b2cf81090d96e12910d880c1c60a96f0ab"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b55b61985ed795f4534e83481df6f129db365d87","unresolved":true,"context_lines":[{"line_number":5551,"context_line":"            job \u003d self.get_job(job_id)"},{"line_number":5552,"context_line":"            return job"},{"line_number":5553,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":5554,"context_line":"            if e.code \u003d\u003d netapp_api.ENFS_V4_0_ENABLED_MIGRATION_FAILURE:"},{"line_number":5555,"context_line":"                msg \u003d _("},{"line_number":5556,"context_line":"                    \u0027NFS v4.0 is not supported while migrating vservers.\u0027)"},{"line_number":5557,"context_line":"                LOG.error(msg)"},{"line_number":5558,"context_line":"                raise exception.NetAppException(message\u003de.message)"},{"line_number":5559,"context_line":"            if e.code \u003d\u003d netapp_api.EVSERVER_MIGRATION_TO_NON_AFF_CLUSTER:"},{"line_number":5560,"context_line":"                msg \u003d _(\u0027Both source and destination clusters must be AFF \u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"c08176bf_52f16efc","line":5557,"range":{"start_line":5554,"start_character":12,"end_line":5557,"end_character":30},"in_reply_to":"170f5231_c861cc33","updated":"2021-09-07 20:51:11.000000000","message":"Thanks for the context and the explanation.\n\n\u003e considering that it will be turned off before the migration starts\n\n\nYeah, i was thinking that if it can be and needs to be turned off, the driver should handle it. I understand there\u0027s no straightforward way to know if v4.0 is being \"used\"... \n\nJust so I understand, Does issuing a svm migration with \"check_only\" check that the storage systems involved are AFF and that the vserver has NFS v4.0 version enabled when the migration began?","commit_id":"74d5a1b2cf81090d96e12910d880c1c60a96f0ab"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d4d26034aa76334bfec707402542f5e12585af8c","unresolved":true,"context_lines":[{"line_number":5551,"context_line":"            job \u003d self.get_job(job_id)"},{"line_number":5552,"context_line":"            return job"},{"line_number":5553,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":5554,"context_line":"            if e.code \u003d\u003d netapp_api.ENFS_V4_0_ENABLED_MIGRATION_FAILURE:"},{"line_number":5555,"context_line":"                msg \u003d _("},{"line_number":5556,"context_line":"                    \u0027NFS v4.0 is not supported while migrating vservers.\u0027)"},{"line_number":5557,"context_line":"                LOG.error(msg)"},{"line_number":5558,"context_line":"                raise exception.NetAppException(message\u003de.message)"},{"line_number":5559,"context_line":"            if e.code \u003d\u003d netapp_api.EVSERVER_MIGRATION_TO_NON_AFF_CLUSTER:"},{"line_number":5560,"context_line":"                msg \u003d _(\u0027Both source and destination clusters must be AFF \u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"170f5231_c861cc33","line":5557,"range":{"start_line":5554,"start_character":12,"end_line":5557,"end_character":30},"in_reply_to":"7d91839c_b1208121","updated":"2021-09-07 20:02:40.000000000","message":"\u003e This error isn\u0027t surfaced before the migration begins? \nYes, it should fail in the check... Administrators could either use the NFS versions configuration parameters in their backends, or if they are completely sure that there is not anyone using NFS v4.0, they could disable this in ONTAP and the check/migration start operations should work properly if this is the only issue.\n\n\u003e If v4 is enabled, and nondisruptive migration is requested, perhaps you can deny the nondisruptive migration capability during migration check; since its not possible to know if clients are connected with v4.0. wdyt?\nThis is a good point... I have even discussed this with Felipe in the past :)... The only thing that made us to keep it like this is: There isn\u0027t a way to ensure that if we turn the nfs v4.0 off the check will pass, because it failed because the NFS v4.0, but the check only shows one issue at a time, so if there is another thing blocking the check, we won\u0027t know...\nSo let\u0027s consider the following scenario:\n- Admin request a nondisruptive migration for a share server that has NFS v4.0 enabled\n- Source or dest cluster aren\u0027t AFF\n- NetApp driver identifies that NFS v4.0 is enabled and says it is okay (returns that the migration is compatible), considering that it will be turned off before the migration starts\n- Admin thinks the migration is okay, and starts it\n- In the migration start, we turn NFS 4.0 off and send the migration request to ONTAP\n- ONTAP Fails saying that either source or destination clusters aren\u0027t AFF...\nThis issue could be pretty annoying to admins, because we previously told them that the migration would be feasible, but when they requested the migration, it faled alledging other issue.\nAnd there is no way to skip the NFS v4.0 validation... That\u0027s the reason we decided to follow with this approach...\nI have even implemented disabling the nfs v4.0 in the past, but the above scenario happened.\nNetApp intends to implement SVM migrate for nfs v4.0 in a near future though, so when that happens, this problem will be avoided :)","commit_id":"74d5a1b2cf81090d96e12910d880c1c60a96f0ab"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"297e54ba1df91eea3a8164467ec06ae5ffd5a4eb","unresolved":true,"context_lines":[{"line_number":5551,"context_line":"            job \u003d self.get_job(job_id)"},{"line_number":5552,"context_line":"            return job"},{"line_number":5553,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":5554,"context_line":"            if e.code \u003d\u003d netapp_api.ENFS_V4_0_ENABLED_MIGRATION_FAILURE:"},{"line_number":5555,"context_line":"                msg \u003d _("},{"line_number":5556,"context_line":"                    \u0027NFS v4.0 is not supported while migrating vservers.\u0027)"},{"line_number":5557,"context_line":"                LOG.error(msg)"},{"line_number":5558,"context_line":"                raise exception.NetAppException(message\u003de.message)"},{"line_number":5559,"context_line":"            if e.code \u003d\u003d netapp_api.EVSERVER_MIGRATION_TO_NON_AFF_CLUSTER:"},{"line_number":5560,"context_line":"                msg \u003d _(\u0027Both source and destination clusters must be AFF \u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"9d94e3c1_854b08a2","line":5557,"range":{"start_line":5554,"start_character":12,"end_line":5557,"end_character":30},"in_reply_to":"97dddece_29771c33","updated":"2021-09-07 22:01:11.000000000","message":"Ah, i understand that better now; I would expect the user (cloud administrator in this case) performs the check operation until it succeeds (correcting incompatibilities each time) before initiating a migration..","commit_id":"74d5a1b2cf81090d96e12910d880c1c60a96f0ab"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"938ba3053169850c11d72927d83f83d0a592fb9e","unresolved":true,"context_lines":[{"line_number":5551,"context_line":"            job \u003d self.get_job(job_id)"},{"line_number":5552,"context_line":"            return job"},{"line_number":5553,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":5554,"context_line":"            if e.code \u003d\u003d netapp_api.ENFS_V4_0_ENABLED_MIGRATION_FAILURE:"},{"line_number":5555,"context_line":"                msg \u003d _("},{"line_number":5556,"context_line":"                    \u0027NFS v4.0 is not supported while migrating vservers.\u0027)"},{"line_number":5557,"context_line":"                LOG.error(msg)"},{"line_number":5558,"context_line":"                raise exception.NetAppException(message\u003de.message)"},{"line_number":5559,"context_line":"            if e.code \u003d\u003d netapp_api.EVSERVER_MIGRATION_TO_NON_AFF_CLUSTER:"},{"line_number":5560,"context_line":"                msg \u003d _(\u0027Both source and destination clusters must be AFF \u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"97dddece_29771c33","line":5557,"range":{"start_line":5554,"start_character":12,"end_line":5557,"end_character":30},"in_reply_to":"c08176bf_52f16efc","updated":"2021-09-07 21:01:14.000000000","message":"Yes, only performing this request with \"check_only\" will do all validations that are done before a migration is started, and return if the migration is possible or not.  The only problem as I mentioned is that each time it will raise one single error, even though there might be more than one.","commit_id":"74d5a1b2cf81090d96e12910d880c1c60a96f0ab"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1318,"context_line":"            msg_args \u003d {\u0027vserver\u0027: vserver, \u0027proto\u0027: share[\u0027share_proto\u0027]}"},{"line_number":1319,"context_line":"            raise exception.NetAppException(msg % msg_args)"},{"line_number":1320,"context_line":""},{"line_number":1321,"context_line":"        share_host \u003d share_host if share_host else share[\u0027host\u0027]"},{"line_number":1322,"context_line":""},{"line_number":1323,"context_line":"        # Get LIF addresses with metadata"},{"line_number":1324,"context_line":"        export_addresses \u003d self._get_export_addresses_with_metadata("}],"source_content_type":"text/x-python","patch_set":10,"id":"e0ed0097_ad59649f","line":1321,"range":{"start_line":1321,"start_character":8,"end_line":1321,"end_character":64},"updated":"2021-08-27 12:20:24.000000000","message":"avoid to write to params variable, prefer:\nEither:\n\nexport_adderss \u003d self._get..(.., interfaces, share_host if share_host else share[\u0027host\u0027])\n\nor:\n\nhost \u003d share_host if share_host else share[\u0027host\u0027]\n\nor: change the caller doing it a required param:\n\nself._create_export(..,vserver_client, share[\u0027host\u0027])\nself._create_export(..,vserver_client, my_custom_host)","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1318,"context_line":"            msg_args \u003d {\u0027vserver\u0027: vserver, \u0027proto\u0027: share[\u0027share_proto\u0027]}"},{"line_number":1319,"context_line":"            raise exception.NetAppException(msg % msg_args)"},{"line_number":1320,"context_line":""},{"line_number":1321,"context_line":"        share_host \u003d share_host if share_host else share[\u0027host\u0027]"},{"line_number":1322,"context_line":""},{"line_number":1323,"context_line":"        # Get LIF addresses with metadata"},{"line_number":1324,"context_line":"        export_addresses \u003d self._get_export_addresses_with_metadata("}],"source_content_type":"text/x-python","patch_set":10,"id":"85394bf1_550b9a6e","line":1321,"range":{"start_line":1321,"start_character":8,"end_line":1321,"end_character":64},"in_reply_to":"e0ed0097_ad59649f","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py":[{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"40cb2b31a995e5150084b53bc9a6ada0b69945ef","unresolved":true,"context_lines":[{"line_number":994,"context_line":"            source_share_server, dest_aggregates, dest_client):"},{"line_number":995,"context_line":"        \"\"\"Checks if the migration can be performed using SVM Migrate."},{"line_number":996,"context_line":""},{"line_number":997,"context_line":"        1. Send the request to the backed to check if the migration is possible"},{"line_number":998,"context_line":"        2. Wait until the job finishes checking the migration status"},{"line_number":999,"context_line":"        \"\"\""},{"line_number":1000,"context_line":"        src_server_id \u003d source_share_server[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"669ff139_21cdf168","line":997,"range":{"start_line":997,"start_character":35,"end_line":997,"end_character":42},"updated":"2021-08-12 12:38:15.000000000","message":"typo: backend","commit_id":"c6abbd14f1656cf3f7a20fd069a8427a3a07d28a"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":310,"context_line":"    def _create_ipspace(self, network_info, client\u003dNone):"},{"line_number":311,"context_line":"        \"\"\"If supported, create an IPspace for a new Vserver.\"\"\""},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        client \u003d client if client else self._client"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        if not client.features.IPSPACES:"},{"line_number":316,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":10,"id":"c6788f2b_3d5273c6","line":313,"range":{"start_line":313,"start_character":8,"end_line":313,"end_character":51},"updated":"2021-08-27 12:20:24.000000000","message":"avoid to write to param variable, a better approach:\n\ndef _create_ipspace(self,network_info, client\u003dself._client):","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":310,"context_line":"    def _create_ipspace(self, network_info, client\u003dNone):"},{"line_number":311,"context_line":"        \"\"\"If supported, create an IPspace for a new Vserver.\"\"\""},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        client \u003d client if client else self._client"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        if not client.features.IPSPACES:"},{"line_number":316,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":10,"id":"ddb991d3_5ff81295","line":313,"range":{"start_line":313,"start_character":8,"end_line":313,"end_character":51},"in_reply_to":"c6788f2b_3d5273c6","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":906,"context_line":"                manage_existing(share, driver_options,"},{"line_number":907,"context_line":"                                share_server\u003dshare_server))"},{"line_number":908,"context_line":""},{"line_number":909,"context_line":"    def _check_compatibility_using_svm_dr("},{"line_number":910,"context_line":"            self, src_client, dest_client, shares_request_spec, pools):"},{"line_number":911,"context_line":"        method \u003d \u0027svm_dr\u0027"},{"line_number":912,"context_line":"        if (not src_client.is_svm_dr_supported()"}],"source_content_type":"text/x-python","patch_set":10,"id":"2826a8fd_dd61b3c3","line":909,"range":{"start_line":909,"start_character":8,"end_line":909,"end_character":41},"updated":"2021-08-27 12:20:24.000000000","message":"@na_utils.trace and function doc\n\nNote: here the return is important, please, add the :return: flag explaining what is each member of the tuple.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":906,"context_line":"                manage_existing(share, driver_options,"},{"line_number":907,"context_line":"                                share_server\u003dshare_server))"},{"line_number":908,"context_line":""},{"line_number":909,"context_line":"    def _check_compatibility_using_svm_dr("},{"line_number":910,"context_line":"            self, src_client, dest_client, shares_request_spec, pools):"},{"line_number":911,"context_line":"        method \u003d \u0027svm_dr\u0027"},{"line_number":912,"context_line":"        if (not src_client.is_svm_dr_supported()"}],"source_content_type":"text/x-python","patch_set":10,"id":"d6c0758e_98bbdecc","line":909,"range":{"start_line":909,"start_character":8,"end_line":909,"end_character":41},"in_reply_to":"2826a8fd_dd61b3c3","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":908,"context_line":""},{"line_number":909,"context_line":"    def _check_compatibility_using_svm_dr("},{"line_number":910,"context_line":"            self, src_client, dest_client, shares_request_spec, pools):"},{"line_number":911,"context_line":"        method \u003d \u0027svm_dr\u0027"},{"line_number":912,"context_line":"        if (not src_client.is_svm_dr_supported()"},{"line_number":913,"context_line":"                or not dest_client.is_svm_dr_supported()):"},{"line_number":914,"context_line":"            msg \u003d _(\"Cannot perform server migration because at least one of \""}],"source_content_type":"text/x-python","patch_set":10,"id":"2b3f0033_fa7d5206","line":911,"range":{"start_line":911,"start_character":18,"end_line":911,"end_character":24},"updated":"2021-08-27 12:20:24.000000000","message":"avoid the hard code string... Add it to utils than use:\n\nutils.SVM_DR_METHDO to all code","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":908,"context_line":""},{"line_number":909,"context_line":"    def _check_compatibility_using_svm_dr("},{"line_number":910,"context_line":"            self, src_client, dest_client, shares_request_spec, pools):"},{"line_number":911,"context_line":"        method \u003d \u0027svm_dr\u0027"},{"line_number":912,"context_line":"        if (not src_client.is_svm_dr_supported()"},{"line_number":913,"context_line":"                or not dest_client.is_svm_dr_supported()):"},{"line_number":914,"context_line":"            msg \u003d _(\"Cannot perform server migration because at least one of \""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa510325_3d4042b6","line":911,"range":{"start_line":911,"start_character":18,"end_line":911,"end_character":24},"in_reply_to":"2b3f0033_fa7d5206","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":916,"context_line":"            LOG.error(msg)"},{"line_number":917,"context_line":"            return method, False"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"        # Check capacity"},{"line_number":920,"context_line":"        server_total_size \u003d (shares_request_spec.get(\u0027shares_size\u0027, 0) +"},{"line_number":921,"context_line":"                             shares_request_spec.get(\u0027snapshots_size\u0027, 0))"},{"line_number":922,"context_line":"        # NOTE(dviroel): If the backend has a \u0027max_over_subscription_ratio\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"7cf0ecbd_132ef6b0","line":919,"range":{"start_line":919,"start_character":16,"end_line":919,"end_character":24},"updated":"2021-08-27 12:20:24.000000000","message":"capacity.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":916,"context_line":"            LOG.error(msg)"},{"line_number":917,"context_line":"            return method, False"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"        # Check capacity"},{"line_number":920,"context_line":"        server_total_size \u003d (shares_request_spec.get(\u0027shares_size\u0027, 0) +"},{"line_number":921,"context_line":"                             shares_request_spec.get(\u0027snapshots_size\u0027, 0))"},{"line_number":922,"context_line":"        # NOTE(dviroel): If the backend has a \u0027max_over_subscription_ratio\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"842be486_25583935","line":919,"range":{"start_line":919,"start_character":16,"end_line":919,"end_character":24},"in_reply_to":"7cf0ecbd_132ef6b0","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":933,"context_line":"        return method, True"},{"line_number":934,"context_line":""},{"line_number":935,"context_line":"    @na_utils.trace"},{"line_number":936,"context_line":"    def _get_job_uuid(self, job):"},{"line_number":937,"context_line":"        job \u003d job.get(\"job\")"},{"line_number":938,"context_line":"        return job.get(\"uuid\")"},{"line_number":939,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"b539aa0a_582bf5c1","line":936,"range":{"start_line":936,"start_character":8,"end_line":936,"end_character":21},"updated":"2021-08-27 12:20:24.000000000","message":"add doc function","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":933,"context_line":"        return method, True"},{"line_number":934,"context_line":""},{"line_number":935,"context_line":"    @na_utils.trace"},{"line_number":936,"context_line":"    def _get_job_uuid(self, job):"},{"line_number":937,"context_line":"        job \u003d job.get(\"job\")"},{"line_number":938,"context_line":"        return job.get(\"uuid\")"},{"line_number":939,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bd702d64_4eeaeff8","line":936,"range":{"start_line":936,"start_character":8,"end_line":936,"end_character":21},"in_reply_to":"b539aa0a_582bf5c1","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":934,"context_line":""},{"line_number":935,"context_line":"    @na_utils.trace"},{"line_number":936,"context_line":"    def _get_job_uuid(self, job):"},{"line_number":937,"context_line":"        job \u003d job.get(\"job\")"},{"line_number":938,"context_line":"        return job.get(\"uuid\")"},{"line_number":939,"context_line":""},{"line_number":940,"context_line":"    def _wait_for_operation_status("},{"line_number":941,"context_line":"            self, operation_id, get_operation, desired_status\u003d\u0027success\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"e3dffd1a_a48c0716","line":938,"range":{"start_line":937,"start_character":8,"end_line":938,"end_character":30},"updated":"2021-08-27 12:20:24.000000000","message":"job might be None, so:\n\njob \u003d job.get(\"job\", {})","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":934,"context_line":""},{"line_number":935,"context_line":"    @na_utils.trace"},{"line_number":936,"context_line":"    def _get_job_uuid(self, job):"},{"line_number":937,"context_line":"        job \u003d job.get(\"job\")"},{"line_number":938,"context_line":"        return job.get(\"uuid\")"},{"line_number":939,"context_line":""},{"line_number":940,"context_line":"    def _wait_for_operation_status("},{"line_number":941,"context_line":"            self, operation_id, get_operation, desired_status\u003d\u0027success\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"805090e5_21dbac34","line":938,"range":{"start_line":937,"start_character":8,"end_line":938,"end_character":30},"in_reply_to":"e3dffd1a_a48c0716","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":937,"context_line":"        job \u003d job.get(\"job\")"},{"line_number":938,"context_line":"        return job.get(\"uuid\")"},{"line_number":939,"context_line":""},{"line_number":940,"context_line":"    def _wait_for_operation_status("},{"line_number":941,"context_line":"            self, operation_id, get_operation, desired_status\u003d\u0027success\u0027,"},{"line_number":942,"context_line":"            timeout\u003dNone):"},{"line_number":943,"context_line":"        if not timeout:"}],"source_content_type":"text/x-python","patch_set":10,"id":"98ea7b67_b673c4b4","line":940,"range":{"start_line":940,"start_character":8,"end_line":940,"end_character":34},"updated":"2021-08-27 12:20:24.000000000","message":"add doc function and @na_util.trace","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":937,"context_line":"        job \u003d job.get(\"job\")"},{"line_number":938,"context_line":"        return job.get(\"uuid\")"},{"line_number":939,"context_line":""},{"line_number":940,"context_line":"    def _wait_for_operation_status("},{"line_number":941,"context_line":"            self, operation_id, get_operation, desired_status\u003d\u0027success\u0027,"},{"line_number":942,"context_line":"            timeout\u003dNone):"},{"line_number":943,"context_line":"        if not timeout:"}],"source_content_type":"text/x-python","patch_set":10,"id":"2e2f3ea4_3daa290c","line":940,"range":{"start_line":940,"start_character":8,"end_line":940,"end_character":34},"in_reply_to":"98ea7b67_b673c4b4","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":938,"context_line":"        return job.get(\"uuid\")"},{"line_number":939,"context_line":""},{"line_number":940,"context_line":"    def _wait_for_operation_status("},{"line_number":941,"context_line":"            self, operation_id, get_operation, desired_status\u003d\u0027success\u0027,"},{"line_number":942,"context_line":"            timeout\u003dNone):"},{"line_number":943,"context_line":"        if not timeout:"},{"line_number":944,"context_line":"            timeout \u003d ("}],"source_content_type":"text/x-python","patch_set":10,"id":"9ba23dbc_14aab472","line":941,"range":{"start_line":941,"start_character":32,"end_line":941,"end_character":45},"updated":"2021-08-27 12:20:24.000000000","message":"it\u0027s a function ? maybe: func_get_operation or get_operation_func","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":938,"context_line":"        return job.get(\"uuid\")"},{"line_number":939,"context_line":""},{"line_number":940,"context_line":"    def _wait_for_operation_status("},{"line_number":941,"context_line":"            self, operation_id, get_operation, desired_status\u003d\u0027success\u0027,"},{"line_number":942,"context_line":"            timeout\u003dNone):"},{"line_number":943,"context_line":"        if not timeout:"},{"line_number":944,"context_line":"            timeout \u003d ("}],"source_content_type":"text/x-python","patch_set":10,"id":"44df5965_51c973e0","line":941,"range":{"start_line":941,"start_character":32,"end_line":941,"end_character":45},"in_reply_to":"9ba23dbc_14aab472","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":939,"context_line":""},{"line_number":940,"context_line":"    def _wait_for_operation_status("},{"line_number":941,"context_line":"            self, operation_id, get_operation, desired_status\u003d\u0027success\u0027,"},{"line_number":942,"context_line":"            timeout\u003dNone):"},{"line_number":943,"context_line":"        if not timeout:"},{"line_number":944,"context_line":"            timeout \u003d ("},{"line_number":945,"context_line":"                self.configuration.netapp_server_migration_state_change_timeout"},{"line_number":946,"context_line":"            )"},{"line_number":947,"context_line":"        interval \u003d 10"},{"line_number":948,"context_line":"        retries \u003d int(timeout / interval) or 1"},{"line_number":949,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fcd2820b_b8071288","line":946,"range":{"start_line":942,"start_character":12,"end_line":946,"end_character":13},"updated":"2021-08-27 12:20:24.000000000","message":"In fact your default is not None, so use the default value in the function method:\n\ndef .(.,desired_status\u003d\u0027success\u0027,timeout\u003dself.configuration.netapp_server_migration_state_change_timeout)","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4ba6b62bb4613b03726091e628f3746ff2d42a77","unresolved":false,"context_lines":[{"line_number":939,"context_line":""},{"line_number":940,"context_line":"    def _wait_for_operation_status("},{"line_number":941,"context_line":"            self, operation_id, get_operation, desired_status\u003d\u0027success\u0027,"},{"line_number":942,"context_line":"            timeout\u003dNone):"},{"line_number":943,"context_line":"        if not timeout:"},{"line_number":944,"context_line":"            timeout \u003d ("},{"line_number":945,"context_line":"                self.configuration.netapp_server_migration_state_change_timeout"},{"line_number":946,"context_line":"            )"},{"line_number":947,"context_line":"        interval \u003d 10"},{"line_number":948,"context_line":"        retries \u003d int(timeout / interval) or 1"},{"line_number":949,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"0810b958_ebea1a8f","line":946,"range":{"start_line":942,"start_character":12,"end_line":946,"end_character":13},"in_reply_to":"8a4083a6_17931841","updated":"2021-08-30 13:38:02.000000000","message":"Nice, I tested here, my fault!","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":939,"context_line":""},{"line_number":940,"context_line":"    def _wait_for_operation_status("},{"line_number":941,"context_line":"            self, operation_id, get_operation, desired_status\u003d\u0027success\u0027,"},{"line_number":942,"context_line":"            timeout\u003dNone):"},{"line_number":943,"context_line":"        if not timeout:"},{"line_number":944,"context_line":"            timeout \u003d ("},{"line_number":945,"context_line":"                self.configuration.netapp_server_migration_state_change_timeout"},{"line_number":946,"context_line":"            )"},{"line_number":947,"context_line":"        interval \u003d 10"},{"line_number":948,"context_line":"        retries \u003d int(timeout / interval) or 1"},{"line_number":949,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"8a4083a6_17931841","line":946,"range":{"start_line":942,"start_character":12,"end_line":946,"end_character":13},"in_reply_to":"fcd2820b_b8071288","updated":"2021-08-28 21:57:50.000000000","message":"I believe it won\u0027t work, as we cannot declare self.something in a method declaration...","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":950,"context_line":"        @utils.retry(exception.ShareBackendException, interval\u003dinterval,"},{"line_number":951,"context_line":"                     retries\u003dretries, backoff_rate\u003d1)"},{"line_number":952,"context_line":"        def wait_for_status():"},{"line_number":953,"context_line":"            # Get the job based on its id"},{"line_number":954,"context_line":"            operation \u003d get_operation(operation_id)"},{"line_number":955,"context_line":"            status \u003d operation.get(\"status\") or operation.get(\"state\")"},{"line_number":956,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"75aaa307_e471176c","line":953,"range":{"start_line":953,"start_character":39,"end_line":953,"end_character":41},"updated":"2021-08-27 12:20:24.000000000","message":"id.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":950,"context_line":"        @utils.retry(exception.ShareBackendException, interval\u003dinterval,"},{"line_number":951,"context_line":"                     retries\u003dretries, backoff_rate\u003d1)"},{"line_number":952,"context_line":"        def wait_for_status():"},{"line_number":953,"context_line":"            # Get the job based on its id"},{"line_number":954,"context_line":"            operation \u003d get_operation(operation_id)"},{"line_number":955,"context_line":"            status \u003d operation.get(\"status\") or operation.get(\"state\")"},{"line_number":956,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"c9ccf420_de6a8cc0","line":953,"range":{"start_line":953,"start_character":39,"end_line":953,"end_character":41},"in_reply_to":"75aaa307_e471176c","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":956,"context_line":""},{"line_number":957,"context_line":"            if status !\u003d desired_status:"},{"line_number":958,"context_line":"                msg \u003d _(\"Operation %(operation_id)s didn\u0027t reach status \""},{"line_number":959,"context_line":"                        \"%(desired_status)s. Current_status is %(status)s\")"},{"line_number":960,"context_line":"                msg_payload \u003d {"},{"line_number":961,"context_line":"                    \u0027operation_id\u0027: operation_id,"},{"line_number":962,"context_line":"                    \u0027desired_status\u0027: desired_status,"}],"source_content_type":"text/x-python","patch_set":10,"id":"4996ca83_5527b1ca","line":959,"range":{"start_line":959,"start_character":70,"end_line":959,"end_character":73},"updated":"2021-08-27 12:20:24.000000000","message":"add period: %(status)s.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":956,"context_line":""},{"line_number":957,"context_line":"            if status !\u003d desired_status:"},{"line_number":958,"context_line":"                msg \u003d _(\"Operation %(operation_id)s didn\u0027t reach status \""},{"line_number":959,"context_line":"                        \"%(desired_status)s. Current_status is %(status)s\")"},{"line_number":960,"context_line":"                msg_payload \u003d {"},{"line_number":961,"context_line":"                    \u0027operation_id\u0027: operation_id,"},{"line_number":962,"context_line":"                    \u0027desired_status\u0027: desired_status,"}],"source_content_type":"text/x-python","patch_set":10,"id":"078e017f_c22036b0","line":959,"range":{"start_line":959,"start_character":70,"end_line":959,"end_character":73},"in_reply_to":"4996ca83_5527b1ca","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":964,"context_line":"                }"},{"line_number":965,"context_line":"                LOG.debug(msg, msg_payload)"},{"line_number":966,"context_line":""},{"line_number":967,"context_line":"                # Failed, no need to retry"},{"line_number":968,"context_line":"                if status \u003d\u003d \u0027error\u0027:"},{"line_number":969,"context_line":"                    msg \u003d _(\u0027Operation %(operation_id)s is in error status.\u0027"},{"line_number":970,"context_line":"                            \u0027Reason: %(message)s\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"4106c8d8_84c84080","line":967,"range":{"start_line":967,"start_character":37,"end_line":967,"end_character":42},"updated":"2021-08-27 12:20:24.000000000","message":"retry.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":964,"context_line":"                }"},{"line_number":965,"context_line":"                LOG.debug(msg, msg_payload)"},{"line_number":966,"context_line":""},{"line_number":967,"context_line":"                # Failed, no need to retry"},{"line_number":968,"context_line":"                if status \u003d\u003d \u0027error\u0027:"},{"line_number":969,"context_line":"                    msg \u003d _(\u0027Operation %(operation_id)s is in error status.\u0027"},{"line_number":970,"context_line":"                            \u0027Reason: %(message)s\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"b717d9a9_9eb3ac7b","line":967,"range":{"start_line":967,"start_character":37,"end_line":967,"end_character":42},"in_reply_to":"4106c8d8_84c84080","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":972,"context_line":"                        msg % {\u0027operation_id\u0027: operation_id,"},{"line_number":973,"context_line":"                               \u0027message\u0027: operation.get(\u0027message\u0027)})"},{"line_number":974,"context_line":""},{"line_number":975,"context_line":"                # Didn\u0027t fail, so we can retry"},{"line_number":976,"context_line":"                raise exception.ShareBackendException(msg)"},{"line_number":977,"context_line":""},{"line_number":978,"context_line":"            elif status \u003d\u003d desired_status:"}],"source_content_type":"text/x-python","patch_set":10,"id":"61d8227c_59249542","line":975,"range":{"start_line":975,"start_character":44,"end_line":975,"end_character":46},"updated":"2021-08-27 12:20:24.000000000","message":"retry.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4ba6b62bb4613b03726091e628f3746ff2d42a77","unresolved":true,"context_lines":[{"line_number":972,"context_line":"                        msg % {\u0027operation_id\u0027: operation_id,"},{"line_number":973,"context_line":"                               \u0027message\u0027: operation.get(\u0027message\u0027)})"},{"line_number":974,"context_line":""},{"line_number":975,"context_line":"                # Didn\u0027t fail, so we can retry"},{"line_number":976,"context_line":"                raise exception.ShareBackendException(msg)"},{"line_number":977,"context_line":""},{"line_number":978,"context_line":"            elif status \u003d\u003d desired_status:"}],"source_content_type":"text/x-python","patch_set":10,"id":"b69bec46_91824ab0","line":975,"range":{"start_line":975,"start_character":44,"end_line":975,"end_character":46},"in_reply_to":"61d8227c_59249542","updated":"2021-08-30 13:38:02.000000000","message":"forgot this point","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0b3f78e7ed8e7f2bf0e9aa4936766961da8777c0","unresolved":false,"context_lines":[{"line_number":972,"context_line":"                        msg % {\u0027operation_id\u0027: operation_id,"},{"line_number":973,"context_line":"                               \u0027message\u0027: operation.get(\u0027message\u0027)})"},{"line_number":974,"context_line":""},{"line_number":975,"context_line":"                # Didn\u0027t fail, so we can retry"},{"line_number":976,"context_line":"                raise exception.ShareBackendException(msg)"},{"line_number":977,"context_line":""},{"line_number":978,"context_line":"            elif status \u003d\u003d desired_status:"}],"source_content_type":"text/x-python","patch_set":10,"id":"4cd60c83_a9f9470a","line":975,"range":{"start_line":975,"start_character":44,"end_line":975,"end_character":46},"in_reply_to":"b69bec46_91824ab0","updated":"2021-09-02 21:57:55.000000000","message":"Just forgot to mark as resolved, but the point is there :)","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":976,"context_line":"                raise exception.ShareBackendException(msg)"},{"line_number":977,"context_line":""},{"line_number":978,"context_line":"            elif status \u003d\u003d desired_status:"},{"line_number":979,"context_line":"                msg \u003d _(\u0027Operation %(operation_id)s reached status %(status)s\u0027)"},{"line_number":980,"context_line":"                LOG.debug("},{"line_number":981,"context_line":"                    msg, {\u0027operation_id\u0027: operation_id, \u0027status\u0027: status})"},{"line_number":982,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":10,"id":"fe59a785_17db9cc8","line":979,"range":{"start_line":979,"start_character":76,"end_line":979,"end_character":77},"updated":"2021-08-27 12:20:24.000000000","message":"s.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":976,"context_line":"                raise exception.ShareBackendException(msg)"},{"line_number":977,"context_line":""},{"line_number":978,"context_line":"            elif status \u003d\u003d desired_status:"},{"line_number":979,"context_line":"                msg \u003d _(\u0027Operation %(operation_id)s reached status %(status)s\u0027)"},{"line_number":980,"context_line":"                LOG.debug("},{"line_number":981,"context_line":"                    msg, {\u0027operation_id\u0027: operation_id, \u0027status\u0027: status})"},{"line_number":982,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":10,"id":"fade8c5f_e57d62cf","line":979,"range":{"start_line":979,"start_character":76,"end_line":979,"end_character":77},"in_reply_to":"fe59a785_17db9cc8","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":982,"context_line":"                return"},{"line_number":983,"context_line":"        try:"},{"line_number":984,"context_line":"            wait_for_status()"},{"line_number":985,"context_line":"        except exception.NetAppException as e:"},{"line_number":986,"context_line":"            raise exception.NetAppException(message\u003de.message)"},{"line_number":987,"context_line":"        except exception.ShareBackendException:"},{"line_number":988,"context_line":"            msg_args \u003d {\u0027operation_id\u0027: operation_id, \u0027status\u0027: desired_status}"},{"line_number":989,"context_line":"            msg \u003d _(\u0027Timed out while waiting for operation %(operation_id)s \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"5febd26e_8c30bcc2","line":986,"range":{"start_line":985,"start_character":8,"end_line":986,"end_character":62},"updated":"2021-08-27 12:20:24.000000000","message":"why are u catching the exception to raise the same ?","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":982,"context_line":"                return"},{"line_number":983,"context_line":"        try:"},{"line_number":984,"context_line":"            wait_for_status()"},{"line_number":985,"context_line":"        except exception.NetAppException as e:"},{"line_number":986,"context_line":"            raise exception.NetAppException(message\u003de.message)"},{"line_number":987,"context_line":"        except exception.ShareBackendException:"},{"line_number":988,"context_line":"            msg_args \u003d {\u0027operation_id\u0027: operation_id, \u0027status\u0027: desired_status}"},{"line_number":989,"context_line":"            msg \u003d _(\u0027Timed out while waiting for operation %(operation_id)s \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"2ad73df2_3e4ac13d","line":986,"range":{"start_line":985,"start_character":8,"end_line":986,"end_character":62},"in_reply_to":"5febd26e_8c30bcc2","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":987,"context_line":"        except exception.ShareBackendException:"},{"line_number":988,"context_line":"            msg_args \u003d {\u0027operation_id\u0027: operation_id, \u0027status\u0027: desired_status}"},{"line_number":989,"context_line":"            msg \u003d _(\u0027Timed out while waiting for operation %(operation_id)s \u0027"},{"line_number":990,"context_line":"                    \u0027to reach status %(status)s\u0027) % msg_args"},{"line_number":991,"context_line":"            LOG.debug(msg)"},{"line_number":992,"context_line":""},{"line_number":993,"context_line":"    def _check_compatibility_for_svm_migrate("}],"source_content_type":"text/x-python","patch_set":10,"id":"93811ae0_71f46c06","line":990,"range":{"start_line":990,"start_character":46,"end_line":990,"end_character":47},"updated":"2021-08-27 12:20:24.000000000","message":"s.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":987,"context_line":"        except exception.ShareBackendException:"},{"line_number":988,"context_line":"            msg_args \u003d {\u0027operation_id\u0027: operation_id, \u0027status\u0027: desired_status}"},{"line_number":989,"context_line":"            msg \u003d _(\u0027Timed out while waiting for operation %(operation_id)s \u0027"},{"line_number":990,"context_line":"                    \u0027to reach status %(status)s\u0027) % msg_args"},{"line_number":991,"context_line":"            LOG.debug(msg)"},{"line_number":992,"context_line":""},{"line_number":993,"context_line":"    def _check_compatibility_for_svm_migrate("}],"source_content_type":"text/x-python","patch_set":10,"id":"2fbf0ec1_e2e6d675","line":990,"range":{"start_line":990,"start_character":46,"end_line":990,"end_character":47},"in_reply_to":"93811ae0_71f46c06","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":988,"context_line":"            msg_args \u003d {\u0027operation_id\u0027: operation_id, \u0027status\u0027: desired_status}"},{"line_number":989,"context_line":"            msg \u003d _(\u0027Timed out while waiting for operation %(operation_id)s \u0027"},{"line_number":990,"context_line":"                    \u0027to reach status %(status)s\u0027) % msg_args"},{"line_number":991,"context_line":"            LOG.debug(msg)"},{"line_number":992,"context_line":""},{"line_number":993,"context_line":"    def _check_compatibility_for_svm_migrate("},{"line_number":994,"context_line":"            self, source_cluster_name, source_share_server_name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"f27695cc_93c0730a","line":991,"range":{"start_line":991,"start_character":16,"end_line":991,"end_character":21},"updated":"2021-08-27 12:20:24.000000000","message":"debug ? should not it be a LOG.exception or LOG.error ?","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":988,"context_line":"            msg_args \u003d {\u0027operation_id\u0027: operation_id, \u0027status\u0027: desired_status}"},{"line_number":989,"context_line":"            msg \u003d _(\u0027Timed out while waiting for operation %(operation_id)s \u0027"},{"line_number":990,"context_line":"                    \u0027to reach status %(status)s\u0027) % msg_args"},{"line_number":991,"context_line":"            LOG.debug(msg)"},{"line_number":992,"context_line":""},{"line_number":993,"context_line":"    def _check_compatibility_for_svm_migrate("},{"line_number":994,"context_line":"            self, source_cluster_name, source_share_server_name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"46b06114_839d6193","line":991,"range":{"start_line":991,"start_character":12,"end_line":991,"end_character":25},"updated":"2021-08-27 12:20:24.000000000","message":"why are u not rerasing in the timeout error ?!","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4ba6b62bb4613b03726091e628f3746ff2d42a77","unresolved":false,"context_lines":[{"line_number":988,"context_line":"            msg_args \u003d {\u0027operation_id\u0027: operation_id, \u0027status\u0027: desired_status}"},{"line_number":989,"context_line":"            msg \u003d _(\u0027Timed out while waiting for operation %(operation_id)s \u0027"},{"line_number":990,"context_line":"                    \u0027to reach status %(status)s\u0027) % msg_args"},{"line_number":991,"context_line":"            LOG.debug(msg)"},{"line_number":992,"context_line":""},{"line_number":993,"context_line":"    def _check_compatibility_for_svm_migrate("},{"line_number":994,"context_line":"            self, source_cluster_name, source_share_server_name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"56182d63_08701298","line":991,"range":{"start_line":991,"start_character":12,"end_line":991,"end_character":25},"in_reply_to":"32f3bd01_5936f4e7","updated":"2021-08-30 13:38:02.000000000","message":"Yeah, how the caller knows that this function got a timeout error ?! If I understood correct, for the caller the timeout is not an error. Is this the expected behavior ?!","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":988,"context_line":"            msg_args \u003d {\u0027operation_id\u0027: operation_id, \u0027status\u0027: desired_status}"},{"line_number":989,"context_line":"            msg \u003d _(\u0027Timed out while waiting for operation %(operation_id)s \u0027"},{"line_number":990,"context_line":"                    \u0027to reach status %(status)s\u0027) % msg_args"},{"line_number":991,"context_line":"            LOG.debug(msg)"},{"line_number":992,"context_line":""},{"line_number":993,"context_line":"    def _check_compatibility_for_svm_migrate("},{"line_number":994,"context_line":"            self, source_cluster_name, source_share_server_name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"32f3bd01_5936f4e7","line":991,"range":{"start_line":991,"start_character":12,"end_line":991,"end_character":25},"in_reply_to":"46b06114_839d6193","updated":"2021-08-28 21:57:50.000000000","message":"timeout is being controlled by the ShareBackendException","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0b3f78e7ed8e7f2bf0e9aa4936766961da8777c0","unresolved":false,"context_lines":[{"line_number":988,"context_line":"            msg_args \u003d {\u0027operation_id\u0027: operation_id, \u0027status\u0027: desired_status}"},{"line_number":989,"context_line":"            msg \u003d _(\u0027Timed out while waiting for operation %(operation_id)s \u0027"},{"line_number":990,"context_line":"                    \u0027to reach status %(status)s\u0027) % msg_args"},{"line_number":991,"context_line":"            LOG.debug(msg)"},{"line_number":992,"context_line":""},{"line_number":993,"context_line":"    def _check_compatibility_for_svm_migrate("},{"line_number":994,"context_line":"            self, source_cluster_name, source_share_server_name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"516b52fa_e43e2c30","line":991,"range":{"start_line":991,"start_character":12,"end_line":991,"end_character":25},"in_reply_to":"56182d63_08701298","updated":"2021-09-02 21:57:55.000000000","message":"Nope, I should be raising an error instead of adding a LOG. Will fix in the next PS","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":988,"context_line":"            msg_args \u003d {\u0027operation_id\u0027: operation_id, \u0027status\u0027: desired_status}"},{"line_number":989,"context_line":"            msg \u003d _(\u0027Timed out while waiting for operation %(operation_id)s \u0027"},{"line_number":990,"context_line":"                    \u0027to reach status %(status)s\u0027) % msg_args"},{"line_number":991,"context_line":"            LOG.debug(msg)"},{"line_number":992,"context_line":""},{"line_number":993,"context_line":"    def _check_compatibility_for_svm_migrate("},{"line_number":994,"context_line":"            self, source_cluster_name, source_share_server_name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"62b13fad_4cb04e1c","line":991,"range":{"start_line":991,"start_character":16,"end_line":991,"end_character":21},"in_reply_to":"f27695cc_93c0730a","updated":"2021-08-28 21:57:50.000000000","message":"error sounds better, thanks","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":990,"context_line":"                    \u0027to reach status %(status)s\u0027) % msg_args"},{"line_number":991,"context_line":"            LOG.debug(msg)"},{"line_number":992,"context_line":""},{"line_number":993,"context_line":"    def _check_compatibility_for_svm_migrate("},{"line_number":994,"context_line":"            self, source_cluster_name, source_share_server_name,"},{"line_number":995,"context_line":"            source_share_server, dest_aggregates, dest_client):"},{"line_number":996,"context_line":"        \"\"\"Checks if the migration can be performed using SVM Migrate."}],"source_content_type":"text/x-python","patch_set":10,"id":"94e34b6b_7444e6de","line":993,"range":{"start_line":993,"start_character":8,"end_line":993,"end_character":44},"updated":"2021-08-27 12:20:24.000000000","message":"@na_utils.trace","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":990,"context_line":"                    \u0027to reach status %(status)s\u0027) % msg_args"},{"line_number":991,"context_line":"            LOG.debug(msg)"},{"line_number":992,"context_line":""},{"line_number":993,"context_line":"    def _check_compatibility_for_svm_migrate("},{"line_number":994,"context_line":"            self, source_cluster_name, source_share_server_name,"},{"line_number":995,"context_line":"            source_share_server, dest_aggregates, dest_client):"},{"line_number":996,"context_line":"        \"\"\"Checks if the migration can be performed using SVM Migrate."}],"source_content_type":"text/x-python","patch_set":10,"id":"04a92299_eef36513","line":993,"range":{"start_line":993,"start_character":8,"end_line":993,"end_character":44},"in_reply_to":"94e34b6b_7444e6de","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1000,"context_line":"        \"\"\""},{"line_number":1001,"context_line":"        src_server_id \u003d source_share_server[\u0027id\u0027]"},{"line_number":1002,"context_line":""},{"line_number":1003,"context_line":"        # 1. Sends the request to the backend"},{"line_number":1004,"context_line":"        try:"},{"line_number":1005,"context_line":"            job \u003d dest_client.svm_migration_start("},{"line_number":1006,"context_line":"                source_cluster_name, source_share_server_name, dest_aggregates,"}],"source_content_type":"text/x-python","patch_set":10,"id":"e49cb21d_9d912f69","line":1003,"range":{"start_line":1003,"start_character":38,"end_line":1003,"end_character":45},"updated":"2021-08-27 12:20:24.000000000","message":"backend.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1000,"context_line":"        \"\"\""},{"line_number":1001,"context_line":"        src_server_id \u003d source_share_server[\u0027id\u0027]"},{"line_number":1002,"context_line":""},{"line_number":1003,"context_line":"        # 1. Sends the request to the backend"},{"line_number":1004,"context_line":"        try:"},{"line_number":1005,"context_line":"            job \u003d dest_client.svm_migration_start("},{"line_number":1006,"context_line":"                source_cluster_name, source_share_server_name, dest_aggregates,"}],"source_content_type":"text/x-python","patch_set":10,"id":"dbdc247f_acdf5a05","line":1003,"range":{"start_line":1003,"start_character":38,"end_line":1003,"end_character":45},"in_reply_to":"e49cb21d_9d912f69","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1006,"context_line":"                source_cluster_name, source_share_server_name, dest_aggregates,"},{"line_number":1007,"context_line":"                check_only\u003dTrue)"},{"line_number":1008,"context_line":"        except Exception:"},{"line_number":1009,"context_line":"            LOG.debug(\u0027Failed to check compatibility for migration.\u0027)"},{"line_number":1010,"context_line":"            raise"},{"line_number":1011,"context_line":""},{"line_number":1012,"context_line":"        job_id \u003d self._get_job_uuid(job)"}],"source_content_type":"text/x-python","patch_set":10,"id":"4865bf10_ef2910ac","line":1009,"range":{"start_line":1009,"start_character":16,"end_line":1009,"end_character":21},"updated":"2021-08-27 12:20:24.000000000","message":"LOG.exception or LOG.error\n\nWhy are u not logging the error.message ?!","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1006,"context_line":"                source_cluster_name, source_share_server_name, dest_aggregates,"},{"line_number":1007,"context_line":"                check_only\u003dTrue)"},{"line_number":1008,"context_line":"        except Exception:"},{"line_number":1009,"context_line":"            LOG.debug(\u0027Failed to check compatibility for migration.\u0027)"},{"line_number":1010,"context_line":"            raise"},{"line_number":1011,"context_line":""},{"line_number":1012,"context_line":"        job_id \u003d self._get_job_uuid(job)"}],"source_content_type":"text/x-python","patch_set":10,"id":"706ebeff_a17165a2","line":1009,"range":{"start_line":1009,"start_character":16,"end_line":1009,"end_character":21},"in_reply_to":"4865bf10_ef2910ac","updated":"2021-08-28 21:57:50.000000000","message":"it\u0027s better to error this out. changed.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1017,"context_line":"                \u0027Waiting on share server migration check result for share \u0027"},{"line_number":1018,"context_line":"                \u0027server %s to complete. Current status is: %s.\u0027,"},{"line_number":1019,"context_line":"                src_server_id, job_state)"},{"line_number":1020,"context_line":"            if job_state \u003d\u003d \u0027success\u0027:"},{"line_number":1021,"context_line":"                raise loopingcall.LoopingCallDone()"},{"line_number":1022,"context_line":""},{"line_number":1023,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"22a7c26e_ccc72f33","line":1020,"range":{"start_line":1020,"start_character":15,"end_line":1020,"end_character":38},"updated":"2021-08-27 12:20:24.000000000","message":"what if the job in error state ? It will keep waiting until timeout, it could be finished earlier, though.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1017,"context_line":"                \u0027Waiting on share server migration check result for share \u0027"},{"line_number":1018,"context_line":"                \u0027server %s to complete. Current status is: %s.\u0027,"},{"line_number":1019,"context_line":"                src_server_id, job_state)"},{"line_number":1020,"context_line":"            if job_state \u003d\u003d \u0027success\u0027:"},{"line_number":1021,"context_line":"                raise loopingcall.LoopingCallDone()"},{"line_number":1022,"context_line":""},{"line_number":1023,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"d7dd731d_38eb53e5","line":1020,"range":{"start_line":1020,"start_character":15,"end_line":1020,"end_character":38},"in_reply_to":"22a7c26e_ccc72f33","updated":"2021-08-28 21:57:50.000000000","message":"if the job is in error state, the client/api will raise NaApiError, and the get_migration_check_job_state method is expecting that. In such case, the client_cmode method will raise NetAppException and it will immediately go to line 1034.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1021,"context_line":"                raise loopingcall.LoopingCallDone()"},{"line_number":1022,"context_line":""},{"line_number":1023,"context_line":"        try:"},{"line_number":1024,"context_line":"            # 2. Wait until the job to check the migration status concludes"},{"line_number":1025,"context_line":"            timer \u003d loopingcall.FixedIntervalWithTimeoutLoopingCall("},{"line_number":1026,"context_line":"                _wait_migration_check_result)"},{"line_number":1027,"context_line":"            timer.start(interval\u003d10, timeout\u003d360).wait()"}],"source_content_type":"text/x-python","patch_set":10,"id":"713c51e8_925d19c9","line":1024,"range":{"start_line":1024,"start_character":66,"end_line":1024,"end_character":75},"updated":"2021-08-27 12:20:24.000000000","message":"concludes.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1021,"context_line":"                raise loopingcall.LoopingCallDone()"},{"line_number":1022,"context_line":""},{"line_number":1023,"context_line":"        try:"},{"line_number":1024,"context_line":"            # 2. Wait until the job to check the migration status concludes"},{"line_number":1025,"context_line":"            timer \u003d loopingcall.FixedIntervalWithTimeoutLoopingCall("},{"line_number":1026,"context_line":"                _wait_migration_check_result)"},{"line_number":1027,"context_line":"            timer.start(interval\u003d10, timeout\u003d360).wait()"}],"source_content_type":"text/x-python","patch_set":10,"id":"8903f345_db18c96b","line":1024,"range":{"start_line":1024,"start_character":66,"end_line":1024,"end_character":75},"in_reply_to":"713c51e8_925d19c9","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1024,"context_line":"            # 2. Wait until the job to check the migration status concludes"},{"line_number":1025,"context_line":"            timer \u003d loopingcall.FixedIntervalWithTimeoutLoopingCall("},{"line_number":1026,"context_line":"                _wait_migration_check_result)"},{"line_number":1027,"context_line":"            timer.start(interval\u003d10, timeout\u003d360).wait()"},{"line_number":1028,"context_line":"            return True"},{"line_number":1029,"context_line":"        except loopingcall.LoopingCallTimeOut:"},{"line_number":1030,"context_line":"            msg \u003d ("}],"source_content_type":"text/x-python","patch_set":10,"id":"88580f7f_8b84eae6","line":1027,"range":{"start_line":1027,"start_character":45,"end_line":1027,"end_character":48},"updated":"2021-08-27 12:20:24.000000000","message":"please reuse or create migration timeout configuration","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1024,"context_line":"            # 2. Wait until the job to check the migration status concludes"},{"line_number":1025,"context_line":"            timer \u003d loopingcall.FixedIntervalWithTimeoutLoopingCall("},{"line_number":1026,"context_line":"                _wait_migration_check_result)"},{"line_number":1027,"context_line":"            timer.start(interval\u003d10, timeout\u003d360).wait()"},{"line_number":1028,"context_line":"            return True"},{"line_number":1029,"context_line":"        except loopingcall.LoopingCallTimeOut:"},{"line_number":1030,"context_line":"            msg \u003d ("}],"source_content_type":"text/x-python","patch_set":10,"id":"7c8b83ab_afabc233","line":1027,"range":{"start_line":1027,"start_character":45,"end_line":1027,"end_character":48},"in_reply_to":"88580f7f_8b84eae6","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1031,"context_line":"                _(\u0027Timeout waiting migration check for share server %s to \u0027"},{"line_number":1032,"context_line":"                  \u0027be performed.\u0027))"},{"line_number":1033,"context_line":"            raise exception.NetAppException(msg % src_server_id)"},{"line_number":1034,"context_line":"        except exception.NetAppException:"},{"line_number":1035,"context_line":"            # Performed the check with the given parameters and the backend"},{"line_number":1036,"context_line":"            # returned an error, so the migration is not compatible"},{"line_number":1037,"context_line":"            return False"},{"line_number":1038,"context_line":""},{"line_number":1039,"context_line":"    def _check_for_migration_support("},{"line_number":1040,"context_line":"            self, src_client, dest_client, source_share_server,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3dd7c1b3_aa70c5f9","line":1037,"range":{"start_line":1034,"start_character":8,"end_line":1037,"end_character":24},"updated":"2021-08-27 12:20:24.000000000","message":"Any error will be treated as  \"not compatible\" ?! What if it fails for another reason ?! It does not mean that the migration is not compatible","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1031,"context_line":"                _(\u0027Timeout waiting migration check for share server %s to \u0027"},{"line_number":1032,"context_line":"                  \u0027be performed.\u0027))"},{"line_number":1033,"context_line":"            raise exception.NetAppException(msg % src_server_id)"},{"line_number":1034,"context_line":"        except exception.NetAppException:"},{"line_number":1035,"context_line":"            # Performed the check with the given parameters and the backend"},{"line_number":1036,"context_line":"            # returned an error, so the migration is not compatible"},{"line_number":1037,"context_line":"            return False"},{"line_number":1038,"context_line":""},{"line_number":1039,"context_line":"    def _check_for_migration_support("},{"line_number":1040,"context_line":"            self, src_client, dest_client, source_share_server,"}],"source_content_type":"text/x-python","patch_set":10,"id":"bdb0e65d_752aa365","line":1037,"range":{"start_line":1034,"start_character":8,"end_line":1037,"end_character":24},"in_reply_to":"3dd7c1b3_aa70c5f9","updated":"2021-08-28 21:57:50.000000000","message":"In this case, the logs would need to be checked... The migration will be always considered False and the user can recheck the operation. The logs will contain the exact message returned by the NaApiError","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4ba6b62bb4613b03726091e628f3746ff2d42a77","unresolved":false,"context_lines":[{"line_number":1031,"context_line":"                _(\u0027Timeout waiting migration check for share server %s to \u0027"},{"line_number":1032,"context_line":"                  \u0027be performed.\u0027))"},{"line_number":1033,"context_line":"            raise exception.NetAppException(msg % src_server_id)"},{"line_number":1034,"context_line":"        except exception.NetAppException:"},{"line_number":1035,"context_line":"            # Performed the check with the given parameters and the backend"},{"line_number":1036,"context_line":"            # returned an error, so the migration is not compatible"},{"line_number":1037,"context_line":"            return False"},{"line_number":1038,"context_line":""},{"line_number":1039,"context_line":"    def _check_for_migration_support("},{"line_number":1040,"context_line":"            self, src_client, dest_client, source_share_server,"}],"source_content_type":"text/x-python","patch_set":10,"id":"b9cb2a2b_7771713b","line":1037,"range":{"start_line":1034,"start_character":8,"end_line":1037,"end_character":24},"in_reply_to":"bdb0e65d_752aa365","updated":"2021-08-30 13:38:02.000000000","message":"I got you\u0027re point, the migration check design requires the user to look at the LOG in False state. So, you\u0027re following it. Nice!","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1036,"context_line":"            # returned an error, so the migration is not compatible"},{"line_number":1037,"context_line":"            return False"},{"line_number":1038,"context_line":""},{"line_number":1039,"context_line":"    def _check_for_migration_support("},{"line_number":1040,"context_line":"            self, src_client, dest_client, source_share_server,"},{"line_number":1041,"context_line":"            shares_request_spec, src_cluster_name, pools):"},{"line_number":1042,"context_line":"        \"\"\"Checks if the migration is supported and chooses the way to do it."}],"source_content_type":"text/x-python","patch_set":10,"id":"a50d75ef_f0c77a93","line":1039,"range":{"start_line":1039,"start_character":8,"end_line":1039,"end_character":36},"updated":"2021-08-27 12:20:24.000000000","message":"@na_utils.trace","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1036,"context_line":"            # returned an error, so the migration is not compatible"},{"line_number":1037,"context_line":"            return False"},{"line_number":1038,"context_line":""},{"line_number":1039,"context_line":"    def _check_for_migration_support("},{"line_number":1040,"context_line":"            self, src_client, dest_client, source_share_server,"},{"line_number":1041,"context_line":"            shares_request_spec, src_cluster_name, pools):"},{"line_number":1042,"context_line":"        \"\"\"Checks if the migration is supported and chooses the way to do it."}],"source_content_type":"text/x-python","patch_set":10,"id":"b771c3f5_eef33abd","line":1039,"range":{"start_line":1039,"start_character":8,"end_line":1039,"end_character":36},"in_reply_to":"a50d75ef_f0c77a93","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1039,"context_line":"    def _check_for_migration_support("},{"line_number":1040,"context_line":"            self, src_client, dest_client, source_share_server,"},{"line_number":1041,"context_line":"            shares_request_spec, src_cluster_name, pools):"},{"line_number":1042,"context_line":"        \"\"\"Checks if the migration is supported and chooses the way to do it."},{"line_number":1043,"context_line":""},{"line_number":1044,"context_line":"        1. Checks if both source and destination clients support SVM Migrate"},{"line_number":1045,"context_line":"        2. Requests the migration"}],"source_content_type":"text/x-python","patch_set":10,"id":"e4421f13_7c524ac4","line":1042,"range":{"start_line":1042,"start_character":11,"end_line":1042,"end_character":77},"updated":"2021-08-27 12:20:24.000000000","message":"Please, the precedence method is important here, explain it, maybe:\n\n\"SVM migrate method is prefered, the SVM DR is only tring if the\nprevious is not available.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1039,"context_line":"    def _check_for_migration_support("},{"line_number":1040,"context_line":"            self, src_client, dest_client, source_share_server,"},{"line_number":1041,"context_line":"            shares_request_spec, src_cluster_name, pools):"},{"line_number":1042,"context_line":"        \"\"\"Checks if the migration is supported and chooses the way to do it."},{"line_number":1043,"context_line":""},{"line_number":1044,"context_line":"        1. Checks if both source and destination clients support SVM Migrate"},{"line_number":1045,"context_line":"        2. Requests the migration"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7955b1_165e97ba","line":1042,"range":{"start_line":1042,"start_character":11,"end_line":1042,"end_character":77},"in_reply_to":"e4421f13_7c524ac4","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1045,"context_line":"        2. Requests the migration"},{"line_number":1046,"context_line":"        \"\"\""},{"line_number":1047,"context_line":""},{"line_number":1048,"context_line":"        # 1. Checks if both source and destination clients support SVM Migrate"},{"line_number":1049,"context_line":"        if (dest_client.is_svm_migrate_supported()"},{"line_number":1050,"context_line":"                and src_client.is_svm_migrate_supported()):"},{"line_number":1051,"context_line":"            source_share_server_name \u003d self._get_vserver_name("}],"source_content_type":"text/x-python","patch_set":10,"id":"a553b87e_017fc104","line":1048,"range":{"start_line":1048,"start_character":71,"end_line":1048,"end_character":78},"updated":"2021-08-27 12:20:24.000000000","message":"Migrate.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1045,"context_line":"        2. Requests the migration"},{"line_number":1046,"context_line":"        \"\"\""},{"line_number":1047,"context_line":""},{"line_number":1048,"context_line":"        # 1. Checks if both source and destination clients support SVM Migrate"},{"line_number":1049,"context_line":"        if (dest_client.is_svm_migrate_supported()"},{"line_number":1050,"context_line":"                and src_client.is_svm_migrate_supported()):"},{"line_number":1051,"context_line":"            source_share_server_name \u003d self._get_vserver_name("}],"source_content_type":"text/x-python","patch_set":10,"id":"12693649_3ecf8b1a","line":1048,"range":{"start_line":1048,"start_character":71,"end_line":1048,"end_character":78},"in_reply_to":"a553b87e_017fc104","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1051,"context_line":"            source_share_server_name \u003d self._get_vserver_name("},{"line_number":1052,"context_line":"                source_share_server[\u0027id\u0027])"},{"line_number":1053,"context_line":""},{"line_number":1054,"context_line":"            # Check if the migration is supported"},{"line_number":1055,"context_line":"            try:"},{"line_number":1056,"context_line":"                result \u003d self._check_compatibility_for_svm_migrate("},{"line_number":1057,"context_line":"                    src_cluster_name, source_share_server_name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"e4afd3ed_173f8e9b","line":1054,"range":{"start_line":1054,"start_character":40,"end_line":1054,"end_character":49},"updated":"2021-08-27 12:20:24.000000000","message":"supported.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1051,"context_line":"            source_share_server_name \u003d self._get_vserver_name("},{"line_number":1052,"context_line":"                source_share_server[\u0027id\u0027])"},{"line_number":1053,"context_line":""},{"line_number":1054,"context_line":"            # Check if the migration is supported"},{"line_number":1055,"context_line":"            try:"},{"line_number":1056,"context_line":"                result \u003d self._check_compatibility_for_svm_migrate("},{"line_number":1057,"context_line":"                    src_cluster_name, source_share_server_name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"73fe61d6_209a079d","line":1054,"range":{"start_line":1054,"start_character":40,"end_line":1054,"end_character":49},"in_reply_to":"e4afd3ed_173f8e9b","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1057,"context_line":"                    src_cluster_name, source_share_server_name,"},{"line_number":1058,"context_line":"                    source_share_server, self._find_matching_aggregates(),"},{"line_number":1059,"context_line":"                    dest_client)"},{"line_number":1060,"context_line":"                return \u0027svm_migrate\u0027, result"},{"line_number":1061,"context_line":"            except Exception:"},{"line_number":1062,"context_line":"                LOG.error(\u0027Failed to check the migration compatibility.\u0027)"},{"line_number":1063,"context_line":"                return \u0027svm_migrate\u0027, False"}],"source_content_type":"text/x-python","patch_set":10,"id":"4241bc7b_b7dd8333","line":1060,"range":{"start_line":1060,"start_character":24,"end_line":1060,"end_character":35},"updated":"2021-08-27 12:20:24.000000000","message":"avoid to use hard coded strings, use the utis:\n\nutils.SVM_MIGRATE_METHOD","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1057,"context_line":"                    src_cluster_name, source_share_server_name,"},{"line_number":1058,"context_line":"                    source_share_server, self._find_matching_aggregates(),"},{"line_number":1059,"context_line":"                    dest_client)"},{"line_number":1060,"context_line":"                return \u0027svm_migrate\u0027, result"},{"line_number":1061,"context_line":"            except Exception:"},{"line_number":1062,"context_line":"                LOG.error(\u0027Failed to check the migration compatibility.\u0027)"},{"line_number":1063,"context_line":"                return \u0027svm_migrate\u0027, False"}],"source_content_type":"text/x-python","patch_set":10,"id":"85429bfa_ba6879e6","line":1060,"range":{"start_line":1060,"start_character":24,"end_line":1060,"end_character":35},"in_reply_to":"4241bc7b_b7dd8333","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1059,"context_line":"                    dest_client)"},{"line_number":1060,"context_line":"                return \u0027svm_migrate\u0027, result"},{"line_number":1061,"context_line":"            except Exception:"},{"line_number":1062,"context_line":"                LOG.error(\u0027Failed to check the migration compatibility.\u0027)"},{"line_number":1063,"context_line":"                return \u0027svm_migrate\u0027, False"},{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":"        # SVM Migrate is not supported, try to check the compatibility using"}],"source_content_type":"text/x-python","patch_set":10,"id":"0c517138_894fa02a","line":1062,"range":{"start_line":1062,"start_character":57,"end_line":1062,"end_character":70},"updated":"2021-08-27 12:20:24.000000000","message":"add the info about the SVM migrate. Maybe:\n\n\"Failed to check the migration compatibility using SVM migrate method.\"","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1059,"context_line":"                    dest_client)"},{"line_number":1060,"context_line":"                return \u0027svm_migrate\u0027, result"},{"line_number":1061,"context_line":"            except Exception:"},{"line_number":1062,"context_line":"                LOG.error(\u0027Failed to check the migration compatibility.\u0027)"},{"line_number":1063,"context_line":"                return \u0027svm_migrate\u0027, False"},{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":"        # SVM Migrate is not supported, try to check the compatibility using"}],"source_content_type":"text/x-python","patch_set":10,"id":"d7e93fbe_7b76a47e","line":1062,"range":{"start_line":1062,"start_character":57,"end_line":1062,"end_character":70},"in_reply_to":"0c517138_894fa02a","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1060,"context_line":"                return \u0027svm_migrate\u0027, result"},{"line_number":1061,"context_line":"            except Exception:"},{"line_number":1062,"context_line":"                LOG.error(\u0027Failed to check the migration compatibility.\u0027)"},{"line_number":1063,"context_line":"                return \u0027svm_migrate\u0027, False"},{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":"        # SVM Migrate is not supported, try to check the compatibility using"},{"line_number":1066,"context_line":"        # SVM DR"}],"source_content_type":"text/x-python","patch_set":10,"id":"290bdeec_fd33dac2","line":1063,"range":{"start_line":1063,"start_character":24,"end_line":1063,"end_character":35},"updated":"2021-08-27 12:20:24.000000000","message":"utils.SVM_MIGRATE_METHOD","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1060,"context_line":"                return \u0027svm_migrate\u0027, result"},{"line_number":1061,"context_line":"            except Exception:"},{"line_number":1062,"context_line":"                LOG.error(\u0027Failed to check the migration compatibility.\u0027)"},{"line_number":1063,"context_line":"                return \u0027svm_migrate\u0027, False"},{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":"        # SVM Migrate is not supported, try to check the compatibility using"},{"line_number":1066,"context_line":"        # SVM DR"}],"source_content_type":"text/x-python","patch_set":10,"id":"d44b1c11_8ff7c59b","line":1063,"range":{"start_line":1063,"start_character":24,"end_line":1063,"end_character":35},"in_reply_to":"290bdeec_fd33dac2","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1063,"context_line":"                return \u0027svm_migrate\u0027, False"},{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":"        # SVM Migrate is not supported, try to check the compatibility using"},{"line_number":1066,"context_line":"        # SVM DR"},{"line_number":1067,"context_line":"        return self._check_compatibility_using_svm_dr("},{"line_number":1068,"context_line":"            src_client, dest_client, shares_request_spec, pools)"},{"line_number":1069,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"f60b2b39_1b998945","line":1066,"range":{"start_line":1066,"start_character":14,"end_line":1066,"end_character":16},"updated":"2021-08-27 12:20:24.000000000","message":"DR.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1063,"context_line":"                return \u0027svm_migrate\u0027, False"},{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":"        # SVM Migrate is not supported, try to check the compatibility using"},{"line_number":1066,"context_line":"        # SVM DR"},{"line_number":1067,"context_line":"        return self._check_compatibility_using_svm_dr("},{"line_number":1068,"context_line":"            src_client, dest_client, shares_request_spec, pools)"},{"line_number":1069,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"b5e0c907_f8f0fb31","line":1066,"range":{"start_line":1066,"start_character":14,"end_line":1066,"end_character":16},"in_reply_to":"f60b2b39_1b998945","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1122,"context_line":"            LOG.error(msg)"},{"line_number":1123,"context_line":"            return not_compatible"},{"line_number":1124,"context_line":""},{"line_number":1125,"context_line":"        pools \u003d self._get_pools()"},{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"        # Check for SVM DR support"},{"line_number":1128,"context_line":"        # NOTE(dviroel): These clients can only be used for non-tunneling"}],"source_content_type":"text/x-python","patch_set":10,"id":"efdf52f8_6fa30714","line":1125,"range":{"start_line":1125,"start_character":8,"end_line":1125,"end_character":33},"updated":"2021-08-27 12:20:24.000000000","message":"Please, do not call it here, it will be used by SVM DR check, but it may not be even performed (like: SVM migrate is available). Only retrieves the pools in the part of code that will use it (as done before).","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1122,"context_line":"            LOG.error(msg)"},{"line_number":1123,"context_line":"            return not_compatible"},{"line_number":1124,"context_line":""},{"line_number":1125,"context_line":"        pools \u003d self._get_pools()"},{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"        # Check for SVM DR support"},{"line_number":1128,"context_line":"        # NOTE(dviroel): These clients can only be used for non-tunneling"}],"source_content_type":"text/x-python","patch_set":10,"id":"fe250734_6ffbc728","line":1125,"range":{"start_line":1125,"start_character":8,"end_line":1125,"end_character":33},"in_reply_to":"efdf52f8_6fa30714","updated":"2021-08-28 21:57:50.000000000","message":"Actually, it is being used on line 1160 as well, so that\u0027s why I kept this declaration here...","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1124,"context_line":""},{"line_number":1125,"context_line":"        pools \u003d self._get_pools()"},{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"        # Check for SVM DR support"},{"line_number":1128,"context_line":"        # NOTE(dviroel): These clients can only be used for non-tunneling"},{"line_number":1129,"context_line":"        # requests."},{"line_number":1130,"context_line":"        dst_client \u003d data_motion.get_client_for_backend(dest_backend_name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"6e109b48_5aefd4a4","line":1127,"range":{"start_line":1127,"start_character":7,"end_line":1127,"end_character":34},"updated":"2021-08-27 12:20:24.000000000","message":"remove it","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1124,"context_line":""},{"line_number":1125,"context_line":"        pools \u003d self._get_pools()"},{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"        # Check for SVM DR support"},{"line_number":1128,"context_line":"        # NOTE(dviroel): These clients can only be used for non-tunneling"},{"line_number":1129,"context_line":"        # requests."},{"line_number":1130,"context_line":"        dst_client \u003d data_motion.get_client_for_backend(dest_backend_name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5727f439_c6a74a98","line":1127,"range":{"start_line":1127,"start_character":7,"end_line":1127,"end_character":34},"in_reply_to":"6e109b48_5aefd4a4","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1166,"context_line":"            # TODO(dviroel): disk_type extra-spec"},{"line_number":1167,"context_line":""},{"line_number":1168,"context_line":"        nondisruptive \u003d ("},{"line_number":1169,"context_line":"            (migration_method \u003d\u003d \u0027svm_migrate\u0027)"},{"line_number":1170,"context_line":"            and (old_share_network[\u0027id\u0027] \u003d\u003d new_share_network[\u0027id\u0027]))"},{"line_number":1171,"context_line":""},{"line_number":1172,"context_line":"        compatibility \u003d {"}],"source_content_type":"text/x-python","patch_set":10,"id":"5999f133_8c924efe","line":1169,"range":{"start_line":1169,"start_character":34,"end_line":1169,"end_character":45},"updated":"2021-08-27 12:20:24.000000000","message":"Avoid hard coded string, use the utils:\n\nutils.SVM_MIGRATE_METHOD","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1166,"context_line":"            # TODO(dviroel): disk_type extra-spec"},{"line_number":1167,"context_line":""},{"line_number":1168,"context_line":"        nondisruptive \u003d ("},{"line_number":1169,"context_line":"            (migration_method \u003d\u003d \u0027svm_migrate\u0027)"},{"line_number":1170,"context_line":"            and (old_share_network[\u0027id\u0027] \u003d\u003d new_share_network[\u0027id\u0027]))"},{"line_number":1171,"context_line":""},{"line_number":1172,"context_line":"        compatibility \u003d {"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a91d4b4_95a6a3c9","line":1169,"range":{"start_line":1169,"start_character":34,"end_line":1169,"end_character":45},"in_reply_to":"5999f133_8c924efe","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1234,"context_line":"            raise exception.NetAppException(message\u003dmsg)"},{"line_number":1235,"context_line":"        return None"},{"line_number":1236,"context_line":""},{"line_number":1237,"context_line":"    def _get_client_for_svm_migrate(self, share_server_to_get_client):"},{"line_number":1238,"context_line":"        \"\"\"Returns a cluster client to perform migration actions.\"\"\""},{"line_number":1239,"context_line":"        backend_name \u003d share_utils.extract_host("},{"line_number":1240,"context_line":"            share_server_to_get_client[\u0027host\u0027], level\u003d\u0027backend_name\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"bf1da6e7_64c3b1d9","line":1237,"range":{"start_line":1237,"start_character":8,"end_line":1237,"end_character":35},"updated":"2021-08-27 12:20:24.000000000","message":"@na_utils.trace\n\nI did not understand why u are calling as: \"get client for svm migrate\". It is just getting a client for the share server, the SVM migrate has no relation to it, right ?! So you should name it as \"get_client_for_share_server\"\n\nIn fact, I think you do not need this method, you could use the \"get_client_and_vserver_name\" in the data motion directly. If that method does not fit in our case, try to change it to be more generic or create a new one in the data motion (this method is not using anything from the lib class by self reference).","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1234,"context_line":"            raise exception.NetAppException(message\u003dmsg)"},{"line_number":1235,"context_line":"        return None"},{"line_number":1236,"context_line":""},{"line_number":1237,"context_line":"    def _get_client_for_svm_migrate(self, share_server_to_get_client):"},{"line_number":1238,"context_line":"        \"\"\"Returns a cluster client to perform migration actions.\"\"\""},{"line_number":1239,"context_line":"        backend_name \u003d share_utils.extract_host("},{"line_number":1240,"context_line":"            share_server_to_get_client[\u0027host\u0027], level\u003d\u0027backend_name\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"a52ccba4_3fc2d299","line":1237,"range":{"start_line":1237,"start_character":42,"end_line":1237,"end_character":68},"updated":"2021-08-27 12:20:24.000000000","message":"there is just one share server here, so it can be simple namre as: share_server","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0b3f78e7ed8e7f2bf0e9aa4936766961da8777c0","unresolved":false,"context_lines":[{"line_number":1234,"context_line":"            raise exception.NetAppException(message\u003dmsg)"},{"line_number":1235,"context_line":"        return None"},{"line_number":1236,"context_line":""},{"line_number":1237,"context_line":"    def _get_client_for_svm_migrate(self, share_server_to_get_client):"},{"line_number":1238,"context_line":"        \"\"\"Returns a cluster client to perform migration actions.\"\"\""},{"line_number":1239,"context_line":"        backend_name \u003d share_utils.extract_host("},{"line_number":1240,"context_line":"            share_server_to_get_client[\u0027host\u0027], level\u003d\u0027backend_name\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"19f14000_2e04ce6c","line":1237,"range":{"start_line":1237,"start_character":8,"end_line":1237,"end_character":35},"in_reply_to":"5cedd087_b67bd77a","updated":"2021-09-02 21:57:55.000000000","message":"Makes sense! Changed! Thank you","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4ba6b62bb4613b03726091e628f3746ff2d42a77","unresolved":false,"context_lines":[{"line_number":1234,"context_line":"            raise exception.NetAppException(message\u003dmsg)"},{"line_number":1235,"context_line":"        return None"},{"line_number":1236,"context_line":""},{"line_number":1237,"context_line":"    def _get_client_for_svm_migrate(self, share_server_to_get_client):"},{"line_number":1238,"context_line":"        \"\"\"Returns a cluster client to perform migration actions.\"\"\""},{"line_number":1239,"context_line":"        backend_name \u003d share_utils.extract_host("},{"line_number":1240,"context_line":"            share_server_to_get_client[\u0027host\u0027], level\u003d\u0027backend_name\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5cedd087_b67bd77a","line":1237,"range":{"start_line":1237,"start_character":8,"end_line":1237,"end_character":35},"in_reply_to":"7ac449e1_8c1de442","updated":"2021-08-30 13:38:02.000000000","message":"Although we create DataMotion just for this kind of end, you\u0027re right in avoiding creating an instance of DataMotion just for it. In several parts of the code it is doing it, but it has not been enclosed by function as you.\n\nAbout the name, suppose I am writing a code and I want to get the client for my host (or share server), how should I proceed ? I need to create another function called \"_get_client_for_my_end\" with the same code as yours. Naming like it, we have repeated coded. What do you think ?!\n\nI think that this function may be very useful, fixing it to \"svm_migrate\" might not be a good idea. In fact, there are several parts of the code doing it (the guys did not realize as you did that it could be a reusable function).\n\nLast point (sorry), this function is not using anything of the lib_multi_svm class. I think you could add this peace of code together with data_motion. As we have \"get_client_for_backend\" requiring the backend name. You could have there a \"get_client_for_host\" requiring a host. Note, fixing it to \"get_client_for_host\" can be used by share, share server or anything that has host.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1234,"context_line":"            raise exception.NetAppException(message\u003dmsg)"},{"line_number":1235,"context_line":"        return None"},{"line_number":1236,"context_line":""},{"line_number":1237,"context_line":"    def _get_client_for_svm_migrate(self, share_server_to_get_client):"},{"line_number":1238,"context_line":"        \"\"\"Returns a cluster client to perform migration actions.\"\"\""},{"line_number":1239,"context_line":"        backend_name \u003d share_utils.extract_host("},{"line_number":1240,"context_line":"            share_server_to_get_client[\u0027host\u0027], level\u003d\u0027backend_name\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"c247fcc9_9febd495","line":1237,"range":{"start_line":1237,"start_character":42,"end_line":1237,"end_character":68},"in_reply_to":"a52ccba4_3fc2d299","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1234,"context_line":"            raise exception.NetAppException(message\u003dmsg)"},{"line_number":1235,"context_line":"        return None"},{"line_number":1236,"context_line":""},{"line_number":1237,"context_line":"    def _get_client_for_svm_migrate(self, share_server_to_get_client):"},{"line_number":1238,"context_line":"        \"\"\"Returns a cluster client to perform migration actions.\"\"\""},{"line_number":1239,"context_line":"        backend_name \u003d share_utils.extract_host("},{"line_number":1240,"context_line":"            share_server_to_get_client[\u0027host\u0027], level\u003d\u0027backend_name\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7ac449e1_8c1de442","line":1237,"range":{"start_line":1237,"start_character":8,"end_line":1237,"end_character":35},"in_reply_to":"bf1da6e7_64c3b1d9","updated":"2021-08-28 21:57:50.000000000","message":"the get_client_and_vserver_name requires an instance of the DataMotion to be created and I do not have one. I\u0027d say renaming this should give a better idea of what is this method really about.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1250,"context_line":"        2. If a policy isn\u0027t available, create it"},{"line_number":1251,"context_line":"        \"\"\""},{"line_number":1252,"context_line":""},{"line_number":1253,"context_line":"        # 1. List the cluster policies"},{"line_number":1254,"context_line":"        cluster_vserver_name \u003d cluster_client.get_cluster_name()"},{"line_number":1255,"context_line":"        cluster_policy_types \u003d cluster_client.get_snapmirror_policies("},{"line_number":1256,"context_line":"            cluster_vserver_name, desired_attribute\u003d\u0027type\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"df40445b_d0d29245","line":1253,"range":{"start_line":1253,"start_character":30,"end_line":1253,"end_character":38},"updated":"2021-08-27 12:20:24.000000000","message":"policies.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1250,"context_line":"        2. If a policy isn\u0027t available, create it"},{"line_number":1251,"context_line":"        \"\"\""},{"line_number":1252,"context_line":""},{"line_number":1253,"context_line":"        # 1. List the cluster policies"},{"line_number":1254,"context_line":"        cluster_vserver_name \u003d cluster_client.get_cluster_name()"},{"line_number":1255,"context_line":"        cluster_policy_types \u003d cluster_client.get_snapmirror_policies("},{"line_number":1256,"context_line":"            cluster_vserver_name, desired_attribute\u003d\u0027type\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"c0e0415f_2ce96d5d","line":1253,"range":{"start_line":1253,"start_character":30,"end_line":1253,"end_character":38},"in_reply_to":"df40445b_d0d29245","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1255,"context_line":"        cluster_policy_types \u003d cluster_client.get_snapmirror_policies("},{"line_number":1256,"context_line":"            cluster_vserver_name, desired_attribute\u003d\u0027type\u0027)"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"        type_migrate \u003d \u0027migrate\u0027"},{"line_number":1259,"context_line":""},{"line_number":1260,"context_line":"        # 2. If a policy isn\u0027t available, create it"},{"line_number":1261,"context_line":"        if type_migrate not in cluster_policy_types:"}],"source_content_type":"text/x-python","patch_set":10,"id":"afd974ea_b8ed6893","line":1258,"range":{"start_line":1258,"start_character":24,"end_line":1258,"end_character":31},"updated":"2021-08-27 12:20:24.000000000","message":"avoid hard coded string. Use the utils module for it.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1255,"context_line":"        cluster_policy_types \u003d cluster_client.get_snapmirror_policies("},{"line_number":1256,"context_line":"            cluster_vserver_name, desired_attribute\u003d\u0027type\u0027)"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"        type_migrate \u003d \u0027migrate\u0027"},{"line_number":1259,"context_line":""},{"line_number":1260,"context_line":"        # 2. If a policy isn\u0027t available, create it"},{"line_number":1261,"context_line":"        if type_migrate not in cluster_policy_types:"}],"source_content_type":"text/x-python","patch_set":10,"id":"5fe0d643_a637d612","line":1258,"range":{"start_line":1258,"start_character":24,"end_line":1258,"end_character":31},"in_reply_to":"afd974ea_b8ed6893","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"        type_migrate \u003d \u0027migrate\u0027"},{"line_number":1259,"context_line":""},{"line_number":1260,"context_line":"        # 2. If a policy isn\u0027t available, create it"},{"line_number":1261,"context_line":"        if type_migrate not in cluster_policy_types:"},{"line_number":1262,"context_line":"            policy_name \u003d self._get_backend_snapmirror_policy_name_svm("},{"line_number":1263,"context_line":"                cluster_vserver_name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a5b08b3_2cb9c694","line":1260,"range":{"start_line":1260,"start_character":49,"end_line":1260,"end_character":51},"updated":"2021-08-27 12:20:24.000000000","message":"it.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"        type_migrate \u003d \u0027migrate\u0027"},{"line_number":1259,"context_line":""},{"line_number":1260,"context_line":"        # 2. If a policy isn\u0027t available, create it"},{"line_number":1261,"context_line":"        if type_migrate not in cluster_policy_types:"},{"line_number":1262,"context_line":"            policy_name \u003d self._get_backend_snapmirror_policy_name_svm("},{"line_number":1263,"context_line":"                cluster_vserver_name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5c00754b_4192b797","line":1260,"range":{"start_line":1260,"start_character":49,"end_line":1260,"end_character":51},"in_reply_to":"7a5b08b3_2cb9c694","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1280,"context_line":"        \"\"\""},{"line_number":1281,"context_line":""},{"line_number":1282,"context_line":"        # 1. Check if share network reusage is supported"},{"line_number":1283,"context_line":"        # NOTE(carloss): If share network was not changed, SVM migrate can"},{"line_number":1284,"context_line":"        # reuse the network allocation from the source share server, so as"},{"line_number":1285,"context_line":"        # Manila haven\u0027t made new allocations, we can just get allocation data"},{"line_number":1286,"context_line":"        # from the source share server"}],"source_content_type":"text/x-python","patch_set":10,"id":"d2a55cb0_c7842d8d","line":1283,"range":{"start_line":1283,"start_character":25,"end_line":1283,"end_character":28},"updated":"2021-08-27 12:20:24.000000000","message":"if","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1280,"context_line":"        \"\"\""},{"line_number":1281,"context_line":""},{"line_number":1282,"context_line":"        # 1. Check if share network reusage is supported"},{"line_number":1283,"context_line":"        # NOTE(carloss): If share network was not changed, SVM migrate can"},{"line_number":1284,"context_line":"        # reuse the network allocation from the source share server, so as"},{"line_number":1285,"context_line":"        # Manila haven\u0027t made new allocations, we can just get allocation data"},{"line_number":1286,"context_line":"        # from the source share server"}],"source_content_type":"text/x-python","patch_set":10,"id":"53cb6a11_c238fcbc","line":1283,"range":{"start_line":1283,"start_character":25,"end_line":1283,"end_character":28},"in_reply_to":"d2a55cb0_c7842d8d","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1283,"context_line":"        # NOTE(carloss): If share network was not changed, SVM migrate can"},{"line_number":1284,"context_line":"        # reuse the network allocation from the source share server, so as"},{"line_number":1285,"context_line":"        # Manila haven\u0027t made new allocations, we can just get allocation data"},{"line_number":1286,"context_line":"        # from the source share server"},{"line_number":1287,"context_line":"        if (source_share_server[\u0027share_network_subnet_id\u0027] \u003d\u003d"},{"line_number":1288,"context_line":"                dest_share_server[\u0027share_network_subnet_id\u0027]):"},{"line_number":1289,"context_line":"            share_server_to_get_network_info \u003d source_share_server"}],"source_content_type":"text/x-python","patch_set":10,"id":"cf7abff7_edb2cd21","line":1286,"range":{"start_line":1286,"start_character":32,"end_line":1286,"end_character":38},"updated":"2021-08-27 12:20:24.000000000","message":"server.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1283,"context_line":"        # NOTE(carloss): If share network was not changed, SVM migrate can"},{"line_number":1284,"context_line":"        # reuse the network allocation from the source share server, so as"},{"line_number":1285,"context_line":"        # Manila haven\u0027t made new allocations, we can just get allocation data"},{"line_number":1286,"context_line":"        # from the source share server"},{"line_number":1287,"context_line":"        if (source_share_server[\u0027share_network_subnet_id\u0027] \u003d\u003d"},{"line_number":1288,"context_line":"                dest_share_server[\u0027share_network_subnet_id\u0027]):"},{"line_number":1289,"context_line":"            share_server_to_get_network_info \u003d source_share_server"}],"source_content_type":"text/x-python","patch_set":10,"id":"edd76249_1bc3e3e7","line":1286,"range":{"start_line":1286,"start_character":32,"end_line":1286,"end_character":38},"in_reply_to":"cf7abff7_edb2cd21","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1290,"context_line":"        else:"},{"line_number":1291,"context_line":"            share_server_to_get_network_info \u003d dest_share_server"},{"line_number":1292,"context_line":""},{"line_number":1293,"context_line":"        # Reuse network information from the source share server in the svm"},{"line_number":1294,"context_line":"        # migrate if the there was no share network changes"},{"line_number":1295,"context_line":"        network_info \u003d {"},{"line_number":1296,"context_line":"            \u0027network_allocations\u0027:"}],"source_content_type":"text/x-python","patch_set":10,"id":"63e671b3_4562f1a6","line":1293,"range":{"start_line":1293,"start_character":72,"end_line":1293,"end_character":75},"updated":"2021-08-27 12:20:24.000000000","message":"SVM Migrate","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1290,"context_line":"        else:"},{"line_number":1291,"context_line":"            share_server_to_get_network_info \u003d dest_share_server"},{"line_number":1292,"context_line":""},{"line_number":1293,"context_line":"        # Reuse network information from the source share server in the svm"},{"line_number":1294,"context_line":"        # migrate if the there was no share network changes"},{"line_number":1295,"context_line":"        network_info \u003d {"},{"line_number":1296,"context_line":"            \u0027network_allocations\u0027:"}],"source_content_type":"text/x-python","patch_set":10,"id":"6af9c314_35d3e18b","line":1293,"range":{"start_line":1293,"start_character":72,"end_line":1293,"end_character":75},"in_reply_to":"63e671b3_4562f1a6","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1291,"context_line":"            share_server_to_get_network_info \u003d dest_share_server"},{"line_number":1292,"context_line":""},{"line_number":1293,"context_line":"        # Reuse network information from the source share server in the svm"},{"line_number":1294,"context_line":"        # migrate if the there was no share network changes"},{"line_number":1295,"context_line":"        network_info \u003d {"},{"line_number":1296,"context_line":"            \u0027network_allocations\u0027:"},{"line_number":1297,"context_line":"                share_server_to_get_network_info[\u0027network_allocations\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"1263be65_b141d8e7","line":1294,"range":{"start_line":1294,"start_character":52,"end_line":1294,"end_character":59},"updated":"2021-08-27 12:20:24.000000000","message":"changes.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1291,"context_line":"            share_server_to_get_network_info \u003d dest_share_server"},{"line_number":1292,"context_line":""},{"line_number":1293,"context_line":"        # Reuse network information from the source share server in the svm"},{"line_number":1294,"context_line":"        # migrate if the there was no share network changes"},{"line_number":1295,"context_line":"        network_info \u003d {"},{"line_number":1296,"context_line":"            \u0027network_allocations\u0027:"},{"line_number":1297,"context_line":"                share_server_to_get_network_info[\u0027network_allocations\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"89455f97_b27c1108","line":1294,"range":{"start_line":1294,"start_character":52,"end_line":1294,"end_character":59},"in_reply_to":"1263be65_b141d8e7","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1300,"context_line":"                    \u0027neutron_subnet_id\u0027)"},{"line_number":1301,"context_line":"        }"},{"line_number":1302,"context_line":""},{"line_number":1303,"context_line":"        # 2. Create new ipspace, port and broadcast domain"},{"line_number":1304,"context_line":"        node_name \u003d self._client.list_cluster_nodes()[0]"},{"line_number":1305,"context_line":"        port \u003d self._get_node_data_port(node_name)"},{"line_number":1306,"context_line":"        vlan \u003d network_info[\u0027network_allocations\u0027][0][\u0027segmentation_id\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"a8aa87b6_64feb132","line":1303,"range":{"start_line":1303,"start_character":52,"end_line":1303,"end_character":58},"updated":"2021-08-27 12:20:24.000000000","message":"domain.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1300,"context_line":"                    \u0027neutron_subnet_id\u0027)"},{"line_number":1301,"context_line":"        }"},{"line_number":1302,"context_line":""},{"line_number":1303,"context_line":"        # 2. Create new ipspace, port and broadcast domain"},{"line_number":1304,"context_line":"        node_name \u003d self._client.list_cluster_nodes()[0]"},{"line_number":1305,"context_line":"        port \u003d self._get_node_data_port(node_name)"},{"line_number":1306,"context_line":"        vlan \u003d network_info[\u0027network_allocations\u0027][0][\u0027segmentation_id\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"e691b81d_d4ae89a4","line":1303,"range":{"start_line":1303,"start_character":52,"end_line":1303,"end_character":58},"in_reply_to":"a8aa87b6_64feb132","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1311,"context_line":"            destination_ipspace, network_info)"},{"line_number":1312,"context_line":""},{"line_number":1313,"context_line":"        # 3. Ensure source and destination clusters contain a snapmirror policy"},{"line_number":1314,"context_line":"        # with \u0027migrate\u0027 type"},{"line_number":1315,"context_line":"        self._ensure_cluster_has_migrate_policy(src_client)"},{"line_number":1316,"context_line":"        self._ensure_cluster_has_migrate_policy(dest_client)"},{"line_number":1317,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"14478985_afd8599c","line":1314,"range":{"start_line":1314,"start_character":25,"end_line":1314,"end_character":29},"updated":"2021-08-27 12:20:24.000000000","message":"type.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1311,"context_line":"            destination_ipspace, network_info)"},{"line_number":1312,"context_line":""},{"line_number":1313,"context_line":"        # 3. Ensure source and destination clusters contain a snapmirror policy"},{"line_number":1314,"context_line":"        # with \u0027migrate\u0027 type"},{"line_number":1315,"context_line":"        self._ensure_cluster_has_migrate_policy(src_client)"},{"line_number":1316,"context_line":"        self._ensure_cluster_has_migrate_policy(dest_client)"},{"line_number":1317,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"c4b78763_29f67b7c","line":1314,"range":{"start_line":1314,"start_character":25,"end_line":1314,"end_character":29},"in_reply_to":"14478985_afd8599c","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1316,"context_line":"        self._ensure_cluster_has_migrate_policy(dest_client)"},{"line_number":1317,"context_line":""},{"line_number":1318,"context_line":"        # TODO(carloss): remove this after the issue with the IPSPACE name"},{"line_number":1319,"context_line":"        #  gets solved"},{"line_number":1320,"context_line":"        ipspace \u003d dest_client.get_ipspaces(ipspace_name\u003ddestination_ipspace)"},{"line_number":1321,"context_line":""},{"line_number":1322,"context_line":"        # Prepare the migration request"}],"source_content_type":"text/x-python","patch_set":10,"id":"835e34ff_6fc6ae0d","line":1319,"range":{"start_line":1319,"start_character":16,"end_line":1319,"end_character":22},"updated":"2021-08-27 12:20:24.000000000","message":"solved.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1316,"context_line":"        self._ensure_cluster_has_migrate_policy(dest_client)"},{"line_number":1317,"context_line":""},{"line_number":1318,"context_line":"        # TODO(carloss): remove this after the issue with the IPSPACE name"},{"line_number":1319,"context_line":"        #  gets solved"},{"line_number":1320,"context_line":"        ipspace \u003d dest_client.get_ipspaces(ipspace_name\u003ddestination_ipspace)"},{"line_number":1321,"context_line":""},{"line_number":1322,"context_line":"        # Prepare the migration request"}],"source_content_type":"text/x-python","patch_set":10,"id":"53677852_82fb18b4","line":1319,"range":{"start_line":1319,"start_character":16,"end_line":1319,"end_character":22},"in_reply_to":"835e34ff_6fc6ae0d","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1319,"context_line":"        #  gets solved"},{"line_number":1320,"context_line":"        ipspace \u003d dest_client.get_ipspaces(ipspace_name\u003ddestination_ipspace)"},{"line_number":1321,"context_line":""},{"line_number":1322,"context_line":"        # Prepare the migration request"},{"line_number":1323,"context_line":"        src_cluster_name \u003d src_client.get_cluster_name()"},{"line_number":1324,"context_line":"        source_share_server_name \u003d self._get_vserver_name("},{"line_number":1325,"context_line":"            source_share_server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"e8a33fc3_ff7ce119","line":1322,"range":{"start_line":1322,"start_character":32,"end_line":1322,"end_character":39},"updated":"2021-08-27 12:20:24.000000000","message":"request.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1319,"context_line":"        #  gets solved"},{"line_number":1320,"context_line":"        ipspace \u003d dest_client.get_ipspaces(ipspace_name\u003ddestination_ipspace)"},{"line_number":1321,"context_line":""},{"line_number":1322,"context_line":"        # Prepare the migration request"},{"line_number":1323,"context_line":"        src_cluster_name \u003d src_client.get_cluster_name()"},{"line_number":1324,"context_line":"        source_share_server_name \u003d self._get_vserver_name("},{"line_number":1325,"context_line":"            source_share_server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"567b2753_2d96d08d","line":1322,"range":{"start_line":1322,"start_character":32,"end_line":1322,"end_character":39},"in_reply_to":"e8a33fc3_ff7ce119","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1324,"context_line":"        source_share_server_name \u003d self._get_vserver_name("},{"line_number":1325,"context_line":"            source_share_server[\u0027id\u0027])"},{"line_number":1326,"context_line":""},{"line_number":1327,"context_line":"        # 4. Send the migration request to ONTAP"},{"line_number":1328,"context_line":"        try:"},{"line_number":1329,"context_line":"            result \u003d dest_client.svm_migration_start("},{"line_number":1330,"context_line":"                src_cluster_name, source_share_server_name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"4919f131_182b88d1","line":1327,"range":{"start_line":1327,"start_character":43,"end_line":1327,"end_character":48},"updated":"2021-08-27 12:20:24.000000000","message":"ONTAP.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1324,"context_line":"        source_share_server_name \u003d self._get_vserver_name("},{"line_number":1325,"context_line":"            source_share_server[\u0027id\u0027])"},{"line_number":1326,"context_line":""},{"line_number":1327,"context_line":"        # 4. Send the migration request to ONTAP"},{"line_number":1328,"context_line":"        try:"},{"line_number":1329,"context_line":"            result \u003d dest_client.svm_migration_start("},{"line_number":1330,"context_line":"                src_cluster_name, source_share_server_name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"62c9417e_04948589","line":1327,"range":{"start_line":1327,"start_character":43,"end_line":1327,"end_character":48},"in_reply_to":"4919f131_182b88d1","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1332,"context_line":"                dest_ipspace\u003dipspace[0][\u0027uuid\u0027],"},{"line_number":1333,"context_line":"                auto_source_cleanup\u003dcleanup_source_server)"},{"line_number":1334,"context_line":""},{"line_number":1335,"context_line":"            # 5. Read the job id and get the id of the migration"},{"line_number":1336,"context_line":"            result_job \u003d result.get(\"job\")"},{"line_number":1337,"context_line":"            job_details \u003d dest_client.get_job(result_job.get(\"uuid\"))"},{"line_number":1338,"context_line":"            job_description \u003d job_details.get(\u0027description\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"e09aeb11_c60ef663","line":1335,"range":{"start_line":1335,"start_character":55,"end_line":1335,"end_character":64},"updated":"2021-08-27 12:20:24.000000000","message":"migration.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1332,"context_line":"                dest_ipspace\u003dipspace[0][\u0027uuid\u0027],"},{"line_number":1333,"context_line":"                auto_source_cleanup\u003dcleanup_source_server)"},{"line_number":1334,"context_line":""},{"line_number":1335,"context_line":"            # 5. Read the job id and get the id of the migration"},{"line_number":1336,"context_line":"            result_job \u003d result.get(\"job\")"},{"line_number":1337,"context_line":"            job_details \u003d dest_client.get_job(result_job.get(\"uuid\"))"},{"line_number":1338,"context_line":"            job_description \u003d job_details.get(\u0027description\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"e4f3f38c_f0836444","line":1335,"range":{"start_line":1335,"start_character":55,"end_line":1335,"end_character":64},"in_reply_to":"e09aeb11_c60ef663","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1333,"context_line":"                auto_source_cleanup\u003dcleanup_source_server)"},{"line_number":1334,"context_line":""},{"line_number":1335,"context_line":"            # 5. Read the job id and get the id of the migration"},{"line_number":1336,"context_line":"            result_job \u003d result.get(\"job\")"},{"line_number":1337,"context_line":"            job_details \u003d dest_client.get_job(result_job.get(\"uuid\"))"},{"line_number":1338,"context_line":"            job_description \u003d job_details.get(\u0027description\u0027)"},{"line_number":1339,"context_line":"            migration_uuid \u003d job_description.split(\u0027/\u0027)[-1]"}],"source_content_type":"text/x-python","patch_set":10,"id":"f6b34832_aa850a2f","line":1336,"range":{"start_line":1336,"start_character":33,"end_line":1336,"end_character":42},"updated":"2021-08-27 12:20:24.000000000","message":"result job will be used as dict: get(\"job\", {})","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1333,"context_line":"                auto_source_cleanup\u003dcleanup_source_server)"},{"line_number":1334,"context_line":""},{"line_number":1335,"context_line":"            # 5. Read the job id and get the id of the migration"},{"line_number":1336,"context_line":"            result_job \u003d result.get(\"job\")"},{"line_number":1337,"context_line":"            job_details \u003d dest_client.get_job(result_job.get(\"uuid\"))"},{"line_number":1338,"context_line":"            job_description \u003d job_details.get(\u0027description\u0027)"},{"line_number":1339,"context_line":"            migration_uuid \u003d job_description.split(\u0027/\u0027)[-1]"}],"source_content_type":"text/x-python","patch_set":10,"id":"bf05b241_a1f2bef0","line":1336,"range":{"start_line":1336,"start_character":33,"end_line":1336,"end_character":42},"in_reply_to":"f6b34832_aa850a2f","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1339,"context_line":"            migration_uuid \u003d job_description.split(\u0027/\u0027)[-1]"},{"line_number":1340,"context_line":"        except Exception:"},{"line_number":1341,"context_line":"            # As it failed, we must remove the ipspace, ports and broadcast"},{"line_number":1342,"context_line":"            # domain"},{"line_number":1343,"context_line":"            dest_client.delete_ipspace(destination_ipspace)"},{"line_number":1344,"context_line":""},{"line_number":1345,"context_line":"            msg \u003d _(\"Unable to start the migration for share server %s.\""}],"source_content_type":"text/x-python","patch_set":10,"id":"f49a851e_ea9ff95c","line":1342,"range":{"start_line":1342,"start_character":14,"end_line":1342,"end_character":20},"updated":"2021-08-27 12:20:24.000000000","message":"domain.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1339,"context_line":"            migration_uuid \u003d job_description.split(\u0027/\u0027)[-1]"},{"line_number":1340,"context_line":"        except Exception:"},{"line_number":1341,"context_line":"            # As it failed, we must remove the ipspace, ports and broadcast"},{"line_number":1342,"context_line":"            # domain"},{"line_number":1343,"context_line":"            dest_client.delete_ipspace(destination_ipspace)"},{"line_number":1344,"context_line":""},{"line_number":1345,"context_line":"            msg \u003d _(\"Unable to start the migration for share server %s.\""}],"source_content_type":"text/x-python","patch_set":10,"id":"18161112_ba588a36","line":1342,"range":{"start_line":1342,"start_character":14,"end_line":1342,"end_character":20},"in_reply_to":"f49a851e_ea9ff95c","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1346,"context_line":"                    % source_share_server[\u0027id\u0027])"},{"line_number":1347,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":"        # 6. Returns migration data to be saved as backend details"},{"line_number":1350,"context_line":"        server_info \u003d {"},{"line_number":1351,"context_line":"            \"backend_details\": {"},{"line_number":1352,"context_line":"                \"migration_operation_id\": migration_uuid"}],"source_content_type":"text/x-python","patch_set":10,"id":"e22309bb_5506d43e","line":1349,"range":{"start_line":1349,"start_character":59,"end_line":1349,"end_character":66},"updated":"2021-08-27 12:20:24.000000000","message":"details.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1346,"context_line":"                    % source_share_server[\u0027id\u0027])"},{"line_number":1347,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":"        # 6. Returns migration data to be saved as backend details"},{"line_number":1350,"context_line":"        server_info \u003d {"},{"line_number":1351,"context_line":"            \"backend_details\": {"},{"line_number":1352,"context_line":"                \"migration_operation_id\": migration_uuid"}],"source_content_type":"text/x-python","patch_set":10,"id":"32798084_4fe1a2b1","line":1349,"range":{"start_line":1349,"start_character":59,"end_line":1349,"end_character":66},"in_reply_to":"e22309bb_5506d43e","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1349,"context_line":"        # 6. Returns migration data to be saved as backend details"},{"line_number":1350,"context_line":"        server_info \u003d {"},{"line_number":1351,"context_line":"            \"backend_details\": {"},{"line_number":1352,"context_line":"                \"migration_operation_id\": migration_uuid"},{"line_number":1353,"context_line":"            }"},{"line_number":1354,"context_line":"        }"},{"line_number":1355,"context_line":"        return server_info"}],"source_content_type":"text/x-python","patch_set":10,"id":"1d386bc8_dcc5cda9","line":1352,"range":{"start_line":1352,"start_character":17,"end_line":1352,"end_character":39},"updated":"2021-08-27 12:20:24.000000000","message":"hard coded.. use could used the same source of truth with utils:\n\nutils.MIGRATION_ID_KEY_NAME","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1349,"context_line":"        # 6. Returns migration data to be saved as backend details"},{"line_number":1350,"context_line":"        server_info \u003d {"},{"line_number":1351,"context_line":"            \"backend_details\": {"},{"line_number":1352,"context_line":"                \"migration_operation_id\": migration_uuid"},{"line_number":1353,"context_line":"            }"},{"line_number":1354,"context_line":"        }"},{"line_number":1355,"context_line":"        return server_info"}],"source_content_type":"text/x-python","patch_set":10,"id":"8efeb144_deab2e41","line":1352,"range":{"start_line":1352,"start_character":17,"end_line":1352,"end_character":39},"in_reply_to":"1d386bc8_dcc5cda9","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1388,"context_line":"            \u0027src\u0027: source_share_server[\u0027id\u0027],"},{"line_number":1389,"context_line":"            \u0027dest\u0027: dest_share_server[\u0027id\u0027],"},{"line_number":1390,"context_line":"        }"},{"line_number":1391,"context_line":"        msg \u003d _(\u0027Starting share server migration from %(src)s to %(dest)s.\u0027)"},{"line_number":1392,"context_line":"        LOG.info(msg, msg_args)"},{"line_number":1393,"context_line":""},{"line_number":1394,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":10,"id":"cf7aa20b_5c8868e9","line":1391,"range":{"start_line":1391,"start_character":17,"end_line":1391,"end_character":76},"updated":"2021-08-27 12:20:24.000000000","message":"Please, add to log informing the method used for migrating.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1388,"context_line":"            \u0027src\u0027: source_share_server[\u0027id\u0027],"},{"line_number":1389,"context_line":"            \u0027dest\u0027: dest_share_server[\u0027id\u0027],"},{"line_number":1390,"context_line":"        }"},{"line_number":1391,"context_line":"        msg \u003d _(\u0027Starting share server migration from %(src)s to %(dest)s.\u0027)"},{"line_number":1392,"context_line":"        LOG.info(msg, msg_args)"},{"line_number":1393,"context_line":""},{"line_number":1394,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":10,"id":"d57c2b96_9a7483ea","line":1391,"range":{"start_line":1391,"start_character":17,"end_line":1391,"end_character":76},"in_reply_to":"cf7aa20b_5c8868e9","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1447,"context_line":"        return False"},{"line_number":1448,"context_line":""},{"line_number":1449,"context_line":"    @na_utils.trace"},{"line_number":1450,"context_line":"    def _share_server_migration_continue_svm_migrate(self, dest_share_server,"},{"line_number":1451,"context_line":"                                                     migration_id):"},{"line_number":1452,"context_line":"        dest_client \u003d self._get_client_for_svm_migrate(dest_share_server)"},{"line_number":1453,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"c433e350_4836a851","line":1450,"range":{"start_line":1450,"start_character":8,"end_line":1450,"end_character":52},"updated":"2021-08-27 12:20:24.000000000","message":"add documentation","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1447,"context_line":"        return False"},{"line_number":1448,"context_line":""},{"line_number":1449,"context_line":"    @na_utils.trace"},{"line_number":1450,"context_line":"    def _share_server_migration_continue_svm_migrate(self, dest_share_server,"},{"line_number":1451,"context_line":"                                                     migration_id):"},{"line_number":1452,"context_line":"        dest_client \u003d self._get_client_for_svm_migrate(dest_share_server)"},{"line_number":1453,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"166be80b_4ee24699","line":1450,"range":{"start_line":1450,"start_character":8,"end_line":1450,"end_character":52},"in_reply_to":"c433e350_4836a851","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1459,"context_line":"                          \u0027reason\u0027: e.message}"},{"line_number":1460,"context_line":"                   )"},{"line_number":1461,"context_line":"            raise exception.NetAppException(message\u003dmsg)"},{"line_number":1462,"context_line":"        return result.get(\"state\") \u003d\u003d \u0027ready_for_cutover\u0027"},{"line_number":1463,"context_line":""},{"line_number":1464,"context_line":"    @na_utils.trace"},{"line_number":1465,"context_line":"    def share_server_migration_continue(self, context, source_share_server,"}],"source_content_type":"text/x-python","patch_set":10,"id":"0d385ec5_c822f24d","line":1462,"range":{"start_line":1462,"start_character":39,"end_line":1462,"end_character":56},"updated":"2021-08-27 12:20:24.000000000","message":"same about hard coded status string","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1459,"context_line":"                          \u0027reason\u0027: e.message}"},{"line_number":1460,"context_line":"                   )"},{"line_number":1461,"context_line":"            raise exception.NetAppException(message\u003dmsg)"},{"line_number":1462,"context_line":"        return result.get(\"state\") \u003d\u003d \u0027ready_for_cutover\u0027"},{"line_number":1463,"context_line":""},{"line_number":1464,"context_line":"    @na_utils.trace"},{"line_number":1465,"context_line":"    def share_server_migration_continue(self, context, source_share_server,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a20429e_cd44c390","line":1462,"range":{"start_line":1462,"start_character":39,"end_line":1462,"end_character":56},"in_reply_to":"0d385ec5_c822f24d","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1462,"context_line":"        return result.get(\"state\") \u003d\u003d \u0027ready_for_cutover\u0027"},{"line_number":1463,"context_line":""},{"line_number":1464,"context_line":"    @na_utils.trace"},{"line_number":1465,"context_line":"    def share_server_migration_continue(self, context, source_share_server,"},{"line_number":1466,"context_line":"                                        dest_share_server, share_instances,"},{"line_number":1467,"context_line":"                                        snapshot_instances):"},{"line_number":1468,"context_line":"        # If the migration operation was started using SVM migrate, it"}],"source_content_type":"text/x-python","patch_set":10,"id":"0adac263_fe6ab98b","line":1465,"range":{"start_line":1465,"start_character":8,"end_line":1465,"end_character":39},"updated":"2021-08-27 12:20:24.000000000","message":"add documentation","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1462,"context_line":"        return result.get(\"state\") \u003d\u003d \u0027ready_for_cutover\u0027"},{"line_number":1463,"context_line":""},{"line_number":1464,"context_line":"    @na_utils.trace"},{"line_number":1465,"context_line":"    def share_server_migration_continue(self, context, source_share_server,"},{"line_number":1466,"context_line":"                                        dest_share_server, share_instances,"},{"line_number":1467,"context_line":"                                        snapshot_instances):"},{"line_number":1468,"context_line":"        # If the migration operation was started using SVM migrate, it"}],"source_content_type":"text/x-python","patch_set":10,"id":"d297f173_75f9bebc","line":1465,"range":{"start_line":1465,"start_character":8,"end_line":1465,"end_character":39},"in_reply_to":"0adac263_fe6ab98b","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1466,"context_line":"                                        dest_share_server, share_instances,"},{"line_number":1467,"context_line":"                                        snapshot_instances):"},{"line_number":1468,"context_line":"        # If the migration operation was started using SVM migrate, it"},{"line_number":1469,"context_line":"        # returned a migration ID to get information about the job afterwards"},{"line_number":1470,"context_line":"        migration_id \u003d self._get_share_server_migration_id("},{"line_number":1471,"context_line":"            dest_share_server)"},{"line_number":1472,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"31cec4c7_ffd44ae8","line":1469,"range":{"start_line":1469,"start_character":67,"end_line":1469,"end_character":77},"updated":"2021-08-27 12:20:24.000000000","message":"afterwards.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1466,"context_line":"                                        dest_share_server, share_instances,"},{"line_number":1467,"context_line":"                                        snapshot_instances):"},{"line_number":1468,"context_line":"        # If the migration operation was started using SVM migrate, it"},{"line_number":1469,"context_line":"        # returned a migration ID to get information about the job afterwards"},{"line_number":1470,"context_line":"        migration_id \u003d self._get_share_server_migration_id("},{"line_number":1471,"context_line":"            dest_share_server)"},{"line_number":1472,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"abd7e9d7_036647c1","line":1469,"range":{"start_line":1469,"start_character":67,"end_line":1469,"end_character":77},"in_reply_to":"31cec4c7_ffd44ae8","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1470,"context_line":"        migration_id \u003d self._get_share_server_migration_id("},{"line_number":1471,"context_line":"            dest_share_server)"},{"line_number":1472,"context_line":""},{"line_number":1473,"context_line":"        # Checks the progress for a SVM migrate migration"},{"line_number":1474,"context_line":"        if migration_id:"},{"line_number":1475,"context_line":"            return self._share_server_migration_continue_svm_migrate("},{"line_number":1476,"context_line":"                dest_share_server, migration_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"40efb2c4_42c70e8b","line":1473,"range":{"start_line":1473,"start_character":48,"end_line":1473,"end_character":57},"updated":"2021-08-27 12:20:24.000000000","message":"migration.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1470,"context_line":"        migration_id \u003d self._get_share_server_migration_id("},{"line_number":1471,"context_line":"            dest_share_server)"},{"line_number":1472,"context_line":""},{"line_number":1473,"context_line":"        # Checks the progress for a SVM migrate migration"},{"line_number":1474,"context_line":"        if migration_id:"},{"line_number":1475,"context_line":"            return self._share_server_migration_continue_svm_migrate("},{"line_number":1476,"context_line":"                dest_share_server, migration_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"cb501b6e_c2e5fed5","line":1473,"range":{"start_line":1473,"start_character":48,"end_line":1473,"end_character":57},"in_reply_to":"40efb2c4_42c70e8b","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1475,"context_line":"            return self._share_server_migration_continue_svm_migrate("},{"line_number":1476,"context_line":"                dest_share_server, migration_id)"},{"line_number":1477,"context_line":""},{"line_number":1478,"context_line":"        # Checks the progress of a SVM DR Migration"},{"line_number":1479,"context_line":"        return self._share_server_migration_continue_svm_dr("},{"line_number":1480,"context_line":"            source_share_server, dest_share_server)"},{"line_number":1481,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"588ce6ac_66587f72","line":1478,"range":{"start_line":1478,"start_character":42,"end_line":1478,"end_character":51},"updated":"2021-08-27 12:20:24.000000000","message":"migration.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1475,"context_line":"            return self._share_server_migration_continue_svm_migrate("},{"line_number":1476,"context_line":"                dest_share_server, migration_id)"},{"line_number":1477,"context_line":""},{"line_number":1478,"context_line":"        # Checks the progress of a SVM DR Migration"},{"line_number":1479,"context_line":"        return self._share_server_migration_continue_svm_dr("},{"line_number":1480,"context_line":"            source_share_server, dest_share_server)"},{"line_number":1481,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5fdc24f4_41e1a04c","line":1478,"range":{"start_line":1478,"start_character":42,"end_line":1478,"end_character":51},"in_reply_to":"588ce6ac_66587f72","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1479,"context_line":"        return self._share_server_migration_continue_svm_dr("},{"line_number":1480,"context_line":"            source_share_server, dest_share_server)"},{"line_number":1481,"context_line":""},{"line_number":1482,"context_line":"    def _share_server_migration_complete_svm_dr("},{"line_number":1483,"context_line":"            self, source_share_server, dest_share_server, src_vserver,"},{"line_number":1484,"context_line":"            src_client, share_instances, new_net_allocations):"},{"line_number":1485,"context_line":"        \"\"\"Perform steps to complete the SVM DR migration."}],"source_content_type":"text/x-python","patch_set":10,"id":"db9e072c_424876cb","line":1482,"range":{"start_line":1482,"start_character":8,"end_line":1482,"end_character":47},"updated":"2021-08-27 12:20:24.000000000","message":"@na_utils.trace","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1479,"context_line":"        return self._share_server_migration_continue_svm_dr("},{"line_number":1480,"context_line":"            source_share_server, dest_share_server)"},{"line_number":1481,"context_line":""},{"line_number":1482,"context_line":"    def _share_server_migration_complete_svm_dr("},{"line_number":1483,"context_line":"            self, source_share_server, dest_share_server, src_vserver,"},{"line_number":1484,"context_line":"            src_client, share_instances, new_net_allocations):"},{"line_number":1485,"context_line":"        \"\"\"Perform steps to complete the SVM DR migration."}],"source_content_type":"text/x-python","patch_set":10,"id":"8dbbea4f_7350af18","line":1482,"range":{"start_line":1482,"start_character":8,"end_line":1482,"end_character":47},"in_reply_to":"db9e072c_424876cb","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1570,"context_line":"        dm_session.delete_snapmirror_svm(source_share_server,"},{"line_number":1571,"context_line":"                                         dest_share_server)"},{"line_number":1572,"context_line":""},{"line_number":1573,"context_line":"    def _share_server_migration_complete_svm_migrate("},{"line_number":1574,"context_line":"            self, migration_id, dest_share_server):"},{"line_number":1575,"context_line":"        \"\"\"Completes share server migration using SVM DR."},{"line_number":1576,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"84d6fcd0_a6a1f2ca","line":1573,"range":{"start_line":1573,"start_character":8,"end_line":1573,"end_character":52},"updated":"2021-08-27 12:20:24.000000000","message":"@na_utils.trace","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1570,"context_line":"        dm_session.delete_snapmirror_svm(source_share_server,"},{"line_number":1571,"context_line":"                                         dest_share_server)"},{"line_number":1572,"context_line":""},{"line_number":1573,"context_line":"    def _share_server_migration_complete_svm_migrate("},{"line_number":1574,"context_line":"            self, migration_id, dest_share_server):"},{"line_number":1575,"context_line":"        \"\"\"Completes share server migration using SVM DR."},{"line_number":1576,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bebd325a_17a4f989","line":1573,"range":{"start_line":1573,"start_character":8,"end_line":1573,"end_character":52},"in_reply_to":"84d6fcd0_a6a1f2ca","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1572,"context_line":""},{"line_number":1573,"context_line":"    def _share_server_migration_complete_svm_migrate("},{"line_number":1574,"context_line":"            self, migration_id, dest_share_server):"},{"line_number":1575,"context_line":"        \"\"\"Completes share server migration using SVM DR."},{"line_number":1576,"context_line":""},{"line_number":1577,"context_line":"        1. Call functions to conclude the migration for SVM Migrate"},{"line_number":1578,"context_line":"        2. Waits until the job gets a success status"}],"source_content_type":"text/x-python","patch_set":10,"id":"c3c4165f_b7633922","line":1575,"range":{"start_line":1575,"start_character":50,"end_line":1575,"end_character":57},"updated":"2021-08-27 12:20:24.000000000","message":"SVM Migrate","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1572,"context_line":""},{"line_number":1573,"context_line":"    def _share_server_migration_complete_svm_migrate("},{"line_number":1574,"context_line":"            self, migration_id, dest_share_server):"},{"line_number":1575,"context_line":"        \"\"\"Completes share server migration using SVM DR."},{"line_number":1576,"context_line":""},{"line_number":1577,"context_line":"        1. Call functions to conclude the migration for SVM Migrate"},{"line_number":1578,"context_line":"        2. Waits until the job gets a success status"}],"source_content_type":"text/x-python","patch_set":10,"id":"4c575923_75aaf696","line":1575,"range":{"start_line":1575,"start_character":50,"end_line":1575,"end_character":57},"in_reply_to":"c3c4165f_b7633922","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1581,"context_line":"        dest_client \u003d self._get_client_for_svm_migrate(dest_share_server)"},{"line_number":1582,"context_line":"        ongoing_migration \u003d dest_client.svm_migration_get(migration_id)"},{"line_number":1583,"context_line":"        completion_status \u003d ("},{"line_number":1584,"context_line":"            \"ready_for_source_cleanup\""},{"line_number":1585,"context_line":"            if ongoing_migration.get(\"auto_source_cleanup\") is False"},{"line_number":1586,"context_line":"            else \"migrate_complete\")"},{"line_number":1587,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"f1afb5e6_e72cf427","line":1584,"range":{"start_line":1584,"start_character":13,"end_line":1584,"end_character":37},"updated":"2021-08-27 12:20:24.000000000","message":"please, avoid to hard code string status here, use utils for it.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1581,"context_line":"        dest_client \u003d self._get_client_for_svm_migrate(dest_share_server)"},{"line_number":1582,"context_line":"        ongoing_migration \u003d dest_client.svm_migration_get(migration_id)"},{"line_number":1583,"context_line":"        completion_status \u003d ("},{"line_number":1584,"context_line":"            \"ready_for_source_cleanup\""},{"line_number":1585,"context_line":"            if ongoing_migration.get(\"auto_source_cleanup\") is False"},{"line_number":1586,"context_line":"            else \"migrate_complete\")"},{"line_number":1587,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5f9a50cb_4ea9ba6d","line":1584,"range":{"start_line":1584,"start_character":13,"end_line":1584,"end_character":37},"in_reply_to":"f1afb5e6_e72cf427","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1583,"context_line":"        completion_status \u003d ("},{"line_number":1584,"context_line":"            \"ready_for_source_cleanup\""},{"line_number":1585,"context_line":"            if ongoing_migration.get(\"auto_source_cleanup\") is False"},{"line_number":1586,"context_line":"            else \"migrate_complete\")"},{"line_number":1587,"context_line":""},{"line_number":1588,"context_line":"        try:"},{"line_number":1589,"context_line":"            # Triggers the migration completion"}],"source_content_type":"text/x-python","patch_set":10,"id":"e2f215d2_8ce2f348","line":1586,"range":{"start_line":1586,"start_character":18,"end_line":1586,"end_character":34},"updated":"2021-08-27 12:20:24.000000000","message":"same about hard coded string","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1583,"context_line":"        completion_status \u003d ("},{"line_number":1584,"context_line":"            \"ready_for_source_cleanup\""},{"line_number":1585,"context_line":"            if ongoing_migration.get(\"auto_source_cleanup\") is False"},{"line_number":1586,"context_line":"            else \"migrate_complete\")"},{"line_number":1587,"context_line":""},{"line_number":1588,"context_line":"        try:"},{"line_number":1589,"context_line":"            # Triggers the migration completion"}],"source_content_type":"text/x-python","patch_set":10,"id":"995065db_2c9d7781","line":1586,"range":{"start_line":1586,"start_character":18,"end_line":1586,"end_character":34},"in_reply_to":"e2f215d2_8ce2f348","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1586,"context_line":"            else \"migrate_complete\")"},{"line_number":1587,"context_line":""},{"line_number":1588,"context_line":"        try:"},{"line_number":1589,"context_line":"            # Triggers the migration completion"},{"line_number":1590,"context_line":"            job \u003d dest_client.svm_migrate_complete(migration_id)"},{"line_number":1591,"context_line":"            job_id \u003d self._get_job_uuid(job)"},{"line_number":1592,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"c6e97499_2b66b6e5","line":1589,"range":{"start_line":1589,"start_character":37,"end_line":1589,"end_character":47},"updated":"2021-08-27 12:20:24.000000000","message":"completion.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1586,"context_line":"            else \"migrate_complete\")"},{"line_number":1587,"context_line":""},{"line_number":1588,"context_line":"        try:"},{"line_number":1589,"context_line":"            # Triggers the migration completion"},{"line_number":1590,"context_line":"            job \u003d dest_client.svm_migrate_complete(migration_id)"},{"line_number":1591,"context_line":"            job_id \u003d self._get_job_uuid(job)"},{"line_number":1592,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7515a714_070f55b9","line":1589,"range":{"start_line":1589,"start_character":37,"end_line":1589,"end_character":47},"in_reply_to":"c6e97499_2b66b6e5","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1590,"context_line":"            job \u003d dest_client.svm_migrate_complete(migration_id)"},{"line_number":1591,"context_line":"            job_id \u003d self._get_job_uuid(job)"},{"line_number":1592,"context_line":""},{"line_number":1593,"context_line":"            # Wait until the job is successful"},{"line_number":1594,"context_line":"            self._wait_for_operation_status("},{"line_number":1595,"context_line":"                job_id, dest_client.get_job)"},{"line_number":1596,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fc328bee_6a11b196","line":1593,"range":{"start_line":1593,"start_character":36,"end_line":1593,"end_character":46},"updated":"2021-08-27 12:20:24.000000000","message":"successful.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1590,"context_line":"            job \u003d dest_client.svm_migrate_complete(migration_id)"},{"line_number":1591,"context_line":"            job_id \u003d self._get_job_uuid(job)"},{"line_number":1592,"context_line":""},{"line_number":1593,"context_line":"            # Wait until the job is successful"},{"line_number":1594,"context_line":"            self._wait_for_operation_status("},{"line_number":1595,"context_line":"                job_id, dest_client.get_job)"},{"line_number":1596,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"b069f54b_864311b1","line":1593,"range":{"start_line":1593,"start_character":36,"end_line":1593,"end_character":46},"in_reply_to":"fc328bee_6a11b196","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1594,"context_line":"            self._wait_for_operation_status("},{"line_number":1595,"context_line":"                job_id, dest_client.get_job)"},{"line_number":1596,"context_line":""},{"line_number":1597,"context_line":"            # Wait until the migration is entirely finished"},{"line_number":1598,"context_line":"            self._wait_for_operation_status("},{"line_number":1599,"context_line":"                migration_id, dest_client.svm_migration_get,"},{"line_number":1600,"context_line":"                desired_status\u003dcompletion_status)"}],"source_content_type":"text/x-python","patch_set":10,"id":"e80d671d_0075d9f5","line":1597,"range":{"start_line":1597,"start_character":51,"end_line":1597,"end_character":59},"updated":"2021-08-27 12:20:24.000000000","message":"finished.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1594,"context_line":"            self._wait_for_operation_status("},{"line_number":1595,"context_line":"                job_id, dest_client.get_job)"},{"line_number":1596,"context_line":""},{"line_number":1597,"context_line":"            # Wait until the migration is entirely finished"},{"line_number":1598,"context_line":"            self._wait_for_operation_status("},{"line_number":1599,"context_line":"                migration_id, dest_client.svm_migration_get,"},{"line_number":1600,"context_line":"                desired_status\u003dcompletion_status)"}],"source_content_type":"text/x-python","patch_set":10,"id":"f2ed4466_5971f528","line":1597,"range":{"start_line":1597,"start_character":51,"end_line":1597,"end_character":59},"in_reply_to":"e80d671d_0075d9f5","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1601,"context_line":"        except exception.NetAppException:"},{"line_number":1602,"context_line":"            msg \u003d _("},{"line_number":1603,"context_line":"                \"Failed to complete the migration for \""},{"line_number":1604,"context_line":"                \"share server %s\") % dest_share_server[\u0027id\u0027]"},{"line_number":1605,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":1606,"context_line":""},{"line_number":1607,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aae9b86_02dedb6e","line":1604,"range":{"start_line":1604,"start_character":32,"end_line":1604,"end_character":33},"updated":"2021-08-27 12:20:24.000000000","message":".\"","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1601,"context_line":"        except exception.NetAppException:"},{"line_number":1602,"context_line":"            msg \u003d _("},{"line_number":1603,"context_line":"                \"Failed to complete the migration for \""},{"line_number":1604,"context_line":"                \"share server %s\") % dest_share_server[\u0027id\u0027]"},{"line_number":1605,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":1606,"context_line":""},{"line_number":1607,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":10,"id":"3b571bd6_c41434f6","line":1604,"range":{"start_line":1604,"start_character":32,"end_line":1604,"end_character":33},"in_reply_to":"3aae9b86_02dedb6e","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1624,"context_line":"        migration_id \u003d self._get_share_server_migration_id(dest_share_server)"},{"line_number":1625,"context_line":""},{"line_number":1626,"context_line":"        share_server_to_get_vserver_name_from \u003d dest_share_server"},{"line_number":1627,"context_line":"        # 1. Call functions to conclude the migration for SVM DR or SVM Migrate"},{"line_number":1628,"context_line":"        if migration_id:"},{"line_number":1629,"context_line":"            self._share_server_migration_complete_svm_migrate("},{"line_number":1630,"context_line":"                migration_id, dest_share_server)"}],"source_content_type":"text/x-python","patch_set":10,"id":"71eea3c0_4a63bcac","line":1627,"range":{"start_line":1627,"start_character":72,"end_line":1627,"end_character":79},"updated":"2021-08-27 12:20:24.000000000","message":"Migrate.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1624,"context_line":"        migration_id \u003d self._get_share_server_migration_id(dest_share_server)"},{"line_number":1625,"context_line":""},{"line_number":1626,"context_line":"        share_server_to_get_vserver_name_from \u003d dest_share_server"},{"line_number":1627,"context_line":"        # 1. Call functions to conclude the migration for SVM DR or SVM Migrate"},{"line_number":1628,"context_line":"        if migration_id:"},{"line_number":1629,"context_line":"            self._share_server_migration_complete_svm_migrate("},{"line_number":1630,"context_line":"                migration_id, dest_share_server)"}],"source_content_type":"text/x-python","patch_set":10,"id":"09682d3a_7371114b","line":1627,"range":{"start_line":1627,"start_character":72,"end_line":1627,"end_character":79},"in_reply_to":"71eea3c0_4a63bcac","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1638,"context_line":"            share_server\u003dshare_server_to_get_vserver_name_from,"},{"line_number":1639,"context_line":"            backend_name\u003ddest_backend_name)"},{"line_number":1640,"context_line":""},{"line_number":1641,"context_line":"        # 2. Build a dict with shares/snapshot location updates"},{"line_number":1642,"context_line":"        # NOTE(dviroel): For SVM DR, the share names aren\u0027t modified, only the"},{"line_number":1643,"context_line":"        # export_locations are updated due to network changes."},{"line_number":1644,"context_line":"        share_updates \u003d {}"}],"source_content_type":"text/x-python","patch_set":10,"id":"33f957af_a001a5b6","line":1641,"range":{"start_line":1641,"start_character":56,"end_line":1641,"end_character":63},"updated":"2021-08-27 12:20:24.000000000","message":"updates.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1638,"context_line":"            share_server\u003dshare_server_to_get_vserver_name_from,"},{"line_number":1639,"context_line":"            backend_name\u003ddest_backend_name)"},{"line_number":1640,"context_line":""},{"line_number":1641,"context_line":"        # 2. Build a dict with shares/snapshot location updates"},{"line_number":1642,"context_line":"        # NOTE(dviroel): For SVM DR, the share names aren\u0027t modified, only the"},{"line_number":1643,"context_line":"        # export_locations are updated due to network changes."},{"line_number":1644,"context_line":"        share_updates \u003d {}"}],"source_content_type":"text/x-python","patch_set":10,"id":"317c94bf_5c49cea2","line":1641,"range":{"start_line":1641,"start_character":56,"end_line":1641,"end_character":63},"in_reply_to":"33f957af_a001a5b6","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1651,"context_line":"                dest_aggregate \u003d volume.get(\u0027aggregate\u0027)"},{"line_number":1652,"context_line":""},{"line_number":1653,"context_line":"                if not migration_id:"},{"line_number":1654,"context_line":"                    # Update share attributes according with share extra specs"},{"line_number":1655,"context_line":"                    self._update_share_attributes_after_server_migration("},{"line_number":1656,"context_line":"                        instance, src_client, dest_aggregate, dest_client)"},{"line_number":1657,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"cfb41977_2251a331","line":1654,"range":{"start_line":1654,"start_character":73,"end_line":1654,"end_character":78},"updated":"2021-08-27 12:20:24.000000000","message":"specs.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1651,"context_line":"                dest_aggregate \u003d volume.get(\u0027aggregate\u0027)"},{"line_number":1652,"context_line":""},{"line_number":1653,"context_line":"                if not migration_id:"},{"line_number":1654,"context_line":"                    # Update share attributes according with share extra specs"},{"line_number":1655,"context_line":"                    self._update_share_attributes_after_server_migration("},{"line_number":1656,"context_line":"                        instance, src_client, dest_aggregate, dest_client)"},{"line_number":1657,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"d7895318_ab85177e","line":1654,"range":{"start_line":1654,"start_character":73,"end_line":1654,"end_character":78},"in_reply_to":"cfb41977_2251a331","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1672,"context_line":"            share_host \u003d instance[\u0027host\u0027]"},{"line_number":1673,"context_line":""},{"line_number":1674,"context_line":"            # If using SVM migrate, must already ensure the export policies"},{"line_number":1675,"context_line":"            # using the new host information"},{"line_number":1676,"context_line":"            if migration_id:"},{"line_number":1677,"context_line":"                old_aggregate \u003d share_host.split(\u0027#\u0027)[1]"},{"line_number":1678,"context_line":"                share_host \u003d share_host.replace("}],"source_content_type":"text/x-python","patch_set":10,"id":"fa12301c_51575015","line":1675,"range":{"start_line":1675,"start_character":33,"end_line":1675,"end_character":44},"updated":"2021-08-27 12:20:24.000000000","message":"information.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1672,"context_line":"            share_host \u003d instance[\u0027host\u0027]"},{"line_number":1673,"context_line":""},{"line_number":1674,"context_line":"            # If using SVM migrate, must already ensure the export policies"},{"line_number":1675,"context_line":"            # using the new host information"},{"line_number":1676,"context_line":"            if migration_id:"},{"line_number":1677,"context_line":"                old_aggregate \u003d share_host.split(\u0027#\u0027)[1]"},{"line_number":1678,"context_line":"                share_host \u003d share_host.replace("}],"source_content_type":"text/x-python","patch_set":10,"id":"543e065e_8d8f86f6","line":1675,"range":{"start_line":1675,"start_character":33,"end_line":1675,"end_character":44},"in_reply_to":"fa12301c_51575015","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1692,"context_line":""},{"line_number":1693,"context_line":"        # NOTE(carloss): as SVM DR works like a replica, we must delete the"},{"line_number":1694,"context_line":"        # source shares after the migration. In case of SVM Migrate, the shares"},{"line_number":1695,"context_line":"        # were moved to the destination, so there\u0027s no need to remove them"},{"line_number":1696,"context_line":"        if not migration_id:"},{"line_number":1697,"context_line":"            # 3. Release source share resources"},{"line_number":1698,"context_line":"            for instance in share_instances:"}],"source_content_type":"text/x-python","patch_set":10,"id":"c7517275_f578df58","line":1695,"range":{"start_line":1695,"start_character":70,"end_line":1695,"end_character":74},"updated":"2021-08-27 12:20:24.000000000","message":"them.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1692,"context_line":""},{"line_number":1693,"context_line":"        # NOTE(carloss): as SVM DR works like a replica, we must delete the"},{"line_number":1694,"context_line":"        # source shares after the migration. In case of SVM Migrate, the shares"},{"line_number":1695,"context_line":"        # were moved to the destination, so there\u0027s no need to remove them"},{"line_number":1696,"context_line":"        if not migration_id:"},{"line_number":1697,"context_line":"            # 3. Release source share resources"},{"line_number":1698,"context_line":"            for instance in share_instances:"}],"source_content_type":"text/x-python","patch_set":10,"id":"424969d8_3bf4652f","line":1695,"range":{"start_line":1695,"start_character":70,"end_line":1695,"end_character":74},"in_reply_to":"c7517275_f578df58","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1694,"context_line":"        # source shares after the migration. In case of SVM Migrate, the shares"},{"line_number":1695,"context_line":"        # were moved to the destination, so there\u0027s no need to remove them"},{"line_number":1696,"context_line":"        if not migration_id:"},{"line_number":1697,"context_line":"            # 3. Release source share resources"},{"line_number":1698,"context_line":"            for instance in share_instances:"},{"line_number":1699,"context_line":"                self._delete_share(instance, src_vserver, src_client,"},{"line_number":1700,"context_line":"                                   remove_export\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":10,"id":"54642ddf_253ee89f","line":1697,"range":{"start_line":1697,"start_character":38,"end_line":1697,"end_character":47},"updated":"2021-08-27 12:20:24.000000000","message":"resources.","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1694,"context_line":"        # source shares after the migration. In case of SVM Migrate, the shares"},{"line_number":1695,"context_line":"        # were moved to the destination, so there\u0027s no need to remove them"},{"line_number":1696,"context_line":"        if not migration_id:"},{"line_number":1697,"context_line":"            # 3. Release source share resources"},{"line_number":1698,"context_line":"            for instance in share_instances:"},{"line_number":1699,"context_line":"                self._delete_share(instance, src_vserver, src_client,"},{"line_number":1700,"context_line":"                                   remove_export\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":10,"id":"df1841b2_3e228c6e","line":1697,"range":{"start_line":1697,"start_character":38,"end_line":1697,"end_character":47},"in_reply_to":"54642ddf_253ee89f","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1706,"context_line":"            \u0027share_updates\u0027: share_updates,"},{"line_number":1707,"context_line":"        }"},{"line_number":1708,"context_line":""},{"line_number":1709,"context_line":"    def _get_share_server_migration_id(self, dest_share_server):"},{"line_number":1710,"context_line":"        return dest_share_server[\u0027backend_details\u0027].get("},{"line_number":1711,"context_line":"            \u0027migration_operation_id\u0027)"},{"line_number":1712,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"368f377e_1e306176","line":1709,"range":{"start_line":1709,"start_character":8,"end_line":1709,"end_character":38},"updated":"2021-08-27 12:20:24.000000000","message":"@na_utils and documentation","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1706,"context_line":"            \u0027share_updates\u0027: share_updates,"},{"line_number":1707,"context_line":"        }"},{"line_number":1708,"context_line":""},{"line_number":1709,"context_line":"    def _get_share_server_migration_id(self, dest_share_server):"},{"line_number":1710,"context_line":"        return dest_share_server[\u0027backend_details\u0027].get("},{"line_number":1711,"context_line":"            \u0027migration_operation_id\u0027)"},{"line_number":1712,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"78e4117d_a9cf1b8b","line":1709,"range":{"start_line":1709,"start_character":8,"end_line":1709,"end_character":38},"in_reply_to":"368f377e_1e306176","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1708,"context_line":""},{"line_number":1709,"context_line":"    def _get_share_server_migration_id(self, dest_share_server):"},{"line_number":1710,"context_line":"        return dest_share_server[\u0027backend_details\u0027].get("},{"line_number":1711,"context_line":"            \u0027migration_operation_id\u0027)"},{"line_number":1712,"context_line":""},{"line_number":1713,"context_line":"    @na_utils.trace"},{"line_number":1714,"context_line":"    def _migration_cancel_using_svm_dr("}],"source_content_type":"text/x-python","patch_set":10,"id":"a2de2ed6_576a0f1d","line":1711,"range":{"start_line":1711,"start_character":13,"end_line":1711,"end_character":35},"updated":"2021-08-27 12:20:24.000000000","message":"hard coded.. use could used the same source of truth with utils:\n\nutils.MIGRATION_ID_KEY_NAME","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1708,"context_line":""},{"line_number":1709,"context_line":"    def _get_share_server_migration_id(self, dest_share_server):"},{"line_number":1710,"context_line":"        return dest_share_server[\u0027backend_details\u0027].get("},{"line_number":1711,"context_line":"            \u0027migration_operation_id\u0027)"},{"line_number":1712,"context_line":""},{"line_number":1713,"context_line":"    @na_utils.trace"},{"line_number":1714,"context_line":"    def _migration_cancel_using_svm_dr("}],"source_content_type":"text/x-python","patch_set":10,"id":"a3004ef9_56433b21","line":1711,"range":{"start_line":1711,"start_character":13,"end_line":1711,"end_character":35},"in_reply_to":"a2de2ed6_576a0f1d","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1750,"context_line":"        3. Ask to ONTAP to actually cancel the migration"},{"line_number":1751,"context_line":"        \"\"\""},{"line_number":1752,"context_line":""},{"line_number":1753,"context_line":"        # 1. Gets information about the migration"},{"line_number":1754,"context_line":"        dest_client \u003d self._get_client_for_svm_migrate(dest_share_server)"},{"line_number":1755,"context_line":"        migration_information \u003d dest_client.svm_migration_get(migration_id)"},{"line_number":1756,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3f4a029e_a0de53e4","line":1753,"range":{"start_line":1753,"start_character":40,"end_line":1753,"end_character":49},"updated":"2021-08-27 12:20:24.000000000","message":".","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1750,"context_line":"        3. Ask to ONTAP to actually cancel the migration"},{"line_number":1751,"context_line":"        \"\"\""},{"line_number":1752,"context_line":""},{"line_number":1753,"context_line":"        # 1. Gets information about the migration"},{"line_number":1754,"context_line":"        dest_client \u003d self._get_client_for_svm_migrate(dest_share_server)"},{"line_number":1755,"context_line":"        migration_information \u003d dest_client.svm_migration_get(migration_id)"},{"line_number":1756,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5e052a45_8ad91bc4","line":1753,"range":{"start_line":1753,"start_character":40,"end_line":1753,"end_character":49},"in_reply_to":"3f4a029e_a0de53e4","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1755,"context_line":"        migration_information \u003d dest_client.svm_migration_get(migration_id)"},{"line_number":1756,"context_line":""},{"line_number":1757,"context_line":"        # Gets the ipspace that was created so we can delete it if it\u0027s not"},{"line_number":1758,"context_line":"        # being used anymore"},{"line_number":1759,"context_line":"        dest_ipspace_name \u003d ("},{"line_number":1760,"context_line":"            migration_information[\"destination\"][\"ipspace\"][\"name\"])"},{"line_number":1761,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"21e8d9b5_bd95ea70","line":1758,"range":{"start_line":1758,"start_character":21,"end_line":1758,"end_character":28},"updated":"2021-08-27 12:20:24.000000000","message":".","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1755,"context_line":"        migration_information \u003d dest_client.svm_migration_get(migration_id)"},{"line_number":1756,"context_line":""},{"line_number":1757,"context_line":"        # Gets the ipspace that was created so we can delete it if it\u0027s not"},{"line_number":1758,"context_line":"        # being used anymore"},{"line_number":1759,"context_line":"        dest_ipspace_name \u003d ("},{"line_number":1760,"context_line":"            migration_information[\"destination\"][\"ipspace\"][\"name\"])"},{"line_number":1761,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bd533255_5f25cfc2","line":1758,"range":{"start_line":1758,"start_character":21,"end_line":1758,"end_character":28},"in_reply_to":"21e8d9b5_bd95ea70","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1759,"context_line":"        dest_ipspace_name \u003d ("},{"line_number":1760,"context_line":"            migration_information[\"destination\"][\"ipspace\"][\"name\"])"},{"line_number":1761,"context_line":""},{"line_number":1762,"context_line":"        # 2. Pauses the migration"},{"line_number":1763,"context_line":"        try:"},{"line_number":1764,"context_line":"            # Request the migration to be paused and wait until the job is"},{"line_number":1765,"context_line":"            # successful"}],"source_content_type":"text/x-python","patch_set":10,"id":"722b53d1_8691e582","line":1762,"range":{"start_line":1762,"start_character":24,"end_line":1762,"end_character":33},"updated":"2021-08-27 12:20:24.000000000","message":".","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1759,"context_line":"        dest_ipspace_name \u003d ("},{"line_number":1760,"context_line":"            migration_information[\"destination\"][\"ipspace\"][\"name\"])"},{"line_number":1761,"context_line":""},{"line_number":1762,"context_line":"        # 2. Pauses the migration"},{"line_number":1763,"context_line":"        try:"},{"line_number":1764,"context_line":"            # Request the migration to be paused and wait until the job is"},{"line_number":1765,"context_line":"            # successful"}],"source_content_type":"text/x-python","patch_set":10,"id":"71d57d87_4be578c5","line":1762,"range":{"start_line":1762,"start_character":24,"end_line":1762,"end_character":33},"in_reply_to":"722b53d1_8691e582","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1762,"context_line":"        # 2. Pauses the migration"},{"line_number":1763,"context_line":"        try:"},{"line_number":1764,"context_line":"            # Request the migration to be paused and wait until the job is"},{"line_number":1765,"context_line":"            # successful"},{"line_number":1766,"context_line":"            job \u003d dest_client.svm_migrate_pause(migration_id)"},{"line_number":1767,"context_line":"            job_id \u003d self._get_job_uuid(job)"},{"line_number":1768,"context_line":"            self._wait_for_operation_status(job_id, dest_client.get_job)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ecceed78_2a06d354","line":1765,"range":{"start_line":1765,"start_character":14,"end_line":1765,"end_character":24},"updated":"2021-08-27 12:20:24.000000000","message":".","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1762,"context_line":"        # 2. Pauses the migration"},{"line_number":1763,"context_line":"        try:"},{"line_number":1764,"context_line":"            # Request the migration to be paused and wait until the job is"},{"line_number":1765,"context_line":"            # successful"},{"line_number":1766,"context_line":"            job \u003d dest_client.svm_migrate_pause(migration_id)"},{"line_number":1767,"context_line":"            job_id \u003d self._get_job_uuid(job)"},{"line_number":1768,"context_line":"            self._wait_for_operation_status(job_id, dest_client.get_job)"}],"source_content_type":"text/x-python","patch_set":10,"id":"35dba80d_ea8e0bd5","line":1765,"range":{"start_line":1765,"start_character":14,"end_line":1765,"end_character":24},"in_reply_to":"ecceed78_2a06d354","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1767,"context_line":"            job_id \u003d self._get_job_uuid(job)"},{"line_number":1768,"context_line":"            self._wait_for_operation_status(job_id, dest_client.get_job)"},{"line_number":1769,"context_line":""},{"line_number":1770,"context_line":"            # Wait until the migration get actually paused"},{"line_number":1771,"context_line":"            self._wait_for_operation_status("},{"line_number":1772,"context_line":"                migration_id, dest_client.svm_migration_get,"},{"line_number":1773,"context_line":"                desired_status\u003d\"migrate_paused\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"6fe696ab_7622e77e","line":1770,"range":{"start_line":1770,"start_character":52,"end_line":1770,"end_character":58},"updated":"2021-08-27 12:20:24.000000000","message":".","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1767,"context_line":"            job_id \u003d self._get_job_uuid(job)"},{"line_number":1768,"context_line":"            self._wait_for_operation_status(job_id, dest_client.get_job)"},{"line_number":1769,"context_line":""},{"line_number":1770,"context_line":"            # Wait until the migration get actually paused"},{"line_number":1771,"context_line":"            self._wait_for_operation_status("},{"line_number":1772,"context_line":"                migration_id, dest_client.svm_migration_get,"},{"line_number":1773,"context_line":"                desired_status\u003d\"migrate_paused\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"27492869_87a03cfb","line":1770,"range":{"start_line":1770,"start_character":52,"end_line":1770,"end_character":58},"in_reply_to":"6fe696ab_7622e77e","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1770,"context_line":"            # Wait until the migration get actually paused"},{"line_number":1771,"context_line":"            self._wait_for_operation_status("},{"line_number":1772,"context_line":"                migration_id, dest_client.svm_migration_get,"},{"line_number":1773,"context_line":"                desired_status\u003d\"migrate_paused\")"},{"line_number":1774,"context_line":"        except exception.NetAppException:"},{"line_number":1775,"context_line":"            msg \u003d _(\"Failed to pause the share server migration.\")"},{"line_number":1776,"context_line":"            raise exception.NetAppException(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"b136d383_9cd5673f","line":1773,"range":{"start_line":1773,"start_character":32,"end_line":1773,"end_character":46},"updated":"2021-08-27 12:20:24.000000000","message":"avoid hard coded status","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1770,"context_line":"            # Wait until the migration get actually paused"},{"line_number":1771,"context_line":"            self._wait_for_operation_status("},{"line_number":1772,"context_line":"                migration_id, dest_client.svm_migration_get,"},{"line_number":1773,"context_line":"                desired_status\u003d\"migrate_paused\")"},{"line_number":1774,"context_line":"        except exception.NetAppException:"},{"line_number":1775,"context_line":"            msg \u003d _(\"Failed to pause the share server migration.\")"},{"line_number":1776,"context_line":"            raise exception.NetAppException(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"c828311c_ebeba0e4","line":1773,"range":{"start_line":1773,"start_character":32,"end_line":1773,"end_character":46},"in_reply_to":"b136d383_9cd5673f","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1776,"context_line":"            raise exception.NetAppException(message\u003dmsg)"},{"line_number":1777,"context_line":""},{"line_number":1778,"context_line":"        try:"},{"line_number":1779,"context_line":"            # 3. Ask to ONTAP to actually cancel the migration"},{"line_number":1780,"context_line":"            job \u003d dest_client.svm_migrate_cancel(migration_id)"},{"line_number":1781,"context_line":"            job_id \u003d self._get_job_uuid(job)"},{"line_number":1782,"context_line":"            self._wait_for_operation_status("}],"source_content_type":"text/x-python","patch_set":10,"id":"db6729a3_138d4ab9","line":1779,"range":{"start_line":1779,"start_character":53,"end_line":1779,"end_character":62},"updated":"2021-08-27 12:20:24.000000000","message":".","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1776,"context_line":"            raise exception.NetAppException(message\u003dmsg)"},{"line_number":1777,"context_line":""},{"line_number":1778,"context_line":"        try:"},{"line_number":1779,"context_line":"            # 3. Ask to ONTAP to actually cancel the migration"},{"line_number":1780,"context_line":"            job \u003d dest_client.svm_migrate_cancel(migration_id)"},{"line_number":1781,"context_line":"            job_id \u003d self._get_job_uuid(job)"},{"line_number":1782,"context_line":"            self._wait_for_operation_status("}],"source_content_type":"text/x-python","patch_set":10,"id":"ad82bd40_1fe500d5","line":1779,"range":{"start_line":1779,"start_character":53,"end_line":1779,"end_character":62},"in_reply_to":"db6729a3_138d4ab9","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1785,"context_line":"            msg \u003d _(\"Failed to cancel the share server migration.\")"},{"line_number":1786,"context_line":"            raise exception.NetAppException(message\u003dmsg)"},{"line_number":1787,"context_line":""},{"line_number":1788,"context_line":"        # If there is need to, remove the ipspace"},{"line_number":1789,"context_line":"        if (dest_ipspace_name and dest_ipspace_name not in CLUSTER_IPSPACES"},{"line_number":1790,"context_line":"                and not dest_client.ipspace_has_data_vservers("},{"line_number":1791,"context_line":"                    dest_ipspace_name)):"}],"source_content_type":"text/x-python","patch_set":10,"id":"bbff0f27_9c1e77dc","line":1788,"range":{"start_line":1788,"start_character":42,"end_line":1788,"end_character":49},"updated":"2021-08-27 12:20:24.000000000","message":".","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1785,"context_line":"            msg \u003d _(\"Failed to cancel the share server migration.\")"},{"line_number":1786,"context_line":"            raise exception.NetAppException(message\u003dmsg)"},{"line_number":1787,"context_line":""},{"line_number":1788,"context_line":"        # If there is need to, remove the ipspace"},{"line_number":1789,"context_line":"        if (dest_ipspace_name and dest_ipspace_name not in CLUSTER_IPSPACES"},{"line_number":1790,"context_line":"                and not dest_client.ipspace_has_data_vservers("},{"line_number":1791,"context_line":"                    dest_ipspace_name)):"}],"source_content_type":"text/x-python","patch_set":10,"id":"b1f26b8a_97ee0dc7","line":1788,"range":{"start_line":1788,"start_character":42,"end_line":1788,"end_character":49},"in_reply_to":"bbff0f27_9c1e77dc","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1800,"context_line":"        migration_id \u003d self._get_share_server_migration_id(dest_share_server)"},{"line_number":1801,"context_line":""},{"line_number":1802,"context_line":"        if migration_id:"},{"line_number":1803,"context_line":"            self._migration_cancel_using_svm_migrate("},{"line_number":1804,"context_line":"                migration_id, dest_share_server)"},{"line_number":1805,"context_line":""},{"line_number":1806,"context_line":"        self._migration_cancel_using_svm_dr("},{"line_number":1807,"context_line":"            source_share_server, dest_share_server, shares)"}],"source_content_type":"text/x-python","patch_set":10,"id":"21aceea3_173fefd9","line":1804,"range":{"start_line":1803,"start_character":12,"end_line":1804,"end_character":48},"updated":"2021-08-27 12:20:24.000000000","message":"return here ?","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1800,"context_line":"        migration_id \u003d self._get_share_server_migration_id(dest_share_server)"},{"line_number":1801,"context_line":""},{"line_number":1802,"context_line":"        if migration_id:"},{"line_number":1803,"context_line":"            self._migration_cancel_using_svm_migrate("},{"line_number":1804,"context_line":"                migration_id, dest_share_server)"},{"line_number":1805,"context_line":""},{"line_number":1806,"context_line":"        self._migration_cancel_using_svm_dr("},{"line_number":1807,"context_line":"            source_share_server, dest_share_server, shares)"}],"source_content_type":"text/x-python","patch_set":10,"id":"de29deb3_350a4094","line":1804,"range":{"start_line":1803,"start_character":12,"end_line":1804,"end_character":48},"in_reply_to":"21aceea3_173fefd9","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":2010,"context_line":"        return True"},{"line_number":2011,"context_line":""},{"line_number":2012,"context_line":"    @na_utils.trace"},{"line_number":2013,"context_line":"    def _source_and_dest_host_supports_svm_migrate("},{"line_number":2014,"context_line":"            self, source_host, dest_host):"},{"line_number":2015,"context_line":"        \"\"\"Checks the possibility to reuse server allocations in a migration\"\"\""},{"line_number":2016,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"a8c41cf3_8164ce67","line":2013,"range":{"start_line":2013,"start_character":30,"end_line":2013,"end_character":38},"updated":"2021-08-27 12:20:24.000000000","message":"support","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":2010,"context_line":"        return True"},{"line_number":2011,"context_line":""},{"line_number":2012,"context_line":"    @na_utils.trace"},{"line_number":2013,"context_line":"    def _source_and_dest_host_supports_svm_migrate("},{"line_number":2014,"context_line":"            self, source_host, dest_host):"},{"line_number":2015,"context_line":"        \"\"\"Checks the possibility to reuse server allocations in a migration\"\"\""},{"line_number":2016,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"c3bb6b1e_168ac30f","line":2013,"range":{"start_line":2013,"start_character":30,"end_line":2013,"end_character":38},"in_reply_to":"a8c41cf3_8164ce67","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":2012,"context_line":"    @na_utils.trace"},{"line_number":2013,"context_line":"    def _source_and_dest_host_supports_svm_migrate("},{"line_number":2014,"context_line":"            self, source_host, dest_host):"},{"line_number":2015,"context_line":"        \"\"\"Checks the possibility to reuse server allocations in a migration\"\"\""},{"line_number":2016,"context_line":""},{"line_number":2017,"context_line":"        source_backend_name \u003d share_utils.extract_host("},{"line_number":2018,"context_line":"            source_host, level\u003d\u0027backend_name\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"b8b89626_0f2aabd7","line":2015,"range":{"start_line":2015,"start_character":67,"end_line":2015,"end_character":76},"updated":"2021-08-27 12:20:24.000000000","message":".","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":2012,"context_line":"    @na_utils.trace"},{"line_number":2013,"context_line":"    def _source_and_dest_host_supports_svm_migrate("},{"line_number":2014,"context_line":"            self, source_host, dest_host):"},{"line_number":2015,"context_line":"        \"\"\"Checks the possibility to reuse server allocations in a migration\"\"\""},{"line_number":2016,"context_line":""},{"line_number":2017,"context_line":"        source_backend_name \u003d share_utils.extract_host("},{"line_number":2018,"context_line":"            source_host, level\u003d\u0027backend_name\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"65094d7f_144946c7","line":2015,"range":{"start_line":2015,"start_character":67,"end_line":2015,"end_character":76},"in_reply_to":"b8b89626_0f2aabd7","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":2038,"context_line":"            source_host, dest_host)"},{"line_number":2039,"context_line":""},{"line_number":2040,"context_line":"    @na_utils.trace"},{"line_number":2041,"context_line":"    def server_migration_mechanism_can_reuse_share_server("},{"line_number":2042,"context_line":"            self, source_host, dest_host):"},{"line_number":2043,"context_line":"        return self._source_and_dest_host_supports_svm_migrate("},{"line_number":2044,"context_line":"            source_host, dest_host)"}],"source_content_type":"text/x-python","patch_set":10,"id":"01004880_4d497e6c","line":2041,"range":{"start_line":2041,"start_character":8,"end_line":2041,"end_character":57},"updated":"2021-08-27 12:20:24.000000000","message":"documentation","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":2038,"context_line":"            source_host, dest_host)"},{"line_number":2039,"context_line":""},{"line_number":2040,"context_line":"    @na_utils.trace"},{"line_number":2041,"context_line":"    def server_migration_mechanism_can_reuse_share_server("},{"line_number":2042,"context_line":"            self, source_host, dest_host):"},{"line_number":2043,"context_line":"        return self._source_and_dest_host_supports_svm_migrate("},{"line_number":2044,"context_line":"            source_host, dest_host)"}],"source_content_type":"text/x-python","patch_set":10,"id":"6f61e39f_8b9d4006","line":2041,"range":{"start_line":2041,"start_character":8,"end_line":2041,"end_character":57},"in_reply_to":"01004880_4d497e6c","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1aef620c86aabc294cf6fa21f14b147ea5ca983f","unresolved":true,"context_lines":[{"line_number":1037,"context_line":""},{"line_number":1038,"context_line":"        job_id \u003d self._get_job_uuid(job)"},{"line_number":1039,"context_line":""},{"line_number":1040,"context_line":"        def _wait_migration_check_result():"},{"line_number":1041,"context_line":"            job_state \u003d dest_client.get_migration_check_job_state(job_id)"},{"line_number":1042,"context_line":"            LOG.debug("},{"line_number":1043,"context_line":"                \u0027Waiting on share server migration check result for share \u0027"},{"line_number":1044,"context_line":"                \u0027server %s to complete. Current status is: %s.\u0027,"},{"line_number":1045,"context_line":"                src_server_id, job_state)"},{"line_number":1046,"context_line":"            if job_state \u003d\u003d \u0027success\u0027:"},{"line_number":1047,"context_line":"                raise loopingcall.LoopingCallDone()"},{"line_number":1048,"context_line":""},{"line_number":1049,"context_line":"        try:"},{"line_number":1050,"context_line":"            # 2. Wait until the job to check the migration status concludes."},{"line_number":1051,"context_line":"            timeout \u003d ("},{"line_number":1052,"context_line":"                self.configuration.netapp_server_migration_state_change_timeout"},{"line_number":1053,"context_line":"            )"},{"line_number":1054,"context_line":"            timer \u003d loopingcall.FixedIntervalWithTimeoutLoopingCall("},{"line_number":1055,"context_line":"                _wait_migration_check_result)"},{"line_number":1056,"context_line":"            timer.start(interval\u003d10, timeout\u003dtimeout).wait()"},{"line_number":1057,"context_line":"            return True"},{"line_number":1058,"context_line":"        except loopingcall.LoopingCallTimeOut:"},{"line_number":1059,"context_line":"            msg \u003d ("},{"line_number":1060,"context_line":"                _(\u0027Timeout waiting migration check for share server %s to \u0027"},{"line_number":1061,"context_line":"                  \u0027be performed.\u0027))"},{"line_number":1062,"context_line":"            raise exception.NetAppException(msg % src_server_id)"},{"line_number":1063,"context_line":"        except exception.NetAppException:"},{"line_number":1064,"context_line":"            # Performed the check with the given parameters and the backend"}],"source_content_type":"text/x-python","patch_set":11,"id":"840201da_58153d60","line":1061,"range":{"start_line":1040,"start_character":8,"end_line":1061,"end_character":35},"updated":"2021-09-02 05:36:22.000000000","message":"Can this be done with utils.retry instead of a fixed interval looping call?","commit_id":"4f4957e7602b8a4ff416ace1d7bf48cb97ffb250"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0b3f78e7ed8e7f2bf0e9aa4936766961da8777c0","unresolved":false,"context_lines":[{"line_number":1037,"context_line":""},{"line_number":1038,"context_line":"        job_id \u003d self._get_job_uuid(job)"},{"line_number":1039,"context_line":""},{"line_number":1040,"context_line":"        def _wait_migration_check_result():"},{"line_number":1041,"context_line":"            job_state \u003d dest_client.get_migration_check_job_state(job_id)"},{"line_number":1042,"context_line":"            LOG.debug("},{"line_number":1043,"context_line":"                \u0027Waiting on share server migration check result for share \u0027"},{"line_number":1044,"context_line":"                \u0027server %s to complete. Current status is: %s.\u0027,"},{"line_number":1045,"context_line":"                src_server_id, job_state)"},{"line_number":1046,"context_line":"            if job_state \u003d\u003d \u0027success\u0027:"},{"line_number":1047,"context_line":"                raise loopingcall.LoopingCallDone()"},{"line_number":1048,"context_line":""},{"line_number":1049,"context_line":"        try:"},{"line_number":1050,"context_line":"            # 2. Wait until the job to check the migration status concludes."},{"line_number":1051,"context_line":"            timeout \u003d ("},{"line_number":1052,"context_line":"                self.configuration.netapp_server_migration_state_change_timeout"},{"line_number":1053,"context_line":"            )"},{"line_number":1054,"context_line":"            timer \u003d loopingcall.FixedIntervalWithTimeoutLoopingCall("},{"line_number":1055,"context_line":"                _wait_migration_check_result)"},{"line_number":1056,"context_line":"            timer.start(interval\u003d10, timeout\u003dtimeout).wait()"},{"line_number":1057,"context_line":"            return True"},{"line_number":1058,"context_line":"        except loopingcall.LoopingCallTimeOut:"},{"line_number":1059,"context_line":"            msg \u003d ("},{"line_number":1060,"context_line":"                _(\u0027Timeout waiting migration check for share server %s to \u0027"},{"line_number":1061,"context_line":"                  \u0027be performed.\u0027))"},{"line_number":1062,"context_line":"            raise exception.NetAppException(msg % src_server_id)"},{"line_number":1063,"context_line":"        except exception.NetAppException:"},{"line_number":1064,"context_line":"            # Performed the check with the given parameters and the backend"}],"source_content_type":"text/x-python","patch_set":11,"id":"6747abca_f28db31f","line":1061,"range":{"start_line":1040,"start_character":8,"end_line":1061,"end_character":35},"in_reply_to":"840201da_58153d60","updated":"2021-09-02 21:57:55.000000000","message":"Ack","commit_id":"4f4957e7602b8a4ff416ace1d7bf48cb97ffb250"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1aef620c86aabc294cf6fa21f14b147ea5ca983f","unresolved":true,"context_lines":[{"line_number":1084,"context_line":"                and src_client.is_svm_migrate_supported()):"},{"line_number":1085,"context_line":"            source_share_server_name \u003d self._get_vserver_name("},{"line_number":1086,"context_line":"                source_share_server[\u0027id\u0027])"},{"line_number":1087,"context_line":""},{"line_number":1088,"context_line":"            # Check if the migration is supported."},{"line_number":1089,"context_line":"            try:"},{"line_number":1090,"context_line":"                result \u003d self._check_compatibility_for_svm_migrate("}],"source_content_type":"text/x-python","patch_set":11,"id":"9c96fb2f_782cfd06","line":1087,"range":{"start_line":1087,"start_character":0,"end_line":1087,"end_character":0},"updated":"2021-09-02 05:36:22.000000000","message":"Would this be a good place to check if both source and destination clusters are AFF?","commit_id":"4f4957e7602b8a4ff416ace1d7bf48cb97ffb250"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0b3f78e7ed8e7f2bf0e9aa4936766961da8777c0","unresolved":false,"context_lines":[{"line_number":1084,"context_line":"                and src_client.is_svm_migrate_supported()):"},{"line_number":1085,"context_line":"            source_share_server_name \u003d self._get_vserver_name("},{"line_number":1086,"context_line":"                source_share_server[\u0027id\u0027])"},{"line_number":1087,"context_line":""},{"line_number":1088,"context_line":"            # Check if the migration is supported."},{"line_number":1089,"context_line":"            try:"},{"line_number":1090,"context_line":"                result \u003d self._check_compatibility_for_svm_migrate("}],"source_content_type":"text/x-python","patch_set":11,"id":"feeaeed1_677eac00","line":1087,"range":{"start_line":1087,"start_character":0,"end_line":1087,"end_character":0},"in_reply_to":"9c96fb2f_782cfd06","updated":"2021-09-02 21:57:55.000000000","message":"The call to ONTAP already performs that check... Then, if it does not pass in the check, an exception will be raised, the message will be logged and the result will be False :)","commit_id":"4f4957e7602b8a4ff416ace1d7bf48cb97ffb250"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1aef620c86aabc294cf6fa21f14b147ea5ca983f","unresolved":true,"context_lines":[{"line_number":1201,"context_line":""},{"line_number":1202,"context_line":"        nondisruptive \u003d ("},{"line_number":1203,"context_line":"            (migration_method \u003d\u003d SERVER_MIGRATE_SVM_MIGRATE)"},{"line_number":1204,"context_line":"            and (old_share_network[\u0027id\u0027] \u003d\u003d new_share_network[\u0027id\u0027]))"},{"line_number":1205,"context_line":""},{"line_number":1206,"context_line":"        compatibility \u003d {"},{"line_number":1207,"context_line":"            \u0027compatible\u0027: True,"}],"source_content_type":"text/x-python","patch_set":11,"id":"d916618b_b0206cc4","line":1204,"range":{"start_line":1204,"start_character":17,"end_line":1204,"end_character":67},"updated":"2021-09-02 05:36:22.000000000","message":"this is guaranteed to be the case due to the API check you\u0027ve introduced in the core patch?","commit_id":"4f4957e7602b8a4ff416ace1d7bf48cb97ffb250"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1aef620c86aabc294cf6fa21f14b147ea5ca983f","unresolved":true,"context_lines":[{"line_number":1348,"context_line":"        self._ensure_cluster_has_migrate_policy(src_client)"},{"line_number":1349,"context_line":"        self._ensure_cluster_has_migrate_policy(dest_client)"},{"line_number":1350,"context_line":""},{"line_number":1351,"context_line":"        # TODO(carloss): remove this after the issue with the IPSPACE name"},{"line_number":1352,"context_line":"        #  gets solved."},{"line_number":1353,"context_line":"        ipspace \u003d dest_client.get_ipspaces(ipspace_name\u003ddestination_ipspace)"},{"line_number":1354,"context_line":""},{"line_number":1355,"context_line":"        # Prepare the migration request."}],"source_content_type":"text/x-python","patch_set":11,"id":"087e7c76_59087714","line":1352,"range":{"start_line":1351,"start_character":25,"end_line":1352,"end_character":23},"updated":"2021-09-02 05:36:22.000000000","message":"what is the issue?","commit_id":"4f4957e7602b8a4ff416ace1d7bf48cb97ffb250"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0b3f78e7ed8e7f2bf0e9aa4936766961da8777c0","unresolved":false,"context_lines":[{"line_number":1348,"context_line":"        self._ensure_cluster_has_migrate_policy(src_client)"},{"line_number":1349,"context_line":"        self._ensure_cluster_has_migrate_policy(dest_client)"},{"line_number":1350,"context_line":""},{"line_number":1351,"context_line":"        # TODO(carloss): remove this after the issue with the IPSPACE name"},{"line_number":1352,"context_line":"        #  gets solved."},{"line_number":1353,"context_line":"        ipspace \u003d dest_client.get_ipspaces(ipspace_name\u003ddestination_ipspace)"},{"line_number":1354,"context_line":""},{"line_number":1355,"context_line":"        # Prepare the migration request."}],"source_content_type":"text/x-python","patch_set":11,"id":"bae402ef_b499121e","line":1352,"range":{"start_line":1351,"start_character":25,"end_line":1352,"end_character":23},"in_reply_to":"087e7c76_59087714","updated":"2021-09-02 21:57:55.000000000","message":"ONTAP is currently not accepting the ipspace name in the request to migrate share servers, but it will start allowing in a near future.","commit_id":"4f4957e7602b8a4ff416ace1d7bf48cb97ffb250"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1aef620c86aabc294cf6fa21f14b147ea5ca983f","unresolved":true,"context_lines":[{"line_number":1745,"context_line":"            for instance in share_instances:"},{"line_number":1746,"context_line":"                self._delete_share(instance, src_vserver, src_client,"},{"line_number":1747,"context_line":"                                   remove_export\u003dTrue)"},{"line_number":1748,"context_line":""},{"line_number":1749,"context_line":"        # NOTE(dviroel): source share server deletion must be triggered by"},{"line_number":1750,"context_line":"        # the manager after finishing the migration"},{"line_number":1751,"context_line":"        LOG.info(\u0027Share server migration completed.\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"f7ee47df_c948f601","line":1748,"range":{"start_line":1748,"start_character":0,"end_line":1748,"end_character":0},"updated":"2021-09-02 05:36:22.000000000","message":"Also cleanup the source share server in case of SVM DR","commit_id":"4f4957e7602b8a4ff416ace1d7bf48cb97ffb250"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0b3f78e7ed8e7f2bf0e9aa4936766961da8777c0","unresolved":false,"context_lines":[{"line_number":1745,"context_line":"            for instance in share_instances:"},{"line_number":1746,"context_line":"                self._delete_share(instance, src_vserver, src_client,"},{"line_number":1747,"context_line":"                                   remove_export\u003dTrue)"},{"line_number":1748,"context_line":""},{"line_number":1749,"context_line":"        # NOTE(dviroel): source share server deletion must be triggered by"},{"line_number":1750,"context_line":"        # the manager after finishing the migration"},{"line_number":1751,"context_line":"        LOG.info(\u0027Share server migration completed.\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"32bb0194_354e2c76","line":1748,"range":{"start_line":1748,"start_character":0,"end_line":1748,"end_character":0},"in_reply_to":"f7ee47df_c948f601","updated":"2021-09-02 21:57:55.000000000","message":"Done","commit_id":"4f4957e7602b8a4ff416ace1d7bf48cb97ffb250"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"19cb0dc962148bf7ce6c3fecff6accd41583b732","unresolved":true,"context_lines":[{"line_number":1248,"context_line":"        return None"},{"line_number":1249,"context_line":""},{"line_number":1250,"context_line":"    @na_utils.trace"},{"line_number":1251,"context_line":"    def _ensure_cluster_has_migrate_policy("},{"line_number":1252,"context_line":"            self, cluster_client):"},{"line_number":1253,"context_line":"        \"\"\"Makes sure that there is a Migrate policy created in the cluster."},{"line_number":1254,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"61d176b4_e86d49b5","line":1251,"updated":"2021-09-07 13:11:42.000000000","message":"This is a cluster policy, so there is no need to create the policy for each SVM. When I wrote this, I was thinking it would follow the same pattern as the SVM DR, but in this case, as is a cluster policy, usually admins need to create that for their clusters.","commit_id":"30851c04269da1e112981dbe19255d27a39c27e5"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"772b717f9130bc66fa33d47c6bf7e5e8fe5000f8","unresolved":true,"context_lines":[{"line_number":1288,"context_line":"        # reuse the network allocation from the source share server, so as"},{"line_number":1289,"context_line":"        # Manila haven\u0027t made new allocations, we can just get allocation data"},{"line_number":1290,"context_line":"        # from the source share server."},{"line_number":1291,"context_line":"        if (source_share_server[\u0027share_network_subnet_id\u0027] \u003d\u003d"},{"line_number":1292,"context_line":"                dest_share_server[\u0027share_network_subnet_id\u0027]):"},{"line_number":1293,"context_line":"            share_server_to_get_network_info \u003d source_share_server"},{"line_number":1294,"context_line":"        else:"},{"line_number":1295,"context_line":"            share_server_to_get_network_info \u003d dest_share_server"}],"source_content_type":"text/x-python","patch_set":13,"id":"cc430e28_0a3dbfe8","line":1292,"range":{"start_line":1291,"start_character":12,"end_line":1292,"end_character":60},"updated":"2021-09-03 20:33:31.000000000","message":"not dest_share_server[\u0027network_allocations\u0027]","commit_id":"30851c04269da1e112981dbe19255d27a39c27e5"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"772b717f9130bc66fa33d47c6bf7e5e8fe5000f8","unresolved":true,"context_lines":[{"line_number":1718,"context_line":"        LOG.info(\u0027Share server migration completed.\u0027)"},{"line_number":1719,"context_line":"        return {"},{"line_number":1720,"context_line":"            \u0027share_updates\u0027: share_updates,"},{"line_number":1721,"context_line":"        }"},{"line_number":1722,"context_line":""},{"line_number":1723,"context_line":"    @na_utils.trace"},{"line_number":1724,"context_line":"    def _get_share_server_migration_id(self, dest_share_server):"}],"source_content_type":"text/x-python","patch_set":13,"id":"ae096aef_8b96f6a7","line":1721,"updated":"2021-09-03 20:33:31.000000000","message":"configure the new LIFS with _setup_network_for_vserver and drop the current ones if network changes were identified","commit_id":"30851c04269da1e112981dbe19255d27a39c27e5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"85a001429790ddc78a84195d28ed69f5d2c6b38c","unresolved":true,"context_lines":[{"line_number":910,"context_line":"    @na_utils.trace"},{"line_number":911,"context_line":"    def _check_compatibility_using_svm_dr("},{"line_number":912,"context_line":"            self, src_client, dest_client, shares_request_spec, pools):"},{"line_number":913,"context_line":"        \"\"\"Send a request to pause a migration."},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"        :param src_client: source cluster client."},{"line_number":916,"context_line":"        :param dest_client: destination cluster client."}],"source_content_type":"text/x-python","patch_set":14,"id":"60fd58a3_34e8ed1a","line":913,"range":{"start_line":913,"start_character":11,"end_line":913,"end_character":46},"updated":"2021-09-08 13:09:37.000000000","message":"?","commit_id":"74d5a1b2cf81090d96e12910d880c1c60a96f0ab"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1689a5949fe384e3797a9e48be1a1a483c450845","unresolved":true,"context_lines":[{"line_number":910,"context_line":"    @na_utils.trace"},{"line_number":911,"context_line":"    def _check_compatibility_using_svm_dr("},{"line_number":912,"context_line":"            self, src_client, dest_client, shares_request_spec, pools):"},{"line_number":913,"context_line":"        \"\"\"Send a request to pause a migration."},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"        :param src_client: source cluster client."},{"line_number":916,"context_line":"        :param dest_client: destination cluster client."}],"source_content_type":"text/x-python","patch_set":14,"id":"d7fc310d_b366b470","line":913,"range":{"start_line":913,"start_character":11,"end_line":913,"end_character":46},"in_reply_to":"60fd58a3_34e8ed1a","updated":"2021-09-08 17:41:53.000000000","message":"+1 - Carlos, please fix it up in a follow up patch","commit_id":"74d5a1b2cf81090d96e12910d880c1c60a96f0ab"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"19cb0dc962148bf7ce6c3fecff6accd41583b732","unresolved":true,"context_lines":[{"line_number":1033,"context_line":"                source_share_server[\u0027share_network_subnet\u0027].get("},{"line_number":1034,"context_line":"                    \u0027neutron_subnet_id\u0027)"},{"line_number":1035,"context_line":"        }"},{"line_number":1036,"context_line":""},{"line_number":1037,"context_line":"        # 2. Create new ipspace, port and broadcast domain."},{"line_number":1038,"context_line":"        node_name \u003d self._client.list_cluster_nodes()[0]"},{"line_number":1039,"context_line":"        port \u003d self._get_node_data_port(node_name)"}],"source_content_type":"text/x-python","patch_set":14,"id":"e8bd856a_1d9830e5","line":1036,"updated":"2021-09-07 13:11:42.000000000","message":"I have mentioned an issue before that ONTAP wasn\u0027t taking into consideration the ipspace names. This issue has been fixed, but ONTAP added a validation where even when you\u0027re checking the compatibility of a migration, you need to have the port and destination ipspaces already created, so there was need to add this code here to get the check working.","commit_id":"74d5a1b2cf81090d96e12910d880c1c60a96f0ab"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"19cb0dc962148bf7ce6c3fecff6accd41583b732","unresolved":true,"context_lines":[{"line_number":1650,"context_line":"        if migration_id:"},{"line_number":1651,"context_line":"            self._share_server_migration_complete_svm_migrate("},{"line_number":1652,"context_line":"                migration_id, dest_share_server)"},{"line_number":1653,"context_line":""},{"line_number":1654,"context_line":"            server_backend_details \u003d source_share_server[\u0027backend_details\u0027]"},{"line_number":1655,"context_line":""},{"line_number":1656,"context_line":"            # If there are new network allocations to be added, do so, and add"}],"source_content_type":"text/x-python","patch_set":14,"id":"347dc2d5_2b2fc584","line":1653,"updated":"2021-09-07 13:11:42.000000000","message":"Here, I realized tempest tests were passing but when I checked the allocations and so on, both the ports in the share server entity in manila were wrong, as well as only the previous IPs were there, which is a big issue... So now:\n- Check if there are allocations\n- List the allocations\n- Delete them (we must delete first because otherwise we will have name conflicts)\n- Create the new network interfaces\n- Add the port details to be returned and saved as backend details","commit_id":"74d5a1b2cf81090d96e12910d880c1c60a96f0ab"}],"manila/tests/share/drivers/netapp/dataontap/client/test_api.py":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":279,"context_line":"        self.assertRaises(ValueError, self.root.invoke_elem, na_element)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def _setup_mocks_for_invoke_element(self, mock_post_action):"},{"line_number":282,"context_line":"        fake_action_url \u003d \u0027/endpoint\u0027"},{"line_number":283,"context_line":"        fake_base_url \u003d \u002710.0.0.3/api\u0027"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        self.mock_object(api, \u0027LOG\u0027)"},{"line_number":286,"context_line":"        self.root._session \u003d fake.FAKE_HTTP_SESSION"}],"source_content_type":"text/x-python","patch_set":10,"id":"f976d2f3_0dea89be","line":283,"range":{"start_line":282,"start_character":8,"end_line":283,"end_character":38},"updated":"2021-08-27 12:20:24.000000000","message":"use fake module to fake data","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        self.assertRaises(ValueError, self.root.invoke_elem, na_element)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def _setup_mocks_for_invoke_element(self, mock_post_action):"},{"line_number":282,"context_line":"        fake_action_url \u003d \u0027/endpoint\u0027"},{"line_number":283,"context_line":"        fake_base_url \u003d \u002710.0.0.3/api\u0027"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        self.mock_object(api, \u0027LOG\u0027)"},{"line_number":286,"context_line":"        self.root._session \u003d fake.FAKE_HTTP_SESSION"}],"source_content_type":"text/x-python","patch_set":10,"id":"54f11a0e_1da66be5","line":283,"range":{"start_line":282,"start_character":8,"end_line":283,"end_character":38},"in_reply_to":"f976d2f3_0dea89be","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":339,"context_line":"    @ddt.data("},{"line_number":340,"context_line":"        {\u0027trace_enabled\u0027: False,"},{"line_number":341,"context_line":"         \u0027trace_pattern\u0027: \u0027(.*)\u0027,"},{"line_number":342,"context_line":"         \u0027log\u0027: False,"},{"line_number":343,"context_line":"         \u0027query\u0027: None,"},{"line_number":344,"context_line":"         \u0027body\u0027: {\u0027fake_key\u0027: \u0027fake_value\u0027}"},{"line_number":345,"context_line":"         },"},{"line_number":346,"context_line":"        {\u0027trace_enabled\u0027: True,"},{"line_number":347,"context_line":"         \u0027trace_pattern\u0027: \u0027(?!(volume)).*\u0027,"},{"line_number":348,"context_line":"         \u0027log\u0027: False,"},{"line_number":349,"context_line":"         \u0027query\u0027: None,"},{"line_number":350,"context_line":"         \u0027body\u0027: {\u0027fake_key\u0027: \u0027fake_value\u0027}"},{"line_number":351,"context_line":"         },"},{"line_number":352,"context_line":"        {\u0027trace_enabled\u0027: True,"},{"line_number":353,"context_line":"         \u0027trace_pattern\u0027: \u0027(.*)\u0027,"},{"line_number":354,"context_line":"         \u0027log\u0027: True,"},{"line_number":355,"context_line":"         \u0027query\u0027: {\u0027name\u0027: \u0027fake_name\u0027},"},{"line_number":356,"context_line":"         \u0027body\u0027: {\u0027fake_key\u0027: \u0027fake_value\u0027}"},{"line_number":357,"context_line":"         },"},{"line_number":358,"context_line":"        {\u0027trace_enabled\u0027: True,"},{"line_number":359,"context_line":"         \u0027trace_pattern\u0027: \u0027^volume-(info|get-iter)$\u0027,"},{"line_number":360,"context_line":"         \u0027log\u0027: True,"},{"line_number":361,"context_line":"         \u0027query\u0027: {\u0027type\u0027: \u0027fake_type\u0027},"},{"line_number":362,"context_line":"         \u0027body\u0027: {\u0027fake_key\u0027: \u0027fake_value\u0027}"},{"line_number":363,"context_line":"         }"},{"line_number":364,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":10,"id":"2311cf03_78771fb2","line":361,"range":{"start_line":342,"start_character":7,"end_line":361,"end_character":40},"updated":"2021-08-27 12:20:24.000000000","message":"use fake module to fake data","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":339,"context_line":"    @ddt.data("},{"line_number":340,"context_line":"        {\u0027trace_enabled\u0027: False,"},{"line_number":341,"context_line":"         \u0027trace_pattern\u0027: \u0027(.*)\u0027,"},{"line_number":342,"context_line":"         \u0027log\u0027: False,"},{"line_number":343,"context_line":"         \u0027query\u0027: None,"},{"line_number":344,"context_line":"         \u0027body\u0027: {\u0027fake_key\u0027: \u0027fake_value\u0027}"},{"line_number":345,"context_line":"         },"},{"line_number":346,"context_line":"        {\u0027trace_enabled\u0027: True,"},{"line_number":347,"context_line":"         \u0027trace_pattern\u0027: \u0027(?!(volume)).*\u0027,"},{"line_number":348,"context_line":"         \u0027log\u0027: False,"},{"line_number":349,"context_line":"         \u0027query\u0027: None,"},{"line_number":350,"context_line":"         \u0027body\u0027: {\u0027fake_key\u0027: \u0027fake_value\u0027}"},{"line_number":351,"context_line":"         },"},{"line_number":352,"context_line":"        {\u0027trace_enabled\u0027: True,"},{"line_number":353,"context_line":"         \u0027trace_pattern\u0027: \u0027(.*)\u0027,"},{"line_number":354,"context_line":"         \u0027log\u0027: True,"},{"line_number":355,"context_line":"         \u0027query\u0027: {\u0027name\u0027: \u0027fake_name\u0027},"},{"line_number":356,"context_line":"         \u0027body\u0027: {\u0027fake_key\u0027: \u0027fake_value\u0027}"},{"line_number":357,"context_line":"         },"},{"line_number":358,"context_line":"        {\u0027trace_enabled\u0027: True,"},{"line_number":359,"context_line":"         \u0027trace_pattern\u0027: \u0027^volume-(info|get-iter)$\u0027,"},{"line_number":360,"context_line":"         \u0027log\u0027: True,"},{"line_number":361,"context_line":"         \u0027query\u0027: {\u0027type\u0027: \u0027fake_type\u0027},"},{"line_number":362,"context_line":"         \u0027body\u0027: {\u0027fake_key\u0027: \u0027fake_value\u0027}"},{"line_number":363,"context_line":"         }"},{"line_number":364,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":10,"id":"84197ee2_8753a13f","line":361,"range":{"start_line":342,"start_character":7,"end_line":361,"end_character":40},"in_reply_to":"2311cf03_78771fb2","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":368,"context_line":"        \"\"\"Tests the method invoke_elem with valid parameters\"\"\""},{"line_number":369,"context_line":"        self.root._session \u003d fake.FAKE_HTTP_SESSION"},{"line_number":370,"context_line":"        response \u003d mock.Mock()"},{"line_number":371,"context_line":"        response.content \u003d \u0027fake_response\u0027"},{"line_number":372,"context_line":"        self.root._session.post \u003d mock.Mock(return_value\u003dresponse)"},{"line_number":373,"context_line":"        na_element \u003d fake.FAKE_NA_ELEMENT"},{"line_number":374,"context_line":"        element_name \u003d fake.FAKE_NA_ELEMENT.get_name()"}],"source_content_type":"text/x-python","patch_set":10,"id":"cf1fc5bf_9e460b71","line":371,"range":{"start_line":371,"start_character":9,"end_line":371,"end_character":42},"updated":"2021-08-27 12:20:24.000000000","message":"use fake module to fake data","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        \"\"\"Tests the method invoke_elem with valid parameters\"\"\""},{"line_number":369,"context_line":"        self.root._session \u003d fake.FAKE_HTTP_SESSION"},{"line_number":370,"context_line":"        response \u003d mock.Mock()"},{"line_number":371,"context_line":"        response.content \u003d \u0027fake_response\u0027"},{"line_number":372,"context_line":"        self.root._session.post \u003d mock.Mock(return_value\u003dresponse)"},{"line_number":373,"context_line":"        na_element \u003d fake.FAKE_NA_ELEMENT"},{"line_number":374,"context_line":"        element_name \u003d fake.FAKE_NA_ELEMENT.get_name()"}],"source_content_type":"text/x-python","patch_set":10,"id":"8708ba0a_0226b0a3","line":371,"range":{"start_line":371,"start_character":9,"end_line":371,"end_character":42},"in_reply_to":"cf1fc5bf_9e460b71","updated":"2021-08-28 21:57:50.000000000","message":"In this case I think we could keep it as is... It varies from scenario to scenario","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":374,"context_line":"        element_name \u003d fake.FAKE_NA_ELEMENT.get_name()"},{"line_number":375,"context_line":"        self.root._trace \u003d trace_enabled"},{"line_number":376,"context_line":"        self.root._api_trace_pattern \u003d trace_pattern"},{"line_number":377,"context_line":"        fake_base_url \u003d \u002710.0.0.3/api\u0027"},{"line_number":378,"context_line":"        fake_action_url \u003d \u0027/endpoint\u0027"},{"line_number":379,"context_line":"        expected_url \u003d fake_base_url + fake_action_url"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"        api_args \u003d {"}],"source_content_type":"text/x-python","patch_set":10,"id":"dd316430_16088b77","line":378,"range":{"start_line":377,"start_character":14,"end_line":378,"end_character":37},"updated":"2021-08-27 12:20:24.000000000","message":"use fake module to fake data","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        element_name \u003d fake.FAKE_NA_ELEMENT.get_name()"},{"line_number":375,"context_line":"        self.root._trace \u003d trace_enabled"},{"line_number":376,"context_line":"        self.root._api_trace_pattern \u003d trace_pattern"},{"line_number":377,"context_line":"        fake_base_url \u003d \u002710.0.0.3/api\u0027"},{"line_number":378,"context_line":"        fake_action_url \u003d \u0027/endpoint\u0027"},{"line_number":379,"context_line":"        expected_url \u003d fake_base_url + fake_action_url"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"        api_args \u003d {"}],"source_content_type":"text/x-python","patch_set":10,"id":"96927cc3_78903c9a","line":378,"range":{"start_line":377,"start_character":14,"end_line":378,"end_character":37},"in_reply_to":"dd316430_16088b77","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":412,"context_line":"        self.assertTrue(mock_get_base_url.called)"},{"line_number":413,"context_line":"        self.root._session.post.assert_called_once_with("},{"line_number":414,"context_line":"            expected_url, data\u003dbody)"},{"line_number":415,"context_line":"        mock_json_loads.assert_called_once_with(\u0027fake_response\u0027)"},{"line_number":416,"context_line":"        mock_json_dumps.assert_called_once_with(body)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"    @ddt.data("}],"source_content_type":"text/x-python","patch_set":10,"id":"b2acd9d7_75e5922c","line":415,"range":{"start_line":415,"start_character":49,"end_line":415,"end_character":62},"updated":"2021-08-27 12:20:24.000000000","message":"use fake module to fake data","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        self.assertTrue(mock_get_base_url.called)"},{"line_number":413,"context_line":"        self.root._session.post.assert_called_once_with("},{"line_number":414,"context_line":"            expected_url, data\u003dbody)"},{"line_number":415,"context_line":"        mock_json_loads.assert_called_once_with(\u0027fake_response\u0027)"},{"line_number":416,"context_line":"        mock_json_dumps.assert_called_once_with(body)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"    @ddt.data("}],"source_content_type":"text/x-python","patch_set":10,"id":"88f89900_0e484b4d","line":415,"range":{"start_line":415,"start_character":49,"end_line":415,"end_character":62},"in_reply_to":"b2acd9d7_75e5922c","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":454,"context_line":"        self.assertEqual(expected_result, base_url)"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    @ddt.data("},{"line_number":457,"context_line":"        {\"name\": \"name_to_be_queried\"},"},{"line_number":458,"context_line":"        {\"type\": \"type_to_be_queried\", \"name\": \"name_to_be_queried\"}"},{"line_number":459,"context_line":"    )"},{"line_number":460,"context_line":"    def test__add_query_params_to_url(self, query):"},{"line_number":461,"context_line":"        url \u003d \u0027endpoint/to/get/data\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"daa91d5c_1bd8baab","line":458,"range":{"start_line":457,"start_character":11,"end_line":458,"end_character":67},"updated":"2021-08-27 12:20:24.000000000","message":"use fake module to fake data","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":454,"context_line":"        self.assertEqual(expected_result, base_url)"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    @ddt.data("},{"line_number":457,"context_line":"        {\"name\": \"name_to_be_queried\"},"},{"line_number":458,"context_line":"        {\"type\": \"type_to_be_queried\", \"name\": \"name_to_be_queried\"}"},{"line_number":459,"context_line":"    )"},{"line_number":460,"context_line":"    def test__add_query_params_to_url(self, query):"},{"line_number":461,"context_line":"        url \u003d \u0027endpoint/to/get/data\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"a523742e_fe1bffd2","line":458,"range":{"start_line":457,"start_character":11,"end_line":458,"end_character":67},"in_reply_to":"daa91d5c_1bd8baab","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"}],"manila/tests/share/drivers/netapp/dataontap/client/test_client_cmode.py":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":8235,"context_line":"        self.assertTrue(result)"},{"line_number":8236,"context_line":""},{"line_number":8237,"context_line":"    @ddt.data("},{"line_number":8238,"context_line":"        {\"body\": {\"fake_body_key\": \"fake_value\"},"},{"line_number":8239,"context_line":"         \"headers\": {\"fake_header_key\": \"fake_header_value\"},"},{"line_number":8240,"context_line":"         \"query\": {},"},{"line_number":8241,"context_line":"         \"url_params\": {\"key_to_add_in_url\": \"value_to_add_in_url\"}"},{"line_number":8242,"context_line":"         },"},{"line_number":8243,"context_line":"        {\"body\": {},"},{"line_number":8244,"context_line":"         \"headers\": {\"fake_header_key\": \"fake_header_value\"},"},{"line_number":8245,"context_line":"         \"query\": {\"key_to_search\": \"value_to_search\"},"},{"line_number":8246,"context_line":"         \"url_params\": {\"key_to_add_in_url\": \"value_to_add_in_url\"}"},{"line_number":8247,"context_line":"         },"},{"line_number":8248,"context_line":"    )"},{"line_number":8249,"context_line":"    @ddt.unpack"},{"line_number":8250,"context_line":"    def test__format_request(self, body, headers, query, url_params):"}],"source_content_type":"text/x-python","patch_set":10,"id":"ce34103d_06b0a0b0","line":8247,"range":{"start_line":8238,"start_character":9,"end_line":8247,"end_character":11},"updated":"2021-08-27 12:20:24.000000000","message":"use fake module to fake data","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":8235,"context_line":"        self.assertTrue(result)"},{"line_number":8236,"context_line":""},{"line_number":8237,"context_line":"    @ddt.data("},{"line_number":8238,"context_line":"        {\"body\": {\"fake_body_key\": \"fake_value\"},"},{"line_number":8239,"context_line":"         \"headers\": {\"fake_header_key\": \"fake_header_value\"},"},{"line_number":8240,"context_line":"         \"query\": {},"},{"line_number":8241,"context_line":"         \"url_params\": {\"key_to_add_in_url\": \"value_to_add_in_url\"}"},{"line_number":8242,"context_line":"         },"},{"line_number":8243,"context_line":"        {\"body\": {},"},{"line_number":8244,"context_line":"         \"headers\": {\"fake_header_key\": \"fake_header_value\"},"},{"line_number":8245,"context_line":"         \"query\": {\"key_to_search\": \"value_to_search\"},"},{"line_number":8246,"context_line":"         \"url_params\": {\"key_to_add_in_url\": \"value_to_add_in_url\"}"},{"line_number":8247,"context_line":"         },"},{"line_number":8248,"context_line":"    )"},{"line_number":8249,"context_line":"    @ddt.unpack"},{"line_number":8250,"context_line":"    def test__format_request(self, body, headers, query, url_params):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a8991b2_0908c42c","line":8247,"range":{"start_line":8238,"start_character":9,"end_line":8247,"end_character":11},"in_reply_to":"ce34103d_06b0a0b0","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":8332,"context_line":"        )"},{"line_number":8333,"context_line":""},{"line_number":8334,"context_line":"    def test_svm_migrate_complete(self):"},{"line_number":8335,"context_line":"        migration_id \u003d \u0027fake_migration_id\u0027"},{"line_number":8336,"context_line":"        request \u003d {"},{"line_number":8337,"context_line":"            \u0027action\u0027: \u0027cutover\u0027"},{"line_number":8338,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":10,"id":"2f14d099_603aa8c8","line":8335,"range":{"start_line":8335,"start_character":9,"end_line":8335,"end_character":42},"updated":"2021-08-27 12:20:24.000000000","message":"use fake module to fake data","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":8332,"context_line":"        )"},{"line_number":8333,"context_line":""},{"line_number":8334,"context_line":"    def test_svm_migrate_complete(self):"},{"line_number":8335,"context_line":"        migration_id \u003d \u0027fake_migration_id\u0027"},{"line_number":8336,"context_line":"        request \u003d {"},{"line_number":8337,"context_line":"            \u0027action\u0027: \u0027cutover\u0027"},{"line_number":8338,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":10,"id":"126aeebc_4074a104","line":8335,"range":{"start_line":8335,"start_character":9,"end_line":8335,"end_character":42},"in_reply_to":"2f14d099_603aa8c8","updated":"2021-08-28 21:57:50.000000000","message":"In this case, it\u0027s just an expected migration id, not a default response from ONTAP, so perhaps I could keep it as is...","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":8356,"context_line":"            \u0027svm-migration-complete\u0027, api_args\u003drequest, use_zapi\u003dFalse)"},{"line_number":8357,"context_line":""},{"line_number":8358,"context_line":"    def test_get_job(self):"},{"line_number":8359,"context_line":"        request \u003d {}"},{"line_number":8360,"context_line":"        job_uuid \u003d \u0027fake_job_uuid\u0027"},{"line_number":8361,"context_line":"        url_params \u003d {"},{"line_number":8362,"context_line":"            \u0027job_uuid\u0027: job_uuid"},{"line_number":8363,"context_line":"        }"},{"line_number":8364,"context_line":"        job_info \u003d {"},{"line_number":8365,"context_line":"            \u0027state\u0027: \u0027success\u0027"},{"line_number":8366,"context_line":"        }"},{"line_number":8367,"context_line":""},{"line_number":8368,"context_line":"        self.mock_object(self.client, \u0027_format_request\u0027,"},{"line_number":8369,"context_line":"                         mock.Mock(return_value\u003drequest))"}],"source_content_type":"text/x-python","patch_set":10,"id":"e4248e1d_594701d4","line":8366,"range":{"start_line":8359,"start_character":8,"end_line":8366,"end_character":9},"updated":"2021-08-27 12:20:24.000000000","message":"use fake module to fake data","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":8356,"context_line":"            \u0027svm-migration-complete\u0027, api_args\u003drequest, use_zapi\u003dFalse)"},{"line_number":8357,"context_line":""},{"line_number":8358,"context_line":"    def test_get_job(self):"},{"line_number":8359,"context_line":"        request \u003d {}"},{"line_number":8360,"context_line":"        job_uuid \u003d \u0027fake_job_uuid\u0027"},{"line_number":8361,"context_line":"        url_params \u003d {"},{"line_number":8362,"context_line":"            \u0027job_uuid\u0027: job_uuid"},{"line_number":8363,"context_line":"        }"},{"line_number":8364,"context_line":"        job_info \u003d {"},{"line_number":8365,"context_line":"            \u0027state\u0027: \u0027success\u0027"},{"line_number":8366,"context_line":"        }"},{"line_number":8367,"context_line":""},{"line_number":8368,"context_line":"        self.mock_object(self.client, \u0027_format_request\u0027,"},{"line_number":8369,"context_line":"                         mock.Mock(return_value\u003drequest))"}],"source_content_type":"text/x-python","patch_set":10,"id":"89e40efb_db71050d","line":8366,"range":{"start_line":8359,"start_character":8,"end_line":8366,"end_character":9},"in_reply_to":"e4248e1d_594701d4","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":8379,"context_line":"            \u0027get-job\u0027, api_args\u003drequest, use_zapi\u003dFalse)"},{"line_number":8380,"context_line":""},{"line_number":8381,"context_line":"    def test_svm_migrate_cancel(self):"},{"line_number":8382,"context_line":"        request \u003d {}"},{"line_number":8383,"context_line":"        migration_id \u003d \u0027fake_migration_uuid\u0027"},{"line_number":8384,"context_line":"        url_params \u003d {"},{"line_number":8385,"context_line":"            \"svm_migration_id\": migration_id"},{"line_number":8386,"context_line":"        }"},{"line_number":8387,"context_line":"        job_info \u003d {"},{"line_number":8388,"context_line":"            \u0027state\u0027: \u0027success\u0027"},{"line_number":8389,"context_line":"        }"},{"line_number":8390,"context_line":""},{"line_number":8391,"context_line":"        self.mock_object(self.client, \u0027_format_request\u0027,"},{"line_number":8392,"context_line":"                         mock.Mock(return_value\u003drequest))"}],"source_content_type":"text/x-python","patch_set":10,"id":"54472f92_02ec3d02","line":8389,"range":{"start_line":8382,"start_character":9,"end_line":8389,"end_character":9},"updated":"2021-08-27 12:20:24.000000000","message":"use fake module to fake data","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":8379,"context_line":"            \u0027get-job\u0027, api_args\u003drequest, use_zapi\u003dFalse)"},{"line_number":8380,"context_line":""},{"line_number":8381,"context_line":"    def test_svm_migrate_cancel(self):"},{"line_number":8382,"context_line":"        request \u003d {}"},{"line_number":8383,"context_line":"        migration_id \u003d \u0027fake_migration_uuid\u0027"},{"line_number":8384,"context_line":"        url_params \u003d {"},{"line_number":8385,"context_line":"            \"svm_migration_id\": migration_id"},{"line_number":8386,"context_line":"        }"},{"line_number":8387,"context_line":"        job_info \u003d {"},{"line_number":8388,"context_line":"            \u0027state\u0027: \u0027success\u0027"},{"line_number":8389,"context_line":"        }"},{"line_number":8390,"context_line":""},{"line_number":8391,"context_line":"        self.mock_object(self.client, \u0027_format_request\u0027,"},{"line_number":8392,"context_line":"                         mock.Mock(return_value\u003drequest))"}],"source_content_type":"text/x-python","patch_set":10,"id":"d75e1b3e_7d9f6023","line":8389,"range":{"start_line":8382,"start_character":9,"end_line":8389,"end_character":9},"in_reply_to":"54472f92_02ec3d02","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":8402,"context_line":"            \u0027svm-migration-cancel\u0027, api_args\u003drequest, use_zapi\u003dFalse)"},{"line_number":8403,"context_line":""},{"line_number":8404,"context_line":"    def test_svm_migration_get(self):"},{"line_number":8405,"context_line":"        request \u003d {}"},{"line_number":8406,"context_line":"        migration_id \u003d \u0027fake_migration_uuid\u0027"},{"line_number":8407,"context_line":"        url_params \u003d {"},{"line_number":8408,"context_line":"            \"svm_migration_id\": migration_id"},{"line_number":8409,"context_line":"        }"},{"line_number":8410,"context_line":"        job_info \u003d {"},{"line_number":8411,"context_line":"            \u0027state\u0027: \u0027success\u0027"},{"line_number":8412,"context_line":"        }"},{"line_number":8413,"context_line":""},{"line_number":8414,"context_line":"        self.mock_object(self.client, \u0027_format_request\u0027,"},{"line_number":8415,"context_line":"                         mock.Mock(return_value\u003drequest))"}],"source_content_type":"text/x-python","patch_set":10,"id":"cfd38a58_4d34552f","line":8412,"range":{"start_line":8405,"start_character":8,"end_line":8412,"end_character":9},"updated":"2021-08-27 12:20:24.000000000","message":"use fake module to fake data","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":8402,"context_line":"            \u0027svm-migration-cancel\u0027, api_args\u003drequest, use_zapi\u003dFalse)"},{"line_number":8403,"context_line":""},{"line_number":8404,"context_line":"    def test_svm_migration_get(self):"},{"line_number":8405,"context_line":"        request \u003d {}"},{"line_number":8406,"context_line":"        migration_id \u003d \u0027fake_migration_uuid\u0027"},{"line_number":8407,"context_line":"        url_params \u003d {"},{"line_number":8408,"context_line":"            \"svm_migration_id\": migration_id"},{"line_number":8409,"context_line":"        }"},{"line_number":8410,"context_line":"        job_info \u003d {"},{"line_number":8411,"context_line":"            \u0027state\u0027: \u0027success\u0027"},{"line_number":8412,"context_line":"        }"},{"line_number":8413,"context_line":""},{"line_number":8414,"context_line":"        self.mock_object(self.client, \u0027_format_request\u0027,"},{"line_number":8415,"context_line":"                         mock.Mock(return_value\u003drequest))"}],"source_content_type":"text/x-python","patch_set":10,"id":"82d1621d_15ec5942","line":8412,"range":{"start_line":8405,"start_character":8,"end_line":8412,"end_character":9},"in_reply_to":"cfd38a58_4d34552f","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":8425,"context_line":"            \u0027svm-migration-get\u0027, api_args\u003drequest, use_zapi\u003dFalse)"},{"line_number":8426,"context_line":""},{"line_number":8427,"context_line":"    def test_svm_migrate_pause(self):"},{"line_number":8428,"context_line":"        request \u003d {"},{"line_number":8429,"context_line":"            \"action\": \"pause\""},{"line_number":8430,"context_line":"        }"},{"line_number":8431,"context_line":"        migration_id \u003d \u0027fake_migration_uuid\u0027"},{"line_number":8432,"context_line":"        url_params \u003d {"},{"line_number":8433,"context_line":"            \"svm_migration_id\": migration_id"},{"line_number":8434,"context_line":"        }"},{"line_number":8435,"context_line":"        job_info \u003d {"},{"line_number":8436,"context_line":"            \u0027state\u0027: \u0027success\u0027"},{"line_number":8437,"context_line":"        }"},{"line_number":8438,"context_line":""},{"line_number":8439,"context_line":"        self.mock_object(self.client, \u0027_format_request\u0027,"},{"line_number":8440,"context_line":"                         mock.Mock(return_value\u003drequest))"}],"source_content_type":"text/x-python","patch_set":10,"id":"d1a23060_3ac639cd","line":8437,"range":{"start_line":8428,"start_character":7,"end_line":8437,"end_character":9},"updated":"2021-08-27 12:20:24.000000000","message":"use fake module to fake data","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":8425,"context_line":"            \u0027svm-migration-get\u0027, api_args\u003drequest, use_zapi\u003dFalse)"},{"line_number":8426,"context_line":""},{"line_number":8427,"context_line":"    def test_svm_migrate_pause(self):"},{"line_number":8428,"context_line":"        request \u003d {"},{"line_number":8429,"context_line":"            \"action\": \"pause\""},{"line_number":8430,"context_line":"        }"},{"line_number":8431,"context_line":"        migration_id \u003d \u0027fake_migration_uuid\u0027"},{"line_number":8432,"context_line":"        url_params \u003d {"},{"line_number":8433,"context_line":"            \"svm_migration_id\": migration_id"},{"line_number":8434,"context_line":"        }"},{"line_number":8435,"context_line":"        job_info \u003d {"},{"line_number":8436,"context_line":"            \u0027state\u0027: \u0027success\u0027"},{"line_number":8437,"context_line":"        }"},{"line_number":8438,"context_line":""},{"line_number":8439,"context_line":"        self.mock_object(self.client, \u0027_format_request\u0027,"},{"line_number":8440,"context_line":"                         mock.Mock(return_value\u003drequest))"}],"source_content_type":"text/x-python","patch_set":10,"id":"6ec344cf_b7ad7627","line":8437,"range":{"start_line":8428,"start_character":7,"end_line":8437,"end_character":9},"in_reply_to":"d1a23060_3ac639cd","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":8450,"context_line":"            \u0027svm-migration-pause\u0027, api_args\u003drequest, use_zapi\u003dFalse)"},{"line_number":8451,"context_line":""},{"line_number":8452,"context_line":"    def test_migration_check_job_state(self):"},{"line_number":8453,"context_line":"        job_id \u003d \u0027job_id\u0027"},{"line_number":8454,"context_line":"        fake_job \u003d {"},{"line_number":8455,"context_line":"            \"state\": \"success\""},{"line_number":8456,"context_line":"        }"},{"line_number":8457,"context_line":"        self.mock_object(self.client, \u0027get_job\u0027,"},{"line_number":8458,"context_line":"                         mock.Mock(return_value\u003dfake_job))"},{"line_number":8459,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"856fdfcf_beea47a7","line":8456,"range":{"start_line":8453,"start_character":8,"end_line":8456,"end_character":9},"updated":"2021-08-27 12:20:24.000000000","message":"use fake module to fake data","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":8450,"context_line":"            \u0027svm-migration-pause\u0027, api_args\u003drequest, use_zapi\u003dFalse)"},{"line_number":8451,"context_line":""},{"line_number":8452,"context_line":"    def test_migration_check_job_state(self):"},{"line_number":8453,"context_line":"        job_id \u003d \u0027job_id\u0027"},{"line_number":8454,"context_line":"        fake_job \u003d {"},{"line_number":8455,"context_line":"            \"state\": \"success\""},{"line_number":8456,"context_line":"        }"},{"line_number":8457,"context_line":"        self.mock_object(self.client, \u0027get_job\u0027,"},{"line_number":8458,"context_line":"                         mock.Mock(return_value\u003dfake_job))"},{"line_number":8459,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ff2591eb_c7e7379c","line":8456,"range":{"start_line":8453,"start_character":8,"end_line":8456,"end_character":9},"in_reply_to":"856fdfcf_beea47a7","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":8467,"context_line":"    @ddt.data(netapp_api.ENFS_V4_0_ENABLED_MIGRATION_FAILURE,"},{"line_number":8468,"context_line":"              netapp_api.EVSERVER_MIGRATION_TO_NON_AFF_CLUSTER)"},{"line_number":8469,"context_line":"    def test_migration_check_job_state_failed(self, error_code):"},{"line_number":8470,"context_line":"        job_id \u003d \u0027job_id\u0027"},{"line_number":8471,"context_line":""},{"line_number":8472,"context_line":"        self.mock_object("},{"line_number":8473,"context_line":"            self.client, \u0027get_job\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"add21106_e15155d8","line":8470,"range":{"start_line":8470,"start_character":8,"end_line":8470,"end_character":25},"updated":"2021-08-27 12:20:24.000000000","message":"use fake module to fake data","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":8467,"context_line":"    @ddt.data(netapp_api.ENFS_V4_0_ENABLED_MIGRATION_FAILURE,"},{"line_number":8468,"context_line":"              netapp_api.EVSERVER_MIGRATION_TO_NON_AFF_CLUSTER)"},{"line_number":8469,"context_line":"    def test_migration_check_job_state_failed(self, error_code):"},{"line_number":8470,"context_line":"        job_id \u003d \u0027job_id\u0027"},{"line_number":8471,"context_line":""},{"line_number":8472,"context_line":"        self.mock_object("},{"line_number":8473,"context_line":"            self.client, \u0027get_job\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"8aea81f5_18bc175f","line":8470,"range":{"start_line":8470,"start_character":8,"end_line":8470,"end_character":25},"in_reply_to":"add21106_e15155d8","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"}],"manila/tests/share/drivers/netapp/dataontap/cluster_mode/test_lib_base.py":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":1880,"context_line":"        vserver_client.offline_volume.assert_called_with(fake.SHARE_NAME)"},{"line_number":1881,"context_line":"        vserver_client.delete_volume.assert_called_with(fake.SHARE_NAME)"},{"line_number":1882,"context_line":""},{"line_number":1883,"context_line":"    @ddt.data(None, \u0027host@backend#pool\u0027)"},{"line_number":1884,"context_line":"    def test_create_export(self, share_host):"},{"line_number":1885,"context_line":""},{"line_number":1886,"context_line":"        protocol_helper \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":10,"id":"6e9bc56e_288a9695","line":1883,"range":{"start_line":1883,"start_character":21,"end_line":1883,"end_character":38},"updated":"2021-08-27 12:20:24.000000000","message":"use fake module to fake data","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":1880,"context_line":"        vserver_client.offline_volume.assert_called_with(fake.SHARE_NAME)"},{"line_number":1881,"context_line":"        vserver_client.delete_volume.assert_called_with(fake.SHARE_NAME)"},{"line_number":1882,"context_line":""},{"line_number":1883,"context_line":"    @ddt.data(None, \u0027host@backend#pool\u0027)"},{"line_number":1884,"context_line":"    def test_create_export(self, share_host):"},{"line_number":1885,"context_line":""},{"line_number":1886,"context_line":"        protocol_helper \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":10,"id":"58f62d68_ed32ca2a","line":1883,"range":{"start_line":1883,"start_character":21,"end_line":1883,"end_character":38},"in_reply_to":"6e9bc56e_288a9695","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"}],"manila/tests/share/drivers/netapp/dataontap/cluster_mode/test_lib_multi_svm.py":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":2014,"context_line":"    @ddt.unpack"},{"line_number":2015,"context_line":"    def test__check_compatibility_for_svm_migrate(self, expected_exception,"},{"line_number":2016,"context_line":"                                                  expected_compatibility):"},{"line_number":2017,"context_line":"        fake_id \u003d \u0027fake_job_id\u0027"},{"line_number":2018,"context_line":"        fake_job \u003d {"},{"line_number":2019,"context_line":"            \"job\": {"},{"line_number":2020,"context_line":"                \"uuid\": fake_id,"},{"line_number":2021,"context_line":"                \"description\": \"fake_description\","},{"line_number":2022,"context_line":"                \"state\": \"success\""},{"line_number":2023,"context_line":"            }"},{"line_number":2024,"context_line":"        }"},{"line_number":2025,"context_line":""},{"line_number":2026,"context_line":"        mock_timer \u003d mock.Mock()"},{"line_number":2027,"context_line":"        self.mock_object(self.mock_dest_client, \u0027svm_migration_start\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9b9844e5_395580f2","line":2024,"range":{"start_line":2017,"start_character":8,"end_line":2024,"end_character":9},"updated":"2021-08-27 12:20:24.000000000","message":"use fake module to fake data","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":2014,"context_line":"    @ddt.unpack"},{"line_number":2015,"context_line":"    def test__check_compatibility_for_svm_migrate(self, expected_exception,"},{"line_number":2016,"context_line":"                                                  expected_compatibility):"},{"line_number":2017,"context_line":"        fake_id \u003d \u0027fake_job_id\u0027"},{"line_number":2018,"context_line":"        fake_job \u003d {"},{"line_number":2019,"context_line":"            \"job\": {"},{"line_number":2020,"context_line":"                \"uuid\": fake_id,"},{"line_number":2021,"context_line":"                \"description\": \"fake_description\","},{"line_number":2022,"context_line":"                \"state\": \"success\""},{"line_number":2023,"context_line":"            }"},{"line_number":2024,"context_line":"        }"},{"line_number":2025,"context_line":""},{"line_number":2026,"context_line":"        mock_timer \u003d mock.Mock()"},{"line_number":2027,"context_line":"        self.mock_object(self.mock_dest_client, \u0027svm_migration_start\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"749f91e9_88a14ba4","line":2024,"range":{"start_line":2017,"start_character":8,"end_line":2024,"end_character":9},"in_reply_to":"9b9844e5_395580f2","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":2046,"context_line":"            True, loopingcall.FixedIntervalWithTimeoutLoopingCall.called)"},{"line_number":2047,"context_line":""},{"line_number":2048,"context_line":"    def test__check_compatibility_for_svm_migrate_timeout(self):"},{"line_number":2049,"context_line":"        fake_id \u003d \u0027fake_job_id\u0027"},{"line_number":2050,"context_line":"        fake_job \u003d {"},{"line_number":2051,"context_line":"            \"job\": {"},{"line_number":2052,"context_line":"                \"uuid\": fake_id,"},{"line_number":2053,"context_line":"                \"description\": \"fake_description\","},{"line_number":2054,"context_line":"                \"state\": \"success\""},{"line_number":2055,"context_line":"            }"},{"line_number":2056,"context_line":"        }"},{"line_number":2057,"context_line":""},{"line_number":2058,"context_line":"        mock_timer \u003d mock.Mock()"},{"line_number":2059,"context_line":"        self.mock_object(self.mock_dest_client, \u0027svm_migration_start\u0027,"},{"line_number":2060,"context_line":"                         mock.Mock(return_value\u003dfake_job))"}],"source_content_type":"text/x-python","patch_set":10,"id":"6516124b_43e98fd2","line":2057,"range":{"start_line":2049,"start_character":6,"end_line":2057,"end_character":0},"updated":"2021-08-27 12:20:24.000000000","message":"use fake module to fake data","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":2046,"context_line":"            True, loopingcall.FixedIntervalWithTimeoutLoopingCall.called)"},{"line_number":2047,"context_line":""},{"line_number":2048,"context_line":"    def test__check_compatibility_for_svm_migrate_timeout(self):"},{"line_number":2049,"context_line":"        fake_id \u003d \u0027fake_job_id\u0027"},{"line_number":2050,"context_line":"        fake_job \u003d {"},{"line_number":2051,"context_line":"            \"job\": {"},{"line_number":2052,"context_line":"                \"uuid\": fake_id,"},{"line_number":2053,"context_line":"                \"description\": \"fake_description\","},{"line_number":2054,"context_line":"                \"state\": \"success\""},{"line_number":2055,"context_line":"            }"},{"line_number":2056,"context_line":"        }"},{"line_number":2057,"context_line":""},{"line_number":2058,"context_line":"        mock_timer \u003d mock.Mock()"},{"line_number":2059,"context_line":"        self.mock_object(self.mock_dest_client, \u0027svm_migration_start\u0027,"},{"line_number":2060,"context_line":"                         mock.Mock(return_value\u003dfake_job))"}],"source_content_type":"text/x-python","patch_set":10,"id":"6dec2e43_d45d21c1","line":2057,"range":{"start_line":2049,"start_character":6,"end_line":2057,"end_character":0},"in_reply_to":"6516124b_43e98fd2","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":2112,"context_line":"        )"},{"line_number":2113,"context_line":""},{"line_number":2114,"context_line":"    def test__get_job_uuid(self):"},{"line_number":2115,"context_line":"        fake_uuid \u003d \u0027fake_uuid\u0027"},{"line_number":2116,"context_line":"        fake_job \u003d {"},{"line_number":2117,"context_line":"            \"job\": {"},{"line_number":2118,"context_line":"                \"uuid\": fake_uuid,"},{"line_number":2119,"context_line":"                \"description\": \"fake_description\""},{"line_number":2120,"context_line":"            }"},{"line_number":2121,"context_line":"        }"},{"line_number":2122,"context_line":"        self.assertEqual("},{"line_number":2123,"context_line":"            self.library._get_job_uuid(fake_job),"},{"line_number":2124,"context_line":"            fake_uuid"}],"source_content_type":"text/x-python","patch_set":10,"id":"ac89d5cb_953604a8","line":2121,"range":{"start_line":2115,"start_character":8,"end_line":2121,"end_character":9},"updated":"2021-08-27 12:20:24.000000000","message":"use fake module to fake data","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":2112,"context_line":"        )"},{"line_number":2113,"context_line":""},{"line_number":2114,"context_line":"    def test__get_job_uuid(self):"},{"line_number":2115,"context_line":"        fake_uuid \u003d \u0027fake_uuid\u0027"},{"line_number":2116,"context_line":"        fake_job \u003d {"},{"line_number":2117,"context_line":"            \"job\": {"},{"line_number":2118,"context_line":"                \"uuid\": fake_uuid,"},{"line_number":2119,"context_line":"                \"description\": \"fake_description\""},{"line_number":2120,"context_line":"            }"},{"line_number":2121,"context_line":"        }"},{"line_number":2122,"context_line":"        self.assertEqual("},{"line_number":2123,"context_line":"            self.library._get_job_uuid(fake_job),"},{"line_number":2124,"context_line":"            fake_uuid"}],"source_content_type":"text/x-python","patch_set":10,"id":"ed6f8849_537b95b9","line":2121,"range":{"start_line":2115,"start_character":8,"end_line":2121,"end_character":9},"in_reply_to":"ac89d5cb_953604a8","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":2125,"context_line":"        )"},{"line_number":2126,"context_line":""},{"line_number":2127,"context_line":"    def test__wait_for_operation_status(self):"},{"line_number":2128,"context_line":"        fake_job_id \u003d \u0027fake_job_id\u0027"},{"line_number":2129,"context_line":"        returned_jobs \u003d ["},{"line_number":2130,"context_line":"            {\u0027status\u0027: \u0027fake_status_1\u0027},"},{"line_number":2131,"context_line":"            {\u0027status\u0027: \u0027fake_status_2\u0027},"},{"line_number":2132,"context_line":"            {\u0027status\u0027: \u0027success\u0027},"},{"line_number":2133,"context_line":"        ]"},{"line_number":2134,"context_line":""},{"line_number":2135,"context_line":"        self.mock_object(self.mock_dest_client, \u0027get_job\u0027,"},{"line_number":2136,"context_line":"                         mock.Mock(side_effect\u003dreturned_jobs))"},{"line_number":2137,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ee0d8da6_0388c7ea","line":2134,"range":{"start_line":2128,"start_character":7,"end_line":2134,"end_character":0},"updated":"2021-08-27 12:20:24.000000000","message":"use fake module to fake data","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":2125,"context_line":"        )"},{"line_number":2126,"context_line":""},{"line_number":2127,"context_line":"    def test__wait_for_operation_status(self):"},{"line_number":2128,"context_line":"        fake_job_id \u003d \u0027fake_job_id\u0027"},{"line_number":2129,"context_line":"        returned_jobs \u003d ["},{"line_number":2130,"context_line":"            {\u0027status\u0027: \u0027fake_status_1\u0027},"},{"line_number":2131,"context_line":"            {\u0027status\u0027: \u0027fake_status_2\u0027},"},{"line_number":2132,"context_line":"            {\u0027status\u0027: \u0027success\u0027},"},{"line_number":2133,"context_line":"        ]"},{"line_number":2134,"context_line":""},{"line_number":2135,"context_line":"        self.mock_object(self.mock_dest_client, \u0027get_job\u0027,"},{"line_number":2136,"context_line":"                         mock.Mock(side_effect\u003dreturned_jobs))"},{"line_number":2137,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"83574d9c_404e5c2d","line":2134,"range":{"start_line":2128,"start_character":7,"end_line":2134,"end_character":0},"in_reply_to":"ee0d8da6_0388c7ea","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":2142,"context_line":"        self.assertEqual(self.mock_dest_client.get_job.call_count, 3)"},{"line_number":2143,"context_line":""},{"line_number":2144,"context_line":"    def test__wait_for_operation_status_error(self):"},{"line_number":2145,"context_line":"        fake_job_id \u003d \u0027fake_job_id\u0027"},{"line_number":2146,"context_line":"        returned_jobs \u003d ["},{"line_number":2147,"context_line":"            {\u0027status\u0027: \u0027fake_status_1\u0027},"},{"line_number":2148,"context_line":"            {\u0027status\u0027: \u0027fake_status_2\u0027},"},{"line_number":2149,"context_line":"            {\u0027status\u0027: \u0027error\u0027, \u0027message\u0027: \u0027failure\u0027},"},{"line_number":2150,"context_line":"        ]"},{"line_number":2151,"context_line":""},{"line_number":2152,"context_line":"        self.mock_object(self.mock_dest_client, \u0027get_job\u0027,"},{"line_number":2153,"context_line":"                         mock.Mock(side_effect\u003dreturned_jobs))"}],"source_content_type":"text/x-python","patch_set":10,"id":"eedbb49f_cfee848a","line":2150,"range":{"start_line":2145,"start_character":8,"end_line":2150,"end_character":9},"updated":"2021-08-27 12:20:24.000000000","message":"use fake module to fake data","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":2142,"context_line":"        self.assertEqual(self.mock_dest_client.get_job.call_count, 3)"},{"line_number":2143,"context_line":""},{"line_number":2144,"context_line":"    def test__wait_for_operation_status_error(self):"},{"line_number":2145,"context_line":"        fake_job_id \u003d \u0027fake_job_id\u0027"},{"line_number":2146,"context_line":"        returned_jobs \u003d ["},{"line_number":2147,"context_line":"            {\u0027status\u0027: \u0027fake_status_1\u0027},"},{"line_number":2148,"context_line":"            {\u0027status\u0027: \u0027fake_status_2\u0027},"},{"line_number":2149,"context_line":"            {\u0027status\u0027: \u0027error\u0027, \u0027message\u0027: \u0027failure\u0027},"},{"line_number":2150,"context_line":"        ]"},{"line_number":2151,"context_line":""},{"line_number":2152,"context_line":"        self.mock_object(self.mock_dest_client, \u0027get_job\u0027,"},{"line_number":2153,"context_line":"                         mock.Mock(side_effect\u003dreturned_jobs))"}],"source_content_type":"text/x-python","patch_set":10,"id":"7657ad6f_0676f192","line":2150,"range":{"start_line":2145,"start_character":8,"end_line":2150,"end_character":9},"in_reply_to":"eedbb49f_cfee848a","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":2308,"context_line":"    def test__migration_start_using_svm_migrate("},{"line_number":2309,"context_line":"            self, network_change_during_migration, source_cleanup):"},{"line_number":2310,"context_line":""},{"line_number":2311,"context_line":"        self.fake_src_share_server[\u0027share_network_subnet_id\u0027] \u003d \u0027fake_sns_id\u0027"},{"line_number":2312,"context_line":"        self.fake_dest_share_server[\u0027share_network_subnet_id\u0027] \u003d \u0027fake_sns_id\u0027"},{"line_number":2313,"context_line":"        node_name \u003d fake.CLUSTER_NODES[0]"},{"line_number":2314,"context_line":"        fake_migration_id \u003d \u0027fake_migration_id\u0027"},{"line_number":2315,"context_line":"        fake_job_id \u003d \u0027fake_job_id\u0027"},{"line_number":2316,"context_line":"        migration_job \u003d {"},{"line_number":2317,"context_line":"            \u0027job\u0027: {\u0027uuid\u0027: fake_job_id}"},{"line_number":2318,"context_line":"        }"},{"line_number":2319,"context_line":"        expected_server_info \u003d {"},{"line_number":2320,"context_line":"            \u0027backend_details\u0027: {"},{"line_number":2321,"context_line":"                \u0027migration_operation_id\u0027: fake_migration_id"},{"line_number":2322,"context_line":"            }"},{"line_number":2323,"context_line":"        }"},{"line_number":2324,"context_line":"        fake_job \u003d {"},{"line_number":2325,"context_line":"            \"description\": \"POST /api/endpoint/%s\" % fake_migration_id"},{"line_number":2326,"context_line":"        }"},{"line_number":2327,"context_line":""},{"line_number":2328,"context_line":"        server_to_get_network_info \u003d ("},{"line_number":2329,"context_line":"            self.fake_dest_share_server"}],"source_content_type":"text/x-python","patch_set":10,"id":"65fc415e_d9ac6fc8","line":2326,"range":{"start_line":2311,"start_character":0,"end_line":2326,"end_character":9},"updated":"2021-08-27 12:20:24.000000000","message":"use fake module to fake data","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":2308,"context_line":"    def test__migration_start_using_svm_migrate("},{"line_number":2309,"context_line":"            self, network_change_during_migration, source_cleanup):"},{"line_number":2310,"context_line":""},{"line_number":2311,"context_line":"        self.fake_src_share_server[\u0027share_network_subnet_id\u0027] \u003d \u0027fake_sns_id\u0027"},{"line_number":2312,"context_line":"        self.fake_dest_share_server[\u0027share_network_subnet_id\u0027] \u003d \u0027fake_sns_id\u0027"},{"line_number":2313,"context_line":"        node_name \u003d fake.CLUSTER_NODES[0]"},{"line_number":2314,"context_line":"        fake_migration_id \u003d \u0027fake_migration_id\u0027"},{"line_number":2315,"context_line":"        fake_job_id \u003d \u0027fake_job_id\u0027"},{"line_number":2316,"context_line":"        migration_job \u003d {"},{"line_number":2317,"context_line":"            \u0027job\u0027: {\u0027uuid\u0027: fake_job_id}"},{"line_number":2318,"context_line":"        }"},{"line_number":2319,"context_line":"        expected_server_info \u003d {"},{"line_number":2320,"context_line":"            \u0027backend_details\u0027: {"},{"line_number":2321,"context_line":"                \u0027migration_operation_id\u0027: fake_migration_id"},{"line_number":2322,"context_line":"            }"},{"line_number":2323,"context_line":"        }"},{"line_number":2324,"context_line":"        fake_job \u003d {"},{"line_number":2325,"context_line":"            \"description\": \"POST /api/endpoint/%s\" % fake_migration_id"},{"line_number":2326,"context_line":"        }"},{"line_number":2327,"context_line":""},{"line_number":2328,"context_line":"        server_to_get_network_info \u003d ("},{"line_number":2329,"context_line":"            self.fake_dest_share_server"}],"source_content_type":"text/x-python","patch_set":10,"id":"658d0056_a1c2986a","line":2326,"range":{"start_line":2311,"start_character":0,"end_line":2326,"end_character":9},"in_reply_to":"65fc415e_d9ac6fc8","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":2401,"context_line":"        mock_get_job.assert_called_once_with(fake_job_id)"},{"line_number":2402,"context_line":""},{"line_number":2403,"context_line":"    def test__migration_start_using_svm_migrate_exception(self):"},{"line_number":2404,"context_line":""},{"line_number":2405,"context_line":"        self.fake_src_share_server[\u0027share_network_subnet_id\u0027] \u003d \u0027fake_sns_id\u0027"},{"line_number":2406,"context_line":"        self.fake_dest_share_server[\u0027share_network_subnet_id\u0027] \u003d \u0027fake_sns_id\u0027"},{"line_number":2407,"context_line":"        node_name \u003d fake.CLUSTER_NODES[0]"},{"line_number":2408,"context_line":""},{"line_number":2409,"context_line":"        server_to_get_network_info \u003d self.fake_src_share_server"},{"line_number":2410,"context_line":""},{"line_number":2411,"context_line":"        segmentation_id \u003d ("},{"line_number":2412,"context_line":"            server_to_get_network_info[\u0027network_allocations\u0027][0]["},{"line_number":2413,"context_line":"                \u0027segmentation_id\u0027])"},{"line_number":2414,"context_line":""},{"line_number":2415,"context_line":"        network_info \u003d {"},{"line_number":2416,"context_line":"            \u0027network_allocations\u0027:"},{"line_number":2417,"context_line":"                server_to_get_network_info[\u0027network_allocations\u0027],"},{"line_number":2418,"context_line":"            \u0027neutron_subnet_id\u0027:"},{"line_number":2419,"context_line":"                server_to_get_network_info[\u0027share_network_subnet\u0027]["},{"line_number":2420,"context_line":"                    \u0027neutron_subnet_id\u0027]"},{"line_number":2421,"context_line":"        }"},{"line_number":2422,"context_line":"        ipspaces \u003d ["},{"line_number":2423,"context_line":"            {\u0027uuid\u0027: fake.IPSPACE_ID,"},{"line_number":2424,"context_line":"             \u0027ipspace\u0027: fake.IPSPACE}"},{"line_number":2425,"context_line":"        ]"},{"line_number":2426,"context_line":""},{"line_number":2427,"context_line":"        mock_list_cluster_nodes \u003d self.mock_object("},{"line_number":2428,"context_line":"            self.library._client, \u0027list_cluster_nodes\u0027,"},{"line_number":2429,"context_line":"            mock.Mock(return_value\u003dfake.CLUSTER_NODES))"}],"source_content_type":"text/x-python","patch_set":10,"id":"52ce055f_d4247e1e","line":2426,"range":{"start_line":2404,"start_character":0,"end_line":2426,"end_character":0},"updated":"2021-08-27 12:20:24.000000000","message":"use fake module to fake data","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":2401,"context_line":"        mock_get_job.assert_called_once_with(fake_job_id)"},{"line_number":2402,"context_line":""},{"line_number":2403,"context_line":"    def test__migration_start_using_svm_migrate_exception(self):"},{"line_number":2404,"context_line":""},{"line_number":2405,"context_line":"        self.fake_src_share_server[\u0027share_network_subnet_id\u0027] \u003d \u0027fake_sns_id\u0027"},{"line_number":2406,"context_line":"        self.fake_dest_share_server[\u0027share_network_subnet_id\u0027] \u003d \u0027fake_sns_id\u0027"},{"line_number":2407,"context_line":"        node_name \u003d fake.CLUSTER_NODES[0]"},{"line_number":2408,"context_line":""},{"line_number":2409,"context_line":"        server_to_get_network_info \u003d self.fake_src_share_server"},{"line_number":2410,"context_line":""},{"line_number":2411,"context_line":"        segmentation_id \u003d ("},{"line_number":2412,"context_line":"            server_to_get_network_info[\u0027network_allocations\u0027][0]["},{"line_number":2413,"context_line":"                \u0027segmentation_id\u0027])"},{"line_number":2414,"context_line":""},{"line_number":2415,"context_line":"        network_info \u003d {"},{"line_number":2416,"context_line":"            \u0027network_allocations\u0027:"},{"line_number":2417,"context_line":"                server_to_get_network_info[\u0027network_allocations\u0027],"},{"line_number":2418,"context_line":"            \u0027neutron_subnet_id\u0027:"},{"line_number":2419,"context_line":"                server_to_get_network_info[\u0027share_network_subnet\u0027]["},{"line_number":2420,"context_line":"                    \u0027neutron_subnet_id\u0027]"},{"line_number":2421,"context_line":"        }"},{"line_number":2422,"context_line":"        ipspaces \u003d ["},{"line_number":2423,"context_line":"            {\u0027uuid\u0027: fake.IPSPACE_ID,"},{"line_number":2424,"context_line":"             \u0027ipspace\u0027: fake.IPSPACE}"},{"line_number":2425,"context_line":"        ]"},{"line_number":2426,"context_line":""},{"line_number":2427,"context_line":"        mock_list_cluster_nodes \u003d self.mock_object("},{"line_number":2428,"context_line":"            self.library._client, \u0027list_cluster_nodes\u0027,"},{"line_number":2429,"context_line":"            mock.Mock(return_value\u003dfake.CLUSTER_NODES))"}],"source_content_type":"text/x-python","patch_set":10,"id":"64d53f1e_b25e5949","line":2426,"range":{"start_line":2404,"start_character":0,"end_line":2426,"end_character":0},"in_reply_to":"52ce055f_d4247e1e","updated":"2021-08-28 21:57:50.000000000","message":"In this case this is being done for 90% of the statements marked... The only thing not using fakes would be the two first lines of the method, which are basically defining ids for the subnets...","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":2603,"context_line":"    @ddt.unpack"},{"line_number":2604,"context_line":"    def test_share_server_migration_continue_svm_migrate("},{"line_number":2605,"context_line":"            self, job_state, first_phase_completed):"},{"line_number":2606,"context_line":"        migration_id \u003d \u0027fake_migration_id\u0027"},{"line_number":2607,"context_line":"        fake_job \u003d {"},{"line_number":2608,"context_line":"            \u0027state\u0027: job_state"},{"line_number":2609,"context_line":"        }"},{"line_number":2610,"context_line":""},{"line_number":2611,"context_line":"        self.mock_object(self.library, \u0027_get_client_for_svm_migrate\u0027,"},{"line_number":2612,"context_line":"                         mock.Mock(return_value\u003dself.mock_dest_client))"},{"line_number":2613,"context_line":"        self.mock_object(self.mock_dest_client, \u0027svm_migration_get\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"43561095_90760b0a","line":2610,"range":{"start_line":2606,"start_character":6,"end_line":2610,"end_character":0},"updated":"2021-08-27 12:20:24.000000000","message":"use fake module to fake data","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":2603,"context_line":"    @ddt.unpack"},{"line_number":2604,"context_line":"    def test_share_server_migration_continue_svm_migrate("},{"line_number":2605,"context_line":"            self, job_state, first_phase_completed):"},{"line_number":2606,"context_line":"        migration_id \u003d \u0027fake_migration_id\u0027"},{"line_number":2607,"context_line":"        fake_job \u003d {"},{"line_number":2608,"context_line":"            \u0027state\u0027: job_state"},{"line_number":2609,"context_line":"        }"},{"line_number":2610,"context_line":""},{"line_number":2611,"context_line":"        self.mock_object(self.library, \u0027_get_client_for_svm_migrate\u0027,"},{"line_number":2612,"context_line":"                         mock.Mock(return_value\u003dself.mock_dest_client))"},{"line_number":2613,"context_line":"        self.mock_object(self.mock_dest_client, \u0027svm_migration_get\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"8b2cf919_1876aac8","line":2610,"range":{"start_line":2606,"start_character":6,"end_line":2610,"end_character":0},"in_reply_to":"43561095_90760b0a","updated":"2021-08-28 21:57:50.000000000","message":"Done","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":2889,"context_line":"    @ddt.data(True, False)"},{"line_number":2890,"context_line":"    def test__share_server_migration_complete_svm_migrate("},{"line_number":2891,"context_line":"            self, auto_source_cleanup):"},{"line_number":2892,"context_line":"        completion_status \u003d ("},{"line_number":2893,"context_line":"            \"ready_for_source_cleanup\""},{"line_number":2894,"context_line":"            if auto_source_cleanup is False else \"migrate_complete\")"},{"line_number":2895,"context_line":"        migration_id \u003d \u0027fake_migration_id\u0027"},{"line_number":2896,"context_line":"        fake_ongoing_migration \u003d {"},{"line_number":2897,"context_line":"            \u0027auto_source_cleanup\u0027: auto_source_cleanup"},{"line_number":2898,"context_line":"        }"},{"line_number":2899,"context_line":"        fake_complete_job_uuid \u003d \u0027fake_uuid\u0027"},{"line_number":2900,"context_line":"        fake_complete_job \u003d {"},{"line_number":2901,"context_line":"            \u0027job\u0027: {"},{"line_number":2902,"context_line":"                \u0027state\u0027: \u0027cutover_triggered\u0027,"},{"line_number":2903,"context_line":"                \u0027uuid\u0027: fake_complete_job_uuid"},{"line_number":2904,"context_line":"            }"},{"line_number":2905,"context_line":"        }"},{"line_number":2906,"context_line":"        self.mock_object(self.library, \u0027_get_client_for_svm_migrate\u0027,"},{"line_number":2907,"context_line":"                         mock.Mock(return_value\u003dself.mock_dest_client))"},{"line_number":2908,"context_line":"        self.mock_object(self.mock_dest_client, \u0027svm_migration_get\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"d4c1d817_8053ef75","line":2905,"range":{"start_line":2892,"start_character":3,"end_line":2905,"end_character":9},"updated":"2021-08-27 12:20:24.000000000","message":"use fake module to fake data","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":2889,"context_line":"    @ddt.data(True, False)"},{"line_number":2890,"context_line":"    def test__share_server_migration_complete_svm_migrate("},{"line_number":2891,"context_line":"            self, auto_source_cleanup):"},{"line_number":2892,"context_line":"        completion_status \u003d ("},{"line_number":2893,"context_line":"            \"ready_for_source_cleanup\""},{"line_number":2894,"context_line":"            if auto_source_cleanup is False else \"migrate_complete\")"},{"line_number":2895,"context_line":"        migration_id \u003d \u0027fake_migration_id\u0027"},{"line_number":2896,"context_line":"        fake_ongoing_migration \u003d {"},{"line_number":2897,"context_line":"            \u0027auto_source_cleanup\u0027: auto_source_cleanup"},{"line_number":2898,"context_line":"        }"},{"line_number":2899,"context_line":"        fake_complete_job_uuid \u003d \u0027fake_uuid\u0027"},{"line_number":2900,"context_line":"        fake_complete_job \u003d {"},{"line_number":2901,"context_line":"            \u0027job\u0027: {"},{"line_number":2902,"context_line":"                \u0027state\u0027: \u0027cutover_triggered\u0027,"},{"line_number":2903,"context_line":"                \u0027uuid\u0027: fake_complete_job_uuid"},{"line_number":2904,"context_line":"            }"},{"line_number":2905,"context_line":"        }"},{"line_number":2906,"context_line":"        self.mock_object(self.library, \u0027_get_client_for_svm_migrate\u0027,"},{"line_number":2907,"context_line":"                         mock.Mock(return_value\u003dself.mock_dest_client))"},{"line_number":2908,"context_line":"        self.mock_object(self.mock_dest_client, \u0027svm_migration_get\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"4d8f8a11_6115a568","line":2905,"range":{"start_line":2892,"start_character":3,"end_line":2905,"end_character":9},"in_reply_to":"d4c1d817_8053ef75","updated":"2021-08-28 21:57:50.000000000","message":"This will be better shaped in the next versions, since there will not be state validations and so on, so I can change this in the next PS","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":2988,"context_line":""},{"line_number":2989,"context_line":"    @ddt.data(True, False)"},{"line_number":2990,"context_line":"    def test__migration_cancel_using_svm_migrate(self, has_ipspace):"},{"line_number":2991,"context_line":"        pause_job_uuid \u003d \u0027fake_pause_job_id\u0027"},{"line_number":2992,"context_line":"        cancel_job_uuid \u003d \u0027fake_cancel_job_id\u0027"},{"line_number":2993,"context_line":"        ipspace_name \u003d \u0027fake_ipspace_name\u0027"},{"line_number":2994,"context_line":"        migration_id \u003d \u0027fake_migration_id\u0027"},{"line_number":2995,"context_line":"        pause_job \u003d {"},{"line_number":2996,"context_line":"            \u0027uuid\u0027: pause_job_uuid"},{"line_number":2997,"context_line":"        }"},{"line_number":2998,"context_line":"        cancel_job \u003d {"},{"line_number":2999,"context_line":"            \u0027uuid\u0027: cancel_job_uuid"},{"line_number":3000,"context_line":"        }"},{"line_number":3001,"context_line":"        migration_information \u003d {"},{"line_number":3002,"context_line":"            \"destination\": {"},{"line_number":3003,"context_line":"                \"ipspace\": {"},{"line_number":3004,"context_line":"                    \"name\": ipspace_name"},{"line_number":3005,"context_line":"                }"},{"line_number":3006,"context_line":"            }"},{"line_number":3007,"context_line":"        }"},{"line_number":3008,"context_line":""},{"line_number":3009,"context_line":"        if has_ipspace:"},{"line_number":3010,"context_line":"            migration_information[\"destination\"][\"ipspace\"][\"name\"] \u003d ("}],"source_content_type":"text/x-python","patch_set":10,"id":"dbb557cd_5c600ed3","line":3007,"range":{"start_line":2991,"start_character":1,"end_line":3007,"end_character":9},"updated":"2021-08-27 12:20:24.000000000","message":"use fake module to fake data","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":2988,"context_line":""},{"line_number":2989,"context_line":"    @ddt.data(True, False)"},{"line_number":2990,"context_line":"    def test__migration_cancel_using_svm_migrate(self, has_ipspace):"},{"line_number":2991,"context_line":"        pause_job_uuid \u003d \u0027fake_pause_job_id\u0027"},{"line_number":2992,"context_line":"        cancel_job_uuid \u003d \u0027fake_cancel_job_id\u0027"},{"line_number":2993,"context_line":"        ipspace_name \u003d \u0027fake_ipspace_name\u0027"},{"line_number":2994,"context_line":"        migration_id \u003d \u0027fake_migration_id\u0027"},{"line_number":2995,"context_line":"        pause_job \u003d {"},{"line_number":2996,"context_line":"            \u0027uuid\u0027: pause_job_uuid"},{"line_number":2997,"context_line":"        }"},{"line_number":2998,"context_line":"        cancel_job \u003d {"},{"line_number":2999,"context_line":"            \u0027uuid\u0027: cancel_job_uuid"},{"line_number":3000,"context_line":"        }"},{"line_number":3001,"context_line":"        migration_information \u003d {"},{"line_number":3002,"context_line":"            \"destination\": {"},{"line_number":3003,"context_line":"                \"ipspace\": {"},{"line_number":3004,"context_line":"                    \"name\": ipspace_name"},{"line_number":3005,"context_line":"                }"},{"line_number":3006,"context_line":"            }"},{"line_number":3007,"context_line":"        }"},{"line_number":3008,"context_line":""},{"line_number":3009,"context_line":"        if has_ipspace:"},{"line_number":3010,"context_line":"            migration_information[\"destination\"][\"ipspace\"][\"name\"] \u003d ("}],"source_content_type":"text/x-python","patch_set":10,"id":"052cc966_49af01ea","line":3007,"range":{"start_line":2991,"start_character":1,"end_line":3007,"end_character":9},"in_reply_to":"dbb557cd_5c600ed3","updated":"2021-08-28 21:57:50.000000000","message":"Ack","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6736d558d03f263e41620ac4490221b544ad3e49","unresolved":true,"context_lines":[{"line_number":3058,"context_line":"    @ddt.unpack"},{"line_number":3059,"context_line":"    def test__migration_cancel_using_svm_migrate_error("},{"line_number":3060,"context_line":"            self, mock_pause, mock_cancel):"},{"line_number":3061,"context_line":"        pause_job_uuid \u003d \u0027fake_pause_job_id\u0027"},{"line_number":3062,"context_line":"        cancel_job_uuid \u003d \u0027fake_cancel_job_id\u0027"},{"line_number":3063,"context_line":"        migration_id \u003d \u0027fake_migration_id\u0027"},{"line_number":3064,"context_line":"        migration_information \u003d {"},{"line_number":3065,"context_line":"            \"destination\": {"},{"line_number":3066,"context_line":"                \"ipspace\": {"},{"line_number":3067,"context_line":"                    \"name\": \"ipspace_name\""},{"line_number":3068,"context_line":"                }"},{"line_number":3069,"context_line":"            }"},{"line_number":3070,"context_line":"        }"},{"line_number":3071,"context_line":""},{"line_number":3072,"context_line":"        self.mock_object(self.library, \u0027_get_job_uuid\u0027,"},{"line_number":3073,"context_line":"                         mock.Mock("}],"source_content_type":"text/x-python","patch_set":10,"id":"e47de75f_b008e1a8","line":3070,"range":{"start_line":3061,"start_character":0,"end_line":3070,"end_character":9},"updated":"2021-08-27 12:20:24.000000000","message":"use fake module to fake data","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96d9524e27cace2a13ebdfff22c24c0356b26fdc","unresolved":false,"context_lines":[{"line_number":3058,"context_line":"    @ddt.unpack"},{"line_number":3059,"context_line":"    def test__migration_cancel_using_svm_migrate_error("},{"line_number":3060,"context_line":"            self, mock_pause, mock_cancel):"},{"line_number":3061,"context_line":"        pause_job_uuid \u003d \u0027fake_pause_job_id\u0027"},{"line_number":3062,"context_line":"        cancel_job_uuid \u003d \u0027fake_cancel_job_id\u0027"},{"line_number":3063,"context_line":"        migration_id \u003d \u0027fake_migration_id\u0027"},{"line_number":3064,"context_line":"        migration_information \u003d {"},{"line_number":3065,"context_line":"            \"destination\": {"},{"line_number":3066,"context_line":"                \"ipspace\": {"},{"line_number":3067,"context_line":"                    \"name\": \"ipspace_name\""},{"line_number":3068,"context_line":"                }"},{"line_number":3069,"context_line":"            }"},{"line_number":3070,"context_line":"        }"},{"line_number":3071,"context_line":""},{"line_number":3072,"context_line":"        self.mock_object(self.library, \u0027_get_job_uuid\u0027,"},{"line_number":3073,"context_line":"                         mock.Mock("}],"source_content_type":"text/x-python","patch_set":10,"id":"dd209f6d_8f7396e8","line":3070,"range":{"start_line":3061,"start_character":0,"end_line":3070,"end_character":9},"in_reply_to":"e47de75f_b008e1a8","updated":"2021-08-28 21:57:50.000000000","message":"Ack","commit_id":"b0d04fa31d74ca8e8c32c5bc38c9e9f948325687"}]}