)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"821ce87ae6bdbbc1e13a0af6b973f21cb3bb000c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"00d57791_2f0f10ef","updated":"2022-02-21 18:51:00.000000000","message":"Hi Gotham, I just added a response regarding the manual validation for this patch. After merging this on ussuri, we still need to make a backport to train, but, if I\u0027m not wrong, it will be a clean cherry pick. If you need more info, just let me know. Thanks!","commit_id":"ca40f7c80473e062baad4b927d9bc90cbac32d8c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aea32ca3e23aa9f3a816e820d189ff4597f0186d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fc8d06f3_687874d7","updated":"2021-12-08 20:40:42.000000000","message":"Hi Nahim, \n\nI see that this isn\u0027t a clean cherry-pick - the code lgtm... can you have the NetApp CI voting and some NetApp reviewers reviewing this change?","commit_id":"ca40f7c80473e062baad4b927d9bc90cbac32d8c"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"2e758d0aadc7eeeeb1cb0b204c2094343786fff1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7b295595_dfe18bc1","updated":"2021-12-10 14:08:34.000000000","message":"Hi, Goutham, I addressed your comment below. Please take a look and let me know if you agree. Thanks!","commit_id":"ca40f7c80473e062baad4b927d9bc90cbac32d8c"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"463638121f9d5f63c1d3a0d4740cb665618e5490","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4fe8f39e_0e1b2cdf","updated":"2022-01-09 18:34:11.000000000","message":"LGTM","commit_id":"ca40f7c80473e062baad4b927d9bc90cbac32d8c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"da5c82f3fa7e2c1e569ab7bbe46027374c704b22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e11f3c21_fae7b4f7","updated":"2022-01-25 17:31:24.000000000","message":"LGTM... Thanks for back porting\n","commit_id":"ca40f7c80473e062baad4b927d9bc90cbac32d8c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"05f7382ff202ff0bc67cc3f0d496fefe2ec0af3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9e79bc84_24134313","updated":"2022-01-24 23:51:32.000000000","message":"Nahim, can you confirm again that the NetApp-CI is okay to bypass?","commit_id":"ca40f7c80473e062baad4b927d9bc90cbac32d8c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"856d0ab6b3c2eca384bb722b6d4996eb4ed3e61d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"572dcfcb_245452e0","updated":"2021-12-08 20:37:50.000000000","message":"run-NetApp CI","commit_id":"ca40f7c80473e062baad4b927d9bc90cbac32d8c"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"a904897db35f4220f91c4197d250230ae98d0dff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f9fa5b19_18727235","updated":"2021-12-13 13:15:12.000000000","message":"run-NetApp CI","commit_id":"ca40f7c80473e062baad4b927d9bc90cbac32d8c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"09375686c2d32efa20d38e9432b27012b4cb4223","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"66f4adea_c6248bb7","in_reply_to":"0ca553d6_819eeb12","updated":"2022-02-21 19:08:43.000000000","message":"When it merges, please propose the stable/train backport :)","commit_id":"ca40f7c80473e062baad4b927d9bc90cbac32d8c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6f9e91bbfff5d4dbeb789d9506234a7d3e39d336","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e8dedba5_ee6fbfb6","in_reply_to":"2f1207b6_90645978","updated":"2021-12-11 01:37:32.000000000","message":"Hey Nahim, \n\nWe should have a discussion about this with the wider team; Is your team\u0027s concern mainly about keeping the CI running for these older branches? I\u0027ve always encouraged a proactive backport approach - i.e., not waiting for users to hit the issues, but if you\u0027re aware that a bug exists in a prior branch, fix it and make the releases happen. We\u0027ve been quite successful in keeping deployers/users happy with this approach over the past years. In part, this is successful because of the participation of driver maintainers like yourself - you do the hard work of proposing/qualifying these backports. We maintain the upstream CI for older branches with best effort because we\u0027d like to keep these bugfixes flowing. This process has also made it possible for package maintainers and distributions (like Red Hat) to rely on upstream to land the backports so they can flow seamlessly to their distributions. For example, unless this fix is in stable/train, it will not make it to Red Hat\u0027s users/deployers of OSP 16, 16.1 or 16.2. \n\nDownstream distributions also have a set release cadence. They ship updated packages in intervals spanning a few months - so, if we wait for a user/deployer to report this issue, it causes more pain since they may have to wait for that much longer for upstream to qualify it, and for downstream distributions to patch it, and eventually for them to ship it.\n\nWe\u0027ve had discussions about this topic at PTGs and Summits in the past and have concluded that CI infrastructure cannot/shouldn\u0027t be the bottleneck here. If a breakage is insurmountable, we\u0027d have to weigh the risks - would it be possible to do a manual qualification and still get the fix in?","commit_id":"ca40f7c80473e062baad4b927d9bc90cbac32d8c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ca8a18279dcf7c92c56c69e7b966304c9aecef0b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0ca553d6_819eeb12","in_reply_to":"435e7b0e_9e50050a","updated":"2022-02-21 19:08:07.000000000","message":"Thanks Nahim, i\u0027ll workflow this now..","commit_id":"ca40f7c80473e062baad4b927d9bc90cbac32d8c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4572104d525db6cbd3a06c5b8bb3a1db47e6d1c5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6521fd3f_add08906","in_reply_to":"47e51ff7_81f5f9b2","updated":"2021-12-16 01:49:24.000000000","message":"\u003e I had done a manual validation when I opened this patch, so if for some reason the CI does not work, we can also try that approach.\n\nTotally okay with that, thanks Nahim!","commit_id":"ca40f7c80473e062baad4b927d9bc90cbac32d8c"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"821ce87ae6bdbbc1e13a0af6b973f21cb3bb000c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"435e7b0e_9e50050a","in_reply_to":"6521fd3f_add08906","updated":"2022-02-21 18:51:00.000000000","message":"Hi Goutham, sorry for the late reply. I saw that you already approved this patch, but just to answer you about this, we were not able to make our CI run on this patch, but I did a manual validation to ensure the bug was fixed.\n\nHere are the logs:\n\n[1] Failure on stable/ussuri: https://paste.opendev.org/show/b4eSdPFD0vusHFNWCmCo/ \n\n[2] Bug fixed after applying the patch: https://paste.opendev.org/show/bkGWWWzLipSvY8QuLHyz/\n\nHope this helps. \nThanks!","commit_id":"ca40f7c80473e062baad4b927d9bc90cbac32d8c"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"c09234201f7eeabb8dc9d4ff833fa3f7299ba2a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"16133f08_714a022e","in_reply_to":"66f4adea_c6248bb7","updated":"2022-02-22 10:52:13.000000000","message":"Done","commit_id":"ca40f7c80473e062baad4b927d9bc90cbac32d8c"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"98e31e3a973b969e170fa09f22d14c2f10f86e23","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"47e51ff7_81f5f9b2","in_reply_to":"e8dedba5_ee6fbfb6","updated":"2021-12-15 19:43:55.000000000","message":"Hi, Goutham, thank you for the explanation.\n\nYou are correct, our main concern is the effort we need to keep the CI running on the older branches. Some time ago, we started working on that, but we had some problems and I\u0027m not sure how long it will take us to find a solution for them. \n\nAnyway, I understand your points and I agree with you. It\u0027s better to have a proactive backport approach (for this patch and others) to avoid problems in the future. I\u0027ll work to fix the NetApp CI issues in older branches to get this patch merged.\n\nI had done a manual validation when I opened this patch, so if for some reason the CI does not work, we can also try that approach.","commit_id":"ca40f7c80473e062baad4b927d9bc90cbac32d8c"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"2e758d0aadc7eeeeb1cb0b204c2094343786fff1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2f1207b6_90645978","in_reply_to":"fc8d06f3_687874d7","updated":"2021-12-10 14:08:34.000000000","message":"Hi, Goutham, thanks for the review! \n\nAfter I submitted this patch we had an internal discussion about the backporting of bugfixes. NetApp understands that it is better not to spend too much time in backports unless some customer had hit the bug.\n\nCurrently, our CI is not working for the stable/ussuri branch, and we would need some time to fix that. Since this bug was not reported by any customer and we already did the backport for victoria and wallaby, we understand that it would be better to abandon this patch and do not make the backport.\n\nPerhaps we should have raised this question before, but we forgot about this patch, sorry for that.\n\nDo you have any concern about this approach?","commit_id":"ca40f7c80473e062baad4b927d9bc90cbac32d8c"}]}